- 08 Sep, 2016 40 commits
-
-
xlai authored
This CL enables sending compositor frame from OffscreenCanvas on worker to browser. It also makes commit() throws InvalidStateError when user call the function without calling transferControlToOffscreen. Two layout tests are added. TBR=tsepez@chromium.org BUG=563858 Review-Url: https://codereview.chromium.org/2318383002 Cr-Commit-Position: refs/heads/master@{#417407}
-
dtapuska authored
BUG=626101 Review-Url: https://codereview.chromium.org/2322073002 Cr-Commit-Position: refs/heads/master@{#417406}
-
derat authored
Make dbus::ObjectManager automatically fetch managed objects after the remote service becomes available. Also remove Bus::GetManagedObjects(), which produces a large amount of log spam due to some services not yet being ready. (It was called by chromeos::DBusThreadManager and bluez::BluezDBusManager at startup.) BUG=636554 Review-Url: https://codereview.chromium.org/2239123002 Cr-Commit-Position: refs/heads/master@{#417405}
-
iannucci authored
build: https://crrev.com/8eaa27680015cf0fdd5349a568229350f83a0c9f Roll recipe dependencies (nontrivial). (recipe-roller@chromium.org) depot_tools: https://crrev.com/1332f33d42e1a08f4acfb69f4707001ffeaf8ea9 Roll recipe dependencies (trivial). (recipe-roller@chromium.org) https://crrev.com/990ab1b42c1f347686a509aade4303289f779902 Remove force parameter from bot_update.ensure_checkout. (iannucci@chromium.org) https://crrev.com/16e7f097a7ab958c843fcc989856a47b842eb3d9 Remove bogus master/builder/slave parameters from bot_update. (iannucci@chromium.org) https://crrev.com/92ded3f29204ce9c900f9227be4f713dc18e251c Roll recipe dependencies (trivial). (recipe-roller@chromium.org) https://crrev.com/0abcd2640ae3c36165fbbc7531571a0a22294243 Fix typobug in bot_update.py. (iannucci@chromium.org) recipe_engine: https://crrev.com/4b3ff6014bcb018aff9ae2755faf47cc304f47af Track step nesting in StreamEngine. (dnj@chromium.org) https://crrev.com/339eace18cba35868b8bbb039100448fbfc58d15 Revert of Track step nesting in StreamEngine. (patchset #5 id:80001 of https://codereview.chromium.org/2245113002/ ) (dnj@chromium.org) R=agable@chromium.org, estaab@chromium.org, hinoka@chromium.org, martiniss@chromium.org BUG=643885 Review-Url: https://codereview.chromium.org/2327603002 Cr-Commit-Position: refs/heads/master@{#417404}
-
sdefresne authored
Pass required flags "-rpath @executable/Frameworks" when linking executable to point to the location where the custom frameworks are located in iOS builds. Pass flags "-objc_abi_version 2" to linker flag for execuable and dynamic libraries as is done by Xcode and remove one intermediate config object (unnecessary). BUG=None Review-Url: https://codereview.chromium.org/2326543003 Cr-Commit-Position: refs/heads/master@{#417403}
-
estade authored
BUG=626786 Review-Url: https://codereview.chromium.org/2316183003 Cr-Commit-Position: refs/heads/master@{#417402}
-
pdfium-deps-roller authored
https://pdfium.googlesource.com/pdfium.git/+log/a31da74cffa8..c29fc707b24b $ git log a31da74cf..c29fc707b --date=short --no-merges --format='%ad %ae %s' 2016-09-08 weili Fix memory management errors for font loading and copying TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2324933002 Cr-Commit-Position: refs/heads/master@{#417401}
-
pdr authored
SVGImageForContainer is confusing and needs better documentation. This patch adds a class-level comment in SVGImageForContainer.h that describes the dimension and fragment url quirks that require this class. BUG=644913 NOTRY=true Review-Url: https://codereview.chromium.org/2322803002 Cr-Commit-Position: refs/heads/master@{#417400}
-
sunyunjia authored
The previous solution at https://codereview.chromium.org/2316113003/ does not check all the frames for nullptr. This patch solves the problem in a more clean and thorough way. BUG=361036 Review-Url: https://codereview.chromium.org/2322013002 Cr-Commit-Position: refs/heads/master@{#417399}
-
erikchen authored
There are two types of EventListeners: those with web_view_instance_id and those without. EventListeners with a web_view_instance_id need to always consider embedder_process_id for equality comparisons. EventListeners without a web_view_instance_id should sometimes ignore embedder_process_id (when being removed) for equality comparisons. The previous code had two major issues: 1) EventListeners were stored in a std::set. std:set requires a stable sort operator. There is no way to create a stable sort operator that sometimes ignores embedder_process_id. Aside: std::set is almost never the right container to use from a performance perspective. In this case, the code frequently needs to iterate through the entire container away, so I've changed the container to be a std::vector (we expect the total number of elements to be small). If we find performance issues, we should switch to std::unordered_set. 2) EventListeners need to be messaged asynchronously, but it's possible that the EventListener is no longer registered by the time the callback comes around. The previous code would make a copy of the EventListener, and then try to "find" the original copy in the callback. Once again, this requires clear semantics for equality. The new code makes several changes: 1) Create the class EventListener::ID. As its name implies, this uniquely identifies an EventListener. 2) Disallow copy and assignment of EventListeners. The only use case is async identity checking, which should use EventListener::ID instead. 3) This cleanup means EventListener::blocked_requests no longer has to be mutable. (A clear sign that something was wrong with the previous scheme). The most important result is that it is no longer possible to have identity confusion between EventListeners, as all comparisons use EventListener::ID. This was the root cause of the leak from Issue 643025. BUG=643025, 641958 Review-Url: https://codereview.chromium.org/2303113002 Cr-Commit-Position: refs/heads/master@{#417398}
-
cwallez authored
The origins of this workaround go waaaaay in the past and seem to contradict themselves (only OSX, vs. not OSX) BUG=590870 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2326713002 Cr-Commit-Position: refs/heads/master@{#417397}
-
dcheng authored
This overload is deprecated: prefer the std::unique_ptr<Value> version, which helps the compiler enforce that ownership transfer occurs. BUG=581865 R=danakj@chromium.org TBR=brettw@chromium.org Review-Url: https://codereview.chromium.org/2285933003 Cr-Commit-Position: refs/heads/master@{#417396}
-
lpy authored
This patch re-enables js/mozilla/strict/13.1.html and fixes lexical redeclaration of arguments. BUG=v8:4577 Review-Url: https://codereview.chromium.org/2318933007 Cr-Commit-Position: refs/heads/master@{#417395}
-
pdr authored
This patch sets the device scale factor on cc's root transform node, fixing several layout tests. This approach is different from how cc builds property trees (see post_local_scale_factor in property_tree_builder's AddTransformNodeIfNeeded) where a post_local transform is used, but aligns closer to blink's approach of using a single transform per transform node. This approach is temporary and will need to be refactored when we begin supporting viewport transforms such as pinch-zoom. BUG=642240 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2318933006 Cr-Commit-Position: refs/heads/master@{#417394}
-
Daniel Murphy authored
This reverts commit 9cdba144. https://codereview.chromium.org/2308153002/ BUG=645177,645181 TBR=qyearsley Previous commit message: Import wpt@65954a35b4e0a5cee1f4839271ba0e44f187c0a6 Using update-w3c-deps in Chromium c7eb73ac. Review URL: https://codereview.chromium.org/2323113002 . Committed: https://crrev.com/9cdba1441437ab946977a224cc45971cfadd8abb Cr-Original-Commit-Position: refs/heads/master@{#417302} Cr-Commit-Position: refs/heads/master@{#417393}
-
justincohen authored
This is the same as the previous toolchain (Xcode 5.1.1 with 10.10 SDK), but also includes the 10.11 SDK. BUG=474373, 626093 Review-Url: https://codereview.chromium.org/2323523003 Cr-Commit-Position: refs/heads/master@{#417392}
-
lushnikov authored
Reland of [Fetch API] Start reading blob only when the reader wants to read contents. (patchset #1 id:1 of https://codereview.chromium.org/2319093004/ ) Reason for revert: With the revert in place, the Linux MSAN is still failing: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20MSAN/builds/12113 This proofs this patch to be innocent. Original issue's description: > Revert of [Fetch API] Start reading blob only when the reader wants to read contents. (patchset #3 id:40001 of https://codereview.chromium.org/2303753003/ ) > > Reason for revert: > Speculative revert: this patch is a suspect to cause Linux MSAN failures: > > https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20MSAN/builds/12091 > > The other suspected patch, the only one related to canvas, was reverted and didn't help. > > Original issue's description: > > [Fetch API] Start reading blob only when the reader wants to read contents. > > > > BUG=643174 > > > > Committed: https://crrev.com/f1ca96c413912ff1768e4274b8b7ac78eb41de64 > > Cr-Commit-Position: refs/heads/master@{#416923} > > TBR=hiroshige@chromium.org,jkarlin@chromium.org,yhirano@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=643174 > > Committed: https://crrev.com/2cbd2420c74783570442264a3e9a1c76cc42152e > Cr-Commit-Position: refs/heads/master@{#417338} TBR=hiroshige@chromium.org,jkarlin@chromium.org,yhirano@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=643174 Review-Url: https://codereview.chromium.org/2327583002 Cr-Commit-Position: refs/heads/master@{#417391}
-
geofflang authored
https://chromium.googlesource.com/angle/angle.git/+log/9df01f8..c955058 BUG= TBR=jmadill@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2320863003 Cr-Commit-Position: refs/heads/master@{#417390}
-
mvanouwerkerk authored
BUG=641412 Review-Url: https://codereview.chromium.org/2321063003 Cr-Commit-Position: refs/heads/master@{#417389}
-
fdoray authored
SequencedWorkerPool is being migrated to base/task_scheduler and there is no equivalent to IsRunningSequenceOnCurrentThread() in base/task_scheduler. Developers should use SequenceChecker to verify that tasks run sequentially. Unlike SequencedWorkerPool::IsRunningSequenceOnCurrentThread(), SequenceChecker works everywhere in Chrome (MessageLoop, SequencedWorkerPool, base/task_scheduler...). BUG=622400 Review-Url: https://codereview.chromium.org/2318123002 Cr-Commit-Position: refs/heads/master@{#417388}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/8917fb02c5d6..2c67e5988500 $ git log 8917fb02c..2c67e5988 --date=short --no-merges --format='%ad %ae %s' 2016-09-08 benjhayden Disable Show all in value-set-table when all values are source values. 2016-09-08 benjhayden Move value/time_display_mode.html to base/time_display_modes.html 2016-09-08 benjhayden Linkify url strings in generic-object-view. TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2320233002 Cr-Commit-Position: refs/heads/master@{#417387}
-
rego authored
The grid-column-gap and grid-row-gap allow now percentage as one of the possible values. This patch adds the required support for both parsing and layout logic. This is based on a patch by Javier Fernández http://crrev.com/2057113002/. However it uses a different approach to compute the percentage gaps based on the sizing operation. During intrinsic size phase the percentage gaps are considered 0px. Also for indefinite heights the percentage row gaps are 0px too. BUG=615248 TEST=fast/css-grid-layout/grid-gutters-as-percentage.html Review-Url: https://codereview.chromium.org/2323793002 Cr-Commit-Position: refs/heads/master@{#417386}
-
mgersh authored
The comment on connect_start and connect_end incorrectly stated that DNS lookup time is included in connect time. The comment above about order of events has the correct order. Review-Url: https://codereview.chromium.org/2326693002 Cr-Commit-Position: refs/heads/master@{#417385}
-
ethannicholas authored
Review-Url: https://codereview.chromium.org/2322673003 Cr-Commit-Position: refs/heads/master@{#417384}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a12446e2..0cb5bdd1 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2324493004 Cr-Commit-Position: refs/heads/master@{#417383}
-
wychen authored
BUG=408658 Review-Url: https://codereview.chromium.org/2212663003 Cr-Commit-Position: refs/heads/master@{#417382}
-
forshaw authored
This CL implements a new method of getting the base address of a new process. It's not clear if the old method of using the thread context is reliable in the face of third party software, so this implementation instead uses only documented functionality to acheive the same thing. BUG=645050 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng Review-Url: https://codereview.chromium.org/2323443003 Cr-Commit-Position: refs/heads/master@{#417381}
-
jmadill authored
The multisample test seems to be passing on new AMD. Also there is an NVIDIA test that still seems to fail. BUG=617290 TBR=kbr@chromium.org,zmo@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2320173002 Cr-Commit-Position: refs/heads/master@{#417380}
-
sataya.m authored
Review-Url: https://codereview.chromium.org/2316233003 Cr-Commit-Position: refs/heads/master@{#417379}
-
mikecase authored
This benchmark is almost identical to the existing WebView startup benchmark, but with the --webview-sandboxed-renderer flag set. Setting the pageset_repeat option for the WebView start-up benchmarks. May make metric more stable to smooth out WebView loading from a cold start vs. WebView being already loaded into Android's memory. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Review-Url: https://codereview.chromium.org/2307873003 Cr-Commit-Position: refs/heads/master@{#417378}
-
geofflang authored
BUG=602688 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2319373004 Cr-Commit-Position: refs/heads/master@{#417377}
-
takumif authored
When a tab that a dialog controller is associated with gets moved to another window, we need to allow the dialog controller to update its reference to the toolbar action (associated with a window). This fixes the bug in which the icon gets pressed in a wrong window. The comment for SetMediaRouterAction() is also updated, as it is okay for the action to be null, and we expect it to become null when it gets removed from the toolbar. BUG=644972 Review-Url: https://codereview.chromium.org/2321163002 Cr-Commit-Position: refs/heads/master@{#417376}
-
pdfium-deps-roller authored
https://pdfium.googlesource.com/pdfium.git/+log/d827111fb10c..a31da74cffa8 $ git log d827111fb..a31da74cf --date=short --no-merges --format='%ad %ae %s' 2016-09-08 tsepez Pass CFX_WideString further down widget callers 2016-09-08 tsepez Remove unused context parameter from JSGetStringFromID 2016-09-08 tsepez Replace CJS_Runtime::Observer with CFX_Runtime<CJS_Runtime>::Observer TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2326683002 Cr-Commit-Position: refs/heads/master@{#417375}
-
jmadill authored
ANGLE still uses GYP for a standalone build. Until we switch to full GN (not currently being worked on) we need this script for all of our build files. BUG=605987 Review-Url: https://codereview.chromium.org/2320743002 Cr-Commit-Position: refs/heads/master@{#417374}
-
scottmg authored
Expose NavigateAndCommitRendererInitiated in TestRendererHost, use it to fix download request limiter test for renderer-initiated case in PlzNavigate. R=clamy@chromium.org, dominickn@chromium.org BUG=510836 Review-Url: https://codereview.chromium.org/2319733002 Cr-Commit-Position: refs/heads/master@{#417373}
-
catmullings authored
Keeps track of scripts injected by extensions installed. Checks if a script is already injected, and injects a script only if it has not been injected. BUG=248627, 631247 TEST= Run target browser_tests with --gtest_filter="ExtensionApiTest.ContentScript*" Committed: https://crrev.com/90d8dd145246616da02f5a54f1da1f5bfe6680e9 Review-Url: https://codereview.chromium.org/2213603002 Cr-Original-Commit-Position: refs/heads/master@{#407016} Cr-Commit-Position: refs/heads/master@{#417372}
-
pfeldman authored
BUG= Review-Url: https://codereview.chromium.org/2320003002 Cr-Commit-Position: refs/heads/master@{#417371}
-
dfalcantara authored
Discussion resulted in zero-ish cases where this would be useful. BUG=644848 Review-Url: https://codereview.chromium.org/2328703002 Cr-Commit-Position: refs/heads/master@{#417370}
-
johnme authored
BUG=644050 Review-Url: https://codereview.chromium.org/2316303004 Cr-Commit-Position: refs/heads/master@{#417369}
-
erikchen authored
This CL removes the implementation of -[TabView mouseUp:] which should never be called, since -[TabView mouseDown:] always triggers a nested run loop that swallows the -[TabView mouseUp:] event. There's an AppKit bug that -[TabView mouseUp:] on inappropriate views, so it's doubly important that the implementation not do anything. BUG=511095 Review-Url: https://codereview.chromium.org/2314873004 Cr-Commit-Position: refs/heads/master@{#417368}
-