- 27 Aug, 2018 40 commits
-
-
Chris Harrelson authored
This was a mistake in commit 1fde0aa3. Bug: 873883 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia48ad8ddc5d63225ccca1a2b8d6f26920de605a5 Reviewed-on: https://chromium-review.googlesource.com/1190923Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#586332}
-
John Abd-El-Malek authored
This reverts commit 268fcfac. Broke http/tests/devtools/service-workers/service-workers-redundant.js http/tests/devtools/service-workers/service-workers-view.js with network service See https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mojo%20Linux/17958 You can reproduce this locally via --additional-driver-flag=--enable-features=NetworkService Original change's description: > DevTools: Show scriptResponseTime for ServiceWorker only if present > > As per the browser protocol, the field scriptResponseTime is > optional. Hence adding a check to see if it present before > displaying it. > > Bug: 767790 > Change-Id: I2638328aeec901419e48977ba40a15971da43f8b > Reviewed-on: https://chromium-review.googlesource.com/1180623 > Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#586048} TBR=dgozman@chromium.org,lushnikov@chromium.org,pfeldman@chromium.org,gautham.bangalore@gmail.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 767790 Change-Id: Idd1be72fe1bd5325263b8d46137edc07d70a4d22 Reviewed-on: https://chromium-review.googlesource.com/1191062Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#586331}
-
Jorge Lucangeli Obes authored
It's hard to be sure that the different permissions are correct without documentation of what the parameters mean. BUG=None TEST=Compiles. Change-Id: If11e34593c38ae66b65e8b9ede8fb3198a03967e Reviewed-on: https://chromium-review.googlesource.com/1186982Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Jorge Lucangeli Obes <jorgelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#586330}
-
Theresa authored
This is no longer used and hasn't been for a while. If it's needed in the future, we can add it back. BUG=765306 Change-Id: I34992be49776f1f97de432bece0070c53ae9df9c Reviewed-on: https://chromium-review.googlesource.com/1184273Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#586329}
-
Victor Costan authored
Change-Id: Id9766b693c33aabadf9265722cf32605378c06a1 Reviewed-on: https://chromium-review.googlesource.com/1191023 Commit-Queue: Victor Costan <pwnall@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#586328}
-
Drew Davenport authored
In libdrm 2.4.93, realpath() is called on the path under /sys/dev/char/.. which resolves to at path under /sys/devices/..., so we need to add /sys/devices/... recursively as well as allow stat() for all intermediate directories. Bug=b:112486795 Test=boot and login successfully on grunt Change-Id: I4cf704ed217830b224398314a3e51b5c0d6bd17c Reviewed-on: https://chromium-review.googlesource.com/1184041Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Drew Davenport <ddavenport@chromium.org> Cr-Commit-Position: refs/heads/master@{#586327}
-
Alexis Hetu authored
Now that SwiftShader has replaced OSMesa, we can remove all OSMesa specific workarounds in chromium. Bug: chromium:873321 chromium:174845 chromium:348350 chromium:347967 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I12fe2de6f7ea963ca9ebeeee1f35cd54e4cbecd0 Reviewed-on: https://chromium-review.googlesource.com/1175450Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#586326}
-
Kurt Horimoto authored
This CL updates CRWWebViewProxy.shouldUseViewContentInset to be accurate for the smooth scrolling experiment. Bug: none Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I19036cc253ed52f99de5fc51949f96f8feabcd4c Reviewed-on: https://chromium-review.googlesource.com/1176965Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#586325}
-
Fredrik Hubinette authored
Also makes some preparations for doing the same for VP9. Bug: 647725, 847573 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Id263a35b9f53be062ebae54d05c603a3efb270e8 Reviewed-on: https://chromium-review.googlesource.com/1153840 Commit-Queue: Fredrik Hubinette <hubbe@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#586324}
-
Evan Stade authored
This keeps the immersive reveal going when bubbles anchored to the top container (like the bookmark bubble) are open, when focus in in the top container, or when transient children (like the bookmark editor) are open. ImmersiveFocusWatcherMus is largely copied from ImmersiveFocusWatcherClassic, but 1. uses aura::client::TransientWindowClient instead of ::wm::TransientWindowManager 2. uses WindowTreeClient::FocusSynchronizer instead of ::wm::GetActivationClient 3. Appends |->GetRootWindow()| in a couple places. Bug: 640365 Change-Id: I46cd0c3d66808d726fea484ff13ceea53dcabd5c Reviewed-on: https://chromium-review.googlesource.com/1187708 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#586323}
-
Jinho Bang authored
If requestShipping is false, we should not perform the shipping address editor even if calling retry() with shippingAddressErrors. Similarly, if none of requestPayer* options is true, we should not perform the contact info editor even if calling retry() with payerErrors. Test: chrome/browser/ui/views/payments/contact_info_editor_view_controller_browsertest.cc chrome/browser/ui/views/payments/shipping_address_editor_view_controller_browsertest.cc components/payments/content/payment_request_spec_unittest.cc Bug: 861704 Change-Id: Id388758617820d9766b0557d0f19670b1044c66e Reviewed-on: https://chromium-review.googlesource.com/1189245Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#586322}
-
Jaewon Choi authored
This patch replaces erase(std::remove_if()) to base::EraseIf() for simplicity. Bug: 875665 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib2e310f38eae8917445cd62b57a1ffb9d873f8cc Reviewed-on: https://chromium-review.googlesource.com/1181016Reviewed-by:
-
Ryan Cui authored
The plan is to monitor the tests for flakiness before moving them to the main chromium waterfall. Bug: 874090 Change-Id: I2c0bddd189c89b5485d0e14a90afbf0eb5ac0e44 Reviewed-on: https://chromium-review.googlesource.com/1185637 Commit-Queue: Ryan Cui <rcui@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#586320}
-
Vladimir Levin authored
This patch adds overflow to column fragment clips, since content should be able to overflow the column. This is a recent spec change, listed under https://www.w3.org/TR/css-multicol-1/#changes-from-20110412 Previously, we were required to clip the way we used to see https://www.w3.org/TR/2011/CR-css3-multicol-20110412/#overflow-inside-multicol-elements This patch aligns us with the new behavior. R=chrishtr@chromium.org Bug: 874124 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I18399eed397482a13955bc5687c12560aa37fb38 Reviewed-on: https://chromium-review.googlesource.com/1175101 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#586319}
-
Christian Biesinger authored
When we do have percentage descendants, we need to force an extra layout when applying stretch alignment, because the flexbox height is now definite (per https://drafts.csswg.org/css-flexbox/#algo-stretch) LayoutNG never set the "has percentage descendants" flag, so we could not skip this extra layout when there are none. We instead had a different optimization that addresses the case where the height was already definite. This patch makes it so that NG does set the flag and makes flexbox use this optimization in NG as well. This has the nice side effect of fixing two tests, in addition to the performance improvement, because we now correctly handle the case of legacy flexbox -> legacy flexbox -> NG block -> NG percentage sized, where the outer flexbox now knows it needs to redo layout in this case (see crbug.com/876459 for more details) Performance improvements according to https://pinpoint-dot-chromeperf.appspot.com/job/15b736ee640000: flexbox-lots-of-data +43.9% flexbox-with-stretch-layout +851.2% Bug: 875147,876459 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I535f0c62993f4cdc03f15cdf91efe300989e43b2 Reviewed-on: https://chromium-review.googlesource.com/1190246 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#586318}
-
Victor Costan authored
Change-Id: I2899516b99f6291876321dd0d4d15a269990d889 Reviewed-on: https://chromium-review.googlesource.com/1189170Reviewed-by:
-
Mohsen Izadi authored
These tests were disabled when both Viz display compisitor and site-per-process are enabled. The issue seems to be fixed as a side-effect of r584677. BUG=869613 Change-Id: I9ba7c48027da705b8f8056ebf9acb96b857b1b8c Reviewed-on: https://chromium-review.googlesource.com/1188695Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#586316}
-
Chromium WPT Sync authored
Using wpt-import in Chromium cefbc054. With Chromium commits locally applied on WPT: 736345b4 "Fix fast/table/column-in-inline.html not to rely on wrong behavior" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23501 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: Iff95d8b8734360bdfcb9e01cb6b5e289826c0e93 Reviewed-on: https://chromium-review.googlesource.com/1190642 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#586315}
-
Hongchan Choi authored
To clarify the life cycle of backing thread in AudioWorkletThread, now WorkletThreadHolder<AudioWorkletThread> owns the thread in a form of WebThreadSupportingGC. By doing so, this CL removes a static singleton WebThread instance from AudioWorkletThread class. Bug: 870678 Test: All existing AudioWorklet tests (layout, unit) passes. Change-Id: I4b9a0a2daebbead53604fbee4dda8052fe09cd37 Reviewed-on: https://chromium-review.googlesource.com/1185740 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#586314}
-
Karan Bhatia authored
This CL makes some fixes to the subresource filter presubmit script: - Don't take files in url_pattern_index component into account. input_api.AffectedFiles() only returns affected files in the PRESUBMIT directory. - Fix typo in new_indexed_ruleset_version computation which currently leads to an exception. BUG=877214 Change-Id: I11a71be5747201a69bb49f422b3081b9347490bf Reviewed-on: https://chromium-review.googlesource.com/1188770 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#586313}
-
Andrew Grieve authored
Reverted in: 78561f5b Reason for reland: * Should now work with swarming * Contains fix for angle_perftest (ran locally) The existing version was found to infinite loop at times. Also moves the jars to CIPD Bug: 876539, 877619 Change-Id: I9564c9b5dd6339abd1ded62d9bba98f9692a601d Reviewed-on: https://chromium-review.googlesource.com/1188601Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#586312}
-
Francois Doray authored
The previous attempt to land this CL was reverted because a value that we didn't expect was returned by ::GetThreadPriority() on Win7 bots. This CL adds logging so we can find out what value is returned and add it to the expected values if need be. Previous attempts to land: https://chromium-review.googlesource.com/1171482 https://chromium-review.googlesource.com/1185529 NOTE: If this causes new test failures, we'll add the value returned by GetThreadPriority() to the switch/case of allowed values. This CL adds a feature to use THREAD_MODE_BACKGROUND_BEGIN instead of THREAD_PRIORITY_LOWEST for ThreadPriority::BACKGROUND threads. This lowers the disk and network I/O priority of the thread in addition to the CPU scheduling priority. MSDN recommends using this setting for threads that perform background work. https://docs.microsoft.com/en-us/windows/desktop/api/processthreadsapi/nf-processthreadsapi-setthreadpriority TBR=gab@chromium.org Bug: 872820 Change-Id: I54de2f17c66985ac437ca7809d3b515b22c72544 Reviewed-on: https://chromium-review.googlesource.com/1190842 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#586311}
-
Michael Spang authored
Running on scenic requires passing a fidl::InterfaceRequest<fuchsia::ui::viewsv1token::ViewOwner> to CreatePlatformWindow(). Bug: 861853 Test: ozone_demo --ozone-platform=scenic --enable-vulkan (with full series) Change-Id: I948a4408d64dcb8fef1ec28a55437a48e6ec4a54 Reviewed-on: https://chromium-review.googlesource.com/1188973 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#586310}
-
Xiaocheng Hu authored
This patch makes NGBoxFragmentPainter paint caret by - Routing back to legacy LayoutBlock to determine if a block has carets to paint - Adding caret painting code to NGBoxFragmentPainter so that carets can be painted in NG contenteditable blocks. This patch makes other editing NG development/debugging easier. It also fixes some image failures with EditingNG flag enabled, e.g. editing/selection/editable-links.html. Bug: 876555 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I29968b24872603d999b8fd2301ffd465cac23406 Reviewed-on: https://chromium-review.googlesource.com/1185499 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#586309}
-
Greg Thompson authored
ChromeViewsDelegate registers a KeepAlive while a menu is shown to prevent the browser from existing while a menu is up. This caused problems with the UninstallView since there was otherwise nothing keeping the browser alive, resulting in Chrome exiting when a menu was opened and closed (https://crbug.com/241366). This was dealt with by adding a leaked ref on the browser process to the UninstallView. In time, this turned into a leaked KeepAlive. This isn't so good for the KeepAliveRegistry, as it DCHECKs that there are no KeepAlives registered at shutdown. The underlying problem here is that BrowserProcessImpl doesn't own the lifetime of the browser process until the main loop is entered. There are various points during initialization where decisions are made to let the process exit without running the main loop. This CL changes BrowserProcessImpl::SetQuitClosure into OnEnteringMainMessageLoop and makes it an act of lifetime ownership transferral. Prior to its invocation, ChromeBrowserMainParts owns process lifetime. After its invocation, BrowserProcessImpl owns it. BrowserProcessImpl observes but ignores KeepAlive transitions when it isn't in charge of process lifetime. BUG=876640 Change-Id: I263aed8bd2c4509ba1bc1919e189dfc2f9e6bbd0 Reviewed-on: https://chromium-review.googlesource.com/1185096 Commit-Queue: Greg Thompson <grt@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Jacob Trimble authored
This adds an entry to .gitignore to ignore .pyc files. This allows other projects to use this without having the git directory be dirty. Change-Id: Ifdc6d204efe2c6801f120df14349b88436b16720 Reviewed-on: https://chromium-review.googlesource.com/1191082Reviewed-by:
-
Toni Barzic authored
BUG=869455 Change-Id: I907efad478d475616af51576707bb6f0a6bd6ea7 Reviewed-on: https://chromium-review.googlesource.com/1182416 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#586306}
-
Evan Stade authored
Bug: none Change-Id: I6ff55d5042afdc992c7f94836cc7192e7b0cb749 Reviewed-on: https://chromium-review.googlesource.com/1188946Reviewed-by:
-
Sylvain Defresne authored
To allow tests to be written without depending on the side-effect of the initialization of an AccountTrackerService, add a public method returning whether migration of account_id is supported on the current platform. Bug: none Change-Id: Ibe632d42378ad952ff92645598fc396cda3a2879 Reviewed-on: https://chromium-review.googlesource.com/1188577 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#586304}
-
Pavol Marko authored
Bug: none Change-Id: I160f2588d09f5aca0c21b4a3c65eea931416bcc8 Reviewed-on: https://chromium-review.googlesource.com/1188466 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#586303}
-
Min Chen authored
Snapping or dropping the drag window into overview if fling the drag window inside preview area should based on the fling direction and velocity. - Fling to the snap position should always snap the window. - Fling to the opposite snap position should consider the velocity. If the velocity is large enough, going to drop the window into overview. Otherwise, still snap the window. Fling the window when splitview is active. - Fling the window in the area where there is no snapped window, the same as preview area is shown. - Fling the window in the area where there is a snapped window. Fling to the opposite position of the snapped window's snap position should drop the window into overview. See recorded video: https://drive.google.com/file/d/0B5I0jFeLxqIieDRSQXNwVWwtcGhCUWtJaHM3MkVfaUJwR3hr/view?usp=sharing Bug: 876354 Change-Id: I316456cb3bcdf086b8181c44efdc5a383cadc97f Reviewed-on: https://chromium-review.googlesource.com/1186155Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#586302}
-
Chris Harrelson authored
Previously we did not consider non-BlockFlow elements in the containing block chain between the float and the containing BlockFlow. The code being fixed was introduced here, as part of solving a similar situation: https://codereview.chromium.org/1661523002. It seems that the case of under-inline was not skipped on purpose. Bug: 833602 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I311ebb3d9f2172ed041bf0e6c8a583d89ae1a74a Reviewed-on: https://chromium-review.googlesource.com/1188980Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#586301}
-
Michael Spang authored
This is necessary to use the GPU through vulkan. Bug: 861853 Test: ozone_demo --ozone-platform=scenic --enable-vulkan (with full series) Change-Id: I7eac180b9c8592f6f5c10799fa845331bda16ec4 Reviewed-on: https://chromium-review.googlesource.com/1188971 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
-
Francois Doray authored
This updates field_trial_testing_config.json with the parameters that we plan to use to experiment with proactive freeze and discard on beta. PageAlmostIdle feature is independant from ProactiveTabFreezeAndDiscard. SiteCharacteristicsDatabase feature is required to enable ProactiveTabFreezeAndDiscard, so they need to be enabled by the same study. stop-non-timers-in-background defines the effect of freezing a tab, so it needs to be in the same study as ProactiveTabFreezeAndDiscard. Bug: 775644 Change-Id: I8ef64a716585a6284e9744c93cf5dfc58a22f77f Reviewed-on: https://chromium-review.googlesource.com/1188862 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#586299}
-
spirv-chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/47ee776a2c56..d94a2077d68c git log 47ee776a2c56..d94a2077d68c --date=short --no-merges --format='%ad %ae %s' 2018-08-27 33432579+alan-baker@users.noreply.github.com Remove idUsage 2018-08-27 31666470+s-perron@users.noreply.github.com Have the constant manager take ownership of constants. (#1866) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@d94a2077d68c The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I5bc5a2ef5245af5cbaa7d41c2abd6633f16b8184 Reviewed-on: https://chromium-review.googlesource.com/1190683Reviewed-by:
spirv-chromium-autoroll <spirv-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: spirv-chromium-autoroll <spirv-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586298}
-
Etienne Pierre-doray authored
This CL adds assertions in ScopedBlockingCall. To distinguish between blocking and sync primitive assertions, a new class was added, ScopedBlockingCallWithBaseSyncPrimitives. Usages of ScopedBlockingCall were replaced by ScopedBlockingCallWithBaseSyncPrimitives when appropriate. Corresponding assertions were added (AssertBlockingAllowed and AssertBaseSyncPrimitivesAllowed) in both ScopedBlockingCall and ScopedBlockingCallWithBaseSyncPrimitives. In the future, either ScopedBlockingCall or ScopedBlockingCallWithBaseSyncPrimitives will be used to mark all blocking tasks. Bug: 874080 Change-Id: I8277436d4dd25dedb47d6fcdacc45f3905397647 Reviewed-on: https://chromium-review.googlesource.com/1178326Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#586297}
-
Becca Hughes authored
Fix an issue with duplicate AudioFocusType typedef that breaks Jumbo builds. BUG=876227 Change-Id: Ic10ecb871d8d1e63093505f63d29bf0b499e6626 Reviewed-on: https://chromium-review.googlesource.com/1183885Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#586296}
-
yusukes authored
The new mojo method allows the Android container to tell Chrome OS that an Android IME has been disabled. This will be used for implementing the cancel button on the enable-IME confirmation dialog. BUG=b:74499980 TEST=unit_tests TEST=Install Gboard, try to enable it via chrome://settings, press CANCEL on the confirmation dialog, verify that the checkbox for Gboard is automatically unchecked. Change-Id: I29320ff6ae8c610a3e3db13330672f3fc68db7d3 Reviewed-on: https://chromium-review.googlesource.com/1179471 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#586295}
-
Yue Li authored
Bug: 867919 Test: Local Compile Change-Id: I4500ed2ceb047fb5557717b038f4a057ec251ce6 Reviewed-on: https://chromium-review.googlesource.com/1186125 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Cr-Commit-Position: refs/heads/master@{#586294}
-
Manu Cornet authored
This makes sure that the size of the highlight (which is also the 'small' part of the ripple animation) corresponds to the shelf size. This results in no behavior change in the old UI, and fixes a glitch in the new one. Bug: 877563 Change-Id: I93c0fa90e22ded53e77b2b099e852851821f62a1 Reviewed-on: https://chromium-review.googlesource.com/1189186Reviewed-by:
-
