GitLab

<FrameSelection.h> header was needed only for RevealSelectionAfterEditingOperation
function parameter. But it seems that all call sites of this private function
didn't specify the second parameter and always used default value.

Bug: 
Change-Id: I9c4a40c36287c9ccc9a908554df8c106283d1430
Reviewed-on: https://chromium-review.googlesource.com/667377Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Andrey Kraynov <iceman@yandex-team.ru>
Cr-Commit-Position: refs/heads/master@{#504786}

NOTRY=true

Bug: 765779
Change-Id: I4c16248e4497ee4c9978d74e64d1591baf45ade7
Reviewed-on: https://chromium-review.googlesource.com/688654Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504785}

Bug: 
Change-Id: I7492294beda04a07a233fbe2225350f985ec0421
Reviewed-on: https://chromium-review.googlesource.com/686294Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Lucas Garron <lgarron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504784}

It looks like the test was just timing out.  Shortened the text used by
AccessibilityGmailComposeStory significantly. Locally the test went from
taking 110s to 54s.

Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/663208
Reverted: https://chromium-review.googlesource.com/686454

Adds new stories that exercise things that sometimes cause performance
problems for accessibility: live regions, large data tables, scrolling
large complex sites, and typing in a contenteditable, and expands the
system_health benchmark to track accessibility metrics.

Bug: 712417
Change-Id: I4496833409b142babc907dff8033da75789c932e
Reviewed-on: https://chromium-review.googlesource.com/688058Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504783}

This code is not being used and there's no plan to enable it any time
soon.

BUG=730770
TEST=No functionality change

Change-Id: I76a0e5823f5c5923f3ae8f134b4a3b6609eb462f
Reviewed-on: https://chromium-review.googlesource.com/685460Reviewed-by: John Rummell <jrummell@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504782}

Code was difficult to copy-and-paste out of the callback examples
because typically one would need to add base:: to many types.

This explicitly adds "base::" to all examples.

Originally I was going to keep the references in the text unchanged and
only change the code blocks. But this ended up being confusing. As a
result, all code-formatted references have been qualified. In some cases
this is a bit verbose and repetitive, but I think its better to be
explicit and consistent.

Expands a bit on weak pointer usage which I have found myself repeatedly
looking up.

Change-Id: I961b25ea6db6151180cf0d687e576be72e327427
Reviewed-on: https://chromium-review.googlesource.com/688505Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Commit-Queue: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504781}

Added in a nullptr check for when the navigator has a detached window.

Bug: 766498
Change-Id: Ia103761f3673b518428f9e34f6b7082d952b3407
Reviewed-on: https://chromium-review.googlesource.com/685818Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Anna Maria <offenwanger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504780}

Fixes "Check failed: TaskScheduler::GetInstance()."

Bug: 
Change-Id: I975bdd95254818f9864cf3e059ad6926bb2985f9
Reviewed-on: https://chromium-review.googlesource.com/686048
Commit-Queue: Matt Mueller <mattm@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504779}

Drag link images are an image of the destination url that's created when you
drag a link. This patch fixes two bugs in the link image offset:
1) Link images were not offset by the device scale factor. This meant that the
link was incorrectly positioned on high-dpi screens.
2) We further regressed the link image offset when DragController::DoSystemDrag
started taking into account page scale factor in:
https://chromium.googlesource.com/chromium/src/+/7e525d262ca0cd454a91c81d2d23071feef9b1dd

This patch adds DragLocationForLink which correctly scales the link offset.

Bug: 766355
Change-Id: I25a04fb4bf734cce810a74498fa126d97f58964c
Reviewed-on: https://chromium-review.googlesource.com/680535Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504778}

Change-Id: I553d1d1212162810f62b5f2bedd48c61d6bdd50f
Reviewed-on: https://chromium-review.googlesource.com/685989Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504777}

Vector icons with FLIPS_IN_RTL get shown. Right now there are only the
submenu arrow and the tablet mode back button which uses this command.
This also only happens when using the 2x icon. The current
transforms applied on rtl 2x icons are:
  - scale down by factor of 2
  - scale by -1
  - translate by the canvas size
This results in the icon being translated out of its bounds and not
being shown. This cl does the scaling down after the translation.

Test: gfx_unittests VectorIconTest.FlipsInRtl
Bug: 769366, 768059
Change-Id: I67e748ea23c9020f13a693546db2fade07e05ae6
Reviewed-on: https://chromium-review.googlesource.com/687826Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504776}

TBR=jam@chromium.org

Bug: 667892
Change-Id: I9c0900c171e9fd808e34c6db85e3e0633e8de14e
Reviewed-on: https://chromium-review.googlesource.com/687755
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504775}

Right now GpuFeatureInfo is passed from GPU to browser through GpuProcessHost.
However, we will want blacklist decisions on the renderer side also, so this CL
hooks it up with GpuChannelHost.

We will be able to remove blacklisting and driver bugs info from Capabilities
and GPUInfo because now we have GpuFeatureInfo available in the renderer side,
but let's leave the cleanup to a separate CL.

BUG=744658
TEST=bots
R=piman@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I9fe61bcf12dbdda80762bd994402a337e44babc2
Reviewed-on: https://chromium-review.googlesource.com/685301Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504774}

There is an increasing need to use Windows features that only exist in
Windows 10 Creators Update or later. This is most conveniently done by
requiring that SDK. The packaged toolchain used by Google build machines
and Google employees has been using the Creators Update SDK for several
months - this CL only changes the requirement for those who are not
using the packaged toolchain. This update would have been done earlier
but several broken versions of the Creators Update SDK necessitated a
delay.

This change was triggered by crrev.com/c/649026 which had to be reverted
due to its dependence on the Creators Update SDK. This change will let
that change be relanded. Requiring the Creators Update SDK will also
allow ENABLE_HDR_DETECTION to be unconditionally defined.

After this change developers will get an informative error message if
they do not have the Creators Update SDK or later installed.

Note that Chrome, of course, still needs to *run* on versions of Windows
before Windows 10 Creators Update - this just covers *build*
requirements.

Bug: 760977
Change-Id: Ice36177e25cedb80555a3ebedaf9f710cafb1a88
Reviewed-on: https://chromium-review.googlesource.com/666023
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504773}

There shouldn't be any remaining issues with these tests on ChromeOS
vs any other platforms, so attempt re-enable.

BUG=622397
TEST=none

Change-Id: If1fbf56b9da66fb1b2d6290999a868e1b488e73e
Reviewed-on: https://chromium-review.googlesource.com/685820Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504772}

The speculative preconnect feature comes in three modes:
* Learning - only the LoadingPredictor database construction is enabled.
* Preconnect - the LoadingPredictor actually does preconnects leveraging
  the historical database. This mode also disables net::Predictor to
  avoid an interference between them.
* No preconnect - disables both types of preconnects. This mode is
  useful for manual testing.

Bug: 699080
Change-Id: I445583d937e57cd99f78ea6f4bc4134b2614c885
Reviewed-on: https://chromium-review.googlesource.com/684896
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Matthew Cary <mattcary@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504771}

The conditional in FFmpegAudioDecoder checking for unsupported
channel layouts was not using the right variable. It used the
one from the config rather than the one for the frame (which
is required for config change support).

I think there's no real harm in this besides a DCHECK failure,
but might be worth merging back anyways. This regressed in
M62 with 16223674.

BUG=726971
TEST=none

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ibcdc5ceeb263c3e247742b4fbfe07a45e64297de
Reviewed-on: https://chromium-review.googlesource.com/686064
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504770}

We have been assuming a platform-specific arrangement of bytes in the
Skia textures we generate.  The resulting SkPixmap color format varies
by platform, and is different on Linux vs. Android.

BUG=769325

Change-Id: Id157f45b179fa74478b1662e7ada3b2e8ff82456
Reviewed-on: https://chromium-review.googlesource.com/688334Reviewed-by: Yash Malik <ymalik@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504769}

Bug: 
Change-Id: I9b0ef3f4a9776ef27f57b67c08731e2ad967d970
Reviewed-on: https://chromium-review.googlesource.com/683007Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504768}

BUG=chromium:758016
TEST=none

Change-Id: I6da6a2ebadabf39109534706fb8673b13ae95fff
Reviewed-on: https://chromium-review.googlesource.com/679274
Commit-Queue: Luigi Semenzato <semenzato@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504767}

Bug: 765719
Change-Id: Id172d596202bab6c2e8093b285feacceadc4425a
Reviewed-on: https://chromium-review.googlesource.com/672665
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504766}

Bug: 701939
Change-Id: I72f565cb28fc4e13e34226baea5bb421b4a8de83
Reviewed-on: https://chromium-review.googlesource.com/675889
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504765}

Bug: 751758
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0552b674bf1ab78e2ab942a79d7d98bf0da181d3
Reviewed-on: https://chromium-review.googlesource.com/679196
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504764}

This CL redirects hints from the omnibox to the LoadingPredictor if it
is enabled. For now the LoadingPredictor attempts only to preconnect in
case of search query or preresolve otherwise to keep it consistent with
the current behavior.

Bug: 699080
Change-Id: I25593be62e751a6ff983b3e97f397985c77c6644
Reviewed-on: https://chromium-review.googlesource.com/675685Reviewed-by: Matthew Cary <mattcary@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504763}

Also fix logcat -v showing all logcat lines from before launch

Change-Id: I375c520bdc89a5d8b0f1e7b4cdcfbc739a7bdacc
Reviewed-on: https://chromium-review.googlesource.com/687557Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504762}

Follow up to https://crrev.com/c/674691
The test failure on CQ related to the change was ignored because the
test was also failing without the patch for another reason.

TBR=bauerb@chromium.org

Bug: None
Change-Id: I1ff5645171141642540940500ae99561e1343e61
Reviewed-on: https://chromium-review.googlesource.com/688076Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504761}

This change is a follow up to a TODO that calls for direct access to the
ContextProvider after it has been moved to the gpu. 

Bug: 746182
Change-Id: Iad2e9e89e234724e4f9053b43ae74dfd66cfa901
Reviewed-on: https://chromium-review.googlesource.com/668029Reviewed-by: Frank Liberato <liberato@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504760}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/168f550c..408b8e44

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org

Change-Id: Ie329123549c567d97a406e5e9b5d37c16b66c413
Reviewed-on: https://chromium-review.googlesource.com/686780Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504759}

The surface input region doesn't work in mus and mash. This CL
implements WindowTargeter::GetExtraHitTestShapeRects() for
exo::Surface::window_. In mus and mash, this function will be called and
returned hittest rects will be sent to mus.

Bug: 766174
Change-Id: I67dc04cc331f0174ff3390920c3de98c00100df5
Reviewed-on: https://chromium-review.googlesource.com/685277
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504758}

This CL adds necessary {} and removes unnecessary {} for generic_sensor
code.

Bug: None
Change-Id: I1a752303d39ddb2d215a018ee6adeacd7f8d1b58
Reviewed-on: https://chromium-review.googlesource.com/687556Reviewed-by: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
Commit-Queue: Jun Cai <juncai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504757}

This patch removes a duplicate method and renames its uses.

Bug: 753595
Change-Id: I8c101b726418f457e4d0feadfb6f042c6558e02f
Reviewed-on: https://chromium-review.googlesource.com/687822Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504756}

It was causing a Clang warning to fire:

FAILED: obj/third_party/WebKit/Source/core/editing/editing/TextIteratorTextNodeHandler.obj
../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo /showIncludes  @obj/third_party/WebKit/Source/core/editing/editing/TextIteratorTextNodeHandler.obj.rsp /c ../../third_party/WebKit/Source/core/editing/iterators/TextIteratorTextNodeHandler.cpp /Foobj/third_party/WebKit/Source/core/editing/editing/TextIteratorTextNodeHandler.obj /Fd"obj/third_party/WebKit/Source/core/editing/editing_cc.pdb"
In file included from ../../third_party/WebKit/Source/core/editing/iterators/TextIteratorTextNodeHandler.cpp:1:
In file included from C:\b\c\builder\ClangToTWin_dbg_\src\out\Debug\..\..\third_party\WebKit\..\..\third_party\WebKit\Source\core\Precompile-core.h:25:
In file included from ../../third_party/WebKit/Source\core/dom/Document.h:37:
In file included from ../../third_party/WebKit/Source\bindings/core/v8/ExceptionState.h:34:
In file included from ../../third_party/WebKit/Source\bindings/core/v8/ScriptPromise.h:34:
In file included from C:\b\c\builder\ClangToTWin_dbg_\src\out\Debug\..\..\third_party\WebKit\Source\bindings\core\v8\ScriptFunction.h:34:
In file included from ../../third_party/WebKit/Source\bindings/core/v8/ScriptValue.h:36:
In file included from ../../third_party/WebKit/Source\platform/bindings/ScriptState.h:12:
In file included from C:\b\c\builder\ClangToTWin_dbg_\src\out\Debug\..\..\third_party\WebKit\Source\platform\bindings\V8PerContextData.h:41:
In file included from ../../third_party/WebKit/Source\platform/bindings/V8GlobalValueMap.h:10:
In file included from ../../third_party/WebKit/Source\platform/wtf/text/StringHash.h:28:
In file included from ../../third_party/WebKit/Source\platform/wtf/text/AtomicString.h:31:
In file included from ../../third_party/WebKit/Source\platform/wtf/text/CString.h:31:
../../third_party/WebKit/Source\platform/wtf/RefCounted.h(161,44):  error: delete called on non-final 'blink::NGPhysicalFragment' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]
  static void DeleteInternal(const T* x) { delete x; }
                                           ^
../../third_party/WebKit/Source\platform/wtf/RefCounted.h(142,7):  note: in instantiation of member function 'WTF::RefCounted<blink::NGPhysicalFragment, blink::NGPhysicalFragmentTraits>::DeleteInternal' requested here
class RefCounted : public RefCountedBase {
      ^
1 error generated.

BUG=84424
TBR=thakis

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I8699ffcd62064f2c53f2dd12ac0456bb46aaacb2
Reviewed-on: https://chromium-review.googlesource.com/687555Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504755}

The Linux CFI bot was detecting unrelated casts in LLVM's allocator,
which is actually the desired behavior of an allocator, generally. Added
an entry to the blacklist to prevent this error on the CFI bot.

R=vtsyrklevich@chromium.org
TBR=pcc@chromium.org

Bug: 726075
Change-Id: I7fd970a5f564d46a066ae57a0d7c6fe46be62868
Reviewed-on: https://chromium-review.googlesource.com/688017Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504754}

GLRenderer uses a non-immutable resource when copying the current
RenderPass to a texture, as the storage format is not explicit when
copying from the OutputSurface backbuffer. In that case the buffer
can be RGB so we need to define the format of the texture as RGB
(you can't add a component when copying), but the ResourceProvider
does not support RGB textures, and adding it everywhere there would
be unneeded complexity.

Instead, we make GLRenderer stop using ResourceProvider for this use
case. Since it is isolated to the GLRenderer subclass (DirectRenderer
does not need to know about these textures), we don't need to use a
"ResourceId" abstraction.

This adds a GetFramebufferCopyTextureFormat() method to GLRenderer
that returns the GL format to use for a texture if copying from the
current Renderpasss output.

This removes the GetFramebufferTexture() method, and moves the call
to CopyTexImage2D() out to the two callsites:
- In the CopyOutputRequest code, we already have a texture id, and
just need to bind it and call CopyTexImage2D.
- In GetBackdropTexture(), we create a new texture id, set up its
filters, and bind and CopyTexImage2D.
- Both of these use the GetFramebufferCopyTextureFormat() to choose
the best format for the copy output.

Since we have a raw texture id, we replace uses ResourceProvider
locks and ScopedResource throughout, and ensure to delete the
texture ID when we set it to 0, or when we destroy the |params|
at the end of GLRenderer::CopyRenderPassDrawQuadToOverlayResource
and GLRenderer::DrawRenderPassDrawQuad.

R=piman@chromium.org

Bug: 768976
Change-Id: I14ee01a767416da9210d80a73c39ef1d2022c58c
Reviewed-on: https://chromium-review.googlesource.com/685300
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504753}

This reverts commit f37c1971.

Reason for revert: <INSERT REASONING HERE>

Causing layout test failure on Mac10.9
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds/50208

Original change's description:
> Split the accessible combo box role into three roles.
> 
> For historical reasons, the ARIA role "combobox" is misused
> and misunderstood. It can be one of three things:
> 
> 1. A fully editable text field that also has a drop-down list
>    of possible options
> 2. A button that opens to reveal a mutually-exclusive list of
>    choices (but with no text field anywhere)
> 3. A grouping container with a text field and a drop-down list
>    inside
> 
> The only platform where this mostly worked was on Windows,
> where "combo box" is a native control. On Mac and Android,
> we need to treat #1 as a text field primarily, and #2 more
> like a button, since there's no equivalent that acts as
> both.
> 
> Bug: 516869, 666049, 546051
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: I7ffd92f2996c729398d4300262e545eaa9ca0009
> Reviewed-on: https://chromium-review.googlesource.com/642056
> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
> Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#504725}

TBR=dmazzoni@chromium.org,dtseng@chromium.org,michaelpg@chromium.org,aleventhal@chromium.org

Change-Id: I4a3c390bd6c363f531ed00f1faa5fb660f637d16
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 516869, 666049, 546051
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/688354Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504752}

Previous CL:
https://chromium.googlesource.com/chromium/src/+/995c535793ecd77fc2661c428d507a017d042db1

BUG=768789

Change-Id: Id162e32921e55a597c2253737f2180e0a4006596
Reviewed-on: https://chromium-review.googlesource.com/685821Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504751}

https://pdfium.googlesource.com/pdfium.git/+log/c29c16f8cb98..8b1408e70532

$ git log c29c16f8c..8b1408e70 --date=short --no-merges --format='%ad %ae %s'
2017-09-27 rharrison Remove FXSYS_strlen and FXSYS_wcslen
2017-09-27 rharrison Replace FX_SAFE_STRSIZE with FX_SAFE_SIZE_T
2017-09-27 rharrison Remove FX_STRSIZE and replace with size_t
2017-09-26 rharrison Make names of GIF types less opaque
2017-09-27 rharrison Add in missing ! to conditional
2017-09-27 dsinclair Move static methods to anonymous namespace

Created with:
  roll-dep src/third_party/pdfium
BUG=769292


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: Iaae379bbcfe4991deac62bcbedc268c752e68011
Reviewed-on: https://chromium-review.googlesource.com/687816
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504750}

In case of nested OOPIFs the GSB event is bubbled one target at a time;
when GSB is bubbling up from an intermediate target, a synthetic GSE is
sent to the target to finish the scrolling sequence on it.
Once GSB has found its final target, the rest of the scroll events are
directly bubbled to that target rather than getting bubbled up one
target at a time.

https://chromium-review.googlesource.com/658217 cl has fixed the DCHECK
hit while sending a synthetic GSE to an intermediate target.
However, the generated GSE still stops scroll bubbling by resetting the
bubbling target to null. This cl drops generated GSEs that are sent to
intermediate bubbling targets and prevents them from stopping the
scroll bubbling.

Bug: 763422
Change-Id: I6a49d431b6f838b3f56e477ef6b0af7b8e6bf0c2
Reviewed-on: https://chromium-review.googlesource.com/678536Reviewed-by: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504749}

Call to WaitSyncTokenCHROMIUM was removed by mistake in:
https://chromium-review.googlesource.com/c/chromium/src/+/579690

BUG=769155, 766611

Change-Id: I25a95c79755801463b15fb12047458c594bf24d6
Reviewed-on: https://chromium-review.googlesource.com/685379
Commit-Queue: Xida Chen <xidachen@chromium.org>
Commit-Queue: Justin Novosad <junov@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Reviewed-by: Olivia Lai <xlai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504748}

This reverts commit 93935b15.

Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=769403

(causing bot failures on newtabpage test)

Original change's description:
> 📰 Use standard styles for classic action items
> 
> Updates the SuggestionCardActionModern style to be more generic and
> be usable for classic cards, use it for the classic generic signin
> promo and the action item.
> 
> Preview: https://photos.app.goo.gl/GC9l01D8QI7YSLtI2
> Bug: None
> Change-Id: If1a007ad4288cc88511845b3ac89a9c8f2f1cbab
> Reviewed-on: https://chromium-review.googlesource.com/674691
> Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>
> Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#504678}

TBR=mvanouwerkerk@chromium.org,dgn@chromium.org

Change-Id: Ife5676ada7e69b01c3b8fcb3002cd779527e93cf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 769403
Reviewed-on: https://chromium-review.googlesource.com/688160
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504747}