- 04 Oct, 2018 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8841085abeb9..4dd17156c6e4 git log 8841085abeb9..4dd17156c6e4 --date=short --no-merges --format='%ad %ae %s' 2018-10-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader e5051aa35032..3b5e426b815f (1 commits) Created with: gclient setdep -r src/third_party/skia@4dd17156c6e4 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=mtklein@chromium.org Change-Id: I3d7c22f28414aee22d2535fa11f9c3185193fa9c Reviewed-on: https://chromium-review.googlesource.com/c/1260159Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596511}
-
Ryo Hashimoto authored
The same check is done in other functions in this .cc file. Do the same thing for UnwrapPlatformHandle(). BUG=891990 TEST=mojo_unittests Change-Id: I05fe4bfd5edd8ec3fc67aeb9f11879c74fd71dd4 Reviewed-on: https://chromium-review.googlesource.com/c/1260782Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#596510}
-
Ned Nguyen authored
This is based on Dirk's comment in https://chromium-review.googlesource.com/c/chromium/src/+/1259475#message-01cdaf3daae02840bb55b523a0eb71c9201adade TBR=dpranke@chromium.org, jbudorick@chromium.org Bug: 891747 Change-Id: Iec031e348d26d77de3f897641f4a151d0b4f544d Reviewed-on: https://chromium-review.googlesource.com/c/1260519Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#596509}
-
JunHo Seo authored
Problem: Let a focused(and scrollable) element's (visible) bounding box is (x, y, w, h). If we hit down arrow key, then its result of SearchOrigin() will be (x, y, w, 0), i.e. top edge of the element. This introduces additional candidates are considered if we use the result. Previously, we are considering an element that its bounding rect is (x', y', w', h'), where y' >= y+h (except intersecting candidate). But, if we use the result, an element (x'', y'', w'', h'') where y <= y'' < y+h can be candidate. Here is an example: (x, y, w, h) --------- (x'', y'', w'', h'') | | ----- | A | | C | | | ----- --------- (x', y', w', h) ----- | B | ----- In above example, assume that we hit down arrow key. And element 'A' is focused and scrollable element. If we use A's bounding box as search origin, then only element 'B' is candidate for getting focus, because y+h < y', y+h > y''. But if we use top edge of element 'A'(x, y, w, 0), element 'C' also can be candidate because y+0 < y''. In point of intuitive, element 'C' is not in down side direction of element 'A', so it should not be candidate in this scenario. Solution: Use bounding box for focused(and scrollable) element as well. This CL also change SearchOrigin() from recursion to iteration. Bug: 891149 Change-Id: Ib9e3ba07859e6bfc415cd19f93b42cc33fda7c74 Reviewed-on: https://chromium-review.googlesource.com/c/1253523 Commit-Queue: JunHo Seo <junho0924.seo@lge.com> Reviewed-by:
Hugo Holgersson <hugoh@vewd.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#596508}
-
Sadrul Habib Chowdhury authored
For synthesized scroll/drag/pinch gestures, dispatch the events at a high frequency (120Hz) so that there's at least one event in each frame. Dispatching events at a lower frequency (60Hz) means the timer can go out of sync with begin-frame, and so there can be frames where there was to event dispatch. Our telemetry code reports this as jank, which is incorrect. Dispatching at a higher frequency for the scroll/drag/pinch gestures resolves this issue. BUG=783034 Change-Id: I1102f76ed743231cbb10fdb872e8c66f895fa223 Reviewed-on: https://chromium-review.googlesource.com/c/1255152Reviewed-by:
Victor Miura <vmiura@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#596507}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a664d328ecfc..6b79459a0027 Created with: gclient setdep -r src-internal@6b79459a0027 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I0c200a5a9c289c60a3ca77a19cba1f1fbdc9ee56 Reviewed-on: https://chromium-review.googlesource.com/c/1260158Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596506}
-
John Budorick authored
TBR=aluo@chromium.org Bug: 814405 Change-Id: I0daf53d6e5784d5f476d804e4c13dcc2c35ba5c5 Reviewed-on: https://chromium-review.googlesource.com/c/1260385Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#596505}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I58af57e2d849ca7f2c25e8a19adddac074f90d6e Reviewed-on: https://chromium-review.googlesource.com/c/1260763Reviewed-by:
-
Ian Clelland authored
Bug: 888668 Change-Id: I1ba1e04b8f5853e449d8a1316f6322d5839ed1b5 Reviewed-on: https://chromium-review.googlesource.com/c/1243524Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#596503}
-
Byoungkown authored
The code in components/policy takes about 3-4 CPU minutes to build. Building effort will fall to about 1 CPU minutes using jumbo builds[1]. When building using jumbo, files get merged and variables and functions with the same name may end up in the same namespace/scope and conflict. One PolicyLoadStatus is in core/common/cloud/user_cloud_policy_store.cc and the other PolicyLoadStatus is in core/common/policy_load_status.h. PolicyLoadStatus is renamed in core/common/policy_load_status.h to avoid conflict as PolicyLoadStatusForUma. [1] https://chromium.googlesource.com/chromium/src/+/lkgr/docs/jumbo.md Bug: 869381 Change-Id: I268603abca0be7ed029d60bd1531ca41983c3ece Reviewed-on: https://chromium-review.googlesource.com/c/1253313Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com> Cr-Commit-Position: refs/heads/master@{#596502}
-
David Trainor authored
Address some issues with how the generic item holder was building - Fix AsyncImageView not properly showing the unavailable drawable (rebase issue). - Fix issue with progress.getPercentage() being called on an indeterminate progress state. - Make sure we properly show the grey circle around the generic icon. - Add a way to not wrap a drawable with an animator if there is nothing to animate. thumbnails: Change-Id: I3bd15451af234e8291d886d4c3df64d696a41ac6 Reviewed-on: https://chromium-review.googlesource.com/c/1258349 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#596501}
-
Anand K. Mistry authored
This leaves 2 mechanisms to view zip files: the old AVFS-based zip file mounting, and the "Zip Archiver" component extension that is based on minizip and uses FSP. Zip archiver is the default, but doesn't yet support zip64 files. AVFS does support zip64, which is why it remains an option. BUG=821761 Change-Id: I185992a4ca9a4b21024a9898623668351ba6a464 Reviewed-on: https://chromium-review.googlesource.com/c/1242254 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#596500}
-
Kenichi Ishibashi authored
Pass a mock URLLoaderFactoryPtrInfo to URLLoaderFactoryBundleInfo as SharedWorkerHost requires the default loader factory when S13nServiceWorker is on. Bug: 891997 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Id656e2fe26fd44a25b6b367bb401553201d4b17a Reviewed-on: https://chromium-review.googlesource.com/c/1260783 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#596499}
-
Xianzhu Wang authored
This fixes 2 problems: 1. The caret visual rect was incorrectly added by scroll offset in composited scrolling block; 2. The painting of caret was not clipped. Bug: 882794 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib7c6979acf6000a747e1ac8ae439633f338d3c3f Reviewed-on: https://chromium-review.googlesource.com/c/1257892 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#596498}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/80482dc264c5..912f2d154162 git log 80482dc264c5..912f2d154162 --date=short --no-merges --format='%ad %ae %s' 2018-10-04 tsepez@chromium.org Remove several more unused methods from core/ Created with: gclient setdep -r src/third_party/pdfium@912f2d154162 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I01758815d35b300af2f90ae693be86c21449d549 Reviewed-on: https://chromium-review.googlesource.com/c/1260148Reviewed-by:
-
Alexey Baskakov authored
The test is flaky on multiple platforms. Example: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests/72784 TBR=dpapad@chromium.org Bug: 891955 Change-Id: I76567527df8d9241754940f6b520d1c52a543931 Reviewed-on: https://chromium-review.googlesource.com/c/1260703Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#596496}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2dd914402ebc..0543f082e2f4 git log 2dd914402ebc..0543f082e2f4 --date=short --no-merges --format='%ad %ae %s' 2018-10-03 khmel@chromium.org Fix flakiness of tests, that require GAIA login. 2018-10-03 kylechar@chromium.org Support macOS 10.14 Mojave. 2018-10-03 zmo@chromium.org Revert "Wire action_runner's Click through DevTools" 2018-10-03 chiniforooshan@chromium.org Telemetry: clean up legacy surface flinger metrics 2018-10-03 pasko@chromium.org androidStartupMetric: skip the first start 2018-10-03 benjhayden@chromium.org Fix flaky cp-toast.autoclose-only-last test. 2018-10-03 zmo@chromium.org Wire action_runner's Click through DevTools Created with: gclient setdep -r src/third_party/catapult@0543f082e2f4 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:879353,chromium:890951,chromium:885912,chromium:890757,chromium:881384,chromium:885912 TBR=sullivan@chromium.org Change-Id: I6e2ae7a29df4dcab18c0cde1e852ee159a3f12cf Reviewed-on: https://chromium-review.googlesource.com/c/1260146Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1395134c3438..5541a6c86a64 git log 1395134c3438..5541a6c86a64 --date=short --no-merges --format='%ad %ae %s' 2018-10-03 ianelliott@google.com Change A4A opt-in/out log messages from DEBUG to VERBOSE. Created with: gclient setdep -r src/third_party/angle@5541a6c86a64 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I722dfc77039cef64d01a754468413cc824b869d0 Reviewed-on: https://chromium-review.googlesource.com/c/1260151Reviewed-by:
-
Caleb Rouleau authored
The N6 devices in the lab are old and failing. Tests are expiring while waiting to find an open bot. With fewer shards we require fewer devices. Bug: 891848 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: Ic14a808f55d405792429feef73a33d9f2603d5e5 Reviewed-on: https://chromium-review.googlesource.com/c/1260218Reviewed-by:
-
Trent Apted authored
ObserverList iterators take a WeakRef to the ObserverList to detect the list being destroyed mid-iteration. ObserverList iteration doesn't need the thread-safety guarantees from base::WeakPtr, and there's rarely more than one iterator, or a couple on the stack. ObserverList iteration was identified as a performance concern as part of https://crbug.com/859155. A base::LinkedList can cater for detecting a destroy-while-iterating. This avoids the malloc() performed when the WeakRef is first dereferenced each iteration, which currently dominates iteration cost. We also reduce reference indirection, and reduce pipelining damage of atomics. Sample performance, for the given ObserverList size in Release. Values are nanoseconds to notify a single observer. Old -> New. (Old values improve with ObserverList size due to the malloc() cost being amortized over the list size). ObserverList::Unchecked 0: 22.3 -> 1.0 1: 79.6 -> 3.4 2: 61.6 -> 3.2 4: 50.5 -> 3.1 8: 41.0 -> 3.2 16: 33.6 -> 3.2 32: 30.3 -> 3.3 64: 28.8 -> 3.2 128: 28.0 -> 3.2 ObserverList<CheckedObserver> 0: 17.9 -> 0.8 1: 89.3 -> 12.9 2: 73.1 -> 14.8 4: 62.8 -> 16.0 8: 55.4 -> 18.0 16: 51.8 -> 18.3 32: 49.0 -> 18.3 64: 46.6 -> 18.3 128: 45.6 -> 18.2 Bug: 888973 Change-Id: I5edeb754e8c62d64efbbdecf617d5b33b0933688 Reviewed-on: https://chromium-review.googlesource.com/c/1242568 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#596492}
-
Jordy Greenblatt authored
The current HEAD behavior of the Setup Flow password page is to allow the user to repeatedly request forward navigation while the IPC for a password check is in progress. Then these requests for a queue so that the next time the user changes the contexts of the password input field, the next request in the queue is sent causing an accidental password check/setup attempt. This CL adds a field to the password page to allow it to determine whether it is in the middle of waiting for a password check to complete and if so, prevent any forward navigation attempt (including from the 'enter' key) and disable the button so the user knows it is out of commission while waiting for the IPC response. The CL also removes some now unused code surrounding expired auth tokens which made it harder to follow the logic flow for the IPC and callback: In the original design, the user would enter their password before they got to the start setup page and would therefore have to hold onto an auth token throughout the flow. In particular, it was necessary to set a timeout leading to a callback to erase the token once it was expired. In the current design, however, the auth token is used to complete the setup flow as soon as it is successfully obtained so there is no case in which a user would have time to let their token expire. Bug: 890958 Change-Id: Ia82af98ebaeeed0429c2da114d6e667130100c99 Reviewed-on: https://chromium-review.googlesource.com/c/1260215Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#596491}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I5406060f4386c5ee66cbf34c65e6311c68414eed Reviewed-on: https://chromium-review.googlesource.com/c/1260563Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#596490}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fbfd101d0207..a664d328ecfc Created with: gclient setdep -r src-internal@a664d328ecfc The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Iaeeced9251bbef817bd76d25979f2dadf72f96a7 Reviewed-on: https://chromium-review.googlesource.com/c/1260150Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e135eaf8c70a..f8aa25fa1e19 git log e135eaf8c70a..f8aa25fa1e19 --date=short --no-merges --format='%ad %ae %s' 2018-10-04 saklein@chromium.org image_test: adding blacklist support 2018-10-04 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@f8aa25fa1e19 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I8c359e327cc94d72d7c771dbfba7845dee257c53 Reviewed-on: https://chromium-review.googlesource.com/c/1260149Reviewed-by:
-
Jinsuk Kim authored
This CL addresses the reported bug by undoing the quick fix http://crrev.com/595608 and lazily initializing Java side TextSuggestionHost properly. Native side still needs to be established eagerly to get the IPC to work. Now Java layer is created before suggestion menu is requested to be shown for the first time. Bug: 884214 Change-Id: I1bbe9b2e3a5898d6dd082f8784951215a4a9ab91 Reviewed-on: https://chromium-review.googlesource.com/c/1256383 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#596487}
-
Erik Luo authored
A promise rejection produces an error log. Before, catching the exception turned the log level from error > info. Now, it turns from error > verbose. Screenshot: https://imgur.com/a/hKiFzWg Bug: 393913 Change-Id: Icd903cedfc7980789dcbbed93efbd63ea7210958 Reviewed-on: https://chromium-review.googlesource.com/c/1252381Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#596486}
-
Yoshifumi Inoue authored
This patch makes |Element#innerText| not to collapse white space around inline- block for improving interop. Note: The spec doesn't explicitly mention about this. Changes of AX test expectations added missing space after <input>. TBR=dmazzoni@chromium.org Bug: 890020 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I74a47fd5ba3a22ff17d9c36838a81b4277ac47cc Reviewed-on: https://chromium-review.googlesource.com/c/1250825Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#596485}
-
Fabrice de Gans-Riberi authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I79d0581a524173b8f96a8df8b8e002cd99074817 Reviewed-on: https://chromium-review.googlesource.com/c/1260515Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#596484}
-
rbpotter authored
Print Preview's destination dialog is displaying multiple scrollbars again. Bisected the issue to https://crrev.com/c/1252682 which recommends adding min-height: 0 to inner nested flexboxes. Bug: None Change-Id: I0d33a9cc79c1f74d7f0a2e79fb2e894d47bc38f4 Reviewed-on: https://chromium-review.googlesource.com/c/1260221Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#596483}
-
rbpotter authored
Split from https://crrev.com/c/1258508. Bug: None Change-Id: I71d0598723ce6abe4bb00c70def3728bf32d7b85 Reviewed-on: https://chromium-review.googlesource.com/c/1260508Reviewed-by:
-
Annie Sullivan authored
This will ensure that the InputToFirstContentfulPaint metric tracks the full latency when these navigations are initiated via user input. This will also make it easier to debug which types of loads from the renderer are NOT counted as being from user input in a follow up CL. Bug: 889220 Change-Id: I2ae48b5ca9d6230c15a4291d03b64945d312f802 Reviewed-on: https://chromium-review.googlesource.com/c/1258242 Commit-Queue: Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#596481}
-
Jinsuk Kim authored
Updates all the callsites of |Tab.getInfoBarContainer| to use |InfoBarContainer.get|, and deletes the api + member variable for InfoBarContainer in Tab. ChromeActivityTestRule.getInfoBarContainer is a new convenience method running ion UI Thread for tests. Bug: 877878 Change-Id: Ic785239e10d9f6376f297cb397632fd997311c9d Reviewed-on: https://chromium-review.googlesource.com/c/1227859 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Friedrich Horschig [CEST] <fhorschig@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
-
Peter K. Lee authored
EarlGrey tests will fail if GoogleService-Info.plist is not found and Firebase is enabled. Bug: 848117 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I427c57f297c78e32bebd0e5a5e47934309e76cb7 Reviewed-on: https://chromium-review.googlesource.com/c/1259803Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#596479}
-
Scott Wu authored
Bug: 865114 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I48e317b989129cf391ece111df72f98eb62504d1 Reviewed-on: https://chromium-review.googlesource.com/c/1226950 Commit-Queue: Scott Wu <scottwu@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#596478}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/684313d6a319..b250ec16d391 git log 684313d6a319..b250ec16d391 --date=short --no-merges --format='%ad %ae %s' 2018-10-04 vadimsh@chromium.org [git_cl] Don't check .gitcookies when running on LUCI. Created with: gclient setdep -r src/third_party/depot_tools@b250ec16d391 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:891755 TBR=agable@chromium.org Change-Id: I3b65bc7a9510860ac30641165980a09b756a61b9 Reviewed-on: https://chromium-review.googlesource.com/c/1260145Reviewed-by:
-
Hajime Hoshi authored
We want to avoid TaskObserver since this binds the current message loop's default task runner and a class tightly. This CL makes MemoryCache not be a TaskObserver and actual pruning is deferred by posting a task. This changes the behavior that the pruning task is enqueued to the end of the task runner. This should not affect actual memory usages so much. This CL also replaces the default task runner usages in the tests with the test task runner since we also want to avoid the default task runner in the test as much as possible. Bug: 870606 Change-Id: I6865ffe2a02800b5106b6da8605e7624498d6316 Reviewed-on: https://chromium-review.googlesource.com/c/1258805Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#596476}
-
John Budorick authored
All of the 10.14s are on minis. TBR=lindsayw@chromium.org Bug: 850125 Change-Id: I50d006b529081eef229f09532d65678aabd97870 Reviewed-on: https://chromium-review.googlesource.com/c/1260308Reviewed-by:
-
wutao authored
The transition animation of Logo view from dots to mic should be to kMic state, not kMicFab state. The difference is that there is a big jump of the dots to kMic state, which is consistent to Android implementation. Bug: b/117184159 Test: manual. Change-Id: Id7ba2fedf683d809d096cdeb644214db92b0f7b9 Reviewed-on: https://chromium-review.googlesource.com/c/1258605Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#596474}
-
Kenneth Russell authored
Kai has been a strong contributor for a long time. Bug: none Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I221ad58462f1bfc16334b76a5158fdfaa4fceb5f Reviewed-on: https://chromium-review.googlesource.com/c/1260386Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#596473}
-
Alexey Baskakov authored
The test is flaky on Linux TSan builder. Example: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20TSan%20Tests/26934 TBR=jdonnelly@chromium.org Bug: 891959 Change-Id: Ia29f4d01145588f97a6e34b1e1fa833186238dfb Reviewed-on: https://chromium-review.googlesource.com/c/1260524Reviewed-by:
-
