- 19 Nov, 2018 40 commits
-
-
Yutaka Hirano authored
They are no longer leaky. Bug: 672740 Change-Id: I327d3f5c073008ec092dc3f94bb00701d05cd183 Reviewed-on: https://chromium-review.googlesource.com/c/1341735Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#609208}
-
David 'Digit' Turner authored
This patch fixed the base::trace_event::TraceEvent::Reset() method to ensure that it never creates dangling pointers. This can happen in the following case: - TraceEvent::Initialize() is called on an instance, with TRACE_EVENT_FLAG_COPY set in the |flags| argument. This will copy argument names, copyable string values, as well as the name and scope into a single heap allocated buffer backed by |parameter_copy_storage_|, and will also adjust all internal pointer fields to point to it. - TraceEvent::Reset() is called on the same instance, this frees the storage area, but before this CL did not update the internal pointers, who were now dangling into heap-free memory! - Later, some code will iterate over the arguments with a loop like: for (int i = 0; i < kTraceMaxNumArgs && arg_names_[i] != nullptr; ++i) { ... } The assumption being that an arg_names_[i] value of nullptr indicates the end of list. Unfortunately, in the case above, this will read completely invalid values from memory. + Fix TraceEvent::MoveFrom() to call other->Reset() to ensure that the source instance is left in consistent state. I believe this is the source of flakiness on many tests related to TraceEvent, and hope this fixes it. BUG=905624,899813 R=oystene@chromium.org,primiano@chromium.org,alexilin@chromium.org,pkl@chromium.org Change-Id: I63cbadc728130cddc68b8c92b28e1e3f584793f4 Reviewed-on: https://chromium-review.googlesource.com/c/1340308 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:Peter Lee <pkl@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#609207}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6340200508f8..ecb09be23157 Created with: gclient setdep -r src-internal@ecb09be23157 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ib075e2ef3d8f0d384cc1d1c4c2d1265cf9bb0124 Reviewed-on: https://chromium-review.googlesource.com/c/1341564Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609206}
-
Koji Ishii authored
Following bot results are included. 11841 11844 11850 11855 11857 11861 11868 11873 11876 11877 11879 11885 11886 11890 11903 11913 11919 11921 11923 11925 11935 0 lines were removed and 3 lines were deflaked by consecutive results since 11877. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: I42b2db12e91066fb87b5d8c81b4a8b18d6bb3a7f Reviewed-on: https://chromium-review.googlesource.com/c/1337213 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#609205}
-
Christopher Lam authored
This CL adds a WebUI for App Management that replaces chrome://apps when the feature NewAppManagement is enabled. This involves: - adding the feature - adding a new MojoWebUIController - adding a mojom, and its C++ handler - adding a skeleton HTML and Polymer 'app' element - adding a BrowserProxy which connects the Renderer JS to the backend C++. Bug: 906508 Change-Id: Iac5be9ce82dc2cb0b1c77301ca43ccf7a99f318f Reviewed-on: https://chromium-review.googlesource.com/c/1309380 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#609204}
-
Tetsui Ohkubo authored
This CL implements animation for clearing all Notifications. This CL does not accurately implements the animation as the spec. For the UX spec, see the bug. TEST=UnifiedMessageListViewTest BUG=897915 Change-Id: I750b3a3e9d86706bef7c9cd13474dbff986486e9 Reviewed-on: https://chromium-review.googlesource.com/c/1312176Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#609203}
-
Giovanni Ortuño Urquidi authored
Un-capitalizes all instances of "radio" to make them consistent. TBR=dominickn@chromium.org Bug: 870192 Change-Id: Ibf38e8eae85d2ae05a2f82788193fec880f6a46a Reviewed-on: https://chromium-review.googlesource.com/c/1341773Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#609202}
-
Dean Liao authored
We used to get V4L2ImageProcessor instance from constructor and perform initialization later. And Initialize() set several data members which are not changed after Initialize(). With factory method, Create(), we can perform Initialize() before constructing V4L2ImageProcessor instance. And those data members set by Initialize() can be const-qualified. This commit is a leading commit for using VideoFrameLayout to encapsulate input/output format and size. Because VideoFrameLayout is a const object, the input/output VideoFrameLayout variables for creating V4L2ImageProcessor should be determined before calling constructor. Thus factory method becomes a natural design choice. BUG=b:110815424,b:73752373 TEST=Run VEA VDA unittest on devices (peach_pit and elm) VEA: video_encode_accelerator_unittest \ --test_stream_data=bear-320x180.yuv:320:180:1:bear.mp4:100000:30 \ --disable_flush --single-process-tests -v=0 VDA: video_decode_accelerator_unittest \ --test_stream_data=/usr/local/video/test-25fps.h264:320:240:250:258:\ 35:150:1 -v=0 --disable_flush --single-process-tests --ozone-platform=gbm Change-Id: I6909b2c1dbe5eda5845681a51af9e3d1c88d89ec Reviewed-on: https://chromium-review.googlesource.com/c/1339084 Commit-Queue: Shuo-Peng Liao <deanliao@google.com> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#609201}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bea23e4d..55d0017c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6785c04a89de242ce474ed134405fb167397f522 Reviewed-on: https://chromium-review.googlesource.com/c/1340507Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609200}
-
Owen Min authored
chrome/browser/policy/browser_dm_token_storage* chrome/browser/policy/machine_level_user_cloud_policy* chrome/browser/policy/cloud/machine_level_user_cloud_policy* components/policy/core/common/cloud/machine_level_user_cloud_policy* Including: Change-Id: If7c4e8c68591db7c227748ab156475dc280e7212 Reviewed-on: https://chromium-review.googlesource.com/c/1340365Reviewed-by:
Georges Khalil <georgesak@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Commit-Queue: Drew Wilson <atwilson@chromium.org> Cr-Commit-Position: refs/heads/master@{#609199}
-
Yuki Shiino authored
This patch introduces a new counter part of BindingSecurity (in core/ component) as BindingSecurityForPlatform (in platform/ component). BindingSecurityForPlatform is a simple collection of trampolines to BindingSecurity. Change-Id: I41195111ff2f288ee3e314048ac92848adf6be0b Reviewed-on: https://chromium-review.googlesource.com/c/1340439Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#609198}
-
Dean Liao authored
According to https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md#object-ownership-and-calling-conventions scoped_refptr should be passed by value, not by reference. This CL focus on image_processor. More than 200+ lines need to be fixed in media/gpu: ~/chrome/src/media/gpu$ grep -r "const scoped_refptr<.*>&" | wc 226 1068 21515 BUG=chromium:906479 TEST=Run VEA VDA unittest on devices (peach_pit and elm) VEA: video_encode_accelerator_unittest \ --test_stream_data=bear-320x180.yuv:320:180:1:bear.mp4:100000:30 \ --disable_flush --single-process-tests -v=0 VDA: video_decode_accelerator_unittest \ --test_stream_data=/usr/local/video/test-25fps.h264:320:240:250:258:\ 35:150:1 -v=0 --disable_flush --single-process-tests --ozone-platform=gbm Change-Id: I963501af745124e565eee4a3febf5a0957d53e10 Reviewed-on: https://chromium-review.googlesource.com/c/1341288Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/42fbb1521607..6340200508f8 Created with: gclient setdep -r src-internal@6340200508f8 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I59ddb3b867746c03f5034fbc4d0495ac60c1be48 Reviewed-on: https://chromium-review.googlesource.com/c/1341563Reviewed-by:
-
Yuta Kitamura authored
This reverts commit 15fef9cc. Reason for revert: Likely introduced flaky assertion failure (bug 906353). Original change's description: > RC: Set Frame->Process association at RenderFrameHost creation. > > At present this is only done at navigation time, which can leave frames > disconnected from their hosting process. > > Bug: 901828 > Change-Id: I611eafebe5e7e54c046def38bbaf5b348dedfcb9 > Reviewed-on: https://chromium-review.googlesource.com/c/1318405 > Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608994} TBR=fdoray@chromium.org,wfh@chromium.org,jochen@chromium.org,siggi@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 901828,906353 Change-Id: Idd7f4f1caf9a6ab884fd6de17ebb84b09e2c201e Reviewed-on: https://chromium-review.googlesource.com/c/1341294Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#609195}
-
Takashi Toyoshima authored
This patch makes Chrome Extensions to call BrowserContext functions to have right permission access lists in all relevant processes including NetworkService that also has CORS checks. Since NetworkService is accessed over mojo, all operations need to be asynchronous. This requires that PermissionsUpdater take a completion callback to let callers know its completion. PermissionsUpdater now relies on a private helper class that outlives it to handle the asynchronous completion. Bug: 870172 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I1c0642f162a0a71034c2529262150dbf4a1e4da8 Reviewed-on: https://chromium-review.googlesource.com/c/1186382 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#609194}
-
Yoshifumi Inoue authored
Because of offset mapping doesn't use |BoxInfo| and creating |BoxInfo| also causes side-effect to mark layout objects |InNGInlineFormattingContext| this patch changes |NGInlineItemsBuilderTempalte<T>| not to use |BoxInfo| for offset mapping. This patch is follow-up the patch[1] and preparation of the patch[2]. [1] http://crrev.com/c/1327582 Make NGOffsetMapping available for non-LayoutNG LayoutBlockFlow [2] http://crrev.com/c/1337224 Utilize NGInlineNode::GetOffsetMapping() in Element#innerText Change-Id: Id5a9d9c4e998261cfa57ec24fc9e268b002a8617 Reviewed-on: https://chromium-review.googlesource.com/c/1341293 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Stuart Langley authored
- For cr-dialog-button (e.g. delete file dialog) use css to set the order so that the ok button is on the right of the cancel button. - For the dialog footer just modify the html so that the ok button comes after the cancel button. Tested visually as there are no automated tests for style. Bug: 844168 Change-Id: Ia6eb652928cba50dd30cb8324b9c33ac13d46df2 Reviewed-on: https://chromium-review.googlesource.com/c/1341283Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#609192}
-
Sam McNally authored
Bug: 903637 Change-Id: Ic9f49f7de59210e400a578060eb611fafebe193f Reviewed-on: https://chromium-review.googlesource.com/c/1341287 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
-
Luciano Pacheco authored
Quick view: Style audio and video to have cursor pointer on their buttons Bug: 848216 Change-Id: I181cd2d3da2721d8c5bce837f0721435d4850297 Reviewed-on: https://chromium-review.googlesource.com/c/1341730Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e22505b4f07f..01979132133e git log e22505b4f07f..01979132133e --date=short --no-merges --format='%ad %ae %s' 2018-11-19 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@01979132133e The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=csmartdalton@chromium.org Change-Id: I7da676ba699bf377d65441bcfe82f95ff167f31b Reviewed-on: https://chromium-review.googlesource.com/c/1341561Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609189}
-
Joel Hockey authored
Setting |overflow: none| in .progress-frame fixes it to display long filenames and the open/close controls within the visible space and intended. Bug: 825289 Change-Id: Id5027bf73961063f8568083d744264e9021aeb1a Reviewed-on: https://chromium-review.googlesource.com/c/1341728Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#609188}
-
Noel Gordon authored
Bug: 905930 Change-Id: Ice0fb6efbfdaa7f52463cb9876d50b85b9900989 Reviewed-on: https://chromium-review.googlesource.com/c/1341298Reviewed-by:
-
tby authored
Add UMA logging for the error status of the ALS, the brightness monitor, and the validity of the user's personal curve at initialisation. Bug: 881215 Change-Id: I63f5e9da17cf9ee5e67ce67a2b7646751bbd808e Reviewed-on: https://chromium-review.googlesource.com/c/1319310 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#609186}
-
Joel Hockey authored
In FilesApp, we set |overflow: auto| on .cr-dialog-container to allow scrolling on dialogs such as the chrome web store dialog which requires scrolling to work on small screens. The pulse event when a user clicks on .cr-dialog-container causes the frame (dialog box) to increase in size by 2% for 180ms. This is causing scrollbars to flash on during that time which is not desirable. By setting the pulse to increase the entire .cr-dialog-container rather than just the frame, we get the same intended visual effect, but without scrollbar flicker. Bug: 883671 Change-Id: I3fb75bef14059bc92b8baa2367290a16b0b0e08f Reviewed-on: https://chromium-review.googlesource.com/c/1341432Reviewed-by:
Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#609185}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7eaaf1ff7e99..42fbb1521607 Created with: gclient setdep -r src-internal@42fbb1521607 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ibe06f4f238dc2214f5630ceaf234acf5ff4253bc Reviewed-on: https://chromium-review.googlesource.com/c/1341560Reviewed-by:
-
Manu Cornet authored
A few changes here: * Specify padding on both ends of the whole tray separately (instead of using space around some tray items to build it up) * Override the size function for the battery to better match its actual visual footprint. * Specify padding between items with one single number, used at the layout level. This all allows for simpler code while better matching the specs. Bug: 901989 Change-Id: Ia75dcfc7b355b114e6492c26ee4ce6372af92f71 Reviewed-on: https://chromium-review.googlesource.com/c/1328042 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#609183}
-
Luciano Pacheco authored
Change RootPath for Downloads volume when MyFilesVolume is enabled, add /Downloads to RootPath, so tests navigate to MyFiles/Downloads sub-folder by default. This allows to run the tests run with the same code with and without MyFilesVolumeFlag. Change the Downloads localized label when MyFilesVolume is enabled to use MyFiles translation, this fixes the label displayed in the breadcrumbs and in the directory tree. Change the ordering of the directory tree from EntryListItem which is used for MyFiles to sort native folders above Linux and Play files volumes. Add iconOverrides to directory tree to allow customization of folders icons based on RootyType and the fullPath, to customize Downloads folder icon when MyFilesVolume is enabled, since Downloads is just a plain folder inside MyFiles volume. Enable a few more tests to run with MyFilesVolume flag enabled that covers the breadcrumbs and the sorting changes. Bug: 873539 Change-Id: Ic46e00404f9295175f97cfd9a91686419636d3af Reviewed-on: https://chromium-review.googlesource.com/c/1338594 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#609182}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/40c3ad6ce9c4..7eaaf1ff7e99 Created with: gclient setdep -r src-internal@7eaaf1ff7e99 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I194f7a4c3e258a44f57acc2ec224a032603f328b Reviewed-on: https://chromium-review.googlesource.com/c/1341557Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I08d71109acb7d75b49b82b36a6a8df0668346c72 Reviewed-on: https://chromium-review.googlesource.com/c/1341558Reviewed-by:
-
Stuart Langley authored
I did a bit of a code search and could not find this being used anymore, so removing it as per the suggested bug. - Added an assert just in case it was being used and my code search skills were not good enough, so we can roll it back. - Closure compile the unit tests while I am at it. Bug: 700272 Change-Id: I5523bbff983fbad3be886319d17278e4673915e3 Reviewed-on: https://chromium-review.googlesource.com/c/1341433Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#609179}
-
Sam McNally authored
Bug: 893081 Change-Id: I0d5e38e3bdb7666252e8dc4d943f40af831fdbcb Reviewed-on: https://chromium-review.googlesource.com/c/1341443Reviewed-by:
-
Kent Tamura authored
This is a follow-up CL of http://crrev.com/c/1335069. Bug: 687843 Change-Id: I873dba8174a99c031e34f3e1f32672c6d275aea4 Reviewed-on: https://chromium-review.googlesource.com/c/1337143 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#609177}
-
Giovanni Ortuño Urquidi authored
calamity is the original author of BookmarkAppHelper and is working on its replacement. Change-Id: I59ff43a2f0ed250cd597b8ebf238ea73a74676ca Reviewed-on: https://chromium-review.googlesource.com/c/1341669Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#609176}
-
John Z Wu authored
Add a return value to indicate if suggestion was allowed. Also fix associated test. Bug: 898990 Change-Id: I22f00cef28dc5a82d431cc49191e956e47cd5e40 Reviewed-on: https://chromium-review.googlesource.com/c/1341148Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#609175}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: Ieef0d3ae87ccaffd92c6bcd37fac45e73208bac2 Reviewed-on: https://chromium-review.googlesource.com/c/1341649Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#609174}
-
Alexey Baskakov authored
Bug: 875698 Change-Id: I6f5b88901728799d81ae493b3dd1bcae0530bc54 Reviewed-on: https://chromium-review.googlesource.com/c/1341286Reviewed-by:
-
Luciano Pacheco authored
Reduce metadata box width from 320px to 250px when the window is narrow (less than 720px). Reduce quick view main content left/right padding when window is less than 720px wide, from 32px to 4px. Change audio art work to be 100% width and height so it resizes with the window in the same way as video quick-view. These three changes allows for a proper display of audio tag controls when the window is narrow. See screenshot in the linked bug. Change some CSS order, 0.2s to 200ms and -webkit prefix to comply with presubmit. in behaviour. Also checked with video, img and pdf quick views. Test: Checked manually the visual with a window 480px wide, no change Bug: 641629 Change-Id: I4af2c8ea83f9167c6c398c0002ee2df8ec6a5531 Reviewed-on: https://chromium-review.googlesource.com/c/1341439Reviewed-by:
-
Anand K. Mistry authored
The FSP implementation doesn't handle the difference between "not implemented" and "error". Zip archiver doesn't provide any custom actions, but FSP interprets this as an error and that bubbles back to the Files App. BUG=679634 Change-Id: I5b52c64b0d01bd700ea4509d046630396afa756c Reviewed-on: https://chromium-review.googlesource.com/c/1341435Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#609171}
-
Alexey Baskakov authored
In WebAppDataRetriver. Bug: 901226 Change-Id: I4db47a0e51c6f6aa89fbfe0fa502e08aeb4036aa Reviewed-on: https://chromium-review.googlesource.com/c/1341285 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
-
Amos Lim authored
SyntaxErrorInOwnersFile: /home/amoseui/Workspace/chromium/src/third_party/WebKit/LayoutTests/OWNERS:4 syntax error: //third_party/WebKit/Tools/OWNERS does not refer to an existing file. third_party/WebKit/Tools/OWNERS was removed in https://crrev.com/c/1338583 Replace third_party/WebKit/Tools/OWERS with third_party/blink/tools/OWNERS as it was included in third_party/WebKit/Tools/OWERS. NOTRY=true NOPRESUBMIT=true Bug: 829697 Change-Id: I3ac65d16964b8dbbbaad9228d37dec88c0577f80 Reviewed-on: https://chromium-review.googlesource.com/c/1341440 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#609169}
-
