- 15 Jan, 2021 40 commits
-
-
Aaron Leventhal authored
Before this CL, the following problems with parent traversal existed: 1. ComputeParent() was called many times before a parent was cached 2. It's technically possible for ComputeParent() to provide a different result than the object that added a child, although no known cases are identified, it's dangerous to have complex asymmetrical code. 3. Several methods such as Init(), UpdateCachedValueIfNeeded() and AddChildren() sometimes ended up reentering on the same object. This CL addresses these issues by: 1. Passing in the correct parent when a child is being added 2. Caching the parent when an object is initialized. Therefore ComputeParent() is only called once per object 3. Requiring that all non-root objects have a parent (DCHECK) 4. Do not allow Init(), UpdateCachedValueIfNeeded() or AddChildren() to reenter on the same object (DCHECK) In addition, the code is simplified by removing several parent-related methods that are no longer necessary, and by reducing the number of member variables related to ignored state. The ignored changes are from a previous CL that was reverted due to an incorrect assumption that a null parent meant that it was a first-time call to UpdateCachedValuesIfNeeded(). Clear improvements in a number of test results, including: - children-changed-only-on-ancestor.html (remove redundant events) - aria-owns-grid-expected.txt (now passes) - canvas-select-row-expected.txt (now passes) - 7.5% improvement in perf_tests for SendPendingAccessibilityEvents + ProcessDeferredAccessibilityEvents Bug: None Change-Id: I38478dca9e5c87645cbbfd35d8e4bbad6e29489a Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528573 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#844046}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/29eeb610bd49..5678b56f5e21 2021-01-15 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from fabc0b0b to 2ef9c5ff (556 revisions) 2021-01-15 syoussefi@chromium.org Vulkan: Generate gl_Position pre-rotation in SPIR-V If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I44ee0bfeed6d4faf6214b9120615cc3be46dfa92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632829Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844045}
-
Christoph Schwering authored
This CL migrates the input and pattern base::string16 of autofill::MatchPattern() to base::StringPiece16. Bug: 1007974 Change-Id: I6c5c1b21ad39bc6317bbc51e1e5c3c4b24455aee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628289 Commit-Queue: Matthias Körber <koerber@google.com> Auto-Submit: Christoph Schwering <schwering@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#844044}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3abe4703fa62..eaa61fcb0fb4 2021-01-15 janscheffler@chromium.org [JSDOC2TS]: Migrate devices If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1158760 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9c96ddd9e160c3ba6d3eae335b6e260e879d759e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633065Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844043}
-
Manuel Rego Casasnovas authored
The test paint/invalidation/outline/focus-ring-on-child-move.html has the same expectations for all platforms. Change-Id: I29bf9a55cd8034548e8ac2f312fa1a6c9e136a34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631268Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#844042}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. AX-Relnotes: n/a. Bug: 1145565 Change-Id: Ide01818d784540cbb5302e7cfd1e98fbbeda175b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626183Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#844041}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610679078-e6bf7486827a51823717a01d08f3ea1e32a813ef.profdata to chrome-win64-master-1610700976-d7ed4801f0bf655f1a5ed007c5aa96678f4cba28.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Idff46878931b9499c5318e062c07ac4e77a5a60a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632828Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844040}
-
Sanja Perisic authored
Added support for SystemDisabledMode policy for the Chrome Web Store, so that CWS can now be hidden if that is the preferred disabled mode. Bug: 1142785 Test: SystemFeaturesPolicyTest.DisableWebStoreAfterInstallWithModes Change-Id: I5cb731f6d071413f06563b19ea6ad365cb44c053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622375 Commit-Queue: Sanja Perisic <sanjaperisic@chromium.org> Reviewed-by:
Anqing Zhao <anqing@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#844039}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f79e432021a1..428143ee24c5 2021-01-15 yyanagisawa@google.com Revert "Check whether goma is running when it is enabled" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1167064,chromium:868590 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ie275785c055678856f3c42e82fde84bf2a8bd8e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632830Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844038}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f54810158ebb..f46e9e72306f 2021-01-15 perezju@google.com Remove experimental/long_term_health If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1060074 Tbr: oysteine@google.com Change-Id: I833e56d8a3af4b0167aad84ad8746375af9ad25c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632826Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844037}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ibb45ef20ee6d1328a5fe9946f386bb07659ede50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632332Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844036}
-
Mikel Astiz authored
The logic is behind a newly-introduced feature toggle: the idea is that bookmark commits to the server now contain a client tag hash, which is the hash of the bookmark's GUID. Populating this field is a simple change in BookmarkLocalChangesBuilder but additional sophistication is introduced to guard against in-flight commits and the time a user transitions from the feature being disabled to being enabled (which can theoretically run into duplicates). Note that the validation of the client tag hash for incoming updates is *NOT* behind a feature toggle, but that is believed to be non-controversial because there aren't many other options for defining the client tag for bookmarks. Bug: 1032052 Change-Id: I07448ad405849b29295c3090d3708d3a562e32e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623934Reviewed-by:
Rushan Suleymanov <rushans@google.com> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#844035}
-
Frédéric Wang authored
SecurityOrigin::IsSecure() is very similar to the concept of "potentially trustworthy URL" defined in [1] and implemented by network::IsUrlPotentiallyTrustworthy(), but it has historically been hard to compare them. After previous refactoring they are quite close. This CL is yet another iteration. SecurityOrigin::IsSecure() is rewritten to use a similar implementation based on GURL and url::Origin. Spec comments are also added to make the difference more obvious. IsSecure() currently returns true if the URL scheme is in the secure list [2] or possibly one wrapped in a blob: or filesystem:. The constructor of url::Origin automatically unwraps this kind of URLs but is also more restrictive about accepted schemes [3]. In particular, about: and data: URLs or URLs with schemes registered as "secure" but not "standard" will now generate invalid origins. Special cases from network::IsUrlPotentiallyTrustworthy() are added to preserve behavior with about: and data: schemes, although some weird edge cases like "about:about" or "blob:about" are no longer treated as secure. Behavior for all standard secure schemes (including https, wss, quic-transport) are preserved. All these changes makes IsSecure() closer to the spec definition of "potentially trustworthy URL". The rest of the IsSecure() handles opaque and allowedlist origins, which is again just a subset of the work done by network::IsUrlPotentiallyTrustworthy() and can be rewritten accordingly. [1] https://w3c.github.io/webappsec-secure-contexts/#is-origin-trustworthy [2] https://source.chromium.org/chromium/chromium/src/+/master:url/url_util.cc;l=63;drc=65a062c4528790ff3651920ba9a3934df184e1bc [3] https://source.chromium.org/chromium/chromium/src/+/master:url/origin.cc;l=47;drc=721926d0cf09b42968ec8481792fcd6fa4edab7b Bug: 1153336 Change-Id: I8f4a42f89a9ae13016a20a1e242c1efd48874162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617709Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#844034}
-
Julie Jeongeun Kim authored
This CL refactors printing unit tests not to use OnMessageReceived since the printing legacy IPCs will be converted to mojo. It is a precursor of converting PrintHostMsg_DidStartPreview and PrintHostMsg_DidGetDefaultPageLayout. Bug: 1008939 Change-Id: I220076282c95e361d9ab3b8264dc0c754e4017db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615736Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#844033}
-
Clemens Arbesser authored
autofill_assistant:browser and its unittests should not depend on platform-specific stuff. Change-Id: I29c798130b0cbd171e87b47ccb3b8cbfceb9685e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631486 Auto-Submit: Clemens Arbesser <arbesser@google.com> Commit-Queue: Marian Fechete <marianfe@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#844032}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610679078-fe2bb289a257049a216843cebd228815ff771bd5.profdata to chrome-win32-master-1610690109-0f7956766f9641d6835b78b89edaf84f3a491ef2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I9f9ff71006693aec5679616a931070bf7333bfdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632334Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844031}
-
Titouan Rigoudy authored
Contrary to crrev.com/c/2627421, this did not need to make it into M89. Bug: chromium:1124358 Change-Id: Icfd9e4088286f7e8b5576e49c63bafa6c60bc5e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628296 Auto-Submit: Titouan Rigoudy <titouan@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#844030}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/091f5ac0a64c..f79e432021a1 2021-01-15 yyanagisawa@google.com Revert "Avoid capture_output to support Python 3.6" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1167064,chromium:868590 Tbr: sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com Change-Id: I0f4db8b68c0f22aba4e7dddee528ccb7f5739691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632825Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844029}
-
Frédéric Wang authored
After previous refactoring, the body of SecurityOrigin::IsPotentiallyTrustworthy is essentially equivalent to network::IsOriginPotentiallyTrustworthy, except that it first DCHECKs the protocol is not "data" and handles opaque origins specially. This CL relies on network's method to implement SecurityOrigin's one in order to reduce code duplication. There should be no visible behavior change. Bug: 1153336 Change-Id: Ib88bd716174d4ac68c50bcc99a82fd2e51303b93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615260Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#844028}
-
Yutaka Hirano authored
In order to fix crbug.com/1167013, we need to introduce a breaking change. Introduce a use counter to estimate the size of the impact. Bug: 1167014 Change-Id: I6f525aa8ec38fa1fa964f4ede3d1f55863d705d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631550 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#844027}
-
Clemens Arbesser authored
Bug: b/176890422 Change-Id: I229923bf68af34376917a0def846cec0adff9183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627424 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#844026}
-
Asami Doi authored
The new test checks if `clients.matchAll()` can detect a blob URL worker client. The test passed when the PlzDedicatedWorker feature is enabled and fails when it is disabled. Bug: 1017034 Change-Id: Ib5b0916c2b9a4068b379769236bd0da2c6285a5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629330 Commit-Queue: Asami Doi <asamidoi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#844025}
-
Francois Doray authored
[sheriff] Disable ExtensionInstallDialogViewInteractiveBrowserTest.InvokeUi_ManyPermissions on Windows for real. R=bsep@chromium.org Bug: 1166152 Change-Id: Id951f8454e6f15f2e7401bf92ab5590cd95c218b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626050 Auto-Submit: François Doray <fdoray@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#844024}
-
chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/d28e6c52e05e..cb31feffa500 2021-01-15 fabiansommer@chromium.org Enable saigo llvm regression tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/nacl-autoroll Please CC mseaborn@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1106311 Tbr: mseaborn@chromium.org Change-Id: I51e1579a1af780afb801873266c45fa7e45f5600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631794Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844023}
-
Benoit Lize authored
(v)asprintf() allocates internally, and is implemented by libc. This makes Chrome crash with PartitionAlloc on Android, since the allocated memory will be freed by PartitionAlloc even though it was not allocated by it. Implement (v)asprintf() ourselves, and wrap it. Bug: 1166558 Change-Id: I4b5ce4be55bd818a029009fa9eb37e123df7f2d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629707 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#844022}
-
Martin Robinson authored
Instead of mapping the ARIA combobox role to other roles on MacOS, always use it unless it is applied to a multiline edit field. This matches the specified behavior and other browsers. These were originally mapped to other roles because of VoiceOver failures that have been fixed with other changes. Bug: 1125165 Change-Id: I26b8ccb006c15d6329da1c29193640f529fab781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611093Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#844021}
-
Alex Ilin authored
This CL adds an experiment parameter that allows to control after how many times user declined the profile switch bubble we stop showing the profile switch bubble. The parameter is called "max_profile_switch_declined_count". It can have the following values: - N < 0 - we always show the bubble when eligible - N == 0 - we never show the bubble - N > 0 - we stop showing the bubble after the user declines it N times Bug: 1166851 Change-Id: Ic165216a338a11d5730e582cd3c2045d107266f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630805Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#844020}
-
Mihai Sardarescu authored
This CL ensures that GetStartupProfile() and GetStartupProfilePath() have the same behavior to return the Guest profile when the profile picker needs to be shown. This fixed the bug below as ProcessCommandLineAlreadyRunning() path uses GetStartupProfilePath while ChromeBrowserMainParts::PreMainMessageLoopRunImpl() was using GetStartupProfile(). Bug: 1166166 Change-Id: I53a363c87ae0957fdf35a197755979c33141c975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628990Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#844019}
-
Anastasiia N authored
Move `SigninHelper` class from chrome/browser/ui/webui/signin/inline_login_handler_chromeos.cc to chrome/browser/ui/webui/signin/signin_helper_chromeos.cc Bug: 1140469 Change-Id: Ia6c79410085240dc6c56e053ac595f9e3138d805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550546 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#844018}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/57654f96e343..3abe4703fa62 2021-01-15 szuend@chromium.org Revert "[module.json extensions] Migrate @ViewLocationResolver in elements/" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1134103 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ibefd6031050bd9d9fbe861f9b7f8141b7d6ef606 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631791Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844017}
-
Fredrik Söderqvist authored
Since the oBB is in unzoomed space but the <foreignObject> local-to-parent transform performs adjustment for zoom we need to perform correction when propagating it. Similarly change LayoutSVGForeignObject::StrokeBoundingBox() to return the same bounds as VisualRectInLocalSVGCoordinates() (which is zoomed). Bug: 1162993 Change-Id: I430cd7832b37475ef1d139997ef5ac5c0bcc17c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627491Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#844016}
-
Anatoliy Potapchuk authored
This reverts commit dd223e70. Reason for revert: these tests have been failing constently on MSAN builders https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests Original change's description: > Add browser tests for AppLaunchHandler. > > Add browser tests for AppLaunchHandler to verify the restoration > process. > > BUG=1146900 > > Change-Id: Ibeaf262080a24c680718888ee081cc62c5b21a3a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619245 > Commit-Queue: Nancy Wang <nancylingwang@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843901} TBR=xiyuan@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,nancylingwang@chromium.org Change-Id: Icc6cc9ccbf6fcb0759bf2d03efd2d25a31d90d44 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1146900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632606Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#844015}
-
Sylvain Defresne authored
For device that do not support multi-window, the persistent identifier returned by -[UISceneSession persistentIdentifier] may change when the user "swipe" the app (as this gesture is interpreted as "close window" under certain circumstances). In preparation for using a stable identifier (i.e. a constant) for devices that do not support multi-window, do not access the value from UISceneSession directly in Chrome but instead through SceneState. There is one location that is still using -persistentIdentifier: the code responsible for recording the OS message asking Chrome to purge old session data. It is find to use -persistentIdentifier there because the value is correct for device that support multi-window, for other device the value is not used as part of a path to save data thus it is benign to try to delete data from a place that does not exists. Bug: 1165798 Change-Id: I5169b5c0be961987ef8e1edc9c122947848268e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626440Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#844014}
-
Jan Wilken Dörrie authored
This change modifies `IsPossibleUsernameValid` to require that the possible username is part of an already saved credential for the same site. This will be later extended to only require a match with a local username saved on any site. For robustness the username and the set of allowed usernames are canonicalized, that is case and email providers are irrelevant. The existing requirements to only be ASCII and to not contain whitespace are dropped. Bug: 959776, 1167042 Change-Id: Ic50c954ddd7a4fd969c56295825ae717c870b915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627278 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/master@{#844013}
-
Andreas Haas authored
This reverts commit 6e5458b0. Reason for revert: UMA metrics cause errors when more than one WebAssembly module gets compiled, see https://bugs.chromium.org/p/chromium/issues/detail?id=1163528 Original change's description: > [v8-browsing] Add WebAssembly UMA metrics to v8-browsing > > This CL brings WebAssembly UMA metrics to the v8-browsing benchmark in > Telemetry. > > R=mythria@chromium.org, clemensb@chromium.org > > Bug: chromium:1084929 > Change-Id: I28e72378774c3d599da1ad670ba036a3f0ea84e0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497164 > Reviewed-by: Mythri Alle <mythria@chromium.org> > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: Andreas Haas <ahaas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820779} TBR=ahaas@chromium.org,mythria@chromium.org,clemensb@chromium.org,johnchen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1084929, chromium:1163528 Change-Id: Id160376c4f56c160cf48bb9575e4b3c6d629e540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627153Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#844012}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b2af2da3481c..f54810158ebb 2021-01-15 dberris@chromium.org Revert "chromeperf: Anomaly configs in subscriptions" 2021-01-15 dberris@chromium.org chromeperf: Remove outdated documentation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1158326 Tbr: oysteine@google.com Change-Id: Ia5ec64506320f332d3a31db3a564ffe8151167fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632367Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844011}
-
Jérôme Lebel authored
Fixed: 903396 Change-Id: I4f2b7fa2d80f5248a6c9c04681bb8494e39061f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391131 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#844010}
-
Antia Puentes authored
This CL migrates the legacy IPC message out of extension_messages.h to Renderer mojo interface from extensions.mojom. Bug: 1165814 Change-Id: I338e9e1e59321d143053ec4c47bed7234c04ae5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627270 Commit-Queue: Antia Puentes <apuentes@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#844009}
-
Alice Wang authored
This CL moves logSigninStartUserAction to SigninMetricsUtils to group the signin metrics logging methods in one place. Bug: 1163476 Change-Id: I515a2c04f4bac3541a0a3bcee4097c3dabab95cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611715Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#844008}
-
Sami Kyostila authored
Chrome is about to switch to the TRACE_EVENT macro implementation provided by Perfetto. The new implementation requires trace event statements to be terminated by semicolons, so this patch modifies the codebase to add semicolons where they were previously left out. No functional changes. Bug: 1006541 Change-Id: I589aed41f82edb909194234a5561e3096ca14a41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627406 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#844007}
-