GitLab

The element is no longer used. All usages have been migrated to cr-toggle.

Bug: 768073
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia02580497b901732defdbc7e75fc4eaedf2b0413
Reviewed-on: https://chromium-review.googlesource.com/1053416Reviewed-by: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557603}

Change-Id: I349768cec84b3545ca35f8836fdbd83fda6c2bc2
Reviewed-on: https://chromium-review.googlesource.com/1054193Reviewed-by: Simon Hatch <simonhatch@chromium.org>
Commit-Queue: Emily Hanley <eyaich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557602}

Material Refresh - Now fades in/out the tab separator and the close button in conjunction with the glow hover effect.

Bug: 822061
Change-Id: Ic4c339c54a61d7f00ff8eedc1ae20c6176440aec
Reviewed-on: https://chromium-review.googlesource.com/1052382
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557601}

https://pdfium.googlesource.com/pdfium.git/+log/35557c3ce83c..95061379c945

$ git log 35557c3ce..95061379c --date=short --no-merges --format='%ad %ae %s'
2018-05-10 rharrison Do not build BMP when codec is disabled

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I19cd1fa0a5bcc56e1eebc140005399d8585d155c
Reviewed-on: https://chromium-review.googlesource.com/1054090
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#557600}

This reverts commit 8b972f42.

Reason for revert: Incompatible with the latest fidlgen

Original change's description:
> [Fuchsia] Update namespace in generated FIDL files.
> 
> Currently fidlgen uses the namespace that's specified in the .fidl file.
> As result the generated code may collide with other code in
> chromium. This CL implements a temporary workaround for this problem:
> generated code is updated to use a namespaces nested in fuchsia::
> namespace. The script won't be necessary after FIDL-160 is resolved.
> 
> Bug: 831384
> Change-Id: I3648f89f44a8e0148b1cc6b58d6f3a8de82a684e
> Reviewed-on: https://chromium-review.googlesource.com/1045257
> Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#556882}

TBR=dcheng@chromium.org,kmarshall@chromium.org,mmenke@chromium.org,sergeyu@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 831384
Change-Id: Icde5c76db4abd1730e525bbd4f44bb8553caa409
Reviewed-on: https://chromium-review.googlesource.com/1054111Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557599}

This reverts commit f57e1c35.

Reason for revert: There are ash and mash_ash failures, reverting because it's ash-related. See crbug.com/841889


Original change's description:
> cros - Update appearance of resolution change notification.
> 
> This removes the last raster asset in ash_resources.grd, so remove that
> file and the associated build target.
> 
> Bug: 840509,505953
> Change-Id: I43ec69b5b8b9fc34aa71a1b65f204447e73b133c
> Reviewed-on: https://chromium-review.googlesource.com/1050523
> Commit-Queue: Evan Stade <estade@chromium.org>
> Reviewed-by: James Cook <jamescook@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#557292}

TBR=jamescook@chromium.org,sky@chromium.org,estade@chromium.org

Change-Id: I4b0ce3e1d01b5b8e390216b379f4158380f542b2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 840509, 505953, 841889
Reviewed-on: https://chromium-review.googlesource.com/1054118Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557598}

This ensures that the main thread as a CFRunLoop, which is required
by audio APIs on Mac.

Bug: 841845
Change-Id: I10be74d77c1585014a63896099eb2b4acb5b345b
Reviewed-on: https://chromium-review.googlesource.com/1054227
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Olga Sharonova <olka@chromium.org>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557597}

Bug: 841768
Change-Id: I7b2d23223f270c129a6c38510ba51cb0eca5f287
Reviewed-on: https://chromium-review.googlesource.com/1054212Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557596}

- Makes some small changes in order to make BookmarkEditVC and BookmarkFolderEditorVC navigation
toolbars appeareance more similar to the ElevatedToolbar they were using before.

Screenshots:
Old: https://drive.google.com/open?id=1uagROckekOJXPjwxu6HdhGfXUEoZtZ7v
New: https://drive.google.com/open?id=1btpW_JxZ-Kad0U0fgPtGuYrD03FceXQq

Bug: 839435
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ifbfc7ca44dad96bad6d6fc55788ecb1c670580a3
Reviewed-on: https://chromium-review.googlesource.com/1053390
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557595}

Bug: 829298
Change-Id: I24c6fb3fde3ad30f00801e096cd034e16642ce35
Reviewed-on: https://chromium-review.googlesource.com/1048625Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557594}

This is for testing purposes and will be removed after launching
variations in WebView: https://crbug.com/841623. Skipping presubmit for
LOG(INFO).

BUG=678288
NOPRESUBMIT=true

Change-Id: Ia100eb88a20b3155ef8d280e598644b3684990a0
Reviewed-on: https://chromium-review.googlesource.com/1053375Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Paul Miller <paulmiller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557593}

When exiting VR on chrome://crash (sad tab), the renderer doesn't send
any control offset updates, and resetting the overrides to the control
offsets for VR restores the hidden control values, so we need to tell
the controls to show explicitly.

Also fixes initialization when opening a new tab while in VR...

Bug: 837807
Change-Id: I14df5479156dc6ac981f845529f8c13aadbd15ac
Reviewed-on: https://chromium-review.googlesource.com/1052892Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557592}

This collapses most of the logic for painting composited
scrollbars into ScrollbarLayerDelegate. There was only one
path and lots of indirection before, most of which can now
go away.

This allows WebScrollbarImpl, WebScrollbarThemeClientImpl,
WebScrollbarThemeGeometryNative and WebScrollbarThemePainter
to be deleted. Bits of WebScrollbar remain, since there are
a handful of places that still use enums defined in its header.

Bug: 841751
Change-Id: Id37c75bc50e5138b44c5d6ba0add08f73ad71f0c
Reviewed-on: https://chromium-review.googlesource.com/1052919
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557591}

This allows for more full integration tests from the new button through
to the extension, in addition to the select_to_speak_browsertest.cc tests.

Bug: 753018, 840493
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib60ea7c5beea59b092fe1bb4d2ce68e27c9c347f
Reviewed-on: https://chromium-review.googlesource.com/1047947Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557590}

https://chromium.googlesource.com/catapult.git/+log/4a13b64861dc..0675e8b8e369

$ git log 4a13b6486..0675e8b8e --date=short --no-merges --format='%ad %ae %s'
2018-05-10 perezju [soundwave] Add test runner script

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: Ie990e68f09bc4d11fb5cd33cbbc840b1140d2098
Reviewed-on: https://chromium-review.googlesource.com/1053804Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#557589}

Bug: 840992
Change-Id: I0f11538f3c91371e7a0e18085ae79ade6a8d2a2d
Reviewed-on: https://chromium-review.googlesource.com/1053362
Commit-Queue: Eric Roman <eroman@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557588}

This constructs an SSLInfo with needed fields for SSLErrorTabHelperTest
tests (in particular, the SSLInfo.cert field). This fixes nullptr
dereference issues that were encountered in https://crrev.com/c/1046050

Change-Id: I154bf688fe9325f9094de59ab0c5f6cae2b137de
Reviewed-on: https://chromium-review.googlesource.com/1054103Reviewed-by: Adrienne Porter Felt <felt@chromium.org>
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557587}

Add support for the viewport-fit @viewport descriptor as
part of the CSS Round Display spec.

This also wraps ViewportFit in a base::Optional so we know
whether the value has been explicitly set.

BUG=838400

Change-Id: I5701fe88fabd4f4246b1ae436cd139d306d8c9f1
Reviewed-on: https://chromium-review.googlesource.com/1047946Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557586}

This changes the content of generated_resources.grd so that pop-up blocking
content now referes to both pop-ups and redirects.

Also removing a block of unused strings in generated_resources.grd.

Bug: 840356
Change-Id: I3a8657ccd3188a1019327bd5499ed19db31899b7
Reviewed-on: https://chromium-review.googlesource.com/1047687
Commit-Queue: Eric Robinson <ericrobinson@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557585}

This change removes all references to the Physical Web Service.

BUG=826540

Change-Id: I75a85182798073648dc0f5356b4373dddb54a662
Reviewed-on: https://chromium-review.googlesource.com/1040353Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Cait Phillips <caitkp@chromium.org>
Commit-Queue: Conley Owens <cco3@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557584}

This reverts commit 48f503a8.

Reason for revert: Failing the Linux Trusty Leak bot

Original change's description:
> Reland "Composite ScrollTimeline scrollSource when appropriate."
> 
> This is a reland of ddd9f0ee
> 
> Original change's description:
> > Composite ScrollTimeline scrollSource when appropriate.
> >
> > This CL makes being the scrollSource of an active (i.e. the scrollSource is
> > scrollable) and attached (i.e. it is being used by at least one WorkletAnimation
> > as a timeline) ScrollTimeline a compositing reason. It does not change the
> > requirement that the scrollSource must be composited for the WorkletAnimation to
> > be sent to the compositor, nor does it change the case where a scrollSource stops
> > being composited whilst a WorkletAnimation is running. Those will be addressed in
> > follow-up CLs.
> >
> > Bug: 776533
> > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > Change-Id: Icae43e1c9cfe2720cc739401c4766b592571f231
> > Reviewed-on: https://chromium-review.googlesource.com/1036934
> > Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
> > Reviewed-by: Majid Valipour <majidvp@chromium.org>
> > Reviewed-by: Philip Rogers <pdr@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#556541}
> 
> TBR=pdr@chromium.org
> 
> Bug: 776533
> Change-Id: I36cde2bb53e4c24fc57caef1e33f8dcac159ec77
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Reviewed-on: https://chromium-review.googlesource.com/1050547
> Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
> Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
> Reviewed-by: Majid Valipour <majidvp@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#557347}

TBR=pdr@chromium.org,majidvp@chromium.org,smcgruer@chromium.org

Change-Id: Ia89e6d42ef89fceebb1630dcdcbe3b1af6c71964
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 776533, 841844
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/1054116Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557583}

This mock clipboard host lives in browser process, essentially synchronizing
clipboard between OOPIFs.

In unit tests we instantiate the mock in-process and override the binder in
Connector so that WebClipboardImpl connects to it.

This patch discovered two issues with clipboard implementation which are being fixed:
- Blacklisting text/uri-list clipboard items does not allow them to be copied
  to clipboard. Old mock implementation masked this issues, while the new one
  exposed the issue caught by multiple tests.
- Unit tests sometime pass null strings to copy to clipboard, so we should
  ensure they are non-null in WebClipboardImpl.

One more semantic change is a rewrite of unit tests which read image from
clipboard to layout tests, where that functionality is available.

The rest is just plumbing of a new mock.

Bug: 775830, 607991

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ie63552228a9038cfd5e677d9f1bec5a2184662ad
Reviewed-on: https://chromium-review.googlesource.com/1034022
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557582}

These tests are failing already and with new V8 roll they will fail
differently.

TBR=dgozman@chromium.org

Bug: chromium:839947
Change-Id: I03399a6528e88d41025d577c44feec08f245d1ba
Reviewed-on: https://chromium-review.googlesource.com/1054187Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557581}

This is not used in production anymore.

Bug: 754872
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I8b68715ccfdf7805cd2d6024148690638c7c9f98
Reviewed-on: https://chromium-review.googlesource.com/1053304Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557580}

This reverts commit 1e0c32df.

Reason for revert: Fix issue that caused revert.

Tested unit tests on Windows with component and non-component build.

Original change's description:
> Revert "Enable device/vr unittests on non-Android platforms"
>
> This reverts commit 11ee8e61.
>
> Reason for revert: Suspected causing build failure on WebKit Win Builder (dbg)
> https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win%20Builder%20%28dbg%29/131035
>
> Original change's description:
> > Enable device/vr unittests on non-Android platforms
> >
> > Change-Id: I76eed7cf354d7f55e5409035941b76100d772b96
> > Reviewed-on: https://chromium-review.googlesource.com/1053093
> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> > Commit-Queue: Bill Orr <billorr@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#557320}
>
> TBR=mthiesse@chromium.org,billorr@chromium.org
>
> Change-Id: Ice684f6a36892c3b73c789617d40718a40d01745
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/1053153
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#557346}

TBR=mthiesse@chromium.org,thomasanderson@chromium.org,billorr@chromium.org

Change-Id: Icbeef0d1e1c9649cdebe9bdfa9a670399c7aa0c9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1053248
Commit-Queue: Bill Orr <billorr@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557579}

For consecutive clips in the same transform space, we combine the clips
in following more cases:
1. A rectangular clip and a rounded clip can bombine if the rectangular
   clip contains the rounded clip;
2. A clip path clip can combine with previous clips (but not following
   clips) if other combination conditions are satisfied.

Also no longer issue a pair of ClipRectOp and ClipRRectOp for one
rounded clip rect. It was needed when we didn't antialias clip rects.

Bug: 841227
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I2daf83ede63e3d6f65bd3eb5f89d8d1ca52cd440
Reviewed-on: https://chromium-review.googlesource.com/1052859
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557578}

The only code remaining in BookmarksTableView is directly related to the
UITableView or its loading and empty state backgrounds.

BUG=840381

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I79910f4d1bfbda5a586bb255c2b53f39ee20cb12
Reviewed-on: https://chromium-review.googlesource.com/1052905
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557577}

Includes incremental garbage collection infrastructure in regular
builds. Does not enable incremental marking at runtime!

Sheriffs:
- This CL may cause throughput regressions and is an attempt
  to collect a broad range of potential performance issues.
- Binary size regressions of up to 100kb are expected. The infra
  added here is the minimal base for any future incremental and
  concurrent marking changes. Long term we will save a bit of
  memory by removing trace methods.

Bug: chromium:757440
Change-Id: I61f4dca6cb1933a9f10416bc6641aae3e8794455
Reviewed-on: https://chromium-review.googlesource.com/1052108Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557576}

Remove the --force-clamshell-power-button switch and related
code from ash. This is no longer used starting with M67.

Bug: 841669
Change-Id: Ifca6c0757f4dd077973b489b58030388251f250d
Reviewed-on: https://chromium-review.googlesource.com/1053565Reviewed-by: Min Chen <minch@chromium.org>
Reviewed-by: Qiang Xu <warx@google.com>
Commit-Queue: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557575}

Add restrictions for auto peeking the bottom sheet based a minimum
required scroll percentage on the web page which is sent from the
server side.

Bug: 833865
Change-Id: Ie16a4d30d7323046fc82c09963f5660576036d95
Reviewed-on: https://chromium-review.googlesource.com/1048111Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557574}

Renames the existing flag, kAutofillUpstreamUseGooglePayOnAndroidBranding,
to kAutofillUpstreamUseGooglePayBrandingOnMobile as it also controls GPay
branding in iOS.

Adds an entry to the about flags page in iOS in order to control the flag.

Bug:841758

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I40d961f0106e14f37c5091ffbda7ac72620dd43c
Reviewed-on: https://chromium-review.googlesource.com/1053430
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557573}

This reverts commit f16dcd5e.

Reason for revert: Breaks Fullscreen EGtests when UIRefresh is enabled.

Original change's description:
> [iOS] Show toolbar for load events when UI refresh flag is enabled.
> 
> In the legacy UI, fullscren was disabled when the WKWebView was loading
> so that the URL of the page is always visible.  After the UI refresh,
> the URL is always visible, so fullscreen does not need to be disabled.
> However, the toolbar should still be shown (but not disabled) upon load
> events to ensure that navigation to AMP pages allows access to the
> navigation controls on these pages.
> 
> Bug: 837254
> Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
> Change-Id: Icc9e54cd6972b481c9041fb547f4ab5e8ba40b81
> Reviewed-on: https://chromium-review.googlesource.com/1048635
> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
> Reviewed-by: Justin Cohen <justincohen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#556908}

TBR=justincohen@chromium.org,kkhorimoto@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 837254
Change-Id: Iee7aa1a1c157015ba238fa18dbfde82e672a8b14
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/1054047Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557572}

This cl unbreaks the Windows/Ozone build by not defining WatchFileDescriptor().

Change-Id: I690ae4cfe458b1fa570f70060520ba98aa8b449d
Reviewed-on: https://chromium-review.googlesource.com/1048071Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Mustafa Çamurcu <camurcu@google.com>
Cr-Commit-Position: refs/heads/master@{#557571}

This doesn't actually change the recording rate because doing so
would make a lot of tests become "flaky" as expected results sometimes
got dropped.

Bug: 766909
Change-Id: I8aa8839ddf6628b89d0bbcffd7385a7c202b17da
Reviewed-on: https://chromium-review.googlesource.com/1032888Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557570}

Document#selectedStylesheetSet/preferredStylesheetSet are non-standard
methods that are only implemented by WebKit and Blink. Their standard
versions are no longer in the spec. Remove them entirely from our
implementation.

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/w1Bv7YZxAco

Bug: 690609
Change-Id: I796a6bc0693934eb308a4fe59b52e4a9d1269e6f
Reviewed-on: https://chromium-review.googlesource.com/1049051
Commit-Queue: Chris Nardi <cnardi@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557569}

This reverts commit 0817c1db.

Reason for revert: Canceling and redirecting causes a variety of small, strange behaviors, revert while landing a better solution (https://chromium-review.googlesource.com/c/chromium/src/+/1053237)

Original change's description:
> Do partial redirect handling in the renderer process for sync requests
> 
> Historically, blink has not received any intermediate resource loading
> callbacks for sync requests. It simply blocked until the load finished
> or failed, which meant that redirect security checks performed by blink
> would be skipped (and in some cases we would try to reconstruct or do
> a partial security check after the fact). SyncLoadContext allows us to
> do more of these security checks before the redirect is sent. This
> allows us to come closer to doing the correct thing for sync request
> in general, and allows us to move some worker requests off-main-thread,
> where before they had to proxy sync requests through the main thread in
> order to get both proper redirect handling and the correct synchronous
> behavior.
> 
> This CL "cancels" sync requests on redirect. WebURLLoaderImpl then
> notifies blink of the redirect, which sends FetchContext callbacks (but
> not ResourceClient callbacks). This allows us to do things CSP checking
> on redirect. If blink permits the redirect, WebURLLoaderImpl manually
> follows the redirect by issuing a new sync request.
> 
> ResourceClient callbacks aren't performed becuase sync requests have
> historically not been associated with a ResourceClient. Doing so would
> be a much large refactor, and would require careful handling to make sure
> we didn't enter JS inside what is supposed to be a synchronous blocking
> function.
> 
> We therefore need to continue to perform a rudimentary CORS check in
> SyncLoadContext, which blocks cross-origin redirects if the
> FetchRequestMode was anything other than kNoCors. This revealed a couple
> of XML/XSLT callsites that should have been setting a FetchRequestMode but
> weren't.
> 
> Bug: 706331
> 
> Change-Id: I4ed54cb3ccd119b8a5d192b077bef8d03745e67e
> Reviewed-on: https://chromium-review.googlesource.com/1015237
> Commit-Queue: Nate Chapin <japhet@chromium.org>
> Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#556546}

TBR=falken@chromium.org,horo@chromium.org,kinuko@chromium.org,yhirano@chromium.org,japhet@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 706331
Change-Id: Id42378ac08f67861aac524ab618b782010970577
Reviewed-on: https://chromium-review.googlesource.com/1054108Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557568}

TBR=foolip

No-Try: True
Bug: 841809
Change-Id: I4355f56ff832b43f62cabf9de76f41bf60ebf94d
Reviewed-on: https://chromium-review.googlesource.com/1054100Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557567}

Change-Id: Id6cb550886ea6aa8e3ae48c9a72e4ac70b8db038
Reviewed-on: https://chromium-review.googlesource.com/1054069Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557566}

This reverts commit 035c0c8f.

Reason for revert: compile failures

Original change's description:
> Roll src/third_party/skia/ d31b2f674..2d46a0092 (9 commits)
> 
> https://skia.googlesource.com/skia.git/+log/d31b2f674acc..2d46a0092661
> 
> $ git log d31b2f674..2d46a0092 --date=short --no-merges --format='%ad %ae %s'
> 2018-05-10 reed allow divide by zero
> 2018-05-10 fmalita Validate readByteArrayAsData size
> 2018-05-07 enne Add driver bug workarounds to GrCaps
> 2018-05-03 egdaniel Remove GrBackendObject and all related functions from Skia.
> 2018-05-10 fmalita Validate gradient DescriptorScope size during deserialization
> 2018-05-10 bsalomon Revert "Revert "Don't use GrRRectBlurEffect for large rects when highp is not full float""
> 2018-05-03 egdaniel Remove guard flag for SK_SUPPORT_LEGACY_BACKEND_OBJECTS on flutter.
> 2018-05-09 bungeman Add all SkPaint::Flags to Viewer app.
> 2018-05-09 robertphillips Fix clipping of SkMatrixImageFilter input (take 2)
> 
> Created with:
>   roll-dep src/third_party/skia
> BUG=chromium: 829614
> 
> 
> The AutoRoll server is located here: https://autoroll.skia.org
> 
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
> 
> If the roll is causing failures, please contact the current sheriff, who should
> be CC'd on the roll, and stop the roller if necessary.
> 
> 
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> TBR=egdaniel@chromium.org
> 
> Change-Id: I88cde5822b6f84857587f5a06861489d9eae6dbc
> Reviewed-on: https://chromium-review.googlesource.com/1053760
> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
> Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#557555}

TBR=egdaniel@chromium.org,skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com

Change-Id: I8f3ada64dc671959da55bc34763a706bcd7cf86d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium: 829614
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1054048Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Cr-Commit-Position: refs/heads/master@{#557565}

Bug: 840456
Change-Id: Idf022ee3493207ab64dd72d25a70f2527f557fad
Reviewed-on: https://chromium-review.googlesource.com/1048068Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557564}