- 09 Feb, 2019 13 commits
-
-
Peng Huang authored
Bug: None Change-Id: I3b6693b4c3e6c07806da8899a0f44b46450ff9ee Reviewed-on: https://chromium-review.googlesource.com/c/1461178Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#630565}
-
Jun Mukai authored
The comment says about desktop-linux but the ifdef includes ChromeOS unexpectedly. Seemingly this hiding actually resolves gotchas happening on attaching, possibly because it can exclude the window-to-disappear properly. Bug: 930004 Test: manually Change-Id: I2ee10e0cbdfc4b15c168e3c3c2c51b33d0a7b563 Reviewed-on: https://chromium-review.googlesource.com/c/1460859Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#630564}
-
Raul Tambre authored
The former non-overloaded variants are deprecated. This is a mechanical change; there is no intended behavior change. Bug: 929827 Change-Id: I11213229cc0b41f2f32a5545252d659ceeffe559 Reviewed-on: https://chromium-review.googlesource.com/c/1461377 Auto-Submit: Raul Tambre <raul@tambre.ee> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#630563}
-
Karan Bhatia authored
This reverts commit c8e48580. Reason for revert: The test is failing as part of non_single_process_mash_browser_tests. Original change's description: > Reenable NetworkContextConfigurationBrowserTests on ChromeOS. > > crrev.com/c/1460185 and crrev.com/c/1457478 should have fixed these > tests on ChromeOS. > > Bug: 927293 > Change-Id: I506f4f5023e431df942797c6820feb7997e514cf > Reviewed-on: https://chromium-review.googlesource.com/c/1460125 > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > Cr-Commit-Position: refs/heads/master@{#630415} TBR=mmenke@chromium.org,rmcelrath@chromium.org Change-Id: Ib68f2ead09605f798f444f02fcfbc10e699860b2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 927293 Reviewed-on: https://chromium-review.googlesource.com/c/1461510Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#630562}
-
Steven Bingler authored
Change-Id: I3e14d19bef87a2f91d5cb7749afbd65a1c0323a3 Reviewed-on: https://chromium-review.googlesource.com/c/1452918Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/master@{#630561}
-
Tommy C. Li authored
This CL adds a context menu for suggestions. It currently only contains a "Remove suggestion..." entry to mirror the Shift+Delete behavior, but currently doesn't do anything. In the future, it will be wired to a confirm bubble. Bug: 929477 Change-Id: If12de2e04c41c4a639fd31a39a80efeac936883c Reviewed-on: https://chromium-review.googlesource.com/c/1457234 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#630560}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e59d40e0bcab..be39f713e530 git log e59d40e0bcab..be39f713e530 --date=short --no-merges --format='%ad %ae %s' 2019-02-08 jvanverth@google.com Add Metal context to Viewer. 2019-02-08 bsalomon@google.com Add GrContext::resetGLTextureBindings(). 2019-02-08 jvanverth@google.com Manage Mac paint events more directly. 2019-02-08 benjaminwagner@google.com Distinguish DDL in Gold results. 2019-02-08 halcanary@google.com SkQP: make text context outlast gm Created with: gclient setdep -r src/third_party/skia@be39f713e530 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:926017 TBR=fmalita@chromium.org Change-Id: Ib478b33e1cb433103301aad6a7712c86ccfec242 Reviewed-on: https://chromium-review.googlesource.com/c/1461155Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#630559}
-
Mohamed Amir Yosef authored
Bug: 889819 Change-Id: I102d62cf4a8e050566a17b9796abcbc56e77ea0b Reviewed-on: https://chromium-review.googlesource.com/c/1458442 Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#630558}
-
Johannes Henkel authored
- This adds the CBOR template impl. Change-Id: Iff3854e4dda2e912518a96fd21739f0882eca544 Reviewed-on: https://chromium-review.googlesource.com/c/1461300Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#630557}
-
Alexander Alekseev authored
This CL separates resources of oobe.html and md_login.html, so that they could be cleaned separately. Bug: 926638 Change-Id: I71708cd7e07e872d80245d77524c7920482979a7 Reviewed-on: https://chromium-review.googlesource.com/c/1455636Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#630556}
-
Yuwei Huang authored
This reverts commit 0a58b6a5. Reason for revert: <INSERT REASONING HERE> Original change's description: > Reland "Add remoting FTL API key" > > This is a reland of c0cf050d > > Original change's description: > > Add remoting FTL API key > > > > Add API key for remoting to use during the signaling process. Note that > > this key is only used by Chrome Remote Desktop and will not be used in > > the Chrome browser. > > > > Internal CL: https://chrome-internal-review.googlesource.com/c/chrome/google_apis/internal/+/831973 > > > > Bug: 927962 > > Change-Id: Iecfa48aebe1078a4a0c747f42711000d9155fc3f > > Reviewed-on: https://chromium-review.googlesource.com/c/1450409 > > Reviewed-by: Joe Downing <joedow@chromium.org> > > Reviewed-by: Roger Tawa <rogerta@chromium.org> > > Auto-Submit: Yuwei Huang <yuweih@chromium.org> > > Commit-Queue: Roger Tawa <rogerta@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#630352} > > TBR=rogerta@chromium.org > > Bug: 927962 > Change-Id: I63c2e7e16621a01827609fab0c8969fd85b2399c > Reviewed-on: https://chromium-review.googlesource.com/c/1461306 > Commit-Queue: Yuwei Huang <yuweih@chromium.org> > Auto-Submit: Yuwei Huang <yuweih@chromium.org> > Reviewed-by: Joe Downing <joedow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#630504} TBR=rogerta@chromium.org,joedow@chromium.org,yuweih@chromium.org Change-Id: I4711f1ae08235ab65b6c141ca4cee6e7b49c3e66 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 927962 Reviewed-on: https://chromium-review.googlesource.com/c/1461507Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#630555}
-
Jordan Taylor authored
web_tests/animations/animationworklet/worklet-animation-set-keyframes.html -> web_tests/external/wpt/animation-worklet/worklet-animation-set-keyframes.https.html web_tests/animations/animationworklet/worklet-animation-set-keyframes-expected.html -> web_tests/external/wpt/animation-worklet/worklet-animation-set-keyframes-ref.html web_tests/animations/animationworklet/worklet-animation-set-timing.html -> web_tests/external/wpt/animation-worklet/worklet-animation-set-timing.https.html web_tests/animations/animationworklet/worklet-animation-set-timing-expected.html -> web_tests/external/wpt/animation-worklet/worklet-animation-set-timing-ref.html Bug: 915352 Change-Id: I95f69fcfaea64b8d779e136facb87b6f5c16c27c Reviewed-on: https://chromium-review.googlesource.com/c/1459069Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Jordan Taylor <jortaylo@microsoft.com> Cr-Commit-Position: refs/heads/master@{#630554}
-
Karan Bhatia authored
BUG=930345 TBR=achuith@chromium.org Change-Id: I980527d14f03d9f57f1f0ae9ba1206b3941189ad Reviewed-on: https://chromium-review.googlesource.com/c/1461499Reviewed-by:
-
- 08 Feb, 2019 27 commits
-
-
Collin Baker authored
This implements an animated app menu button highlight when an in-product help promo is showing. A custom InkDropMask is used. Bug: 909755 Change-Id: Ib282525c8af1cdda416002641332164ba64942e5 Reviewed-on: https://chromium-review.googlesource.com/c/1450671 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#630552}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f256339a1959..2b0553ce59c3 git log f256339a1959..2b0553ce59c3 --date=short --no-merges --format='%ad %ae %s' 2019-02-08 jonahr@google.com Implement EXT_instanced_arrays 2019-02-08 jmadill@chromium.org Refine Ozone suppression. Created with: gclient setdep -r src/third_party/angle@2b0553ce59c3 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I64dc2fdf02da599d30aadd5d0142fb79eb72573b Reviewed-on: https://chromium-review.googlesource.com/c/1461456Reviewed-by:
-
Karan Bhatia authored
This reverts commit 45675d0d. Reason for revert: Speculative revert for crbug.com/930338 Original change's description: > Picture-in-Picture: move key methods into a service. > > This is moving most of the Picture-in-Picture feature into a service. > Follow-up CLs will move the remaining methods and some Android auto-pip > code. It will also include further cleanups. > > This CL was meant to be the smallest CL that could move the core feature > set without breaking compilation or tests. It's larger than expected. > > Bug: 919860, 908400 > Change-Id: I72c5faad9a14de6645a7cd1565b29d6a353e24a3 > Binary-Size: cause unknown, landing approved by agrieve@ > Reviewed-on: https://chromium-review.googlesource.com/c/1379049 > Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#630361} TBR=dcheng@chromium.org,dalecurtis@chromium.org,beaufort.francois@gmail.com,mlamouri@chromium.org,agrieve@chromium.org,jochen@chromium.org Change-Id: I88efa31a23ab1c55b256e5813fa20fd2d8776a21 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 919860, 908400, 930338 Reviewed-on: https://chromium-review.googlesource.com/c/1461546Reviewed-by:
-
Xing Liu authored
NotificationIntentInterceptorTest is flaky on kitkat, this CL enables it on post Android K versions. TBR=dtrainor@chromium.org, peter@chromium.org Bug: 910870 Change-Id: I8643bee6718dc05e73e0f62f481e9150a0f38d75 Reviewed-on: https://chromium-review.googlesource.com/c/1459520Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#630549}
-
Majid Valipour authored
Pausing worklet animation now holds the time. This works as expected for main thread animations. Implementing this for composited worklet animations will be done in a follow up patch. Major changes: - Add and expose pause() method pausing the animation. - Introduce hold_time that is used when animation is paused. - Rework how current time is computed, it is now closer to regular animations i.e., we either compute it based on "start time and timeline.currentTime" or use "hold time". - Instead of setting start time we now set the current time which then works backward to compute either the start time or the hold time based on the animation state. - When transitioning animation play state, we now always set the current time. Previously this was adhoc and inconsistent. - Introduce has_started_ to differentiate when playing an animation for the first time vs playing it from pause. - Update playback_rate related calculation to use new logic. Relanding: Original CL was reverted here [1]. Took the following steps to address this: - Address flakiness in unit test by using more accurate error value matching other tests. - Fix flakiness in layout test (worklet-animation-pause.https.html) by using startTime and waiting for time to actually advance working around pre-existing animation clock issue [2]. Also got rid of an invalid state transition from pause->idle. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1434815 [2] http://crbug.com/785940 TEST: - wpt/animation-worklet/worklet-animation-pause.https.html: js test for basic current time calculations - wpt/animation-worklet/worklet-animation-pause-immediately.https.html: reftest for basic pause - wpt/animation-worklet/worklet-animation-pause-result.https.html: reftest for pause/resume. - WorkletAnimationTest.PausePlay: unit test for basic state transition and time calc Bug: 821910, Change-Id: I11fd2960443081be81055904d6d56a2abc3282f5 Reviewed-on: https://chromium-review.googlesource.com/c/1456640Reviewed-by:Majid Valipour <majidvp@chromium.org> Reviewed-by:
-
Danan S authored
Bug: 929570 Change-Id: I027130d4301bd9d3a6c2e19f5ac56d9600c16af2 Reviewed-on: https://chromium-review.googlesource.com/c/1457920Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Danan S <danan@chromium.org> Cr-Commit-Position: refs/heads/master@{#630547}
-
Jeff Fisher authored
Adds a new test for DOMDebugger.setInstrumentationBreakpoint Change-Id: Icb420733979c8ba3dad0aafd33b8c8cb744cae45 Reviewed-on: https://chromium-review.googlesource.com/c/1461340Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Jeff Fisher <jeffish@microsoft.com> Cr-Commit-Position: refs/heads/master@{#630546}
-
Tibor Goldschwendt authored
Having all translations for webview strings in the base module breaks the use of current_detected_ui_locale_name as an indicator for the current UI language. To fix this, move current_detected_ui_locale_name into Chrome resources and, thus, prevent its translations being added to base. Furthermore, use the fixed current_detected_ui_locale_name to record via UMA whether Chrome resumes in the wrong language. I.e. we support the current system language but Chrome is not displayed in it. That can happen if the user changes the language but the language split is not installed in time. Bug: 906082 Change-Id: I084220643e864329360463ef47e84e8632fc6f24 Reviewed-on: https://chromium-review.googlesource.com/c/1460176 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#630545}
-
Khushal authored
Once a tile is done rasterizing, we inform the layer associated with the tile. In the case of pending layer tiles, no additional damage needs to be added from this update, since it is already accounted for in the invalidation on the pending layer which contributes to this layer's overall damage. However, on the active tree, where this raster may be for content previously checkerboarded and its update will be driven by cc, we ensure that the damage from this update is added to this layer's damage at this step. The complete tile's area is assumed to be damaged. Currently LayerTreeHostImpl dispatches the notification for tile raster complete to both the twin (active and pending) layers. This was creating a scenario where when an update which partially invalidates a tile is received on the pending tree, the notification for its raster finishing was being processed by its active and pending layer. The active layer would then damage the complete tile, and the frame damage would unnecessarily include this full tile damage instead of the partial invalidation receieved on the pending tree. Fix the above by routing the tile raster finished notification to only the layer that tile belongs to. Note that this means that if a pending tile finishes after activation, we might still be doing additional damage. But since we only activate after all visible content has been rasterized, those pending tiles are likely not visible anyway. R=danakj@chromium.org,enne@chromium.org Change-Id: I721480af0d7ea3889ef1de2bd5bbee693062f671 Reviewed-on: https://chromium-review.googlesource.com/c/1460181Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#630544}
-
Vlad Tsyrklevich authored
When GWP-ASan is enabled with use_allocator_shim=false (e.g. Windows component builds) it prints a diagnostic warning. Only enable GWP-ASan if it can actually be initialized to avoid printing unnecessary warnings. This means we can't use enable_gwp_asan to enable running tests, as the tests already test for use_allocator_shim=true when necessary. Bug: 929878 Change-Id: I4a8aaaca80c0185fd1c5e07bd7692437665407d3 Reviewed-on: https://chromium-review.googlesource.com/c/1460192 Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#630543}
-
Raul Tambre authored
The former non-overloaded variants are deprecated. Removed casts where they are now unnecessary. This is a mechanical change; there is no intended behavior change. Bug: 929827 Change-Id: Ib064163c5cbdc2a1d596ec26457eb0f41e0d39c2 Reviewed-on: https://chromium-review.googlesource.com/c/1461129 Commit-Queue: Raul Tambre <raul@tambre.ee> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: Raul Tambre <raul@tambre.ee> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#630542}
-
Dan Harrington authored
reportCompleteNotificationAction can be called without native, which resulted in crashes. Changed to use CachedMetrics to only report when native is loaded. I manually tested that this no longer crashes by killing the chrome process before triggering the intent. Note that if Chrome is killed before native is loaded, the metric won't be reported. Bug: 930307 Change-Id: I88728029ae1c09a9197de9c1eb3c6d71086b99d6 Reviewed-on: https://chromium-review.googlesource.com/c/1461332Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Dan H <harringtond@google.com> Cr-Commit-Position: refs/heads/master@{#630541}
-
Matthew Jones authored
This patch adds a static member to chrome's toast wrapper that allows extra padding to be applied to all toasts. The setter is only allowed to be called once to prevent abuse of the system. Bug: 914107 Change-Id: Iaaa036526a13a1b3759ec417cb401efd02a171f7 Reviewed-on: https://chromium-review.googlesource.com/c/1457463 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#630540}
-
Raul Tambre authored
The former non-overloaded variants are deprecated. This is a mechanical change; there is no intended behavior change. Bug: 929827 Change-Id: I4c58520e5cd8707df4ee8d383df595ebbdc5897a Reviewed-on: https://chromium-review.googlesource.com/c/1461127 Commit-Queue: Raul Tambre <raul@tambre.ee> Commit-Queue: Joshua Bell <jsbell@chromium.org> Auto-Submit: Raul Tambre <raul@tambre.ee> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#630539}
-
Joel Einbinder authored
If DevTools is being debugged, and it is reloaded from another devtools inspecting it (Page.reload), the previous devtools connection would never detach and breakpoints would fail to be set among other bugs. Change-Id: I8263de6832070228dcf8e187c3adbc10c41adbae Reviewed-on: https://chromium-review.googlesource.com/c/1447326Reviewed-by:
-
Chris Blume authored
Currently, some of the code paths store the texture in the backing as opposed to the representation. In order for us to do future work to synchronize SharedImages between contexts, we need the texture to live in the representation. This CL moves the texture into the representation. BUG: 930294 Change-Id: Ibe252e21c6d9e8d78b7772adba1355fbf387b000 Reviewed-on: https://chromium-review.googlesource.com/c/1449699 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#630537}
-
Joel Einbinder authored
https://i.imgur.com/HP6fuOT.png Bug: 907703 Change-Id: I08b11e488fbf0a237858f03917290f66d4ef47ff Reviewed-on: https://chromium-review.googlesource.com/c/1450753 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#630536}
-
Adam Langley authored
The initial steps of both makeCredential and getAssertion are the same. This change pulls that behaviour out of makeCredential and call it for both operations. Change-Id: If10dac3dce6c5dd4d1080c80730066afd5365b0c Reviewed-on: https://chromium-review.googlesource.com/c/1461216 Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#630535}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/762247be1246..1ec1b5c17001 git log 762247be1246..1ec1b5c17001 --date=short --no-merges --format='%ad %ae %s' 2019-02-08 thestig@chromium.org Fix non-standalone build. 2019-02-08 tsepez@chromium.org Add JavaScript test for CJX_Tree object. 2019-02-08 thestig@chromium.org Clean up CFX_RTFBreak::GetDisplayPos() and its caller. 2019-02-08 thestig@chromium.org Break circular dependency between xfa/fxfa and xfa/fgas. 2019-02-08 tsepez@chromium.org Add JavaScript test for CXJ_Model object. 2019-02-08 thestig@chromium.org Initialize CPDF_TextPageFind members in the header. 2019-02-08 thestig@chromium.org Roll build/ 213e0a3a3..a721f3327 (131 commits) 2019-02-08 thestig@chromium.org Reorder hooks to run in a particular order. 2019-02-08 tsepez@chromium.org Add JavasScript test for CJX_Container methods. 2019-02-08 tsepez@chromium.org Add JavaScript test for CJX_Node object. 2019-02-07 thestig@chromium.org Roll third_party/googletest/src/ 879ac092f..5ec7f0c4a (111 commits) 2019-02-07 thestig@chromium.org Roll tools/clang/ 05973b6a9..b23f5a073 (4 commits) 2019-02-07 thestig@chromium.org Fix some nits in CFX_FontMgr. 2019-02-07 thestig@chromium.org Reland "Add --jitless to recommended v8 flags." 2019-02-07 thestig@chromium.org Roll v8/ 817547547..73d4f6ca5 (395 commits) 2019-02-07 thestig@chromium.org Roll tools/clang/ 3a16568a5..05973b6a9 (8 commits) 2019-02-07 thestig@chromium.org Change pdfium_fuzzer to use render flags. 2019-02-07 thestig@chromium.org Consolidate various GetInteger() functions in fuzzers. 2019-02-07 thestig@chromium.org Use UnownedPtr in TextGlyphPos. 2019-02-07 thestig@chromium.org Limit image positions/sizes in CPDF_ImageRenderer. 2019-02-07 thestig@chromium.org Use TextGlyphPos::GetOrigin() in GetGlyphsBBox(). 2019-02-07 tsepez@chromium.org Add JavaScript test for CJX_Subform object. 2019-02-07 thestig@chromium.org Roll buildtools/ 2f02e1f36..6fbda1b24 (1 commit) 2019-02-07 thestig@chromium.org Check for integer overflows in AdjustGlyphSpace(). 2019-02-07 thestig@chromium.org Add FPDFSysFontInfoEmbedderTest. 2019-02-07 thestig@chromium.org Correctly handle integer overflows in DrawNormalText(). 2019-02-07 thestig@chromium.org Use TextGlyphPos::GetOrigin() in more places. 2019-02-07 licorn@gmail.com image_diff: respect use_system_zlib build argument 2019-02-07 thestig@chromium.org Consolidate calculations into TextGlyphPos::GetOrigin(). 2019-02-07 thestig@chromium.org Roll third_party/depot_tools/ ddbeac1c0..06d1040fa (178 commits; 76 trivial rolls) 2019-02-07 thakis@chromium.org Remove a few semicolons. 2019-02-07 thestig@chromium.org Roll build and clang. Created with: gclient setdep -r src/third_party/pdfium@1ec1b5c17001 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:584393,chromium:662325,chromium:919640,chromium:914983,chromium:919635,chromium:926235,chromium:929475 TBR=dsinclair@chromium.org Change-Id: I8ed183579daed640fcb7fe2a1f31ff59cc81d03d Reviewed-on: https://chromium-review.googlesource.com/c/1461152Reviewed-by:
-
Joel Einbinder authored
In an object like {abc: 123}, the property 'abc' was mistakenly labeled as being from the Object prototype. ScreenShot: https://i.imgur.com/bdIWNDt.png Bug: none Change-Id: I85aed6eaa6561afbc54f52115ec9bf539fd345eb Reviewed-on: https://chromium-review.googlesource.com/c/1460180 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by: -
Pedro Amaral authored
Tablet tabs are currently using the website theme color. This wasn't an issue before because tablets didn't use colors but now that the menu button is themed this is a problem. This CL makes it so tablets ignore the website theme and just use default theming. Bug: 929971 Change-Id: I06b1152245ff9547a4b6b71db291e0c175e08460 Reviewed-on: https://chromium-review.googlesource.com/c/1460400 Commit-Queue: Pedro Amaral <amaralp@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d77957d206cc..8bfeef929cbe git log d77957d206cc..8bfeef929cbe --date=short --no-merges --format='%ad %ae %s' 2019-02-08 simonhatch@chromium.org Pinpoint - Increase pageset repeat for network_service 2019-02-08 perezju@chromium.org [soundwave] Switch soundwave health study to upstream bots 2019-02-08 simonhatch@chromium.org Pinpoint - Allow loading.desktop.network_service again Created with: gclient setdep -r src/third_party/catapult@8bfeef929cbe The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:926585,chromium:863390,chromium:926585 TBR=sullivan@chromium.org Change-Id: I6fbaa7f35e5b5d77f10a493cbe41793ffefea34d Reviewed-on: https://chromium-review.googlesource.com/c/1461153Reviewed-by:
-
Avi Drissman authored
BUG=none Change-Id: I37e27f6c46b5ee034ff3d508186a13494b7a1cac Reviewed-on: https://chromium-review.googlesource.com/c/1461324 Commit-Queue: Avi Drissman <avi@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#630530}
-
Pedro Amaral authored
Currently ToolbarTablet has to keep track of whether or not the menu update badge is visible so it can reshow the badge after exiting tab switcher mode. This is bad design as the ToolbarTablet has to keep track of state that belongs to the MenuButton. This CL moves all the update badge visibility state tracking into the MenuButton. Bug: 928889 Change-Id: I007a55657a64ca6149fe2c522ce3298b34309347 Reviewed-on: https://chromium-review.googlesource.com/c/1456691 Commit-Queue: Pedro Amaral <amaralp@chromium.org> Reviewed-by:
-
Nicolas Pena authored
This reverts commit 1ff422d8. Reason for revert: Will reland shipping First Input Timing once we are sure it's going to ship. For now, let's unship. Original change's description: > [EventTiming] Ship First Input Timing on main frames > > Intent to ship: > https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/blink-dev/LN92hkaKCzw/Y-ryVxu5AgAJ > > Bug: 823744, 841224 > Change-Id: Ic4d3d67facd0d717b929b9798650eb502057fea6 > Reviewed-on: https://chromium-review.googlesource.com/c/1368826 > Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> > Reviewed-by: Yoav Weiss <yoav@yoav.ws> > Cr-Commit-Position: refs/heads/master@{#625684} TBR=yoav@yoav.ws,tdresser@chromium.org,npm@chromium.org,yoavweiss@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 823744, 841224 Change-Id: I4c95a1fd789793c240a35580f612627a0bc7af13 Reviewed-on: https://chromium-review.googlesource.com/c/1460428Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#630528}
-
Raul Tambre authored
The former non-overloaded variants are deprecated. This is a mechanical change; there is no intended behavior change. Bug: 929827 Change-Id: I54efe1d1de66e58928e004a2cda05b9296737949 Reviewed-on: https://chromium-review.googlesource.com/c/1461382 Commit-Queue: Raul Tambre <raul@tambre.ee> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Auto-Submit: Raul Tambre <raul@tambre.ee> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#630527}
-
Raul Tambre authored
The former non-overloaded variants are deprecated. This is a mechanical change; there is no intended behavior change. Bug: 929827 Change-Id: Id94947775c92bace04b850a23ed830ff44bb1042 Reviewed-on: https://chromium-review.googlesource.com/c/1461383 Commit-Queue: Raul Tambre <raul@tambre.ee> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Auto-Submit: Raul Tambre <raul@tambre.ee> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#630526}
-
