1. 22 Aug, 2011 24 commits
  2. 21 Aug, 2011 7 commits
  3. 20 Aug, 2011 9 commits
    • abarth@webkit.org's avatar
      garden-o-matic summary.html should have UI for examining failures · f9eb7e5b
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66625
      
      Reviewed by Dimitri Glazkov.
      
      This patch introduces the notion of UI actions and converts our
      existing manual <button> manipulation with this new abstraction.  The
      patch also adds an Examine button to failure notifications.  In a
      future patch, I'll add a controller that wires this button up to
      something useful.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js: Added.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js: Added.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93483 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f9eb7e5b
    • commit-queue@webkit.org's avatar
      instanceof HTMLSourceElement Fails · ab0f1436
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=65013
      
      Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-08-20
      Reviewed by Eric Carlson.
      
      Source/WebCore:
      
      Add HTMLSourceElement to DOMWindow.idl for consistency.  Constructors for
      all elements should be available on DOMWindow.
      
       * bindings/generic/RuntimeEnabledFeatures.cpp:
      (WebCore::RuntimeEnabledFeatures::htmlSourceElementEnabled):
      * bindings/generic/RuntimeEnabledFeatures.h:
      * page/DOMWindow.idl:
      
      LayoutTests:
      
      Updated test results after adding HTMLSourceElement to the DOMWindow
      
      * fast/dom/prototype-inheritance-2-expected.txt:
      * fast/dom/prototype-inheritance-expected.txt:
      * platform/chromium/fast/dom/prototype-inheritance-expected.txt:
      * platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
      * platform/gtk/fast/dom/prototype-inheritance-expected.txt:
      * platform/qt-wk2/fast/dom/prototype-inheritance-2-expected.txt:
      * platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
      * platform/qt/fast/dom/prototype-inheritance-expected.txt:
      * platform/win/fast/dom/prototype-inheritance-expected.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93482 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ab0f1436
    • darin@apple.com's avatar
      If Range::insertNode is passed an empty document fragment, it creates a broken DOM tree · ac9cd7e4
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=65015
      
      Reviewed by Alexey Proskuryakov.
      
      Source/WebCore: 
      
      Test: fast/dom/Range/insertNode-empty-fragment-crash.html
      
      * dom/Range.cpp: (WebCore::Range::insertNode): Don't adjust the range after insertion
      if we didn't add anything. Otherwise the code will put a wrong "child before" value into
      the range end boundary point.
      
      LayoutTests: 
      
      * fast/dom/Range/insertNode-empty-fragment-crash-expected.txt: Added.
      * fast/dom/Range/insertNode-empty-fragment-crash.html: Added.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93481 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ac9cd7e4
    • abarth@webkit.org's avatar
      garden-o-matic summary page should indiciate compile failures · f83b2e69
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66624
      
      Reviewed by Dimitri Glazkov.
      
      This patch creates a notification-based UI for build failures.  The new
      UI displays the same information that used to be displayed in the
      infobar.  There's lots of room for improvement in surfacing more
      information, but this is a start.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93480 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f83b2e69
    • kbalazs@webkit.org's avatar
      eventSender.keyDown is unimplemented (WKTR) · 4b831868
      kbalazs@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=57515
      
      Unreviewed gardening.
      
      * platform/wk2/Skipped: Skip dependent test.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93479 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      4b831868
    • kbalazs@webkit.org's avatar
      [Qt] fast/parser/innerhtml-with-prefixed-elements.xhtml has incorrect result · ba45d18f
      kbalazs@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66626
      
      Unreviewed gardening.
      
      * platform/qt/Skipped:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93478 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ba45d18f
    • commit-queue@webkit.org's avatar
      OOB Read in WebCore::SVGAnimationElement · 251006bf
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=65858
      
      Patch by Ken Buchanan <kenrb@chromium.org> on 2011-08-20
      Reviewed by Nikolas Zimmermann.
      
      Source/WebCore:
      
      Potential crash resulting from incorrect keySpline array lengths. This fix validates the length in startedActiveInterval.
      
      Test: svg/animations/animate-calcMode-spline-crash-bad-array-length.xhtml
      
      * svg/SVGAnimationElement.cpp:
      (WebCore::SVGAnimationElement::parseMappedAttribute):
      (WebCore::SVGAnimationElement::calculateKeyTimesIndex):
      
      LayoutTests:
      
      Added test case covering keySpline array length problem.
      
      * svg/animations/animate-calcMode-spline-crash-bad-array-length-expected.txt: Added.
      * svg/animations/animate-calcMode-spline-crash-bad-array-length.xhtml: Added.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93477 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      251006bf
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r93415. · 064cf131
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/93415
      https://bugs.webkit.org/show_bug.cgi?id=66623
      
      Introduces failing test (Requested by pfeldman on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-19
      
      Source/WebCore:
      
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * inspector/front-end/BreakpointManager.js: Removed.
      * inspector/front-end/DebuggerModel.js:
      * inspector/front-end/SourceFile.js:
      * inspector/front-end/WebKit.qrc:
      * inspector/front-end/inspector.html:
      
      LayoutTests:
      
      * inspector/debugger/breakpoint-manager-expected.txt: Removed.
      * inspector/debugger/breakpoint-manager.html: Removed.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93476 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      064cf131
    • rniwa@webkit.org's avatar
      Chromium Windows and Linux rebaselines. These baselines were so wrong. · 7a7f8767
      rniwa@webkit.org authored
      * platform/chromium-cg-mac/fast/css/computed-style-expected.txt: Removed.
      * platform/chromium-win/fast/css/computed-style-expected.txt: Removed.
      * platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
      Replaced with LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt.
      * platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
      Replaced with LayoutTests/svg/css/getComputedStyle-basic-expected.txt.
      * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93475 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      7a7f8767