GitLab

Bug: 1081214
Change-Id: I88c24f7ca3f700c994623ee172a675798651770f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207954Reviewed-by: Dan H <harringtond@chromium.org>
Commit-Queue: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769874}

AppsGridView creates app list item layers when handling item drag, and
destroys them when they're not longer necessary (for performance).
The bounds animations are started in AnimateToIdealBounds, but in
certain cases, no bounds animations are run. If that is not the case,
AnimateToIdealBounds should run OnBoundsAnimatorDone, to ensure the
layers are destroyed if no longer necessary (if drag is not in
progress).

BUG=1083942

Change-Id: Ie6c71db8955aa3194727925e49c3680b36df8649
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207953
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769873}

Adds a "cookieNameFilter" feed property that
will allow filtering of the cookie name that
invalidates the feed.

The cookie invalidation logic will be updated
in a follow up CL.

BUG=1084233

Change-Id: Ide7edc38ffd0690fe46e651fd305aa47e3875155
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207974Reviewed-by: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769872}

While ViewAndroidDelegate takes a ViewGroup, all other places
should not be using ViewGroup, but rather View. This is because
the container-view is a ContentView, and ContentView should not
have children other than those added by ViewAndroidDelegate.

BUG=1075585
TEST=none

Change-Id: I9ba6e1b3aad6d1c780b9383de78f73e5cdebfd28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2191379
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769871}

Fixed: 1076769
Change-Id: Iff73aef6e88000421be8d68cdb1d021b933341ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2176692Reviewed-by: dpapad <dpapad@chromium.org>
Commit-Queue: Roman Arora <romanarora@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769870}

The code below:

      VideoDecodeAccelerator::Client* client = nullptr;
      std::swap(client, client_);

is replaced with:

      VideoDecodeAccelerator::Client* client = client_;
      client_ = nullptr;

The old code is undesirable, because:

1. It was not following go/totw/28 advice about using the following
   pattern:

      VideoDecodeAccelerator::Client* client = nullptr;
      using std::swap;
      swap(client, client_);

2. Is not really needed, because the swap is with a known constant.

3. Might not compile if in the future, hypothetically the type of
   |client_| becomes |base::CheckedPtr<VideoDecodeAccelerator::Client>|.
   (this last issue might be fixable by A) using the pattern in 1 above
   and B) implementing |swap(T*&, CheckedPtr<T>&)| function in the base
   namespace).

Bug: 1080832
Change-Id: If6d12da018f5753e25c8c3fc18910ad609d6ad92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205119Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769869}

There is an if-statement with an empty body.

Also initialize POD members in the header while we are at it.

Change-Id: I7a1e140aeeebf574089842ade65be14f3e087daa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203415
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769868}

The main thing this adds is waiting for cc to see the bottom-controls
height by way of cc::RenderFrameMetadata. This is necessary because
if we send scroll events before cc (BrowserControlsOffsetManager)
gets the height, then no scrolling happens and the test fails.

This also turns off delaying hide/show for tests.

Unfortunately waiting for cc to get the height requires private
api, so this test is moved to the private tests.

I'm starting with a single test, if this proves stable I'll update
the rest (and likely refactor this to be shared with the
TopControlsTest).

BUG=1077825
TEST=BottomControlsTest

Change-Id: I1a1eadbee7b6f19f759b133df1739071150b6e25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194233Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769867}

This CL changes:

    AddChildView(webui_view_ = new WebUIOmniboxPopupView(
                 location_bar_view_->...));

into:

    webui_view_ = AddChildView(
        std::make_unique<WebUIOmniboxPopupView>(
            location_bar_view_->...));

This makes the code easier to handle for the |rewrite_raw_ptr_fields|
tool that changes raw pointer fields like |webui_view_| to use
CheckedPtr instead (this project is still in an investigation phase,
we don't know yet if we will proceed with such rewrite).

Additionally, the change is desirable on its own - the overload
of View::AddChildView that takes |std::unique_ptr| is preferable
over the one that takes a raw pointer (as pointed out in the
comment for that method).

Bug: 1080832
Change-Id: I9c371b99244396ffe89efd95cd3ea4496b712230
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207474
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769866}

Bug: 949269
Change-Id: I883df1bd935d7e34713452930387fbffbd1eafcf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206533Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Manas Verma <manasverma@google.com>
Cr-Commit-Position: refs/heads/master@{#769865}

Adds the necessary CrOS args to the GPU noop Telemetry sleep test.
Currently, the tests are blowing up due to the missing args, which is
preventing us from verifying that the builders are otherwise healthy.

TBR=ynovikov@chromium.org

Bug: 1080424
Change-Id: I68bec47f566defceb67d3d069252527ed790a6a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207960Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769864}

This was originally needed to work around mojo restrictions in chrome to
open Assistant settings from within Chrome OS settings. This is no
longer required with a public interface available via
AssistantController.

This CL does not change behavior and cleans up by removing
assistant_settings.h and providing the utility to open the Assistant
settings via the AssistantController interface.

Bug: b:156677196
Test: Tested on Chrome OS VM.
Change-Id: I3ad7889ff82b7a24fcc6a9c37a865ccccb6c9988
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205122
Commit-Queue: Abhijeet Singh <siabhijeet@google.com>
Reviewed-by: David Black <dmblack@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769863}

Removes DCHECK for app group URL, as this is not supported in EG tests.
This means that EG tests on device will run with the credential store
in memory only mode.

TBR Sylvain, in order to fix iphone-device, as he already reviewed
TBR=sdefresne@chromium.org

https: //chromium-review.googlesource.com/c/chromium/src/+/2206835.
Bug: 1044639, 1084271
Change-Id: I0f533e59aa9c59ee3202a90fa5d36008979c8a75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207315Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769862}

https://chromium.googlesource.com/angle/angle.git/+log/d34ab323f368..8a90905cc0c8

git log d34ab323f368..8a90905cc0c8 --date=short --first-parent --format='%ad %ae %s'
2020-05-18 cclao@google.com Revert "Vulkan: Try to merge barriers if possible"

Created with:
  gclient setdep -r src/third_party/angle@8a90905cc0c8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: geofflang@google.com
Change-Id: I39532d6c3425be183e832b44b5f250723fd1782b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207995Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#769861}

When generating a jsdoc with a single tag, we tend to one-line it.
Do that for the @const marker for objects too.

Bug: 469920
Change-Id: Iaa78417a5dd5ae4853825e60878b01dd87a41362
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205054Reviewed-by: dpapad <dpapad@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769860}

https://webrtc.googlesource.com/src.git/+log/3a35312b64a0..2af35ab984e3

git log 3a35312b64a0..2af35ab984e3 --date=short --first-parent --format='%ad %ae %s'
2020-05-18 handellm@webrtc.org FakeAudioCaptureModule: remove lock recursions.
2020-05-18 marinaciocea@webrtc.org Reland "Make TransformableVideoFrameInterface::GetMetadata pure virtual."
2020-05-18 handellm@webrtc.org VideoAdapter: add missing attribute thread annotations.

Created with:
  gclient setdep -r src/third_party/webrtc@2af35ab984e3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1069295
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I83c03656d26d898a8cd6d3873baee4f1d885b813
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207894Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#769859}

win10_chromium_x64_coverage_rel_ng was set up to experiment and
understand the impact of code coverage on CQ.

Now that the experiment is done, this CL cleans things up.

Bug: 1004523
Change-Id: Ifb34136099a758574f41e6cc5e0e7199b914efce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207978Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769858}

Although gfx::ColorTransform can perform range adjustment (from limited
range to full range), it is not very accurate for high bit depths. Since
YUVAToRGBA() already performs range adjustment (using libavif
functions), set the range of the source color space to full range when
we create the gfx::ColorTransform object for YUV-to-RGB conversion.

Tested:
blink_platform_unittests --gtest_filter=*AVIF*

Bug: 960620
Change-Id: I74ff29ca0ca4199154477f24e65ad9f3496d5c93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204819Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Wan-Teh Chang <wtc@google.com>
Cr-Commit-Position: refs/heads/master@{#769857}

Update TestExpectations for flaky iframe test
http/tests/misc/insert-iframe-into-xml-document-before-xsl-transform.html
on Linux.

TBR: chrishtr@chromium.org

Bug: 10842567
Change-Id: I600f40e68b0dd57c9f83d4b6742c69cf25b512a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207774Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769856}

TBR=wychen

Bug: 1081754
Change-Id: I06062b7711d79a7a1f2d94b4fe1cebc11eadf1dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207945Reviewed-by: Sinan Sahin <sinansahin@google.com>
Commit-Queue: Sinan Sahin <sinansahin@google.com>
Cr-Commit-Position: refs/heads/master@{#769855}

LockContentsView & LockScreenMediaControlsView

Bug: 648382
Change-Id: I6bdc71f3a1ea55bfe03a43b99ecb67f8fa8b52fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207018
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769854}

The usage in RegisterWebUIControllerInterfaceBinder of
WebContents::GetWebUI() leads to potential race conditions. Navigations
between different WebUIs are cross-process, which means that two WebUIs
run in separate processes and their IPC messages to the browser process
can race against each other.

One particular case that I believe is hit in reality is as follows:
1 Start with WebUI1 in a tab (runs in process 1).
2 Navigate to WebUI2 in the same tab.
3 Send the CommitNavigation IPC to WebUI2 (in process 2).
4 WebUI2 sends DidCommitNavigation IPC to browser process from process 2
5 Process 1 sends interface bind request to browser process for WebUI1
** This is still possible, since WebUI1 is running in process 1 and has
   not been unloaded yet.

In this sequence of events, in step 4 the main RenderFrameHost for the
tab will be changed. In step 5, the code in
RegisterWebUIControllerInterfaceBinder gets the WebUI from WebContents,
which will return WebUI2, while the interface request is for WebUI1,
leading to mismatch.

This CL fixes this race by exposing the WebUI associated with a
RenderFrameHost directly, through the public API, so the code binding
incoming interface requests will use the WebUI from the RenderFrameHost
itself instead of the potential mismatch from WebContents::GetWebUI.

Bug: 1081078
Change-Id: I4998efb72573bcfb4166db7a99ca98014689eb3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204850Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769853}

https://chromium.googlesource.com/catapult.git/+log/77ed01701581..540b89ce7c0d

git log 77ed01701581..540b89ce7c0d --date=short --first-parent --format='%ad %ae %s'
2020-05-18 bsheedy@chromium.org [Telemetry] Standardize build directory usage

Created with:
  gclient setdep -r src/third_party/catapult@540b89ce7c0d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC oysteine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1026296
Tbr: oysteine@google.com
Change-Id: I1e90b1034059be43da7170f41f3ac327a246a583
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207893Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#769852}

This change removes some WidgetDelegate overrides in ImeWindowView
and replaces them with setter calls. It also slightly restructures
ImeWindow to make it clear that both title and icon are const for
the lifetime of the ImeWindow.

Bug: 1075649
Change-Id: I1d0a9117bc45b1c56362627dbc4f98b20beb7954
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207970
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769851}

It's intermittently timing out on multiple platforms, not just Windows.

No-Try: True
Tbr: shrekshao@google.com
Bug: 1083320, 1082525
Change-Id: I1649c632d42f774976c35fad376ba59a88150eef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208070Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769850}

The type is not immediately obvious from the assignment, so desugaring
seems desirable in general.

Desugaring also helps if (hypothetically) in the future
|minimize_button_| and other similar fields become CheckedPtr - in this
case |auto*| would not compile, but the desugared type would work fine.

Bug: 1080832
Change-Id: I2c5bb0c90b4bca9e30ec416175661e030a7cf83a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207619Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769849}

Using wpt-import in Chromium 28d716a6.
With Chromium commits locally applied on WPT:
f6984fd9 "De-flaky pointerlock/pointerevent_pointermove_in_pointerlock.html"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa

No-Export: true
Change-Id: I7e8427c2272b612ff3a8486d131ecac3ec0e1456
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207019Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#769848}

This change updates the logic used in the Blink document for
document.hasStorageAccess and document.requestStorageAccess. Gates have
been added to ensure the proper restrictions such as having a non-opaque
origin, sandbox token (if applicable), as well as ensuring that
hasStorageAccess reflects the actual state of storage access on the page.

Additionally defense in depth logic checks have been added in
StorageAccessGrantPermissionContext to shortcut if we get a request for
a scenario no grant would be needed.

Some additional cleanup is included with this change to remove the
temporary usage of CONTENT_SETTING_SESSION in
StorageAccessGrantPermissionContext and to ensure all content settings
updates will propagate to the network service. A follow up change will
ensure this does not result in duplicate updates when we perform our
initial update.

Browser tests have been added to validate end to end functionality.

Bug: 989663
Change-Id: I09fdc115a30a71e341961b385a2e2e05fd161536
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194905Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Brandon Maslen <brandm@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#769847}

Reset the accessibility event recorder pointer and the web contents
observer pointer rather than releasing them. This ensures that the
objects are destroyed, rather than just the reference to them released.
Also, stop the accessibility event recorder when destroying the
AccessibilityUIMessageHandler.

AX-Relnotes: Fix bug in chrome:accessibility page.

Bug: 785493, 1081469, 1043024, 1042569
Change-Id: I61ecc6cb12d3f9695130ca9c15900bf3070de1ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199020Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Abigail Klein <abigailbklein@google.com>
Cr-Commit-Position: refs/heads/master@{#769846}

kDnsHttpssvcExperimentDomains and kDnsHttpssvcControlDomains:
Comma-separated lists to define the domains for which we are allowed to
query HTTPSSVC or INTEGRITY. The exact query sent (or none at all) will
be determined by the existing feature params: kDnsHttpssvcUseIntegrity
and kDnsHttpssvcUseHttpssvc.

kDnsHttpssvcEnableQueryOverInsecure: This feature param will enable
querying HTTPSSVC or INTEGRITY over Do53, but we don't plan to turn it
on soon. The default is DoH-only.

Bug: 1052476
Change-Id: I78c8df8b5ac2e4cb16aea6358666fccef013baee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202317
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Reviewed-by: Eric Orth <ericorth@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769845}

Bug: 1083409
Change-Id: Id06677cb30ac4264a81162a075f023b5c5faf36e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204544Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Vincent Boisselle <vincb@google.com>
Cr-Commit-Position: refs/heads/master@{#769844}

We don't need to do anything in FinishCycle() for transient
PaintController, or if we haven't committed anything since the last
FinishCycle().

Remove code that resets paint property changed flags from
PaintArtifact::FinishCycle() for CAP, so that LocalFrameView can do that
in the same way for both CAP and pre-CAP.

This doesn't actually reduce any extra calls for crbug.com/1049159, but
prepares for that. This CL actually avoids the repeated VLOGs in
FinishCycle when it does nothing.

Bug: 1049159
Change-Id: I6f4f11acebc3194cf85ac26b909c663dba422a3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205977
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769843}

This update brings performance, low latency, and API improvements.
Testing on a Pixelbook shows that the inking surface receives a hardware
overlay in all orientations.

The new binaries are smaller.  The new WebAssembly binary is 6.8 MB
compared to 5.5 MB for the old one, plus a 2 MB memory initialization
file that's no longer required.  That's a net reduction of 0.7 MB.  The
JavaScript is smaller as well; 217 KB to 183 KB for the WebAssembly
loader and bindings script, and 350 KB to 89 KB for the Ink closure JS
binary.  Also, only the threaded build is required now that threads are
stable in Chrome, which eliminates the entire 7.8 MB non-threaded
WebAssembly and script files.  Total savings: 8.8 MB.

The Ink exported binary uses a new interface with narrowly defined
externs and no longer exports 'goog' among other globals from the
previous automatic externs. It may be possible in a future change to
remove the iframe sandboxing from the Ink binary.

Change-Id: Ieba6513b723f91d67c445246e7ba4e08f113469e
Bug: 1084273
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204141
Commit-Queue: William Furr <wfurr@google.com>
Reviewed-by: dstockwell <dstockwell@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769842}

This header is copied from prefs, per the design doc.

Bug: 1084186
Change-Id: Id99652bbf573b6aa6ede9230a7d6da5c23904acf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207752Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769841}

The main motivation behind this change is that we may want to name the
first page (to give it a non-default orientation, for instance).

This requires two things:

1. Manually name the first entry in the page name mapper. We normally
insert named pages as part of inserting a forced break. However, there's
no break before the first page (or it wouldn't be the first page
anymore). Add a way to name the first page(s) manually, at the end of
LayoutView layout.

2. Correct start/end page name handling and propagation, as described in
the spec [1]. An author may want to set the first page name on the first
SECTION, DIV, etc., rather than specifying it on the root element (which
would be rather non-intuitive). Therefore, improve on our current,
rather simplistic, approach to how the layout engine deals with named
pages, and do it exactly as the spec describes.

Page name propagation is currently only supported for block containers.
It would also be appropriate to support this for table, flex, etc.

[1] https://drafts.csswg.org/css-page-3/#start-page-value

Bug: 1053768
Change-Id: I0f16cfb4325f6641b2c77355e03a6e439084d333
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205937Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769840}

We use IdentifiabilityMetricBuilder to report hashes of the different
values this method can return to UKM to determine how much entropy
this function leaks.

Bug: 973801
Change-Id: I4aa45f5662d62a83f1971a62c61891f3ebdfa81b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186997
Commit-Queue: Dylan Cutler <dylancutler@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769839}

Bug: b:156675499
Change-Id: I098a339572c2e8c3c319500a23d42dc69f8b4df5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204695Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#769838}

Since the probe categories are ignored, remove them. Also, remove
MakeTelemetryInfo() and its helper functions since they add no value to
the test.

Bug: None
Change-Id: I6a77a761e822678caf840b66fbe471139d1157d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207773
Commit-Queue: Jesse Schettler <jschettler@chromium.org>
Auto-Submit: Jesse Schettler <jschettler@chromium.org>
Reviewed-by: Paul Moy <pmoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769837}

META is already set to NullButton higher up in the function.

BUG=1073130

Change-Id: Ic148ddd58d3b0768e171d95f7c3d2101ab24d6cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203210
Commit-Queue: Andrew Walbran <qwandor@google.com>
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769836}

This CL records a new histogram called
Navigation.PasswordEntry.SiteEngagementLevel the first time a user
modifies a password field.

Bug: 1073604
Change-Id: Ide7ca623d4962daf9c9213a1c424bba096995b5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199711
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Auto-Submit: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769835}