GitLab

Manually convert this test to testharness and new Audit.

And since it's a large rewrite already, change the test so that we
don't need an expected result file and compute the expected result
ourselves.

BUG=692795
TEST=mixing.html

Review-Url: https://codereview.chromium.org/2707433003
Cr-Commit-Position: refs/heads/master@{#453313}

There were a couple possible edge cases with the new postscript language
level identification that could lead to incorrect behavior.
(1) Printer is stuck in GDI centric mode. In this case the change to
POSTSCRIPT_PASSTHROUGH will cause a failure. Check for POSTSCRIPT_
PASSTHROUGH support before running it.
(2) Printer gets set to PS mode but the postscript level detection
returns something weird. This would result in driver trying to send
Gdi commands to a printer in PS mode.
These issues are resolved in this patch.

Finally, this fixes the problem of postscript printers not printing
if the postscript feature is disabled by using GDI mode instead of
PS mode to query the postscript level.

BUG=614988

Review-Url: https://codereview.chromium.org/2714073002
Cr-Commit-Position: refs/heads/master@{#453312}

This patch makes |adjustSelectionToAvoidCrossingEditingBoundaries()| in
|VisibleSelection| not to call |validate()| as a preparation of changing
a parameter to |SelectionInDOMTree|[1] for improving code health.

[1] http://crrev.com/2722523002 Get rid of VisibleSelection::m_granularity and
m_hasTrailingWhitespace

BUG=513568
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2719003002
Cr-Commit-Position: refs/heads/master@{#453311}

It causes pkg-config to look in the precise sysroot.
We need the jessie sysroot.

BUG=angleproject:1423

Review-Url: https://codereview.chromium.org/2712073004
Cr-Commit-Position: refs/heads/master@{#453310}

https://pdfium.googlesource.com/pdfium.git/+log/717a4fc857d6..73c9f3bb3d82

$ git log 717a4fc85..73c9f3bb3 --date=short --no-merges --format='%ad %ae %s'
2017-02-27 tsepez Allow building XFA without additional codecs.

Created with:
  roll-dep src/third_party/pdfium

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2722633002
Cr-Commit-Position: refs/heads/master@{#453309}

https://chromium.googlesource.com/webm/libvpx.git/+log/4d4231352c8c..8121f85473b2

$ git log 4d4231352..8121f8547 --date=short --no-merges --format='%ad %ae %s'
2017-02-24 yunqingwang Remove an old leftover comment
2017-02-24 jzern get_prob(): rationalize int types
2017-02-22 yunqingwang Improve VP9 encoder threading test for better coverage
2017-02-16 johannkoenig consolidate block_error functions
2017-02-22 jianj Make vp9_scale_and_extend_frame_ssse3 work for hbd when bitdepth = 8.
2017-02-16 johannkoenig block error sse2: use tran_low_t
2017-02-22 marpan vp9: 1pass CBR: modify condition for reducing loop filter.
2017-02-17 marpan vp9: Non-rd pickmode: use simple block_yrd under some conditons.
2017-02-22 marpan vp9: aq-mode=3: On key frame reset cr->reduce_refresh to 0.
2017-02-21 johannkoenig vp8_fdct4x4 test: fix segfault again
2017-02-22 jianj vp9: Only compute y_sad for golden in variance partition for speed < 8.
2017-02-13 marpan vp9: Incorporate source sum_diff into non-rd partition thresholds.
2017-02-21 luoyi Following SSSE3 intrinsics functions also work for HBD
2017-02-17 jianj Fix segmentation fault caused by denoiser working with spatial SVC.
2017-02-16 ranjit.tulabandu Refactored the row based multi-threading code
2017-02-17 luoyi Fix idct8x8 SSSE3 SingleExtremeCoeff unit tests
2017-02-13 johannkoenig Drop zbin_ptr and quant_shift_ptr

Created with:
  roll-dep src/third_party/libvpx/source/libvpx
R=johannkoenig@google.com

Review-Url: https://codereview.chromium.org/2718943005
Cr-Commit-Position: refs/heads/master@{#453308}

Previously we were just doing this for remote browser tests.

BUG=chromedriver:1695
TBR=stgao@chromium.org

Review-Url: https://codereview.chromium.org/2721703002
Cr-Commit-Position: refs/heads/master@{#453307}

[InputEvent] Change |InputEventInit::sequence<Range> ranges| to |sequence<StaticRange> targetRanges|

See spec https://w3c.github.io/input-events/#h-interface-inputevent

BUG=692700

Review-Url: https://codereview.chromium.org/2709883004
Cr-Commit-Position: refs/heads/master@{#453306}

Seems pointer events carried over a model from mouse events that it
shouldn't have. Always dispatch pointer events to disabled form
controls.

BUG=695979

Review-Url: https://codereview.chromium.org/2716063002
Cr-Commit-Position: refs/heads/master@{#453305}

Trying to prevent folks from creating large CLs in Options only to
discover we intend to deprecate it shortly. This codifies a few
assumptions we've been making about where new code should go.

BUG=none
R=dbeam@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2719093002
Cr-Commit-Position: refs/heads/master@{#453304}

In SPv2 we won't create a layer for an element that paints no content.
For composited animation focused layout tests we explicitly want to
make sure the element under test is composited. Thus we must paint
some kind of content (what it is doesn't actually matter).

Here we add an 'x' as dummy text content to be painted by any element that is
intended to be animated. We could alternatively set a background color and
ensure the element has some non-empty size, but that involves more styling which
feels more intrusive.

BUG=692310
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2702483002
Cr-Commit-Position: refs/heads/master@{#453303}

It's not ready on all platforms yet.

BUG=638281
TBR=pfeldman

Review-Url: https://codereview.chromium.org/2719853005
Cr-Commit-Position: refs/heads/master@{#453302}

BUG=635619
TEST=NGBlockLayoutAlgorithmTest::CollapsingMarginsWithText

Review-Url: https://codereview.chromium.org/2710213007
Cr-Commit-Position: refs/heads/master@{#453301}

Consolidate functions in ProtocolManagerHelper and put them inside
components/safe_browsing_db/util.*.
Separate BasePingManager and SafeBrowsingPingManager, where:
BasePingManager handles basic safe browsing pings such as HitReport,
ThreatDetails report etc.
Leave NotificationImageReport and PermissionReport to
SafeBrowsingPingManager due to their chrome/browser/ dependencies.
BUG=684805

Review-Url: https://codereview.chromium.org/2650973005
Cr-Commit-Position: refs/heads/master@{#453300}

ui::Window no longer exists. Remove code that deals with it.

BUG=none

Review-Url: https://codereview.chromium.org/2715983002
Cr-Commit-Position: refs/heads/master@{#453299}

More tidy up of DumpWithoutCrashing() calls. Per
https://goto.google.com/uoflm, this doesn't seem to have been hit post
M56, so let me know if you'd like to remove the whole `if` instead.

R=clamy@chromium.org
BUG=653344,694688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2714823002
Cr-Commit-Position: refs/heads/master@{#453298}

We have new mocks!  Update the item card UI to be more in-line with the
new specs.

BUG=529395
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2707083003
Cr-Commit-Position: refs/heads/master@{#453297}

BUG=635619

Review-Url: https://codereview.chromium.org/2717403002
Cr-Commit-Position: refs/heads/master@{#453296}

WebRTC now ignores x-google-min-bitrate parameter for opus codec,
which was used in remoting. As result the audio was sent at 64kbps,
instead of desired 160kbps. Updated webrtc_transport to use
maxaveragebitrate to specify target bitrate, which should make the
test non-flaky.

BUG=695384

Review-Url: https://codereview.chromium.org/2711053005
Cr-Commit-Position: refs/heads/master@{#453295}

BUG=691781

Review-Url: https://codereview.chromium.org/2709393006
Cr-Commit-Position: refs/heads/master@{#453294}

BUG=673426,295792,641635
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2717003002
Cr-Commit-Position: refs/heads/master@{#453293}

This CL refactors GetImageForScale() on Gtk3 so no widget gets created.  Only
a GtkStyleContext is needed.

In addition, it adds GtkStateFlagFocused to the style context if |focus_| is true.
This fixes focused button rendering on Ambiance, which doesn't use a focus
rectangle, but instead changes the button's border directly.

BUG=695357
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2715153002
Cr-Commit-Position: refs/heads/master@{#453292}

A previous CL added special treatment for AMP pages when they
are clicked on in the Contextual Search Overlay.  However the
functionality was behind a flag, which we never enabled.

This changes the AMP case to be behind a default-enabled flag that
will allow us to disable if needed.

BUG=645325

Review-Url: https://codereview.chromium.org/2714623002
Cr-Commit-Position: refs/heads/master@{#453291}

Revert of Switch RemoteWindowProxy to use v8::Context::NewRemoteContext. (patchset #21 id:400001 of https://codereview.chromium.org/2626183003/ )

Reason for revert:
Causing crashes in canary: https://crbug.com/696528, https://crbug.com/696577

Original issue's description:
> Switch RemoteWindowProxy to use v8::Context::NewRemoteContext.
>
> BUG=527190
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
>
> Review-Url: https://codereview.chromium.org/2626183003
> Cr-Commit-Position: refs/heads/master@{#453128}
> Committed: https://chromium.googlesource.com/chromium/src/+/4a40a757e7029a3f59b12543cbf617eceb15f7f0

TBR=haraken@chromium.org,yukishiino@chromium.org,jochen@chromium.org,lfg@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=527190

Review-Url: https://codereview.chromium.org/2721693002
Cr-Commit-Position: refs/heads/master@{#453290}

Focus rings are floored to the nearest integral number of pixels. This
matches what we do for solid borders. This only addresses the second
part of the linked bug; updating TreeView and TableView will come later.

TBR=derat@chromium.org
BUG=695540

Review-Url: https://codereview.chromium.org/2714753002
Cr-Commit-Position: refs/heads/master@{#453289}

This CL fixes a regression caused by
https://codereview.chromium.org/2701923002/
There was a last-minute change from GtkEntry to GtkTextView, but I
incorrectly assumed that selection and text colors would be handled
in the same way.

BUG=79722
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2721493002
Cr-Commit-Position: refs/heads/master@{#453288}

We are adding COMPONENT/TEAM information into OWNERS file. Please help us to
verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your
OWNERS files. Thanks.

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
List of components
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905

Review-Url: https://codereview.chromium.org/2698093002
Cr-Commit-Position: refs/heads/master@{#453287}

This CL removes PickButtonTintFromColors from gtk_ui.cc.  This
function was not used, and apparently only Gcc 6 caught this.

BUG=694497
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2722463003
Cr-Commit-Position: refs/heads/master@{#453286}

- Title
- Subtitle
- Disclaimer
- Two lists of bulletpoints

Note that each list of bulletpoints is represented as one string to ensure
translation consistency; the wording used for the title of the list can
affect on the declension of individual bullet points.

The UI where the strings will be used is not a part of this CL.

BUG=693525

Review-Url: https://codereview.chromium.org/2703733004
Cr-Commit-Position: refs/heads/master@{#453285}

There was still a bug left in logic for simplifying the specifier
list for new test expectation lines: specifiers for skipped tests
were added after simplification, meaning that in the (common) case
where the test fails the same on all platforms and android is skipped,
the specifier list is simplified to [ Linux Mac Win ] and then
Android is added.

The fix is to add specifiers for skipped ports before simplifying.

BUG=655201

Review-Url: https://codereview.chromium.org/2709103009
Cr-Commit-Position: refs/heads/master@{#453284}

In this CL:
  Make docstring style consistent
  Make quotes consistent
  Move helper functions to below main class
  Edit comments

This CL should not change behavior. Reason for this change:
Was reading this file when making another change and saw
a few trivial things to improve.

Review-Url: https://codereview.chromium.org/2719483003
Cr-Commit-Position: refs/heads/master@{#453283}

This incorporates the new data stoppage dialog. Split out from perf
regression sheriffing doc because non-chromium perf sheriffs and
sometimes bot health sheriffs would use this doc too.

Review-Url: https://codereview.chromium.org/2712383003
Cr-Commit-Position: refs/heads/master@{#453282}

Review-Url: https://codereview.chromium.org/2708883004
Cr-Commit-Position: refs/heads/master@{#453281}

BUG=693114,581462,647438,695628,695629,695632,695640,695686,695751,695758,695887,696006,696028
TEST=test only changes
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2718763003
Cr-Commit-Position: refs/heads/master@{#453280}

BUG=680567

Review-Url: https://codereview.chromium.org/2717563002
Cr-Commit-Position: refs/heads/master@{#453279}

To better reflect it's use and function.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2715513009
Cr-Commit-Position: refs/heads/master@{#453278}

Revert of Add dummy file with very long path to test path length limits. (patchset #1 id:1 of https://codereview.chromium.org/2718733002/ )

Reason for revert:
(this was a temporary CL to test whether long paths break things)

Original issue's description:
> Add dummy file with very long path to test path length limits.
>
> This CL adds a path in Chromium with a total length of 204 from the repo root, which would be the length of a file in LayoutTests/external/wpt/<subpath> where <subpath> is 160 characters.
>
> So, if this CL doesn't break anything, then http://crrev.com/2708883004 could be committed.
>
> This CL might break any builders with a checkout directory of about 43 characters or more.
>
> Context: see http://crrev.com/2708883004
> Review-Url: https://codereview.chromium.org/2718733002
> Cr-Commit-Position: refs/heads/master@{#453109}
> Committed: https://chromium.googlesource.com/chromium/src/+/ce0805ea777b313eb24184737d2b0dfde45e8c69

TBR=tkent@chromium.org,foolip@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.

Review-Url: https://codereview.chromium.org/2719083002
Cr-Commit-Position: refs/heads/master@{#453277}

This moves or shares some properties between internet-page and
network-summary in preparation for moving the lists of networks
from network-summary-item to a subpage.

There should be no functionality changes.

This CL also (finally) adds a few basic tests for the internet page. They are by no means exhaustive.

BUG=673944
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2709573006
Cr-Commit-Position: refs/heads/master@{#453276}

Currently the fingerprint setup shows up on options, but does not work properly, possibly due to reliance on MD Settings code. Hide the fingerprint stuff on options, it is not needed for options. Also, the enable screen lock toggle was showing when it should be hidden.

TEST=manual
BUG=693144
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2698773004
Cr-Commit-Position: refs/heads/master@{#453275}

Also remove pre-MD code for VolumeView.

TBR=tdanderson@chromium.org
BUG=663767

Review-Url: https://codereview.chromium.org/2709103007
Cr-Commit-Position: refs/heads/master@{#453274}