- 17 Nov, 2020 40 commits
-
-
Brian Sheedy authored
Adds the requests module as an entry in //third_party/blink/tools/wpt_import.py's file-specific vpython spec. One of the script's dependencies (typ) is taking a dependency on the requests module, so failing to include it in the vpython spec causes import failures. Bug: 1147992 Change-Id: I42258b20373cdb4b3430c8bb01357706ccfb23da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544937 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#828396}
-
Greg Thompson authored
There was a fear that the value iterator was flaky on Win 7. If that's true, a little test coverage should expose it. BUG=1066801 R=robliao@chromium.org Change-Id: I984044243886510c9c540bc471b6a62a26212e3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540447 Commit-Queue: Greg Thompson <grt@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#828395}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/384b05891b9b..1f921f2e5070 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mek@google.com,gogerald@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1040645,chromium:1139446 Tbr: mek@google.com,gogerald@google.com Change-Id: Ib46ab93bdd01d391daedc645a2b3c5f0faa6f80c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545102Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828394}
-
Zhaoyang Li authored
This reverts commit 0afe240a. Reason for revert: The issue is fixed in iOS third_party code so the change is no longer needed. Original change's description: > ios: Disable -Wgnu-folding-constant for .m files. > > Bug: 1143700 > Change-Id: If1110313fda223d83d17db5600f2041c3e1f6f32 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510229 > Commit-Queue: Nico Weber <thakis@chromium.org> > Commit-Queue: Hans Wennborg <hans@chromium.org> > Auto-Submit: Nico Weber <thakis@chromium.org> > Reviewed-by: Hans Wennborg <hans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#822644} TBR=thakis@chromium.org,hans@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1143700 Change-Id: I3c1b2e57871b06bb21fed29fc4b4ecc6c77d9caa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545025 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#828393}
-
Kartik Hegde authored
Add the HttpsFirewall routine to the ServiceConnection. BUG=chromium:956783 TEST=1) chromeos_unittests --gtest_filter=CrosHealthdServiceConnectionTest.* 2) unit_tests --gtest_filter=DeviceCommandRunRoutineJobTest* 3) Applied HttpFirewall changes and successfully ran the HttpFirewall routine on a DUT (verified using cros-health-tool diag --action=run_routine --routine=https_firewall). Change-Id: I55dafa03d296c3451b40dd9720a3447259ebb5fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482091 Commit-Queue: Kartik Hegde <khegde@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Paul Moy <pmoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#828392}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I346808400cf076cf40fac835c12a72a8625d90a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545202Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#828391}
-
Wan-Teh Chang authored
Handle multiple incomplete lazy decoded frames in DeferredImageDecoder::PrepareLazyDecodedFrames(). This allows blink::ImageDecoder::DecodeFrameCount() to return the true frame count even when not all frames' encoded data are available. Change blink::AVIFImageDecoder::DecodeFrameCount() to return the true frame count. Change blink::AVIFImageDecoder::FrameIsReceivedAtIndex() to actually check if the frame's encoded data has been received. Bug: 1148577 Bug: 1136922 Change-Id: I2423472b406b130fb460cbfe65b5b3890c106344 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538696 Commit-Queue: Wan-Teh Chang <wtc@google.com> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#828390}
-
wutao authored
To reduce the ChromeVox interaction in Assistant listening mode, This patch: 1. Does not focus on the Mic button when showing the voice input UI. 2. Fixes a bug that shows keyboard input UI first and then switch to voice input UI. Bug: b/167501035 Test: Updated tests Change-Id: I6bdc83a114f4a8a6ebeb691ec0d784ec5696cf44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532929 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#828389}
-
Rohan Pavone authored
Bug: 1147969 Change-Id: I455cc893a80f99f0ff59ab7b9e44e118c2b7bb22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536075Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Rohan Pavone <rohpavone@chromium.org> Cr-Commit-Position: refs/heads/master@{#828388}
-
Norman Rosas authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //components/nacl Bug: 1113033 Change-Id: Ic29fd8502723d94dc62bb6613f26292f29c4fed3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544904Reviewed-by:
Brad Nelson <bradnelson@chromium.org> Commit-Queue: Norman Rosas <normando@google.com> Cr-Commit-Position: refs/heads/master@{#828387}
-
Austin Sullivan authored
Unresolved nit from https://crrev.com/c/2542805 Bug: 1139907 Change-Id: I6684aca074fa5d8f2ef416fed41f3e66ce5fc018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545225 Commit-Queue: Austin Sullivan <asully@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: Austin Sullivan <asully@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#828386}
-
Xianzhu Wang authored
We had 3 ways to check printing status: - Document::Printing()/Document::IsPaintingPreview()/Document::IsCapturingLayout() - GraphicsContext::Printing()/GraphicsContext::IsPaintingPreview()/GraphicsContext::IsPrintingOrPrintingPreview() - PaintInfo::IsPrinting() Now keep the first way only to ensure consistency and reduce chance of errors. Also simplify PaintRecordBuilder constructor parameters to avoid multiple default parameters, and let callers set some GraphicsContext related configs directly instead of through PaintRecordBuilder constructor. Change-Id: I479b98b19700c5bed077ec9ef00bd148e3b33c63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535627 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#828385}
-
Nick Burris authored
The call to ClearStoragePartitionData clears ownership of the event data, so it may be corrupt by the time the test JS executes. This patch makes it so the storage partition is cleared at the end of each test rather than before the JS values are read. This does not fix the unrelated ChromeOS flakes which are due to the test timing out only on that platform. Bug: 1129411 Change-Id: Iba8d8575bfb57c5e81a8a420386320c4d7e1d019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521693Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#828384}
-
Andrew Xu authored
This CL implements the feature that the delete button shows after its host item view is under gesture press for enough long time. Bug: 1147584 Change-Id: I27ba1dc11939dd47712aed7a0dd08cb9a1ea2b99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532909Reviewed-by:
David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#828383}
-
Maks Orlovich authored
This is almost entirely based on Lily Chen's https://chromium-review.googlesource.com/c/chromium/src/+/2169726/ (just with a different interface to the delegate, some test updates, and updating various sites that do inclusion checks). This allows access to Secure cookies from non-cryptographic but potentially trustworthy URLs. The Secure cookie access checks in CookieMonster are modified to allow access from localhost URLs, such that, by default, access to Secure cookies is allowed from cryptographic schemes and localhost. Additional potentially trustworthy origins (such as origins that are allowlisted) are allowed by the CookieAccessDelegate, so that when there is an active CookieAccessDelegate, access to Secure cookies is allowed from any potentially trustworthy origin. Note that nothing happens to the cookie when its source origin loses its potentially-trustworthy status. This can lead to situations where a previously-set cookie can no longer be read or modified by its source origin. Since integration tests use localhost URLs by default, several tests had to be modified to use different URLs that don't show up as localhost. For Fetch tests, this rather involved reverting the expectation that they would be unable to use SameSite=none cookies on http://localhost. Bug: 1056543 Change-Id: Id14a7b92001dbb5c03ac7009ba8f18614e67cd7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377987Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Steven Bingler <bingler@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ayu Ishii <ayui@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#828382}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f92a7636da65..ecb7a9bbb816 2020-11-17 bsheedy@chromium.org Revert "[typ] Use requests for ResultSink" 2020-11-17 hypan@google.com Add "third_party/gsutil" to cipd.yaml for devil 2020-11-16 bsheedy@chromium.org [typ] Use requests for ResultSink 2020-11-13 hypan@google.com Add CIPD create instruction cipd.yaml that packages devil If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1108014,chromium:1147992 Tbr: rmhasan@google.com Change-Id: Ife72772d25ac7767989451cc551b28e0e437ff34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542861Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828381}
-
Dave Vandyke authored
When the extension has enabled displayActionCountAsBadgeText, the action count for a tab is displayed as the badge text. So far, if the extension then queries the badge text a placeholder is returned. With this change we instead return the action count if the extension has the declarativeNetRequestFeedback permission or activeTab access granted for the tab. Bug: 1139852 Change-Id: I0500cee99a854390e88a7a7cb6e25ef90972d815 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502928Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#828380}
-
Norman Rosas authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //components/page_load_metrics Bug: 1113033 Change-Id: I93641d807e66e984f62d63e9c7522e1fefe70169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545262Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Norman Rosas <normando@google.com> Cr-Commit-Position: refs/heads/master@{#828379}
-
Dave Tapuska authored
Move to a single implementation of UpdateLifecycle in WebFrameWidgetBase. There are some additional steps that WebViewImpl takes, put those inside a ForMainFrame branch. BUG=1097816 Change-Id: I0474285150309a861c3fb080f625e7a7a324d10b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538174Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#828378}
-
Rakib M. Hasan authored
Bug: 1041619, 1147459, 1148450 Change-Id: Id1a61ce88a5a05b26835190fbd0e246434cad239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544743Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#828377}
-
Marijn Kruisselbrink authored
This reverts commit 2c942cf7. Reason for revert: Some of the added tests are flaky/slow. See for example https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29 https://test-results.appspot.com/data/layout_results/Linux_Tests__dbg__1_/93011/blink_web_tests/layout-test-results/results.html Original change's description: > [DevTools] Introduce `Page.DocumentOpened` CDP event > > Send a `Page.DocumentOpened` event via CDP when an iframe's content is > edited via JS. Writing to an iframe's document via JS is not considered > a navigation, therefore no `Page.Navigated` CDP event is emitted. But > since writing to an iframe's document can change attributes which > DevTools needs to be informed about, the `Page.DocumentOpened` event is > emitted instead. Previously only a refresh of DevTools would let > DevTools know about changes to an iframe caused by JS manipulation of > said iframe. > > Example (see http://doc/1gczarAME7AATGHwqm_IDqcGFlOM6DLAoX9rqetv4Rx0): > There is a 'frameNavigated' event for the initial load of an iframe. > If there is a 'document.write' for this iframe right away, there is no > 'frameNavigated' event for this iframe at all. > > Frontend CL: https://crrev.com/c/2507793 > (needs to be merged first, this will fix the failing tests, which fail > because the frontend cannot handle unknown CDP events) > > Bug: chromium:1140540, chromium:1140481 > > > Change-Id: I92a659b7ab8b1cb7ae50e28df40b8ca9b0bf8c86 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498482 > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Auto-Submit: Wolfgang Beyer <wolfi@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828122} TBR=dcheng@chromium.org,caseq@chromium.org,japhet@chromium.org,sigurds@chromium.org,arthursonzogni@chromium.org,wolfi@chromium.org Change-Id: Id84e5ccdf91dd8edf6a1fb6b8e613c401bbf2344 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1140540 Bug: chromium:1140481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545724Reviewed-by:
-
Tim Dresser authored
Add flackr@, and remove nzolghadr@. Change-Id: I105114ad7c89b9a2162a79880c6fc71d33578cb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541810Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#828375}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605612997-0b538d267d59602889f3873bf24b3a402bd4dd04.profdata to chrome-linux-master-1605635959-3de00f504d9de3eba6702b2e7e69c522ca7d3882.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I92b4601d5f52c6d19a3e6c2946f6be6a41f11f37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545228Reviewed-by:
-
Henrique Nakashima authored
tools/android/modularization/getowners.py traverses the codebase reading OWNERS files and uses git commands to read a number of metrics at the granularity of modules. This script will be run periodically in a builder to feed information into a dashboard. Bug: 1135347 Change-Id: I8ef4050396c796cc96aff757d99ad15cb14b9483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451326 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#828373}
-
Shakti Sahu authored
This CL removes the loading animation for the video player. We will use chrome media's in-built loading animation for this purpose which also provides better feedback on slow networks and other video failures. Bug: 1149946 Change-Id: Ib0e7ad4ab131e10e0bda01e819bb7314ec6d57b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542860Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#828372}
-
Adam Langley authored
BUG=1002262 Change-Id: Ief209ab2904ade456afa3dcdfd11d001aeb8330e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538158 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#828371}
-
Etienne Bergeron authored
This CL is adding unittests to ensures the layout is recomputed when the behavior or whitespace elision is updated. This fix is cleaning a TODO left in the code. R=msw@chromium.org Bug: 1085014 Change-Id: I803b6285bc03771b5026db63950bd60ebee1231c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545222Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#828370}
-
Jeffrey Kardatzke authored
This was not being handled correctly before. We now require passing back in the prior decoded slice data so that dependent slice header parsing will be correct. Previously we relied on the decoder to do this, but even then we didn't handle all the fields properly. Fixes new fuzzer case and removes need for prior fuzzer fix in this area. This also fixes a range check issue where values needed to be in the 0 to 2^15 - 1 range for a few things that fixes another fuzzer case. BUG=b:153111783,chrome:1149206,chrome:1148863,chrome:1149205 TEST=H265 playback still works, unit/fuzzer tests pass Change-Id: I722dd5d2996685fd716f2218b3d9031a51fc4c79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542946 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#828369}
-
edchin authored
Design doc: go/bling-phishguard PASSWORD_REUSE_DETECTION_ENABLED is only defined for !is_ios. This CL removes the use of this flag in files that are already not compiled in iOS. Bug: 1147962 Change-Id: Ibf646ea2536ceb15de4dd5e15c140bbbe2b5269a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543803Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#828368}
-
Mounir Lamouri authored
The feature is enabled by default and the flag is no longer required. Change-Id: Ifd7825e03edc2b166209f232bd1b5bd40a7f062a Fixed: 1112537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538352Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#828367}
-
Luciano Pacheco authored
Fix the export of `MediaSessionPlaybackState` to export the whole enum. Bug: 1133186 Change-Id: I67897f77d34741e9bf343c157b839fd6f282243f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543648 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#828366}
-
Marijn Kruisselbrink authored
This reverts commit 84cf3e38. Reason for revert: Some of the added tests have been very flaky since landing. The worst being All/ExperimentsManagerESAE2ETest.FetchingExperiments/0, see for example on https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=All%2FExperimentsManagerESAE2ETest.FetchingExperiments%2F0&testType=gcp_unittests Example test output: ../../chrome/credential_provider/gaiacp/experiments_manager_unittests.cc(191): error: Expected equality of these values: experiment1_value Which is: "abc" ExperimentsManager::Get()->GetExperimentForUser( base::UTF16ToUTF8(OLE2W(sid)), Experiment::TEST_CLIENT_FLAG) Which is: "false" Stack trace: Backtrace: credential_provider::testing::ExperimentsManagerESAE2ETest_FetchingExperiments_Test::TestBody [0x00007FF624EC0ED6+3350] (o:\chrome\credential_provider\gaiacp\experiments_manager_unittests.cc:189) testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,void> [0x00007FF6252EE67F+79] (o:\third_party\googletest\src\googletest\src\gtest.cc:2674) ../../chrome/credential_provider/gaiacp/experiments_manager_unittests.cc(194): error: Expected equality of these values: experiment2_value Which is: "def" ExperimentsManager::Get()->GetExperimentForUser( base::UTF16ToUTF8(OLE2W(sid)), Experiment::TEST_CLIENT_FLAG2) Which is: "false" Stack trace: Backtrace: credential_provider::testing::ExperimentsManagerESAE2ETest_FetchingExperiments_Test::TestBody [0x00007FF624EC1040+3712] (o:\chrome\credential_provider\gaiacp\experiments_manager_unittests.cc:192) testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,void> [0x00007FF6252EE67F+79] (o:\third_party\googletest\src\googletest\src\gtest.cc:2674) Original change's description: > Add support for fetching experiments > > Bug: 1143836 > Change-Id: I0c787bf1c663b28d94e67c8015910dbcb48a4779 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508633 > Commit-Queue: Yusuf Sengul <yusufsn@google.com> > Reviewed-by: Rakesh Soma <rakeshsoma@google.com> > Cr-Commit-Position: refs/heads/master@{#827540} TBR=yusufsn@google.com,rakeshsoma@google.com,wrlewis@google.com,ssanapala@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1143836 Change-Id: Iad3912ce90d3d7f95a18b5747a8a6efbc68b11e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544934Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Yusuf Sengul <yusufsn@google.com> Cr-Commit-Position: refs/heads/master@{#828365}
-
Yu Su authored
Bug: 1148031 Change-Id: I7e44ba488428a31479728d8c6d267070c1043edb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542950Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Yu Su <yuyansu@google.com> Cr-Commit-Position: refs/heads/master@{#828364}
-
Tarun Bansal authored
Bug: 989569 Change-Id: I0b669beade05c7d9d4e9af3215712868e149207a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521882 Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#828363}
-
Xi Han authored
When Instant Start is enabled, the calculateButtonData() is called pre-native and early exits without calling the IdentityDiscController#ensureProfileDataCache(). As a result, the IdentityDiscController misses the event of the onProfileDataUpdated() and thus doesn't notify its observer StartSurfaceToolbarMediator to update the visibility of the identity disc button. To fix the issue, we cache the call of calculateButtonData() from the Start surface if it is called pre-native. When a new Profile is set, we check if a cached request exists, and call the calculateButtonData() if yes. Thus, it guarantees to update the button data if Profile has updated, as well as to notify Start Surface to update the visibility of the button. Bug: 1137535 Change-Id: I3aca4434ecc74850ee226affd3c3425931cf02a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533522Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#828362}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f69ec827f69b..70f0ab5795d6 2020-11-17 sigurds@chromium.org Fix usage of style.setProperty 2020-11-17 andoli@chromium.org Refactor ui/Action.js into ui/ActionRegistration.js and update dependencies accordingly 2020-11-17 andoli@chromium.org Remove treeElement property bound to Node intances If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1134103 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0b3dcfb42cbfb87334740272a54cd4b5a701403c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544031Reviewed-by:
-
Ian Kilpatrick authored
When flex did a 2-pass layout (once to determine the intrinsic size, and a followup to shrink - and the block-size changed, we'd just perform a simplified layout pass. The fieldset layout algorithm "stretches" its content to its block-size upfront. Due to this using the simplified layout pass resulted in an incorrect layout, never correctly sizing the anonymous fieldset content. This patch disables the simplified layout pass for fieldsets. Bug: 1149714 Change-Id: I454a65363c019240dd4b30531009a13e8b596ea4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544755Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
-
Jan Krcal authored
This CL unifies the size of avatar icons in the Profiles native menu on Mac with the Chrome profile menu. Bug: 857064 Change-Id: Ie0336b272506ba10972921261eda8b055372de1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545162 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#828359}
-
Liviu Tinta authored
Bug: 989958 Change-Id: I2faf1553f355290838b6467e8a0fa1c6baf97531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544025Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#828358}
-
Sebastien Lalancette authored
Realized there were no tests for this action in that context. Also added coverage for the fix for the associate bug. Bug: 1140517 Change-Id: Ia16ff23d3dd4c95d35dcefe9d760305f058e5341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544048Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#828357}
-
