- 16 Jan, 2021 40 commits
-
-
Thomas Lukaszewicz authored
This patch introduces a EmbedderHidden() method that enables bubble WebUIController subclasses to take appropriate action when their embedder is no longer visible. TabSearchUI overrides this to destroy the |page_handler_| when its embedding bubble is no longer visible to prevent background updates. Cleaned up use of member variables in WebUIBubbleManagerBase and WebUIBubbleManager<T>. Bug: 1099917, 1166967 Change-Id: I374dd74b5a1c3d37a53e7213e64c096adef35bda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626114Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Yuheng Huang <yuhengh@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#844343}
-
Takumi Fujimoto authored
Part 1 of MediaNotificationService refactoring. Create an interface and make CastMediaNotificationProvider and PresentationRequestNotificationProvider implement it. Bug: 1021643 Change-Id: I899d0430a59a7432ed2d55bcbc23af3cb8405a07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606650 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#844342}
-
Yuheng Huang authored
Break up tabs related functionality to MultiTabStory to be more reusable in other features. Bug: 1099917 Change-Id: I7e1310ee4c680383b5347e1f046b7bb718e35837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631465 Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#844341}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1610733364-157abbebfa8d67c9510c102888afbc9dd88135a0.profdata to chrome-linux-master-1610755196-61d932c6744ad62f0472d9ac776510bd42cd0a54.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I14ae8be6fe0c069c9897b5a445fa72c65a5a00f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634275Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844340}
-
Owen Min authored
All channels load Chrome policies from the stable bundle id domain. So should the extension policies. Bug: 1163895, 831577 Change-Id: Id5bc4d5fcb0bffdc9444a53328d1ec9d20cb9008 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630230Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#844339}
-
WangHui authored
No logic changed. Bug:None Change-Id: Ib73cd10d6f7cffef67367f6da7ce26aefe0b2758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631515 Commit-Queue: HuiWang <wanghui210@huawei.com> Reviewed-by:
Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#844338}
-
Tomasz Wiszkowski authored
This change allows BaseCarouselSuggestion to show or hide the header text depending on whether it is desired to show it. Bug: 1166302, 1145685 Change-Id: If91da47ab1f121837d6c263dc6d217f2b4452b8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634015 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#844337}
-
James Cook authored
This is causing my build to fail locally. I'm not sure why it's working on the bots. Bug: none Change-Id: I3d715d9ce69637329719ea944da68c7ed5830a27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633200Reviewed-by:
Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#844336}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610733364-0048730fde812fecdb18597677d6c98bc22e5905.profdata to chrome-win64-master-1610744388-21de24e38f072743f3bfcce061ea4b5afc98a448.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie339537037586b105e19d6434c9ec13c36a7871d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633082Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844335}
-
Aaron Krajeski authored
Our toblob metrics were all ending up in the overflow bucket: https://uma.googleplex.com/p/chrome/histograms?sid=bc11d3b58d816ec456478bd44834c192 Also, UmaHistogramMicrosecondsTimesUnderTenMilliseconds is deprecated: crbug.com/983261 Unfortunately I need to change their names in order to use the new macro without messing up old data. Bug: 1165901 Change-Id: I163a093ab055a989aded448a4b5ee0f69ec3582e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625291Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#844334}
-
manukh authored
Traditional AutcompleteMatch's set their |fill_into_edit| to their URLs. With rich autocompletion before this CL, when the input matched the title, |fill_into_edit| would instead be set to the title, and |fill_into_edit_additional_text| would contain the URL and be displayed in a views::Label adjacent to the omnibox. E.g., for the input 'ti', the location bar would display 'ti[tle] (url.com)'. To avoid awkward cursor logic, only the omnibox is editable, and the adjacent label containing |fill_into_edit_additional_text| is not. This made it difficult to edit the suggestion URL before navigating to it when the user input matched the suggestion title. Therefore, this CL reverts to the original behavior of having |fill_into_edit| be the URL. Specifically: 1) No longer sets |fill_into_edit| to the suggestion title when the input matches the title. 2) Renames |fill_into_edit_additional_text| to |additional_text| since it is no longer used when suggestion selection changes. 3) Removes the |swapped_fill_into_edit| field as it would always be false now. 4) No longer sends the |additional_text| in view methods for selection changes since we only want to display the additional text for the default suggestions. 5) Removes the |kRichAutocompletionShowTitlesParam| param as it would require effort to make it compattible with the above changes, and fishfooders concurred it's not promising. This has the added side benefit of making |fill_into_edit| behavior consistent between suggestions that seem the same. I.e., before when selecting a suggestion whose title matched the input, sometimes the location bar would display 'title (url.com)' and othertimes 'url.com' (depending on the input length and whether the match was a shortcut match). Bug: 1163356, 1062446 Change-Id: If42f30d693b7d5204d94c3f21e72662879d8b857 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616973 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#844333}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bfd330d08195..05e5446145a6 2021-01-15 johnstiles@google.com Code cleanup: minor fixes in convertSwitch. 2021-01-15 johnstiles@google.com Reorder GLSL output so that functions are emitted last. 2021-01-15 scroggo@google.com Deprecate (and ignore) SkAndroidCodec::ExifOrientation 2021-01-15 brianosman@google.com Enforce ES2 limits on indexing expressions (in runtime effects) 2021-01-15 fmalita@chromium.org [svg] Property inheritance workaround 2021-01-15 johnstiles@google.com Implement Type cloning for enums and structs. 2021-01-15 johnstiles@google.com Migrate Type-cloning logic from the Inliner into Type. 2021-01-15 johnstiles@google.com Revert "Disable the MSAA atlas mode for CCPR" 2021-01-15 brianosman@google.com Enable matrix-negation interpreter test If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: ethannicholas@google.com Change-Id: Ie33584dbe0719fdda2e82537318a198a9df16e04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633458Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844332}
-
Fritz Koenig authored
V4L2PixFmtToVideoCodecProfiles doesn't need to know if the caller is an encoder or decoder, it will do the same thing regardless. BUG=none TEST=none Change-Id: Ib1676b52f58fc63be4d9ee0432b3d60eff8f8305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634052 Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Auto-Submit: Fritz Koenig <frkoenig@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#844331}
-
Yusuke Sato authored
They are unused, and don't even have definitions. BUG=None TEST=try Change-Id: Ife26905454428a93d1dde5603023fd50b067ae0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632625 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Auto-Submit: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#844330}
-
Phillis Tang authored
Disallow drag install for urls that are not http or https, eg: chrome: //xx links as they don't qualify as app url. Bug: 1157390 Change-Id: Id15a64dedb7e22e4a390ce4cf1457b84e95bdb20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634014Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Phillis Tang <phillis@chromium.org> Cr-Commit-Position: refs/heads/master@{#844329}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/b5d77a48d740..576e0801f928 $ git log b5d77a48d..576e0801f --date=short --no-merges --format='%ad %ae %s' 2021-01-13 huisu vpxenc: initalize the image object 2020-12-17 angiebird Fix show_index in vp9_extrc_encodeframe_decision() 2020-12-17 angiebird Correct pixel_count in encode_frame_result 2020-12-15 huisu First pass: skip motion search for intra-only 2020-12-11 gjasny configure: add darwin20 cross-compile support 2020-12-10 jleconte Fix nullptr with offset. 2020-11-25 angiebird Fix typos in simple_encode.h 2020-11-24 angiebird Revert "Close out file in EndEncode()" 2020-11-20 angiebird Refine documentation of vpx_ext_ratectrl.h 2020-11-19 angiebird Allow user to set rc_mode and cq_level in SimpleEncode 2020-11-17 angiebird Add gop_index to vpx_ext_ratectrl.h 2020-11-17 angiebird Capitalize VPX_RC_OK / VPX_RC_ERROR 2020-11-17 angiebird Add doxygen for vpx_rc_funcs_t 2020-11-13 angiebird Add doxygen for vpx_rc_config 2020-11-13 angiebird Copy first pass stats documentation from AV1 to VP9 2020-11-13 angiebird Add doxygen to structs in vpx_ext_ratectrl.h 2020-11-13 angiebird Fix uninitialized warning in resize_test.cc 2020-11-13 angiebird Fix the warning of C90 mixed declarations and code 2020-08-10 angiebird Close out file in EndEncode() Created with: roll-dep src/third_party/libvpx/source/libvpx R=jzern@google.com Change-Id: I06789ff7cfab1dc8da824acadc0f3595db62ae60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632807Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#844328}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/af4a3a998449..149733cead63 2021-01-15 sugoi@google.com Fix crash in vertex shader when position is not declared If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I2b20a5a0db871057674f70dd789bf8eae625a31c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632875Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844327}
-
Arthur Hemery authored
Currently we have two parallel paths, we send the ip_address_space to the renderer via commit_params but also via the PolicyContainer. This patch removes the commit_params path and now relies only on the PolicyContainer. That also helps with having correct inherited values before the first commit happens. Bug: 1154729 Change-Id: I5ecc93c1e236061e96317b6788fff71cdb9d4d27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625868Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Titouan Rigoudy <titouan@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#844326}
-
Mason Freed authored
This was part of another CL that I didn't end up landing, but I did the archeology so I figured I should keep the results. Change-Id: I7c96e2d73014315becbef6577e3a49ae614e341a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634224 Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#844325}
-
Nate Fischer authored
This reverts commit 001f4ee8. Reason for revert: new flakiness crept in, see crbug.com/1147838 Original change's description: > Revert "Disable testFlingScroll" > > This reverts commit 74872d88. > > Reason for revert: Test was failing due to the device screen being locked, not a problem with this specific test. > > Original change's description: > > Disable testFlingScroll > > > > Disable > > org.chromium.android_webview.test.AndroidScrollIntegrationTest#testFlingScroll > > due to flaky > > > > Bug: 1147938 > > Change-Id: Ic701876e9c09399309b06827d1384b665b9b9509 > > Tbr: boliu@chromium.org > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535554 > > Reviewed-by: Owen Min <zmin@chromium.org> > > Commit-Queue: Owen Min <zmin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#826959} > > TBR=boliu@chromium.org,zmin@chromium.org,dbertoni@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1147938 > Change-Id: I135d770ca7a98a56a00b3b617db6b69d787b845f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541649 > Reviewed-by: Owen Min <zmin@chromium.org> > Reviewed-by: Nate Fischer <ntfschr@chromium.org> > Commit-Queue: Richard Coles <torne@chromium.org> > Commit-Queue: Nate Fischer <ntfschr@chromium.org> > Auto-Submit: Richard Coles <torne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827889} TBR=boliu@chromium.org,torne@chromium.org,zmin@chromium.org,ntfschr@chromium.org,dbertoni@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1147838 Change-Id: I1839a37805f58442503d3f78699a7fb971c4427d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633195Reviewed-by:
Michael Bai <michaelbai@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Michael Bai <michaelbai@chromium.org> Auto-Submit: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#844324}
-
Yuwei Huang authored
It isn't straightforward for the user to figure out the UID of an audio device, so this CL provides an extra host routine to list all available audio devices and their UID. The user can trigger it by running: remoting_me2me_host.app/Contents/MacOS/remoting_me2me_host --list-audio-devices An example output looks like this: Audio devices: Device name: BlackHole 16ch Device UID: BlackHole_UID Device name: MacBook Pro Microphone Device UID: BuiltInMicrophoneDevice Device name: MacBook Pro Speakers Device UID: BuiltInSpeakerDevice Bug: 1161363 Change-Id: I060d08956a9635cb6d8e165a90f891399fb63be5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630741 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#844323}
-
Jonathan Ross authored
Scheduling.{Browser|Renderer}.SwapToAckLatency2 and PrepareTilesDuration2 are both expired in M-85 and no longer needed. We have better fine grained metrics available in CompositorLatency.* Removing these and marking them obsolete. Bug: 1034813 Change-Id: I50cc84b8fe9cafbf87611178492d026f0a2b8260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633167Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#844322}
-
Tibor Goldschwendt authored
Makes shortcuts Finch-configurable. Flag is enabled by default. Bug: 1166872 Change-Id: I24c1b5cf6a0fe192f580b5dca899480730d000ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633189 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#844321}
-
Andy Perelson authored
Changes were generated by a few lines of bash which I've documented at http://go/paste/4886211966533632. Limiting this CL to files in directories that don't set noparent in OWNERS so it can be done with a small set of reviewers for a large set of directories. Can do more targetted follow up CLs for the rest. R=tedchoc Bug: 1167291 Change-Id: I3ffbc694d284a34cbba1d14f36baecff0216da98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633527 Commit-Queue: Andy Perelson <ajp@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#844320}
-
Ryan Sturm authored
Completion time is the only timing field that is set even when load timing is not enabled. For now, we will solve this with setting the completion time (and thereafter response end) to when the memory cache is actually hit. Bug: 1167308 Change-Id: Idfa8d628d42f5acf66ba702319c1bce6aa618199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634022 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#844319}
-
Tom Anderson authored
BUG=443355,1138143,1161141,1161143,1161144,1161145,1161146,1161147,1161149,1161151,1161152 Change-Id: I5c95a9d066683d18f344d694e517274e3ef7ccb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622521Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#844318}
-
Nicolás Peña Moreno authored
This CL slightly updates PageEndReason3 (new version from 2): * HIDDEN is removed as a page end reason due to the fact that we no longer flush the metric when the page is hidden. * APP_ENTER_BACKGROUND is added as a reason as the metric can be reported when this happens, and it is not a page closure per se. UKM collection review: https://docs.google.com/document/d/1nGbQlG5bdrKn_vFzZxIIiIzAGbwooC1n2S4DHYmVivI/ Bug: 1049260 Change-Id: I3ff183d73f36287f3a99590abd552ea15d37e252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630746Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#844317}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/54449966dd2e..04772515a8b6 2021-01-15 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 0a68b365ebff to c068cfc1397a (2 revisions) 2021-01-15 cwoffenden@gmail.com Missing header for VS1029 (for commit 8c58491d) 2021-01-15 bclayton@google.com StorageTextureTests: Use textureNumLayers() 2021-01-15 bclayton@google.com StorageTextureTests: Use new access qualifiers Also rolling transitive DEPS: https://dawn.googlesource.com/tint from 0a68b365ebff to c068cfc1397a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: I22c5232fa409307fbc4b0160651569cfc9d630fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634127Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844316}
-
Moe Ahmadi authored
Fixed: 1162444 Change-Id: I3911e22e11d712d3520ae258f574f097e7994327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631359Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#844315}
-
Alex Newcomer authored
To prevent multipaste from jumping when deleting items, remember the old menu position. Bug: 1165288 Change-Id: I136d43ec9524a6ddcaff1ba371a50e90ce321d0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633963 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#844314}
-
cfredric authored
Change-Id: I3f0c448a4ecb1e7a629db48954e50a5b3e0a9985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621672Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Cr-Commit-Position: refs/heads/master@{#844313}
-
Joe Downing authored
I noticed these while looking at the flag handling code path in the host code and figured they should get cleaned up. Change-Id: I91d0b9b8a483e386181650b8ae287b0247aa113b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634084 Auto-Submit: Joe Downing <joedow@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#844312}
-
adamta authored
Ensures correct scroll position on refactored NTP when opening new tabs and when navigating back from a webpage to the NTP. Bug: 1114792 Change-Id: I365034f218445e6ff8e1483dabb18202f7af976c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633581 Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#844311}
-
Henrique Ferreiro authored
This CL is part of the Chrome OS source code directory migration: https://docs.google.com/document/d/1g-98HpzA8XcoGBWUv1gQNr4rbnD5yfvbtYZyPDDbkaE. Bug: 1164001 Change-Id: I19542959e230536269b4efe8b707c95957a8bce2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618140 Owners-Override: James Cook <jamescook@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#844310}
-
Patrick Noland authored
This move also allows/requires us to: * Move backKeyPressed/mOriginalUrl/getOriginalUrl * Stop overriding backKeyPressed and setUrl in SearchActivityLBL In the latter case, we continue to override back key behavior via a delegate. As far as I could tell it's safe to stop overriding setUrl, since: * SearchActivity's LocationBarDataProvider only ever returns an empty UrlBarData * SearchActivity's's UrlBar can't be unfocused Just to be sure, I've added a test for this scenario. Bug: 1147581 Change-Id: Ic1291b788a4913980d542135a828120e4a7cb353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594214 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#844309}
-
Aaron Colwell authored
Changing the RenderViewHost parameter to a WebContents to more closely match the signature of OverrideWebPreferencesAfterNavigation(). This change also makes it clearer that the RenderViewHost that was being passed in was actually one for the WebContents main frame. This in turn makes it easier to replace GetSiteInstance() calls on the RVH with calls on the WebContents and be assured that the behavior is still correct. Replacement of these calls is part of the refactorings needed to remove the SiteInstance member from RenderViewHost. - Replaced RenderViewHost parameter with WebContent pointer and updated all function signatures of overrides. - Removed a few RenderViewHost to WebContents conversions in overrides since the WebContents is passed in directly now. - Replaced RenderViewHost::GetSiteInstance() calls with WebContents::GetSiteInstance() calls. - Replaced rvh->GetProcess()->GetBrowserContext() calls with web_contents->GetBrowserContext(). TBR: boliu, jamescook, rdevlin.cronin, dalecurtis, mlamouri, dpapad, seantopping,falken, ddorwin, dgozman Bug: 1166021 Change-Id: Ie39614b3de07383114915813fb959be017dd4b1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626355 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#844308}
-
Lijin Shen authored
MessageUtils resets the accessibility utils to null when one of the activities is destroyed, which causes the crash when another activity is about to show a message. This CL removes static message utils and passes in the a11y util directly to the classes which need a11y info. Bug: 1167098 Change-Id: I5404f35ec173ab25334e8108a27b4886f1bb9478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634122Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#844307}
-
chinsenj authored
This CL renames AssignToDesksMenu to MoveToDesksMenu. It also updates comments related to this. Additionally, this CL also updates the command ids and strings related to this menu. Test: manual Bug: 1166856 Change-Id: I24813b042e674031f3c09b74f4aaa5967df77aba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630769Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Cr-Commit-Position: refs/heads/master@{#844306}
-
Azeem Arshad authored
This adds OWNERS for //chromeos/dbus/hermes. Points to //chromeos/network/OWNERS Bug: 1093185 Change-Id: I31373e9644a9f2100956b3a54c79010736e1fd67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633804Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#844305}
-
Elaine Chien authored
Allow Enterprise admins to apply the policy without needing a browser restart. Bug: 1158427 Change-Id: I52dc1488eb1c29ec4d93c73169e4523efd838244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633070 Commit-Queue: Elaine Chien <elainechien@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#844304}
-