- 22 Aug, 2019 40 commits
-
-
Nigel Tao authored
This runs the test with and without marking an app as a default app. Not much actually seems to depend on that bit being set. This means that the (existing) test isn't ideal, but as the added commentary says, it's probably better than nothing. Change-Id: Ic508abf972e3ae939963f22dc2f1f19d9b9ca555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732092 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#689355}
-
Austin Tankiang authored
Bug: 993678 Change-Id: I75a1319b19cff076da6bfd7f31793d0fa8a7bab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757405Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#689354}
-
Takuto Ikuta authored
Currently, webkit_layout_tests on linux-rel took around 24 mins in slowest shards. e.g. https://ci.chromium.org/p/chromium/builders/try/linux-rel/172077 And this is the slowest test in linux-rel. So it is better to remove this modification. webkit_layout_tests on linux does not have large overhead, so this won't affect capacity requirement match. Instead, this will reduce wait time in builder and that may shrink capacity. NOTRY=true Bug: 868114 Change-Id: I0cbbaea215e52ae1d2f1d0c5b6249de263513587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763552 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#689353}
-
Chinglin Yu authored
This implements the jankiness profiler on ChromeOS. The ProfilePrivder observes jankiness through JankMonitor and then sends notification to each registered MetricCollector implementation class. The profiles are collected with the JANKY_TASK trigger event. Bug: 904785 Test: unit_tests. Change-Id: I699286541a6d892efe1e7e2ada47defbc57a1bfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692209 Commit-Queue: Chinglin Yu <chinglinyu@chromium.org> Reviewed-by:
Gabriel Marin <gmx@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#689352}
-
Yue Zhang authored
Currently, chrome crashes if user ungroups a tab right after closing the dialog. This is because that the recyclerView is cleared out when dialog hides and thus we lose reference to the item being ungrouped. This CL fixes this issue. Bug: 990702 Change-Id: If1322f2aaf704c7b6ab006f35200594d44d8317d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739344Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#689351}
-
Austin Tankiang authored
Bug: 993678 Change-Id: Idc11c9b6a9f87d6006dcad4f53a2dac23ce437cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757404Reviewed-by:
-
Findit authored
This reverts commit fd82f584. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 689336 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2ZkODJmNTg0Y2MzMDhkZDkxYWExMTIwNjNhODRhZDQ5ZWQ2YjhkYTMM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/28411 Sample Failed Step: compile Original change's description: > Migrate hid.mojom and related classes to the new Mojo types > > This CL converts hid.mojom and related classes from old Mojo types > to the new types. Major changes are as below, > > - Apply PendingRemote to HidConnectionClientPtr. > - Replace InterfacePtr with mojo::Remote > - Replace mojo::Binding with mojo::Receiver > > Bug: 955171 > Change-Id: If4b686844272cd1763be50ff7620e00e1084a108 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761874 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > Cr-Commit-Position: refs/heads/master@{#689336} Change-Id: I9444d50f890dfd4b84ecdf78bd8d7a78dd6c83f5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 955171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764556 Cr-Commit-Position: refs/heads/master@{#689349}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/42c6af9182d2..57f211b56a99 git log 42c6af9182d2..57f211b56a99 --date=short --no-merges --format='%ad %ae %s' 2019-08-22 bsalomon@google.com SK_API in src/gpu cleanup Created with: gclient setdep -r src/third_party/skia@57f211b56a99 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@google.com Bug: None Change-Id: I124ccf89642e39a2fa496ff00a0be32d023ce191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764875Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689348}
-
Jason Lin authored
This is a reland of bbe68ab3 This reland resolves the following issues: * CrostiniInstallerViewBrowserTest fails to pass MSAN * CrostiniInstallerTest is flaky Also note that the original description links to the wrong issue crbug.com/912638 instead of crbug.com/929571. Original change's description: > Factor non-ui logic out of CrostiniInstallerView > > The current CrostiniInstallerView contains a lot of non-ui logic such as > histogram recording and somewhat complex interaction with CrostiniManager. This > CL factors out the non-ui logic into new class CrostiniInstaller. This not only > makes the code cleaner, but also allows us to port the installer UI to WebUI > much more easily. > > > Bug: 912638 > Change-Id: Ie0195c8580518aa39e59aa539ef2fb614978776b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1701024 > Reviewed-by: Ben Wells <benwells@chromium.org> > Reviewed-by: Timothy Loh <timloh@chromium.org> > Commit-Queue: Jason Lin <lxj@google.com> > Cr-Commit-Position: refs/heads/master@{#688021} Bug: 929571,995261,992298 Change-Id: I85809d7760ee99fa1100e303aadf04837db9666b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760640Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#689347}
-
Sven Zheng authored
This file is for live tests that needs src-internal checkout. Bug: 992565 Change-Id: I20ed30e17ccfe588dbc1df03ee82f2b8a613d658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764609Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#689346}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/3418cf472b93..bf2dc2c1e95f git log 3418cf472b93..bf2dc2c1e95f --date=short --no-merges --format='%ad %ae %s' 2019-08-22 cjmcdonald@chromium.org parallel_emerge_new: Disable Portage vardb locks for boards 2019-08-22 cjmcdonald@chromium.org Make root-deps argument optional Created with: gclient setdep -r src/third_party/chromite@bf2dc2c1e95f The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I32f563c86d924f2fb610fe1579604514e08892c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764874Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/f52a5e29712d..88c370baef61 git log f52a5e29712d..88c370baef61 --date=short --no-merges --format='%ad %ae %s' 2019-08-21 tsepez@chromium.org Pass owning reference to CFWL_Message to OnProcessMessageToForm() 2019-08-21 tsepez@chromium.org Make TranslateFWLMessage() own the message it is sending. 2019-08-21 thestig@chromium.org Rename |CFX_Break::m_Line| to |m_Lines|. Created with: gclient setdep -r src/third_party/pdfium@88c370baef61 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: Icc7f8e11f9d40e84389af729e09002a53ba3ea9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764873Reviewed-by:
-
Maggie Chen authored
A DCHECK is triggered in GpuWatchdogThreadImplV2::Arm() during GPU initialization. Whenever there is an error, GpuInit::InitializeAndStartSandbox() exits earlier. watchdog_thread_->OnInitComplete() is not called in those cases and arm_disarm_counter_ gets messed up. A new class GpuWatchdogInit is created to call OnInitcomplete() in the destructor. OnInitComplete() will never be missed at the end of InitializeAndStartSandbox(). Bug:949839, 995372 Change-Id: I1a107df0ca48409ff2252260ea41de643fa39b6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762879Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#689343}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f8ff63e09525..103e407c01f1 Created with: gclient setdep -r src-internal@103e407c01f1 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: Ifa5adfef6a34beb62fa9260d0352bd9cfbfafaea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764872Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689342}
-
John Chen authored
NOTRY=true TBR=crouleau@chromium.org Bug: chromedriver:2860 Change-Id: I70349540da8215d1be314cf8f0f3e2e73f91e903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764795Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#689341}
-
Luciano Pacheco authored
Bug: 778674 Change-Id: I96e6757fb68166f99d0dbd8ac6be5ae1c7d7da0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763271 Commit-Queue: Alex Danilo <adanilo@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#689340}
-
Mei Liang authored
This CL modifies incognito GTS to use the same color palette as Dark mode. In addition, this CLs add darker theme support for all tab group related UIs in incognito, except for TabSelectionEditor. Change-Id: Ic1517867cf90ac0550fd1bf15e91cd19c4231eab Bug: 960891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745619 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#689339}
-
Moe Ahmadi authored
Bug: 996516 Change-Id: I1d15cc85274698027896c21324cc1fd12648c962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764868 Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#689338}
-
Esmael El-Moslimany authored
Bug: 996152 Change-Id: I3f2d09288393d251528badaa668f1317585e9eec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764431 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#689337}
-
Gyuyoung Kim authored
This CL converts hid.mojom and related classes from old Mojo types to the new types. Major changes are as below, - Apply PendingRemote to HidConnectionClientPtr. - Replace InterfacePtr with mojo::Remote - Replace mojo::Binding with mojo::Receiver Bug: 955171 Change-Id: If4b686844272cd1763be50ff7620e00e1084a108 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761874Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#689336}
-
Sam Goto authored
Sample: https://storage.cloud.google.com/chromium-translation-screenshots/d2da91cc316334522197c0b6cb4eb0c8dddc58f5 After doing one round of outreach, we learned quickly that the modal dialog was too disruptive for developers and an imposition on their flow. https://github.com/samuelgoto/sms-receiver#opt-in-ux The blocking nature of the modal assumes there is nothing else to be done, which quickly proved to be too strict for partners (e.g. some forms have first/last names input fields that can be entered while one waits for an OTP). In this CL, we move our implementation from a blocking UX to an unblocking UX, reusing the InfoBar visual language: https://github.com/samuelgoto/sms-receiver#unblocking-ux We debated for a while keeping both implementations in the code base, but decided against it due to the (a) maintenance cost involved, (b) memory / strings consequences involved, (c) code complexity introduced and (d) our intuition that the infobar is a strictly better UX than modal dialogs for this feature. This CL: - deletes the old modal dialog implementation (and its resources) - creates an info bar dialog implementation - removes the content/public/SmsDialog interface Bug: 994874 Change-Id: I1360de9fa0bb10f99df71684e6f617b7c0c4f5cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751966 Commit-Queue: Sam Goto <goto@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#689335}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/18e21a5b..b91d75c9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I29f605db524a2e40068304593629be730c86cc02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763879Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689334}
-
Kent Tamura authored
CacheControlMaxAge(), Age(), and CacheControlStaleWhileRevalidate() of ResourceResponse should return base::TimeDelta instead of double They are |delta-seconds| [1], and base::TimeDelta is more suitable than double. [1] https://tools.ietf.org/html/rfc7234#section-1.2.1 Bug: 988343 Change-Id: Ifa617cc52ded0e88710aba0ca0a458273bdf93f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757256Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#689333}
-
Rafael Cintron authored
In preparation to reuse the code in SwapChainFactoryDXGI for shared images, this CL renames classes to have more general purpose names: * SwapChainFactoryDXGI --> SharedImageBackingFactoryD3D * SharedImageBackingDXGISwapChain --> SharedImageBackingFactoryD3D * GLImageDXGISwapChain --> GLImageD3D * SwapChainFactoryDXGI --> SharedImageBackingFactoryD3D::IsSwapChainSupported * SwapChainFactoryDXGITest --> SharedImageBackingFactoryD3DTest Bug: 966580 Change-Id: Iffb511df7802a78e1ca3ceafd83fdb082b33a478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761438 Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by:
Maggie Chen <magchen@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#689332}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/78f41f5a6e33..ec4ea59c6d52 git log 78f41f5a6e33..ec4ea59c6d52 --date=short --no-merges --format='%ad %ae %s' 2019-08-22 dneto@google.com Force Glslang to support HLSL in its interface (#784) Created with: gclient setdep -r src/third_party/shaderc/src@ec4ea59c6d52 The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: I55091bd304c26da0c85224b911a97850770ab0df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764892Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromium.org Change-Id: Ia29bb79a54e64e504392952a82a4c67e6db36887 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764400Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689330}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/c9ccac7cb734..fb49e6c16449 git log c9ccac7cb734..fb49e6c16449 --date=short --no-merges --format='%ad %ae %s' 2019-08-21 zhangxy@google.com Merge pull request #2393 from kuzkry:custom-type-traits-remove_const 2019-08-21 absl-team@google.com Googletest export Created with: gclient setdep -r src/third_party/googletest/src@fb49e6c16449 The AutoRoll server is located here: https://autoroll.skia.org/r/googletest-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_cfi_rel_ng;luci.chrome.try:win_chrome_official TBR=isamsonov@google.com,staphany@google.com Bug: None Change-Id: I167a094c06c4de743e7a618f700b96c59be746eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764342Reviewed-by:
Staphany Park <staphany@google.com> Reviewed-by:
Staphany Park <staphany@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689329}
-
Donn Denman authored
Extends the CardTag histogram, which tells us what kind of card has been generated from the server and therefore characterizes the data that we'll display in the Bar. This is a very useful histogram, which we'll use for several experiments in the works. BUG=984239 Change-Id: I0aac1e7b0e22a296d6a8d8ab6efac552dd632fa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752388 Commit-Queue: Donn Denman <donnd@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I300826b935887976b8818d7c19c331d9a57de643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764891Reviewed-by:
-
Justin Cohen authored
Increases a webState timeout, disables a request desktop and two share button tests. Bug: 995797, 996541, 990186, 996544 Change-Id: I07c8dd52d0bb13c6c805ef35b2c727ec3deb84bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762331 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#689326}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fe65f6d2c3d1..42c6af9182d2 git log fe65f6d2c3d1..42c6af9182d2 --date=short --no-merges --format='%ad %ae %s' 2019-08-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@42c6af9182d2 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@google.com Bug: None Change-Id: Ia6aa0cb33665a29a2314db77322a6a76e088bb04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764770Reviewed-by:
-
Ryan Hamilton authored
https://quiche.googlesource.com/quiche.git/+log/9a910e3deaec..0b20fdfd4bea $ git log 9a910e3de..0b20fdfd4 --date=short --no-merges --format='%ad %ae %s' 2019-08-21 rch Add missing include of <set> to qpack_decoder.h2019-08-21 rch Use the uint64_t specialization of std::min in qpack_encoder.cc to fix Chrome build breakage where size_t != uint64_t. 2019-08-21 bnc Enforce limit on number of blocked streams in QPACK decoder. 2019-08-21 fayang gfe-relnote: Remove QUIC version 44. 2019-08-21 quiche-dev gfe-relnote: change logs about window update frames from DLOG(INFO) to DVLOG(1). 2019-08-21 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_fix_packets_acked. 2019-08-21 renjietang Prevent QPACK streams from being created more than once. 2019-08-21 nharper gfe-relnote: Use new flag quic_enable_version_48_2 for QUIC_VERSION_48 2019-08-21 bnc Remove two obsolete TODOs from http_decoder.cc. 2019-08-20 bnc Use dynamic table for QPACK encoding. 2019-08-20 bnc Feed header block in fragments in QPACK roundtrip fuzzer. 2019-08-20 fayang gfe-relnote: Add live check to QuicSpdySession. No functional change expected, not protected. 2019-08-20 renjietang Do not check config() when sending HTTP/3 SETTINGS frame. 2019-08-20 fayang gfe-relnote: In QUIC v48, support partial write of CRYPTO frames. Protected by existing gfe2_reloadable_flag_quic_enable_version_48. 2019-08-20 fkastenholz Add flag to QuicSession indicating that it has been configured 2019-08-19 wub gfe-relnote: Default-initialize QUIC BBRv2 loss event threshold for exiting STARTUP from a flag. Protected by --gfe2_reloadable_flag_quic_default_to_bbr_v2. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I3ec9ca8c79805a0a371c10bec36c9150332bdfe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764252 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#689324}
-
Dan Beam authored
BUG=994064 TBR=pastarmovj@chromium.org Change-Id: I9d9b40fa01a39c38c4dbc9886362ebd006fa0ec3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756432 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
-
Makoto Shimazu authored
This CL adds a test to check if WebRequest API can observe requests for service worker scripts. There are a couple of code paths to load a service worker script: new script on registration, and updating the service worker. This tests the both. I manually confirmed this passes when disabling ServiceWorkerImportedScriptUpdateCheck, and temporarily disabled since it's enabled by default now. Let's enable the test when the fix lands. Bug: 995763, 991443 Change-Id: I230d4a5b3b7928e25c69b27b3316ab015ef3aa16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763487 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#689322}
-
Ryan Hamilton authored
which takes a QUIC flag name and value as a string and sets the flag appropriately. Bug: 984738 Change-Id: If2223c084da792d25dfc94ca4ac3795c39895338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761254Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b06831a5ae4a..f8ff63e09525 Created with: gclient setdep -r src-internal@f8ff63e09525 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:991478 Change-Id: I64bfe19094ac641a78b04427e9aa1b1e94e8e864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764771Reviewed-by:
-
Gyuyoung Kim authored
As the last step to deprecate Platform::GetDataResource(name), this CL removes Platform::GetDataResource(name) in //content and blink. Bug: 983396 Change-Id: Ibdb8b3c44a9184f031b157ed0c2bd0cf6e9ad721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761899 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Nick Diego Yamane authored
Currently, MessagePumpGlib's FD watching API implementation sets FdWatch Gsource's can_recurse to false, which causes issues when nested loops are used (e.g: X11WholeScreenMoveLoop, ClipboardOzone, etc). So, switch it to true to fix that aforementioned issue. Bug: 996117 Change-Id: I41d9b37eeb1a3b9a4e9cf8cf6c675181f8a6706b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760426Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#689318}
-
Findit authored
This reverts commit 591bf020. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 689296 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzU5MWJmMDIwMzI5ZTk5YjZlMDBiNTgzYjgzNmYyODlkNTBhY2FhM2QM Sample Failed Build: https://ci.chromium.org/buildbot/chromium/android-archive-rel/3803 Sample Failed Step: compile Original change's description: > UI_DevTools: Backend for ui_devtools performance panel. > > The goal is to enable and create the performance tool for ui_devtools. > The performance panel will record and show metrics such as FPS, CPU time utilization > for Aura/Views UI. This CL is for the backend only. The TracingAgent is very similar > to the TracingHandler from > https://cs.chromium.org/chromium/src/content/browser/devtools/protocol/tracing_handler.cc. > > Bug: 989052 > Change-Id: Ic696e09f700e93bcd0842fdbda575ef1f54af63a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726651 > Commit-Queue: MyungJae Lee <myungjaelee@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Dana Fried <dfried@chromium.org> > Reviewed-by: oysteine <oysteine@chromium.org> > Reviewed-by: Leonard Grey <lgrey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#689296} Change-Id: Icce706bb8f3e3451762bcea6d5611cfc863f73e3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 989052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764933 Cr-Commit-Position: refs/heads/master@{#689317}
-
Chromium WPT Sync authored
Using wpt-import in Chromium dc613c9c. With Chromium commits locally applied on WPT: 1194775a "Add ability to block same-origin access via document-access feature policy" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools msisov@igalia.com: external/wpt/webvtt rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I95beb857f3d488a0f480652ff18b9164e9c2f49a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763877Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689316}
-
