- 21 Aug, 2019 40 commits
-
-
Thomas Tangl authored
Bug: 966388 Change-Id: I9c4537e1802ac08407c28db2139806ecefc9d149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763753 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#689128}
-
David Trainor authored
This reverts commit a42eb196. Reason for revert: Causing a crash. See crbug.com/996179 Original change's description: > Change Show in folder to single pulse + test > > Bug: 994293 > Change-Id: I2446ed845f08b5173ac25fe836e50b114f58cf45 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756545 > Commit-Queue: Theresa <twellington@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Cr-Commit-Position: refs/heads/master@{#688295} TBR=dtrainor@chromium.org,twellington@chromium.org,mdjones@chromium.org,jhimawan@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 994293 Change-Id: Ie448f7de1ef72dac1e3bd4f7c93466c903ab1b03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762473Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#689127}
-
Kush Sinha authored
Chrome OS Account Manager has been enabled for 1% on Stable channel. Enable it on ToT as preparation for 100% Stable ramp up. TBR=droger@chromium.org Bug: 816954 Change-Id: I6e0097237600e40c39a98e59af063deddd1da9a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761588Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#689126}
-
Nazerke authored
The colors for the button and selected table cell are changed to the right ones. Bug: 995271 Change-Id: I988161221bbc46853672aace94132505beaab1b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762221 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Auto-Submit: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#689125}
-
Christopher Cameron authored
These get in the way of refactoring, and aren't used anyway. TBR=raymes Bug: 982024 Change-Id: Ifa87a5e7af30a8529bf531409b49307f499a64fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761714Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#689124}
-
Ben Kirchman authored
We had made response header names lowercase because they are case insensitive. It turns out UrlResponseInfoImpl already uses a TreeMap with a case insensitive order. Map keys will always be case insensitive anyway, but it could be confusing to users if we change the case of the headers. Original Discussion: crrev.com/c/1703325/36/components/cronet/android/fake/java/org/chromium/net/test/FakeUrlRequest.java#203 Bug: 669707 Change-Id: If8af8faf9214fba51e2dceab28e8dcb82976b8ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762356 Commit-Queue: Benjamin Kirchman <kirchman@google.com> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#689123}
-
Elly Fong-Jones authored
This reverts commit 7472b906. Reason for revert: sheriff suspects this caused a build break on win{,32}-archive-rel: https://ci.chromium.org/p/chromium/builders/ci/win-archive-rel/4309 In file included from ../../chrome/chrome_cleaner/ipc/proto_chrome_prompt_ipc_unittest.cc:14: In file included from ../..\base/test/scoped_task_environment.h:15: In file included from ../..\base/task/lazy_task_runner.h:17: ../..\base/task/task_traits.h(263,5): error: static_assert failed due to requirement 'has_thread_pool ^ has_extension' "Traits must explicitly specify a destination (e.g. ThreadPool or a named thread like BrowserThread)" static_assert( ^ ../..\chrome/chrome_cleaner/ipc/proto_chrome_prompt_ipc.h(108,39): note: in instantiation of function template specialization 'base::TaskTraits::TaskTraits<base::MayBlock, void>' requested here base::CreateSequencedTaskRunner({base::MayBlock()}); ^ 1 error generated. Original change's description: > [TaskEnvironment] Standardize paradigm for classes forwarding traits > > As discussed @ > https://chromium-review.googlesource.com/c/chromium/src/+/1749538/6/ash/test/ash_test_base.h#84 > > Usage of explicit everywhere also avoids implicit copy construction > and is the reason for changes to a few unit tests that previously > used operator= to initialize their task environments. > > TBR=dcheng@chromium.org > (for widespread mechanical change) > > Bug: 992483 > Change-Id: I321576674f3b387a6f5069e8e71eebf41c98e7ed > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758338 > Reviewed-by: Gabriel Charette <gab@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#689098} TBR=dcheng@chromium.org,gab@chromium.org Change-Id: I69b71b220ab583bc3a18e8fb07213fa1b6a75b50 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 992483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762475Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#689122}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I7c2ea12e5a011f27ba2a026beac9a2aa8b984004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763161Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689121}
-
Alex Keng authored
This CL enables <input type=text/number/password/button/submit> to render high contrast colors when high contrast mode is enabled. test: web_tests\fast\forms\controls-new-ui-high-contrast\text_number_password_button_submit.html Note the test is verifying if we are correctly using system colors in high contrast mode and since we don't really change system setting for HC in webtests, the results colors are still black/grey/white (in higher contrast) instead of black/white/green. Bug: 994219 Change-Id: I0a9653c3051eb9e7db01ef43ec024354518be950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763429 Commit-Queue: Alex Keng <shihken@microsoft.com> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#689120}
-
Thomas Tangl authored
Bug: 966388 Change-Id: I19ff60ec305481b5de301a41a1807d154981afc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763673Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6a337fb9b12b..2891cbc02f12 git log 6a337fb9b12b..2891cbc02f12 --date=short --no-merges --format='%ad %ae %s' 2019-08-21 taylori@google.com perfetto-ui: Fix to split up FrontendLocalState Created with: gclient setdep -r src/third_party/perfetto@2891cbc02f12 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: I3750be80265c5f8052b4a01ca2dc383ba4dec61a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763639Reviewed-by:
-
Allen Bauer authored
Bug: 862097 Change-Id: I961db6594f82812270fbd8d3114e9aa687abb43e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762689 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#689117}
-
Sigurdur Asgeirsson authored
Bug: 996273 Change-Id: Ib14172afd9ca3b4661f5708572d2d719a71379b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759059 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#689116}
-
Kevin Bailey authored
Using the previously added submatch support, this CL allows tab switch suggestions to be separate suggestions below their parent suggestion. Instead of clicking a button to activate the tab switch, this change allows selecting a special suggestion. Bug: 995935 Change-Id: I039e879f1b330cf9b17755daf9134013451cd9f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762827 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#689115}
-
John Lee authored
https://imgur.com/a/MfVqsey Bug: 989131 Change-Id: If40b94d6ceecbdf46ee336e765f65df2efb19673 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762835Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#689114}
-
Tanisha Mandre authored
- Implement Coordinator which uses the same Presenting delegate as the QR Scanner. Bug: 989951 Change-Id: I6a48b71313825b1139d0d0f237fd0c91125ed487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730906 Commit-Queue: Tanisha Mandre <tanishamandre@google.com> Reviewed-by:
-
Chris Harrelson authored
Bug: 967076 Change-Id: I099d7862e216ea656fccef800d38e3396b0a8668 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761077 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#689112}
-
Etienne Bergeron authored
This CL is adding UMA metrics to evaluate the amount of calls to each fallback fonts mechanism. 1) Compare the PlatformFontWin and PlatformFontSkia on fallbacks 2) Determine whether or not the FontLink code on windows is not used (see crbug/995789). ShapeRuns(...) is shaping the text by running these mechanisms: 1) Skipping newline character 2) Trying the primary font 3) Trying the fallback font (e.g. GetFontFallback(...)) 4) Trying the fallbacks font (e.g. GetFontFallbacks(...)) 5) Failing to shape the text R=robliao@chromium.org, asvitkine@chromium.org Bug: 995789 Change-Id: I954c50ab8dfa8d0a6e552f175d58357685a3b95f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759058Reviewed-by:Robert Liao <robliao@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#689111}
-
Jeremy Roman authored
Move destruction of an adopted-but-not-inserted portal into HTMLPortalElement::ExpireAdoptionLifetime. Change-Id: Id7323e014838ae9c06434369f4d7e1124062275a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761400Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#689110}
-
Pratish Kumar authored
This CL introduces a new method PDFiumPage::CalculateImage() which is responsible for populating images vector in PDFiumPage. Added a unit test TestCalculateImages() as well as pdf test file containing three images to verify the image data. Bug: 981448 Change-Id: Ifbc8426cb47a3a7a76b2bca309c7a68e1792b3fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738690Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Lei Lei authored
Change-Id: I096f86553aa1c173c03f2e103a8c199db94d7d3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711101Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Lei Lei <leilei@chromium.org> Cr-Commit-Position: refs/heads/master@{#689108}
-
Matt Menke authored
This CL adds NetworkIsolationKey as an argument to the ServerNetworkStats methods in HttpServerProperties, and makes consumers pass in the correct key. Bug: 969890 Change-Id: I0259dc37b0428a7a649e2391b6c23459caba4673 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758297 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#689107}
-
Eric Karl authored
Change-Id: I170282a5298026be223d63259cebd527444fb05a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763159 Auto-Submit: Eric Karl <ericrk@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#689106}
-
Xing Liu authored
This CL rewrites the logic to schedule background task in BackgroundTaskCoordinator. Now it's based on deliver time window. The old unit tests are deleted, new unit tests will be added in following CL. Bug: 991010 Change-Id: I8a05e8178d94b1daadf87d8abc8f9e0bac783e37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756439 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
-
Darwin Huang authored
No intended logic changes, but should be more readable. Change-Id: Ife2389f5fbfa8e5448d584efdd612cbc1d67721d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762979 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#689104}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/3654f21952d9..ad86dfbd3219 git log 3654f21952d9..ad86dfbd3219 --date=short --no-merges --format='%ad %ae %s' 2019-08-21 cjmcdonald@chromium.org Move cros_check_patches to use depgraph lib Created with: gclient setdep -r src/third_party/chromite@ad86dfbd3219 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I566d93f86fc30f285076df403d9edefb28bdc386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763173Reviewed-by:
-
James Cook authored
The outline was appearing even if the user used the mouse to click on the button. Elsewhere in settings we only show outlines when the user uses the keyboard. Update action-link CSS styles to check the global focus-outline-visible style added by FocusOutlineManager. I did this at the settings level, rather than for all action-links, because I'm not sure that all consumers of action-link need or want a dependency on FocusOutlineManager. Bug: 995921 Test: no outline when button clicked with mouse, outline present when triggered with keyboard Change-Id: Idb7d4e0f96bb70d1d24c63fbc760460198a08304 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762695Reviewed-by:
-
Sergio Villar Senin authored
NullValue() is represented as a NaN in a double. We could better return a base::Optional<double> and use the undefined base::Optional as null value. Also there is no need for the IsNull() call as we could just use the returned value as a boolean. Bug: 994811 Change-Id: Ibb4a6b89102dd49450d68aae35b03e9eba46332f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760963Reviewed-by:
Kevin Ellis <kevers@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#689101}
-
Xing Liu authored
This CL adds metrics to track two level db we use in notification scheduling system. TBR=dtrainor@chromium.org Bug: 963298 Change-Id: I6e0698827b0ef5450df1c23abca8f94168086e09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761651 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Reviewed-by:
-
Vladislav Kuzkokov authored
This reverts commit 75116336. Reason for revert: crbug.com/996271 Original change's description: > [Printing] Don't create unnecessary PrintSettings instances. > > Make |PrintingContext::settings_| null before settings are created or > after ownership is passed to PrinterQuery. > > Bug: 964948 > Change-Id: I0cff0b5b460ecb3424ff0cb07e5849bed3ffe51e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678182 > Reviewed-by: Lei Zhang <thestig@chromium.org> > Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#688541} TBR=thestig@chromium.org,vkuzkokov@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 964948 Change-Id: If0dfec489dcbb8e38f2fbf3e8510904dc80893f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758237Reviewed-by:
Vladislav Kuzkokov <vkuzkokov@chromium.org> Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#689099}
-
Gabriel Charette authored
As discussed @ https://chromium-review.googlesource.com/c/chromium/src/+/1749538/6/ash/test/ash_test_base.h#84 Usage of explicit everywhere also avoids implicit copy construction and is the reason for changes to a few unit tests that previously used operator= to initialize their task environments. TBR=dcheng@chromium.org (for widespread mechanical change) Bug: 992483 Change-Id: I321576674f3b387a6f5069e8e71eebf41c98e7ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758338Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#689098}
-
Gabriel Charette authored
This is a reland of dd34a877 Rebased on a few more fixes including a local full build of: - Windows + is_chrome_branded - ChromeOS + is_chrome_branded (except for the libassistant portion which is giving weird errors...) Original change's description: > Reland [base] Require task posters to specify an explicit destination > > This patch makes it a requirement for all task traits to specify their > thread affinity. Previously task traits that did not name a specific > thread would implicitly run on the thread pool, which could be > surprising. To make this more obvious, thread pool tasks must now use > the base::ThreadPool() trait. > > This is the final reland of > https://chromium-review.googlesource.com/c/chromium/src/+/1635827 > (will attempt to fix errors that caused original revert before > relanding). > > Bug: 968047 > Change-Id: Ice339db270a27815b2be68200930e5bc105e8a96 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759056 > Commit-Queue: Gabriel Charette <gab@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#688782} Bug: 968047 Change-Id: Iccd12e0a9f1535cb10b903777c5004a7d1acb34a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761362 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#689097}
-
Dominic Farolino authored
This CL stops referencing the local variable |new_response| after we assign the private |new_response_| to it, for consistency. Bug: N/A Change-Id: Ide27ddae64cc20e870a6d27e71d9636ab41a7f6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760578Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#689096}
-
Alison Maher authored
Inline background images are painted after backplates are drawn in forced colors mode. This breaks the ensured level of contrast for such elements. To account for this, background images are ignored for inline elements when forced colors mode is enabled and forced-color-adjust is auto. Bug: 970285 Change-Id: I609eb1779ed3a9d964cb6165e5452b9d2a9666e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757685 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
-
David Bokan authored
Event sender is used only in web_tests. Tests shouldn't ever set this case up but we shouldn't ever crash. Bug: 996071 Change-Id: I4fa1ef12d934b1698ca2f70070bcb509355dd491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763375Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#689094}
-
Tricia Crichton authored
All remaining commands that changed in W3C mode, were updated to point to the command_executor version, which uses the correct W3C syntax. Bug: chromedriver:3076 Change-Id: I12234e4bb6462daf5c79b916d9b33bd127892653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763301Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#689093}
-
Mohamed Amir Yosef authored
Change-Id: I63c4f71016101a761e6ecb67233bce79bf922fa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741920 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#689092}
-
Min Qin authored
This CL treats extension downloads from untrusted sources as regular downloads. That means these downloads will be prompted, show up in downloads page and download shelf as normal downloads. BUG=756825 Change-Id: I515bba2fa0a64198a56a06ce38864ef59ad18c9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761374Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#689091}
-
George Burgess IV authored
In the linked bug, we discovered that clean Chrome links with ThinLTO enabled consume quite a bit of memory. In my measurements, Chrome OS x64 links take around 49GB, and a standard Linux ThinLTO link takes around 46GB. Build command: $ /usr/bin/time -v ninja chrome [snip] Maximum resident set size (kbytes): 46337504 [snip] $ cat args.gn target_os = "linux" target_cpu = "x64" use_goma = true is_official_build = true is_chrome_branded = true clang_use_default_sample_profile = true use_thin_lto = true (the last two args should be redundant in this case) Measured similarly, Android's build takes 8-9GB on ARM, so it gets to stay at 10GB. Bug: 988364 Change-Id: Ia1bbf6b441dcb9219a37842060e72eebe7ec687e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755189Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#689090}
-
Mohamed Amir Yosef authored
This unblocks upcoming patches that would allow accessing the used fcm_network_handler for testing purposes. Change-Id: Ia940186ba7558a84433950265e80bea4c83d2b85 Bug: 985287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710658 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
-
