- 29 Aug, 2018 40 commits
-
-
Boris Sazonov authored
This CL wires up 'Activity and interactions' and 'Google activity controls' entries in SyncAndServicesPreferences. It also updates strings used for 'Google activity controls' entry. Bug: 814728 Change-Id: I161bdc0df44d46aba3ad795da2c2a9be5ca543c9 Reviewed-on: https://chromium-review.googlesource.com/1194038Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#587241}
-
Dominic Mazzoni authored
* The site uses Polymer, so we get some web components performance coverage * Tests some simple animations and re-layout, helping us prevent accessibility performance regressions when those occur Bug: none Change-Id: I0e7d55c587b05148e76c532cd21a8d37696c36d5 Reviewed-on: https://chromium-review.googlesource.com/1188893 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#587240}
-
Rakina Zata Amni authored
Bug: 868227 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I4dc042dbcf7e38b71a64d1caa2982110e2796fef Reviewed-on: https://chromium-review.googlesource.com/1193602Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#587239}
-
Pete Williamson authored
This replaces the FileObserver based screenshot detection algorithm with an algorithm based on ContentObserver, which has proven more reliable in our testing. Design doc here: https://docs.google.com/document/d/1iyiVQODF1qh_Qiz7Is1y9jvWt1DYjgXmiJgLbFt2tSs Bug: 857505 Change-Id: Ie4edf56683d92f0834dd1afbe77a49949d2d932f Reviewed-on: https://chromium-review.googlesource.com/1191922Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#587238}
-
David Tseng authored
When an aura Window receives a new transform, it possibly impacts its bounds. Previously, we were only observing OnWindowBoundsChanged, which does not get called for transform changes. This change makes it so we also observe OnWindowTransformed and fire a location change to push the new location to all accessibility clients. Bug: 842868 Change-Id: I5251198da8b4af6cb96ad3197a6d37caa0a37faa Reviewed-on: https://chromium-review.googlesource.com/1195645Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#587237}
-
Ian Clelland authored
This queues a report through the Reporting API whenever an image is encountered which violates the 'unsized-media' policy, in a document in which that feature is not allowed according to feature policy. Bug: 867471 Change-Id: I8d39639d21d9a993685f97efc078a9a1ab6f303c Reviewed-on: https://chromium-review.googlesource.com/1195675Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#587236}
-
Joe Downing authored
This CL splits up the existing Mouse input monitor for Windows into a common base class for mouse and keyboard and adds the keyboard implementation for Windows. We can implement the other platforms as needed. Bug: 877176 Change-Id: I2ae2168ff340b81306065e647a2d1bd17b59c9d9 Reviewed-on: https://chromium-review.googlesource.com/1187335 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#587235}
-
Matt Reynolds authored
Add a default configuration for the GamepadPollingInterval finch experiment to fieldtrial_testing_config.json. BUG=855188 Change-Id: I0168675acaa21c95db0e6f61d4735a5dc791ef61 Reviewed-on: https://chromium-review.googlesource.com/1191808Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#587234}
-
Sebastien Marchand authored
This switch the value of the flag to true by default. The only reason why it was set to false was that the UKM was still pending approval, but it has now been approved and it's probably better to set it to true by default rather than setting it manually in every experiments. Bug: 844426 Change-Id: I0fdea3413886f4610233e95696306f25fc9d70a0 Reviewed-on: https://chromium-review.googlesource.com/1195543 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#587233}
-
Majid Valipour authored
will-change workaround is no longer necessary. Most other cases have been removed in http://crrev.com/584946 Bug: 873673 Change-Id: I3f531c58951aba923f390674c7acac58fe39b860 Reviewed-on: https://chromium-review.googlesource.com/1195646Reviewed-by:
Peter Mayo <petermayo@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#587232}
-
David Tseng authored
Bug: 862419 Change-Id: Id04a7a505333a33227924051f336e2440e4ba5a0 Reviewed-on: https://chromium-review.googlesource.com/1194572 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
-
Sarah Hu authored
This is only used by settings and is no longer needed per latest mock. Bug: 876067 Change-Id: Ib9dd98b1912f87d881fb7ec8f74b17f56352b656 Reviewed-on: https://chromium-review.googlesource.com/1188454Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Cr-Commit-Position: refs/heads/master@{#587230}
-
Stephen McGruer authored
Upstream the spec has changed from using 'null' to represent a missing composite value on keyframes to using 'auto'. Instead of changing our internal representations to use two different enums (i.e. CompositeOperator and CompositorOperationOrAuto), this CL just updates the conversion logic to treat 'auto' as the previous 'null' value, avoiding any change of internal logic. Spec change: https://github.com/w3c/csswg-drafts/issues/3000 Bug: 877967 Change-Id: I8a1c83799f4a538c0102875f6259ac337e9d0843 Reviewed-on: https://chromium-review.googlesource.com/1191205Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#587229}
-
Christopher Cameron authored
In previous patches, we have routed almost all usage of the views APIs in BridgedContentView to go through the BridgedNativeWidgetHost. This completes this process. Change initialization of BridgedContentView to not take a views::View, and instead take the initial bounds (which were previously the only thing read from the views::View). Move the functions CreateContentView and DestroyContentView to the public interface. Add a new non-public function, CreateDragDropClient, because drag-drop behavior has not been routed through mojo-ifiable interfaces yet. Add an accessor to BridgedNativeWidget to query whether or not the window is translucent (which was previously determined by querying properties of the ui::Layer). Bug: 859152 Change-Id: Iaa5b628f619fc35a48530812c15d0cc877a3d40c Reviewed-on: https://chromium-review.googlesource.com/1192547 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#587228}
-
kristipark authored
Delete any links initialized from Most Visited when their history entry is cleared. If the link is modified by the user (i.e. edit/add), the link will not be deleted when history is cleared. Bug: 874185 Change-Id: I762fe713c097bfa75e86b25368cff25e116d674d Reviewed-on: https://chromium-review.googlesource.com/1179246 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#587227}
-
Navid Zolghadr authored
Push a new PointerRawMove in the main thread event queue for MouseMove events. Note that we do not send compatibility mouse events for this type. Only PointerEvent with the type pointerrawmove. Also note that this change only adds pointerrawmove for mouse events at this point. pointerrawmove for touch events should come in the following CLs. Intent to implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/84RGJvm_PMM Bug: 873684 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Icb003b8ba978f1c64157dbbe79222a687d4aa42d Reviewed-on: https://chromium-review.googlesource.com/1181171Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#587226}
-
Etienne Pierre-doray authored
This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/ui/webui. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. R=scottchen@chromium.org Bug: 874080 Change-Id: If28d24f284744bcdda4b48c27d20952d17c20db2 Reviewed-on: https://chromium-review.googlesource.com/1191419Reviewed-by:Tommy Li <tommycli@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#587225}
-
Min Chen authored
Drop the dragged window into overview if the window has been dragged further than half of the distance from top of the display to the top of the new selector item in overview. Do not apply this rule if preview area is shown or splitview is active. Bug: 874508 Change-Id: Ib3faf6aadd8a49f2380b330fddd1b647bf63a9e7 Reviewed-on: https://chromium-review.googlesource.com/1192699 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#587224}
-
Ian Clelland authored
This queues a report through the Reporing API whenever the PaymentRequest API is invoked from a frame in which the 'payment' feature is not allowed according to feature policy. Bug: 867471 Change-Id: Ie03fe06924a634829d03fb9d9693aee29ab66dd2 Reviewed-on: https://chromium-review.googlesource.com/1191411Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#587223}
-
Justin Cohen authored
This reverts commit ae6e8514. Reason for revert: cronet and webrtc aren't on Xcode 10 yet. Original change's description: > [ios] Bump minimum Xcode requirement to 10. > > Change-Id: I60521b36cb903ca18d59fe88caa1a9c7b1aa9e87 > Reviewed-on: https://chromium-review.googlesource.com/1182377 > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Reviewed-by: Justin Cohen <justincohen@chromium.org> > Commit-Queue: Justin Cohen <justincohen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#587174} TBR=rohitrao@chromium.org,sdefresne@chromium.org,justincohen@chromium.org Change-Id: I815f001ec9c75008791dd46cb1ee39f62248a160 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1194601Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#587222}
-
Simeon Anfinrud authored
Instead of using multiple mutable Controllers for WebContents and Uri, use a single StartParams Controller and derive everything else from that. Bug: 113094427 (followup) Test: cast_shell_junit_tests Change-Id: I0d9e11a5b905d5937378b03569b99bc277117a0d Reviewed-on: https://chromium-review.googlesource.com/1194795Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#587221}
-
Fredrik Söderquist authored
This CL reworks the core of SVGMarkerData so that it first extracts the "features" of the current segment/PathElement, and then uses those features to determine the orientation. The state of SVGMarkerData is also changed from two pairs of points to two vectors, since this is the representation that's actually used by CurrentAngle(). It should also be a better representation when handling of degenerate curves is added. CurrentAngle() is changed to return a 'double', and the clamping previously done in the method is now done by the callers. Additionally The code that computes the bisected angle is split out to a separate function. Bug: 450368 Change-Id: Ic9561cab3bbf9c3f5cbc9f3607cfc9bfe90fea05 Reviewed-on: https://chromium-review.googlesource.com/1193847Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#587220}
-
Weidong Guo authored
Bug: 878519 Change-Id: I4a29c0ff3c0de6799e1597bcdbe81f812bc5a86f Reviewed-on: https://chromium-review.googlesource.com/1195097Reviewed-by:
-
Pedro Amaral authored
Previously we were theming the bottom toolbar with the website specified theme color. After talking with UX we decided that it would only have the bottom toolbar color reflect whether incognito mode was enabled. This CL makes it so the bottom toolbar is light colored when incognito is not enabled and dark colored when it is enabled. Bug: 875870, 852140 Change-Id: I839d2938209d463191892dcd3fe68c527bba44c2 Reviewed-on: https://chromium-review.googlesource.com/1192125Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#587218}
-
Donn Denman authored
This reverts commit a2495396. Reason for revert: Underlying crash has been fixed. Original change's description: > Temporarily disable two ContextualSearchTapEvent tests. > > Recent changes to ContextualSearchPolicy are causing the KitKat Phone > Tester to fail, temporarily disables the affected tests. > > TBR=donnd@chromium.org > > Bug: 878430,878512 > Change-Id: I449216aee736cbfcce30cbc035793cd8ccb8d608 > Reviewed-on: https://chromium-review.googlesource.com/1194738 > Reviewed-by: Troy Hildebrandt <thildebr@chromium.org> > Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#586915} TBR=donnd@chromium.org,thildebr@chromium.org Change-Id: I7ad819188a9cd57dc4551c80610be051e81fa524 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 878430, 878512 Reviewed-on: https://chromium-review.googlesource.com/1195754Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#587217}
-
Etienne Pierre-doray authored
This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/safe_browsing. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. R=vakh@chromium.org Bug: 874080 Change-Id: I49c31da1c962eb6005ed6655e259ed719c6f9953 Reviewed-on: https://chromium-review.googlesource.com/1190929Reviewed-by:Robert Sesek <rsesek@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#587216}
-
Patrick Monette authored
This is a reland of ed0a1be1 after fixing a broken test. Original change's description: > Fix the issue with 3rd-party DLL blocking and IAttachmentExecute > > Because the IAttachmentExecute interface will invoke registered > third-party IOfficeAntiVirus provider, it's possible to put Chrome > in a state where all downloads fail if a DLL needed by one of the > provider is blocked. > > This CL introduces 2 temporary solutions that aims to separately > address the issue for enterprise and regular users. The long-term > solution is to move the call to the attachment services to a > utility process where third-party DLL injection is explicitly > allowed. > > For enterprise users, simply never enable the blocking feature on > domain-joined machines. > > For regular users, add a feature (InvokeAttachmentServices) that > allows us to no longer invoke the IAttachmentExecute interface and > instead use the fallback code path that manually sets the Zone > Identifier (Mark of the Web). > > The fallback code was a bit outdated because Windows 10 now adds the > HostUrl and ReferrerUrl data into the Zone Identifier. This CL adds > a new feature that writes this data similarly to how the > IAttachmentExecute interface does. This change is also behind a new > feature (AugmentedZoneIdentifier). > > Finally, the chrome.mediaGalleries API > (https://developer.chrome.com/apps/mediaGalleries) was also using > the IAttachmentExecute API. A third feature now controls whether > the mediaGalleries component uses the same function as the download > manager, in order to benefits from the changes described above. > > Bug: 870998 > Change-Id: I50c5d804c469b2499f1e6ec6998e146baaaace7a > Reviewed-on: https://chromium-review.googlesource.com/1188864 > Reviewed-by: Asanka Herath <asanka@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Chris Hamilton <chrisha@chromium.org> > Reviewed-by: Min Qin <qinmin@chromium.org> > Commit-Queue: Patrick Monette <pmonette@chromium.org> > Cr-Commit-Position: refs/heads/master@{#586940} Bug: 870998, 852295 Tbr: chrisha@chromium.org Tbr: thestig@chromium.org, Tbr: qinmin@chromium.org Tbr: asanka@chromium.org Change-Id: I7d3e52e16f69ce746ebd682bdf1d69d78441f488 Reviewed-on: https://chromium-review.googlesource.com/1195682Reviewed-by:
Patrick Monette <pmonette@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#587215}
-
Byoungkown authored
Using "use_jumbo_build=true" args in GN, speed up builds in components/url_formatter. Bug: None Change-Id: I8c1ea3a67bafb99cb3b432a4b15ed22390ce4f58 Reviewed-on: https://chromium-review.googlesource.com/1190362Reviewed-by:
-
Dave Tapuska authored
Since Interstitial pages don't allow navigation they can't be told to go back from the renderer. Trap the back mouse button in the interstitial page and handle it directly. BUG=852230 Change-Id: Ibbd5d97a9bd692a0b431a19eb6466b0512e7bce5 Reviewed-on: https://chromium-review.googlesource.com/1194831 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#587213}
-
nednguyen authored
Bug: 803137 Change-Id: I0ecd7f1885cca5b15c3aa2e6c95cddf867753a75 Reviewed-on: https://chromium-review.googlesource.com/1195746Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#587212}
-
Vaclav Brozek authored
Pieces of dead code removed: * is_possible_change_password_form -- this data member is never read, only assigned. * UsernamesCollection data type, never used * name data member -- only used on iOS, so removed from the Mojo bindings (which are only used on platforms using //content) Bug: 852772 Change-Id: I29337fbfc632dbce38d6b85cd00e885e28f738c7 Reviewed-on: https://chromium-review.googlesource.com/1195504Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
-
Eric Roman authored
Change-Id: I00071ce9d7917f7671e82547fab9f60d7c2ef2c8 Reviewed-on: https://chromium-review.googlesource.com/1192415 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#587210}
-
Dan Harrington authored
This will be used to show only a summary of available offline content on the net error page, instead of the list view. Bug: 852872 Change-Id: Id9a23351ce3a43ebd4308abde38a0d3f4829ae5d Reviewed-on: https://chromium-review.googlesource.com/1190645 Commit-Queue: Dan H <harringtond@google.com> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#587209}
-
Lukasz Anforowicz authored
This CL extracts the second half of CommitDataNavigation method into a new CommitDataNavigationWithRequest method. The new method is called by the old WebLocalFrameImpl::CommitDataNavigation method and by RenderFrameImpl::LoadNavigationErrorPageInternal. The CL also consolidates and deduplicates RenderFrameImpl code related to committing of error pages: - It avoids duplication of the code that calculates blink::WebFrameLoadType and blink::WebHistoryItem based on content::HistoryEntry* - It removes the need to pass arguments that either 1) do not differ among callers or 2) can be deduced from other arguments. For example: - GURL(kUnreachableWebDataURL) - is_client_redirect This CL should be a pure refactoring, with no change in behavior. Bug: 874544 Change-Id: I0088ad6367407ba70aa28c550ca46d7121dd78eb Reviewed-on: https://chromium-review.googlesource.com/1176230 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#587208}
-
Dmitry Gozman authored
This timing logically belongs to NavigationInfo structure and DecidePolicyForNavigation call, instead of DidStartProvisionalLoad. Any additional bits of information in DidXXXLoadYYY should generally belong to one of the existing structures and not be plumbed separately. This also makes it possible to further reduce duplication between StartNavigation and CommitNavigation by calling latter from the former in some circumstances. Bug: none Change-Id: Ic1d42a4445e068c2414a59e397f2503dca864689 Reviewed-on: https://chromium-review.googlesource.com/1194875Reviewed-by:
-
Jan Krcal authored
Before this CL, migration to USS for wallet data USS bridge fails because - this bridge does not support incremental updates, - a clear-all gc directive is expected for every (non-empty) update for such bridges, and - the uss migrator does not provide the directive (as it has no clue about which data types expect which directives). This CL exempts initial updates from this rule and allows them to arrive without any gc directive. Bug: 876308 Change-Id: I2dd91f077ee3602d88e96c5532c3bb910b48c224 Reviewed-on: https://chromium-review.googlesource.com/1194366 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
-
David Black authored
Show a message to the user when we are not selected to return a response due to multi-device hotword loss. Bug: b:112364854 Change-Id: I8c876622ddb69fc7e67ff64848394e1c5fa60491 Reviewed-on: https://chromium-review.googlesource.com/1192590Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#587205}
-
David Bokan authored
Skip updating visual viewport's paint property nodes unless one of the inputs has changed. Bug: 868927,877184 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux-blink-gen-property-trees;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I62e37c449a14098175e79d6d357a5aecac314e9a Reviewed-on: https://chromium-review.googlesource.com/1194564 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#587204}
-
Paul Jensen authored
This is accomplished by avoiding holding Cronet_UrlRequestImpl::lock_ while issuing callbacks. Holding the lock is only necessary while modifying state that should be processed in an atomic fashion. The Cronet_UrlRequestImpl will not be deleted until after final callbacks have been run so there is no chance of a use-after-free. Bug: 869402 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;luci.chromium.try:ios-simulator-cronet Change-Id: Ie851b57296c394e6f098022a7930d65f62f7b0c6 Reviewed-on: https://chromium-review.googlesource.com/1183625Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#587203}
-
Steve Kobes authored
PaintLayer::location_ is relative to the containing block, not the parent layer. For a MouseEvent on a position: absolute element, we were adding the parent layer's location to a value that already included it, which doesn't make sense. The behavior of layerX and layerY remains quirky and not standardized. There is an open issue at https://github.com/w3c/uievents/issues/135. It's unclear if the FIXME about ConvertToLayerCoords is still correct. Bug: 856525 Change-Id: Iba5bb7b2c955b4bd526597628cd789ff0eb42e90 Reviewed-on: https://chromium-review.googlesource.com/1195648Reviewed-by:
-
