GitLab

Bug: 965999
Change-Id: Ica5fb02f000171714ce40b670b2de532ad46503b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625245
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Jian Li <jianli@chromium.org>
Reviewed-by: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662742}

HTMLPlugInElement::PluginWrapper() can be called for a plugin element
that does not have a document node frame. This causes a crash in
MimeHandlerViewContainerManager::Get() which expects the passed
|render_frame_| to be nullptr.

Bug: 966371
Change-Id: I6ba558efdf416f421d1a540f947d79203b0bc985
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627267Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662741}

Bug: 963448
Change-Id: Ib1d140f23d04353371158879aaf984306e585420
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625459Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Jenny Zhang <jennyz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662740}

Change-Id: I6b3a1bb41b8fd01217347c20e8bbd59367084112
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625390Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662739}

https://chromium.googlesource.com/angle/angle.git/+log/344ecaa6755d..d9fa0744e82b


git log 344ecaa6755d..d9fa0744e82b --date=short --no-merges --format='%ad %ae %s'
2019-05-23 jgilbert@mozilla.com Emit OVR_multiview2 on ESSL/GLSL outputs.


Created with:
  gclient setdep -r src/third_party/angle@d9fa0744e82b

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@google.com

Change-Id: I21f0cd8a58a94452fb77ccec3354c72dccf542f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626701Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#662738}

TBR=agrieve  # Trivial refactor in remoting

Change-Id: I33da8ab9f2585b0c15f978f5b6a0870240b83e26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627650
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662737}

Bug: 861509
Change-Id: I96d7fc00331b25361a26d59fd68d4eb300e12c5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626799
Commit-Queue: John Budorick <jbudorick@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Auto-Submit: John Budorick <jbudorick@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662736}

light mode: https://screenshot.googleplex.com/PWCNx1XrTBK.png
dark mode: https://screenshot.googleplex.com/86rWXw8u4bM.png

Bug: 963793
Change-Id: Ie6981aab2482190f74ea75d3e950045373f234ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625855Reviewed-by: Kyle Milka <kmilka@chromium.org>
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662735}

After downstream switched to new API,
it is safe to remove these methods
Downstream cl:
https://chrome-internal-review.googlesource.com/c/chrome/ios_internal/+/1284395

Bug: 922813
Change-Id: Ic813d77bfc6f6ad192300ced1dee8e8b2f69f36b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623543
Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662734}

Surface has the context of the frame_token from the active_frame_data_
pointer, so it can supply the callback that the Display aggregates
during DrawAndSwap. When the Display gets notified of presentation
feedback, it'll call through the Surface, which then calls a new
SurfaceClient API with the same information.


R=sadrul@chromium.org

Bug: 965537
Change-Id: I0d275ad0f37fb212c3fd7e7460aaef1db9734373
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623167
Commit-Queue: Daniel Libby <dlibby@microsoft.com>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662733}

These tests were flakily hanging, with unsufficient diagnostic output
for us to diagnose the issue. Now that we have per-Run() timeouts we
can re-enable these tests to get diagnostic call-stacks when they hang.

Bug: 913037
Change-Id: I718c3bcbad2f21b4fe061d88a4b1daf53fd7e56e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627213Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662732}

The ink drop was the default tray buttons size instead of the
larger size of the menu button. Updates the ink drop calculation
to ensure the size is set properly, fixing the ink drop's
appearance on the switch position menu button.

Bug: 966151
Change-Id: I4e65932dc9b2e90e81746454e084feaac1148956
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626014Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662731}

Android Studio creates a folder src/AndroidStudioDefault for the
libraries, and this can lead to false alarms in PRESUBMIT.py.

Bug: None
Change-Id: I7b2e1de119086a2bc22c8ad202ff0c590b6a7392
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625902
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662730}

https://chromium.googlesource.com/catapult.git/+log/1d6ef8a04840..2491ddef9616


git log 1d6ef8a04840..2491ddef9616 --date=short --no-merges --format='%ad %ae %s'
2019-05-23 nednguyen@google.com Update webpagereplay OWNER
2019-05-23 perezju@chromium.org [Telemetry] Fix default build_path in GetStackTrace


Created with:
  gclient setdep -r src/third_party/catapult@2491ddef9616

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:960794
TBR=eyaich@google.com

Change-Id: Ifbd3e1cb92d0519cf6cf69af159c99304d16fcf3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627004Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#662729}

This reverts commit 84466676.

Reason for revert: Introduced flakiness to `sync_integration_tests`'s `SingleClientSessionsSyncTest.NavigationChainAlteredDestructively`.
https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vODQ0NjY2NzZlZDA2ZGM1NzViZmY1ZDEwYTU0NzY0OTNjYjI2MTY2Nww

Original change's description:
> Adding page language to sync data.
> 
> Bug: 957657
> Change-Id: I3e03e000c3c377fbf1417bf8a9a63e52d71af965
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613789
> Commit-Queue: Alexandre Frechette <frechette@chromium.org>
> Reviewed-by: anthonyvd <anthonyvd@chromium.org>
> Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#662649}

TBR=anthonyvd@chromium.org,mastiz@chromium.org,frechette@chromium.org

Change-Id: If7c671ccd8912ab53169d1647c96c17319bd8fab
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 957657
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627455Reviewed-by: Alexandre Frechette <frechette@chromium.org>
Commit-Queue: Alexandre Frechette <frechette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662728}

Previously the caller to gwp_asan::EnableFor* would pass in various
bools to indicate if sampling should be increased because this is an
interesting process/release channel. This doesn't work well in a world
where GWP-ASan hooks multiple allocators, instead have the caller simply
indicate that process sampling should be boosted or not--not the
specific conditions that led to increased process sampling.

In doing so also change the previous ProcessSamplingBoost feature
name/semantics to ProcessSamplingBoost2 since the boost is no longer
cumulative.

Bug: 956824
Change-Id: I70f646b15df5f002857c08bb104ffd881b5f2f3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626031
Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Reviewed-by: Vitaly Buka <vitalybuka@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662727}

Checking this pinpoint task: https://pinpoint-dot-chromeperf.appspot.com/job/1484ef632c0000
Before this change only one frame_time was recorded and the value is not normal (~3ms)
And by updating the story more than 700 frame_times are recorded and the value is (~26ms)

Bug: chromium:965578
Change-Id: I2646755c138f33618da32f6ac5a02e8534dd7459
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622505
Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662726}

https://swiftshader.googlesource.com/SwiftShader.git/+log/8458639991d4..6779e5e01b13


git log 8458639991d4..6779e5e01b13 --date=short --no-merges --format='%ad %ae %s'
2019-05-23 bclayton@google.com Reimplement VkFence using sw::WaitGroup and sw::Event.
2019-05-23 bclayton@google.com Add sw::WaitGroup to System/Synchronization.hpp
2019-05-23 bclayton@google.com Move sw::Event to System/Synchronization.hpp


Created with:
  gclient setdep -r src/third_party/swiftshader@6779e5e01b13

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:b/133127573,chromium:b/133135427,chromium:b/133127573,chromium:b/133127573
TBR=swiftshader-team+autoroll@google.com

Change-Id: I8ee371f886fae57bda68f79af100c52c067da568
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626675Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#662725}

It is only called once so it should be one. This removes a use of old
base::Bind() from content/.

R=liberato@chromium.org

Bug: 953861, 751838
Change-Id: I019bfdde75755866ef8760b1fc4dfd20ad532ede
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625829Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662724}

Fixes and re-enables the three tests in WebXrVrDeviceTest that were
disabled due to failing 100% of the time. The cause as a string in the
HTML file that they all load that was missing its closing quote, which
was causing issues when trying to load and run JavaScript on the page.

TBR=billorr@chromium.org

Bug: 966254
Change-Id: I89bb21bea7f539c976f9c90f63635951418d64a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626743Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662723}

gsutil uses Python "mimetypes" to map file suffixes to Content-Type, and this
uses local configuration and/or registry settings on Windows. Check that the
mapping appears correct, and fix types if a mismatch is found.

Also adds a type check for the --force-destination-cr-position
to enforce that it's numeric only (no 'r' prefix).

Change-Id: Ib4f8a6824e2e339dd309670169143345557cc832
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627215
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Auto-Submit: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662722}

This reverts commit 648e59b2.

Reason for revert: Broke chromium.android/android-jumbo-rel (crbug.com/966508)

Original change's description:
> Use ProfileKey instead of Profile in JNI_PrefetchBackgroundTask.
> 
> Now that the task may run in Reduced Mode, there is not necessarily a
> Profile anymore.
> 
> Bug: 933358
> Change-Id: I58d3d69e724ca058b676cc4ff0b2b7ef24c7792e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625392
> Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#662650}

TBR=carlosk@chromium.org,hnakashima@chromium.org

Change-Id: Ie9ceefbc06f930745fd20b3005c49a801a799a7c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 933358
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626962Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662721}

122363ccaea7 Fix compile for Linux 32b fuzz target

Bug: 966292
Change-Id: I07aba00aa266572fe54b545600e831f27cb1857a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625875Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Abhishek Arya <inferno@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662720}

This reverts commit 8209b4f7.

Reason for revert: http://crbug.com/966491

Original change's description:
> Reland "Trichrome Proguard: Fix locale pak selection."
> 
> This is a reland of beea44ce
> 
> Fixed the package name of the generated file being incorrect for Webview in
> chrome_public_apk_tmpl.gni.
> 
> Original change's description:
> > Trichrome Proguard: Fix locale pak selection.
> >
> > This CL moves the arrays of locale pak files out of BuildConfig.java
> > into a new file, LocaleConfig.java.
> >
> > This file is generated with a unique package which allows Chrome
> > and Webview to have different versions in Trichrome.
> >
> > Bug: 960025
> > Change-Id: I906d0c7e6c1540bfaa5f89e7bd9adbd9f97c8262
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610255
> > Commit-Queue: Eric Stevenson <estevenson@chromium.org>
> > Reviewed-by: David Trainor <dtrainor@chromium.org>
> > Reviewed-by: Richard Coles <torne@chromium.org>
> > Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#662209}
> 
> TBR: dtrainor@chromium.org, torne@chromium.org
> Bug: 960025
> Change-Id: Id8ffe2e02c461ccff1b23d5328972c893415f05b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625375
> Commit-Queue: Eric Stevenson <estevenson@chromium.org>
> Auto-Submit: Eric Stevenson <estevenson@chromium.org>
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#662324}

TBR=dtrainor@chromium.org,torne@chromium.org,agrieve@chromium.org,estevenson@chromium.org

Change-Id: I2518621d193276d32d06cfd96464cb1a775fbe5f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 960025
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627216Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662719}

It's possible to call RebuildLayoutTree on a locked element with a set
ChildNeedsStyleRecalc flag, because we are blocking child style recalc
but not self style recalc on that locked element.

This CL modifies the DCHECK in Element::RebuildLayoutTree to expect
that case.

Bug: 966310
Change-Id: I53338285df4d51d04ff5e92e41be5e928b0ac154
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627272Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662718}

https://skia.googlesource.com/skia.git/+log/c51d791ab992..459b295bedce


git log c51d791ab992..459b295bedce --date=short --no-merges --format='%ad %ae %s'
2019-05-23 robertphillips@google.com Expand backend allocation API to allow an initialization color (only for GL to start)
2019-05-23 ethannicholas@google.com Reland "remove unused functions in sksl.inc"


Created with:
  gclient setdep -r src/third_party/skia@459b295bedce

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=csmartdalton@google.com

Change-Id: I64af50faa16c052b9dbde6e274f8f0d0cd39df6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627002Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#662717}

Because we use StartupTraceWriterRegistries not only during startup, but
also for background tracing sessions, it's possible that one trace
writer is created during a former tracing session and later returned to
the startup tracing registry of another session. This could result in
the registry attempting to rebind an already bound writer, which causes
a nullptr crash.

Bug: 966307
Change-Id: I11a0ff43673b2fc35a5d48dcb89cd87d06e8ace1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626866
Auto-Submit: Eric Seckler <eseckler@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662716}

The DEPS entry for the samples was removed a while ago, but the
corresponding .gitignore entry was left out, so git clean is continuing
to ignore the directory.

TBR=klausw@chromium.org

Bug: 966208
Change-Id: I10e3911b2e53eab679b3295a32ed4adc58c89a55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625960Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662715}

Adds device thermal state, low power mode, and whether or not the OS was updated
between the previous and current session.

Bug: 965393
Change-Id: Ibb91efe391a10daa983aafe56e93a9d4e02fa114
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621710
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662714}

This CL shows a dropdown menu that allows the user to access the
Autofill Assistant settings and send feedback when clicking the profile
icon.

Most of this CL is a partial revert of http://crrev/c/1560295.

Bug: b/133394188
Change-Id: I1bcac3dd98e11967ea33a1fa5762ff6125c6e1fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627373Reviewed-by: Clemens Arbesser <arbesser@google.com>
Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662713}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cbc5d3765f60..943bf7fdf620


Created with:
  gclient setdep -r src-internal@943bf7fdf620

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=lowell@google.com,kmilka@google.com,yutak@google.com

Change-Id: If4834690ac692fe7e5546d4d39103f0ccb3bdaa4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627001Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#662712}

Bug: 924681
Change-Id: I4ec1dabaa39cfe875a76030ab717c3b371afcc88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621307
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662711}

Before this patch, local development with Payment Request API and
Payment Handler API on http://some-test-server without SSL was
impossible due to the strict origin checks spread out in multiple parts
of the web payment API code.

This patch unifies multiple URL validity checks into
components/payments/core/url_util.h, which is used by both Payment
Request and Payment Handler API in both native and Java code. This
utility checks for
--unsafely-treat-insecure-origin-as-secure=http://some-test-server flag
on the command line.

After this patch, a web developer is able to use http://some-test-server
without SSL, if they pass the flag on the command line.

Bug: 927780
Change-Id: I1b5521cbae0423656f028cd595a5d72e5f852c63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621874Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662710}

Add a virtual test suite for testing SameSiteByDefaultCookies,
which treats unspecified-SameSite cookies as if they were
SameSite=Lax (the current status quo is to treat them as if
they were SameSite=None).

This change creates two variants of each wpt/cookies/samesite
test, where one (with no URL query string) is only run with
SameSiteByDefaultCookies diabled, and the other (with the
URL query string ?samesite-by-default-cookies.tentative) is
only run in the virtual test suite which has
SameSiteByDefaultCookies enabled. The two versions each have
different assertion expectations to match the expected behavior
of unspecified-SameSite cookies with SameSiteByDefaultCookies
enabled/disabled.

This also fixes one of the cookie prefix tests which fails with
SameSiteByDefaultCookies enabled, so it passes whether or not
it is enabled.

Bug: 961439
Change-Id: Icfeaea952da26baa085fa163180befd8140651ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612019Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662709}

In ProcessInputActionSequence function, we now just check if id matches
with the session id, then the action is the same with the one saved in
session. However, the actions with different types may have the same
id, so we should check if both of their ids and types match.

Bug: 606367
Change-Id: I2334c7174ea855d692835cd54c44cd9c5172aef8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626676Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662708}

Bug: 958976
Change-Id: I4ed4df4fc41941dea71bb1f283fc6a6815e58bd3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622738Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662707}

WTF::CrossThreadOnceFunction dialette is understandable throughout
Blink. However, there is some excessive (and needless) uses of
ConvertToBaseOnceCallback in some cases.

This CL delays calling ConvertToBaseOnceCallback when calling
ChromeClient::NotifySwapTime. Instead, it takes changes the function
and its callees to operate over WTF::CrossThreadOnceFunction instance.

ConvertToBaseOnceCallback is now only called when crossing the
Blink -> Chromium barriers, where speaking the base::OnceCallback
dialette gets needed.

BUG=963574
R=haraken@chromium.org, hiroshige@chromium.org

Change-Id: I3717dac166b76603dd76beed902ae87299e5252a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627450
Auto-Submit: Antonio Gomes <tonikitoo@igalia.com>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662706}

Bug: 943725
Change-Id: Ia30e74c9f51e0e746aa116e02ccfd948381850f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626079Reviewed-by: Jazz Xu <jazzhsu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662705}

BUG=963574
R=haraken@chromium.org, hiroshige@chromium.org

Change-Id: I6a2567a7b1c8f967aebc3a4f0da95a75a1e9a0fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627451
Auto-Submit: Antonio Gomes <tonikitoo@igalia.com>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662704}

When SplitView is enabled, and the window is successfully dragged
and moved to another desk, we should properly reset the SplitView
drag indicators.

BUG=866622
TEST=Manually, Added a test.

Change-Id: I2577b5cc40cb3850c7f820fe8e048c285952ebca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625862
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662703}