- 02 Sep, 2020 40 commits
-
-
Marijn Kruisselbrink authored
This deletes a bunch of old code that is no longer needed. Bug: 1121673 Change-Id: Ie5fccd67aaa989d9011018a14315c5f18c8a452c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376365Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#803958}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/26be5f68f929..8584a9dfb946 2020-09-02 jleconte@google.com Make ReadValue quest process proto file. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1123318 Tbr: nuskos@google.com Change-Id: I6f9ba2492f5583600ca6f038352980c796238e01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391360Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803957}
-
Ben Joyce authored
Bug: 1096591 Change-Id: I085c379c4189b3ed71943edeffa53aa4bf1cb10a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385818Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Chan Li <chanli@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#803956}
-
Shengfa Lin authored
Add parsing webSocketUrl for connection Bug: chromedriver:3588 Change-Id: I39fc933fcf8cfc2a7ff14c7fbf65fa3f1ba832b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389053 Commit-Queue: Shengfa Lin <shengfa@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#803955}
-
yiyix authored
There is lots of magic number 4 in the image_data.cc. in fact, we are using 4 to represent that there are 4 color bit to describe each pixel, namely, red, green, blue and alpha. Add a class level comment to describe what 4 means in image_data.cc. Bug: 1122866 Change-Id: I728ea5fadba3bc7f7477dbbdd35aa180872beb84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379656Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#803954}
-
Anastasia Helfinstein authored
This change renames NodeWrapper to BasicNode for increased clarity. This is a pure refactor. AX-Relnotes: n/a. Bug: None Change-Id: I86302cbfbaf76ee33c9f2672c4a92b4c424f081c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388772Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#803953}
-
Daniel Classon authored
Adds deep links to the Languages Page, as well as the old Language subpage, Language V2 subpage, Input subpage, and Smart Input subpage. Bug: 1084154 Change-Id: Ib00b78e0d5e1a7a7d832864894c6f76f364328e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386433 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#803952}
-
W. James MacLean authored
More tests that are flaking on Win7 32. TBR=dschuff@chromium.org Bug: 1059468 Change-Id: Iae2f5d10b0e2e36ef6487d7e20d34e626111993e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391171 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#803951}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/90b027a36b4c..4ef21edffb35 2020-09-02 robertphillips@google.com Split creation of integral table out of GrRectBlurEffect 2020-09-02 johnstiles@google.com Disallow inlining ternary true/false branches. 2020-09-02 johnstiles@google.com Add unit tests for the inliner. 2020-09-02 mtklein@google.com skvx spring cleaning 2020-09-02 robertphillips@google.com Split up find_or_create_rrect_blur_mask_fp If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1108408 Tbr: michaelludwig@google.com Change-Id: I10e3e19996db88b57403f6fad6d0722e0f20dc81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390985Reviewed-by:
-
Toni Barzic authored
This reverts commit crrev.com/c/2181825 in order to fix a tooltip bug on certain multi-mon setups on Windows. This is not an automatic revert because subsequent changes required a bit of editing to undo the change. Manual testing shows that this fixes the multi-mon variable-DPI tooltip issue, but regresses bug 1053938. Bug: 1108833, 1053938 Change-Id: I39b9a013ad82c79b2e3cb263e380ad9f3e65554a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380252 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#803949}
-
Mike Dougherty authored
web::test::HttpServer has been deprecated in favor of using net::EmbeddedTestServer directly. A new::EmbeddedTestServer is already exposed in ChromeTestCase subclasses as |self.testServer|. It is important to stop using web::test::HttpServer in ChromeTestCase because many of these servers are being created and never stopped. Additionally, many tests don’t require the use of the server at all. In order to support tests which still require the use of this server, starting and stopping the server has been moved to a specialized subclass, WebHttpServerChromeTestCase. Bug: 891834, 1121576 Change-Id: I6722b1c75140dd5ac5baffb88489fa6f6af85a75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380744 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#803948}
-
Ben Mason authored
TBR=agrieve@chromium.org Bug: 1123319 Change-Id: Ib60d02dd820e2f60a9ab6b7f9f0380b4af839d02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390863 Commit-Queue: Ben Mason <benmason@chromium.org> Reviewed-by:
Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#803947}
-
ckitagawa authored
This CL expires old captures after 72 hours in order to allow for previews to be reasonably current. Bug: TODO Change-Id: I0c86c928dc73564e3721d4d8f79b8b7693931619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386223Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#803946}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b7642c19404f..3ffd1d826be3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I993c58e22e3b1e0f8732ce999494e751e651dcfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390946Reviewed-by:
-
Ben Pastene authored
This reverts commit 5159cfc6. Reason for revert: spec revert for crbug.com/1124142 There are "MojoResult(3): INVALID_ARGUMENT" errors in a CrOS ARC test after this landed. Original change's description: > Remove unused methods in std::string StringTraits > > IsNull and SetToNull aren't needed as the STL string type doesn't use > nullable_is_same_type. > > Change-Id: I0770b42e275e3026749c5409015c4b79941ea56f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386744 > Reviewed-by: Ken Rockot <rockot@google.com> > Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> > Cr-Commit-Position: refs/heads/master@{#803654} TBR=rockot@google.com,hferreiro@igalia.com Change-Id: I63114a22d365c1b4c8c8f79f4678e975d7f6c589 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391044Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#803944}
-
Weilun Shi authored
Add instructions for how to use shorthand to set variant's summary attribute. Change-Id: I5233dadd21c60f5c354e70d814f613e5f1f8c27c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388911 Auto-Submit: Weilun Shi <sweilun@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#803943}
-
Wei-Yin Chen (陳威尹) authored
Before this CL, search chip properties might be set on IPH cards in the Grid tab switcher, and triggers an assertion error. To make debugging easier, the content dump of the offending model is added to the error message. Bug: 1076546 Change-Id: I8bf110050226a8462881fba069632a5e9380672f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363773 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#803942}
-
Jeroen Dhollander authored
During shutdown this pointer might become dangling. Instead, we fetch the value through |AssistantInteractionController::Get()| whenever we need it (and check to ensure it is not nullptr). I also checked if we need to protect the |IdentityManager*|, but that should be safe as |BloomController| is created together with |Service| (*), which also contains a pointer to |IdentityManager|. (*) Here: http://shortn/_l71GCzVgX3 Bug: b/165356952 Tests: compiled Change-Id: I9e1e9ed83db9a42221e1c2f0e0f3dbe14a33e0c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372591 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#803941}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /base/security_unittest.cc This CL was uploaded by git cl split. R=jln@chromium.org Bug: 1110266 Change-Id: I2e4b59b6cfb69c0638f7effb5e5d5e8f79e49f5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371211Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Sean McAllister <smcallis@google.com> Cr-Commit-Position: refs/heads/master@{#803940}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a62890115c98..bef95c091b2d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC wjmaclean@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1073476,chromium:1124242 Tbr: wjmaclean@google.com Change-Id: I9528ef12c1410b078dccf1b73d04513b2a8b1308 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390983Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803939}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 1045266 Test: NetworkComponentsNetworkConfigInputTest* Change-Id: I2cd588e70a0f7dbb92e4550ee7f0365368abbbb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388988 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
-
Mustafa Emre Acer authored
Bug: 1107504 Change-Id: I250ba6b8f554c30c69489636854f2c441728dce6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389240Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#803937}
-
Vasiliy Telezhnikov authored
On some Mali gpus glTexSubImage fails for egl siblings with R8 format. Before we experienced that on NVidia gpu we get memory corruption after deleting source texture. This CL modifies NVidia workaround to not only keep source texture alive but also use it if we're on the same context and enables it on all Android devices to be closer to MailboxManagerSync behavior be had before threaded shared images. Bug: 1117370 Change-Id: Ia93badb27bbb23146ec348598821f66ad9b9f15d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390861Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#803936}
-
Arthur Eubanks authored
Bug: 1114873 Change-Id: I1d9fa0fc6577cd49db8d1b58f63cd72646a88531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385979 Auto-Submit: Arthur Eubanks <aeubanks@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Victor Miura <vmiura@chromium.org> Commit-Queue: Victor Miura <vmiura@chromium.org> Cr-Commit-Position: refs/heads/master@{#803935}
-
Sven Zheng authored
In general dcheck_always_on should catch more bugs. All other platform builders have set this. Change-Id: Ibfe62ffba72d4a71bdc570048a999d5e82b931a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386491 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#803934}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/000948ecdba8..b7642c19404f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I470d4c6876330baf7b2b10935e8d7fe5d8c94dc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390884Reviewed-by:
-
Jonathan Freed authored
Bug: b/166660507 Change-Id: If94ef5636812508796fd66fa3b5ad58beda439ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390945 Commit-Queue: Jonathan Freed <freedjm@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#803932}
-
Benoit Lize authored
The main partition_alloc.h header is getting unwieldy. Move locking to its own file, in preparation for more work on the lock. No behavior change. Bug: 1061437 Change-Id: Ifa6314fb87a2081a6f7d32f48c1812614debb30f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390400 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#803931}
-
Sven Zheng authored
This cl get SingleClientTypedUrlsSyncTest works on Android. Clank doesn't support multiple profiles, and all sync tests need multiple profiles. For single client test on desktop, it need at least 2 profiles: 1 The default browser and profile, started by browser test; 2 The browser and profile under test, created by AddBrowser(); 3 If verifier is enabled, create another verifier profile. For Android, we can't do that. This cl does: * Only support single client test on Android. * For 1 and 2, we only use the default browser and profile as SUT. * For 3, we don't support it for Android. android_sync_integration_tests. $ autoninja -C out/Clank android_sync_integration_tests $ out/Clank/android_sync_integration_tests TEST: Locally tested on a Next 5X device for target BUG: 1117345 Change-Id: I0167164334fc63be5cc278c145daf130ba16912e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387404Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#803930}
-
Evan Stade authored
Bug: 1110930, 1016938 Change-Id: I60d7bccc8dda4ea46708b92f7816fc17892e57af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380646 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#803929}
-
Seokho Song authored
The custom scrollbar options are available on the scrollable. But the internal popup (used html_select) was not affected by pseudo custom scrollbar tags. In this change, the pseudo styles from owner_element.GetLayoutObject() ->GetCachedPseudoElementStyle(...) and CSSValueFromComputedStyle(...) were applied to serialize CSS. And that would be appended to the SharedBuffer data which will be used for popup webview. Bug: 1076508 Change-Id: I47dcf88017e3cc1d1d03a1a2d87d49fffed4a057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364316 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#803928}
-
RJ Ascani authored
In order to support EME origin isolation requirements, the fuchsia::media::drm protocols were updated to give the client control of the storage used for CDM user data. In particular, the client can "add" data stores to the KeySystem to use for writing persistent CDM user data to. The API changes also inverted the provisioning flow and puts the platform KeySystem service to control when a provisioning request is initiated. This CL adopts the use of the new APIs in the FuchsiaCdmManager. For now, it adds a single shared drm::DataStore to each KeySystem. It also provides a server implementation for the fuchsia::media::drm::ProvisioningFetcher protocol, which is used by the KeySystem for fetching provisioning certificates. Bug: 991723 Change-Id: Ie799076be5be88abfda9519a0a9207a9667ad19d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318514 Commit-Queue: RJ Ascani <rjascani@google.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#803927}
-
Andrew Xu authored
In overview mode, only the gesture tap event will end the overview. Hotseat state does not update for the other gestures, such as scrolling (it is usually used to drag a window). It is the reason why the current code - recording the metrics for the ET_GESTURE_BEGIN event, causes unnecessary recordings. Bug: 1124345 Change-Id: If9931368a98776338beb893b2f5c326603849437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389322Reviewed-by:
Xiyuan Slow <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#803926}
-
Glen Robertson authored
This allows us to stop depending on the impl in browser_prefs.cc. Fixes `gn check` errors. Split out from crrev.com/c/2383400 Bug: 898837 Change-Id: I777200b6a49710e1496fb3189f8bbed80fb3cbb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386437 Auto-Submit: Glen Robertson <glenrob@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#803925}
-
Patrick Noland authored
No clear culprit, since there are three related CLs in the regression range. Disabling on emulator instead to get the builder green. Bug: 1124336 Change-Id: I76df36557dd3f851dbe4280acb025d577f7d5254 TBR: wychen@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390950 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#803924}
-
K. Moon authored
Calls blink::Platform::InitializeBlink() from pdf_unittests's main(). This allows the use of primitive Blink types like blink::WebString in tests. (Specifically, this depends on initializing WTF.) Bug: 1099022 Change-Id: I9ca8b88645870c0d834225458f6d2e34958d3948 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390864Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#803923}
-
Avery Musbach authored
Bug: 1087182 Change-Id: I35bc9c7b9f5318e85e1ceb870a1a37884b935002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378531Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#803922}
-
Ramin Halavati authored
Profile API is being updated (issue 1033903) and the usage of GetOffTheRecordProfile and HasOffTheRecordProfile without argument is getting deprecated. Use cases of this call that ONLY refer to incognito or guest mode can use [Get/Has]PrimaryOTRProfile() instead. This CL does not change any behavior and is just code clean up. Bug: 1060940 Change-Id: Ie155364573e060093d3fb67bd2a163467346fe49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388283Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#803921}
-
Ramin Halavati authored
Profile API is being updated (issue 1033903) and the usage of GetOffTheRecordProfile and HasOffTheRecordProfile without argument is getting deprecated. Use cases of this call that ONLY refer to incognito or guest mode can use [Get/Has]PrimaryOTRProfile() instead. Usage of these API functions are updated in AppController. Bug: 1060940 Change-Id: Icd809c023b069c83c426c362efe1303fbc8a40c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388463Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c9886cc22e82..132b4bab67e1 2020-09-02 tvanderlippe@chromium.org Migrate lighthouse to devtools_entrypoint 2020-09-02 jacktfranklin@chromium.org Move legacy css copy_to_gen to each subfolder 2020-09-02 tvanderlippe@chromium.org Migrate media to devtools_entrypoint 2020-09-02 tvanderlippe@chromium.org Migrate browser_debugger to devtools_entrypoint 2020-09-02 szuend@chromium.org [ts] Type-check sdk/RemoteObject.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1101738 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I47d757c1269344323168697893e222f40bf19ba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390984Reviewed-by:
-
