- 10 Sep, 2018 40 commits
-
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/77a15654a753..03c80a36415d git log 77a15654a753..03c80a36415d --date=short --no-merges --format='%ad %ae %s' 2018-09-10 benjhayden@chromium.org Add scalar-span for v2spa Created with: gclient setdep -r src/third_party/catapult@03c80a36415d The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I10cddb8fe7c7773d73152b86fa15cc760c6f09e5 Reviewed-on: https://chromium-review.googlesource.com/1216869Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590077}
-
Victor Costan authored
This CL only handles the difficult cases in //remoting. The easy cases were tackled by mechanical CLs, such as https://crrev.com/c/1188959 for //net. Parallel CLs will tackle other difficult cases. net::IOBuffer is (thread-safe) ref-counted. Asides from improving the ability to reason about instance ownership locally, creating instances via base::MakeRefCounted makes it possible to use 1-based ref-counting in the future (see base/memory/ref_counted.h). This CL replaces raw IOBuffer pointers with scoped_refptr<net::IOBuffer> in some APIs. Local inspection of the impacted implementations should reveal that no extra reference churn was introduced. Change-Id: I59940c49e6635540a4a42840919ff114b3a1941f Reviewed-on: https://chromium-review.googlesource.com/1215463Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#590076}
-
Victor Costan authored
This CL only handles a difficult case in //jingle. The easy cases were tackled by mechanical CLs, such as https://crrev.com/c/1188959 for //net. Parallel CLs will tackle other difficult cases. ability to reason about instance ownership locally, creating instances via base::MakeRefCounted makes it possible to use 1-based ref-counting in the future (see base/memory/ref_counted.h). net: :IOBuffer is (thread-safe) ref-counted. Asides from improving the Change-Id: I06317e9410389b226fbe7818c8d7138d5bb79050 Reviewed-on: https://chromium-review.googlesource.com/1215464Reviewed-by:
Nicolas Zea <zea@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#590075}
-
Pedro Amaral authored
Bug: 876051 Change-Id: I7826a815732a64d4b728be2f6b8565c5259f974c Reviewed-on: https://chromium-review.googlesource.com/1217585 Commit-Queue: Pedro Amaral <amaralp@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#590074}
-
Ojan Vafai authored
This reverts commit 0962c66c. Reason for revert: This test also fails on some mac bots, e.g. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/15266 Original change's description: > Implement crash report prototype (behind flag) > > This patch implements crash reporting, as detailed in the > reporting spec: https://w3c.github.io/reporting/#crash-report > > Change-Id: I209880150193910a0947608e6b08a6eeea29206c > Reviewed-on: https://chromium-review.googlesource.com/1174965 > Commit-Queue: Paul Meyer <paulmeyer@chromium.org> > Reviewed-by: Nick Carter <nick@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589941} TBR=avi@chromium.org,nick@chromium.org,paulmeyer@chromium.org Change-Id: I52ea9472a94c7c5eaa13e29dcd3569e0db3c8280 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1217513Reviewed-by:
Ojan Vafai <ojan@chromium.org> Commit-Queue: Ojan Vafai <ojan@chromium.org> Cr-Commit-Position: refs/heads/master@{#590073}
-
Jani Hautakangas authored
Refactor base/ime components and dependencies for ozone plaform integration to avoid cyclic dependencies. - Groups ui/base/ime common types into their own GN component (ime_types) to break a dependency cycle that ozone ime context integration would cause on ChromeOS. - Groups some of ui/base/ime/linux interfaces into their own GN component (ime_linux) to break a dependency cycle that ozone ime context integration would cause on ChromeOS. - Move chromeos source files under is_chromeos flag to avoid depending them when chromeos is not used, but ime is needed (kudos to msisov@igalia.com). Bug: 791920 Change-Id: I0b1668564dde22c6e2b05ee1323ebbe4a1343475 Reviewed-on: https://chromium-review.googlesource.com/1193871 Commit-Queue: Jani Hautakangas <jani.hautakangas@lge.com> Reviewed-by:
Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#590072}
-
khmel@chromium.org authored
This reverts commit 37385434. (Test flakiness fixed) When app is pinned, icon image is loaded via controller using loader owner by chrome launcher controller. Once new ARC app window appears in the system, it's icon is loaded asynchronously. In this flow, default app icon is applied first and then, once real image is loaded final icon is set. Each update of ARC window icon is reflected on shelf. That means default app icon appear on the shelf for a moment and in most cases this is very noticeable. This CL prevents setting default app in favor of final app icon and default icon is set only as a fallback when final icon could not be loaded. TEST=Manual BUG=882048 BUG=882043 Bug: b:114246197 TBR=xiyuan@chromium.org,jdonnelly@chromium.org,khmel@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ic2015afe42b4b3aacd05a307350e643a6967d3e8 Reviewed-on: https://chromium-review.googlesource.com/1216721 Commit-Queue: Yury Khmel <khmel@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#590071}
-
Varun Khaneja authored
Bug: 754341 Change-Id: Ib8dcfcba25ea2f563365fca13f79873499639c52 Reviewed-on: https://chromium-review.googlesource.com/1211979Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#590070}
-
Bailey Berro authored
Currently, we wait until the first batch of shares is returned from host discovery before attempting to Mount a share so that name resolution can be performed. This change switches to using the GatherSharesInNetwork method that takes a HostDiscoveryResponse callback so that the delay is shortened. Bug: chromium:757625 Change-Id: I22cf5fd48bdcc633fa4d7f2f08b1e6f7e10af764 Reviewed-on: https://chromium-review.googlesource.com/1211947 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#590069}
-
Weilun Shi authored
Add button should be hidden when there are max number of most visited tiles. Bug: 881091 Change-Id: I40d33e533691885204f1fd813ce077fb060678d9 Reviewed-on: https://chromium-review.googlesource.com/1214180 Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#590068}
-
Aiden Benner authored
e.g. public int x = 0; public boolean x = false; - Adds errorprone rule that will detect when fields are initialized to default values (results in larger class sizes and can't be optimized away see https://issuetracker.google.com/issues/37124982) - Refactor current redundant initializations - Fix cases where classes were being generated with redundant initializations TBR=agrieve Bug: 878853 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester Change-Id: Ia76a02ea73a55f2fa66b4ef6461ac985eba574bb Reviewed-on: https://chromium-review.googlesource.com/1209547 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:agrieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#590067}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d91f0adca280..11bc3991530d git log d91f0adca280..11bc3991530d --date=short --no-merges --format='%ad %ae %s' 2018-09-10 nodir@google.com [bot_update] add ignore_input_commit parameter Created with: gclient setdep -r src/third_party/depot_tools@11bc3991530d The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:882094 TBR=agable@chromium.org Change-Id: I189dbf46abcf77ef9ad2fb1362d82c03777f67a2 Reviewed-on: https://chromium-review.googlesource.com/1216868Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590066}
-
Luna Lu authored
Design doc: https://docs.google.com/document/d/1yh_-ayeaFV0EjuR51U641zbrPAB0Baqj6UrC9bT9iqQ/edit#heading=h.y7amr11fn0tb This CL implements "intrinsicSize" attribute to SVGImageElement. This attribute has been added to HTMLImageElement and HTMLVideoElement. The value of "intrinsicSize" overrides the intrinsic size: 1. When no width and height is specified, the value of "intrinsicSize" specifies the <svg:image> element's layout size. 2. When one dimension is specified, the value of "intrinsicSize" is used as an aspect ratio to determine the other dimension. 3. If both width and height are specified, "intrinsicSize" has no effect. Bug: 874629 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I9023d6cf7a818c983155efc12505f1d6fd18de43 Reviewed-on: https://chromium-review.googlesource.com/1210544Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#590065}
-
Eugene But authored
Experiment results were collected in M69. Bug: 853774 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I44d71ec5a620b8ac5b9673161dbf9172cfc67fdf Reviewed-on: https://chromium-review.googlesource.com/1213268Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#590064}
-
Alex Moshchuk authored
Previously isolated origins were stored in a set. This resulted in large overheads when URLs needed to be checked against isolated origins, since the set had to be walked through linearly, running a fairly slow comparison function (IsolatedOriginUtil::DoesOriginMatchIsolatedOrigin()) on each isolated origin, and this lookup turned out to be fairly common. This CL reorganizes the underlying data structure into a map keyed by site URLs. For example, if we add {https://foo.com, https://bar.foo.com, https://www.bar.com} as isolated origins, the map will look like this: https://foo.com -> { https://foo.com, https://bar.foo.com } https://bar.com -> { https://www.bar.com } When checking a URL against isolated origins, we now can just look up the map using the URL's site and then look for the most specific isolated origins as before. The site can be found in O(log n) time, and the corresponding list of origins to search using DoesOriginMatchIsolatedOrigin() changes from O(n) to O(originsPerSite), which is expected to be ~1. Bug: 877653 Change-Id: I41667f94cea7f1f8e5b53fa23443d83cfbb3c0ed Reviewed-on: https://chromium-review.googlesource.com/1208942 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#590063}
-
Dale Curtis authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/bfe62e18d24f..bbe6b81a6c31 $ git log bfe62e18d..bbe6b81a6 --date=short --no-merges --format='%ad %ae %s' 2018-09-10 dalecurtis Update patches file for new ffmpeg fixes. 2018-09-07 dalecurtis avformat/utils: Don't calculate duration using AV_NOPTS_VALUE for start_time. 2018-08-30 dalecurtis avformat/mov: Error on too large stsd entry counts. 2018-08-22 liberato Fetch upstream and check for upstream commit. Created with: roll-dep src/third_party/ffmpeg BUG=879852, 826648 TBR=tguilbert Change-Id: Ibdec4e7e2ffd3d7d61bdefa71f09814d699bba5b Reviewed-on: https://chromium-review.googlesource.com/1217040Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#590062}
-
Wez authored
Quitting the RunLoop with QuitCurrent*Deprecated() triggers the DCHECK against mixing the deprecated quit APIs with use of QuitClosure. Use the GpuServiceImpl::ExitProcess() helper to quit the process gracefully, instead. Also removes the |is_exiting_| flag in favour of checking whether |exit_callback_| is set, and adds a DCHECK for a non-null |exit_callback| being passed at construction. Bug: 882068 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Id8a87e4648fbac3283f41ce2f80cf03a153227ab Reviewed-on: https://chromium-review.googlesource.com/1214750 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#590061}
-
Steve Anton authored
Adds unit tests for the RTCIceTransport Blink bindings that use a mock IceTransportAdapter. These exercise the RTCIceTransport bindings along with the IceTransportProxy and IceTransportHost. Bug: 864871 Change-Id: I2b857979bf201f67f9db631b6f35a3e8bebef547 Reviewed-on: https://chromium-review.googlesource.com/1206173 Commit-Queue: Steve Anton <steveanton@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#590060}
-
Xida Chen authored
In chrome VR or virtual keyboard case, we can get GestureScrollBegin without GestureTapDown, and that |scrolling_touch_action_| may have no value. In this case, we set it to Auto to prevent crash. This was done in a previous CL: https://chromium-review.googlesource.com/c/chromium/src/+/1195649 However, there was a small mistake in the previous CL. That is, the |scrolling_touch_action_| could have been set when the browser receives the ACK for the touch start from the main thread. In this case, we should not set it to Auto. Bug: 880701 Change-Id: I250bb7a09840f16665cfcf5826236cad99b533c5 Reviewed-on: https://chromium-review.googlesource.com/1213502Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#590059}
-
Tommy Steimel authored
This CL adds an isConnected check in the overlay play button's click positioning check to prevent a crash when trying to access the layout data after it's been removed. Bug: 870490, 881772 Change-Id: Ic005ae9d3acc2945ed67645bfe98a237c89e38f0 Reviewed-on: https://chromium-review.googlesource.com/1217065Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#590058}
-
Yuwei Huang authored
This CL fixes a bug that crashes the latest M70 Android client when it lauches. URLRequestContextGetter's constructor creates a ProxyChangeListener, which requires an Android looper on the current thread. The C++ network thread doesn't create any looper, so it must be created on the UI thread which has alooper. Note that this class is used (and required to be used) on the network thread afterwards. Bug: 882072 Change-Id: I0cf610d3dccf087f040b49995d3022a1ba4de0e9 Reviewed-on: https://chromium-review.googlesource.com/1217363Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#590057}
-
Eugene But authored
Removed references to unsupported iOS 9. Bug: None Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I1cea95523f85ee82b614a959eab5fc5c7bc01ea0 Reviewed-on: https://chromium-review.googlesource.com/1217353Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#590056}
-
Mike West authored
Bug: 882107 Change-Id: I380e01b2663a926c9e5eb7d4ac9f3e433dc869e9 Reviewed-on: https://chromium-review.googlesource.com/1213082Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#590055}
-
W. James MacLean authored
This issue may be fixed by recent changes, but even if it isn't, it would be nice to have some fresh data on it. Bug: 823578 Change-Id: I2568fad71686c658fbe9e26ffe1dfdcb09ff3891 Reviewed-on: https://chromium-review.googlesource.com/1217402Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#590054}
-
Jeffrey Cohen authored
Instead of COMPANY_NAME returning an empty string when disabled, this CL enable/disables the filling of COMPANY_NAME within the fill logic. Bug: 864612 Change-Id: I9437e45a056d110d4e3c36ac92f8ac01338b8344 Reviewed-on: https://chromium-review.googlesource.com/1205106 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#590053}
-
Tien-Ren Chen authored
The PaintChunkToCcLayer algorithm was originally designed for SPv2 compositor, and it was expected the layerization algorithm should never assign a chunk to a excessively clipped layer, thus the DCHECK. Later this algorithm was adopted in SPv175 to be used with the SPv1 compositor. There is a known bug that in certain corner case we can fail to escape clip, and the bug is difficult to fix in the legacy architecture. The DCHECK is expected to be a "soft" one that we have a fail-safe path to recover in a sane way. This CL converts the DCHECK to a DLOG in SPv1 mode, and it should still trap in SPv2 mode. In addition, it reverts a workaround to a nullptr bug in the fail-safe path, and add a test for the fail-safe. BUG=881788,853357 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I4606acf4885f3344bb45a901bb2e8e46dbcda49a Reviewed-on: https://chromium-review.googlesource.com/1213952Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#590052}
-
Lei Zhang authored
Change-Id: Iff32093fe4339338c3e5bb025049034f90dd6e53 Reviewed-on: https://chromium-review.googlesource.com/1215043Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#590051}
-
W. James MacLean authored
A number of changes have landed recently that may eliminate the flakieness seen in this test. This CL re-enables the test, but feel free to revert this if the flakes continue. Bug: 870744 Change-Id: I859f7170dbcdd334f3e872b117d48412721b7fa0 Reviewed-on: https://chromium-review.googlesource.com/1217089Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#590050}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/a5078b7c17f7..8550a2d1e037 git log a5078b7c17f7..8550a2d1e037 --date=short --no-merges --format='%ad %ae %s' 2018-09-10 hnakashima@chromium.org Remove check for clean branch from safetynet_job.py. Created with: gclient setdep -r src/third_party/pdfium@8550a2d1e037 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Icacbd3bd153eb29230ac46b94565a1bd59abbfaa Reviewed-on: https://chromium-review.googlesource.com/1216865Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590049}
-
Antonio Gomes authored
URLFetcher will stop working with advent of Network Service, and SimpleURLLoader is the replacement API for most clients. This CL migrates PrefetchRequestFetcher et al and the respective unittests away from URLFetcher. Bug: 773295,879776 Change-Id: Ibcfc2a7d72b6efe1b372233ade95b58d95fbf62b Reviewed-on: https://chromium-review.googlesource.com/1215367Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#590048}
-
W. James MacLean authored
A number of changes have landed recently that may eliminate the flakieness seen in this test. This CL re-enables the test, but feel free to revert this if the flakes continue. Bug: 871062 Change-Id: Iad353f9aecbf2eb59c4831ef70658f08c13a47a9 Reviewed-on: https://chromium-review.googlesource.com/1217087Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#590047}
-
Bruce Dawson authored
This reverts commit 5b59b7dd. Reason for revert: This was a speculative fix which did not help, and the real cause of the hang reports was found. Original change's description: > Avoid the deadlock prone WT_EXECUTEINWAITTHREAD > > WT_EXECUTEINWAITTHREAD is theoretically slightly more efficient than > WT_EXECUTEDEFAULT when running callbacks registered by > RegisterWaitForSingleObject but it comes with an ill-defined risk of > deadlocks. We seem to be hitting those, so this change switches to > the safer flag. > > If no improvement is seen then this change will be reverted. > > Bug: 877012 > Change-Id: I773cad8cd0621fb487770306bee4cc9812d4f243 > Reviewed-on: https://chromium-review.googlesource.com/1200484 > Commit-Queue: Bruce Dawson <brucedawson@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589608} TBR=brucedawson@chromium.org,grt@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 877012 Change-Id: I78fe13ebfdd7380a1ec79c2e048a59802c3e7964 Reviewed-on: https://chromium-review.googlesource.com/1217150Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#590046}
-
Li Lin authored
Bug: b:113854907 Change-Id: I0c2348325f86197b7a930210226798bb3f5df1ed Reviewed-on: https://chromium-review.googlesource.com/1212099Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/master@{#590045}
-
yoshiki iguchi authored
This CL has DummyView handle a back key event and close the Chrome OS message center if it opens. This fix is for ag/112017890. Note that DummyView handles key events only when no other ARC window is focused. ARC-side: ag/4779503 Chromium-side: crrev.com/1175709 Bug: b/112017890 Test: Ran atest Change-Id: If0603bd68f2ad4f482521e7cf3e698edb934183f Reviewed-on: https://chromium-review.googlesource.com/1175709Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#590044}
-
Dominic Mazzoni authored
The previous behavior was deliberate but dates back to this 2006 WebKit bug without any clear rationale: https://bugs.webkit.org/show_bug.cgi?id=8705 In the absence of a strong argument in favor of this behavior, we should do what's better for users and show the focus ring. Bug: 870062 Change-Id: I6c1c427d05270a69d4ded74f68704d78b78c3095 Reviewed-on: https://chromium-review.googlesource.com/1213311 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#590043}
-
Kenneth Russell authored
GPU process bringup is flaky while the tests are crashing the GPU process. Similar suppressions may ultimately be needed for other GPU process crash tests on Android. Bug: 882103 No-Try: True Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I4326e81a9f8e64066b1ac271fc87e9afa97a8681 Tbr: enne@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1217403Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#590042}
-
Reid Kleckner authored
This death test is looking for output from a CHECK failure, and CHECk failures are not printed in official+release builds. This test has been failing on our official clang ToT bot since it was added: https://ci.chromium.org/buildbot/chromium.clang/ToTWin/2132 R=dougarnett@chromium.org,jam@chromium.org Bug: 864640 Change-Id: I7527d65d3ffcfba9a68427aa60d2e6152be838ce Reviewed-on: https://chromium-review.googlesource.com/1217066Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#590041}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a2bc1ca21bbc..52fd68762ae4 git log a2bc1ca21bbc..52fd68762ae4 --date=short --no-merges --format='%ad %ae %s' 2018-09-10 reed@google.com Reland "remove legacy google3 flag" Created with: gclient setdep -r src/third_party/skia@52fd68762ae4 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: I34962270c6f1ef27a391ba528ca1e44d758c3bed Reviewed-on: https://chromium-review.googlesource.com/1216816Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590040}
-
Egor Pasko authored
SHERIFFS: This could make some benchmarks run faster on continuous bots because the devices gets cooled down. The benchmark touched by this change is _not_ monitored, but the benchmarks running _after_ this one may see a change. This is expected. Traces from experiment [1] showed that waiting for battery to cool down to 32C happens every 7 runs adds adds a couple of minutes of waiting and does not remove the upwards trend on metrics entirely. During those cool runs the noise was significantly lower than on bots, using the same hardware (N5X). Trying if this value makes bots bappier. Cooling down seems unnecessary on N5 and on Go devices, but it would be good to keep an eye on them anyway and see later how to properly make this device-dependent in the future, if there is need. [1] NOT_FOR_COMMIT: Sleep before/after pagecache flush https://chromium-review.googlesource.com/c/chromium/src/+/1210643 Bug: 881384 Change-Id: I304437b4231503d7a5d461ee00190bdb8ee5f5cd Reviewed-on: https://chromium-review.googlesource.com/1217035 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#590039}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/480edb8c1d7d..8e9d23405644 git log 480edb8c1d7d..8e9d23405644 --date=short --no-merges --format='%ad %ae %s' 2018-09-10 jmadill@chromium.org Vulkan: Fix FragCoord scaling when a viewport is applied. Created with: gclient setdep -r src/third_party/angle@8e9d23405644 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Iad2c871b824c18e59c1cc34321fea0ba80dbf392 Reviewed-on: https://chromium-review.googlesource.com/1216867Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590038}
-