- 12 Dec, 2017 24 commits
-
-
Scott Chen authored
Bug: 781335 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id8bd8fca8d4adea95561d454783c45d40872edbb Reviewed-on: https://chromium-review.googlesource.com/816059 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#523284}
-
Kevin Bailey authored
This makes a tiny fix to the previous change, which was failing on Win 7 debug. There is a line in ScoredHistoryMatch::ScoredHistoryMatch(...) which dereferences a string's rbegin() iterator. (Searching for 'rbegin' will find the only occurrence.) Thus the code expects a non-empty string. I'm guessing it passed the other platforms because they store a '\0' there, while a debug build might be more diligent. This change simply changes history_quick_provider_unittest.cc to pass a non-empty string to that parameter. Revert: 817298 Original CL: 794432 When the option hide-suggestion-url-scheme is enabled, Omnibox suggestions exclude the scheme in some cases where they would be inconsistent with other suggestions. This change preserves schemes when the user specified one. This change asserts 'preserve_scheme' to GetFormatTypes() now if alternatively the input, interpretted as a URL, has a scheme. This changes the treatment of http (and https when certain flags are set.) Previously it was only asserted if there was a match in the scheme. Added many tests as well. Bug: 761505 Change-Id: I417448ffbb370d86c794309520083cff10ea5957 Reviewed-on: https://chromium-review.googlesource.com/820354 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#523283}
-
Pawel Osciak authored
To reflect reviewer specialization/code familiarity per OWNERS file/reviewer choice guidelines. BUG=None TEST=None Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I0a3bb4cee242c9a3e59bb451ea697889d1679856 Reviewed-on: https://chromium-review.googlesource.com/821150Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#523282}
-
Fredrik Hubinette authored
Bug: 788984 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I75a199398befeca552449cedd8f66fa175c3043d Reviewed-on: https://chromium-review.googlesource.com/810093 Commit-Queue: Fredrik Hubinette <hubbe@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#523281}
-
Peter Collingbourne authored
With this we should hopefully get more useful stack traces on ToT bots. Bug: Change-Id: I6d9f36564d1f2edee3032b55a4f34429d302612d Reviewed-on: https://chromium-review.googlesource.com/820620Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#523280}
-
Nate Chapin authored
Bug: 793028 Change-Id: Icff8fce73e745969e4022329a7cb0374ce43698c Reviewed-on: https://chromium-review.googlesource.com/818197Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#523279}
-
Morten Stenshorne authored
The fragmentation spec says that fragmentainer heights should never be shorter than 1px [1], so that we don't get stuck without content progress. This means that if the multicol container's content box height is 0, fragmentainers inside it will still be 1px. The ref depended on incorrect behavior in Presto, where floats would never be fragmented. [1] https://www.w3.org/TR/css-break-3/#breaking-rules Bug: 788337 Change-Id: I96338070458a9df518d1b4bb70eee399bfde48ab Reviewed-on: https://chromium-review.googlesource.com/821010 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#523278}
-
Andrey Lushnikov authored
This patch teaches global search to search in sourcemap sources as well. BUG=763701 Change-Id: I3062e21cf0a589d02f6926b8ec3785eca15b879a Reviewed-on: https://chromium-review.googlesource.com/820653Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#523277}
-
Erik Luo authored
This prevents the 'show more' chevron from overlapping with the split widget's 'hide debugger' button. Screenshot: https://imgur.com/a/5ByuK Bug: 767330 Change-Id: I77212e20d2e85605c168e4e5845dccd2efa1399a Reviewed-on: https://chromium-review.googlesource.com/815903Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#523276}
-
erikchen authored
kAllRenderers will profile all renderers. This allows a user to easily debug renderer-based memory issues. Adding this mode also allows the removal of some testing code that had the same effect. kManual allows the user to manually specify the processes to profile via chrome://memory-internals. If the user starts profiling a process while in another mode, the mode will change to kManual for simplicity. This CL renames the function ShouldProfileProcessType to ShouldProfileNonRendererProcessType. This CL fixes a bug in BackgroundProfilingTrigger whereby renderers would never be profiled, since ShouldProfileProcessType() was incorrectly being used. This logic is no longer necessary since BackgroundProfilingTrigger queries for all profiled processes by pid. Bug: Change-Id: Ibeca2346f1629292ca17678081cf0aec68a85ab3 Reviewed-on: https://chromium-review.googlesource.com/818181 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#523275}
-
Eric Roman authored
The default is VS 2017 as of 7295a84e. Bug: 683729 Change-Id: I795011162e0a9f6c39af799b50d32587b0baed76 Reviewed-on: https://chromium-review.googlesource.com/821211Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#523274}
-
Lei Zhang authored
Change-Id: I69bbbfa9d4c317a522a39e097b478d0f80e61fad Reviewed-on: https://chromium-review.googlesource.com/818606Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Chris Blume <cblume@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#523273}
-
Renjie Liu authored
Move the language code locator util from components/language => components/language/content/browser as it will only used by the GeoLanguageProvider. Bug: 76915 Change-Id: I45695bf2c1149f89e7f6d13a41a5f80ea0084ba8 Reviewed-on: https://chromium-review.googlesource.com/818596 Commit-Queue: Renjie Liu <renjieliu@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#523272}
-
Theresa Wellington authored
Allow zero-query omnibox suggestions to show on the Chrome Home NTP. This allows the "Link you copied" feature to work in Chrome Home. BUG=762038 Change-Id: I4c6cc0c1305dea95e7dd3c5c6ba5cc36abd48a36 Reviewed-on: https://chromium-review.googlesource.com/820096Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#523271}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3477c932..6c68f62d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I667b3a3114df6241df69aa63df38164750900277 Reviewed-on: https://chromium-review.googlesource.com/820198Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#523270}
-
Andrey Lushnikov authored
This patch changes StylesSidebarPane autocomplete for property names in the following maner: - for regular nodes, only regular CSS properties are autocompleted - for SVG nodes, both CSS and SVG properties are autocompleted BUG=721998 R=dgozman Change-Id: Ie06307d62a1b9685f0bf998b5b2714c47e3d5ee8 Reviewed-on: https://chromium-review.googlesource.com/820647Reviewed-by:
-
Jaebaek Seo authored
As shown in crbug.com/786852/#c9, the current select popup in Android WebView is not correctly located. The main reason is that the left margin for the anchor rectangle of the popup is added by x value of scroll manager. This CL adds y value of scroll manager to the left margin instead. Bug: 786852 Change-Id: I8ebf983de64eea3c89d8fc7d2063962a7f1c7bb1 Reviewed-on: https://chromium-review.googlesource.com/818679Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> Cr-Commit-Position: refs/heads/master@{#523268}
-
Xiyuan Xia authored
- No "Servers" and "Authorities" tab; - No "Import" as in previous non-MD impl; Bug: 719907 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie6fc8e7b257937b4e0607e426d9b0550dc2ddd4b Reviewed-on: https://chromium-review.googlesource.com/820638Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#523267}
-
Mitsuru Oshima authored
Modified ClientControlledStateSurface so that - State change are first sent to client (Android) except for PIN/TRUSTED_PIN - PIN/TRUSTED_PIN are still handled on server side per security requirement. It may leave the the state inconsistent and the same thing can happen in the old implmenetation. - the bounds change request from chrome side is ignored for now and only the geometry change from client is applied. * Emulate the state change by client in ShellSurface unit tests. Animation isn't enabled yet in this CL. It'll be addressed in a separate CL. BUG=762816 TEST=manually tested on device (maximize/fullscreen/minimix/pin/unpin etc) Existing test should pass with new implementation (with test impl). Change-Id: Idc8001876f4b1c50d375b1090ce63516f3998ab0 Reviewed-on: https://chromium-review.googlesource.com/809488 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#523266}
-
Devlin Cronin authored
An (illegal) include was commented out. Remove it. Bug: None Change-Id: Ief2da1cb5a3f381aeff1589f055fd12158bda1fc Reviewed-on: https://chromium-review.googlesource.com/821110Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#523265}
-
John Abd-El-Malek authored
When there's an ongoing navigation, if the app loada a JavaScript URL we create a temporary NavigationRequest in NavigatorImpl::RequestNavigation. However the call to RenderFrameHostManager::GetFrameHostForNavigation was resetting the speculative RFH of the original NavigationRequest since the site instance of a JavaScript load is always the same as the existing frame. Bug: 793432 Change-Id: I5a25eea9a8733cd5cebe71f700b30ebb4c0b1710 Reviewed-on: https://chromium-review.googlesource.com/820453 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#523264}
-
Yoichi Osato authored
This patch is a part of crrev.com/c/813336 ([LayoutNG] Paint text selection on load.) LayoutSelection.cpp: - This converts legacy offset to NG offset if LayoutObject has enclosing NGBlockFlowlayout before paint phase. - LayoutSelectionStartEndForNG() returns start/end offsets that the NGPhysicalTextFragment is selected. LayoutSelectionTest.cpp: - This patch adds NGLayoutSelectionTest to confirm/demonstrate how we use the function. Also you can refer my following painting patch(crrev.com/c/818884). Bug: 708452 Change-Id: Ic9fc6822f83e0821c5f2f4917d4ac316543702e2 Reviewed-on: https://chromium-review.googlesource.com/818864Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#523263}
-
Ilya Sherman authored
R=asvitkine@chromium.org Bug: 727984 Change-Id: Ic1993cce55beed9e00512f6fe4b001fc5ec4c591 Reviewed-on: https://chromium-review.googlesource.com/818746 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#523262}
-
Hector Carmona authored
Bug: 789897 Change-Id: Id16a994fda31d9a294444cf56ceab646548cb29d Reviewed-on: https://chromium-review.googlesource.com/803623 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
-
- 11 Dec, 2017 16 commits
-
-
Andrey Kosyakov authored
Bug: 726381 Change-Id: I76fb27d4eb50730ff85fdf39895859db4e343bc8 Reviewed-on: https://chromium-review.googlesource.com/811526 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#523260}
-
Allen Vicencio authored
Add ReadDirectory and GetMetadataEntry methods for SmbProviderClient. This allows read-only navigation of the share, excluding reading files. Bug:chromium:757625 CQ-DEPEND=CL:794892 Change-Id: I55d4baa6dec95392774cdea3c07c13989b31e782 Reviewed-on: https://chromium-review.googlesource.com/749897 Commit-Queue: Allen Vicencio <allenvic@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#523259}
-
Joy Ming authored
This CL is part of the greater effort to build out functionality to allow users to change their default download storage location. This is the first step, surfacing the option to change download location in the preferences pane. This is not fully functional (the directory selector is not yet implemented) and is hidden behind a flag. Bug: 792775 Change-Id: Ic57aa2e4f61c83861e5711c2fe0b48737217904e Reviewed-on: https://chromium-review.googlesource.com/818205 Commit-Queue: Joy Ming <jming@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#523258}
-
Lei Zhang authored
OS_CHROMEOS already implies OS_LINUX. Change-Id: I194767e151ec59134682db0a276e60f2ef9469ee Reviewed-on: https://chromium-review.googlesource.com/820932Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#523257}
-
Steven Holte authored
Coverage on iOS left for a follow up. Bug: 793470 Change-Id: I4844e667c421f7df3c3412362d50ad74078e8223 Reviewed-on: https://chromium-review.googlesource.com/818202Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
-
Tom Sepez authored
Network service requires this in some situtations. Additionally, alphabetize methods and consolidate some logic into helper methods along the way. As part of the consolidation, need to mask open() flags before checking "if allowed" and test for "EFAULT" earlier in some situations. Require "Create" permission for rename() for consistency. Use initializer-list for vectors where possible. Clean up hooks and tests to use bitset creation helper function. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ide22e759692baf4350b643400619885f1676db15 Reviewed-on: https://chromium-review.googlesource.com/812452 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#523255}
-
Petr Hosek authored
We will still produce an error if --fail-on-unused-args is used. Bug: 684096 Change-Id: I4a0640ad83072750d555c8de9e6391f76942ae38 Reviewed-on: https://chromium-review.googlesource.com/792606 Commit-Queue: Petr Hosek <phosek@chromium.org> Reviewed-by:
-
spqchan authored
Highlight the URLs on the sidebar according to the Security Panel MD specs. Screenshot: https://screenshot.googleplex.com/baLGTsSAe8B Updated the sidebar tests so it will test for the new changes. Bug: 523589, 617311 Change-Id: I35c14aded5530cfad2b58f18e9270250fa2e7ed1 Reviewed-on: https://chromium-review.googlesource.com/795171 Commit-Queue: Sarah Chan <spqchan@chromium.org> Reviewed-by:
Eric Lawrence <elawrence@chromium.org> Cr-Commit-Position: refs/heads/master@{#523253}
-
Yutaka Hirano authored
This CL consists of bunch of refactoring efforts: - Add explanatory comments. - Rename scheduler() to Scheduler() - Rename WasRan() to WasRun() - Add Release() and ReleaseAndSchedule() to test fixtures as the existing usage in tests are too verbose. - InvalidInstance() now returns a value instead of a mutable reference. Bug: 785770 Change-Id: I80c963a3509cce74aaba28c2b5f62eca47ebe84d Reviewed-on: https://chromium-review.googlesource.com/816276Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#523252}
-
Ryan Landay authored
The select_insert_text param in this method is only ever called with false after https://chromium-review.googlesource.com/c/chromium/src/+/801979. Bug: 784039 Change-Id: I3c8d0176bfb6600605d42b83676341a61fd83aac Reviewed-on: https://chromium-review.googlesource.com/820352 Commit-Queue: Ryan Landay <rlanday@chromium.org> Reviewed-by:
-
Xing Liu authored
Bug: 793158 Change-Id: I32c0567bb5e1c44ccd21e898e1022593121b187e Reviewed-on: https://chromium-review.googlesource.com/817359 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
-
Peiyong Lin authored
It's very important to understand how much IPC volume GRC needs to handle. This patch adds an IPCVolumeReporter to report IPC count for frame, page and process every minute. The histogram uses a maximum count of 100 with 10 buckets. BUG=776118, 790680 Change-Id: Id11ffa4480f7d066f140cf6daba1dedc744e311e Reviewed-on: https://chromium-review.googlesource.com/815280Reviewed-by:
Zhen Wang <zhenw@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: lpy <lpy@chromium.org> Cr-Commit-Position: refs/heads/master@{#523249}
-
Ned Nguyen authored
Bug:793609 NOTRY=true TBR=dpranke@chromium.org Change-Id: I770559876a6dd6b7de0a3575e02a1b854858a414 Reviewed-on: https://chromium-review.googlesource.com/820939Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#523248}
-
Erik Luo authored
Console will remember - User text typed in the input filter - Whether the sidebar was open, consistent with Sources and the drawer - Which top level sidebar filter was selected Bug: 787620, 734088 Change-Id: Iab109fbf1f459b0c64974c7414dcf3fd24739f11 Reviewed-on: https://chromium-review.googlesource.com/810090 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
-
Xiaohan Wang authored
Today we always write and read from the DataPipe asynchronously. This might introduce unnecessary latency since the DataPipe might already be readable/writable when we schedule the read/write. This also indirectly contributes to out-of-order dispatch of Decode() and Reset() calls in some MojoDecoderBufferConverter clients, e.g. MojoAudioDecoderService, MojoVideoDecoderService, MojoDecryptorService. See BUG for more details. Unit tests are added to cover this issue. Note that this CL does not completely fix the BUG. A follow up CL will come next, with more tests added. BUG=792281 TEST=More tests added. Change-Id: Ia6dc25f8621cca2a041b6299b104de2074c06a02 Reviewed-on: https://chromium-review.googlesource.com/818329 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Xiangjun Zhang <xjz@chromium.org> Cr-Commit-Position: refs/heads/master@{#523246}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9e68ea0b. With Chromium commits locally applied on WPT: d857d94a "Handle display:contents while creating counter nodes." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/7457 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I2c7430b2fc8ddeeab76dac9f922f70cacccff341 Reviewed-on: https://chromium-review.googlesource.com/820193 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523245}
-
