- 13 Dec, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/319e00ca2a19..b7e9343b7617 git log 319e00ca2a19..b7e9343b7617 --date=short --first-parent --format='%ad %ae %s' 2019-12-13 dberris@chromium.org Introduce a histogram_name property in ReadOptions 2019-12-13 sullivan@chromium.org Correct LCP metric use of Map. Created with: gclient setdep -r src/third_party/catapult@b7e9343b7617 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1033807 Tbr: skyostil@google.com Change-Id: I39951e36490eec3c81efc943129bbee74406f2d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966015Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#724535}
-
Wei Wang authored
This patch implements ServiceWorkerGlobalScope.onmessageerror, including adding event handler attribute, adding constructor for ExtendableMessageEvent of kMessageerror type, and starting to dispatch messageerror events. This patch also modifies the existing WPT to test the implementation, including adding t.add_cleanup() to unregister the service worker and remove the iframe, and modifying the expected results of the WPT. chromestatus: https://chromestatus.com/feature/5758162755911680 Bug: 1024132 Change-Id: Icac12f62a2840e8bb694f6b80b08e50805a4b6de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921521 Commit-Queue: Wei4 Wang <wei4.wang@intel.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#724534}
-
Keishi Hattori authored
Removing kHighPriorityInputOnMainThread experiment as it has been permanently enabled. Change-Id: Ief831cccdd8a312f0a25fbef9a64e7ef87a17037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957192 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#724533}
-
Yun Liu authored
Reference link: https://clang.llvm.org/docs/SourceBasedCodeCoverage.html#running-the-instrumented-program Dumping data to ONLY 1 file may cause warning and data overwrite in browsertests. Pattern "%2m" is used to expand to 2 raw profiles at runtime. Example in chromium: https://cs.chromium.org/search/?q=LLVM_PROFILE_FILE+2m&sq=package:chromium&type=cs DeviceTempFile cannot be used with the pattern, and NamedDeviceTemporaryDirectory is not applicable because the directory is not created until using "with" statement. Bug: 985574 Change-Id: I8c2b9f1d289be1de3bd1b283cc35acc618a7d6a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884378Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#724532}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/6c479796f6e4..ebf634bcaa3e git log 6c479796f6e4..ebf634bcaa3e --date=short --first-parent --format='%ad %ae %s' 2019-12-13 johnkslang@users.noreply.github.com Merge pull request #2023 from greg-lunarg/kg109 Created with: gclient setdep -r src/third_party/glslang/src@ebf634bcaa3e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ianelliot@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,ianelliot@google.com Change-Id: I8adfdb57876fb754918c08f761d1f73312dd5402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966014Reviewed-by:
-
Andrew Grieve authored
* Renames javac.py -> compile_java.py * Makes temporary paths relative * Moves .info processing to a helper class * Moves jar.py logic into compile_java.py * Output annotation processor sources to a separate directory from .class files (via -s flag) Bug: 1020680 Change-Id: Iead62ab70d0424f112606b8e326fbd880e539468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959470 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#724530}
-
Jaeyong Bae authored
This patch means fix the size of string for test. Because, it appears to cause the devices we use on android-asan to oom on asan builds. Bug: 979668 Change-Id: I0321d76a0f69b8bc920347f3bce329e36f1a5cfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879627Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com> Cr-Commit-Position: refs/heads/master@{#724529}
-
Alan Cutter authored
This reverts commit e2c6d84a. Reason for revert: DumpAccessibilityTreeTest.AccessibilityButtonNameCalc/uia is failing on all Windows 7 waterfall bots: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_browsertests&tests=DumpAccessibilityTreeTest.AccessibilityButtonNameCalc%2Fuia [4176:1936:1212/164612.912:ERROR:dump_accessibility_test_helper.cc(126)] Diff: * Line Expected - ---- -------- 1 document 2 ++button Name='InnerText0' 3 ++button Name='InnerText1' 4 ++button Name='AriaLabel2' 5 ++button Name='LabelledBy3' 6 ++button Name='LabelledBy4' 7 ++button Name='InnerText5' 8 ++button Name='Outer inner' 9 ++++description Name='Outer' IsControlElement=false * 10 ++++group 11 ++++++description Name='inner' IsControlElement=false 12 ++button Name='Outer inner1' 13 ++++description Name='Outer' IsControlElement=false 14 ++++group Name='inner1' 15 ++++++description Name='inner2' IsControlElement=false 16 ++button Name='Outer grandchild' 17 ++++description Name='Outer' IsControlElement=false 18 ++++group * 19 ++++++group 20 ++++++++description Name='grandchild' IsControlElement=false 21 <-- End-of-file --> Actual ------ document ++button Name='InnerText0' ++button Name='InnerText1' ++button Name='AriaLabel2' ++button Name='LabelledBy3' ++button Name='LabelledBy4' ++button Name='InnerText5' ++button Name='Outer inner' ++++description Name='Outer' IsControlElement=false ++++group IsControlElement=false ++++++description Name='inner' IsControlElement=false ++button Name='Outer inner1' ++++description Name='Outer' IsControlElement=false ++++group Name='inner1' ++++++description Name='inner2' IsControlElement=false ++button Name='Outer grandchild' ++++description Name='Outer' IsControlElement=false ++++group ++++++group IsControlElement=false ++++++++description Name='grandchild' IsControlElement=false <-- End-of-file --> ../../content/browser/accessibility/dump_accessibility_browsertest_base.cc(436): error: Value of: matches_expectation Actual: false Expected: true Original change's description: > Tune the UI Automation content view > > In testing we've observed scenarios where uninteresting container nodes > in the accessibility tree have caused issues with Narrator. This CL > removes some of these containers from the UI Automation content view, > which is the view Narrator uses. > > Bug: 1031302 > Change-Id: Iaee82c3add61659b9c14591d072ab49b069f5c61 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938308 > Commit-Queue: Adam Ettenberger <adettenb@microsoft.com> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Nektarios Paisios <nektar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#724335} TBR=haraken@chromium.org,nektar@chromium.org,rsesek@chromium.org,kbabbitt@microsoft.com,kschmi@microsoft.com,adettenb@microsoft.com Change-Id: I3159634c2c234e95c48bf6d120ef5fae2c81b05d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1031302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965745Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#724528}
-
Koji Ishii authored
Following bot results are included. 580 581 583 584 586 588 589 592 593 594 595 599 601 195 lines were removed and 30 lines were deflaked by consecutive results since 581. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: I5a2d454b4814903fd8c0e7271e53699ad55f5103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958300Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#724527}
-
Xianzhu Wang authored
ToBaseValue() is not supported when a TracedValue is backed with a ProtoWriter. Previously the mistake was silently ignored. Separate JSON related API from ConvertableToTraceFormat and TracedValue into TracedValueJSON. Also fix broken ToString() usages. (TBR for simple passive changes under base/task/, base/test/ and components/.) TBR=thakis@chromium.org R=oysteine@chromium.org,pdr@chromium.org Change-Id: Iac5aeeb021f019917d61f57144b4a2a799f79a23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956965 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#724526}
-
David Munro authored
Bug: chromium:930901 Test: Upgraded manually. Unit tests. Change-Id: I227d354fc36d8527cadaf0a3c2465940703ee2f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966800 Commit-Queue: David Munro <davidmunro@google.com> Commit-Queue: Nicholas Verne <nverne@chromium.org> Auto-Submit: David Munro <davidmunro@google.com> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#724525}
-
Alex Turner authored
Adds functionality that allows for skipping field trials that conflict with other arguments. Also adds functionality for merging field trials. Both of these will be enabled in a future change. A design document can be found in the bug ticket. Bug: 1031186 Change-Id: I4a86890fbd8edd238784db2876518fd144bfee31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902532 Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Ravi Mistry <rmistry@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#724524}
-
Kenichi Ishibashi authored
[CallWith] is translated into [ConstructorCallWith]. These extended attributes are moved into interface's extended attributes. As a consequence specifying these extended attributes on a single constructor operation affects all constructor operations. This is tricky and ideally we should avoid this kind of hack but I guess this is fine because this wouldn't break existing IDL files and we will use the new code generator soon. Bug: 999961 Change-Id: I39c817c21cea84e839d461210127444a95a2d3cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961881Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#724523}
-
chrome://settingsDemetrios Papadopoulos authored
- Always pass |showOSSettings| as false to chrome://settings. - Delete chrome://settings tests referring to UIs that no longer exist. This is the first of many steps to fully decouple chrome://settings and chrome://os-settings codebases, now that SplitSettings is on by default. The UIs surfaces (along with any strings) in chrome://settings that become dead code with this CL, will be removed in follow up steps. Note as of this CL, --disable-features=SplitSettings will not be respected by chrome://settings anymore but the flag itself will be removed in later CLs. Bug: 1026455 Change-Id: I9a916c7686e96c9f604bed2c180ecd9a3ba9f7ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962018 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#724522}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0678df30b5a5..39cdc37bdd0f git log 0678df30b5a5..39cdc37bdd0f --date=short --first-parent --format='%ad %ae %s' 2019-12-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 5855011aeee5..cd31cb38833c (1 commits) Created with: gclient setdep -r src/third_party/skia@39cdc37bdd0f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: djsollen@google.com Change-Id: Ic5e757b81a4c0cbf1b36a151aa94b1be8c74e8ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966676Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e0f8b5d08354..1d77542f5681 git log e0f8b5d08354..1d77542f5681 --date=short --first-parent --format='%ad %ae %s' 2019-12-13 cnorthrop@google.com Add flag to label captures 2019-12-12 jmadill@chromium.org gn: Add 'test_only' label to util targets. 2019-12-12 jmadill@chromium.org util: Always export default visibility. Created with: gclient setdep -r src/third_party/angle@1d77542f5681 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliot@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1030192 Tbr: ianelliot@google.com Change-Id: I8353fdb7b90ea72bdb3786580c03e3ccdee485db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966409Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Id19cf6f9de927f0f4600afc7ccf0921cf3e563f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966685Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c741d90d63c0..0b132b0832d4 Created with: gclient setdep -r src-internal@0b132b0832d4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: If9b699ae36d8c7a3585b9c2e38976cc603379d2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966683Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#724518}
-
Johannes Henkel authored
Upstream PR: https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1966418 Also, adding README.md and transcode.cc to roll.py so it gets rolled. Change-Id: Id7e772130a56b38faec1f0964c21eff18f0fc8b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966495 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#724517}
-
Sam Sebree authored
-Allows mime type to be referenced from service worker installed scripts manager -Introduces JSON modules as a feature flag so that the flag is accessible to the browser process -Introduces service worker WPT tests for JSON Modules This PR inspired the following change: https://chromium-review.googlesource.com/c/chromium/src/+/1854504 Bug: 967018 Change-Id: I6939988ab0df3896bbd81dcd174312f871583574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825788Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Sam Sebree <sasebree@microsoft.com> Cr-Commit-Position: refs/heads/master@{#724516}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/953ba804a145..319e00ca2a19 git log 953ba804a145..319e00ca2a19 --date=short --first-parent --format='%ad %ae %s' 2019-12-13 dberris@chromium.org Update timestamp on every execution engine update Created with: gclient setdep -r src/third_party/catapult@319e00ca2a19 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1032856 Tbr: skyostil@google.com Change-Id: I70aba064f5fbeed59a22200a5b50e9eb0d8da2e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966682Reviewed-by:
-
Keishi Hattori authored
Replaces the per-thread input task queue with a per-RenderWidget one. Adds WidgetScheduler class to manage these per-RenderWidget task queues. Design doc: https://docs.google.com/document/d/1WtJSUnqngtrwrfZJ_lvv-lMrYbZIokMJNUogBQwU3KY/edit# Bug: 1030643 Change-Id: I5af29ca3ed05156d242f1417c9391e6277617dd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942679 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/5c413afdc7f8..97fb51f4af11 git log 5c413afdc7f8..97fb51f4af11 --date=short --first-parent --format='%ad %ae %s' 2019-12-13 enga@chromium.org Add script to generate fuzzer seed corpus from tests Created with: gclient setdep -r src/third_party/dawn@97fb51f4af11 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I68fdcdcab72d75434b14c022433d3eb458f9bc6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966751Reviewed-by:
-
Yuki Shiino authored
Defaults to g_empty_atom if no [ReflectInvalid=]. Renames a helper function. 'enumerated attributes' mean IDL attributes that have a set of finite string values. The helper function handles the mapping between keywrod and state for a given enumerated attribute. Bug: 839389 Change-Id: I8e77ef20de5efa34c943dcda414732c1c5153e90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961844Reviewed-by:
-
Hitoshi Yoshida authored
This is to unblock compilations, and not to work for all the cases that use buffer source types. And adds an assertion to show a clear message that an unknown type is passed in the function. (Otherwise, we may hit a property access error on None objects.) Bug: 839389 Change-Id: I98e54356e7dafd98a93023afc220700913b5d6f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965779 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
-
Anand K. Mistry authored
This avoids having multiple stray copies of the password in browser and daemon addressable memory while being transferred over Mojo. On the smbfs side, the password will be read directly into a libpasswordprovider::Password. Bug: 939235 Change-Id: I19e4b401dd388fcf56c02426ee0044ab79d1031f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963594Reviewed-by:
Sergei Datsenko <dats@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#724510}
-
Kuo Jen Wei authored
Bug: b/141518780 Test: Pass closure compiler check, tast run <DUT> 'camera.CCAUI*' and validate all function of CCA on HALv1/v3 device works correctly. Change-Id: I7fd2182d5e1933ab7dd282850f0010d0d0c9b26b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954996Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#724509}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/37fc8b16fc93..928e3835d93d git log 37fc8b16fc93..928e3835d93d --date=short --first-parent --format='%ad %ae %s' 2019-12-13 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update Devtools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@928e3835d93d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I416b43418b8cd31278bb82917364412ced1c9c72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966675Reviewed-by:
-
Alan Cutter authored
This CL disables: - OmniboxViewTest.EnterToSearch - OmniboxViewTest.DesiredTLDWithTemporaryText - OmniboxViewTest.DesiredTLD on TSAN and ASAN bots due to a high number of timeout flakes on the trybots. TBR=tommycli@chromium.org Bug: 1030551 Change-Id: Ie9b0ebfacc2ea3f948e3592902f58d2a7f9f39bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965785Reviewed-by:
-
Jeonghee Ahn authored
Background: In SpavNav mode, more elements have become focus candidates: https://chromium-review.googlesource.com/c/chromium/src/+/1461355 https://chromium-review.googlesource.com/c/chromium/src/+/1632231 https://chromium-review.googlesource.com/c/chromium/src/+/1859535 These changes were the result of our efforts to avoid unreachable elements. In other words, SpatNav started to consider more elements, with tabIndex<0, as candidates. Problem: Sometimes this caused inconvenience because every "wrapping" element got focused towards the innermost candidate: The user had to press a direction key several times to reach the "real" focusable element, see the bug for more details. Solution: This CL tries to ignore certain extra, inconvenient focus candidates. If an element is recognized as focusable by SpatNav's extended condition (SupportsSpatialNavigationFocus() in element.cc) and it has one or several focusable descendant(s), then we ignore it in favor for its focusable descendant(s). We only ignore ancestor focusables with a non-negative tabIndex. Bug: 982601 Change-Id: I8d98fb2261f205b000e2ab7bae9f801272649784 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900792 Commit-Queue: Jeonghee Ahn <jeonghee27.ahn@lge.com> Reviewed-by:
Hugo Holgersson <hugoh@logikbyran.se> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#724506}
-
Nicholas Verne authored
Users can opt to back up their existing container before attempting the upgrade and are prompted to restore if the upgrade fails. Bug: 1024693 Change-Id: If26ae717c47d40ceed74364205a83d98a2e5a1a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951272Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Julian Watson <juwa@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#724505}
-
Yu-Hsuan Hsu authored
There are several changes in this CL. 1. Add a histogram for stream effects. (related to CL:1939171) 2. Expand stream config histograms to have the Direction and ClientType suffix. (related to CL:1939172) 3. Extend the expire date of all Cras histograms to next December. BUG=b:145261414 Change-Id: Ibf8fcd84e2305e414bd1892bff1e875edb89be23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958544 Commit-Queue: Yu-Hsuan Hsu <yuhsuan@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#724504}
-
Alexandre Courbot authored
kV4l2Lib is only used from within PostSandboxInitialization(), so move it there to keep things local. BUG=None TEST=Build succeeds for kevin. Change-Id: If69f1e61c0e131b49b3d02de4838780f387a997e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966795 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#724503}
-
Jinsong Fan authored
For aura and cross-process iframes code path, the visible edges of the selection bound are uninitialized, so GetVisibleRectBetweenBounds() always returned an empty rect. This caused the quick menu or context menu to always be displayed in the top-left corner. The CL fixes it. Bug: 1027843, 1015274 Change-Id: If35210a0428fd51f8c3b44e94dfdb1960cef64a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946054 Commit-Queue: Jinsong Fan <fanjinsong@sogou-inc.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#724502}
-
Alan Cutter authored
This CL disables interactive_ui_tests in autofill_interactive_uitest.cc on Windows. Tests from the following tests suites flakily timeout on the Windows 7 waterfall: - AutofillInteractiveTest - AutofillDynamicFormInteractiveTest TBR=battre@chromium.org Bug: 967588 Change-Id: I2e29e1cb7c8223d1d7cc3951ffc91cbda1be0ab9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965736Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/97a175b7117c..c741d90d63c0 Created with: gclient setdep -r src-internal@c741d90d63c0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1029823,chromium:1033537,chromium:987646 Tbr: jbudorick@google.com Change-Id: Ifeda6caef9da58026cd299a5bfbf953126a349fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966752Reviewed-by:
-
Tetsui Ohkubo authored
During transition of ARC++ window from minimized to snapped, WorkspaceLayoutManager::OnWindowActivating() might be triggered. For browser windows, it is fine because the transition happens synchronously and the method does nothing, but for ARC++ windows, it happens asynchronously and the method might restore pre-minimize window state while snapping is still in progress. We should clear the pre-minimize state to ensure it does not happen. A Tast test arc.SplitView will be improved to cover this. TEST=manual(Follow the steps in the bug and confirmed it worked) BUG=1031313 Change-Id: Ia6c4c8a9a0746c23dc1c8d0e5716a3007f97c3c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963831Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#724499}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b34e896a1257..953ba804a145 git log b34e896a1257..953ba804a145 --date=short --first-parent --format='%ad %ae %s' 2019-12-13 dberris@chromium.org Use all known changes for determining order Created with: gclient setdep -r src/third_party/catapult@953ba804a145 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1031433 Tbr: skyostil@google.com Change-Id: I13a01c0d658ce3f18b8325326024b8f5f90d0d88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965861Reviewed-by:
-
Azeem Arshad authored
This CL fixes issue with unnecessary hand pointer appearing on network summary items even when the item is not actionable. This was caused because the row has an "actionable" attribute, that adds a pointer, permanently set on it. Fixed this by making the actionable attribute conditional. Fixed: 1005196 Change-Id: I7fda634e7fcd54c14c909b2a48ecc737b26850fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966090Reviewed-by:
Jon Mann <jonmann@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#724497}
-
Benjamin Beaudry authored
The following tests were failing when LayoutNG was disabled. - accessibility/listitem-presentation-inherited.html - accessibility/presentation-owned-elements.html - accessibility/role-attribute.html They have been moved automatically into "layout-ng-fragment-item disabled" tests but, according to Koji, they also need to be marked as disabled inside of "disable-layout-ng". Bug: 591099, 982194, 1015100 Change-Id: If08f6b27264064b83959a756d19cffe4f181023b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962646Reviewed-by:
-
