- 22 Sep, 2014 40 commits
-
-
kjellander authored
Also depend on chromium_builder_perf instead of chromium_builder_qa since it's likely we'll start running Telemetry tests on our bots in the near future. BUG= Review URL: https://codereview.chromium.org/587173004 Cr-Commit-Position: refs/heads/master@{#295968}
-
earthdok authored
BUG=415179 R=glider@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/556853003 Cr-Commit-Position: refs/heads/master@{#295967}
-
mathp authored
Previous change forgot to remove a file from BUILD.gn https://codereview.chromium.org/479873002 BUG=None NOTRY=true TBR=jam Review URL: https://codereview.chromium.org/587193004 Cr-Commit-Position: refs/heads/master@{#295966}
-
mlerman authored
BUG=413271 TEST=Ensure new-profile-management is disabled. Sign in to a profile. Enable new-profile-management. Lock an account. Take the machine offline. Try to unlock your account (with the right or wrong password), and receive a message specifying that your password cannot be verified because you're offline. Review URL: https://codereview.chromium.org/591533002 Cr-Commit-Position: refs/heads/master@{#295965}
-
elizavetai authored
Moving parts connected to screenshot testing from login_ui_browsertest.cc to separate files. Uses BrowserTestBase::Admixture added in https://codereview.chromium.org/468493003/. BUG=395653 Review URL: https://codereview.chromium.org/441263002 Cr-Commit-Position: refs/heads/master@{#295964}
-
kpschoedel authored
BUG=380349 Committed: https://chromium.googlesource.com/chromium/src/+/bbb7ea7c66f18298079eea4a6b24834986f4a822 Committed: https://crrev.com/19537df7b11b6e634c16a3073a77b98db3d7b61f Cr-Commit-Position: refs/heads/master@{#293520} Review URL: https://codereview.chromium.org/479873002 Cr-Commit-Position: refs/heads/master@{#295963}
-
vasilii authored
Revert of Roll src/third_party/WebKit 08e97a9:0f6e289 (svn 182386:182407) (patchset #1 id:1 of https://codereview.chromium.org/588163003/) Reason for revert: Linux ASAN memory leaks after "Roll src/third_party/WebKit 08e97a9:0f6e289 (svn 182386:182407)" http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/7724/steps/content_unittests/logs/stdio ==30366==ERROR: LeakSanitizer: detected memory leaks Direct leak of 34 byte(s) in 1 object(s) allocated from: #0 0x50482b in malloc (/b/build/slave/Linux_ASan_LSan_Tests__2_/build/src/out/Release/content_unittests+0x50482b) #1 0x58b7516 in partitionAllocGenericFlags third_party/WebKit/Source/wtf/PartitionAlloc.h:538:20 #2 0x58b7516 in partitionAllocGeneric third_party/WebKit/Source/wtf/PartitionAlloc.h:554 #3 0x58b7516 in createUninitialized third_party/WebKit/Source/wtf/text/StringImpl.cpp:299 #4 0x58b7516 in WTF::StringImpl::create(unsigned char const*, unsigned int) third_party/WebKit/Source/wtf/text/StringImpl.cpp:418 #5 0x58e809f in WTF::String::fromUTF8(unsigned char const*, unsigned long) third_party/WebKit/Source/wtf/text/WTFString.cpp:911:16 #6 0x58ffa2f in fromUTF8 third_party/WebKit/Source/wtf/text/WTFString.h:400:67 #7 0x58ffa2f in blink::WebString::fromUTF8(char const*, unsigned long) third_party/WebKit/Source/platform/exported/WebString.cpp:91 #8 0x20a09ac in WebString<23> third_party/WebKit/public/platform/WebString.h:113:16 #9 0x20a09ac in content::MockMediaStreamRegistry::AddVideoTrack(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) content/renderer/media/mock_media_stream_registry.cc:36 #10 0x217484a in VideoSourceHandlerTest_OpenWithoutClose_Test content/renderer/media/video_source_handler_unittest.cc:97:1 #11 0x217484a in testing::internal::TestFactoryImpl<content::VideoSourceHandlerTest_OpenWithoutClose_Test>::CreateTest() testing/gtest/include/gtest/internal/gtest-internal.h:486 #12 0x2f13c63 in HandleExceptionsInMethodIfSupported<testing::internal::TestFactoryBase, testing::Test *> testing/gtest/src/gtest.cc:2418:12 #13 0x2f13c63 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2601 #14 0x2f14df6 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2728:5 #15 0x2f28853 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4591:11 #16 0x2f27e54 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2418:12 #17 0x2f27e54 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4209 #18 0x2eb1e53 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2304:10 #19 0x2eb1e53 in base::TestSuite::Run() base/test/test_suite.cc:226 #20 0x2ea717b in Run base/callback.h:401:12 #21 0x2ea717b in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int ()> const&, int, bool, base::Callback<void ()> const&) base/test/launcher/unit_test_launcher.cc:498 #22 0x2ea6c70 in base::LaunchUnitTests(int, char**, base::Callback<int ()> const&) base/test/launcher/unit_test_launcher.cc:553:10 #23 0x1ff5d0c in main content/test/run_all_unittests.cc:14:10 #24 0x7f375d21876c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 Original issue's description: > Roll src/third_party/WebKit 08e97a9:0f6e289 (svn 182386:182407) > > Summary of changes available at: > https://chromium.googlesource.com/chromium/blink/+log/08e97a9..0f6e289 > > TBR=caseq@chromium.org,pdr@chromium.org,wjmaclean@chromium.org > > Committed: https://crrev.com/f57e3cf2113ac892f16777e5ab225f3c68b94ede > Cr-Commit-Position: refs/heads/master@{#295950} TBR=caseq@chromium.org,pdr@chromium.org,wjmaclean@chromium.org,blink-deps-roller@chromium.org NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/592783002 Cr-Commit-Position: refs/heads/master@{#295962}
-
vasilii authored
Revert of Roll src/third_party/WebKit 0f6e289:a63b92e (svn 182407:182410) (patchset #1 id:1 of https://codereview.chromium.org/590143002/) Reason for revert: Linux ASAN memory leaks after "Roll src/third_party/WebKit 08e97a9:0f6e289 (svn 182386:182407)" http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/7724/steps/content_unittests/logs/stdio ==30366==ERROR: LeakSanitizer: detected memory leaks Direct leak of 34 byte(s) in 1 object(s) allocated from: #0 0x50482b in malloc (/b/build/slave/Linux_ASan_LSan_Tests__2_/build/src/out/Release/content_unittests+0x50482b) #1 0x58b7516 in partitionAllocGenericFlags third_party/WebKit/Source/wtf/PartitionAlloc.h:538:20 #2 0x58b7516 in partitionAllocGeneric third_party/WebKit/Source/wtf/PartitionAlloc.h:554 #3 0x58b7516 in createUninitialized third_party/WebKit/Source/wtf/text/StringImpl.cpp:299 #4 0x58b7516 in WTF::StringImpl::create(unsigned char const*, unsigned int) third_party/WebKit/Source/wtf/text/StringImpl.cpp:418 #5 0x58e809f in WTF::String::fromUTF8(unsigned char const*, unsigned long) third_party/WebKit/Source/wtf/text/WTFString.cpp:911:16 #6 0x58ffa2f in fromUTF8 third_party/WebKit/Source/wtf/text/WTFString.h:400:67 #7 0x58ffa2f in blink::WebString::fromUTF8(char const*, unsigned long) third_party/WebKit/Source/platform/exported/WebString.cpp:91 #8 0x20a09ac in WebString<23> third_party/WebKit/public/platform/WebString.h:113:16 #9 0x20a09ac in content::MockMediaStreamRegistry::AddVideoTrack(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) content/renderer/media/mock_media_stream_registry.cc:36 #10 0x217484a in VideoSourceHandlerTest_OpenWithoutClose_Test content/renderer/media/video_source_handler_unittest.cc:97:1 #11 0x217484a in testing::internal::TestFactoryImpl<content::VideoSourceHandlerTest_OpenWithoutClose_Test>::CreateTest() testing/gtest/include/gtest/internal/gtest-internal.h:486 #12 0x2f13c63 in HandleExceptionsInMethodIfSupported<testing::internal::TestFactoryBase, testing::Test *> testing/gtest/src/gtest.cc:2418:12 #13 0x2f13c63 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2601 #14 0x2f14df6 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2728:5 #15 0x2f28853 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4591:11 #16 0x2f27e54 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2418:12 #17 0x2f27e54 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4209 #18 0x2eb1e53 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2304:10 #19 0x2eb1e53 in base::TestSuite::Run() base/test/test_suite.cc:226 #20 0x2ea717b in Run base/callback.h:401:12 #21 0x2ea717b in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int ()> const&, int, bool, base::Callback<void ()> const&) base/test/launcher/unit_test_launcher.cc:498 #22 0x2ea6c70 in base::LaunchUnitTests(int, char**, base::Callback<int ()> const&) base/test/launcher/unit_test_launcher.cc:553:10 #23 0x1ff5d0c in main content/test/run_all_unittests.cc:14:10 #24 0x7f375d21876c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 Original issue's description: > Roll src/third_party/WebKit 0f6e289:a63b92e (svn 182407:182410) > > Summary of changes available at: > https://chromium.googlesource.com/chromium/blink/+log/0f6e289..a63b92e > > TBR=caseq@chromium.org,pdr@chromium.org,wjmaclean@chromium.org > > Committed: https://crrev.com/09e1192db2fc7c5295eb373626b77945ca10aee3 > Cr-Commit-Position: refs/heads/master@{#295959} TBR=caseq@chromium.org,pdr@chromium.org,wjmaclean@chromium.org,blink-deps-roller@chromium.org NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/593693004 Cr-Commit-Position: refs/heads/master@{#295961}
-
Erik Corry authored
R=jochen@chromium.org BUG= Review URL: https://codereview.chromium.org/588543003 Cr-Commit-Position: refs/heads/master@{#295960}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/0f6e289..a63b92e TBR=caseq@chromium.org,pdr@chromium.org,wjmaclean@chromium.org Review URL: https://codereview.chromium.org/590143002 Cr-Commit-Position: refs/heads/master@{#295959}
-
glider authored
This CL links libsanitizer_options into every executable built with ASan on OSX. The existing implementation of __asan_default_options for Chromium.app is merged with that in sanitizer_options.cc Also now use_sanitizer_options is only set when building with sanitizers so that there isn't an unconditional dependency on an empty object file in every executable in non-sanitizer builds. BUG=302040 R=cpu@chromium.org Review URL: https://codereview.chromium.org/581983003 Cr-Commit-Position: refs/heads/master@{#295958}
-
chrome-tpm authored
Cr-Commit-Position: refs/heads/master@{#295957} -
joaodasilva authored
This test flakes on the Mac. This CL adds additional logging to help diagnose the source of flakiness. BUG=339240 Review URL: https://codereview.chromium.org/551323003 Cr-Commit-Position: refs/heads/master@{#295956}
-
ziran.sun authored
Autofill preview sets the field's autofill property to true. When the field is autofilled right after preview happens, we'd like to clear the autofill property that was set by preview before filling happens. This is handled in Blink side in SetValue() function - https://codereview.chromium.org/553983012/ R=isherman@chromium.org BUG=412311 Review URL: https://codereview.chromium.org/551403002 Cr-Commit-Position: refs/heads/master@{#295955}
-
elizavetai authored
Class MixinBasedBrowserTest was added. This class expands its base class, InProcessBrowserTest, by supporting adding mixins. Mixins can be used to add some features not related directly to the testing process in order not to make the test class too complicated and to set up them in a proper time (at the same time when the corresponding set ups for the main test are run). A mixin should be a class inherited from MixinBasedBrowserTest::Mixin. Test which wants to use some mixin should call AddMixin(mixin_) from its constructor, where mixin_ should be an instance of e.g. MixinYouWantToUse. Also, now LoginManagerTest is inherited from MixinBasedBrowserTest. BUG=395653 Review URL: https://codereview.chromium.org/574703002 Cr-Commit-Position: refs/heads/master@{#295954}
-
dgozman authored
This decouples targets discovery from remote debugging in preparation of moving discovery to the protocol. BUG=398049 Review URL: https://codereview.chromium.org/560323005 Cr-Commit-Position: refs/heads/master@{#295953}
-
mcasas authored
This CL adds a new class VideoCaptureDeviceDeckLinkMac with two static methods EnumerateDevices() and EnumerateDeviceCapabilities(). This class also has some empty methods to comply with VCD interface. DeckLink uses ScopedComPtr style APIs, so an internal template class is provided with the needed bits for automatic reference counting inside VCDDeckLinkMac. Static methods for enumeration are used from VCDFactoryMac. Support for Blackmagic SDK as a third party is discussed in http://crbug.com/408534 and is necessary prerequisite for landing this CL. This SDK landing is under review in http://crrev.com/509313002. Other CL(s) will follow to use DeckLink devices for capture. BUG=408493, 408534 Review URL: https://codereview.chromium.org/518073002 Cr-Commit-Position: refs/heads/master@{#295952}
-
peria authored
BUG=409743 TEST=unit_tests --gtest_filter="MetadataDatabaseTest*" Review URL: https://codereview.chromium.org/552723002 Cr-Commit-Position: refs/heads/master@{#295951}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/08e97a9..0f6e289 TBR=caseq@chromium.org,pdr@chromium.org,wjmaclean@chromium.org Review URL: https://codereview.chromium.org/588163003 Cr-Commit-Position: refs/heads/master@{#295950}
-
vasilii authored
BUG=416406 TBR=rijubrata.bhaumik@intel.com NOTRY=true Review URL: https://codereview.chromium.org/592733002 Cr-Commit-Position: refs/heads/master@{#295949}
-
kulkarni.a authored
BUG= Review URL: https://codereview.chromium.org/587713002 Cr-Commit-Position: refs/heads/master@{#295948}
-
vasilii authored
Revert of Roll src/third_party/WebKit 08e97a9:38de67c (svn 182386:182399) (patchset #1 id:1 of https://codereview.chromium.org/587233002/) Reason for revert: Compilation failure on Mac: FAILED: cd ../../third_party/WebKit/Source/bindings/modules/v8; export BUILT_PRODUCTS_DIR=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release; export CONFIGURATION=Release; export PRODUCT_NAME=bindings_modules_v8_generated_individual; export SDKROOT=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk; export SRCROOT=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release/../../third_party/WebKit/Source/bindings/modules/v8; export SOURCE_ROOT="${SRCROOT}"; export TARGET_BUILD_DIR=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release; export TEMP_DIR="${TMPDIR}";python ../../scripts/idl_compiler.py --cache-dir ../../../../../../out/Release/gen/blink/bindings/scripts --output-dir ../../../../../../out/Release/gen/blink/bindings/modules/v8 --interfaces-info ../../../../../../out/Release/gen/blink/bindings/modules/InterfacesInfoModules.pickle --write-file-only-if-changed 1 "../../../modules/webaudio/OfflineAudioCompletionEvent.idl" /bin/sh: line 1: 8665 Killed: 9 python ../../scripts/idl_compiler.py --cache-dir ../../../../../../out/Release/gen/blink/bindings/scripts --output-dir ../../../../../../out/Release/gen/blink/bindings/modules/v8 --interfaces-info ../../../../../../out/Release/gen/blink/bindings/modules/InterfacesInfoModules.pickle --write-file-only-if-changed 1 "../../../modules/webaudio/OfflineAudioCompletionEvent.idl" FAILED: cd ../../third_party/WebKit/Source/bindings/modules/v8; export BUILT_PRODUCTS_DIR=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release; export CONFIGURATION=Release; export PRODUCT_NAME=bindings_modules_v8_generated_individual; export SDKROOT=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk; export SRCROOT=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release/../../third_party/WebKit/Source/bindings/modules/v8; export SOURCE_ROOT="${SRCROOT}"; export TARGET_BUILD_DIR=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release; export TEMP_DIR="${TMPDIR}";python ../../scripts/idl_compiler.py --cache-dir ../../../../../../out/Release/gen/blink/bindings/scripts --output-dir ../../../../../../out/Release/gen/blink/bindings/modules/v8 --interfaces-info ../../../../../../out/Release/gen/blink/bindings/modules/InterfacesInfoModules.pickle --write-file-only-if-changed 1 "../../../modules/webaudio/OscillatorNode.idl" /bin/sh: line 1: 8666 Killed: 9 python ../../scripts/idl_compiler.py --cache-dir ../../../../../../out/Release/gen/blink/bindings/scripts --output-dir ../../../../../../out/Release/gen/blink/bindings/modules/v8 --interfaces-info ../../../../../../out/Release/gen/blink/bindings/modules/InterfacesInfoModules.pickle --write-file-only-if-changed 1 "../../../modules/webaudio/OscillatorNode.idl" FAILED: cd ../../third_party/WebKit/Source/bindings/modules/v8; export BUILT_PRODUCTS_DIR=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release; export CONFIGURATION=Release; export PRODUCT_NAME=bindings_modules_v8_generated_individual; export SDKROOT=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk; export SRCROOT=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release/../../third_party/WebKit/Source/bindings/modules/v8; export SOURCE_ROOT="${SRCROOT}"; export TARGET_BUILD_DIR=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release; export TEMP_DIR="${TMPDIR}";python ../../scripts/idl_compiler.py --cache-dir ../../../../../../out/Release/gen/blink/bindings/scripts --output-dir ../../../../../../out/Release/gen/blink/bindings/modules/v8 --interfaces-info ../../../../../../out/Release/gen/blink/bindings/modules/InterfacesInfoModules.pickle --write-file-only-if-changed 1 "../../../modules/webaudio/PannerNode.idl" /bin/sh: line 1: 8669 Killed: 9 python ../../scripts/idl_compiler.py --cache-dir ../../../../../../out/Release/gen/blink/bindings/scripts --output-dir ../../../../../../out/Release/gen/blink/bindings/modules/v8 --interfaces-info ../../../../../../out/Release/gen/blink/bindings/modules/InterfacesInfoModules.pickle --write-file-only-if-changed 1 "../../../modules/webaudio/PannerNode.idl" FAILED: cd ../../third_party/WebKit/Source/bindings/modules/v8; export BUILT_PRODUCTS_DIR=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release; export CONFIGURATION=Release; export PRODUCT_NAME=bindings_modules_v8_generated_individual; export SDKROOT=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk; export SRCROOT=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release/../../third_party/WebKit/Source/bindings/modules/v8; export SOURCE_ROOT="${SRCROOT}"; export TARGET_BUILD_DIR=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release; export TEMP_DIR="${TMPDIR}";python ../../scripts/idl_compiler.py --cache-dir ../../../../../../out/Release/gen/blink/bindings/scripts --output-dir ../../../../../../out/Release/gen/blink/bindings/modules/v8 --interfaces-info ../../../../../../out/Release/gen/blink/bindings/modules/InterfacesInfoModules.pickle --write-file-only-if-changed 1 "../../../modules/webaudio/PeriodicWave.idl" /bin/sh: line 1: 8670 Killed: 9 python ../../scripts/idl_compiler.py --cache-dir ../../../../../../out/Release/gen/blink/bindings/scripts --output-dir ../../../../../../out/Release/gen/blink/bindings/modules/v8 --interfaces-info ../../../../../../out/Release/gen/blink/bindings/modules/InterfacesInfoModules.pickle --write-file-only-if-changed 1 "../../../modules/webaudio/PeriodicWave.idl" FAILED: cd ../../third_party/WebKit/Source/bindings/modules/v8; export BUILT_PRODUCTS_DIR=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release; export CONFIGURATION=Release; export PRODUCT_NAME=bindings_modules_v8_generated_individual; export SDKROOT=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk; export SRCROOT=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release/../../third_party/WebKit/Source/bindings/modules/v8; export SOURCE_ROOT="${SRCROOT}"; export TARGET_BUILD_DIR=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release; export TEMP_DIR="${TMPDIR}";python ../../scripts/idl_compiler.py --cache-dir ../../../../../../out/Release/gen/blink/bindings/scripts --output-dir ../../../../../../out/Release/gen/blink/bindings/modules/v8 --interfaces-info ../../../../../../out/Release/gen/blink/bindings/modules/InterfacesInfoModules.pickle --write-file-only-if-changed 1 "../../../modules/webdatabase/SQLResultSetRowList.idl" /bin/sh: line 1: 8674 Killed: 9 python ../../scripts/idl_compiler.py --cache-dir ../../../../../../out/Release/gen/blink/bindings/scripts --output-dir ../../../../../../out/Release/gen/blink/bindings/modules/v8 --interfaces-info ../../../../../../out/Release/gen/blink/bindings/modules/InterfacesInfoModules.pickle --write-file-only-if-changed 1 "../../../modules/webdatabase/SQLResultSetRowList.idl" FAILED: cd ../../third_party/WebKit/Source/bindings/modules/v8; export BUILT_PRODUCTS_DIR=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release; export CONFIGURATION=Release; export PRODUCT_NAME=bindings_modules_v8_generated_individual; export SDKROOT=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk; export SRCROOT=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release/../../third_party/WebKit/Source/bindings/modules/v8; export SOURCE_ROOT="${SRCROOT}"; export TARGET_BUILD_DIR=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release; export TEMP_DIR="${TMPDIR}";python ../../scripts/idl_compiler.py --cache-dir ../../../../../../out/Release/gen/blink/bindings/scripts --output-dir ../../../../../../out/Release/gen/blink/bindings/modules/v8 --interfaces-info ../../../../../../out/Release/gen/blink/bindings/modules/InterfacesInfoModules.pickle --write-file-only-if-changed 1 "../../../modules/webdatabase/SQLError.idl" /bin/sh: line 1: 8681 Killed: 9 python ../../scripts/idl_compiler.py --cache-dir ../../../../../../out/Release/gen/blink/bindings/scripts --output-dir ../../../../../../out/Release/gen/blink/bindings/modules/v8 --interfaces-info ../../../../../../out/Release/gen/blink/bindings/modules/InterfacesInfoModules.pickle --write-file-only-if-changed 1 "../../../modules/webdatabase/SQLError.idl" FAILED: cd ../../third_party/WebKit/Source/bindings/modules/v8; export BUILT_PRODUCTS_DIR=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release; export CONFIGURATION=Release; export PRODUCT_NAME=bindings_modules_v8_generated_individual; export SDKROOT=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk; export SRCROOT=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release/../../third_party/WebKit/Source/bindings/modules/v8; export SOURCE_ROOT="${SRCROOT}"; export TARGET_BUILD_DIR=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release; export TEMP_DIR="${TMPDIR}";python ../../scripts/idl_compiler.py --cache-dir ../../../../../../out/Release/gen/blink/bindings/scripts --output-dir ../../../../../../out/Release/gen/blink/bindings/modules/v8 --interfaces-info ../../../../../../out/Release/gen/blink/bindings/modules/InterfacesInfoModules.pickle --write-file-only-if-changed 1 "../../../modules/webdatabase/SQLResultSet.idl" /bin/sh: line 1: 8682 Killed: 9 python ../../scripts/idl_compiler.py --cache-dir ../../../../../../out/Release/gen/blink/bindings/scripts --output-dir ../../../../../../out/Release/gen/blink/bindings/modules/v8 --interfaces-info ../../../../../../out/Release/gen/blink/bindings/modules/InterfacesInfoModules.pickle --write-file-only-if-changed 1 "../../../modules/webdatabase/SQLResultSet.idl" FAILED: cd ../../third_party/WebKit/Source/bindings/modules/v8; export BUILT_PRODUCTS_DIR=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release; export CONFIGURATION=Release; export PRODUCT_NAME=bindings_modules_v8_generated_individual; export SDKROOT=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk; export SRCROOT=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release/../../third_party/WebKit/Source/bindings/modules/v8; export SOURCE_ROOT="${SRCROOT}"; export TARGET_BUILD_DIR=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release; export TEMP_DIR="${TMPDIR}";python ../../scripts/idl_compiler.py --cache-dir ../../../../../../out/Release/gen/blink/bindings/scripts --output-dir ../../../../../../out/Release/gen/blink/bindings/modules/v8 --interfaces-info ../../../../../../out/Release/gen/blink/bindings/modules/InterfacesInfoModules.pickle --write-file-only-if-changed 1 "../../../modules/webdatabase/SQLStatementCallback.idl" /bin/sh: line 1: 8684 Killed: 9 python ../../scripts/idl_compiler.py --cache-dir ../../../../../../out/Release/gen/blink/bindings/scripts --output-dir ../../../../../../out/Release/gen/blink/bindings/modules/v8 --interfaces-info ../../../../../../out/Release/gen/blink/bindings/modules/InterfacesInfoModules.pickle --write-file-only-if-changed 1 "../../../modules/webdatabase/SQLStatementCallback.idl" FAILED: cd ../../third_party/WebKit/Source/bindings/modules/v8; export BUILT_PRODUCTS_DIR=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release; export CONFIGURATION=Release; export PRODUCT_NAME=bindings_modules_v8_generated_individual; export SDKROOT=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk; export SRCROOT=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release/../../third_party/WebKit/Source/bindings/modules/v8; export SOURCE_ROOT="${SRCROOT}"; export TARGET_BUILD_DIR=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release; export TEMP_DIR="${TMPDIR}";python ../../scripts/idl_compiler.py --cache-dir ../../../../../../out/Release/gen/blink/bindings/scripts --output-dir ../../../../../../out/Release/gen/blink/bindings/modules/v8 --interfaces-info ../../../../../../out/Release/gen/blink/bindings/modules/InterfacesInfoModules.pickle --write-file-only-if-changed 1 "../../../modules/webaudio/WaveShaperNode.idl" /bin/sh: line 1: 8673 Killed: 9 python ../../scripts/idl_compiler.py --cache-dir ../../../../../../out/Release/gen/blink/bindings/scripts --output-dir ../../../../../../out/Release/gen/blink/bindings/modules/v8 --interfaces-info ../../../../../../out/Release/gen/blink/bindings/modules/InterfacesInfoModules.pickle --write-file-only-if-changed 1 "../../../modules/webaudio/WaveShaperNode.idl" FAILED: cd ../../third_party/WebKit/Source/bindings/modules/v8; export BUILT_PRODUCTS_DIR=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release; export CONFIGURATION=Release; export PRODUCT_NAME=bindings_modules_v8_generated_individual; export SDKROOT=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk; export SRCROOT=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release/../../third_party/WebKit/Source/bindings/modules/v8; export SOURCE_ROOT="${SRCROOT}"; export TARGET_BUILD_DIR=/Volumes/data/b/build/slave/Mac_Builder/build/src/out/Release; export TEMP_DIR="${TMPDIR}";python ../../scripts/idl_compiler.py --cache-dir ../../../../../../out/Release/gen/blink/bindings/scripts --output-dir ../../../../../../out/Release/gen/blink/bindings/modules/v8 --interfaces-info ../../../../../../out/Release/gen/blink/bindings/modules/InterfacesInfoModules.pickle --write-file-only-if-changed 1 "../../../modules/webdatabase/Database.idl" /bin/sh: line 1: 8676 Killed: 9 python ../../scripts/idl_compiler.py --cache-dir ../../../../../../out/Release/gen/blink/bindings/scripts --output-dir ../../../../../../out/Release/gen/blink/bindings/modules/v8 --interfaces-info ../../../../../../out/Release/gen/blink/bindings/modules/InterfacesInfoModules.pickle --write-file-only-if-changed 1 "../../../modules/webdatabase/Database.idl" 2014-09-22 03:17:59.684 ibtoold[8067:707] [MT] DVTAssertions: ASSERTION FAILURE in /SourceCache/IDEInterfaceBuilder/IDEInterfaceBuilder-5056/InterfaceBuilderKit/Document/IBDocument.m:1627 Details: Some objects didn't get the ibBeginArchivingDocument:withContext: callback. A class has probably overridden the method without calling through to super. missing objects: <NSTableHeaderView:0x7fb363b91650> IBCocoaDocument: <NSCustomObject:0x7fb363bf25d0> id=-2 <NSCustomObject:0x7fb363bf2670> id=-1 <NSCustomObject:0x7fb363bf2690> id=-3 <NSWindowTemplate:0x7fb363bf26d0> id=1 <NSView:0x7fb363bf29d0> id=2 relationship=contentView frame={{0, 0}, {480, 268}} <NSCustomView:0x7fb363bf2e90> id=36 relationship=ibDesignableContentView.ibShadowedSubviews frame={{269, -2}, {211, 52}} <NSButton:0x7fb363bf3e60> id=7 relationship=ibDesignableContentView.ibShadowedSubviews frame={{5, 12}, {96, 32}} layoutFrame={{11, 19}, {84, 21}} <NSButtonCell:0x7fb363bf3f30> id=8 relationship=cell <NSButton:0x7fb363bf3230> id=5 relationship=ibDesignableContentView.ibShadowedSubviews frame={{101, 12}, {96, 32}} layoutFrame={{107, 19}, {84, 21}} <NSButtonCell:0x7fb363bf3730> id=6 relationship=cell <NSCustomView:0x7fb363bf4370> id=40 relationship=ibDesignableContentView.ibShadowedSubviews frame={{0, 205}, {71, 32}} <NSTextField:0x7fb363bf4610> id=9 relationship=ibDesignableContentView.ibShadowedSubviews frame={{17, 6}, {50, 17}} layoutFrame={{20, 6}, {44, 17}} <NSTextFieldCell:0x7fb363bf4a70> id=10 relationship=cell <NSCustomView:0x7fb363bf7170> id=44 relationship=ibDesignableContentView.ibShadowedSubviews frame={{0, -2}, {139, 52}} <NSButton:0x7fb363bf73c0> id=3 relationship=ibDesignableContentView.ibShadowedSubviews frame={{14, 12}, {111, 32}} layoutFrame={{20, 19}, {99, 21}} <NSButtonCell:0x7fb363bf7630> id=4 relationship=cell <NSTextField:0x7fb363bf77c0> id=13 relationship=ibDesignableContentView.ibShadowedSubviews frame={{74, 210}, {386, 22}} <NSTextFieldCell:0x7fb363bf7890> id=14 relationship=cell <NSScrollView:0x7fb363bf7da0> id=67 relationship=ibDesignableContentView.ibShadowedSubviews frame={{20, 50}, {440, 147}} <NSOutlineView:0x7fb363bf8b70> id=69 relationship=documentView frame={{0, 0}, {438, 129}} <NSTableColumn:0x7fb363c75c80> id=72 relationships=(outlineTableColumn, ibShadowedTableColumns) <NSTextFieldCell:0x7fb363bf9880> id=73 relationship=dataCell <NSScroller:0x7fb363c019a0> id=71 relationship=verticalScroller frame={{423, 17}, {16, 129}} <NSScroller:0x7fb363c02a70> id=70 relationship=horizontalScroller frame={{1, 130}, {438, 16}} <NSCustomView:0x7fb363c028a0> id=90 relationship=ibDesignableContentView.ibShadowedSubviews frame={{0, 236}, {460, 32}} <NSTextField:0x7fb363c05f00> id=91 relationship=ibDesignableContentView.ibShadowedSubviews frame={{17, 5}, {216, 17}} layoutFrame={{20, 5}, {210, 17}} <NSTextFieldCell:0x7fb363c03c90> id=92 relationship=cell <NSCustomObject:0x7fb363c058d0> id=34 <NSCustomObject:0x7fb363bf26b0> id=37 <NSTreeController:0x7fb363c069f0> id=74 Object: <IBCocoaDocument: 0x7fb365803e00> Method: -willArchiveWithContext: Thread: <NSThread: 0x7fb361419330>{name = (null), num = 1} Hints: None Backtrace: 0 0x0000000108a75ac1 -[DVTAssertionHandler handleFailureInMethod:object:fileName:lineNumber:assertionSignature:messageFormat:arguments:] (in DVTFoundation) 1 0x0000000108a75519 _DVTAssertionHandler (in DVTFoundation) 2 0x0000000108a757ff _DVTAssertionFailureHandler (in DVTFoundation) 3 0x0000000107aae172 -[IBDocument willArchiveWithContext:] (in IDEInterfaceBuilderKit) 4 0x000000010e28773e IBCompileKeyedObjectsData (in IDEInterfaceBuilderCocoaIntegration) 5 0x000000010e28762e -[IBCocoaDocument compiledKeyedObjectsDataWithOptionserror:] (in IDEInterfaceBuilderCocoaIntegration) 6 0x000000010e287afa -[IBCocoaDocument internalCompiledPackageWithOptionserror:] (in IDEInterfaceBuilderCocoaIntegration) 7 0x0000000107ac67b1 __47-[IBDocument compiledPackageWithOptionserror:]_block_invoke (in IDEInterfaceBuilderKit) 8 0x0000000107aeb0c9 -[IBDocument assertIfArbitrationIsScheduledDuring:] (in IDEInterfaceBuilderKit) 9 0x0000000107ac6722 -[IBDocument compiledPackageWithOptionserror:] (in IDEInterfaceBuilderKit) 10 0x000000010789ef8b (in ibtoold) 11 0x00000001078a23ad (in ibtoold) 12 0x00000001078acb65 (in ibtoold) 13 0x00000001078ad0c0 (in ibtoold) 14 0x00000001078acf90 (in ibtoold) 15 0x00000001078ab3e7 (in ibtoold) 16 0x00000001078ac7b7 (in ibtoold) 17 0x00000001078abd6e (in ibtoold) 18 0x00007fff978607e1 start (in libdyld.dylib) ninja: build stopped: subcommand failed. Original issue's description: > Roll src/third_party/WebKit 08e97a9:38de67c (svn 182386:182399) > > Summary of changes available at: > https://chromium.googlesource.com/chromium/blink/+log/08e97a9..38de67c > > TBR=caseq@chromium.org,pdr@chromium.org,wjmaclean@chromium.org > > Committed: https://crrev.com/f838f453af2d146a6bdd0f960f2edce0c03d4c27 > Cr-Commit-Position: refs/heads/master@{#295946} TBR=caseq@chromium.org,pdr@chromium.org,wjmaclean@chromium.org,blink-deps-roller@chromium.org NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/590103002 Cr-Commit-Position: refs/heads/master@{#295947}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/08e97a9..38de67c TBR=caseq@chromium.org,pdr@chromium.org,wjmaclean@chromium.org Review URL: https://codereview.chromium.org/587233002 Cr-Commit-Position: refs/heads/master@{#295946}
-
hirono authored
The gap occures when a user moves the mouse cursor fast at the beginning of cropping. The reason the app uses the first mousemove event's coordinate as the beginning position of cropping. The CL uses the mousedown event's coordinate instead of the first mousemove's one. BUG=412237 TEST=manually Review URL: https://codereview.chromium.org/590073002 Cr-Commit-Position: refs/heads/master@{#295945}
-
dzhioev authored
Sometimes the screen starts to send updates to JS part to early, when screen is not registered yet. As a result several messages with context diffs could be ignored, and JS context became inconsistent with C++ context. I added 'contextReady' message, that is send from JS when context is ready to recieve updates. Before that the screen handler caches changes in the local context. BUG=375191 Review URL: https://codereview.chromium.org/581593003 Cr-Commit-Position: refs/heads/master@{#295944}
-
wensheng.he authored
Currently when analyze the memory usage details of the unhooked components, like unhooked-other, the dmprof expand command does nothing. The purpose of this patch is to enhance 'dmprof expand' command. As unhooked maps have no call stack traces, the result just filters MMAP_LIST items in *.heap files, which belongs to current component specified by the command parameter. R=kouhei@chromium.org BUG=416314 Review URL: https://codereview.chromium.org/587193002 Cr-Commit-Position: refs/heads/master@{#295943}
-
mgiuca authored
Previously, the images had padding to make them 32x32 (the size of the button). Now the button size is set programmatically, so the images can be as small as the actual graphic within. BUG=411775 Review URL: https://codereview.chromium.org/579093002 Cr-Commit-Position: refs/heads/master@{#295942}
-
v8-autoroll authored
TBR=machenbach@chromium.org Review URL: https://codereview.chromium.org/590833003 Cr-Commit-Position: refs/heads/master@{#295941}
-
xiang.long authored
Change worker script fetch error code in "Update" algorithm to align with spec: Non 2xx response will be rejected with NetworkError; Redirected response will be rejected with SecurityError; Reponse with Wrong MIME type will be rejected with SecurityError. (1/3): https://codereview.chromium.org/546353003/ (2/3): this (3/3): Layout test & Blink side cleanup BUG=408421 TEST=http/tests/serviceworker Review URL: https://codereview.chromium.org/567903002 Cr-Commit-Position: refs/heads/master@{#295940}
-
sdefresne authored
Followup to https://codereview.chromium.org/550503003 that missed //content/public/common/OWNERS. BUG=None Review URL: https://codereview.chromium.org/588493003 Cr-Commit-Position: refs/heads/master@{#295939}
-
loislo authored
It was a race between animation scheduled by WebTestProxyBase and ResourceLoader which received the test script content. In case of failure I see the next sequence of top level events: 1) RootGraphicsLayer was cleared 2) html resource arrived and animation was scheduled 3) js resource arrived, onload event handler was called and the test finished in the ASSERT The expected sequence of top level events: 1) RootGraphicsLayer was cleared 2) html resource arrived and animation was scheduled 3) scheduled animation was executed 4) js resource arrived, onload event handler was called and the test finished successfully The simplest solution is to run pending animations. BUG=397321 Review URL: https://codereview.chromium.org/581983002 Cr-Commit-Position: refs/heads/master@{#295938}
-
rijubrata.bhaumik authored
This is part 2 of the Adding Device Light [content side] Adding the Browser and Java part in the content side for the DeviceLight API. BUG=336424 Review URL: https://codereview.chromium.org/292693004 Cr-Commit-Position: refs/heads/master@{#295937}
-
jochen authored
0c53324 Invoke V8::Initialize() explicitly during V8 setup c5cab02 Add FPDF_GetSecurityHandlerRevision TBR=jam@chromium.org BUG=none Review URL: https://codereview.chromium.org/588113003 Cr-Commit-Position: refs/heads/master@{#295936}
-
perkj authored
NOTRY=true Review URL: https://codereview.chromium.org/583183003 Cr-Commit-Position: refs/heads/master@{#295935}
-
mgiuca authored
Buttons are now 39x39, giving them bigger click/tap target zones, spacing them further apart, and centering them within the switcher area. The actual image sizes have not changed. Moved the separator line up 1px to make room and to match the mocks. Also added a new test of the exact dimensions of the app launcher, to make sure we don't accidentally enlarge the window (which would have been easy to accidentally do in this patch). BUG=411775 Review URL: https://codereview.chromium.org/581923002 Cr-Commit-Position: refs/heads/master@{#295934}
-
mithro authored
Adding -gdwarf-4 to make DWARF-4 the output format. * gcc 4.6 outputs DWARF-2 by default * gcc 4.7 outputs DWARF-4 by default * clang <3.4 outputs DWARF-3 by default * clang >3.4 outputs DWARF-4 by default DWARF-4 is the latest debug output format which includes features for macro-expansion, better var tracking and other similar options. From http://gcc.gnu.org/onlinedocs/gcc/Debugging-Options.html > -gdwarf-4 > Produce debugging information in DWARF format (if that is > supported). The value of version may be either 2, 3 or 4; the > default version for most targets is 4. Note that with DWARF > Version 2, some ports require and always use some non-conflicting > DWARF 3 extensions in the unwind tables. > > Version 4 may require GDB 7.0 and -fvar-tracking-assignments for > maximum benefit. BUG= Review URL: https://codereview.chromium.org/198363002 Cr-Commit-Position: refs/heads/master@{#295933}
-
alekseys authored
BUG=397741 Review URL: https://codereview.chromium.org/587013003 Cr-Commit-Position: refs/heads/master@{#295932}
-
chromeos-commit-bot authored
Cr-Commit-Position: refs/heads/master@{#295931} -
shreeram.k authored
Skipping the test case for source tag. This might be failing because still there are issues related with audio tags control attribute. BUG=411987 Review URL: https://codereview.chromium.org/585093004 Cr-Commit-Position: refs/heads/master@{#295930}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/8bc0f5b..08e97a9 TBR= Review URL: https://codereview.chromium.org/586423002 Cr-Commit-Position: refs/heads/master@{#295929}
-
