- 16 Apr, 2020 40 commits
-
-
Xianzhu Wang authored
To highlight layers that can't use LCD-text. Only layers containing text will be highlighted. The visualization helps us find which layers can be candidate of improving LCD-text. Bug: 642885 Change-Id: I7c4c24c1d0e63ce016bef1bffbfe135ea1afe0b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147930 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#759732}
-
Steve Kobes authored
Bug: 1053510 Change-Id: I221a5ab7c4ea2eec9b951d8512a39de7edf119fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151838Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#759731}
-
Dan Harrington authored
Will be used for action upload. Bug: 1044139 Change-Id: I9dedc4148cc2f14e76fafdd357b3fd4460f8a3d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151342Reviewed-by:
Ian Wells <iwells@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#759730}
-
kylechar authored
GpuChannelManager::RemoveChannel() removes the map entry for a GpuChannel and destroys the GpuChannel at the same time. This is problematic because the GpuChannel destructor can trigger context loss which leads back to GpuChannelManager::LoseAllContexts(). That will iterate over |gpu_channels_| in the middle of removing an element. Fix by removing the map entry first and then deleting the GpuChannel object. This is already done in DestroyAllChannels() for the same reason. Bug: 1067642 Change-Id: I5ccba54151686726b24af97a06c0bd7bf7f06d5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152767Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#759729}
-
Yusuke Sato authored
Now code in Chromium is the master, and the one in platform2 is just a mirror. BUG=None TEST=No real code change Change-Id: Ic29f281f1b95e057403f335e53d43dbc5606450d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151842Reviewed-by:
Long Cheng <lgcheng@google.com> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#759728}
-
Sebastien Lalancette authored
For now, the triggering of the alert still goes through BVC. This will change in a following CL, where triggering the alert will all be done under ActivityServiceLegacyCoordinator' scope. Bug: 1068606 Change-Id: Id27f298d1c71dd02c6f1c38cd8b370697b09dfeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151106 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#759727}
-
Xianzhu Wang authored
This reverts commit fc46d7d7. Reason for revert: Fixed telemetry_perf_unittests. Original change's description: > Revert "Collect reasons of disallowing LCD text" > > This reverts commit b79724f8. > > Reason for revert: Causing flaky failures in Mac10.14 Tests bot. > > First failure here: > https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests/3374 > > > telemetry_perf_unittests on (none) GPU on Mac failed because of: > measurements.rasterize_and_record_micro_unittest.RasterizeAndRecordMicroUnitTest.testRasterizeAndRecordMicro > > > > Original change's description: > > Collect reasons of disallowing LCD text > > > > (TBR for passive change in tools/perf/measurements/rasterize_and_record_micro.py.) > > TBR=wangxianzhu@chromium.org > > R=pdr@chromium.org > > > > Bug: 642885 > > Change-Id: Ia5c8313ea9e34139e06ff11fcc5d751ff0768c75 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149914 > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > Reviewed-by: Philip Rogers <pdr@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#759474} > > TBR=wangxianzhu@chromium.org,pdr@chromium.org > > Change-Id: Ic25a88c23e6f504461d3100fbf3bc8f8429c81f2 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 642885 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151450 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#759562} TBR=wangxianzhu@chromium.org,pdr@chromium.org,guidou@chromium.org Change-Id: Ica3073d071e43b76f763012a2bc6c8403c0695a0 Bug: 642885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152771Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#759726}
-
Devlin Cronin authored
Introduce a common views::test::WidgetVisibleWaiter helper class to enable tests to easily wait for a given widget to become visible, and use it in place of places that had similar functionality. Bug: None Change-Id: I4fda7baeef12ae33f47a47393a58396f917b65e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151343Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759725}
-
Mei Liang authored
Because TabContextObserver listens to TabModel changing events to invalidate TabSuggestion, closing the selected tabs before running the TabSuggestionFeedback callback results in using a null TabSuggestion for the callback. This CL addresses the null usage by running the callback before closing the selected tabs. Change-Id: I5f827d7cc6fb8d684f436b6dc30681086bc81aa7 Bug: 1063821, 1061991 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147878Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#759724}
-
Oksana Zhuravlova authored
This change removes RenderFrameImplHost::registry_ since it's no longer used and updates the early return condition in SetUpMojoIfNeeded() to check associated_registry_ instead. Bug: 718652 Change-Id: I1807918dcf1c28fd52b76a77b186745daaac9e86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149697Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#759723}
-
Natalie Chouinard authored
Build SettingsActivityTestRule as a dep of chrome_java_test_support target so that it can be used by modularized test targets without causing dependency cycles with //chrome/android:chrome_test_java. Change-Id: Iffb515092ec8246a1df89c9b57b15fd7246bf07d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151179Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#759722}
-
Erik Jensen authored
Python 2 has reached its end of life. Bug: 1067546 Change-Id: Id6830e890372cc4d91f4bb4149506c455945dba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151174Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Cr-Commit-Position: refs/heads/master@{#759721}
-
Tommy Li authored
This CL styles the header text closer to the mocks. It's getting there. At least the color and uppercasing is correct. The designer also said that using OS fonts is preferable. Bug: 1052522 Change-Id: I14aed65e109dc68caa6fcf1ac9c1c804424e5258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151547 Auto-Submit: Tommy Li <tommycli@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#759720}
-
Matt Menke authored
We want to get rid of the single argument AddHeader() method as the two argument AddHeader() and SetHeader() methods are safer and more flexible. Bug: 1068194 Change-Id: I2a51b9ca2162b772f3a259e8568f7d1f98c08ba7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149629 Auto-Submit: Matt Menke <mmenke@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#759719}
-
Natalie Chouinard authored
Change-Id: I4ed07473a67a8048ba77052fbc1e11681c0f8f1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144363 Auto-Submit: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#759718}
-
Christoph Schwering authored
This CL introduces strong aliases FormRendererId and FieldRendererId which wrap uint32 renderer IDs. Bug: 896689, 1007974 Change-Id: I11e3efa786aec5e8896d1cb34761b38d8e774986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141990 Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#759717}
-
Chromium WPT Sync authored
Using wpt-import in Chromium fa62c9de. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." 6c8523d2 "[scroll-timeline] Implement element-based scroll offset" f93fa6fd "[css-grid] Migrate grid-item-margin-auto-columns-rows-vert-rl to WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools jsbell@chromium.org: external/wpt/resources yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: If352d97ae657e5fe1dc82bb520524b49b26517c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151969Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759716}
-
Olivier Robin authored
The main thread test interfers with the EarlGrey synchromization. If a tests enables metrics, any subsequent sync will wait forever. Disable MainThreadFreezeDetection on tests. Bug: 1070286 Change-Id: I96381b423f9915f22015bfe1af264e3ce51697ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151517Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759715}
-
Wez authored
Introduce a "web-engine" annotation namespace, and provide the Chromium "version" from which the web-engine package was built. Additional fields will be provided in follow-up CLs. Other packages published by Chromium may have similar annotations added using package-specific namespaces. Bug: 1063393 Change-Id: I122a29f9cec5ad8747a5952c6be0531696c084fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149328 Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759714}
-
Brian Salomon authored
Changes slightly after change to Skia displacement filter code. Bug: skia:10139 Change-Id: I4672582afb163ae857e6acc2807d45eca4fa0849 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153326 Commit-Queue: Brian Salomon <bsalomon@google.com> Commit-Queue: Michael Ludwig <michaelludwig@google.com> Auto-Submit: Brian Salomon <bsalomon@google.com> Reviewed-by:
Michael Ludwig <michaelludwig@google.com> Cr-Commit-Position: refs/heads/master@{#759713}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d059dfbc06e0..dff792591fb9 git log d059dfbc06e0..dff792591fb9 --date=short --first-parent --format='%ad %ae %s' 2020-04-16 eshr@google.com Remove VideoStreamEncoderObserver::AdaptationReason::kNone Created with: gclient setdep -r src/third_party/webrtc@dff792591fb9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: If9d12e4cafb9b3dce7f702be8b04ab66f335c947 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152868Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759712}
-
Ben Pastene authored
profile_provider_unittest is a big target, and takes some time to build: https://chromium-build-stats.appspot.com/ninja_log/2020/04/15/luci-chrome-ci-xenial-us-west1-c-highmem-16-1-jm5p/ninja_log.luci-chrome-ci-xenial-us-west1-c-highmem-16-1-jm5p.chrome-bot.20200415-113309.9739.gz/trace.html By moving it into //:gn_all, we can speed up the build time of //:chromiumos_preflight while still allowing bots that run the test to find the target. Change-Id: I5881faf0b11a22899f8639c55dc28dd554cd8906 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150815Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#759711}
-
Yusuf Sengul authored
Bug: 1071326 Change-Id: I77b95cf30552cd87dbb8b921b66f9a7636efe5fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152215Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Commit-Queue: Yusuf Sengul <yusufsn@google.com> Cr-Commit-Position: refs/heads/master@{#759710}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a0a377b4..6cb05cce Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I34852b328f76d140b3f873192f05cc14b0afd190 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152606Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759709}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9036394cfefb..7027d3e67c45 git log 9036394cfefb..7027d3e67c45 --date=short --first-parent --format='%ad %ae %s' 2020-04-16 lalitm@google.com tp: add parent slice id to slice table Created with: gclient setdep -r src/third_party/perfetto@7027d3e67c45 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:153450605 Tbr: perfetto-bugs@google.com Change-Id: I4616b223a22e85ef6edc6c72b618295db0f7d03d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151434Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759708}
-
Guido Urdaneta authored
Disable several P2PQuicTransportMockConnectionTests that are failing on many bots. Bug: 1071340 Change-Id: I353863488e2cf3357eb167539cb3c7908a1407f5 TBR: ianswett@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153066Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#759707}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/ab983012a2d4..514232c46d65 git log ab983012a2d4..514232c46d65 --date=short --first-parent --format='%ad %ae %s' 2020-04-16 bclayton@google.com VkSemaphore: Unlock/Lock the mutex outside the blocking_call. 2020-04-16 bclayton@google.com Regres: Include a better error message when git add fails. 2020-04-16 bclayton@google.com Regres: Avoid dereferencing a nil on process timeout. Created with: gclient setdep -r src/third_party/swiftshader@514232c46d65 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I420453664ba81032b803243ff03493f8c8994bdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152709Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759706}
-
Annie Sullivan authored
Shift csharrison down in hopes of spreading out the reviewer load a little. Change-Id: Iacac4dd0103c07d7505336d312dbf60152d03783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151484 Commit-Queue: Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#759705}
-
Pavel Yatsuk authored
The crash in crbug.com/1066814 indicates that Toast.show() was called on the same toast object twice. Code pattern, where toast object is retained between callbacks, allows for such scenario. In this CL I change logic to cancel old toast and create a new instance before calling Toast.show(). BUG=1066814 Change-Id: I9694d465a500202920cf23104eccf89c1176cb94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151853Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#759704}
-
Brian Sheedy authored
Optimizes the Android Skia Gold code in the following ways: 1. Adds an "Initialize" step and shuffles arguments around so that goldctl only has to initialize the working directory once instead of every time a comparison is performed, saving ~250ms per comparison. 2. Because #1 causes each session to only be valid for a single instance/corpus/keys_file combination, adds SkiaGoldSessionManager to lazily create sessions as necessary. 3. Short circuits the "Authenticate" step if the session is already authenticated, saving ~40ms per comparison. Change-Id: I72677ec8b0a0a3757ce198e8b8e1d34be7b74257 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148153Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#759703}
-
Chris Mumford authored
Corrected indent to be four spaces IAW the style guide. Doing this makes all Python scripts uniformaly formatted in //third_party/sqlite/scripts. Bug: None Change-Id: I476654c330bf957e0ad65d46c44df53e1eacdf2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150236Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#759702}
-
Robert Flack authored
Bug: 730065 Change-Id: I60f2dc628d00c0cf9c70bdff417f5c8cc07f8243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112981Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#759701}
-
Kevin Ellis authored
CSS animations require property-value pairs for the first and last keyframe for all animated properties. This patch adds tracking of when missing properties should be inserted and lazily calculates the property values as required in getKeyframes. Bug: 1068332 Change-Id: I29fdca2a393a115672c682fd7377416a7869971f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137510Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#759700}
-
Ken Rockot authored
When a FilesystemProxy is given an empty root path in UNRESTRICTED mode, it expects all API calls to receive absolute paths only. This constraint was imposed under the assumption that no existing LevelDB ChromiumEnv users were using relative paths (and thus creating persistent databases in the arbitrary current working directory). Well that turned out to be a bad assumption. This changes FilesystemProxy so that when given an empty root, it resolves relative paths against the current working directory. Fixed: 1071158 Change-Id: I52f48394ba65d66ebdc072d7b40951c6dfa29534 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151311 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#759699}
-
Devlin Cronin authored
Waiting for a state and waiting for an event are subtly different: for an event, the waiter *must* be constructed before the event is fired (or else will spin forever), whereas for a state, a waiter may be constructed at any point (because the state can be queried). Update the docs with this differentiation and an example. Bug: None Change-Id: Ice984ee861df46d9010986e72779639e6c19e400 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151470 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#759698}
-
Koji Ishii authored
|NGInlineCursor::MoveToItem| consumes 4.11% of total time in perf_tests/layout/chapter-reflow.html. One of its frequent caller is |MakeNull|. This patch optimizes |MakeNull| not to use |MoveToItem|. Bug: 982194 Change-Id: I3d8bef0bd40b0c8ad1bac8f5a296ce7e0cd1bde2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151773 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759697}
-
Esmael El-Moslimany authored
Bug: 1071009 Change-Id: I47fbb65bdf8adeea437e919b476ee8f1d3caafdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152003Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#759696}
-
Justin Donnelly authored
Change-Id: Icd693ebb3a68a8e1cddbfa686ccf2df904b7ba64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147371 Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#759695}
-
Guido Urdaneta authored
It is failing consistently on some Linux bots. Bug: 1071403 Change-Id: Icd58e5223373b0d9a0161e1477e35941ca21766e TBR: karandeepb@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152805 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#759694}
-
Dan Harrington authored
Note that I've chosen to NOT use 'next_stream_state'. Instead, we load the data similar to the way we load data when doing the initial load. Doing it this way is simpler, but will limit us to doing background refreshes only when there are no attached surfaces. Bug: 1044139 Change-Id: I304a7ba158e6a9c7e333606f63c50c947216638a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145933Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#759693}
-