- 17 Nov, 2017 40 commits
-
-
Johann authored
https://aomedia.googlesource.com/aom.git/+log/08b26a8a257e..535ecf6b31fe $ git log 08b26a8a2..535ecf6b3 --date=short --no-merges --format='%ad %ae %s' 2017-11-15 jzern av1_txfm,round_shift: remove implicit conv warning 2017-11-13 huisu Fix integer overflows in av1_iidentity*_c() 2017-11-13 huisu Fix int overflow in decode_coefs() Created with: roll-dep src/third_party/libaom/source/libaom R=jzern@chromium.org Change-Id: I872329cccab87a81683a8359e2dfde63f2e49bf5 Reviewed-on: https://chromium-review.googlesource.com/776240Reviewed-by:
Tom Finegan <tomfinegan@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#517495}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/feee08f4da81..12ab00b4d856 $ git log feee08f4d..12ab00b4d --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Id803bbe8056b4792c81a59b685c6e6d3d481a624 Reviewed-on: https://chromium-review.googlesource.com/776241Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#517494}
-
Sergey Volk authored
CMA backends might choose to implement GetCurrentPts in such a way that it reports the current position to be kStartPts immediately after Start(kStartPts) is called, rather then after playback actually starts, and that should be ok. Bug: none Test: cast_media_unittests Change-Id: I4e232504c0a664fb0e715eed96982c2a6d62b2e2 Reviewed-on: https://chromium-review.googlesource.com/775873Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Sergey Volk <servolk@chromium.org> Cr-Commit-Position: refs/heads/master@{#517493}
-
Lei Tian authored
Use TabPersistentStoreObserver.onMetadataSavedAsynchronously to background the Browser Actions tab creation service Change the logic to background the Browser Actions tab creation service based on TabPersistentStoreObserver.onMetadataSavedAsynchronously. The callback indicates that tab model lists are backuped so the saved tabs can be restored succesfully. Also for the notification when a new tab has not been created (tabId is not available), the Intent to bind the notification will be a VIEW intent. This notification is necessary to make the service foreground. Bug: 766349 Change-Id: I73d49e2a1e26410b2dd6e51a07f35e9965b9a38a Reviewed-on: https://chromium-review.googlesource.com/769852Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Lei Tian <ltian@chromium.org> Cr-Commit-Position: refs/heads/master@{#517492}
-
Yuke Liao authored
This reverts commit 02bddfd9. Reason for revert: NavigationCallbacksTest.FailedNavigation is failing on devices, and only devices, both iPhones and iPads with iOS 10 and iOS 11. Original change's description: > Fixed Navigation callbacks for failed provisional navigation. > > Verified callbacks correctness with > NavigationCallbacksTest.FailedNavigation integration test. > > Before this CL DidStartNavigation was called twice (second time > for presenting error in Native Content). DidFinishNavigation was > called once (also for presenting NativeContent). First > DidStartNavigation did not have a matching DidStartNavigation > call. > > This CL removes DidStartNavigation/DidFinishNavigation callbacks > for for presenting error in Native Content and adds balanced > DidFinishNavigation callback in handleLoadingError:. > > Bug: 725241 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: Id15ef8c9422e571f74f9c00bf88ea98ccbf6607c > Reviewed-on: https://chromium-review.googlesource.com/758718 > Commit-Queue: Eugene But <eugenebut@chromium.org> > Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517420} TBR=eugenebut@chromium.org,kkhorimoto@chromium.org Change-Id: I76bc2987780795fd72284b22203e945387f04c53 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 725241 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/777279Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#517491}
-
Andrew Grieve authored
Also refactors our proguard wrapper a bit by having it: * Ensure all outputs exist before short-circuiting * Only touch missing files after building (avoids creating 0-length files for a failed run). Change-Id: Ie57a925a9258dd9c304e7af4bcccaf94b24b1129 Reviewed-on: https://chromium-review.googlesource.com/770790Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#517490}
-
dpapad authored
This fixes a crash where the user could still request a profile reset while one was already in progress, by closing and re-opening the dialog. Bug: 616089 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia99f6ceea4d6f3c1ba797ba47affc42804c3fd5f Reviewed-on: https://chromium-review.googlesource.com/772939Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#517489}
-
Min Qin authored
TBR=dtrainor@chromium.org Bug: Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I8e277d2ab135195a2848b07f6bd922fe5dc392c3 Reviewed-on: https://chromium-review.googlesource.com/777032Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#517488}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/2c7f34c833b4..3d70ca9cc194 $ git log 2c7f34c83..3d70ca9cc --date=short --no-merges --format='%ad %ae %s' 2017-11-10 oetuaho Remove unreferenced variables from the AST Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I2fe389880ad4ff0c131fff6b21cd668f8d9d8e16 Reviewed-on: https://chromium-review.googlesource.com/776648Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#517487}
-
Dominic Mazzoni authored
This fixes a regression where just clicking on text in some live regions caused it to announce. The problem was that we rewrote live region event firing (crrev.com/2957973003) and made it fire an event it any time a node in a live region was updated, but we need to limit the scope to only: * A node with text is added * A node with text is removed * A node's text changes Added some new tests and more Windows test expectations to cover this, and also manually tested this page to make sure everything there continues to work: https://minorninth.github.io/aria-live-region-tests/live_region_tests.html Bug: 785347 Change-Id: Id6fea0f32695234edbbf1493b7dfa40111e5f6a3 Reviewed-on: https://chromium-review.googlesource.com/772290 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#517486}
-
Yuke Liao authored
This reverts commit 220c3a64. Reason for revert: DownloadTaskImplTest.* are failing again on iOS 11 devices: For example: DownloadTaskImplTest.FailureInTheBeginning: ../../ios/web/download/download_task_impl_unittest.mm:321: Failure Value of: session_task Actual: false Expected: true ../../ios/web/download/download_task_impl_unittest.mm:319: Failure Actual function call count doesn't match EXPECT_CALL(task_observer_, OnDownloadUpdated(task_.get()))... Expected: to be called once Actual: never called - unsatisfied and active unknown file: Failure Uninteresting mock function call - returning directly. Function call: OnTaskDestroyed(0x101752170) Original change's description: > Reland DownloadTaskImpl implementation for //ios/web Download API. > > This CL implements DownloadTask public interface. > > DownloadControllerImpl CL: crrev.com/c/758525 > Design doc: http://go/ios-web-download-api > > Bug: 780646 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: Iffea44bfb64cc945f7d899dd7181556a730394f1 > Reviewed-on: https://chromium-review.googlesource.com/775889 > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Commit-Queue: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517424} TBR=sdefresne@chromium.org,eugenebut@chromium.org Change-Id: I254a9d8856c29bbe228a2dc96838536dd23e5a35 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 780646 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/777063Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#517485}
-
Jose Dapena Paz authored
This is a fix for a regression introduced by this jumbo fix: commit b1622826 Author: Mostyn Bramley-Moore <mostynb@vewd.com> Date: Wed Nov 15 07:05:13 2017 +0000 [jumbo] avoid ToBrowserAccessibilityAuraLinux redefinition The change reuses the BrowserAccessibilityAuraLinux AtkAction casting for BrowserAccessibilityAtkHyperlink. But it is not the same object, and it will break the hyperlink action support. So let's provide again a specific casting, but with a name that will not clash with jumbo build. Bug: 783447 Change-Id: I319154aadd5aa040a2222d533ca94cb83877068e Reviewed-on: https://chromium-review.googlesource.com/776778Reviewed-by:
Mostyn Bramley-Moore <mostynb@vewd.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Cr-Commit-Position: refs/heads/master@{#517484}
-
Dominic Mazzoni authored
Original: https://chromium-review.googlesource.com/c/chromium/src/+/642056 Reverted: https://chromium-review.googlesource.com/c/chromium/src/+/688354 Fix just required rebaselining some tests. For historical reasons, the ARIA role "combobox" is misused and misunderstood. It can be one of three things: 1. A fully editable text field that also has a drop-down list of possible options 2. A button that opens to reveal a mutually-exclusive list of choices (but with no text field anywhere) 3. A grouping container with a text field and a drop-down list inside The only platform where this mostly worked was on Windows, where "combo box" is a native control. On Mac and Android, we need to treat #1 as a text field primarily, and #2 more like a button, since there's no equivalent that acts as both. Bug: 516869, 666049, 546051 TBR: dtseng, aleventhal, michaelpg Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Idd47a98b396cf8862bde000af43c447d2b9fa921 Reviewed-on: https://chromium-review.googlesource.com/692704Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#517483}
-
Johann authored
Change-Id: Iad4faae02b7a8939b8ede8488bc3239bbec27774 Reviewed-on: https://chromium-review.googlesource.com/763812Reviewed-by:
Tom Finegan <tomfinegan@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#517482}
-
Sergey Volk authored
Bitstream conversion must be enabled for the media playback of AAC, H.264 and HEVC media streams. Mojo renderer does this by default. Bug: none Test: cast_media_unittest on Luther now plays AAC files Change-Id: I4e5cd522a52dc7954a5d187251366ff6ac360d18 Reviewed-on: https://chromium-review.googlesource.com/776217Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Sergey Volk <servolk@chromium.org> Cr-Commit-Position: refs/heads/master@{#517481}
-
Ryan Hamilton authored
BUG=783897 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id5ef2b72cd73f2fbdbb49ab2f3dab590a9e3b3d2 Reviewed-on: https://chromium-review.googlesource.com/767153 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Buck Krasic <ckrasic@chromium.org> Cr-Commit-Position: refs/heads/master@{#517480}
-
Theresa Wellington authored
Check if the sheet is open, layout manager is null, or overview is visible inside the tracker initialization callback in case state has changed during tracker intialization. BUG=786251 Change-Id: I5cbfa00a98f06a02e9145f569c096595243f35cd Reviewed-on: https://chromium-review.googlesource.com/777119Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#517479}
-
Eugene But authored
This reverts commit 02bddfd9. Reason for revert: Breaks device bots tests Original change's description: > Fixed Navigation callbacks for failed provisional navigation. > > Verified callbacks correctness with > NavigationCallbacksTest.FailedNavigation integration test. > > Before this CL DidStartNavigation was called twice (second time > for presenting error in Native Content). DidFinishNavigation was > called once (also for presenting NativeContent). First > DidStartNavigation did not have a matching DidStartNavigation > call. > > This CL removes DidStartNavigation/DidFinishNavigation callbacks > for for presenting error in Native Content and adds balanced > DidFinishNavigation callback in handleLoadingError:. > > Bug: 725241 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: Id15ef8c9422e571f74f9c00bf88ea98ccbf6607c > Reviewed-on: https://chromium-review.googlesource.com/758718 > Commit-Queue: Eugene But <eugenebut@chromium.org> > Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517420} TBR=eugenebut@chromium.org,kkhorimoto@chromium.org Change-Id: I6c21310e2f1893fead293ca3808b680a4ae910b0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 725241 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/777240Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#517478}
-
Ryan Hamilton authored
Protected by enabled flag FLAGS_quic_reloadable_flag_quic_truncate_long_details. merge internal change: 175959960 BUG=785223 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id7e15f179c7db5a19e86ddb9b474d96d2bd14342 Reviewed-on: https://chromium-review.googlesource.com/773405 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#517477}
-
Yuke Liao authored
This reverts commit 26a439d2. Reason for revert: This CL is causing downstream DEPS failure. Failure message: ERROR in /b/build/slave/simulator-builder/build/src/ios/web/service_manager_connection_impl.cc Illegal include: "services/service_manager/embedder/embedded_service_runner.h" Because of no rule applying. Illegal include: "services/service_manager/runner/common/client_util.h" Because of no rule applying. ERROR in /b/build/slave/simulator-builder/build/src/ios/web/service_manager_context.mm Illegal include: "services/catalog/manifest_provider.h" Because of no rule applying. Illegal include: "services/service_manager/connect_params.h" Because of no rule applying. Illegal include: "services/service_manager/embedder/manifest_utils.h" Because of no rule applying. Illegal include: "services/service_manager/runner/common/client_util.h" Because of no rule applying. Illegal include: "services/service_manager/service_manager.h" Because of no rule applying. ERROR in /b/build/slave/simulator-builder/build/src/ios/web/public/browser_state.h Illegal include: "services/service_manager/embedder/embedded_service_info.h" Because of no rule applying. ERROR in /b/build/slave/simulator-builder/build/src/ios/web/public/service_manager_connection.h Illegal include: "services/service_manager/embedder/embedded_service_info.h" Because of no rule applying. ERROR in /b/build/slave/simulator-builder/build/src/ios/web/public/web_client.h Illegal include: "services/service_manager/embedder/embedded_service_info.h" Because of no rule applying. FAILED Example: https://uberchromegw.corp.google.com/i/internal.bling.main/builders/simulator-builder/builds/17706. Original change's description: > Tighten DEPS allowances on //services in //ios > > Several DEPS entries were allowing dependencies on the internals of a > service. This CL tightens those DEPS down. Note that a couple are left: > this is intentional, as in those cases the services in question are > actually being embedded in the dependent. > > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: I7e91f08559399997059c4c81dd7857e19c776175 > Reviewed-on: https://chromium-review.googlesource.com/776695 > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Commit-Queue: Colin Blundell <blundell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517422} TBR=blundell@chromium.org,sdefresne@chromium.org Change-Id: Ia31536a911d8f9912e1bb9c2ce1cad8377910da9 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/777239Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#517476}
-
Ian Vollick authored
Currently, when the audio permission prompt is shown, the UI is drawn disabled, but because some of it juts further out toward the user than the backplane, you can still interact with this UI. Bug: None Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Id3ce1c09b7091cbe955e02abec15198db2355a93 Reviewed-on: https://chromium-review.googlesource.com/776621Reviewed-by:
Amirhossein Simjour <asimjour@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#517475}
-
Christos Froussios authored
Filling will trigger JS events, which can be interpreted by the page as a change in the values. Bug: 784391 Change-Id: I4e9fa8a6ef6a35d545aabd91725e18c69599c77d Reviewed-on: https://chromium-review.googlesource.com/771634Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#517474}
-
Lei Zhang authored
Change-Id: I8347edc5893e51df581dab388b72130f5473d14f Reviewed-on: https://chromium-review.googlesource.com/775042Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#517473}
-
Roman Sorokin authored
For Active Directory users we try to use password to get TGT both from the pod screen and from online auth. Latter is redundant. BUG=chromium:786412 TEST=manual Change-Id: Ia586014ddb1c04f33ae026f08ea5569fcad5786e Reviewed-on: https://chromium-review.googlesource.com/776667Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#517472}
-
Yuta Kitamura authored
Upon landing of <http://crrev.com/c/765749>, which tightened up the threading check of WTF::Function, a few assertion failures were reported. The stack traces indicated closures for swap promises (in PaintTiming.cpp and FirstMeaningfulPaintDetector.cpp) might end up getting destructed on the compositor thread. To allow this, WTF::CrossThreadBind() must be used instead of WTF::Bind(). Bug: 786194 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I9252eff15ca00e1bc0dfc8f87629ccb9acb56714 Reviewed-on: https://chromium-review.googlesource.com/776343Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
enne <enne@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#517471}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/ba6a850bbb5b..37921f135dc6 $ git log ba6a850bb..37921f135 --date=short --no-merges --format='%ad %ae %s' 2017-11-17 bokan Clarify comment for mean_pixels_approximated means Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I1f9f63fc69bc3b5a147238a2a17ba082bbd8ea6e Reviewed-on: https://chromium-review.googlesource.com/776649 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#517470}
-
Katie Dektar authored
Adds sandbox google docs link to the manifest so that aria-hidden will be removed there too. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iba412f3a1f35a09d3dd403474eb02186c361e2b1 Reviewed-on: https://chromium-review.googlesource.com/775517 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#517469}
-
kylechar authored
With the display compositor running in the GPU process, we need to send a unique id from the host process to the GPU process to ensure that BeginFrameSource::source_ids_ are different after process restart. Pass this value along with the other arguments needed to create a viz::FrameSinkManagerImpl. |restart_id| is plumbed into DelayBasedBeginFrameSources that are created for each viz::Display. There are other BeginFrameSources that are created in the GPU process, but these BeginFrameSources don't produce BeginFrameArgs so their source_id isn't used and isn't important. Bug: 782268 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ie3bd4f6bf3a9ba97d370969cae3d7faa396a0f43 Reviewed-on: https://chromium-review.googlesource.com/766512 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#517468}
-
Lei Zhang authored
TBR=reveman@chromium.org,dgozman@chromium.org,lfg@chromium.org,sdefresne@chromium.org,rockot@chromium.org Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2b94ac88777958e132dce4772fda9ba12320c560 Reviewed-on: https://chromium-review.googlesource.com/771053 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#517467}
-
Theresa Wellington authored
BottomToolbarPhone sets tint on its background drawable. Call mutate to avoid sharing state with other uses of modern_toolbar_background.xml. BUG=786283 Change-Id: Ia8ab7000297d03f03edf612dc49047290ae4346f Reviewed-on: https://chromium-review.googlesource.com/777039Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#517466}
-
Tom Sepez authored
This is a small bit of overdue tidying, in that the flags should be in the header with the method that returns them. Change-Id: I8f9e8290a3ec36b53fa64ca69fcc3a11ac3b0e7c Reviewed-on: https://chromium-review.googlesource.com/773508Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#517465}
-
Michael Thiessen authored
The GVR crash has been fixed, so we can remove our workaround (which was to wait 10 seconds before allowing re-entry into VR) The workaround was added in https://chromium-review.googlesource.com/c/chromium/src/+/624294 Bug: 759575 Change-Id: Iad46c0575d15c1eb7d67d46253eea50294243ae8 Reviewed-on: https://chromium-review.googlesource.com/776620 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#517464}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/57e0828fade9..3e4d1fde7fab $ git log 57e0828fa..3e4d1fde7 --date=short --no-merges --format='%ad %ae %s' 2017-11-17 angle-deps-roller Roll skia/third_party/externals/angle2/ 1eda27a65..2c7f34c83 (2 commits) 2017-11-17 scroggo Fix webp bug compositing alpha frames on opaque (better fix) Created with: roll-dep src/third_party/skia BUG=735497,784078 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: I1f45988b72e5268b343dd4f575c23bb0c8ed51fc Reviewed-on: https://chromium-review.googlesource.com/776644Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#517463}
-
Quinten Yearsley authored
This CL: - renames "test-expectations.html" so that it is called "results.html" - renames the old results.html to be "legacy-results.html" blink-dev thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/9NFDSTEzcd4 Bug: 748628 Change-Id: Id8293ed24f680b71cf1bdb3e134cdb130154ee14 Reviewed-on: https://chromium-review.googlesource.com/775973 Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#517462}
-
Michael Thiessen authored
The GVR bugs have been fixed, we can remove our workaround. Workaround was added in https://chromium-review.googlesource.com/c/chromium/src/+/682107 Bug: 769005 Change-Id: I2ff8edc388de04fa2c4f662406ab7687c13eb88e Reviewed-on: https://chromium-review.googlesource.com/775864 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#517461}
-
Ran Ji authored
Add an extra to the intent that sent to CCT to indicate where it comes from. Currently the extra is only set by Webapp/WebApk Bug: 769728 Change-Id: I38ddbf9a5e797e602513de098a890645419d90c3 Reviewed-on: https://chromium-review.googlesource.com/751302Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Ran Ji <ranj@chromium.org> Cr-Commit-Position: refs/heads/master@{#517460}
-
Francois Doray authored
The "MinimumProtectionTime" field trial has expired. Not having to read the "AllowMultipleDiscards" param of this field trial will simplify the TabManager refactor. Bug: 775644 Change-Id: Ide53247821bc9753fe8d6ba27614d3591384cbed Reviewed-on: https://chromium-review.googlesource.com/771545 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#517459}
-
Sammie Quon authored
Add a minimum distance for windows that get tapped and already in a snap region (windows tapped close too the left or right side of the screen). This is so users do not accidently snap too easily when trying to activate the window. Also fix a bug where you can drag very straight across or down without the overview window moving. Test: ash_unittests SplitViewWindowSelectorTest.Dragging Bug: 778933, 781324 Change-Id: I1b4e993951260f079f85851890854dc217ea95f3 Reviewed-on: https://chromium-review.googlesource.com/757985 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#517458}
-
rnephew authored
This reverts commit d0c9cacb. Reason for revert: 5X AOSP bug is fixed and rolled. https://chromium-review.googlesource.com/c/chromium/src/+/776353 Original change's description: > Disable failing blink_perf.canvas stories on Webview too > > Even though they're failing on 5X webview and they're disabled on 5X, > there's a bug where 5X webview isn't matching the 5X test condition > (https://github.com/catapult-project/catapult/issues/4045). > > TBR=ashleymarie@chromium.org > NOTRY=true > > Bug: 784540 > Change-Id: I100929183b15c1d84ff4e0cecddb15236644bb84 > Reviewed-on: https://chromium-review.googlesource.com/775433 > Reviewed-by: Charlie Andrews <charliea@chromium.org> > Commit-Queue: Charlie Andrews <charliea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517137} TBR=charliea@chromium.org,ashleymarie@chromium.org Change-Id: Ib48acc82b6fb1b2a1e3aa3c4f3966456cf88103f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 784540 Reviewed-on: https://chromium-review.googlesource.com/777060Reviewed-by:
rnephew <rnephew@chromium.org> Commit-Queue: rnephew <rnephew@chromium.org> Cr-Commit-Position: refs/heads/master@{#517457}
-
Scott Chen authored
This CL changes the look of the welcome page for profiles that have DICE fully enabled. Bug: 782155 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ife6f0d2cc661b15d2cf9be9a8577b090707ff57d Reviewed-on: https://chromium-review.googlesource.com/753386 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#517456}
-