- 22 Nov, 2019 40 commits
-
-
Moe Ahmadi authored
This CL adds logic to "remember" the user pressing 'Enter' when autocomplete matches are stale. This happens if the user types too fast and presses 'Enter' immediately. Currently, the realbox either does nothing or navigates to a stale result. After this change, the realbox does nothing until up-to-date results have arrived. it then navigates to the default match, if one exists, assuming that navigation to the default match was the user intent, signaled by typing too fast and pressing 'Enter'. Bug: 1024109 Change-Id: I67e434419e586d3488b1239b9fa37da8aaa4fec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928214 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#718302}
-
David Bokan authored
This is a small refactoring to make it clearer that the inner and outer viewport scroll nodes' existence is linked. That is, if either one is non-null, then the other one must be as well. Viewport scroll nodes (and others like page scale, elastic transform, etc.) are only created for the renderer's main-frame compositor. In an OOPIF renderer or the UI compositor, these property nodes are never registered and will always return null. In the main-frame renderer, we can always assume they're non-null. Bug: 1016229 Change-Id: Ie022d3d9cb937848a0ceb6560e936ce1ff06142f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871329 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#718301}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ea02a5d30e4f..e75a355406dc Created with: gclient setdep -r src-internal@e75a355406dc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:992974 Tbr: jbudorick@google.com Change-Id: I2dfa5bef80799f6fe9fa96527e9dd3c36c43d4fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928028Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718300}
-
Reilly Grant authored
Bug: 1007633 Change-Id: I0a020fa00b0d48a5cdcddb75062bad878b17e183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931263 Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#718299}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3944e7cd71d6..693bde6a69a2 git log 3944e7cd71d6..693bde6a69a2 --date=short --no-merges --format='%ad %ae %s' 2019-11-22 anubmat@microsoft.com DevTools: Fix Debugger hover tips not working Created with: gclient setdep -r src/third_party/devtools-frontend/src@693bde6a69a2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1015367 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I562cc2e2fd8a31f361b4ff773c002be1a5de77e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931165Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718298}
-
Jonathan Ross authored
On Mac AMD this test has begun failing again. These suppressions overlap with older Sierra ones, and new ones being seen on ASAN. I'm updating the entire set to point to the lasted bug, and incorporate [ mac amd no-passthrough ] There have been changes to Mac GPU selection, so suppressing until the root cause is determined. TBR=ynovikov@chromium.org TEST= deqp/functional/gles3/transformfeedback/* webgl2_conformance_tests Bug: 1027605 Change-Id: I5a73bfd52a97413d31a0c5f8bf5372f398eee759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930256 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:Jonathan Ross <jonross@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#718297}
-
danakj authored
These tests do not have network access, but InstanceID attempts to make network queries when asked for a token (via getToken()). The prefetch service posts a task during startup that ultimately asks for a token, which causes the task to fail with a network timeout eventually (after 30 seconds). This causes tests that use a base::TaskEnvironment to be very slow as their destruction waits for the 30 second task to complete. This halves the time spent in each unit_tests shard on the bots. R=avi@chromium.org Change-Id: I84815b07d167446e827df8777506f3d171bcfba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928297Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#718296}
-
Eric Stevenson authored
This will prevent old files from hanging around and causing misleading error messages. Change-Id: I928f3ac2a5e87e9ba71097ecc7a7894b7ca4d04c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922605 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#718295}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/189c98042f16..db80f6936cbc git log 189c98042f16..db80f6936cbc --date=short --no-merges --format='%ad %ae %s' 2019-11-22 ethannicholas@google.com SkSL now supports functions defined in sksl_gpu.inc 2019-11-22 reed@google.com Revert "Reland "Revert "Use flat version of path-direction enum""" 2019-11-22 robertphillips@google.com Add utility for creating test-only GrProgramInfos 2019-11-22 kjlubick@google.com [skolo] Remove internal hardware 2 2019-11-22 reed@google.com remove LEGACY_CONVEXITY code -- no more clients Created with: gclient setdep -r src/third_party/skia@db80f6936cbc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: I47ad424c55b5b2bd771607d88ad8f64aaea09fec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931269Reviewed-by:
-
Jérôme Lebel authored
Renaming: +[SigninEarlGreyUI signinWithIdentity:] +[SigninEarlGreyUI signinWithIdentity:isManagedAccount:] -[SigninEarlGreyUtilsImpl addIdentity:] -[SigninEarlGreyUtilsImpl checkSignedInWithIdentity:] -[SigninEarlGreyUtilsAppInterface addIdentity:] to: +[SigninEarlGreyUI signinWithFakeIdentity:] +[SigninEarlGreyUI signinWithFakeIdentity:isManagedAccount:] -[SigninEarlGreyUtilsImpl addFakeIdentity:] -[SigninEarlGreyUtilsImpl checkSignedInWithFakeIdentity:] -[SigninEarlGreyUtilsAppInterface addFakeIdentity:] Change-Id: Ib9f814b779bdefe953724e3d4a712c4a11f3826e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931077Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#718293}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I8b455af32e5abe7842b35b726b4f6d7f9ff4bf4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931164Reviewed-by:
-
Owen Min authored
Retrieve DM Token from BrowserDMTokenStorage doesn't have to wait for async storing process finished because we are always reading from memory. Change-Id: I86aa534323fb73f736aacc05946448ac60c93293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931356Reviewed-by:
Marc-André Decoste <mad@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#718291}
-
zhaoyangli authored
This will prevent unnecessary dependencies from being pulled to EG2 tests. Bug: 1015907 Change-Id: I45c5ec755761f1903b405542967c8a7321500ab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929761Reviewed-by:
-
Archana Simha authored
Bug: 987014 Change-Id: Id8b75318fba5382077523114781d29f8f45a301e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819353 Commit-Queue: Archana Simha <archanasimha@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#718289}
-
Jasper Chapman-Black authored
Bug: 978298 Change-Id: I2e1a00223a2313511667f93063192b4e98475346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931078 Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/26b030de1b76..e87972e30da4 git log 26b030de1b76..e87972e30da4 --date=short --no-merges --format='%ad %ae %s' 2019-11-22 tsepez@chromium.org Fix downcast in CXFA_FFTextEdit. Created with: gclient setdep -r src/third_party/pdfium@e87972e30da4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1026918 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I99f2443f4efdb0ab23268e332a4e8036b5ceec75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931163Reviewed-by:
-
Justin Cohen authored
This reverts commit 7798da0c. Reason for revert: Enable by default again for M80. Original change's description: > [ios] Change EmbedderBlockRestoreUrl default official value. > > Change-Id: Ib1049641e3035846e6e26ca545206dc28e576ece > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929266 > Commit-Queue: Justin Cohen <justincohen@chromium.org> > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#718157} TBR=rohitrao@chromium.org,justincohen@chromium.org Change-Id: I10827d3b4cfa295b4f9d40ffb54b193b2dbf2273 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931201Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#718286}
-
Johannes Kron authored
This CL whitelists the WebRTC statistics total (squared) inter frame delay and adds two derived statistics, average inter frame delay and the standard deviation of the inter frame delay. Bug: webrtc:11108 Change-Id: I1b8e4c38a0093e622341f67590e930102a534d5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929819Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Johannes Kron <kron@chromium.org> Cr-Commit-Position: refs/heads/master@{#718285}
-
Yann Dago authored
Bug: 1017632 Change-Id: Ibb873519cbeb0b83dab5e15661e7dbe21c1f5b22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879199Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#718284}
-
Clemens Backes authored
This should be fixed in v8 via https://crrev.com/c/1930615. R=ahaas@chromium.org Bug: chromium:1025184, chromium:1027131 Change-Id: Ic9be384a777910b6da59f1a9252be88638d6c8f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930557Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#718283}
-
Ana Salazar authored
Add an specific shelf background type for the in-app shelf, which is shown on tablet mode. This will help have more control of the trasitions to or from in-app state. Bug: 1024645 Change-Id: I091cfcd529c2dd632366bb12341cc482bb37cace Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928013Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Ana Salazar <anasalazar@chromium.org> Cr-Commit-Position: refs/heads/master@{#718282}
-
Xiaocheng Hu authored
This patch sanitizes clipboard markup before pasting it into document by removing all pasted style elements and serializing them onto elements as inline style. In this way, we stop stylesheets in clipboard markup from being applied to the original elements in the document. This patch follows the same approach as in WebKit [1]: - First create a dummy document to insert the markup - Then computes style and layout in the dummy document - Re-serialize the dummy document as the markup to be inserted. This reuses the code path that we serialize a selection range into clipboard, where we need to serialize element computed style into inline styles so that the element styles are preserved. - Make sure all style elements are removed before inserting markup into document This patch also adds a complete test to ensure that content pasted from Excel is still properly styled, which is the main reason we used to preserve style elements in clipboard markup [2]. [1] https://trac.webkit.org/changeset/223440 [2] http://crbug.com/121163 Bug: 1017871 Change-Id: I3bb5a4ae7530a3fdef5ba251975e004857c06f1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922919 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#718281}
-
Pavel Feldman authored
Change-Id: I18672227a10a1988ce252a8fbf528684c317714d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931267Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#718280}
-
Daniel Murphy authored
R=enne@chromium.org Bug: 1024966 Change-Id: Ie6e4e3956a85e2acdf0be7efcbd47a4e9e000a9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931200 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#718279}
-
Donn Denman authored
These tests are intermittently timing out on Marshmallow, but appear to be fine on earlier versions. BUG=1023426 TBR=twellington@chromium.org Change-Id: Icce89903bf810bfd075880d86d6e3b72cad2be72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931149 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#718278}
-
Max Moroz authored
https://chromium.googlesource.com/chromium/llvm-project/compiler-rt/lib/fuzzer.git/+log/b9f51dc8c980..debe7d2d1982 $ git log b9f51dc8c..debe7d2d1 --date=short --no-merges --format='%ad %ae %s' 2019-10-11 jakehehrlich [libFuzzer] Don't prefix absolute paths in fuchsia. 2019-10-09 jakehehrlich [libFuzzer] Fix Alarm callback in fuchsia. 2019-10-01 morehouse [libFuzzer] Remove lazy counters. 2019-09-27 hctim [libFuzzer] Dump trace and provide correct msg for overwritten input. 2019-09-26 hctim [libFuzzer] [NFC] Fix grammar error with "it's" 2019-09-17 jakehehrlich [libFuzzer] Always print DSO map on Fuchsia libFuzzer launch 2019-09-16 dor1s [libFuzzer] Remove unused version of FuzzedDataProvider.h. 2019-09-11 dor1s [libFuzzer] Make -merge=1 to reuse coverage information from the control file. 2019-08-22 mcgov LibFuzzer support for 32bit MSVC 2019-08-21 sammccall reland [gtest] Fix printing of StringRef and SmallString in assert messages. 2019-08-12 dor1s [libFuzzer] Merge: print feature coverage number as well. 2019-08-09 dor1s [libFuzzer] Merge: print stats after reading the output corpus dir. 2019-08-08 dor1s [compiler-rt] Add ConsumeProbability and ConsumeFloatingPoint methods to FDP. 2019-08-06 dor1s [compiler-rt] Rename FuzzedDataProvider.h to .hpp and other minor changes. 2019-08-05 kongyi Build libfuzzer libcxx-static with PIC 2019-08-05 dor1s [compiler-rt] Move FDP to include/fuzzer/FuzzedDataProvider.h for easier use. 2019-07-31 nico compiler-rt: Rename .cc file in lib/sanitizer_common to .cpp 2019-07-23 dor1s [libFuzzer] Fix __sanitizer_print_memory_profile return type in ExtFunctions.def 2019-07-09 dor1s [libFuzzer] Include FuzzedDataProvider.h in the test without "utils" subdir. 2019-06-27 phosek [libFuzzer] Migrate to the new exception syscalls on Fuchsia 2019-06-21 kcc [libFuzzer] split DataFlow.cpp into two .cpp files, one of which can be compiled w/o dfsan to speed things up (~25% speedup) Created with: roll-dep src/third_party/libFuzzer/src TBR=metzman@chromium.org Bug: 539572 Change-Id: I5a8ec83cb4565fa6c519c2373020230e93f7d556 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928898Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#718277}
-
Lei Zhang authored
- Guard HungPluginTabHelper and PluginObserver with BUILDFLAG(ENABLE_PLUGINS). - Sort sections guarded by buildflags alphabetically. Bug: 1027360 Change-Id: Iab94fe425d160635554215b98494c7b7ac94f138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929626Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#718276}
-
David Bokan authored
This CL refactors and clarifies some of the terminology and code related to CC's scroll chaining around viewport layers. A summary of the changes: - Remove the "MainScrollNode" terminology. It comes from a time when only the outer viewport was ever used in the scroll chain which is no longer the case. Given that this is just an alias for the outer node it only adds needless terminology. - Adds GetNodeToScroll to turn a ScrollNode found while walking up the scroll tree into the node to use to get the appropriate viewport behavior. - Audited all call sites of ViewportMainScrollNode and made sure we used either ShouldScroll or OuterViewportScrollNode as appropriate. ShouldScroll must be used when we want to know if the ScrollNode will use cc::Viewport for scrolling (i.e. it's either inner or outer). OuterViewportScrollNode is used only in cases where we want the full outer/inner distributing scroll behavior. - Fixed some tests to create viewport layers. Needed because they were hitting the DCHECK I added but later removed; however, this is still a good change. - Fixed RootScrollerScrollNonDescendant. This test was setup incorrectly since multiple ScrollNodes had |scrolls_outer_viewport| set and the inner viewport should have |prevent_viewport_scrolling_from_inner| set since we have a non-default root scroller. It passed because the original viewport had no scrolling so we never tried to scroll it. Now that DistributeScrollDelta will add the inner scroll node, and it didn't have the |prevent...| bit set, it caused the test to fail. This is a failure in the test, not in the logic. - Change viewport() to be a ref rather than a pointer since it's never nullptr. Bug: 1016229 Change-Id: I0094d203139362aa310848849c680ae664e4e5b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866279Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
Kaan Alsan authored
Added a flag to EndPositionStrategy which allows it to prioritize the previously snapped targets when finding a snap point. If no target is found then it defaults to finding the closest snap point as it does normally. Also added unit tests. This is currently not used, but will be used in a follow-up patch for resnapping the container when layout changes occur. Bug: 866127 Change-Id: I9c8d6db608a5219f4178afe0a79136b81cfb3378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929644 Commit-Queue: Kaan Alsan <alsan@google.com> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#718274}
-
Alex Cooper authored
Commit 5fc24a75 is confirmed to have broken these bots; however, after local testing it was determined that it was just the removal of this dependency that caused the break. Bug: 1027334 Change-Id: I794f6702014affe986a2ddf0dd27f1a66a60cfc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931157 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#718273}
-
Daniel Hosseinian authored
Establish the deny list entries as enum string values. Rename the existing 'printing.printer_type_blacklist' to 'printing.printer_type_deny_list'. Previously, there was no part of the code that was able to set the pref; therefore, no migration code is necessary in the renaming. Follow-up of crrev.com/712342 Bug: 487875 Change-Id: I2fc8998772c36d752303c5abd62ea48b4fff6f7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884287Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#718272}
-
Maksim Sisov authored
There is a possible race that results in a terminated gpu process. That is, a surface may have been destroyed right before a request that creates or commits buffers. To fix that, always create buffers anonymously aka not attached to any surfaces, and simply remove the pointer that the WaylandBufferManagerHost::Surface has to the WaylandWindow so that it does not try to do anything except the destruction of buffers, the call for which can come later from the GPU process. Bug: 1006813 Change-Id: I9f207ec8dac92b94a1e8f8b9fc9cd3fdb0186580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924247Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#718271}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/102af505dafe..8412598cca10 git log 102af505dafe..8412598cca10 --date=short --no-merges --format='%ad %ae %s' 2019-11-22 dproy@chromium.org Add python inputs for tracing:generate_about_tracing Created with: gclient setdep -r src/third_party/catapult@8412598cca10 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1025132 Tbr: oysteine@google.com Change-Id: I49eac51504449d7405e222b3154158aa6318e60f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928342Reviewed-by:
-
David Tseng authored
Before: File "/usr/local/google/home/dtseng/projects/chrome/src/third_party/chromevox/third_party/closure-library/closure/bin/build/depstree.py", line 56, in __init__ raise NamespaceNotFoundError(require, source) NamespaceNotFoundError: Namespace "cvox.AbstractEarcons" never provided. Required in <jsbundler.SourceWithPaths object at 0x7fcc566aa150> After: File "/usr/local/google/home/dtseng/projects/chrome/src/third_party/chromevox/third_party/closure-library/closure/bin/build/depstree.py", line 56, in __init__ raise NamespaceNotFoundError(require, source) NamespaceNotFoundError: Namespace "cvox.AbstractEarcons" never provided. Required in common/classic_earcons.js Issue: closure-library/closure/bin/build/depstree.py (part of Closure Library code) does: raise NamespaceNotFoundError(require, source) but |source| has no stringification that's friendly so you get the raw jsbundler.SourceWithPaths (which inherits from the Closure Library |Source| class). Fix by providing __str__ in the jsbundler.SourceWithPaths object (so we don't have to mod Closure Library). Change-Id: I72ca69869690661aabebc2b68843d7b2a8e6d428 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929915Reviewed-by:Steven Bennetts <stevenjb@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#718269}
-
Khushal authored
R=fserb@chromium.org Bug: 1018629 Change-Id: I8b552e92456bd8ee79e04f8f55e3c27a2d53e56f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922305 Auto-Submit: Khushal <khushalsagar@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#718268}
-
Jae Hoon Kim authored
The fix of multiple cycles of progress is at chromium:1926650. Bug: chromium:1026443 Test: ./out/Default/unit_tests --gtest_filter=DlcserviceClientTest.* Change-Id: I280d8c81041342feeb2a4701b689cae4922a5497 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930470 Commit-Queue: Jae Hoon Kim <kimjae@chromium.org> Auto-Submit: Jae Hoon Kim <kimjae@chromium.org> Reviewed-by:
-
Ana Salazar authored
Report animation smoothness for the transition into the hotseat in the HomeLauncher. Bug: 1022178, 1022177 Change-Id: I5dc5e76688aa5a88bcabb5d688b419d819932867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917941 Commit-Queue: Ana Salazar <anasalazar@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#718266}
-
Simon Que authored
Reverted due to "chromeos-*" builders not working with Goma RBE. See crbug.com/1027312 The new version of the CL has had the failing builders removed. ================================================ CI: - ChromiumOS ASAN Release - Libfuzzer Upload Chrome OS ASan - Linux Chromium OS ASan LSan Builder - Linux ChromiumOS Full - Linux ChromiumOS MSan Builder - Mojo ChromiumOS (remaining builders removed) Try: - linux_chromium_chromeos_asan_rel_ng - linux_chromium_chromeos_msan_rel_ng - linux_mojo_chromeos (remaining builders removed) Schedule of migration: https://docs.google.com/spreadsheets/d/1TZhpasm6iceYm7zqkyEtZ1wn9ZcpREfH4LV4cusICJA/edit#gid=0 Bug: 950413, 1027312 Change-Id: I8bca8bff1af888e5167bb16ebf275920ff2aa30f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928386Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#718265}
-
Jonathan Backer authored
The use experience is largely the same, but it is very different from our crash reporting perspective. Lost context shutdowns are clean and don't show up as a crash report. They are treated similarly by GPU blacklisting. Bug: 1026872 Change-Id: I00559c7ef5276fe6c7c9aee832ff016a0a755156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929153 Commit-Queue: Jonathan Backer <backer@chromium.org> Auto-Submit: Jonathan Backer <backer@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#718264}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ff3bbb5d. With Chromium commits locally applied on WPT: e83dd93c "Limit backtracking on regexp called from blink." 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ie5a2ae60d915b2a7aba393d6d9d08c367b0d7fe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930342Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718263}
-
