GitLab

WindowSelectorController::ToggleOverview used to do 3 removal loops over the
active window list, one of which did a search through another window list for
each window. This reduces the runtime complexity (a single removal loop) and
makes the code easier to read (having fewer conditions).

Bug: None
Change-Id: I06ddf20b5ef3be57da4660de849bffeb4935683b
Reviewed-on: https://chromium-review.googlesource.com/934974Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538869}

Will be used in to be implemented CMA backend.

BUG=internal b/73746352
TEST=Build

Change-Id: I08d520edf54cbd8658c6112eeb930e7e68fd3d6a
Reviewed-on: https://chromium-review.googlesource.com/933584Reviewed-by: Stephen Lanham <slan@chromium.org>
Commit-Queue: Mina Almasry <almasrymina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538868}

This removes code from BVC and allows reusing Store Kit code in
DownloadManagerCoordinator.

Bug: 791806
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Id5d33de9666a0bdc35fb3d451158b33a8636bf4d
Reviewed-on: https://chromium-review.googlesource.com/934315
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538867}

This cl releases some resource ids after moving Keyboard Shortcut
Viewer (KSV) from ui/chromeos to ash/components.
Current ui_chromeos_strings' max id is 26353, starts next grd id from
26450.

Bug: 768932
Test: None
Change-Id: I93ca16b9797af61ee46f8ee27999859e86a0583f
Reviewed-on: https://chromium-review.googlesource.com/934966Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538866}

This reverts commit 62f63887.

Reason for revert: Breaks Linux x64 build

See https://ci.chromium.org/buildbot/chromium/Linux%20x64/59320


Original change's description:
> Rename buildflag_headers for consistency
> 
> This renames targets in chrome, chromecast and chromeos.
> 
> Targets go from foo_features to foo_buildflags
> And similarly the header now has buildflags in the name.
> 
> BUG=814485
> TEST=covered by build
> TBR=dcheng@chromium.org
> 
> Cq-Include-Trybots: master.tryserver.chromium.mac:mac_chromium_10.10_macviews
> Change-Id: I9e93ff7bfd088b93678ce4a2814a1dbf6e36f091
> Reviewed-on: https://chromium-review.googlesource.com/932544
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#538856}

TBR=sky@chromium.org,dcheng@chromium.org,thakis@chromium.org

Change-Id: Ie087d5e711feb3d2ac127b78f0c019ae18bcdaed
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 814485
Cq-Include-Trybots: master.tryserver.chromium.mac:mac_chromium_10.10_macviews
Reviewed-on: https://chromium-review.googlesource.com/935361Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538865}

This adds BlueZ.ChipLost. This differs from BlueZ.AdapterLost in that
ChipLost records adapter lost specifically due to hardware
disconnection.

Corresponding CL where metrics is used: http://crosreview.com/924505

BUG=chromium:813390

Change-Id: I1a1956f6f40508b57af12c49ee4c1265c7309457
Reviewed-on: https://chromium-review.googlesource.com/930482Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538864}

Bug: 615187
Change-Id: I843a790e5a0000d9ca8a981b734c5891f54577c8
Reviewed-on: https://chromium-review.googlesource.com/934977Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: Xiaoling Bao <xiaolingbao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538863}

Use Service directly, since it's all in //net anyway.

Bug: 811472
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: If76628a56aa9e9e1b463f40f5ade4e3c50b506ed
Reviewed-on: https://chromium-review.googlesource.com/919421Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Julia Tuttle <juliatuttle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538862}

This support is no longer needed, and removing it side-steps an Android
framework issue. Specifically, re-enabling popupwindow clipping prevents
Android from drawing it overtop of the bottom navigation bar.

BUG=815226

Change-Id: I5860a7f58efb3920cb636557502879dd9e3136ab
Reviewed-on: https://chromium-review.googlesource.com/934978
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538861}

This change causes |AuthenticatorImpl| to only serialize
|CollectedClientData| once for each request. Since the code then carries
it around as a string, the |CollectedClientData| object itself is never
used except to immediately call |SerializeToJson| on it. Thus
|CollectedClientData| is folded into a function on |AuthenticatorImpl| to
save two indirections.

Along the way, implement the changes to the Token Binding member[1] and
re-add the random hint to not template match[2] now that it doesn't
break things.

[1] https://github.com/w3c/webauthn/commit/a47fe1c4d53b123caa7abc76e9659b95dc1c1a16
[2] https://chromium.googlesource.com/chromium/src/+/eb234c8e7356f2239700c604ad7b3eda42aaac33

Bug: 814103
Change-Id: Ifa96f3eee11bcbf740c7adff43e092ce5361210a
Reviewed-on: https://chromium-review.googlesource.com/929807Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538860}

* Move the code pulling and pushing data to its own function.
* Add a loop that runs until the audio client reports empty buffer.
* Remove unnecessary GetVolume() call; it's overwritten by GetAgcVolume() call later.

Bug: 637558
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ie06d862592143d76508a7d4d709efd42c83a1d9c
Reviewed-on: https://chromium-review.googlesource.com/931554
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538859}

Remove VrTabModalJsDialog flag when in VR.

BUG=779126

Change-Id: I2c7ce7d764cc7879496878d8a20facf1baba5a9b
Reviewed-on: https://chromium-review.googlesource.com/932756Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Amirhossein Simjour <asimjour@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538858}

This will allow configuring minigbm via GN variables, instead of make
file args.

Bug: 733450
Change-Id: I455d6b39c587b061a3527b63c7b1a1f556a529ac
Reviewed-on: https://chromium-review.googlesource.com/933595Reviewed-by: Michael Spang <spang@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Sergey Volk <servolk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538857}

This renames targets in chrome, chromecast and chromeos.

Targets go from foo_features to foo_buildflags
And similarly the header now has buildflags in the name.

BUG=814485
TEST=covered by build
TBR=dcheng@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.mac:mac_chromium_10.10_macviews
Change-Id: I9e93ff7bfd088b93678ce4a2814a1dbf6e36f091
Reviewed-on: https://chromium-review.googlesource.com/932544Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538856}

Currently BaseFile will ask ContentBrowserClient for default download dir
if preference returns an empty dir.
This CL moves that logic into DownloadManagerImpl,
so BaseFile won't need to reference ContentBrowserClient.

BUG=803135

Change-Id: I480d9f32bd685068134bd25b23e07ea21d7239f6
Reviewed-on: https://chromium-review.googlesource.com/930234
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538855}

Allow toggle of color inversion on the root window layer to support
high contrast mode toggle.

Bug: b/73383555
Change-Id: I97bc389385249283ca362ddfb22599b87a822ab2
Tested: Manual
Reviewed-on: https://chromium-review.googlesource.com/932621
Commit-Queue: Randy Rossi <rmrossi@chromium.org>
Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538854}

Today, PaymentAppContext::Shutdown() is called from
~StoragePartitionImpl() after the UI thread is done running tasks
and before the IO thread is done running tasks. ShutdownOnIO() is
successfully posted to the IO thread. After it runs, it tries to
send the DidShutdown() reply to the UI thread, which fails. Because
of how PostTaskAndReply is implemented, the PaymentAppContext is
leaked (cf.
https://cs.chromium.org/chromium/src/base/threading/post_task_and_reply_impl.cc?l=89&rcl=0fe5265959e1da13c1521fd7f5f6275a3b83c614).

We now want to change PostTaskAndReply() to avoid leaking the
reply callback and its arguments when the reply thread can't run
tasks. To make that possible, we need to change the DCHECK in
~PaymentAppContextImpl() so that it only fails if ShutdownOnIO()
didn't run, not if DidShutdown() didn't run.

Bug: 807013
Change-Id: Ie893c70d423fed7c617cec31f01dfe1763501913
Reviewed-on: https://chromium-review.googlesource.com/929592Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538853}

Bug: 812186
Change-Id: I441588439e23144311c1960c20ae49aaf75f96e5
TBR: chfremer@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/934976Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538852}

This reverts commit da69db99.

Reason for revert: Suspected of causing the crashes tracked by crbug.com/814641

Original change's description:
> Fix Windows sandbox to work with Application Verifier
> 
> Application Verifier is a useful tool for tracking down bugs on Windows.
> However Chrome's sandbox has not played well with App Verifier - it ends
> up initializing a heap before the process is ready for this. This change
> teaches the NtMapViewOfSection to skip InitHeap when handling the App
> Verifier DLLs, which don't need patching anyway.
> 
> With this change I can run Chrome with the default App Verifier settings
> enabled with the exception of Handles and TLS (those failures probably
> don't represent real bugs), without using --no-sandbox.
> 
> Bug: 752344
> Change-Id: Id1fd4be9c0f080513bbdb649ed5cf2637df8474c
> Reviewed-on: https://chromium-review.googlesource.com/925821
> Reviewed-by: James Forshaw <forshaw@chromium.org>
> Reviewed-by: Will Harris <wfh@chromium.org>
> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#538307}

TBR=brucedawson@chromium.org,forshaw@chromium.org,wfh@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 752344
Change-Id: Icd8feea1779f2891389762db0773ecf0ed9ad762
Reviewed-on: https://chromium-review.googlesource.com/934862Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538851}

This CL simply moves the file, no major changes.

BUG=803135

Change-Id: I3158f7e4382940afe1114bb4f614eba4337ba660
Reviewed-on: https://chromium-review.googlesource.com/929745Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538850}

The Sync Confirmation Dialog was using the Unity width instead of the
default width.

Bug: 814555
Change-Id: I9e4ebcd296fb9afc470841f0344a52ce7f2f40f4
Reviewed-on: https://chromium-review.googlesource.com/934244Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538849}

ShouldShowLocationBarForHTTPApp and ShouldShowLocationBarForHTTPSApp
are both flaky, with the former failing while the later crashes.

TBR=mguica@chromium.org

Bug: 815240, 815246
Change-Id: I8856047c78d503affea58a25ba6f708454642116
Reviewed-on: https://chromium-review.googlesource.com/934926Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538848}

This was unintentionally removed, and needs to be added back. In the
future, this might move to DataReductionProxyData.

Bug: 813948
Change-Id: Iee0b5c16fc99860a9682804d1948651b434ab7ea
Reviewed-on: https://chromium-review.googlesource.com/927749
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538847}

For the mojo version of session storage, the 'cloning' of namespaces
has to to be called on the same mojo pipe as all session storage data
operations. This patch allows that to happen by letting the source
renderer mint the new namespace ID (and thus allowing it to call 'clone'
with that ID).

Bug: 716490
Change-Id: I7d1e20c7b1387e9caeab868217cf25c7a0119342
Reviewed-on: https://chromium-review.googlesource.com/910109
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538846}

|scrollable_viewport_size_| is cached on each
InputHandler::OnSwapCompositorFrame, but it is never used. This CL
simply removes it.

Change-Id: I3025b25cc45c5ea220870aa23d462f04964311b5
Reviewed-on: https://chromium-review.googlesource.com/933115Reviewed-by: Yi Xu <yiyix@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Shridhar Sundarraj <sundarrajs@google.com>
Cr-Commit-Position: refs/heads/master@{#538845}

Ideally we should be able to show the dialogs in a meta world when
in WebVR. For now, this patch makes sure that no dialog is opened
in WebVR. Moreover, the dialog will be dismissed.

BUG=none

Change-Id: I32e8d7aed84927f1057a4a13e42622d9eceeb301
Reviewed-on: https://chromium-review.googlesource.com/932442
Commit-Queue: Amirhossein Simjour <asimjour@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538844}

This reverts commit 21813050.

Reason for revert: Broke (at least) webrtc's deps roller and Mac bisectors

Original change's description:
> [test_env.py] Reland: Warm up vpython virtualenv cache on swarming task shards
> 
> This will prevent tests sensitive to cold vpython startup time from
> timing out.
> 
> Relands https://chromium-review.googlesource.com/c/chromium/src/+/917802 . We
> expect this to work because test shards now include a hermetic copy of
> cpython as well as vpython (which was the failure observed in
> crbug.com/812693).
> 
> R=​dpranke@chromium.org, kbr@chromium.org, tandrii@chromium.org
> 
> Bug: 804174,812693
> Change-Id: Ic38845f8af366d9af211bef64df135176ab9ee1d
> Reviewed-on: https://chromium-review.googlesource.com/933107
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#538652}

TBR=iannucci@chromium.org,dpranke@chromium.org,kbr@chromium.org,tandrii@chromium.org

Change-Id: Ia8f6a122db20332c67b2376a176b18c68ae9efd1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 804174, 812693
Reviewed-on: https://chromium-review.googlesource.com/935028Reviewed-by: Charlie Andrews <charliea@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538843}

This build flag is intended to be set by the "Build From Tarball" bot which does
an unbundled build.  This is necessary because some of the libraries that we
statically link (eg. harfbuzz) use features that are very new and not available
on all (or any) supported distros.

BUG=800977
R=thestig

Change-Id: Ie7d635effe148aae07a75b60221442b0c71f2a38
Reviewed-on: https://chromium-review.googlesource.com/933725Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538842}

https://skia.googlesource.com/skia.git/+log/413782e8540d..09f818d2c9c0

$ git log 413782e85..09f818d2c --date=short --no-merges --format='%ad %ae %s'
2018-02-22 halcanary SkString: use c++11 vsnprintf in windows
2018-02-22 halcanary SkQP:  do test filtering correctly
2018-02-23 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ c5472f44e..569770ec9 (1 commit)

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=djsollen@chromium.org

Change-Id: I31d0300a50b802c3c6af2cc7b565db039126972a
Reviewed-on: https://chromium-review.googlesource.com/934846
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#538841}

Since there is a race between /proc/self/tasks being updated and the actual
state of the process's threads, call AssertSingleThreaded rather than
LOG(FATAL) when InitializeSandbox detects that the process is not
multithreaded to allow a chance for /proc to be updated before the
process is killed.

BUG=b:73166395

Change-Id: I57d662fc9e1f2fd29a0d0ab9e1147ea00ee05568
Reviewed-on: https://chromium-review.googlesource.com/920002
Commit-Queue: Drew Davenport <ddavenport@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538840}

which records the location where a QUIC internal error was generated.

This is temporary change in order to track down the cause of an increase
in INTERNAL_ERROR and should be revered once that cause is determined.

Change-Id: I42e9b584894bdc8fb38fea21cdbd0699ce4d1a58
Reviewed-on: https://chromium-review.googlesource.com/931996Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538839}

Add an observer interface to ArcPolicyBridge. Observers are notified
whenever policy is sent to CloudDPC or a compliance report is
received from it.

The CL also forces a compliance report to be sent after the initial
policy fetch by adding a GUID to the policy JSON which changes
whenever a new instances of ArcPolicyBridge is created. A cleaner
way to do this would be a |force_compliance_report| flag sent to
CloudDPC. This clean-up is tracked in a follow-up bug.

Bug: b/73277923
Bug: b/73762796
Test: unit_tests
Change-Id: Ib4cdfb28e4b3ea2ea0ca03d1cd7293d7e07f0bcd
Reviewed-on: https://chromium-review.googlesource.com/931705
Commit-Queue: Bartosz Fabianowski <bartfab@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538838}

Bug: 805635
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I151911fab9a5e9e53531f52453b6c481fe901eaa
Reviewed-on: https://chromium-review.googlesource.com/934586Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538837}

This way, we don't need to build blink for both target and host,
and snapshots don't work in cross builds yet anyways (crbug.com/803591).
Once they do, we can reconsider.

Bug: 495204
Change-Id: Ie20c7eff44acea3cad5697cfa61f52d3f7405ac1
Reviewed-on: https://chromium-review.googlesource.com/934685
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538836}

views::View that don't have a context menu controller
still mark the click event as handled,
forbidding further processing of this event.

Bug: 814666
Change-Id: Ie9ab6e0f0e573a4d653a52995421ac1075c686fb
Reviewed-on: https://chromium-review.googlesource.com/925269Reviewed-by: Elliot Glaysher <erg@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538835}

In future, Chrome renderer will generate paint items
and send them to viz process. The RasterService in viz
will turn those paint items into SkDDL in raster threads,
and then post a task to Gpu thread to draw SkDDL. This
new SkiaRenderer can be used to test the SkDDL related
code.

This CL also removes GLRenderer and SurfacelessGLRenderer,
because we would like use Skia instead of using GL directly
in future.

Bug: None
Change-Id: I6c4f5fa73550e7958b0ef25ec5ac88421251fcfb
Reviewed-on: https://chromium-review.googlesource.com/929314Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538834}

Per https://github.com/w3c/web-platform-tests/pull/4832 remove
WebSQL cases from WPT's workers/data-url*.html since it's not
otherwise tested in WPT, and the test "passes" even if the API is
not present. Also add an addition assertion that indexedDB is
present before blithely checking that using it throws.

WebSQL is not exposed to Workers in Chrome so we don't lose
coverage here - we only "passed" because the API was not present
in these contexts. The webexposed/ tests cover this.

Change-Id: I0aa05ff9e674351a2a49ba0bae8e5a9938b2cf34
Reviewed-on: https://chromium-review.googlesource.com/929602Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538833}

Since "ViewsBrowserWindows" is a Chrome feature, this CL follows
CreateNativeWebModalManager in declaring a function in components
and defining it in c/b/ui/cocoa.

Background:
Polychrome is an intermediate step to shipping MacViews browser.
Currently, switching between Cocoa browser and MacViews browser requires
a buildflag. Polychrome builds both Cocoa and MacViews into the same
binary and allows switching between them based on a feature flag.
More details at crbug.com/802257

As Cocoa and (much of) Views were not typically built together,
some symbols were reused. With Polychrome, these are duplicate symbols.
This CL resolves the issue by renaming the Cocoa symbols, and then
shimming them for the (regular, not Polychrome) Cocoa build.

Bug: 808017
Change-Id: I9bf1845aa22305928aafd74884793f0fa86afe56
Reviewed-on: https://chromium-review.googlesource.com/929942Reviewed-by: Mike Wittman <wittman@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538832}

Bug: 738611
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id88cb1a89d7eed7e2993dbf5f690708b61cc4143
Reviewed-on: https://chromium-review.googlesource.com/932978Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538831}

Storage back-ends notify the quota system about deltas in per-origin
usage via a QuotaManagerProxy, which will do sequence-hopping to get
to the right place to talk to the QuotaManager itself.

Convert the entry points to pass url::Origin instances along instead
of GURLs. For back-ends that are already converted to use url::Origin
internally (Cache API, Indexed DB) this deletes code. For the others
(AppCache, WebSQL, FileSystem), some conversions are necessary, mostly
in test logic.

(The QuotaManager itself is not yet updated, so the proxy itself
needs to do a type conversion. That'll get tidied up soon.)

Bug: 598424
Change-Id: I7e9eb04e974053ee6cc9172ee039aaa7cdec3d89
Reviewed-on: https://chromium-review.googlesource.com/927794Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538830}