- 07 Mar, 2019 40 commits
-
-
danakj authored
WebViewHelper is a WebWidgetClient even though WebViewPlugin's WebView is not composited. So set it up as the WebWidgetClient after attaching the main frame. R=dcheng@chromium.org, tommycli@chromium.org Bug: 920952, 912193 Change-Id: I8391bde1d0452cf78d23a8b855a45497bac02d66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504142 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#638497}
-
Andrew Moylan authored
These were added in http://crrev.com/c/1352824 (model_impl.h) but we didn't add them to enum.xml yet. Bug: 933200 Change-Id: If18be5107be2124797f72f0f290c0666e61a3c9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496122Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#638496}
-
vitaliii authored
Enable using Scrypt to derive the key when encrypting data with a new custom passphrase in Chrome Sync (starting from M74). I manually tested the functionality locally. We have a kill switch, which we can use if we decide not to launch in M73/M74. Bug: 875901 Change-Id: I37dee9a66e0f519e963a6b3a13887c3bf8b2e049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497141Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Auto-Submit: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#638495}
-
Miyoung Shin authored
- unsigned long long / long long -> uint64_t - No logic change. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929980 Change-Id: I24e97b5d2c3068e092d2f40a45920991468a06bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507294Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638494}
-
Kamila Hasanbega authored
This reverts commit 99d553b3. Reason for revert: This has likely caused failing tests https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/11228 Original change's description: > pdf: Switch to the threaded version of ink > > Updates the resource manager to not require a mime type when loading > a bundled resource. This is the same as the behavior in [1]. > > [1] https://cs.chromium.org/chromium/src/extensions/browser/extension_protocols.cc?q=extension_protocols.cc&sq=package:chromium&dr&l=340 > > Bug: 902646 > Change-Id: Ib65eafd6fc900351a9270317a711c9d3ab092f80 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501194 > Commit-Queue: dstockwell <dstockwell@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#638324} TBR=thestig@chromium.org,dstockwell@chromium.org,rdevlin.cronin@chromium.org Change-Id: I9ed4732eb289e9f8e0d1712ea7e03e46dbba032b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 902646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507712Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Commit-Queue: Kamila Hasanbega <hkamila@chromium.org> Cr-Commit-Position: refs/heads/master@{#638493}
-
Mohamed Amir Yosef authored
Enable Sync on clients one at a time in order to avoid race conditions. Bug: 919877 Change-Id: Ic8820cf33c9deb9cae3fbf24df0d2e1846d36cd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506083 Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#638492}
-
Zhuoyu Qian authored
TouchEventDispatchResultType is unused, remove it. Change-Id: I9f3e49d5d9599dd5448bc54c2b9c71602b1cc325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506917Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#638491}
-
Gyuyoung Kim authored
As a step to annotate the macros of Allocator for the Onion Soup, this CL annotates some classes of //third_party/blink/renderer/platform/text with the macros of Allocator. After some analyzes, it was concluded that for the case of LayoutLocale class, it makes sense to use USING_FAST_MALLOC because it has been used as a member variable with new() or smart pointers. In WebEntities class, it makes sense to use DISALLOW_NEW because it's used as member variable with a reference type. Lastly, the rest of classes this CL annotates make sense to use STACK_ALLOCATED. Bug: 919389 Change-Id: Icf692c5541746e1b3d93662cdc951070d092b4c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506677Reviewed-by:
-
Haojian Wu authored
The CDB for chromium is huge (~200MB), emitting into one line will make editors freezing when opening it. Change-Id: I85a09485104fd7c9c6c1b426178d9823bdfba543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505508Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/692122e3ef23..52e620ffd0bd git log 692122e3ef23..52e620ffd0bd --date=short --no-merges --format='%ad %ae %s' 2019-03-07 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@52e620ffd0bd The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: I1e30b7b627af860b205dde01cb9b28746c773b64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506645Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638488}
-
Colin Blundell authored
The SigninManager unittest is the one test that uses FakeProfileOAuth2TokenService outside of either IdentityTestEnvironment or IdentityManager and friends. However, it doesn't need to, as it doesn't use any of the heavy functionality that FakePO2TS exposes. This CL changes it to use ProfileOAuth2TokenService, clarifying the actual usage of FakePO2TS in the codebase. Bug: 938823 Change-Id: I2fdea1b4c073be2488a9aae10fb7c2fb5b773766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505452Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#638487}
-
Kazuki Takise authored
Currently, the backdrop window in AlwaysOnTopContainer is not set as always on top, which causes the window to be reparented to DefaultContainer when SetFullscreen is called for it (as OnPreWindowStateTypeChange is added to AOTController in [1].) This is causing the crash of the browser process when a window exits PIP. To prevent this, this CL sets a new property to backdrop windows so that they won't be reparented to another window. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1447991 Bug: b/124699190 Test: Confirmed exiting PIP didn't cause crash Change-Id: I4f2729e949bfcfd7bcb1b5e2ca623109ad5d7501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1482100Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Commit-Queue: Kazuki Takise <takise@chromium.org> Cr-Commit-Position: refs/heads/master@{#638486}
-
Darwin Huang authored
- security bugs were for integer overflow and heap-buffer overflow. Bug: 925656, 932353, 925381 Change-Id: Ibda5a20302153b7ede3a5b89a7bcea622fded869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504333Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638485}
-
Dominic Mazzoni authored
TBR=nektar@chromium.org Bug: 905419 Change-Id: Iabcb0eff62369972c07aef952fa6345422b761ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507256Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#638484}
-
Yuichiro Hanada authored
kLoginLayoutWhitelist has a list of xkb layout ids that are allowed to be used on login screen. However, the same information is already in //chromeos/ime/input_methods.txt. This CL removes the array and use the infomation in input_methods.txt instead. There is a slight diff between kLoginLayoutWhitelist and input_methods.txt. - 'fr' is only in kLoginLayoutWhitelist and xkb_manifest.json uses it. I updated xkb_manifest.json to use 'fr(oss)'. - 'ro(std)' and 'ga' is specified as login layouts in input_methods.txt, but not in kLoginLayoutWhitelist. They are considered as login layout after this CL. Bug: None Change-Id: Ic88846555310e3c534e64dd195bd47aa80befa42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1490986Reviewed-by:
Shu Chen <shuchen@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#638483}
-
Marc Treib authored
After https://crrev.com/c/1430089, this state is not meaningful anymore. Yay, one less! Semi-relatedly, this CL also moves some NotifyObservers() calls, to avoid notifying while we're in an intermediate (and thus potentially invalid) state. Bug: 839834, 935908 Change-Id: I6093ba3bd44452990ba9b0b8926b3c6e308c90ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1481418Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#638482}
-
Matt Falkenhagen authored
The non-servicified path is no longer supported. Bug: 926114 Change-Id: I0fa7058c73fb185f15bc00ff62d494cefb7ece45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506064 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#638481}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/48f640f5365e..ffb1ffb82284 git log 48f640f5365e..ffb1ffb82284 --date=short --no-merges --format='%ad %ae %s' 2019-03-06 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@ffb1ffb82284 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ic67fa50d7eb1c449dc5769cf94d27b181e432568 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506207Reviewed-by:
-
Zinovy Nis authored
cc/paint/image_provider.cc:14:14: warning: passing result of std::move() as a const reference argument; no move will actually happen [hicpp-move-const-arg] : image_(std::move(image)) {} ^~~~~~~~~~ ~ cc/paint/image_provider.cc:18:14: warning: passing result of std::move() as a const reference argument; no move will actually happen [hicpp-move-const-arg] : image_(std::move(image)), destruction_callback_(std::move(callback)) {} ^~~~~~~~~~ ~ cc/paint/image_provider.cc:27:14: warning: passing result of std::move() as a const reference argument; no move will actually happen [hicpp-move-const-arg] : image_(std::move(other.image_)), ^~~~~~~~~~ ~ cc/paint/image_provider.cc:37:12: warning: passing result of std::move() as a const reference argument; no move will actually happen [hicpp-move-const-arg] image_ = std::move(other.image_); ^~~~~~~~~~ ~ Change-Id: I2c3d49f7833ea117ef1b6aec4cf9037d19cb7c81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1489751Reviewed-by:Khushal <khushalsagar@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Zinovy Nis <zynis@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#638479}
-
Matt Falkenhagen authored
ServiceWorkerServicification is always enabled now, so loader interceptors are always enabled. Bug: 926114 Change-Id: I77855393a475da5636c7c855d6456b6819cd3e82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506062Reviewed-by:
-
Yann Dago authored
Each section of the chrome://management page should look like each section of the settings page Visual of management page: http://screen/CQ335FkdT5a ChromeOS: http://screen/tZofcxLpJ6B Visual of settings page: http://screen/pYsjEZuRsVr Bug: 938995 Change-Id: I50f150081b1ca24d02be9aea2b2ee668965f53fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506499Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#638477}
-
Hajime Hoshi authored
This CL refactors FrameMsg_JavaScriptExecuteRequest* and FrameHostMsg_JavaScriptExecuteResponse from being a legacy IPC message into a method on mojom::Frame and mojom::FrameHost. This is necessary for bfcache where JavaScript must not be executed on per-thread task runners. While legacy IPC processes messages on a per-thread (default) task runner, Mojo can dispatch on a per-frame task runner. Bug: 870606 Change-Id: Ie655dc6f594568f70efd3f030e9d49257c64cc2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1488405 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b9c4c2512141..45209e43f286 Created with: gclient setdep -r src-internal@45209e43f286 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:934623,chromium:790705 TBR=shend@chromium.org,zmin@chromium.org,dvadym@chromium.org,petewil@chromium.org Change-Id: I8eac98e38a3350282c1334764876a6a8fb4fab78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506643Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638475}
-
Maggie Cai authored
Currently we are not showing cookies in the site details page. It is confusing when we enter the site details page from the All Sites page, which shows the cookies for the origin. This CL shows the cookies in the site details page and also allow the user to clear the cookies from the site details page. In addition, if there are cookies on the etld+1 level and we only have one origin, we will show them as a grouped entry instead of collapsed to the top level entry. This is because otherwise the collapsed entry will look weird if we enter the site details page, which only shows the cookies number from the origin, not the etld+1. BUG=835712,935269 Change-Id: Id145657099f9d12fb9efd0200cb57c8e3ba8bb55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1493691 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Patti <patricialor@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#638474}
-
Karandeep Bhatia authored
This CL fixes extraHeaders event listeners for webviews in network-service path. r611357 began requiring the 'extraHeaders' specifier for event listeners which wanted to intercept certain headers. However this doesn't work for webviews in the network service path. ExtensionWebRequestEventRouter::HasAnyExtraHeadersListenerImpl doesn't correctly handle web view event names, causing the WebRequestProxyingURLLoaderFactory to enter into an inconsitent state. Fix this by changing how HasAnyExtraHeadersListenerImpl is implemented. BUG=938095 Change-Id: I8ceb830fd16a2ec671d3b7f49f891ae4c30cb6b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504817 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638473}
-
Matt Falkenhagen authored
No longer needed after mojofication. Bug: 931084 Change-Id: I3fe93ee2e7c9899ef9f76b2a8a42a548fc03267d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504665Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#638472}
-
tzik authored
V8 updated the signature of MicrotasksCompletedCallback to take a void pointer user data, and is deprecating the old signature. This CL updates its user to use the new one. Change-Id: I24990f68b2964fa80554689947746636958f59cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504660Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#638471}
-
Giovanni Ortuño Urquidi authored
Before, we were retrieving the scope for the app associated with the current URL. This approach had a couple of problems: 1. If WebKit prefs were recomputed while out-of-scope we would set the scope based on the wrong URL 2. Sometimes WebKit prefs are recomputed before the navigation has finished, so there would be no URL that we could use to get the app. This CL fixes these issues by retrieving the app associated with the app window. This association is set when the app window is created and it never changes. Additionally, it adds a GetScopeUrlForApp and HasScopeUrl to AppRegistrar. Bug: 934171 Change-Id: I0f0d78d97f85f6e6a7de3fa4266828bb852b0716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504592 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#638470}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4c5c3fce..0a7a6252 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia4f92d7c0115bae7fc8b5ed1750e1941c3c44b3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507038Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638469}
-
Kuo Jen Wei authored
BUG=None TEST=Video recording and photo taking function normally with/without timer tick. Timer tick can be canceled from stop shutter button. Change-Id: I62feaec286513b3eca7933a85f7f070c63cf74d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1486791Reviewed-by:
Sheng-hao Tsao <shenghao@google.com> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#638468}
-
Rakina Zata Amni authored
Activatable-locked subtrees are counted in total find-in-page matches, but we currently still skip over them for active match navigation (the specially-highlighted match). This CL makes us unlock/commit relevant locked elements needed to show the active match (the ancestors of the nodes in the active match range). This includes sending the "beforeactivate" event to those elements. Bug: 882663 Change-Id: I743faf1391ff0157fdca12a1cbba51fd29a680c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1491069 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#638467}
-
Luciano Pacheco authored
Follow up of CL:1475315. Change-Id: Ia6d4e8ab329fb93826182025f6f6c221d4471266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506922 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#638466}
-
Xianzhu Wang authored
Previously we created render surface only based on the current value of opacity, filter and backface-filter, but the compositor may change the values without informing blink, causing incorrect rendering due to missing render surfaces. Also change the condition checking composited animation from HasActiveXXXAnimation() to IsRunningXXXAnimationOnCompositor() which has been available since crrev.com/c/1498030 and is more accurate. Bug: 836884 Change-Id: I4b14a56c93c9baeb7c0d59da43e3be314f9f9c2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498022 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#638465}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5abc126b0795..df42f3b1d646 git log 5abc126b0795..df42f3b1d646 --date=short --no-merges --format='%ad %ae %s' 2019-03-07 oysteine@google.com Merge "Add API to enable additional producer_name_filter entries in a session" Created with: gclient setdep -r src/third_party/perfetto@df42f3b1d646 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I75cc4350660a84ac80e6cb804aadef7fb9021b41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507252Reviewed-by:
-
Gyuyoung Kim authored
As a step to annotate the macros of Allocator for the Onion Soup, this CL annotates some classes of //third_party/blink/renderer/platform/testing with the macros of Allocator. After some analyzes, it was concluded that for the case of HistogramTester, LayerTreeHostEmbedder, ScopedMainThreadOverrider, ScopedSchedulerOverrider classes, they make sense to use USING_FAST_MALLOC because they have been used as a member variable with new() or smart pointers. In FuzzedDataProvider classes, it makes sense to use DISALLOW_NEW because it's used as member variable with a reference type. Lastly, the rest of classes this CL annotates make sense to use STACK_ALLOCATED. Bug: 919389 Change-Id: I1599e8879f39952d9699218a906ec8e7e193b5fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506675Reviewed-by:
-
Miyoung Shin authored
Add a PRESUBMIT check to ensure new |short| use don't come in. Bug: 929985 Change-Id: Ifae1e6ba1af4d6c6ee0b0b8dffe608e0e710b291 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503174Reviewed-by:
-
Luciano Pacheco authored
Fix My files expanding when selecting or expanding entries in other roots. Change-Id: I5c87f371ef500608100b6e07ae118f84e71f0311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505744 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#638461}
-
Kenichi Ishibashi authored
The test is already disabled for non-OMT fetch cases. Disable the test for OMT fetch case too. Bug: 937048 Change-Id: I4397c954cace41d4e1553e929c00c74d32da3deb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506059 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Auto-Submit: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#638460}
-
Bruno Santos authored
Renaming to KioskNextHome to reflect the refactoring work and ultimate goal. Also considered MojoKiosk, but Mojo team prefers to keep the Mojo name referring specifically to the Mojo library, not uses of the library. Bug: 933530 Change-Id: I3113fa6f2a8e95843a9bd82bfcf8a2c75b32bcfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1491832Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Bruno Santos <brunoad@chromium.org> Cr-Commit-Position: refs/heads/master@{#638459}
-
Kenichi Ishibashi authored
Add a meta tag to have long timeout for the test. This should deflake the test. Bug: 937544 Change-Id: I87e0dda7647371e1082639037090264240a5bd06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506058 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
