- 14 Dec, 2017 40 commits
-
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/111e9904..6c8aaa8d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I47a1216e4df3df087a1222d9ef22d31e83972591 Reviewed-on: https://chromium-review.googlesource.com/826284Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#524040}
-
Morten Stenshorne authored
We'd end up re-entering NGBlockNode::CopyFragmentDataToLayoutBox() for the same node. After layout of a fragment, NGBlockNode::CopyFragmentDataToLayoutBox() would call LayoutBlock::UpdateAfterLayout(), which would call scrollbar was toggled, it'd go ahead and call UpdateLayout() on the object, which would take us back into the NG layout machinery, on the same node, via Finally we'd re-enter NGBlockNode::CopyFragmentDataToLayoutBox(), causing misc kinds of misery, such as not being able to paint the block at all. For multicol, there'd even be a DCHECK failure "Variable fragment inline size not supported", because the code got confused as to whether a fragment was a first fragment or not. LayoutBox: :UpdateAfterLayout(), which would call PaintLayer: :UpdateSizeAndScrollingAfterLayout(), which would call PaintLayerScrollableArea: :UpdateAfterLayout(). If this code detected that a LayoutNGBlockFlow: :UpdateBlockLayout(), further to NGBlockNode::Layout(). Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I832372223e324682bb4e38b3177dce30093df2e1 Reviewed-on: https://chromium-review.googlesource.com/824265 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#524039}
-
Gauthier Ambard authored
This CL adds an haptic feedback when presenting the "Articles aren't available right now" snackbar. Bug: 794726 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia96d7128bc85c0adfd09f4a2f8a3bb9d9fc76072 Reviewed-on: https://chromium-review.googlesource.com/826629Reviewed-by:
Elodie Banel <lod@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#524038}
-
Ilya Sherman authored
This CL covers all of the remaining uses other than //third_party (and the macro itself). R=sky@chromium.org TBR=wfh@chromium.org Bug: 773850 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Icf1931aee5a5ccba6205a1c711423c596ca39d45 Reviewed-on: https://chromium-review.googlesource.com/823602 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#524037}
-
Stefan Zager authored
R=skobes@chromium.org,chrishtr@chromium.org Bug: Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I13743f230cdc11a53878ea3a9c8d8d63637f5e9f Reviewed-on: https://chromium-review.googlesource.com/826305Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#524036}
-
Gauthier Ambard authored
The clean toolbar should be able to resize to fit a fake safe area. Bug: 794164 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie754943620a5a22d8725bccb640f636da06dbe5e Reviewed-on: https://chromium-review.googlesource.com/822197Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#524035}
-
Takeshi Yoshino authored
Bug: 627682 Change-Id: I752828ced7052c99c03a8004b3e8cd75c50b9550 Reviewed-on: https://chromium-review.googlesource.com/824142 Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#524034}
-
Henrik Grunell authored
Fails on Win7. TBR=chenwilliam@chroimum.org Bug: 794869 Change-Id: Ie32fd675197bd608ce8a236ba0401966f3371b72 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/826628Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#524033}
-
Chris Pickel authored
Brings the Local NTP back in line with the spacing required for certain overly-tall Doodles. Bug: 761994 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7bf8e6aa9e5a3a7035c14b0e1a4c2c2679decc07 Reviewed-on: https://chromium-review.googlesource.com/824239Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Chris Pickel <sfiera@chromium.org> Cr-Commit-Position: refs/heads/master@{#524032}
-
Daniel Bratell authored
Nobody set or read the ui::surface::TransportDIB member sequence_num_ and that made the compiler upset in jumbo builds where the compiler sees more of the whole picture. Change-Id: Ia59e824e9e6175870065336c6403958878d2dba0 Reviewed-on: https://chromium-review.googlesource.com/826063Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#524031}
-
Daniel Bratell authored
Both the real and the testing version of ui::LinuxInputMethodContextFactory were named g_linux_input_method_context_factory which caused collisions in jumbo builds. This renames the testing one to g_linux_input_method_context_factory_for_testing Bug: 773275 Change-Id: Ia11a8a16ce5a40ef4a6469fe5bdcfeab2323e068 Reviewed-on: https://chromium-review.googlesource.com/826064Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#524030}
-
Daniel Bratell authored
In jumbo builds several cc files are compiled in the same translation unit and then the different kClassIdentifier symbols clashed. This renames them to kPeerConnectionRemoteTrackIdentifier and kProcessedLocalAudioSourceIdentifier Bug: 746953 Change-Id: I7fe95ebbef69f4dd3b47258417cc917ba441dd91 Reviewed-on: https://chromium-review.googlesource.com/822191Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#524029}
-
Mostyn Bramley-Moore authored
This top-level 'using namespace' statement gives -Wheader-hygiene warnings in jumbo builds. BUG=794692 Change-Id: Ifc2aea2f04ca580267f1a02892c13b04b27f7073 Reviewed-on: https://chromium-review.googlesource.com/826222 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#524028}
-
Eric Lawrence authored
A comment in KURLTest.cpp is now wrong because our handling of fragment encoding has changed. Fix the comment. Change-Id: I1e8be982d734ca45bb316d73313451b0eb17e204 Reviewed-on: https://chromium-review.googlesource.com/826004Reviewed-by:
-
Zhenyao Mo authored
With this flag specified, Chrome runs in compatibility profile instead of core. This CL also put GeForce GT 120 to compatibility profile. BUG=657817 TEST=manual R=kbr@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I2242883406b0779c7baef914e1f966772f77b7ef Reviewed-on: https://chromium-review.googlesource.com/818186Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
-
Ricky Liang authored
On devices that have camera sensors mounted in portrait orientation, we should set the rotation accordingly; otherwise the displayed frames are not in the correct orientation. BUG=b:32690003 TEST=Make sure the camera preview is displayed correct in the Chrome camera app on scarlet. Change-Id: Ia69a23808a2cd68e0d101289e569ce885b16be1d Reviewed-on: https://chromium-review.googlesource.com/823371Reviewed-by:Wu-Cheng Li <wuchengli@chromium.org> Commit-Queue: Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#524025}
-
Hajime Hoshi authored
We plan to deprecate kUnspecedTimer / kUnspecedLoading / kUnthrottled and introduce kInternal* for internal usages. This CL introduces kInternalTest for tests or mock objects and replaces the current task types with kInternalTest. Doc: https://docs.google.com/document/d/1n9qNbP0H28J4DIzorydemc36b1xy-8-5zEADsoJfMxU/edit# Bug: 794123 Change-Id: If4e616d9b770ff0e5be88261e68c3fd572d05783 Reviewed-on: https://chromium-review.googlesource.com/822792 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#524024}
-
chromeos-commit-bot@chromium.org authored
TBR=chrome-os-gardeners@google.com Change-Id: I5a509bbf7a893b336b610ac0c95e5bdf768694b6 Reviewed-on: https://chromium-review.googlesource.com/826108Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#524023}
-
Tomasz Mikolajewski authored
1. Remove mtomasz from OWNERS. 2. If the last one, then add fukino@ and yamaguchi@. BUG=None TEST=None Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7b7c36f45575aad15a08e63ba7d7c52d6f8d3000 Reviewed-on: https://chromium-review.googlesource.com/816644Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#524022}
-
Jun Choi authored
Changed UTF8 encoding check function in CBOR decoder to include bytes after first embedded NULL byte. Failed cluster fuzz test case : \63\00\00\A6 Bug: 793587 Change-Id: If519678d29568451c121617a2b02079345a14307 Reviewed-on: https://chromium-review.googlesource.com/818731 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Jeffrey Yasskin <jyasskin@chromium.org> Cr-Commit-Position: refs/heads/master@{#524021}
-
Max Morin authored
RenderFrameAudioInputStreamFactory is intended to be exposed to the renderer. The AudioInputStreamHandle class is introduced to bundle a stream and its client. When moving to the audio service, the AudioInputStreamHandle will stay in content/ while the MojoAudioInputStream will be in the audio service. This diagram shows how we want the stream setup to look in the near future: https://docs.google.com/drawings/d/1pSYEqiG46N0OD6rJhfTpohyn2ZkSWsp3ZIHe2PDh0Us/edit Bug: 653871 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I4ff52dbc4797b595e3dd791d1bafa9325a0af9d2 Reviewed-on: https://chromium-review.googlesource.com/771196Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#524020}
-
Scott Violet authored
EasyResizeWindowTargeter may be used to shrink the region of a window you can interact with (the shelf uses this in certain modes). For mus we only support this with a hit-test mask. This patch wires up EasyResizeWindowTargeter to use a hit-test mask when necessary. BUG=775223 TEST=covered by test Change-Id: I3e1b494e890f0f8366ce4a8a1fc64f839a61542f Reviewed-on: https://chromium-review.googlesource.com/826032 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Elliot Glaysher <erg@chromium.org> Cr-Commit-Position: refs/heads/master@{#524019}
-
Xiaohan Wang authored
Given read can be done asynchronously, if decoder Reset() if called while there are outstanding reads, Reset() could be called before Decode() causing out-of-order issues. This CL adds a Flush() call on MojoDecoderBufferReader such that decoder Reset() will only be called after all outstanding decodes have been processed. BUG=792281 TEST=Add even more tests Change-Id: Iaaf5073fcda6c78f85c0d624f1ad11566c8c726f Reviewed-on: https://chromium-review.googlesource.com/823574 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#524018}
-
Luciano Pacheco authored
Convert and merge FrameHostMsg_SmartClipDataExtracted now using Mojo callback directly. Bug: 786836 Change-Id: If2925e9e019854558f8c97cf51e6b0d32b521345 Reviewed-on: https://chromium-review.googlesource.com/804804Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
-
junweifu authored
Load com base functions dynamically at runtime with core_winrt_util. Text Detection only support Latin-1 text as documented in specification[1], the service can't be connected if the language isn't supported on the system. Create OcrEngine interface that provides optical character(OCR) functionality. Add unittest to test the result of Creating OcrEngine. [1] https://wicg.github.io/shape-detection-api/text.html#text-detection-api BUG=790931 Cq-Include-Trybots: master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng Change-Id: I4e171aad11a50197c7cfb64547defa24d0988f3e Reviewed-on: https://chromium-review.googlesource.com/813237 Commit-Queue: Junwei Fu <junwei.fu@intel.com> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#524016}
-
Hiroki Nakagawa authored
Bug: 794837 Change-Id: I429e94757e3d486b32c1ec204ed027f18f0ae1e5 Reviewed-on: https://chromium-review.googlesource.com/826830Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#524015}
-
Victoria Su authored
Implemented :any-link by firstly editing pseudo names for :-webkit-any-link then using the previous name for :any-link. This feature has a use-counter. There are also web platform tests for :any-link and :-webkit-any-link and unit tests for the use-counters. Design doc: https://docs.google.com/document/d/1BzEliD8e8AaAbEiU5lVyaJT341DQrZwktXz59C5HrUE/edit?usp=sharing Intent to Implement: https://groups.google.com/a/chromium.org/d/msg/blink-dev/dJkNHglu1Z0/eodHxUDdAgAJ BUG=788265 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ia17e65588496e561e45fae3216183d93e25ffed4 Reviewed-on: https://chromium-review.googlesource.com/807834 Commit-Queue: Victoria Su <victoriaytsu@google.com> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#524014}
-
Yutaka Hirano authored
We've been using IPC::Message in URLLoaderClientImpl to implement the "deferred loading" feature. This CL replaces it with custom containers having callback parameters, in order to remove IPC messages defined in resources_messages.h. Bug: 788241 Change-Id: I3b5863aa2604c2f3d56c3c0481d88ef865f91b28 Reviewed-on: https://chromium-review.googlesource.com/826882Reviewed-by:
-
Thiemo Nagel authored
Revert of "Cache the brand code to avoid hundreds of repeated reads." commit 04749717. https://codereview.chromium.org/2890943005 Disabling RLZ is communicated through an empty brand code. Thus the value of the brand code must not be cached before RLZ is initialized. BUG=793162 TEST=none Change-Id: I7f9e223a9a39d19408f364f6aad95cb8c86f6d79 Reviewed-on: https://chromium-review.googlesource.com/824363Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#524012}
-
rhalavati@google.com authored
Typo corrected in ADBClientSocket's network traffic annotation. Bug: 656607 Change-Id: I627e41fc48b778e6b8b2ba423707984a02002f71 Reviewed-on: https://chromium-review.googlesource.com/824242Reviewed-by:
-
James Cook authored
Ensure that code associated with the UI Service, which is used on both chromeos and linux-ozone, uses files and functions named *mus*. Reserve *mash* for chromeos-only code that runs under --mash and uses the ash window manager. Bug: 722527 Test: chrome, chrome --mus, and chrome --mash run with target_os="chromeos" and linux-ozone still compiles (I can't run linux-ozone due to xkb issues) Change-Id: I452e80dffb16d6445f40757d1198ff98233bb528 Reviewed-on: https://chromium-review.googlesource.com/822455 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#524010}
-
Yoichi Osato authored
Since this patch, we use ShapeResult.Direction() to get appropriate CharacterRange to paint RTL text such as: <div id="d1">אבג</div> <script> getSelection().setBaseAndExtent(d1.firstChild, 0, d1.firstChild, 1); </script> Bug: 708452 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Id858f508c41b7231e73b25ef11933f88b2b2993e Reviewed-on: https://chromium-review.googlesource.com/821797 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#524009}
-
François Degros authored
Replaced several of scoped_refptr's assignment operators by a unified assignment operator. This works beautifully in tandem with scoped_refptr's different constructors, and it removes some duplicated and tricky code. It is exception safe, and works fine in case of self assignment. We still need to keep operator=(T*), despite the implicit conversion constructor scoped_refptr(T*). There is code assigning rtc::scoped_refptr<T> to scoped_refptr<T>, and we want to keep this code compiling and working as is. rtc::scoped_refptr<T> has an implicit conversion operator to T*. C++ allows one implicit conversion, but not two, to be chained in a row. Marked scoped_refptr's move and swap operations as noexcept. This allows std::vector<scoped_refptr<T>> to use scoped_refptr's more efficient move operations instead of copy operations. This avoids extraneous calls to T::AddRef() and T::Release() when vector is reallocating its internal buffer. Change-Id: Id6f360f8acab827133fe5bef829a7a2e308b87fd Reviewed-on: https://chromium-review.googlesource.com/802338Reviewed-by:
-
Kunihiko Sakamoto authored
This fixes a bug introduced by crrev.com/c/824172. Bug: 778352 Change-Id: Id1dbc552ed5a94a0b5fadddec0b5bea50c3a7597 Reviewed-on: https://chromium-review.googlesource.com/826662Reviewed-by:
-
Xianzhu Wang authored
We planned to launch root-layer-scrolls before SPv175, so now begin to test the SPv175+RLS configuration. Bug: 793675 Change-Id: Ic8c83e7ff694b09f19277181172de31df1fb81dc Reviewed-on: https://chromium-review.googlesource.com/819574 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#524006}
-
Jiaquan He authored
This commit: - hides the AppListModel and SearchModel in chrome; - creates ChromeAppListUpdater to own AppListModel and SearchModel; - forces model accesses to go through ChromeAppListUpdater; - fixes lint errors in affected files. Bug: 733662 Change-Id: I6ae6253516fa9be73e9f84d9aadeb3285ed7d19c Reviewed-on: https://chromium-review.googlesource.com/809495Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/9cfb34e845c8..97e6e42e3e39 $ git log 9cfb34e84..97e6e42e3 --date=short --no-merges --format='%ad %ae %s' 2017-12-13 simonhatch Dashboard - Small refactor. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I12a74d31015cb0d95008e222b8527a1e812c040c Reviewed-on: https://chromium-review.googlesource.com/826132 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#524004}
-
Xiaocheng Hu authored
When spellchecking is globally disabled (via context menu or settings), all spelling markers should be removed. Currently, the marker removal logic is duplicated at two places. This patch unifies the logic and ensures that the removal is done exactly once for each frame. This is also a preparation patch for removing Blink-side maintenance of the global spellcheck enabled status. All-in-one patch: crrev.com/c/821496 Removal plan of Blink-side status: https://goo.gl/grtURZ Bug: 710097 Change-Id: I84d33cef5db2aa6ffeb1b66568dee037cba4a737 Reviewed-on: https://chromium-review.googlesource.com/826259Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#524003}
-
chrome-release-bot authored
TBR=govind@chromium.org Change-Id: I2d539f31a7269f02246d1245e338d5aaf73e9179 Reviewed-on: https://chromium-review.googlesource.com/826445Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#524002}
-
xzhan96 authored
Reason for reland: Fix the flaky build errors by adding a needed dependency in third_party/WebKit/Source/platform/BUILD.gn Original change's description: > Merge all native enums RequestContextFrameType into single mojo enum > > This CL creates blink.mojom.RequestContextFrameType enum type and uses > it to replace existing native enums content::RequestContextFrameType and > blink::WebURLRequest::FrameType. > > This is the preparation to impl the blink.mojom.ServiceWorkerClientInfo, > and finally to remove content::ExtendableMessageEventSource, which is an > incremental step toward Onion Soup: having less dependence on content types > for service worker. > > BUG=782528 > > Change-Id: I6f7787575f1583297a27a0213b1440d01e94e2dd > Reviewed-on: https://chromium-review.googlesource.com/791916 > Commit-Queue: Xiaofeng Zhang <xiaofeng.zhang@intel.com> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#523699} TBR=falken@chromium.org,horo@chromium.org,dcheng@chromium.org,kinuko@chromium.org,yhirano@chromium.org,tsepez@chromium.org,shimazu@chromium.org Change-Id: Ie1a0dc3567cdde59655995c3a06c95ddeac027ea Reviewed-on: https://chromium-review.googlesource.com/823824Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#524001}
-
