- 22 Apr, 2019 40 commits
-
-
Tommy C. Li authored
To prepare for launch, enabling these dy default on tip of tree. Bug: 842236 Change-Id: I0d40540fcfb6262238670ccfbcbe3d7f371e05e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577488Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#652916}
-
Matt Menke authored
Enum classes are safer, and since we're going to use this to create SocketParams objects, too, they're also simpler, as it's a bit weird to convert from an enum class to a bool and then back to the original enum class. Bug: 533571 Change-Id: Iead421aca8137de7428f8e0434806bf8da3577b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561962 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#652915}
-
Raymond Toy authored
Bug: 954593 Change-Id: I438bafec932f44a349fd0ba2e2d9910c194b9149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575177Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#652914}
-
Alex Cooper authored
On windows release 1809 (and presumably up), input was not being routed to the chromium webxr process/threads. This resulted in polling tracked controllers and subscriptions to input events never firing or returning any controllers. This change has no effect on 1803. Bug: 953129 Change-Id: Ifdfbd47906b1d5817e791449ac94235e346ea0e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577485 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#652913}
-
Jarryd authored
This change adds the implementation for three new Blob APIs: stream(), text(), and arrayBuffer(). Related web platform tests: https://crrev.com/c/1526796/ Spec: https://www.w3.org/TR/FileAPI/ Bug: 945893 Change-Id: Ieb06be0e9023685a12eaa79bd77d69cb13fa5412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529716 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#652912}
-
Ryan Hansberry authored
Bug: 954347 Change-Id: I36aa7aaef7f907d5529c50aaf618fd6c85f40636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574486Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#652911}
-
Bo Liu authored
Send frame token from viz display with the presentation feedback. This is more inline with chrome's architecture where viz display service sends this update. There are other code paths that used to deliver CompositorFrameMetadata and they have to call the new path for delivering frame tokens. Eventually should remove CompositorFrameMetadata code paths. SynchronousCompositorHost has to ensure tokens are delivered in order. Previously this worked with metadata version. Now that it's independent, need to explicitly make sure it's delivered in order. For now, only call DidProcessFrame. Eventually should move devtools to frame token and RenderFrameMetadata. Bug: 881469 Change-Id: Ie49e97255d45ba7a7267cce87b37c29fadb302a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576428Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#652910}
-
ccameron authored
This reverts commit 45f012f3. Reason for revert: Broke mac compile Original change's description: > Skia/Metal raster: Add viz::MetalContextProvider > > Add viz::MetalContextProvider, and add Metal to the Skia build by > default. Do not wire up any of this yet. > > Bug: 952063 > Change-Id: I897d052bdbf046114c1ddc0527c1d3cafc8777c5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577296 > Reviewed-by: Brian Osman <brianosman@google.com> > Reviewed-by: Eric Karl <ericrk@chromium.org> > Commit-Queue: ccameron <ccameron@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652899} TBR=ccameron@chromium.org,brianosman@google.com,ericrk@chromium.org Change-Id: Ic0a4f5201df55ac7ef0b8a191b572a9bbeee6dc0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 952063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577783Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#652909}
-
Eric Orth authored
Per-context HostCaches are now used for all resolution cache lookups and cache stores. The old manager-wide cache is gone along with the manager-wide option to enable/disable caching. The ContextHostResolver now also registers/deregisters the caches with HostResolverManager on creation/destruction in order for them to receive invalidation notifications. Note that it appears all callers of HostCache browser data removal already go through appropriate NetworkContexts rather than making assumptions about the cache being global, so it all works out that such cache clearings will clear the relevant per-context caches when NetworkContext gets the cache to clear from its URLRequestContext and ContextHostResolver. Bug: 934402 Change-Id: Icc27f248b86f2140e1306f87008b23b5ff7ac6b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560372 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#652908}
-
Raymond Toy authored
This makes it consistent with other files. No other changes were made. Bug: 954519 Change-Id: I2b737e6c639caba48ad8de974832119691adfbf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575726Reviewed-by:
-
David Benjamin authored
ToString (which is a test-only method so it doesn't really matter) is only call if IsSetConfig, not !IsParseError Bug: 954766 Change-Id: I1e956cb374d5bf9899e16942f6c13868e29e6100 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577563 Commit-Queue: David Benjamin <davidben@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#652906}
-
Tommy C. Li authored
Previously, the Windows 10 Handler navigated to the NTP by making the WebContents load the URL of the NTP. That's is mostly correct, except that it doesn't tell the Browser to update the omnibox. This CL makes the Windows 10 Welcome Handler act the same way as the normal Welcome Handler, which performs a navigation at the chrome/ with a Browser object instead of at the content/ level with a WebContents object. It used to work before accidentally, essentially. Bug: 954120 Change-Id: I5514044f32ae542de52c8aba8c08373de1e84b53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576138 Auto-Submit: Tommy Li <tommycli@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#652905}
-
Xianzhu Wang authored
We want to use NGPhysicalOffsetRect in more places in legacy code, but don't want performance regressions caused by the additional function calls. Some performance measurement (e.g. crrev.com/c/1567095) showed that such small function calls can accumualte to quite big cost if they are called very frequently. Change-Id: I2bbe10669e1c7bbcfae2cf155536fab44136402e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577586 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#652904}
-
Avi Drissman authored
Gate waiting for the update on whether there are other Chrome instances; show a dialog if there are. BUG=948283 Change-Id: I3b1d87150fb6c8058453c68f2e459717124a2db3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566813 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#652903}
-
Khushal authored
Plumb the frame rate of video updates to the display compositor. This information is used to configure the display to tick at the video's frame rate if possible. R=liberato@chromium.org Bug: 938106 Change-Id: Ic720900181f58eddf65069c3a6d4cc480a98efb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556458 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#652902}
-
Kyle Milka authored
On the local NTP we allow background customization even if a theme is installed. Remove the logging for unavailablity due to having a theme installed as it's no longer true. Bug: None Change-Id: Ib181fd959f5e321343789f692f18c1491b53ebbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575637Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#652901}
-
Garrett Beaty authored
Change-Id: Ica0e38196c37e00e2503b8674323b64ce6490554 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576022 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#652900}
-
Christopher Cameron authored
Add viz::MetalContextProvider, and add Metal to the Skia build by default. Do not wire up any of this yet. Bug: 952063 Change-Id: I897d052bdbf046114c1ddc0527c1d3cafc8777c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577296Reviewed-by:
Brian Osman <brianosman@google.com> Reviewed-by:
-
Martin Robinson authored
Orca expects that this API also scroll to the target node onto the screen. Eventually Orca will be able to use the AtkComponent scrolling API, but that isn't widely available yet, so we implement this fallback behavior. Bug: 950530 Change-Id: Id769d32849221591dfdb9ab6e96c07c8fb0e6b4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576561 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Cr-Commit-Position: refs/heads/master@{#652898}
-
Sergey Ulanov authored
CreateNativePixmap() will need to get VkDevice to be able to allocate buffers compatible with the target device. Bug: 852011 Change-Id: I7294fbd48d93c0614f78440b023f63a84b01bae9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570534 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#652897}
-
Brandon Wylie authored
Change the button from wrap_content to a width relative to the width of parent element. Bug: 936052 Change-Id: I63ff28b1329a221255f14113f9ae65dba2cee514 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575361 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#652896}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/fe8eb40a01ae..8c506a537d15 git log fe8eb40a01ae..8c506a537d15 --date=short --no-merges --format='%ad %ae %s' 2019-04-22 norvez@chromium.org chromeos_config: mark cyan as important again Created with: gclient setdep -r src/third_party/chromite@8c506a537d15 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Ie57851f6209b058e393ebb622a0ab654bf1b7f8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576297Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652895}
-
Bailey Berro authored
Previously, we were constructing and returning a unique_ptr solely for the purpose of being able to return a nullptr if a printer was not found. Instead, let's just return an optional which makes more sense for this. Change-Id: I14db20b6f7ffc8855ee48de2eda622fb78ec6b57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572263 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#652894}
-
Dale Curtis authored
Current AV1 content doesn't use many tiles, so we see much better performance by increasing the number of frame threads on systems that can handle the increase versus increasing tile threads. This patch sets the number of tile threads based on current encoding practices and the frame threads based on recommendations from dav1d: https://bugzilla.mozilla.org/show_bug.cgi?id=1536783 It distributes tiles threads and frame threads based on the number of available processors and other //media limits -- preferring to fulfill tile thread recommendations first since the dav1d folk indicate they are more efficient. If a system has the cores for it, we'll now use the following: <300p: 2 tile threads, 2 frame threads. <700p: 3 tile threads, 2 frame threads. <1000p: 5 tile threads, 4 frame threads >1000p: 8 tile threads, 8 frame threads. If we don't have the cores for it; i.e., on systems with <= 3 cores we'll now use less threads. Previously even if a system had <= 3 cores, we would still allocate >= 3 threads (up to 3 tile, and 2 frame). Now, for such systems, we will set frame_threads=1 (which generates no more threads, since the calling thread counts as a thread) and at most 1 more tile thread over the core count. E.g. a 3 core system will use a maximum of 3 tile threads and 1 frame thread. Single and dual core systems will use 2 tile threads and 1 frame thread. BUG=954659 TEST=https://www.youtube.com/watch?v=Fmdb-KmlzD8 plays smoothly; see 1m30s+ for most intense areas. R=chcunningham Change-Id: I82e5725a32a987a98567af9aeba495d248000105 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576158 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#652893}
-
khmel@chromium.org authored
Before tracing was not activated for client tasks due to problem of activating tracing in their processes. Now it is solved and we have extra events to analyze. queueBuffer and dequeueBuffer may have the same hierarchy as surface flinger events that cause false error reporting. This CL adds detection of surface flinger process id and consume events from it. TEST=Locally BUG=b:122555793 Change-Id: I048275c56d21de0c6bf19f07ab472972af8f0e82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574648Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#652892}
-
Robert Ogden authored
Bug: 909915 Change-Id: Ic64749cede88ed4ccfa0a28163fddde9f7f33e82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577489Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#652891}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/65dffa4595e2..109321d1bdd1 Created with: gclient setdep -r src-internal@109321d1bdd1 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=chcunningham@chromium.org,loyso@chromium.org,clamy@chromium.org,flackr@chromium.org Change-Id: Ic3aa61e57d7ffe3002ed959621b9c9a926d7b640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577560Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652890}
-
Matt Simmons authored
This change introduces a new metric Tabs.TimeSinceLastView.onTabClobber. This is emitted when a user focuses the omnibox and then subsequently navigates within a certain amount of time after returning to a tab. This and Tabs.TimeSinceLastView.onTabView are mutually exclusive (per-engagement). Bug: 947572 Change-Id: I61a6fff00197134ca806adf6f94bb8bcfef7416b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551942Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Matt Simmons <mattsimmons@chromium.org> Cr-Commit-Position: refs/heads/master@{#652889}
-
Marijn Kruisselbrink authored
Use three-words "Native File System" everywhere. Also change RuntimeEnabledFeature status from "experimental" to no status, since it should currently only be changed by the base::Feature being enabled. Bug: 853326, 929490 Change-Id: Ifaead92ed2e236dda9661e3f58d02fff017e51f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572251 Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#652888}
-
Chris Cunningham authored
NOTRY=true Bug: 954319 Change-Id: Id8eeeb53df0dc8747b9f4f96ae9a6f5891eef8d1 TBR: alph@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576173Reviewed-by:
-
Peter Kasting authored
This also rewrites the test for style reasons while I'm touching it. Bug: 953836 Change-Id: I2cf956f9fae60a9fc9ef83748e977279a459a2ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572110 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#652886}
-
John Abd-El-Malek authored
This is a reland of 4dd1f3ce. Disabled test in msan as well. Original change's description: > Reland "Move loading of data URLs out of the network process." > > This is a reland of f45ff75d > > Original change's description: > > Move loading of data URLs out of the network process. > > > > For subresources the renderer was already loading it in-process. Now for navigations and downloads, we keep them in the browser process. This avoids: > > 1) sending GURLs bigger than 2MB to a different process, which strips them as they're bigger than url::kMaxURLChars > > 2) having the network process deal with a scheme that's not going over the network, which we avoid > > > > Bug: 937146, 939871 > > Change-Id: I8ca8225308b2a5f1f90594ab06943f0641a5c551 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570805 > > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > > Reviewed-by: Ken Rockot <rockot@google.com> > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > Reviewed-by: David Trainor <dtrainor@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#652196} > > Bug: 937146, 939871 > Change-Id: I480da494a987c9b223c1a571821b35e3bdbc7447 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574881 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652335} TBR=bsep@chromium.org Bug: 937146, 939871 Change-Id: I7088f802cb5fef81021c488aa6426d1a87604e99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577483 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#652885}
-
Nate Chapin authored
A bunch of tests need to be updated for a behavior change in https://chromium-review.googlesource.com/c/chromium/src/+/1526426 These are the ones where the updated test passes before and after the behavior change. Bug: 914587 Change-Id: Ic8b34c4c205ea2f9bf59b620ca6baac47cd7b1ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576025Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#652884}
-
David Black authored
I was unable to repro the bug consistently with an unaltered build. I was able to repro the bug, however, with some local changes in which I posted the UpdateLabel calls to simulate a timing issue. With this change, I was able to reproduce the bug consistently. Bug: b:130758812 Change-Id: I063527e9c52f5584104ce556d3558fc4ed62e228 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577494Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#652883}
-
Martin Robinson authored
Bug: 932708 Change-Id: Ib793df737907234c4ffe7f7d7f591086711d9f81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574721 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#652882}
-
Jun Mukai authored
The animation is already ongoing when the closing is scheduled, Chrome is going to crash without SetTargetState() regardless of the side-shelf state. Bug: 954907, 951853 Test: manually Change-Id: Ic5e67e152341cb96829fd2d1e9e768485f8b2eff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577482Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#652881}
-
Dana Fried authored
This fixes an issue where a context menu opened from the app menu would trigger UMA logging events for the bookmarks bar. Bug: 951907 Change-Id: I4521b6b7101e2c662f347f479130201482617d6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574682Reviewed-by:
-
Wei Li authored
Status bubble text was drawn with certain transparency. When it was changed to be drawn on a label, the color would be automatically computed based on foreground and background colors, which makes the text color even lighter with some themes. We fix that by disable auto color readability on that label. BUG=952061 Change-Id: I25ec54aa82c4d62e7fa67f146f0e7c9e39511eac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565504 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#652879}
-
Sébastien Séguin-Gagnon authored
Record when the infobar is shown, opened and dismissed. Bug: 942747 Change-Id: I76b8dbfc3538d7095eb2a9f0d4e96706954c0493 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574833 Auto-Submit: sebsg <sebsg@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#652878}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/76c5c490d194..4b68d1e3e421 git log 76c5c490d194..4b68d1e3e421 --date=short --no-merges --format='%ad %ae %s' 2019-04-22 crouleau@chromium.org Speculatively reduce parallelism in metrics calculations to prevent d8 error. Created with: gclient setdep -r src/third_party/catapult@4b68d1e3e421 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:953365 TBR=charliea@chromium.org Change-Id: Id0e080bd242a0b35657db6b10230642d5d13218d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576292Reviewed-by:
-
