GitLab

It takes 1-3 seconds on Release and ~10 seconds on Debug.

TBR=brucedawson@chromium.org
BUG=647192
NOTRY=true

Review-Url: https://codereview.chromium.org/2342803002
Cr-Commit-Position: refs/heads/master@{#418832}

This is a refactoring patch which stores the definite/indefinite height
detection in a new attribute m_hasDefiniteLogicalHeight in LayoutGrid.
That way we just only call LayoutBlock::hasDefiniteLogicalHeight() once,
from LayoutGrid::layoutBlock(). Then in LayoutGrid::gridTrackSize()
we reuse the cached value.

No new tests, no change of behavior.

BUG=624301

Review-Url: https://codereview.chromium.org/2334133002
Cr-Commit-Position: refs/heads/master@{#418831}

This test consistently takes 2 seconds on Release and 10 seconds on
Debug, thus it meets the bar of Slow tests.

TBR=brucedawson@chromium.org
BUG=647192
NOTRY=true

Review-Url: https://codereview.chromium.org/2342043002
Cr-Commit-Position: refs/heads/master@{#418830}

This cl splits the big CL with changes to net/ folder and
has changes only to net/nqe and some url_request tests
according to the changes to URLRequest API.

What the big cl does:
It modifies net/ clients that use URLRequest API as long as
URLRequest::Read returns int net errors and
URLRequest::Delegate and NetworkDelegate methods
(for example, OnResponseStarted or OnCompleted) have int
net_error in the arguments now.

The reason behind splitting the CL into small one is that
an android bot started to be unstable and unittests became
flaky. It was not possible to locate the problem and the
decision was to split the CL and upload small parts with a
6+ hours interval in order to make it possible to locate
the problematic code.

The big CL is located here -
https://codereview.chromium.org/2265873002/

BUG=423484

Review-Url: https://codereview.chromium.org/2332643002
Cr-Commit-Position: refs/heads/master@{#418829}

This CL introduces seven new fuzzers for WebAssembly which test the
decoding of single sections in the WebAssembly module decoder.

R=mmoroz@chromium.org

Review-Url: https://codereview.chromium.org/2344823002
Cr-Commit-Position: refs/heads/master@{#418828}

This CL renames '-webkit-clip-path' to 'clip-path', and makes the former
an alias of the latter.
For LayoutSVGRoot, clip-path is now applied only by the PaintLayer and
not by SVGPaintContext.

Intent-to-ship:

https://groups.google.com/a/chromium.org/d/topic/blink-dev/FBE05hzCmPo

BUG=633028
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2312713002
Cr-Commit-Position: refs/heads/master@{#418827}

This patch adds UMA to measure time to open hyphenation dictionary.

The previous CL[1] added UMA that includes IPC as "Hyphenation.Open",
but this metric measures the time of the file task without the IPC.

[1] 2113933003

BUG=605840

Review-Url: https://codereview.chromium.org/2340613002
Cr-Commit-Position: refs/heads/master@{#418826}

This exercises webview state save/restore, and also makes using the
shell as a testing/demonstration tool easier, because the current URL
is retained and reloaded when you switch webview providers.

BUG=
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2330013002
Cr-Commit-Position: refs/heads/master@{#418825}

TransparentButton has state-change animations enabled despite being invisible,
which causes a bunch of spurious repaints of the combobox on mouse enter/exit.

BUG=645266

Review-Url: https://codereview.chromium.org/2327673003
Cr-Commit-Position: refs/heads/master@{#418824}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/5148bd4b2be6..3cc40b373729

$ git log 5148bd4b2..3cc40b373 --date=short --no-merges --format='%ad %ae %s'
2016-09-15 perezju Revert of "[telemetry] Wire TsProxy through telemetry's network stack." (patchset #1 id:1 of https://codereview.chromium.org/2335403003/ )

BUG=639632

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2341723004
Cr-Commit-Position: refs/heads/master@{#418823}

There's no longer any WebSocket files under content/common/.

R=yhirano@chromium.org,jochen@chromium.org
BUG=none

Review-Url: https://codereview.chromium.org/2344613005
Cr-Commit-Position: refs/heads/master@{#418822}

Previously, internals.isPreloaded() depends on |ResourceFetcher::m_preloads|,
which is cleared by ResourceFetcher::clearPreloads().
This caused internals.isPreloaded() to turn false after around document's
load event.

This CL makes ResourceFetcher to keep a set of preloaded URLs (separately
from |m_preloads|) if a blink::Internals object is created, and use the set
to calculate internals.isPreloaded().

BUG=643621

Review-Url: https://codereview.chromium.org/2332333003
Cr-Commit-Position: refs/heads/master@{#418821}

This patch converts "editing/inserting/insert-at-end-0[12].html" to use w3c test
harness to simplify test script, and consolidates into "insert_at_end.html"
since these scripts use similar sample, for improving code health.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2339853002
Cr-Commit-Position: refs/heads/master@{#418820}

Some EGL drivers do not support binding one component textures to an
EGL image. One component textures are used for YUV video frames, so
to support those drivers in WebView, we need to do YUV to RGB
conversion in software, and then upload an RGB texture instead of a
set of 3 Y,U,V textures.

BUG=579060, 632461
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2242453002
Cr-Commit-Position: refs/heads/master@{#418819}

The Android policy cache was originally created to avoid Strict Mode
violations, but doesn't do so in Webview. Actually, although reading
the app restrictions on the UI thread is a strict mode violation it
is unlikely to cause UI visible delays, As such the solution is to
simply to allow file reads in this component.

BUG=628627

Review-Url: https://codereview.chromium.org/2322963002
Cr-Commit-Position: refs/heads/master@{#418818}

BUG=498716

Review-Url: https://codereview.chromium.org/2316263002
Cr-Commit-Position: refs/heads/master@{#418817}

Makes indexed properties return undefined if the index is out of range.

BUG=229750

Review-Url: https://codereview.chromium.org/2341723002
Cr-Commit-Position: refs/heads/master@{#418816}

Revert of Implement QuicHttpStream::GetLoadTimingInfo (patchset #7 id:200001 of https://codereview.chromium.org/2324183002/ )

Reason for revert:
URLRequestQuicTest.TestTwoRequests is flaky, see https://crbug.com/647071.

Original issue's description:
> Implement QuicHttpStream::GetLoadTimingInfo
>
> This CL implements QuicHttpStream::GetLoadTimingInfo.
>
> |dns_start| and |dns_end| are obtained in
> QuicStreamFactory::Job::DoResolveHost and
> DoResolveHostComplete. These two values are passed to
> QuicChromiumClientSession's constructor.
>
> |connect_start| and |connect_end| are obtained in
> QuicChromiumClientSession::CrytoConnect() and when
> handshake is confirmed.
>
> |ssl_start| and |ssl_end| are the same as |connect_start|
> and |connect_end| because QUIC always does encryption.
>
> If a session is reused, the connect_timing fields should
> all be null. This CL also sets
> |socket_reused| field of LoadTimingInfo accordingly.
>
> BUG=637051
>
> Committed: https://crrev.com/5608fc1bd4f0a80b6d1996f3f4059f2efa0a0777
> Committed: https://crrev.com/83ac2f22700c563fef8a670ad4c5c57d34032e03
> Cr-Original-Commit-Position: refs/heads/master@{#417969}
> Cr-Commit-Position: refs/heads/master@{#418567}

TBR=rch@chromium.org,xunjieli@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=637051

Review-Url: https://codereview.chromium.org/2341033002
Cr-Commit-Position: refs/heads/master@{#418815}

BUG=

Review-Url: https://codereview.chromium.org/2338293002
Cr-Commit-Position: refs/heads/master@{#418814}

path() is being deprecated, GetPath() has better checking against wrong use.

For more context, see https://codereview.chromium.org/2275553005/.

BUG=640599

Review-Url: https://codereview.chromium.org/2317023003
Cr-Commit-Position: refs/heads/master@{#418813}

This patch converts "editing/inserting/insert-div-02[34].html" to use w3c test
harness to simplify test script, and consolidates into
"insert_paragraph_and_style.html" since these scripts were committed in same
patch, for improving code health.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2338013005
Cr-Commit-Position: refs/heads/master@{#418812}

Refactor disk_mount_manager_unittest by replacing gmock with a dedicated mock class of DiskMountManagerObserver.

This change is based on
https://codereview.chromium.org/2333983004/
which was once merged but reverted by
https://codereview.chromium.org/2343593002/

BUG=641943
TEST=chromeos_unittest build with is_asan and is_lsan = true in gn args, and run with ASAN_OPTIONS="detect_leaks=1 symbolize=1" environment variable.

Review-Url: https://codereview.chromium.org/2341923003
Cr-Commit-Position: refs/heads/master@{#418811}

PR for DOM Standard is: https://github.com/whatwg/dom/pull/329

Note: Blink's IDL uses [Unscopeable], instead of [Unscopable].
I have filed a bug: https://bugs.chromium.org/p/chromium/issues/detail?id=647133.

Let me omit to add a layout test. It should be covered in WPT.

BUG=643869

Review-Url: https://codereview.chromium.org/2343783002
Cr-Commit-Position: refs/heads/master@{#418810}

BUG=636710

Review-Url: https://codereview.chromium.org/2340733002
Cr-Commit-Position: refs/heads/master@{#418809}

BUG=617056
TBR=rdevlin.cronin@chromium.org

Review-Url: https://codereview.chromium.org/2331423006
Cr-Commit-Position: refs/heads/master@{#418808}

This CL fixes an issue where the CBD button would stay grey after the
CBD button was activated via spacebar.

BUG=640894
NO_DEPENDENCY_CHECKS=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2282403002
Cr-Commit-Position: refs/heads/master@{#418807}

I have mistyped the mixin name. Sorry.

BUG=645295
TBR=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2331423007
Cr-Commit-Position: refs/heads/master@{#418806}

It seems that for "group" labels GN does not include data of dependencies
declared as "deps", but it would be convenient if we could refer to
chromium_builder_perf group to query all the runtime dependencies of the
test binaries.  This change does not touch dependency logic, though: all
the prerequisites of chromium_builder_perf continue to build as before.

The runtime_deps of this target can then be used, e.g., to make archive
with all the files required to run all (telemetry-based and binary)
performance tests.

R=jochen,thakis

Review-Url: https://codereview.chromium.org/2337153002
Cr-Commit-Position: refs/heads/master@{#418805}

path() is being deprecated, GetPath() has better checking against wrong use.

For more context, see https://codereview.chromium.org/2275553005/.

BUG=640599

Review-Url: https://codereview.chromium.org/2317123002
Cr-Commit-Position: refs/heads/master@{#418804}

Currently, invalidate_shadow_on_frame_swap_ is not set when a MacViews window is
shown. It is only set when the layer is created, changed or the window resized.
This causes translucent windows like the "Restore Pages" bubble and Find-In-Page
window to not have a shadow, when they are shown after being hidden.

This CL modifies BridgedNativeWidget::OnVisibilityChanged() to trigger shadow
invalidation while showing translucent windows. This fixes the shadow for the
"Restore Pages" bubble and also of the Find-In-Page window on tab switching. A
unit test is also added which demonstrates the problem.

Note that this does not fix the shadow for the Find-In-Page window when it is
displayed initially on pressing Cmd+F.

BUG=636707, 646734

Review-Url: https://codereview.chromium.org/2336983002
Cr-Commit-Position: refs/heads/master@{#418803}

Revert of Magnifier border is now more visible on light backgrounds. (patchset #8 id:180001 of https://codereview.chromium.org/2269383002/ )

Reason for revert:
Caused leaks in unit tests.

https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/16164

=================================================================
==1214==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 24 byte(s) in 1 object(s) allocated from:
    #0 0x647f4b in operator new(unsigned long) (/b/swarm_slave/w/irbU0iLK/out/Release/ash_unittests+0x647f4b)
    #1 0x18e142f in ash::PartialMagnificationController::CreateMagnifierWindow(aura::Window*) ash/magnifier/partial_magnification_controller.cc:323:31
    #2 0x18e1fd4 in SetActive ash/magnifier/partial_magnification_controller.cc:236:5
    #3 0x18e1fd4 in ash::PartialMagnificationController::OnLocatedEvent(ui::LocatedEvent*, ui::PointerDetails const&) ash/magnifier/partial_magnification_controller.cc:259
    #4 0x26cab42 in DispatchEvent ui/events/event_dispatcher.cc:191:12
    #5 0x26cab42 in ui::EventDispatcher::DispatchEventToEventHandlers(std::vector<ui::EventHandler*, std::allocator<ui::EventHandler*> >*, ui::Event*) ui/events/event_dispatcher.cc:170
<snip>

Original issue's description:
> chromeos: Magnifier border is now more visible on light backgrounds.
>
> Previously the partial magnifier border was difficult to see on white colored backgrounds. I add a textured layer instead of a solid color, so the border is outlined in black, so that it is visible on all backgrounds.
>
> BUG=638996
> TEST=none
>
> https://screenshot.googleplex.com/htWDLX1Bxdp
>
> Committed: https://crrev.com/da331ee46dfead28a5b2af2379f9fad320509957
> Cr-Commit-Position: refs/heads/master@{#418785}

TBR=jdufault@chromium.org,jamescook@chromium.org,sammiequon@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=638996

Review-Url: https://codereview.chromium.org/2344843002
Cr-Commit-Position: refs/heads/master@{#418802}

Currently the test passes even without the original fix for bug 611679
(https://codereview.chromium.org/1978793002/patch/40001/50002).
I checked that this CL makes the test proper again (it fails without
the bug fix).

Discussed in https://codereview.chromium.org/2225053002/
(see most recent comments).

BUG=611679
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2339133002
Cr-Commit-Position: refs/heads/master@{#418801}

If we're in flipped blocks writing mode (i.e. vertical-rl), the flow thread
block offset we're dealing with may be a logical end point, and end points are
exclusive. This means that we need to pick the previous column, not the next,
if the offset is exactly at a column boundary.

Let flowThreadTranslationAtOffset() and columnIndexAtOffset() take a
PageBoundaryRule argument to handle this.

This makes offsetLeft and offsetTop work properly in vertical-rl writing mode
for elements that end at column boundaries. Added a test for that, and threw in
a vertical-lr test too, for good measure.

Remove ColumnIndexCalculationMode from columnIndexAtOffset(). It was partially
and inaccurately used to make sure we didn't escape the valid column range in
case an exclusive end offset was passed. Have the call sites that really need
to clamp the column index do it themselves. It's up to the callers to decide
how to treat offsets outside the range of columns anyway.

Review-Url: https://codereview.chromium.org/2339973002
Cr-Commit-Position: refs/heads/master@{#418800}

Revert of [worklets] Introduce ThreadedWorkletMessagingProxy and AnimationWorkletMessagaingProxy. (patchset #8 id:180001 of https://codereview.chromium.org/2312493002/ )

Reason for revert:
Caused leaks in a number of layout tests.

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/22941

Original issue's description:
> [worklets] Introduce ThreadedWorkletMessagingProxy and AnimationWorkletMessagaingProxy.
>
> This patch does the plumbing from the animationworklet to the globalscope to import scripts etc.
>
> BUG=567358
>
> Committed: https://crrev.com/4bd1a1b4e1d321526cfe0c10adc15f507a661bb8
> Cr-Commit-Position: refs/heads/master@{#418765}

TBR=nhiroki@chromium.org,hongchan@chromium.org,yhirano@chromium.org,majidvp@chromium.org,ikilpatrick@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=567358

Review-Url: https://codereview.chromium.org/2342013002
Cr-Commit-Position: refs/heads/master@{#418799}

path() is being deprecated, GetPath() has better checking against wrong use.

For more context, see https://codereview.chromium.org/2275553005/.

This CL does two non-trivial changes in addition to the mechanical renaming and reformatting:
* In components/nacl/browser/pnacl_translation_cache_unittest.cc, and
* in chrome/browser/media_galleries/fileapi/itunes_data_provider_browsertest.cc
the CL modifies the test code to keep track whether the ScopedTempDir was initialised and can vend the path, or whether it was not, and cannot be asked for the path. In both cases, before this CL, ScopedTempDir needed to trust the test code to not to store any files under the uninitialised path. After the CL, ScopedTempDir can assume that whenever it vends the path, files may be written under it, and the contract of not touching the uninitialised path stays limited to the test and the tested code.

BUG=640599
R=mseaborn@chromium.org, reillyg@chromium.org
TBR=rsesek@chromium.org, blundell@chromium.org, sergeyu@chromium.org

Review-Url: https://codereview.chromium.org/2318033002
Cr-Commit-Position: refs/heads/master@{#418798}

This CL also changes TestVolume::CreateRootDirectory to handle that GetPath()
(unlike path()) cannot be called before initialising the ScopedTempDir. Because
CreateRootDirectory apparently can be called multiple times from
FakeTestVolume, it needs to handle that and not initialise the directory twice.
On the other hand, the directory cannot be initialised from anywhere else, so
this CL made this clear by adding a Boolean member root_initialized_ which is
updated and checked by CreateRootDirectory. Using the Boolean member, unlike
just handling the fact that the directory has been already initialised (this
information is still possible to retrieve via Take()+Set()), makes it clearer
that the assumption is the directory only being initialised where also
root_initialized_ is set.

R=achuith@chromium.org
BUG=640599

Review-Url: https://codereview.chromium.org/2345473002
Cr-Commit-Position: refs/heads/master@{#418797}

Cr-Commit-Position: refs/heads/master@{#418796}

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

Miscellaneous minor cleanups were applied.

BUG=637812

Review-Url: https://codereview.chromium.org/2341693002
Cr-Commit-Position: refs/heads/master@{#418795}

Removed ConnectionToClient::OnInputEventReceived(), which was never used.
Removed timestamp from VideoFrame protobuf: it was used only for perf
tests that have been removed.

Review-Url: https://codereview.chromium.org/2334293002
Cr-Commit-Position: refs/heads/master@{#418794}

This reverts commit d0125b8f.

Reason:
Warnings from ServiceWorkerGlobalScope doesn't show up in devtools' console

BUG=594160
TBR=eostroukhov, pfeldman

Review-Url: https://codereview.chromium.org/2344813002
Cr-Commit-Position: refs/heads/master@{#418793}