- 25 Sep, 2020 40 commits
-
-
Eric Orth authored
This struct is designed for use outside the network stack and is used as part of the NetworkService mojo API. Bug: 1129993 Change-Id: I6990e3f65a6a8a5a4d10d2f2f182288c4a0fc697 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427024 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#810785}
-
Tom Anderson authored
This is needed since some distros do not have libwayland-client available. If systems don't have libwayland-client, they definitely won't have a wayland server either, so it doesn't make sense to statically link libwayland-client, which won't make wayland work and will only waste binary size. Instead, this CL dynamically loads libwayland-client if available. Also, this CL includes some misc fixes to fix the 'ninja all' build for Linux/ozone. R=msisov Bug: 1126894 Change-Id: Ice0fd0b113f5d804cd05089bfad54168d94c53e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416941 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#810784}
-
minch authored
Bug: 1131543 Change-Id: I20ce373294ea711389bcf7673e49eb94fbce07b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431555Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#810783}
-
Olga Sharonova authored
To be observed during experimentation with "OptimizedRealtimeThreadingMac" feature. Should be removed after the feature launched (or cancelled). Bug: 1112952, 1132225 Change-Id: Id8dad2f4de06f61cf3ac1c2e3ba470a5cf223b75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429273 Auto-Submit: Olga Sharonova <olka@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#810782}
-
chrome://omniboxmanukh authored
This CL includes version info (e.g. version, channel, OS, CL, etc) in the JSON download and copy exports. This was already included in batch exports. Bug: 891303, 987279 Change-Id: Ic1b04046320b366b56b7629edbe65892d4fc3c70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432045Reviewed-by:
Orin Jaworski <orinj@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#810781}
-
Egor Pasko authored
This is often necessary on Android to read /proc/self/pagemap. Without prctl(PR_SET_DUMPABLE) opening this file fails in 94% of cases on Canary. This potentially leads to bias in reporting MappedAndResidentMemoryFootprint2. What happened since it last landed as http://crrev.com/809373 * Facepalm and negate the condition in PCHECK, prctl returns zero on success * Actually tested the change on a local non-rooted Pixel 2 device with a release official build with android_channel = canary Bug: 1070618 Change-Id: I99b1a4c8bf820fb22e50b49e72522f8ece1e251d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429763 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#810780}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3d9856b0..5eff1172 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5324a11530ae228015eb2dc466d1876738e69015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432046Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810779}
-
Mohamed Amir Yosef authored
Before this CL: When parsing the server response, the field signatures were captured from the processed form by aligning them with the server response. After this CL: Field signatures are read from the server response. Form signatures ,however, are still computed from the processed forms by aligning them with the server response. Bug: 1114655 Change-Id: Id905b8f05c5c0009f34e3147cefd81f79c27ae9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428925Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#810778}
-
Michael Ludwig authored
For some reason, the rebaseline script did not detect a different expected image for 2-comp.html on Mac10.14 for this CL: https://chromium-review.googlesource.com/c/chromium/src/+/2423314 Bug: skia:10205 Change-Id: I8ceb48dbd0a97d2a5ed1ebfacacbab9f7c458732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432744 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Auto-Submit: Michael Ludwig <michaelludwig@google.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#810777}
-
Lei Zhang authored
- Use base::StrCat() to more efficiently concatenate strings. - Use the base::span version of base::Base64Encode(). - Get rid of the weird scoping in CopyImageToClipboard(). - Use base::MakeRefCounted() instead of the new keyword. Change-Id: Ia36fe209b48851000fa875f9e38366660081b8eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429973Reviewed-by:
Ricardo Quesada <ricardoq@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#810776}
-
Karandeep Bhatia authored
Node::GetExecutionContext can return null after the document has been shut down. Early return in SVGFEImageElement::FetchImageResource to prevent a null dereference. BUG=1125293 Change-Id: I130840104b61f072c3c2d3b4d067d6d0be0789c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411394 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#810775}
-
Collin Baker authored
This IPH is currently not in use. With the new FeaturePromoController system re-adding it will be much simpler if needed. Bug: 1106523 Change-Id: Iae709121eaf090aa9ea6e13949918f45854fd08f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432524Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#810774}
-
Francois Doray authored
TBR=battre@chromium.org Bug: 1076487 Change-Id: Ic2671b38d51dbd694f4603f2a1d779567084e854 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432365Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#810773}
-
Elaine Chien authored
Bug: 1130078 Change-Id: I71622631b40a4ab0eaf32cbaa5e98fa85b701ef7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431559Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#810772}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I0413cedd44d3730ff576956f1906cf35bff83249 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432265Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810771}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1601034748-4cd4b98b310bb3013acaee2e7944821542e902f7.profdata to chrome-win32-master-1601045991-448e0de5114b8171193e6ee9ab99aeaf1d5de1aa.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com Change-Id: If665bd6a221959b1be1bf1fd7cde9fc1b32cf0b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432282Reviewed-by:
-
Jarryd authored
In the storage pressure check, we multiply available space by 100. The max value of an int64_t is 2^63, so an overflow could happen on a disk whose size is at least 2^63 / 100 ~= 92 PB. This change refactors the storage pressure check by representing the storage pressure threshold (2%) as 0.02 rather than 2, which allows us to remove the multiplication by 100 on the other side of the equation. Bug: 1127237 Change-Id: If3d5a89ee2cd8ea8f0beabf1a38ae71a14d3ff52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429365Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#810769}
-
Ajit Narayanan authored
This CL only affects the behavior of Select-to-Speak when STS is triggered by selection followed by Search-S (it does not affect STS triggered from the tray or by mouse selection). Since keyboard selection does not highlight any nodes marked user-select:none, STS follows the visual behavior here by ignoring these nodes when spoken out as well. While this causes the behavior to be inconsistent between mouse- and keyboard-based invocation, it follows the user's mental model: when a rectangular selection is made with the mouse, STS speaks out everything within the rectangle that the user draws, whereas when a selection is made with the cursor and STS invoked from the keyboard, STS speaks out whatever was actually selected. Also added a browser test to verify this behavior. Bug: 830106 Change-Id: I8552e7bda40f150df2ab4bb0338de706a717f30e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426973 Commit-Queue: Ajit Narayanan <ajitnarayanan@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#810768}
-
Michael Thiessen authored
Mostly straightforward changes, migrated a few junit tests to batched instrumentation tests without issue. Also, added a version to the MostVisitedSitesMetadataUtils so that further updates to the cache structure can be made without invalidating the existing cache. The cache is currently unused, so my breaking change shouldn't cause any problems. Bug: 783819 Change-Id: I25f2fb281c495d15e8a05b9f64fcfc79cc5733fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426731Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#810767}
-
Xiaocheng Hu authored
The feature is already shipped with M83. Now that 4 milestones have passed, this patch removes the flag and the dead code paths. Bug: 441925 Change-Id: I4bebfcf8b1277ddc29c4f4448ff778496ea5e30b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429825 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#810766}
-
Tom Anderson authored
BUG=1066670 R=sky Change-Id: I146a8e396afc20341d9feac27a0115beba227d39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429933 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#810765}
-
chrome://managementChris Lu authored
This reverts commit 46c6817b. Reason for revert: Chromium upsteam Egtest failing https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8868162076936730176/+/steps/ios_chrome_integration_eg2tests_module_iPhone_6s_13.6_on_Mac-10.15/0/stdout [12:20:39:INFO] Interaction cannot continue because the desired element was not found. [12:20:39:INFO] [12:20:39:INFO] Check if the element exists in the UI hierarchy printed below. If it exists, adjust the matcher so that it accurately matches the element. [12:20:39:INFO] [12:20:39:INFO] Element Matcher: [12:20:39:INFO] Omnibox contains text 'support.google.com' Original change's description: > [ios] Add EG test to chrome://management page > > Added EG test to chrome://management page. > > Updated omniboxContainingText: matcher to avoid crash when the > element is not an UITextField. > > Bug: 1131052 > Change-Id: Ia68ad5a6071867e8ae3cf4751ce1ef792cd741dd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424546 > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Reviewed-by: Mike Dougherty <michaeldo@chromium.org> > Reviewed-by: Sergio Collazos <sczs@chromium.org> > Commit-Queue: Tina Wang <tinazwang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810645} TBR=michaeldo@chromium.org,sczs@chromium.org,gambard@chromium.org,tinazwang@chromium.org Change-Id: I3ca8a0e6d189ec6c8045439abc6b76c8bbaafb6d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1131052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432316Reviewed-by:
-
Justin Cohen authored
This reverts commit 785cd90b. Reason for revert: Better fix here: https://chromium-review.googlesource.com/c/chromium/src/+/2432053 Original change's description: > ios: Block universal links during restore. > > NOTRY=True > Bug: 1129875, 1132099 > > Change-Id: I901f4aea4a0df4e33c23c848289acb0aa2561369 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430290 > Commit-Queue: Justin Cohen <justincohen@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Reviewed-by: Ali Juma <ajuma@chromium.org> > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Reviewed-by: Mike Dougherty <michaeldo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810720} TBR=rohitrao@chromium.org,ajuma@chromium.org,justincohen@chromium.org,eugenebut@chromium.org,michaeldo@chromium.org,mrefaat@chromium.org,gambard@chromium.org Change-Id: I7b48feab29a592af07c8ebf4a1540fe6279bc04e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1129875 Bug: 1132099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432132Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#810763}
-
Erik Chen authored
This CL adds the basic plumbing necessary for Lacros to avoid calling unavailable methods on ash due to ash being too old. This requires modifying browser tests to disable all crosapi functionality, and to modify production logic to avoid using crosapi functionality if it's unavailable. Bug: 1130810 Change-Id: Iedf7faae93372e42c59a61186df49d683d859f50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424544Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#810762}
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 87-4262.0-1600690455-benchmark-87.0.4265.0-r1 to 87-4262.0-1600690455-benchmark-87.0.4274.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I65ae4ef6a5254f306b79049df3a89d165868277c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432280Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 87-4258.0-1600689257-benchmark-87.0.4265.0-r1 to 87-4258.0-1600689257-benchmark-87.0.4274.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I1bcbb0f8f71cff4a689d2450bcb5f6bfe39f02fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432283Reviewed-by:
-
Eric Willigers authored
When navigator.share() is called with files, the files are saved to a new directory, and sharesheet::SharesheetService is used to present the user with a choice of share targets. ShareServiceUnitTest now adds blobs to blob storage context. Test cases TotalBytes and FileBytes are removed as they became redundant with https://chromium-review.googlesource.com/c/chromium/src/+/2415431 and they risk flakiness by creating large blobs. Spec: https://w3c.github.io/web-share/#share-method Bug: 1110119 Change-Id: I8c7d44f899cf8c0d31cd87fcb0ce77b25f5a98b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422107 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Maggie Cai <mxcai@chromium.org> Reviewed-by:
Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#810759}
-
Sinan Sahin authored
Currently, the ContextMenuPopulator is a per-tab object. This requires us to pass the same set of params to #buildContextMenu() and then #onItemSelected(). Also, other methods of the class are called with the same params multiple times. This CL creates a ContextMenuPopulatorFactory and makes the ContextMenuPopulator a per-menu object. This way, we can reduce the number of params the class methods take, and we don't need to call the same methods with the same set of params many times. Change-Id: Iacfab7b35fad60cf191ea84443b456f8b60c43c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427137 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#810758}
-
François Doray authored
This reverts commit 8986879b. Reason for revert: Tests are still flaky, see bug. Original change's description: > Ad metrics: Re-enable CreativeOrigin*Browser* tests that were flaky. > > Flakiness may have been fixed by > https://chromium-review.googlesource.com/c/chromium/src/+/2290775. > Re-enable and monitor tests for any signs of further flakiness. > > Bug: 1098373 > Change-Id: I3bb147b3b5fd7a1ec8fd17d99e5db44008278c80 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391722 > Reviewed-by: Josh Karlin <jkarlin@chromium.org> > Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810661} TBR=jkarlin@chromium.org,cammie@chromium.org Change-Id: I06884bc864eb74fc8c7274785f66f289ffd82093 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1098373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432366Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 87-4247.0-1600681610-benchmark-87.0.4265.0-r1 to 87-4247.0-1600681610-benchmark-87.0.4274.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ib2f3baac726e494533dc682455336c0391838bf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432276Reviewed-by:
-
Kramer Ge authored
For SeqLocks, it is recommended for data accesses protected by the SeqLock to be atomics. Hence, we are adding atomic memcpy functions to save the inconvenience for users having to implement their own atomic accessors. Use std::atomic in seqlocks instead of atomicops.h. unittest: Use atomic memcpy functions instead. Test max_retries feature of ReadBegin. Fix: Use std::atomic in tests See: http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2019/p1478r1.html https://www.hpl.hp.com/techreports/2012/HPL-2012-68.pdf Bug: 1132012 Change-Id: I0dad5d63cbc9e30ec44535b35fce62fe7c66b2be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572369Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#810755}
-
Sammie Quon authored
This is a reland of 4c93f79b. The original change patch is in ps1. The reason for the revert was an error was something with managing GPU textures (mailbox name not found). Tried copying some GPU test code [1] but still got the same error and was building up a lot of GPU dependencies. Instead of creating fake output, this cl wraps the existing TakeScreenshot calls and puts a waiter in. [1] https://source.chromium.org/chromium/chromium/src/+/master:components/viz/test/fake_skia_output_surface.cc;drc=361ef8a161b516ba106966bb0740314c41dc2678;l=272 Original change's description: > desks: Add tests for RootWindowDeskSwitchAnimator. > > Test: added > Bug: 1111445 > Change-Id: I0f79be1c09d4ef0eeff276e3c50f491efbe56244 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380517 > Reviewed-by: Khushal <khushalsagar@chromium.org> > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809854} Bug: 1111445 Change-Id: Ib4e50c22fb063b82f50c3f4f79bb026e648a6157 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429363 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#810754}
-
Alexander Surkov authored
Bug: 1131921 Change-Id: Id8b5a92a3c74763a57cf267caee612e158045875 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429251Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Alexander Surkov <asurkov@igalia.com> Cr-Commit-Position: refs/heads/master@{#810753}
-
Stepan Khapugin authored
Removes the surprisingly few unused includes and GN deps I could find. Fixed: 1045664 Change-Id: I2cab2467857b1d60b527911cc54074af8f8e5677 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424253 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#810752}
-
Morten Stenshorne authored
It was failing with LayoutNG block fragmentation due to subpixel differences. Rounded border painting is very sensitive to what layers are involved, it seems. In legacy multicol we establish a layer for the flow thread and perform clipping and translation to slice the tall single column (internal representation) into columns (what you see on screen). This is not the case for NG block fragmentation, where we just paint stuff, without any additional clipping. The ref had some absolute positioning and clipping. which appeared to match the layer situation when legacy multicol was used (but not NG). We already have plenty of coverage for rounded borders in block fragmentation in wpt/css/css-break/ , e.g. borders-003.html Bug: 829028 Change-Id: If5ce0626f004acb0466497e0f1eee06ddeccbd38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429009Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#810751}
-
Patrick Noland authored
This only requires giving TabSwitcherModeTTCoordinatorPhone a MenuButtonCoordinator and setting the MenuButton view once inflation happens. The logic removed (tinting, setting the onClick/accessibilityDelegate) is now handled internally by MenuButtonCoordinator/MenuButton. Bug: 1086676 Change-Id: Iafbe6539974406fcd3db0f8a904e581d355a872b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411401 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#810750}
-
James Vecore authored
When testing with Nearby Share we were seeing crashes during Bluetooth socket sending. When ever the crash happened we would see the same write_request getting processed twice. When the write request gets to the underlying socket implementation we would hit this CHECK: [1]. This was happening because SendFrontWriteRequest can get called again while write request is still pending (a call is always queued after write completion regardless of the queue state) and it grabs the front of the queue. The queue item for a write request does not get popped off until the transfer is complete which allows the same request to get processed twice (depending on timing). The solution here is to remove the pending request from the queue right away and store while it is in progress. In SendFrontWriteRequest we check if there is already a pending request and exit early. SendFrontWriteRequest always gets re-queued when the pending write request completes so we always keep processing. Tested on device with transfers between Android and ChromeOS. [1] https://source.chromium.org/chromium/chromium/src/+/master:net/socket/socket_posix.cc;l=331 Fixed: 1121747 Change-Id: I67b69f735798f832aecdd62b6697ecef8d99cfaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429863Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d0ddf023e1c8..ea1181f182dc 2020-09-25 yichengli@chromium.org Add api/controllers endpoint for BundleFpmcuUnittests 2020-09-25 saklein@chromium.org Test/BuildTargetUnitTest: Begin blocklist language transition. 2020-09-25 mmortensen@google.com Refactor portage_util to isolate portage system calls. 2020-09-25 yichengli@chromium.org Generate python bindings for new BuilderConfig artifact type 2020-09-24 chrome-bot@chromium.org Update config settings by config-updater. 2020-09-24 moragues@google.com strongbad: enable builder 2020-09-24 chrome-bot@chromium.org Update config settings by config-updater. 2020-09-24 gbiv@google.com lddtree: add LD_ARGV0_REL 2020-09-24 chrome-bot@chromium.org Update config settings by config-updater. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I497dc99d761de51247711b075f5dcdf5a5acaa77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431829 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Becca Hughes authored
Change-Id: Ic47ee8e027e8e545e51d2b791f5ceb6c19660c28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432106 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Auto-Submit: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
-
Nnamdi Theodore Johnson-Kanu authored
- Romoved duplicated string - Updated base page UI Screenshots: - https://imgur.com/OZPqyfj - https://imgur.com/OGFU3fI - https://imgur.com/jDLcIQu - https://imgur.com/Lndkx7C - https://screenshot.googleplex.com/ckyhXWunKco7LHP.png Bug: 1093185 Change-Id: Ied55dbf424f0715ea9a728c6266336e957a29469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417312 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#810746}
-
