GitLab

Bug: 803822
Change-Id: I65b3eea6ebd61fff719650d8af5364d429b73103
Reviewed-on: https://chromium-review.googlesource.com/888701
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Siddhartha S <ssid@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532615}

https://skia.googlesource.com/skia.git/+log/58acd74f55f2..caaf211e8dd0

$ git log 58acd74f5..caaf211e8 --date=short --no-merges --format='%ad %ae %s'
2018-01-29 reed handle conics in text warper
2018-01-29 bsalomon Remove some unused sample count caps
2018-01-29 reed compare textonpath techniques

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=bungeman@chromium.org

Change-Id: Iab0a54275c1d271ffbb896d36dd148844061a1c9
Reviewed-on: https://chromium-review.googlesource.com/891804Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#532614}

Begin implementation for downloads by creating entries in ukm.xml and
a DownloadUkmHelper following go/downloads-ukm for:
- Download.Started: file_type, download_source
- Download.Interrupted: change_in_file_size, reason,
resulting_file_size, time_since_start
- Download.Resumed: mode, time_since_start
- Download.Completed: resulting_file_size, time_since_start

The implementation strategy is to have a ukm_download_id persisted
that will uniquely identify each download. The ukm_source_id will be
reported only at the start of the download.

Bug: 785557
Change-Id: I94b46bc3287fcde949e58424dc929e71cec7df16
Reviewed-on: https://chromium-review.googlesource.com/742357
Commit-Queue: Joy Ming <jming@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532613}

Looks like the bug was fixed, so we don't need this.

Bug: 445616
Change-Id: Id33ecc6249b1e68337650c733d0877e3326732bf
Reviewed-on: https://chromium-review.googlesource.com/885021
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Jungshik Shin <jshin@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532612}

This patch refactors the function so that it no longer requires a
RenderedPosition instance, by making it call LocalCaretRectOfPosition()
instead of calling LayoutObject::LocalCaretRect() directly.

This also helps converting RenderedPosition::AbsoluteRect to the NG
code path.

Bug: 771398
Change-Id: I9eb61a68cad265769e35e206fd5d230414f83680
Reviewed-on: https://chromium-review.googlesource.com/889643
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532611}

This CL was uploaded by git cl split.

R=estark@chromium.org

Bug: 177475
Change-Id: Ie191053771d653739fa5bfb5a2a8f143306d2c47
Reviewed-on: https://chromium-review.googlesource.com/891743Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532610}

This CL was uploaded by git cl split.

R=reillyg@chromium.org

Bug: 177475
Change-Id: I0fb502eb7e5d4c25f6facaadb66d971d981087ee
Reviewed-on: https://chromium-review.googlesource.com/891519Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532609}

This CL was uploaded by git cl split.

R=agl@chromium.org

Bug: 177475
Change-Id: I222339d1ce16c92c54e3ad7ddbdd8b4e9cc92b5e
Reviewed-on: https://chromium-review.googlesource.com/891920Reviewed-by: Adam Langley <agl@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532608}

This patch fixes a bug that prevented more than one sensor data
to be available at once when using the device motion/orientation
API.

The issue was introduced by this other patch [1] which fixed
some security-related issues in the way shared memory region
handles are managed throughout Chromium (more details at
https://crbug.com/789959).

The device service´s sensor implementation doesn´t work
correctly because it assumes it is possible to create a
writable mapping of a given shared memory region at any
time. This assumption is not correct on Android, once an
Ashmem region has been turned read-only, such mappings
are no longer possible.

To fix the implementation, this CL changes the following:

- PlatformSensor used to require moving a
  mojo::ScopedSharedBufferMapping into the newly-created
  instance. Said mapping being owned by and destroyed
  with the PlatformSensor instance.

  With this patch, the constructor instead takes a single
  pointer to the corresponding SensorReadingSharedBuffer,
  i.e. the area in memory where the sensor-specific
  reading data is located, and can be either updated
  or read-from.

  Note that the PlatformSensor does not own the mapping
  anymore.

- PlatformSensorProviderBase holds the *single* writable
  mapping that is used to store all SensorReadingSharedBuffer
  buffers. It is created just after the region itself,
  and thus can be used even after the region's access
  mode has been changed to read-only.

  Addresses within the mapping will be passed to
  PlatformSensor constructors, computed from the
  mapping's base address plus a sensor-specific
  offset.

  The mapping is now owned by the
  PlatformSensorProviderBase instance.

Note that, security-wise, nothing changes, because all
mojo::ScopedSharedBufferMapping before the patch actually
pointed to the same writable-page in memory anyway.

Since unit or integration tests didn't catch the regression
when [1] was submitted, this patch was tested manually by
running a newly-built Chrome apk in the Android emulator
and on a real device running Android O.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/805238

BUG=805146
R=mattcary@chromium.org,alexilin@chromium.org,juncai@chromium.org,reillyg@chromium.org

Change-Id: I7d60a1cad278f48c361d2ece5a90de10eb082b44
Reviewed-on: https://chromium-review.googlesource.com/891180
Commit-Queue: David Turner <digit@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Matthew Cary <mattcary@chromium.org>
Reviewed-by: Alexandr Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532607}

This CL was uploaded by git cl split.

R=dewittj@chromium.org

Bug: 177475
Change-Id: I5d91769ce49fd202108315e884630dde60379130
Reviewed-on: https://chromium-review.googlesource.com/891481
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532606}

TBR: falken@chromium.org
No-Try: true
Bug: 807014
Change-Id: Iac0c9a8e7b4959c0848cc3722f96d15f306877dc
Reviewed-on: https://chromium-review.googlesource.com/891484
Commit-Queue: Samuel Huang <huangs@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532605}

1. Fix layering of surfaces vs frame_sinks, so that surfaces can't
   depend on frame_sinks.
2. Remove some uneeded rules.
3. Ban features.h from client, host and service subdirs.
4. Add comment in all DEPS files pointing to README.md.

Bug: none
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I180d2e200c6c297725aa33b0da096d67fa910c56
Reviewed-on: https://chromium-review.googlesource.com/891548
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532604}

https://chromium.googlesource.com/catapult.git/+log/831d51715a13..69f2184e9c43

$ git log 831d51715..69f2184e9 --date=short --no-merges --format='%ad %ae %s'
2018-01-29 simonhatch Pinpoint - Skip reading statistic if no sample values.

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I249c5733041f42cb6aa4247df3d263280294b76a
Reviewed-on: https://chromium-review.googlesource.com/891542
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532603}

1. |CollectionInfoFetcher| is responsible to download and
   deserialize the proto related to the collection info from
   Backdrop wallpaper service. |ImageInfoFetcher| is responsible
   to fetch the image specific information belonging to each particular
   collection.

2. wallpaper_manager.js fetches the list of the collection info via
   extension API and displays them in the category column. After that
   point, it uses lazy loading for each collection: it fetches the
   image info for each collection only after the user clicks on it.

Bug: 800945
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I520660ceb821b1f57fd349d0cdb87e12c1ec0ca5
Reviewed-on: https://chromium-review.googlesource.com/877580
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532602}

This CL was uploaded by git cl split.

R=thomasanderson@chromium.org

Bug: 177475
Change-Id: I2ee2c7f385ae71ecee28e312bfc39ab3c547cd47
Reviewed-on: https://chromium-review.googlesource.com/891745Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532601}

The test is failing due to excessive output.

TBR=ssid@chromium.org

Bug: 806988
Change-Id: Iaf311c39049405bdad1e461391b86055f5baf80d
Reviewed-on: https://chromium-review.googlesource.com/891699Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532600}

This is a reland of 69f0b0d2.
(Relanding to pick up resource file change.)

Original change's description:
> Chrome OS: Use Chrome logo on the OOBE Sync Sessings screen.
>
>
> This CL limits Sync settings screen to Google Chrome build and adds Chrome logo
> to it.
>
> BUG=805507
>
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: I5d17c32a7b9339af93394b366976d8ae43e13f03
> Reviewed-on: https://chromium-review.googlesource.com/889916
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Commit-Queue: Alexander Alekseev <alemate@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#532221}

TBR=oshima@chromium.org

Bug: 805507
Change-Id: I153d86a34bf73a7b02f9a844fbc137d658897944
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/891562Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532599}

This reverts commit 13c588bc, to re-land
the original patch (https://chromium-review.googlesource.com/884996)
again. This patch contains fixes needed to restore tab capture
functionality and clear up failing perf waterfall bots.

This time, I'm landing with the "sensitive to random bots not in the CQ"
content_browsertests disabled. I will re-enable them in a separate
change so that people stop reverting this very important fix, the act of
which keeps making things worse elsewhere.

TBR=xjz@chromium.org,kylechar@chromium.org

Bug: 806635, 785072, 754872
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I15ac4faaa168eb57f1775b70148382c3933de82f
Reviewed-on: https://chromium-review.googlesource.com/891541
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532598}

In later CLs this will be used to implement renderer initiated blob URL
loading.

Bug: 800901
Change-Id: I7e6afde55e132f4d6ae35bfb2beccad60ff82a36
Reviewed-on: https://chromium-review.googlesource.com/890021Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532597}

The experiment ended in 2015 but the client code was never removed.

Bug: 473483
Change-Id: I4cb79fa62ff9c2bc63525a2e5b747d4c2ef52bcb
Reviewed-on: https://chromium-review.googlesource.com/887602
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532596}

page_load_metrics::IsGoogleSearchResultUrl() can, if given a URL where
the query identifier is after the fragment identifier (e.g.,
https://www.google.com/webmasters/#?modal_active=none), cause a DCHECK
to fail in QueryContainsComponentHelper.

This adds a unit test which triggers the DCHECK failure. It also removes
the DCHECK in favor of trimming initial [?#] characters.

Change-Id: Ibdc5d6d0aee2089deea2c777d94c0dd70ef1ffd0
Bug: 805155
Reviewed-on: https://chromium-review.googlesource.com/882211Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532595}

Also adds comments explaining the implementation of them in
OneCopyRasterBufferProvider.

R=piman@chromium.org, sunnyps@chromium.org

Bug: 730660
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I02a762a4208fcd8d317c35c49f40d36425f27126
Reviewed-on: https://chromium-review.googlesource.com/891442Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532594}

AV_INPUT_BUFFER_PADDING_SIZE has been increased to 64 in FFmpeg:
https://github.com/FFmpeg/FFmpeg/commit/6e80079a2840ee407c5d126030eb1066bcbfdfc5

BUG=777484

Change-Id: I1bd68d1c1b0c3131f28d6e07e1444b89800c09db
Reviewed-on: https://chromium-review.googlesource.com/889686Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532593}

Bug: 793025

Change-Id: I9707ded8397c178ab3cdd65c2c71851c64b00c00
Reviewed-on: https://chromium-review.googlesource.com/889791
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532592}

Bug: 678689
Change-Id: I9f47f8f59f86621327d5ace0b2431b1fc48ff900
Reviewed-on: https://chromium-review.googlesource.com/889823Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532591}

The idl file should be removed, and a couple of comments got missed.

TBR=dcheng@chromium.org

Bug: 650275
Change-Id: Ic36c71da5234bd9f0808f005c967147a11e45e27
Reviewed-on: https://chromium-review.googlesource.com/889043Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532590}

According to the spec, https://www.w3.org/TR/css-scroll-snap-1/,
:target/scrollIntoView()/etc should take scroll-margin, into account.

Currently in ContainerNode, BoundingBox() is calculated from its
UpperLeftCorner and LowerRightCorner. This patch move the logic to
LayoutObject and keeps the wrapper in ContainerNode.

When the rect is needed for ScrollIntoView, these two points might be
generated from different LayoutBoxes, and we should apply the
scroll-margin accordingly. We put these together into a new method -
LayoutObject::AbsoluteBoundingBoxRectForScrollIntoView() and wrap it as
Node::BoundingBoxForScrollIntoView().

Bug: 803606
Change-Id: I9002d6148fe8ed8f0851fa213431bd6260b993bb
Reviewed-on: https://chromium-review.googlesource.com/877444
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532589}

The underlying accessibility code has been refactored recently and I
cannot reproduce flake locally. Also, the flakiness dashboard shows
that the other tests in the suite are not flaky anymore. I suspect
the issue is fixed.

Also add a RunLoop spin in one place that changes a pref that ash
may need to observe. I don't think that affects this test, but I
noticed it while investigating.

Bug: 787024
Test: browser_tests
Change-Id: I65175c4e87c09c2cc172174c9b0595e4372ad652
Reviewed-on: https://chromium-review.googlesource.com/889645Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532588}

Free the jobjects inside the loop. Previously selecting >= 512 files at
same time will cause a crash because the jobjects are not freed.

Bug: 726426
Change-Id: Ie71af5965b76653fa52b8745268aab66db5eff48
Reviewed-on: https://chromium-review.googlesource.com/889498Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Ran Ji <ranj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532587}

There are two versions of this method available, one inherited from
mojom::CompositorFrameSink interface and one that actually implements
the functionality. Both are public and a bit confusing as to which
should be used. After this change, callers should prefer to use the one
that is inherited from mojom::CompositorFrameSink and call the other one
only when they want to see if the call was successful or not. The first
version DCHECK's on the success of the call.

BUG=776154
TEST=none

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I26a0a23f8e2ee807c3a2ea8a5ce7004ac2801c85
Reviewed-on: https://chromium-review.googlesource.com/865475Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532586}

Change-Id: I7feb448f100fdd0f3cab0ade9f2f6b804dc3caeb
Reviewed-on: https://chromium-review.googlesource.com/881558Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Menglu Huang <huangml@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532585}

This patch adds WPT tests for testing whether transformed table parts contain
fixed position elements as specced in:

https://www.w3.org/TR/css-transforms-1/#transformable-element
https://www.w3.org/TR/css-transforms-1/#transform-rendering

R=chrishtr@chromium.org

Bug: 804952, 805996
Change-Id: I2701e7abffddc67ad4ee206948361acfb28cecd1
Reviewed-on: https://chromium-review.googlesource.com/887364Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532584}

The Standard Gamepad spec lays out a standard configuration for gamepad
buttons and axes. The browser attempts to remap the buttons and axes
reported by connected devices to more closely match the standard. In
most cases, a suitable mapping function can be chosen from the vendor
and product IDs reported by the device.

In some cases this is not sufficient; for instance, some devices are
supported over both USB and Bluetooth and require different mapping
functions in either case. To help select a mapping function in these
cases, a |bus_type| parameter is added to
GetGamepadStandardMappingFunction to specify whether the device is
connected over USB or Bluetooth.

BUG=749295

Change-Id: I566e06f5d34eeac269a0a70e912f74a64ccd19f5
Reviewed-on: https://chromium-review.googlesource.com/887231Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Matt Reynolds <mattreynolds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532583}

e.g. navigation_and_load_inttest.mm

Change-Id: I70fd08b18e49afbbcd060957bf76ef1e5db1bc20
Reviewed-on: https://chromium-review.googlesource.com/891675Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532582}

This CL was uploaded by git cl split.

R=rockot@chromium.org

Bug: 177475
Change-Id: I805b6d3c2e4c97d65839bf7f1edaf30ac9804946
Reviewed-on: https://chromium-review.googlesource.com/889943Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532581}

Merge TestCommon into TestRule since there is no long need for sharing
the implementation with other classes

Bug: 711517
Change-Id: I40f53f07d734112fb85fb2bf8d1efe1ad4752097
Reviewed-on: https://chromium-review.googlesource.com/887747Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Yoland Yan <yolandyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532580}

In preparation for the frame retransmission fix we need to bring out
the BattOr connection's Flush() out into it's own function so it can
be called directly by the BattOr agent.

In order to achieve this we had to rework many BattOr agent test
cases which did not pass after this change. It turns out they
never should have passed because they did not advance the clock to
complete the command retry timeout after a command failed.

Bug: 735434
Change-Id: Ie376c91ba47c6e466f57c6acde8a377bd96c209e
Reviewed-on: https://chromium-review.googlesource.com/836850
Commit-Queue: Aaron Schulman <aschulman@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532579}

There might be cases where unregistering broadcast receiver can throw
IllegalArgumentException if the context is not handled in an appropriate
manner. This CL avoids the crash.

Change-Id: I9d7888dcbde518caa6e7e426a215953e9c3ba672
Bug: 780261
Reviewed-on: https://chromium-review.googlesource.com/891458Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Isha Bobra <ibobra@google.com>
Cr-Commit-Position: refs/heads/master@{#532578}

R=martis@chromium.org

Change-Id: I70d2846efc7bc0b9511b4429d59c7ae7e492aac9
Reviewed-on: https://chromium-review.googlesource.com/889858Reviewed-by: Michael Martis <martis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532577}

When converting from the mDNS service information to a DetectedPrinter
struct, we fail with an IPP-E service name because we forgot to check
for them.  This fixes that.

Bug: 806390
Change-Id: Iad2853f458ac3880f9d62f45e135ecb16ee942b8
Reviewed-on: https://chromium-review.googlesource.com/890046Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Justin Carlson <justincarlson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532576}