- 19 Jan, 2021 40 commits
-
-
Victor Costan authored
The majority of the storage code uses incognito instead of off_the_record. This CL gets WebSQL in line, to reduce cognitive overhead for readers. Change-Id: I8fcce58f82da24e22aa7b14b201dc7ed935b1114 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634551 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#844845}
-
Chris Mumford authored
Switch the exception message from "GATT Error: Not supported." to "GATT operation not permitted." when attempting to read a non-readable characteristic on macOS. The former is more descriptive, as Web Bluetooth does support reading characteristics, and also aligns with other platform behaviors, e.g. Windows and Linux, which currently set the "... not permitted." message. Bug: none Change-Id: I0023a5ddd35d5783cec253e3a935c295804f731b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633646 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#844844}
-
Sahel Sharify authored
Similar to crbug.com/993223 PaymentRequestSheetController::UpdateHeaderView gets called after the payment request(PR) has been aborted. The fix for crbug.com/993223 early returns in DidFinishNavigation which is the caller of UpdateHeaderView. That's why calling UpdateHeaderView from a different function (e.g. DidChangeVisibleSecurityState in the case of crbug.com/1165624) still reproduces the issue. This CL early returns in all PaymentRequestSheetController's Update...View functions when the PR is being aborted. Bug: 1165624 Change-Id: Ie6f8f8ff6e72ef16878aa8dc3f15e19dea1587e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635074Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#844843}
-
Scott Violet authored
This test shuts down the session service part way through, and then recreates it. The second service ends up with a different task runner (because each session service has its own). This means it's possible for the second one to try reading files that haven't been finished writing. At least that's my theory as to why this test is flaky. I couldn't repro this locally, so this is a best guess. BUG=1154345, 1158715, 1166756 TEST=test only change, SessionRestoreTest.NormalAndPopup Change-Id: I7bf5ea96134179f607ffcf9d882b6bc7b2277da2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634013Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#844842}
-
Ben Mason authored
This reverts commit 70b75301. Reason for revert: Incorrect multiple uses of PRODUCT_NAME (crbug.com/1168172) Original change's description: > Update BrowsingDataLifetime policy description > > Update policy description of BrowsingDataLifetime policy to make it more > informative while cutting down on the technical details and complexity. > > Bug: 1163584 > Change-Id: I2764fbf7651625667b9199136f17ea6dc709ae41 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630865 > Commit-Queue: Igor Ruvinov <igorruvinov@chromium.org> > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844217} TBR=pastarmovj@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,igorruvinov@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1163584 Change-Id: I80834322e3715c917da54015b70b211d3d70feb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637582Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#844841}
-
Sorin Jianu authored
It would be nice to have a group target that builds all the targets in the chrome/updater so it is easier to build everything locally, when needed. Bug: 1167572 Change-Id: I4ee56b21cd4d461bf7bded3b8dcb5ffc2dce3c89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635110Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#844840}
-
Jeroen Dhollander authored
This allows us to use prerecorded audio files as Assistant input. Note that the |fake_input_device.cc/h| files are currently copied from the chromeos/services/assistant/platform directory, but they will be removed from there in a follow-up CL (when they are no longer used). Bug: b/171748795 Test: Compiled Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: I3f7fa20798885df599db51310a5d6e87e36e6fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605243 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#844839}
-
Jérôme Lebel authored
Making sure there is no unexpected calls to ObserverBridgeDelegate. Bug: 903396 Change-Id: I24861862d71cb361081a1c1dd4f36972448bf98c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632676 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#844838}
-
Stephen McGruer authored
Based on my testing[0], this is a reasonable sweet spot before performance gains diminish substantially (and then actually start to regress near 40 processes). Long term, we should consider the user/bot's cpu_count and calculate something like that, but for now this brings our shard time down from nearly 300m to ~130m. [0]: https://docs.google.com/spreadsheets/d/1hMIoOB1oaC9iyWK5GEy5xIwUJLoDRaI77ReJ1lKjpZk/edit#gid=0 Bug: 1023835 Change-Id: Ifccb39af65f8ac9e785818b3e4cf27138dc61d26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633371Reviewed-by:
Luke Z <lpz@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#844837}
-
Toby Huang authored
Legacy supervised users are now deprecated. This CL removes some dead UI code and strings. Bug: 1164090 Change-Id: I895ad42c4c336889aebb57112ca80ef622594e4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625803 Auto-Submit: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#844836}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 193 histograms that show frequent access in the past 90 days. These are the 95% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2021-04-19. TBR=chromium-metrics-reviews@google.com Change-Id: Idf34b3691926880bad0be2a5f1c23486d47f297d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638093Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#844835}
-
Wez authored
Include "fallback" languages in the "sec-ch-lang" and "accept-language" headers rather than relying on generic language fallbacks. This allows language/locale combinations that are less commonly supported by sites to be substituted with more appropriate commonly-supported combinations than would otherwise be possible. Bug: 1092804, 1164990 Change-Id: I7827ecbc24c0d2745e53a7c50af01b2c0cda0773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632757 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#844834}
-
Moe Ahmadi authored
This code is under active development and these are useful metrics for monitoring regressions. Fixed: 1125723 Change-Id: I6667830a5bac7671624764d5b909c37f11070a52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631364Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#844833}
-
Marc Treib authored
Most of these were set to expire with M90. As the launch is still ongoing, we'll need these for a bit longer. By M95, we should be able to judge which of these we'll need long-term and which can go away. Bug: 1165277 Change-Id: I03b733fb7f3086af7bf1a356217f77e2af84a991 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635155Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Sinan Sahin authored
This is a reland of 6a340039 The SingleActionMessageTest was failing on an L bot because Mockito couldn't mock WindowAndroid because it has a Display.Mode member, which is only available on M+. This reland replaces the WindowAndroid with a Callback<Animator> since we only need one method from that class. Original change's description: > [Messages] Fix clipping of message banner because of SurfaceView hole > > This CL delegates the Animator#start calls in MessageBannerMediator to > WindowAndroid#startAnimationOverContent. > > Bug: 1159429 > Change-Id: I865e62718efa46eae8e1bf733271854475edaa00 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628497 > Commit-Queue: Sinan Sahin <sinansahin@google.com> > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Pavel Yatsuk <pavely@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843685} Bug: 1159429 Change-Id: I325340cb845809e963c9df50b217aa9d6f70849e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633526 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#844831}
-
Jeroen Dhollander authored
Bug: b/177328928 Test: compiled and deployed Change-Id: I56b03581f2299812e8114d09f76bd56c44fdcf51 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617516Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6cdb67fb33ed..5eb527cf7fb2 2021-01-19 glahiru@webrtc.org Replace sigslot usages with callback list library. 2021-01-19 tommi@webrtc.org Add DeliverPacketAsync method to PacketReceiver. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I7b23c1012e96a85d40e9aa648031da0cf299dd51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638003Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844829}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 15 histograms that have been used to generate alerts in the past 90 days and do not already have a date later than or within 60 days of 2021-04-19. TBR=chromium-metrics-reviews@google.com Change-Id: I89c74efd5548b911e399a790e7f774225372b8bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637258Reviewed-by:
-
Clark DuVall authored
This reduces the base dex size in trichrome by 0.5MB, which should help both memory usage and startup time in child processes with isolated splits enabled. Unfortunately we can't do the same for monochrome at the moment because WebView still needs the full content_java target. Bug: 11674041 Change-Id: I2aa3ba17ef97ab311e23f3ab8f0c0340cee9bfe7 Binary-Size: The method count is inflated because methods are moving Binary-Size: from the base module -> chrome module, and it doesn't look Binary-Size: like these are counted right. The increase in Binary-Size: Combined_unique methods is only +13. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634009 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#844827}
-
Dominic Battre authored
Some credit card tests may start executing before the PersonalDataManager they depend on is fully loaded. This CL introduces waiting for that to be completed. Bug: 1163102,1162474 Change-Id: I394b690fe0e98925b0c6f1e8deb8be9b5388944a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628947 Commit-Queue: Evan Stade <estade@chromium.org> Auto-Submit: Dominic Battré <battre@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#844826}
-
Robert Ogden authored
Bug says this may fail on navigating to internal urls, but simply clearing the ongoing prefetches again is harmless. Bug: 1167997 Change-Id: I6ceb3525c61e9a593ecf8a298510df9c27d845ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636677 Commit-Queue: Robert Ogden <robertogden@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Auto-Submit: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#844825}
-
Andrey Zaytsev authored
Bug: 1165183 Change-Id: I6ccea4c08c70dbc77bed222a1a172c6a886f087e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636155 Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#844824}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9e417d1e36be..a8b2b4a5eb39 2021-01-19 janscheffler@chromium.org [JSDOC2TS]: Migrate screencast 2021-01-19 andoli@chromium.org [module.json extensions] js_profiler 2021-01-19 andoli@chromium.org [module.json extensions] layers 2021-01-19 tvanderlippe@chromium.org Migrate trimEndWithMaxLength to string-utilities 2021-01-19 andoli@chromium.org [module.json extensions] linear_memory_inspector If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1050549,chromium:1134103,chromium:1158760 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia641ac97565ec546c6829d4396b3e1d805d504b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637997Reviewed-by:
-
Sophey Dong authored
Bug: 1152761 Change-Id: I40ead415dcf134f2119bc63d27a82ce07c6dfb07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559154Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Sophey Dong <sophey@chromium.org> Cr-Commit-Position: refs/heads/master@{#844822}
-
Jesse Schettler authored
CSS mixins are no longer necessary and can be replaced with CSS vars. Bug: 1167325 Change-Id: I39b304e8644c4df511952166f7b30c82d92d359e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633399Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#844821}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/84e43fa2c447..2517afd133f3 2021-01-19 tandrii@google.com [git-cl] fix bug if user is not logged when fetching tryjob results. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ic8c8b407062e07048cb73c693a990d877c58b9c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637718Reviewed-by:
-
Jan Wilken Dörrie authored
This change extends several Password Manager histograms. R=chromium-metrics-reviews@google.com Fixed: 1165113 Change-Id: If442fb40bd477aa860a658441c7c433b6d156a6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636154 Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
-
Yuke Liao authored
This is a reland of e2f3b551 Original change's description: > Lacros: create lacros tast test targets > > This CL creates gn targets for lacros tast tests, and the main > motivation is to run lacros tast tests on Chromium CI. > > Bug: 1158590 > Change-Id: I783779c3386a39743b8227367189b0b87832b9dc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606188 > Commit-Queue: Yuke Liao <liaoyuke@chromium.org> > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@google.com> > Cr-Commit-Position: refs/heads/master@{#844127} Bug: 1158590 Change-Id: I4baefe78970cb928476166875b519738be0c9f79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633073 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#844818}
-
Egor Pasko authored
If pinpoint_traces.py is interrupted while html2trace is busy, the next extraction would take partial results. To make the process robust in presence of interruptions, create a temporary directory for html2trace, then atomically rename it to the directory that will be searched on extraction. The operation may seem not equivalent to creating a '.tmp.json' and renaming it, because this is indeed not equivalent. This change fixes the bug that I missed in previous testing when I forgot to delete the json_cache, hence this code was not executing. This time json_cache was deleted before testing. Bug: 1119406 Change-Id: I7cfb19572a9ffa26827dd113bb92b2253b0a2b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637838Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#844817}
-
Colin Blundell authored
This CL coalesces the implementation of ChromeSubresourceFilterClient::ShowNotification() to simplify a followup CL that will: - Move the bulk of this implementation into a new ProfileInteractionManager::MaybeShowNotification(client) method that the throttle manager will invoke directly, with that method calling client->ShowNotification() and the only remaining code in ChromeSubresourceFilterClient::ShowNotification() being the actual showing of the infobar With that followup CL, WebLayer will then share the core logic that will be moved into ProfileInteractionManager. In this CL, however, there is no behavioral change. Bug: 1116095 Change-Id: Ia9d61d6ebc8c323cfc9054a58a22acbe89e27d22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628992 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#844816}
-
Andy Perelson authored
R=ajgo Bug: 1167291 Change-Id: I252d2eef1967cb5a2510f4f9648bdc0d3bda58c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633973Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Andy Perelson <ajp@chromium.org> Cr-Commit-Position: refs/heads/master@{#844815}
-
Wez authored
The test suite was removing all services from the browser process' incoming service directory, causing the NetworkService to sometimes fail to be able to contact the platform network stack. Fix the test suite not to disable access to platform services. Bug: 1150754 Change-Id: Idd34735bcd494502af9391ab212313cea2b94c22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637517 Commit-Queue: Wez <wez@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#844814}
-
Wez authored
Bug: 1168167 Change-Id: I2972d60b27925816579629f164c26a18a9892886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637583 Commit-Queue: Wez <wez@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1611035655-73de094cb5ff55b60927a0f5adde75a5bce05096.profdata to chrome-win64-master-1611057528-899a688a15a64f3c7bd554cd5ab3f72fe33a7d09.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I116ff756cff1bba34f8e571becee00f0208b769b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637898Reviewed-by:
-
Tim van der Lippe authored
R=szuend@chromium.org Bug: 1050549 Change-Id: Id404e0427b150b6301c3b73bf3a5eecfe871781c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637501 Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#844811}
-
Xida Chen authored
TBR=eirage@chromium.org NOTRY=true Bug: 1168170 Change-Id: I675d070a129826054f285085ff1f6771caa3a1bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636839Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#844810}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. Bug: 1145565 Change-Id: I41c527483afce87b1b28c3345bd5d23f1d0140a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635071Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#844809}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1611024810-772a0a2d15ca5658988961a1c7ea3d1b91cdca35.profdata to chrome-win32-master-1611057528-c042fc837e99141efabc34633cbdaeed88679432.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I339d3cd859debf9ccd9852f2742216138fb55602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637894Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202101190600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/V5FYlmqYUEfkAqfSEHzekB27KIr2sLJjCa2Z4wp13lYC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/154430508,b/172415656,b/176852796,b/177381366,b/177381582,b/177382762,b/177604649,b/177774996,b/177784709,b/177856222 Tbr: media-app@grotations.appspotmail.com Change-Id: I462173835d168002c92edaf819f63716febfc959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637738Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844807}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cc7aa8e318bb..0bc32f23f69e 2021-01-19 reed@google.com Add query to test our cached convexity If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: Ice90967ddd3c0086a53ce5ec24c04d2a101b709d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637896Reviewed-by:
-
