- 10 Sep, 2019 40 commits
-
-
David Black authored
Previously the close button in the proactive suggestions view was 16dip as the view bounds matched the icon bounds. Now, the icon is still 16dip but the view bounds are increased to 32dip which is also the standard size across Assistant for buttons. Bug: b:140669269 Change-Id: I89e8fb9e2027553cec8fb6a8d605ce10ec4cdd67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792979Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#695249}
-
Chris Blume authored
The SkiaRenderer GL bot was accidentally added outside of alphabetical order. This CL rearranges the order to be alphabetical. Bug: 969855 Change-Id: I3e1183483ba7dcca1f4cccf084b062f41d3c6fe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795668Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#695248}
-
chrome-bot authored
Same change as https://crrev.com/c/1793050. This break affects all our UITests: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=celab_tests Validation: https://cr-buildbucket.appspot.com/build/8902773145814860448 Change-Id: I3dd0efbc1dc797cd51bf587e9fd217385beba06c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791795Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Auto-Submit: Mathieu Binette <mbinette@google.com> Cr-Commit-Position: refs/heads/master@{#695247}
-
John Rummell authored
Moving the code that handles the CDM manifest into a separate file in chrome/common to support manifest parsing outside of the component updater. Bug: 889561,971433 Test: new unit_tests pass Change-Id: I1d6591834f01f1fd01daf5450f5cad08f4af2e26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764249Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#695246}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c1ec0cbb921b..c9800e5adb7a Created with: gclient setdep -r src-internal@c9800e5adb7a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I11f333c4ae254ae9af70628c5e52127afcd699cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796109Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695245}
-
Alex Clarke authored
We want to prioritize loading and compositing tasks until first contentful paint. That wac casusing fast/replaced/replaced-breaking.html to flakily have image diffs because the test harness is taking screen shots before the plugins have finished loading. This patch makes the test wait until they have both loaded before finishing which fixes the flakes we'd have when turning on the new scheduler policy. Bug: 971191 Change-Id: I08f34cfefa5ffdec14741b7ab1cf8d83fc3e33b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795789Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#695244}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /services/device/public/cpp/power_monitor. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=bajones@chromium.org Bug: 891670 Change-Id: Ibb48e3b6a6c219f1c781e719f033d0ee88c33f1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787099 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#695243}
-
dpapad authored
The code was adding a trailing space when the URL ends with "\", to work around https://bugs.webkit.org/show_bug.cgi?id=28885 which no longer seems to be an issue. Bug: None Test: Run https://jsfiddle.net/m7brn0q4/, verify that a network request to "foo/bar/?\" is sent. Change-Id: I351d60350ab43b99270edaef063da76b35955a1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793789 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#695242}
-
rbpotter authored
- Autogenerate Polymer 3 cr-toolbar, cr-toolbar-search-field, and cr-toolbar-selection-overlay - Autogenerate Polymer 3 cr-toolbar-search-field test - Add a cr-toolbar to the demo page Bug: 965770 Change-Id: Id51ce14f0a8812be7a858d5362c42f212d199f41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790435 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#695241}
-
Christy Chen authored
Two strings for the checkboxes in Layers panel are not localized. This CL wrap them with ls, and include the strings in the GRDP. https://imgur.com/fbrbvKY Bug: 941561 Change-Id: Iab4e3bfaa791dbb9542133109367284465b59d98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779170Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Christy Chen <chrche@microsoft.com> Cr-Commit-Position: refs/heads/master@{#695240}
-
Adithya Srinivasan authored
Test flakily fails on TSAN, see bug for more details. Bug: 1002602 Change-Id: I0b68f636f601d2a138297ce0b2da49dc2883304a Tbr: peter@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796385Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#695239}
-
Jenny Zhang authored
Bug: 1001708 Change-Id: I036e5546d84a60fc9248f785c1801bc8d88eef57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793945 Commit-Queue: Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#695238}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e5641be5fe30..d9c1c856c64c git log e5641be5fe30..d9c1c856c64c --date=short --no-merges --format='%ad %ae %s' 2019-09-10 raul@tambre.ee fix_encoding: Decode bytestrings on Python 3 Created with: gclient setdep -r src/third_party/depot_tools@d9c1c856c64c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:984182 Change-Id: I7518842e1bdcf77ce98f9087790a06e121238964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796107Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695237}
-
Nico Weber authored
There are a few existing violations. Cleaning these up doesn't look super involved; that's tracked at crbug.com/1002509 Bug: 912946, 1002509 Change-Id: I58d3334040e90967c6614bf17f705cd43d5c5b0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780884 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#695236}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/507f43465b33..29ab487ea7c1 git log 507f43465b33..29ab487ea7c1 --date=short --no-merges --format='%ad %ae %s' 2019-09-10 philipel@webrtc.org Revert "Removes string support in field trial parser." Created with: gclient setdep -r src/third_party/webrtc@29ab487ea7c1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I804344bc4330d9a6226ec1b7c4fc01e7cd6d3f0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795565Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695235}
-
Himanshu Jaju authored
For users who have sync turned off on their current device, we show a button to direct them to the settings page to enable sync. Light mode - https://drive.google.com/open?id=1hYpPBCBQdAfxTsw0a13lS2aBSsvTrqk6 Dark mode - https://drive.google.com/open?id=1FYts7p-9W7duyv9Gqs5XEReJT8j3yYnd Bug: 1001102 Change-Id: I0ad3de82739b74541a06249447ad5c7c72b3ae23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795426 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#695234}
-
David Black authored
HTTP headers from proactive suggestion responses may be unescaped. These strings can be shown in both the proactive suggestions UI as well as in Assistant UI. We need to unescape these strings before displaying them to the user. Bug: b:140645078 Change-Id: I967c85a67e230bb86f029f517147b4b1b1fbd3ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790479Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#695233}
-
Brian Sheedy authored
Adds the option to run tests using Python3 instead of Python2 to allow for tests to be migrated over in preparation for the Python2 deprecation. This can be achieved by adding a "'use_python3': True" entry to the test's gn_isolate_map.pyl entry. Bug: 898348 Change-Id: I675ec068e18cec6bf59ea9d19802bd712f18e87e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769719Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#695232}
-
Erik Språng authored
Remove ios, add android webview. Bug: 1000023 Change-Id: Iace7f258104df5d46f51c20e3ceb19f43120e14f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795908 Commit-Queue: Erik Språng <sprang@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Erik Språng <sprang@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#695231}
-
Toni Barzic authored
Allow more aggressive apps container UI scaling down when dealing with extremely restricted vertical space (e.g. full zoom and docked magnifier): * reduce the minimum scale value when scaling the tile size * if minimum scale is not enough (or barely enough), remove item icon top padding. * scale down fade out area * if screen size is < 600, reduce the search box size, and the margin between the search box and suggestion chips container BUG=1001989 Change-Id: I887ba805c99e5882f3f9bbc5a6f48064bff53819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793926 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#695230}
-
Andrew Xu authored
ShelfViewTest::ShouldHideTooltipTest and ShelfViewTest:: ShouldHideTooltipWithAppListWindowTest assumes that home button is still the child view of shelf view. It is incorrect now. This CL fixes these two tests. Bug: 1002576 Change-Id: I8350fa9fab8c21497f3ac24f9bf0a32bde1aaf30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795759Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#695229}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b2d5d40a3393..2ab2ac03d8ee git log b2d5d40a3393..2ab2ac03d8ee --date=short --no-merges --format='%ad %ae %s' 2019-09-10 brianosman@google.com GL: Don't leak shader objects when program linking fails Created with: gclient setdep -r src/third_party/skia@2ab2ac03d8ee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: None Change-Id: Ie716422697a87d63b73393c9140214b076ae419b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796106Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695228}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 70 histograms that show frequent access in the past 90 days. These are the 80% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-03-08. Change-Id: I0e3f3d4df5a91effbd04caa8427f403d2820afe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795804 Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#695227}
-
Andrew Xu authored
Scrollable shelf should place shelf icons in the center of display when there is sufficient space. That is also the UI behavior of the current shelf view. This CL achieves the UI consistency for scrollable shelf. Bug: 973481 Change-Id: Ifc50e6d62f5508dc84578519c4f6c6522fb845e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789677 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#695226}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /chrome/browser/android/download. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=qinmin@chromium.org Bug: 891670 Change-Id: Ifeb9efb0ae6973e97ef9107881387ae2e20cd789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786684 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#695225}
-
Eugene But authored
This change is made because all subdirectories of ios/web/public represent features, while web_state subdirectory is class name. The move proposal was discussed here: https://docs.google.com/document/d/1C2YIU0rDbH5wz2VI6nk0COrktwY3DbF-e7QbMIAKEJc/edit TBR=blundel@chromium.org Bug: 942244 Change-Id: I5227e9a413401e5a599d0d5cbd4758d3eb00aa38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793356Reviewed-by:
Yi Su <mrsuyi@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#695224}
-
Nico Weber authored
The file list in a dSYM bundle never changes, so there isn't really an incremental build issue with dSYM bundles. On the other hand, the file list in a dSYM bundle never changes, so it's easy to just list the files in the dSYM instead of the directory -- it's behavior preserving and it allows removing a bunch of mac-specific (harmless) whitelist entries, so might as well do that. (Removing the whitelist entries for actual bundle contents is more important since that actually affects incremental builds, but it's also harder.) To make sure this does the right thing, I went to an arbitrary swarming shard or a recent run of browser_tests on a recent build on https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Tests%20%281%29 : $ tools/swarming_client/isolateserver.py download \ -I https://isolateserver.appspot.com --namespace default-gzip \ -s 0bec65143ae103f148e632bae84dcbc44e57caf7 --target foo That isolate happens to have at least one each of - mac_framework_bundle (Chromium Framework.dSYM): $ ls foo/out/Release/Chromium\ Framework.dSYM/Contents/ Info.plist Resources/ $ ls foo/out/Release/Chromium\ Framework.dSYM/Contents/Resources/DWARF/Chromium\ Framework foo/out/Release/Chromium Framework.dSYM/Contents/Resources/DWARF/Chromium Framework - mac_app_bundle (Chromium.dSYM): $ ls foo/out/Release/Chromium.dSYM/Contents/ Info.plist Resources/ $ ls foo/out/Release/Chromium.dSYM/Contents/Resources/DWARF/Chromium foo/out/Release/Chromium.dSYM/Contents/Resources/DWARF/Chromium - mac_plugin_bundle (ppapi_tests.so.dSYM): $ ls foo/out/Release/ppapi_tests.so.dSYM/Contents/ Info.plist Resources/ $ ls foo/out/Release/ppapi_tests.so.dSYM/Contents/Resources/DWARF/ppapi_tests.so foo/out/Release/ppapi_tests.so.dSYM/Contents/Resources/DWARF/ppapi_tests.so Bug: 1000667,1002291 Change-Id: I9433bb05824b4f4b002766c53eee141bd69b4697 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795802Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#695223}
-
Brandon Goddard authored
This change scopes down a keydown listener in Profiler panels (Memory and Javascript Profiler tools) so that it only applies to the sidebar tree element that the handler manipulates (selecting which profile to view). Previously, any up/down arrow press that was not handled in the entire panel could result in the change in view. For example, with focus on the toolbar dropdown, pressing the down arrow would change the perspective as desired, but pressing up would move back to the start screen by changing the element selected (shown in the before gif below). Now the arrows navigate to the different snapshots/etc only when the sidebar has focus. Before: https://imgur.com/cWO43Tp After: https://imgur.com/03gReuM Bug: 963183 Change-Id: Ie2337449c064b8e3d690dc2cb0ef07be296c798e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775055Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Brandon Goddard <brgoddar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#695222}
-
Peter Kasting authored
Bug: 1000055 Change-Id: I5da481b05ecf433f987d4f6db381fd20a7062d46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793351 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#695221}
-
Polina Bondarenko authored
Add ArcSmartCardManagerBridge that implements SmartCardManagerHost. ArcSmartCardManagerBridge starts the refresh operation to make smart card certificates available to ARC. Bug: b:119914122 Test: plugin smart card reader to the local device, make sure that the certificate is shown in a client certificate user dialog launched from the test Android app. Test: ./out/Default/unit_tests --gtest_filer=ArcSmartCardManagerBridgeTest.* Change-Id: I175b8863e5f590a2e3d85d9ea6917908b336349b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724072 Commit-Queue: Polina Bondarenko <pbond@chromium.org> Auto-Submit: Polina Bondarenko <pbond@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Edman Anjos <edman@chromium.org> Cr-Commit-Position: refs/heads/master@{#695220}
-
Marc Treib authored
Before this CL, UserEventEqualityChecker would modify its |expected_specifics_| in IsExitConditionSatisfied(), which usually gets called multiple times. In the specific situations where it did this, it was actually safe, but this was quite non-obvious. The new version just makes a copy and modifies that. It's slightly more verbose, but much less confusing. Bug: none Change-Id: I44b0220197625b168ff7394ec83ad7682e7b2d6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795824 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#695219}
-
Jit Yao Yap authored
Change-Id: Ib0710ad86a9266d5b60a4cceca6abff00b0c20d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795248Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Jit Yao Yap <jityao@google.com> Cr-Commit-Position: refs/heads/master@{#695218}
-
Sigurdur Asgeirsson authored
This allows users of the public performance manager API, outside the performance_manager directory to use the test fixtures and access the graph implementation for testing only. Bug: 910288 Change-Id: I529f3b54d190f2cae1e3a23bd5d5758f5e973b4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790402Reviewed-by:
Patrick Monette <pmonette@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#695217}
-
Peter Kasting authored
Bug: 23697 Change-Id: Id372671eda6800a995fb31ff30213a8276e7b4d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792006Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#695216}
-
Aaron Krajeski authored
For deferred offscreen canvases, it's possible that there are un-drawn, recorded commands at these points. Bug: 1002523 Change-Id: I0b47319ff38aaa4030e9b74f897abd54eeeb4bcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779107 Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#695215}
-
Corentin Wallez authored
Also implements GPUTextureViewDescriptor.aspect and GPUBindGroupLayoutBinding.textureDimension that were added to Dawn in this roll. https://dawn.googlesource.com/dawn.git/+log/a900ccebcf42..f60522f5a467 $ git log a900ccebc..f60522f5a --date=short --no-merges --format='%ad %ae %s' 2019-09-10 digit [fuchsia] Fix Chromium build. 2019-09-10 digit [fuchsia] Implement external semaphore and memory support. 2019-09-10 cwallez Implement BGLBinding::textureDimension 2019-09-10 cwallez Add TextureViewDescriptor.aspect. 2019-09-10 cwallez Implement debug markers and groups for CommandEncoder 2019-09-09 enga Metal: Support setting bind groups before pipeline to match WebGPU semantics 2019-09-09 enga D3D12: Add IndexBufferTracker 2019-09-09 enga D3D12: Factor SetVertexBuffer tracking to match other tracking classes 2019-09-09 digit [fuchsia] Add headers containing extra vulkan definitions. 2019-09-09 digit Enable Vulkan for Chromium Fuchsia build. 2019-09-09 enga dawn_wire: Fix leak in Server::DoDevicePopErrorScope 2019-09-07 hao.x.li Align the size of Uniform and Storage buffer to 16 bytes in Metal 2019-09-05 bryan.bernhart Resource Management 6: VK support for resource allocation. Created with: roll-dep src/third_party/dawn Change-Id: I631197c99bb2847175731627a1d808fa5b85a840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795762Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#695214}
-
Sam Maier authored
Bug: 992461 Change-Id: I89026c422872e499f8038814a2a98c68e9fa422d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796103 Commit-Queue: Sam Maier <smaier@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Sam Maier <smaier@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#695213}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c650bce8. With Chromium commits locally applied on WPT: d8d7248d "Move forced colors tests to wpt" 999a3129 "[LayoutNG] Fix line breaking behavior after out-of-flow objects" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools mcasas@chromium.org: external/wpt/geolocation-API mstensho@chromium.org: external/wpt/css/css-multicol timvolodine@chromium.org, reillyg@chromium.org: external/wpt/orientation-event NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Ic9dcdc7fe26ebe599ebe30ae1472d2377bb1c54c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795663Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695212}
-
Mandy Chen authored
As per the plan [1] to localize the Audits Panel, this CL adds locale files in the lighthouse repo [2] to audits_worker/lighthouse/locales/. The files are copied to the output folder that's uploaded to the remote server (out/Release/resources/inspector/audits_worker/lighthouse/locales) and they are not bundled into audits_worker_module.js. They are also not bundled with the default (non-remote) devtools (out/Release/gen/devtools). Screenshots: https://imgur.com/a/hZiufh4 [1]: https://docs.google.com/document/d/1jnt3BqKB-4q3AE94UWFA0Gqspx8Sd_jivlB7gQMlmfk/edit?pli=1 [2]: https://github.com/GoogleChrome/lighthouse/tree/master/lighthouse-core/lib/i18n/locales Bug: 941561 Change-Id: I6c6572ceef6f94ebd5ff46cc17a83c21f8708221 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784959Reviewed-by:
Erik Luo <luoe@chromium.org> Reviewed-by:
Paul Irish <paulirish@chromium.org> Commit-Queue: Mandy Chen <mandy.chen@microsoft.com> Cr-Commit-Position: refs/heads/master@{#695211}
-
Tatiana Buldina authored
Bug: chromedriver:2198 Change-Id: I8e13ec3b88dd7018cb4650fc0ce52d4feb4aed07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793944Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#695210}
-