GitLab

Adds test utility code that allows Chrome to think it's received an intent
from a trusted app. This allows us to test Chrome's ability to auto present
WebVR content when given a link from a trusted app (or test its rejection
if the app is not trusted). Also adds one test using the new code.

Also contains a drive-by fix for flakiness in
WebVrTransitionTest#testNfcFiresVrdisplayactivate caused by a race
condition when adding the vrdisplayactivate listener.

Bug: 746086
Change-Id: Ic6b55df18d915a4e36b36ca43bd11f4c773f6d33
Reviewed-on: https://chromium-review.googlesource.com/578527
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488408}

All image decoder test have a helper function "CreateDecoder" which
conflicts in jumbo builds where the tests are merged. This patch renames
them "CreateBMPDecoder", "CreateJPEGDecoder" and so on.

Bug: 745732
Change-Id: I2cfd108c39ade76a09059d77778557ab44b82752
Reviewed-on: https://chromium-review.googlesource.com/576098Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#488407}

Previously the |timeout| duration was being passed as the deadline,
leading to the wait operation timing out as soon as Fuchsia's total
up-time exceeded it. Any subsequent waits on process termination would
then timeout instantly.

This had the effect that any unit-test fixture that took longer than
the per-batch timeout (less the Fuchsia boot timer under the test-
runner) to complete would always fail, with UNKNOWN RESULT for tests
from all later batches.

Bug: 746775, 738275
Change-Id: I89b6d03f58caffe602bbf37a921b3bd20c09cee2
Reviewed-on: https://chromium-review.googlesource.com/578699Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488406}

I'm working on a feature in content/public where I would like to use this style,
but I am currently unable to since it's in chrome/android. We can fix this by
moving it to ui/android.

Bug: 
Change-Id: Iced9ecf8f03949291a5f80b9293ac16d9cbc6925
Reviewed-on: https://chromium-review.googlesource.com/578477
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488405}

Bug: 699244
Change-Id: I3ee97e123c4a94424f87ac45d77d39450e6fbfe8
Reviewed-on: https://chromium-review.googlesource.com/559512Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488404}

In preparation for launching the experiment to collect ad identifiers
in existing SafeBrowsing reports.

Hoping to also sanity check the plan for reusing this feature in the
future if we want to change this param:
When the trial launches, the finch config will go away and the feature
will remain "disabled", so the code will revert to the Default value
from this CL. If we later want to change the param, we create a new
trial with a new param value, which will set the feature to "enabled"
and the new value from the trial will be used instead.

Bug: 674618
Change-Id: Ibb5cd5f2b4c95ecda592701084631027582a010a
Reviewed-on: https://chromium-review.googlesource.com/578388
Commit-Queue: Luke Z <lpz@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Nathan Parker <nparker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488403}

Bug: 737118
Change-Id: Ib14dfb4207a5cf37b173852a6a4fc13c9d13019f
Reviewed-on: https://chromium-review.googlesource.com/575074Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488402}

This is only populated with dummy data for now, but provides a place
to hook up the process list and dumping function in the future.

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I24934d3052dd8e36ad4a7b1372a5ef557ce716d4
Reviewed-on: https://chromium-review.googlesource.com/578559
Commit-Queue: Brett Wilson <brettw@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488401}

net_unittests always fail because they run slowly under qemu

Change-Id: Ief04c1ba39b5a507f0583fd7e31f4ff09492404c
Bug: 745094, 738275
Reviewed-on: https://chromium-review.googlesource.com/580048Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488400}

Before this patch, if a single web app manifest specified multiple
sections of "related_applications" with different "id" (package name)
fields and the user had several of these payment apps installed, then
Chrome would display only one of these payment apps.

The problem arose from an erroneous assumption of 1:1 relationship
between web app manifests and payment apps. In fact, a single web app
manifest can correspond to multiple payment apps, e.g., a dev and a prod
version of the same app.

The fix is to loop through the full web app manifest when looking for
matching payment apps, instead of early-exiting when the first matching
payment app is found.

After this patch, if a single web app manifest specified multiple
sections of "related_applications" with different "id" fields and the
user had several of these payment apps installed, then Chrome displays
all of the matching payment apps.

Bug: 745765
Change-Id: I70f287cb792ac8b0b073c22e9c08eebec6ffae3e
Reviewed-on: https://chromium-review.googlesource.com/579964Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488399}

This reverts commit 94fc8d93.

Reason for revert: Cronet builders are breaking again, debug builders only this time: https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20x86%20Builder%20%28dbg%29/builds/61964

We have an android_cronet_tester trybot but I don't remember if it does debug builds or not.

Original change's description:
> Reland "Android: Turn on UnusedResources lint check"
> 
> Original CL: http://crrev.com/c/578488
> 
> Fixes: Cronet builders
> 
> TBR=hanxi@chromium.org,agrieve@chromium.org,yuweih@chromium.org
> 
> Bug: 731159
> Change-Id: I6a54dfbae76c1d55166dbcaaea7bbbc93e60bf34
> Reviewed-on: https://chromium-review.googlesource.com/580267
> Commit-Queue: Peter Wen <wnwen@chromium.org>
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Reviewed-by: Peter Wen <wnwen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#488380}

TBR=wnwen@chromium.org,hanxi@chromium.org,agrieve@chromium.org,yuweih@chromium.org

Change-Id: I3360f01c815fe0674a05ae38622778bd5ed55305
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 731159
Reviewed-on: https://chromium-review.googlesource.com/580134Reviewed-by: Miriam Gershenson <mgersh@chromium.org>
Commit-Queue: Miriam Gershenson <mgersh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488398}

TBR=zmo@chromium.org
NOTRY=true

BUG=602688

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I2490f77aadb5866a8af0d34ce16673e7be06d2b9
Reviewed-on: https://chromium-review.googlesource.com/580489
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488397}

This reverts commit 14020f57.

Reason for revert: Hold off on API breaking change till M62, so we can have several that go out at the same time and we'll have a new origin trial.

Original change's description:
> WebVR: Update VRDisplay.GetFrameData to follow the current spec.
> 
> The WebVR 1.1 spec was updated to clarify the behavior of getFrameData.
> Now, GetFrameData should return false unless called within a
> VRDisplay.requestAnimationFrame callback.
> 
> BUG=736023
> 
> Change-Id: I14d9442a016817a78232ed7b1e71956c8dac614a
> Reviewed-on: https://chromium-review.googlesource.com/578188
> Reviewed-by: Brandon Jones <bajones@chromium.org>
> Commit-Queue: Bill Orr <billorr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#487970}

TBR=bajones@chromium.org,bsheedy@chromium.org,billorr@chromium.org

Change-Id: Ia0491a7af887c6149b69178747f6a0e6a9b5f3d2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 736023
Reviewed-on: https://chromium-review.googlesource.com/580167Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488396}

BUG=590878

Change-Id: Idcebf0336623322813b4cdfac66183d37c28f2bd
Reviewed-on: https://chromium-review.googlesource.com/573411
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488395}

GrGLFunction is a std::function today, but we'd like to slim that down.
This will let us change its underlying type seamlessly.

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I9f9c3d4b56e6d6fb6db82c8f47ddf74fdca6476d
Reviewed-on: https://chromium-review.googlesource.com/580129Reviewed-by: Brian Salomon <bsalomon@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488394}

BUG=746146

Change-Id: Ib18b966545eb9034736698206174b9e3b73a88d7
Reviewed-on: https://chromium-review.googlesource.com/578573Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488393}

Widgets in ViewHolderItem of context menu sometimes cannot be retrieved
after inflation, this will causes NullPointerException when setting their
fields. Add null check for this case.

BUG=746482

Change-Id: If4ec3ee4e71a745a5dafcb651a027e1acd0f3849
Reviewed-on: https://chromium-review.googlesource.com/578745Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Lei Tian <ltian@google.com>
Cr-Commit-Position: refs/heads/master@{#488392}

This CL does not change the SQLite version used by Chromium. It just
adds the code downloaded from
http://www.sqlite.org/cgi/src/info/0a5e1c04d9d07bb7 into the repository.

Bug: 746653
Change-Id: I9c96577a354a5dde8dd37b0031eff71d3ec63406
Reviewed-on: https://chromium-review.googlesource.com/578928Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488391}

Revert of Handle Java assert using a customized function in base (patchset #11 id:470001 of https://codereview.chromium.org/2971063003/ )

Reason for revert:
Reland changes weren't reviewed

Original issue's description:
> Create java_assertion_handler, a Java binary that takes in a JAR file
> and modifies the bytecode of classes.
>
> Replace the Java ASSERT with JavaExceptionReporter.assertFailureHandler
> that throws Exception.
>
> Output is written to a new JAR file.
>
>
> BUG=672945
>
> Review-Url: https://codereview.chromium.org/2971063003
> Cr-Original-Commit-Position: refs/heads/master@{#487903}
> Committed: https://chromium.googlesource.com/chromium/src/+/33133e5767a9c1ca1f7e9defad2d7b3347065589
> Review-Url: https://codereview.chromium.org/2971063003
> Cr-Commit-Position: refs/heads/master@{#488381}
> Committed: https://chromium.googlesource.com/chromium/src/+/bef3daf02ae6035f166782025fd7e4e54d465271

TBR=yfriedman@chromium.org,agrieve@chromium.org,zpeng@chromium.org,ranj@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=672945

Review-Url: https://codereview.chromium.org/2985613002
Cr-Commit-Position: refs/heads/master@{#488390}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/f1ed1692b568..0e1c43e75abf

$ git log f1ed1692b..0e1c43e75 --date=short --no-merges --format='%ad %ae %s'
2017-07-20 loloangela Fix errors related to the bad-continuation param
2017-07-20 sullivan Remove old versions of benchmark health report.
2017-07-20 mikecase Fix benchmark_runner being unable to sometimes configure logging.

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I95d20d4e5a098a0068443e9eb512fabeddef0a00
Reviewed-on: https://chromium-review.googlesource.com/580190
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488389}

Right now, this CL is vacuous, since |db_thread_| is always set.

However, while changing the WebDataService to move off the DB thread, I'll be
changing ChromeSyncClient to get the correct thread from the WebDataService.  If
there is no WebDataService, then the easiest thing to do is this CL (don't
bother creating things that need a WebDataService to function, and ensure that
tests that need these created create the WebDataService first).

If we didn't do this, then one of two things would happen:
* ChromeSyncClient would pass a null db_thread_ in, which would get passed into
  the various individual datatype services here, which would then run into
  problems because at least some of them DCHECK that they have a model thread.
  These services would have to be tweaked to instead DCHECK that no one tries to
  _use_ them when there's no model thread.  I went this route first, then
  decided it made no sense to create services that weren't allowed to be used.
* ChromeSyncClient would make up a random task runner and pass it down as the
  model thread.  Again, it felt misleading to create a task runner that no one
  could run tasks on (because if someone did, it would mean they were trying to
  talk to a database that didn't exist).

So, this seemed like the clearest precursor to the future changes.

While there, I also tweaked how the conditional works for history-based services
so it would be structured similarly.

Bug: 689520
Change-Id: Ic1aaa5947e7328b322bc508e3092ab389b6f73c3
Reviewed-on: https://chromium-review.googlesource.com/578929Reviewed-by: Nicolas Zea <zea@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488388}

This CL updates Gaia containers size after its state has been updated, not
before.

Bug: 745933
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I1517fe77e1148f6af27e816782767f9b5ee22d77
Reviewed-on: https://chromium-review.googlesource.com/578869Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488387}

Bug: 699244
Change-Id: I5187cfa7e0e170a50bc270fd7f852ecdb239dfa7
Reviewed-on: https://chromium-review.googlesource.com/559789Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488386}

This CL fixes the problem with Gaia screen error overlay visibility.

Bug: 738806
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I741951a0d1d8ba511b37783cb5651fdc50a05378
Reviewed-on: https://chromium-review.googlesource.com/579287Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488385}

As logs from trybots suggest (see the associated bug), the state of the
UI during this test sometimes lags behind the test's expectations. This
CL attempts to prevent it by draining the UI thread at the moment where
the test frequently fails.

This was impossible to verify on available trybots, but should at least
be verifiable on
https://build.chromium.org/p/chromium.fyi/builders/EarlGreyiOS, where
the flake is rather reliable (the test never passes on the very first
attempt).

TBR=sdefresne@chromium.org

Bug: 747058
Change-Id: Ib9cd3c2669357f22bc8d19474c82dabe66801740
Reviewed-on: https://chromium-review.googlesource.com/579972
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Mike Baxley <baxley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488384}

This is part 4 of 6 for FieldTrial refactoring for WebView

Part 1: https://chromium-review.googlesource.com/c/562098/
Part 2: https://chromium-review.googlesource.com/c/561920/
Part 3: https://chromium-review.googlesource.com/c/561922/
Part 4: https://chromium-review.googlesource.com/c/561980/
Part 5: https://chromium-review.googlesource.com/c/562417/
Part 6: https://chromium-review.googlesource.com/c/562021/

This CL adds a new class, PlatformFieldTrials, that the 
Chrome specific ChromeBrowserFieldTrials is now
derived from. Its implementation is currently just stubs
as they shouldn't be necessary for WebView.

BUG=678288

Change-Id: I5d7b1b77f5af39594977a5bd7ed66bf51cb63628
Reviewed-on: https://chromium-review.googlesource.com/561980
Commit-Queue: Kyle Milka <kmilka@google.com>
Reviewed-by: Alexei Svitkine (slow) <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488383}

Bug: 736903
Change-Id: Ic71d4c4d52f4ad17be6b8e9f251d79b534dea341
Reviewed-on: https://chromium-review.googlesource.com/579168Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488382}

and modifies the bytecode of classes.

Replace the Java ASSERT with JavaExceptionReporter.assertFailureHandler
that throws Exception.

Output is written to a new JAR file.

BUG=672945

Review-Url: https://codereview.chromium.org/2971063003
Cr-Original-Commit-Position: refs/heads/master@{#487903}
Committed: https://chromium.googlesource.com/chromium/src/+/33133e5767a9c1ca1f7e9defad2d7b3347065589
Review-Url: https://codereview.chromium.org/2971063003
Cr-Commit-Position: refs/heads/master@{#488381}

Original CL: http://crrev.com/c/578488

Fixes: Cronet builders

TBR=hanxi@chromium.org,agrieve@chromium.org,yuweih@chromium.org

Bug: 731159
Change-Id: I6a54dfbae76c1d55166dbcaaea7bbbc93e60bf34
Reviewed-on: https://chromium-review.googlesource.com/580267
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488380}

RendererSettings is consumed by DirectRenderer and its subclasses. 
Renderers are part of viz so RenderSettings should also be in viz. It
is moved to common because browser is going to send RendererSettings
initialized via command line flags to Viz. The rest of the CL updates
includes, forward declarations and namespaces as appropriate.

Bug: 722935, 732825
Change-Id: Iaf9ec362f3987b25fc1a1157bd07f62a17cee271

TBR=boliu@chromium.org, piman@chromium.org, sadrul@chromium.org

Change-Id: Iaf9ec362f3987b25fc1a1157bd07f62a17cee271
Reviewed-on: https://chromium-review.googlesource.com/579592
Commit-Queue: Xingyu Zhang <staraz@chromium.org>
Reviewed-by: Bo Liu <boliu@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488379}

The InitTaskGetHardwareClassOnBackgroundThread() code calls into
StatisticsProvider::GetMachineStatistic(), which calls
WaitForStatisticsLoaded(), which uses a WaitableEvent.

Bug: 743056
Change-Id: I3da6e975b1d774f963ca4cdb9242878357bd2b78
Reviewed-on: https://chromium-review.googlesource.com/572740Reviewed-by: Alexei Svitkine (slow) <asvitkine@chromium.org>
Commit-Queue: Alexei Svitkine (slow) <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488378}

Bug: 736904
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I179d50c4dd3e2c835f06145e2c453c0012f1e001
Reviewed-on: https://chromium-review.googlesource.com/578952Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488377}

Change-Id: I6094dd41a321a93333bee8c8d26b16db7cff1191
Reviewed-on: https://chromium-review.googlesource.com/580348
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488376}

Using wpt-import in Chromium dd9a923e.

Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/348

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=qyearsley@chromium.org

No-Export: true
Change-Id: I09e8c412330f06dfbd412689ea9b03f5c49f08b3
Reviewed-on: https://chromium-review.googlesource.com/579953
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488375}

BGRX_8888 Gpu Memory Buffer is not always supported. Before using it, check it
available first.

BUG=746069
TEST=run WebGL Aquarium on eve

Change-Id: Ib49784a7706cfebd8edd572011c874b18f805f86
Reviewed-on: https://chromium-review.googlesource.com/576616Reviewed-by: Dongseong Hwang <dongseong.hwang@intel.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Dongseong Hwang <dongseong.hwang@intel.com>
Cr-Commit-Position: refs/heads/master@{#488374}

BUG=730519

Review-Url: https://codereview.chromium.org/2938913002
Cr-Commit-Position: refs/heads/master@{#488373}

FrameIsAd heuristics
====================

After this CL, TopDocumentIsolation will by default only isolate
cross-site frames that also match FrameIsAd heuristics.  This behavior
is controllable via Finch, via chrome://flags and via command line
(see below for details).

Impact on browser tests
=======================

Browser tests should not depend on the FrameIsAd heuristics.  This is
taken care of by EnableTopDocumentIsolationForTesting, which enables
the mode that isolates all frames that are cross-site from the main
frame.

chrome://flags changes
======================

This CL tweaks TopDocumentIsolation's entry in chrome://flags, so that the
following variations are present (3. and 4. are introduced by this CL):
1. Default
2. Enabled
3. Enabled (CrossSite - isolate all frames from sites other than
            the top-level frame)
4. Enabled (Ads - isolate only cross-site ads detected by heuristics)
5. Disabled

Today variations 1 and 5 turn off TDI mode (because the default for
kTopDocumentIsolation base::Feature is to be disabled).  Variation 3
enables TDI and isolates all cross-site frames (this is what browser
tests use when enabling TDI via EnableTopDocumentIsolationForTesting).
Variations 2 and 4 enable TDI and use FrameIsAd heuristics.  Probably a
better name for variation 2 would be "Enabled (unspecified isolation
mode)", but the "Enabled" string is hardcoded in the chrome://flags
code.

I've manually tested that if a user enabled TDI in chrome://flags before
this CL, then it will stay enabled after this CL (variation 2).

Command line
============

After this CL, the user can control TDI with the following command line
switches:

- When no extra cmdline switches are present, then TDI is controlled via
  chrome://flags and/or Finch experiments.

- Cmdline flags to disable TDI:
  --disable-features=top-document-isolation

- Cmdline flags to enable TDI using unspecified / default isolation mode:
  --enable-features=top-document-isolation

- Cmdline flags to enable TDI using specific isolation mode (1 for
  cross-site, 2 for ads;  see the TopDocumentIsolationMode enum for all
  possible values):
  --enable-features="top-document-isolation<TopDocumentIsolation" \
  --force-fieldtrials=TopDocumentIsolation/Cmdline \
  --force-fieldtrial-params=TopDocumentIsolation.Cmdline:mode/1

BUG=733303
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2946113002
Cr-Commit-Position: refs/heads/master@{#488372}

There is an option to configure the maximum size of the NetLog. The
default is 100MiB.

This is a re-land that was originally reviewed at https://chromium-review.googlesource.com/c/571514/

TBR=xunjieli@chromium.org

Bug: 679030
Change-Id: Ibf4fd80bca9ecd2d7899bc7039a930bbfc70ffa0
Reviewed-on: https://chromium-review.googlesource.com/580030Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488371}

https://pdfium.googlesource.com/pdfium.git/+log/dc11ec85ebf6..77417ec9e131

$ git log dc11ec85e..77417ec9e --date=short --no-merges --format='%ad %ae %s'
2017-07-19 tsepez Make CPWL_Wnd classes be observable.

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: Iffe7f8d656cd04ddc17b622d819f3d3499691c66
Reviewed-on: https://chromium-review.googlesource.com/579664
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488370}

Rename the media-engagement feature flag to
RecordMediaEngagementScores in order to better describe what it
is doing.

BUG=None

Change-Id: I3d3ac469f6c32418396ca95884d18374ce8db1e1
Reviewed-on: https://chromium-review.googlesource.com/579196Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488369}