- 10 Sep, 2020 40 commits
-
-
Reda Tawfik authored
1) Adds list all user credentials to the Model from the Mediator. 2) Adds the credential model to properties class. 3) Creates a ViewHolder for the credential view. 4) Implements the Adapter for the RecyclerView. 4) Implements |bindCredentialView()|. 5) Sends focused field type from native to java. 6) Adds a test to check if the model updates the view properly. Screenshot: https://bugs.chromium.org/p/chromium/issues/detail?id=1104132#c11 Bug: 1104132 Change-Id: I4606a13214f5e815bce41207e72cde6caed60fd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370542 Commit-Queue: Reda Tawfik <redatawfik@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#805854}
-
Fredrik Söderqvist authored
This has only one actual user - AnimatedPropertyTypeSupportsAddition() which is only called when the animation has a target. Since a test reads the type add GetAnimatedPropertyTypeForTesting(). Bug: 1017723 Change-Id: Iaada97a2d281c0067f73f44a80f9e84837ca951d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403471Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#805853}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/625eb197594e..feb1579dfb25 2020-09-10 treehugger-gerrit@google.com Merge "metrics: Extend metric proto before registering metric" 2020-09-10 treehugger-gerrit@google.com Merge "traceconv: add missing flush in output writer" 2020-09-10 treehugger-gerrit@google.com Merge "Add back reserved lines commented earlier" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I4c916d735961aeb4cd154a94e34d6e6543cc33d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404040Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805852}
-
Batalov Vladislav authored
Android can throw an exception during checking scheme. https://cs.android.com/android/platform/superproject/+/master:frameworks/base/media/jni/android_media_MediaDrm.cpp;l=987?q=throwExceptionAsNecessary It seems like there is no reason to not catch it neither. Change-Id: Ib6b1e889f3849a24372a0a3f0601c5f5193da9fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401099Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#805851}
-
Eric Willigers authored
DirectSocketsServiceImpl::OpenTcpSocket() now calls CreateTCPConnectedSocket() on the network context. Browser test DirectSocketsBrowserTest.OpenTcp_Options verifies that the remote address, port, buffer sizes and no-delay flag are passed successfully. NavigatorSocket::PendingRequest has been split into TCPSocket and UDPSocket classes, currently with no web-exposed members implemented. https://github.com/WICG/raw-sockets/blob/master/docs/explainer.md#tcp https://github.com/WICG/raw-sockets/blob/master/docs/explainer.md#udp Explainer: https://github.com/WICG/raw-sockets/blob/master/docs/explainer.md Intent to Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/ARtkaw4e9T4/m/npjeMssPCAAJ Design doc: https://docs.google.com/document/d/1Xa5nFkIWxkL3hZHvDYWPhT8sZvNeFpCUKNuqIwZHxnE/edit?usp=sharing Bug: 905818 Change-Id: I7030f73d4863767b3d51a615fd84380148011bec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391181 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#805850}
-
Matthew Mourgos authored
Bug: 1080827, 1122723 Change-Id: I8349f698e9c403a53d3c265380337be35c024402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399620Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#805849}
-
Mei Liang authored
This CL adds the following a11y support to the TabSelectionEditor: * Adds content description to the TabSelectionEditorLayout and announces the description when TabSelectionEditor shows to screen. * Update the TabSelectionEditorToolbar navigation button content description. Everything introduced in this CL is gated by field trial under the enable-tab-grid-layout flag and the enable-tab-groups-continuation flag. All Java code is verified to be behind the gating function TabUiFeatureUtilities#isLaunchPolishEnabled by formal equivalence checking tool here: http://crrev.com/c/1934235. The changes in the tab_selection_editor_layout.xml can't be verified by the tool, but it is expected. Without both flags, it is a no-op. Bug: 1124919 Change-Id: I2a4a7ff575808d71e8a4594ee158ca45a87a006f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399314 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#805848}
-
Mike Wittman authored
Updates the test expectation to account for the component debug ASAN build using a .cr.so extension on the base unittests module. Bug: 1126928 Change-Id: I49fba26c817d6e2e1b0aeeedadea8f440e4d6a98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404301 Auto-Submit: Mike Wittman <wittman@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#805847}
-
Tamir Duberstein authored
The referenced bug never tracked this test. Change-Id: I6c36f578482742bcbcf7b4054b7fadcd62c12a12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403701Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Tamir Duberstein <tamird@google.com> Cr-Commit-Position: refs/heads/master@{#805846}
-
Olivier Yiptong authored
This change logs the time it takes to enumerate fonts on Mac using a UMA histogram. Bug: 1043306 Change-Id: I9bbed21d4004d6c2c30184bf6770360e7cb7c5ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403589 Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
-
Thomas Tellier authored
Bug: 1066489 Change-Id: I5af5d0ab745176572dfa01cb02e6d45ac1b27c99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303429 Commit-Queue: Thomas Tellier <tellier@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#805844}
-
Xianzhu Wang authored
These functions are used in DCHECK only. The guards make it clear that these functions don't affect release production. Change-Id: Ia1fb5e1a7208f53a8e120f82340c75057de852e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398914 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#805843}
-
Siyu An authored
Bug: 1082013 Change-Id: Ic6736d65ff962a400cd0cd714ca27a25200346c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401849Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#805842}
-
Mark Cogan authored
This CL fixes a variety of issues that will cause crashes or timeouts in EG and unit tests with the multiwindow flag enabled: - InstallationNotifier will keep polling forever by default, and since it's a singleton that lives through the whole test app's lifetime, it can hit DCHECKs when objects it depends on get eventually deallocated. This CL adds a method to stop polling, and uses it in the download manager test (which was triggering the polling). Long-term, this shouldn't be a singleton. - SelectorCoordinatorTest needed to have explicit timeouts added to some waits; it was spinning forever in the simulator with MW enabled. - PassphraseTableViewControllerTest needed to create some dummy state objects, because one of the settings view controllers grabs the scene state. There are several layers of cleaner fixes possible here -- refactoring the view controller to not access model/app objects, etc. - The history and bookmarks EG tests include tests for opening new windows, but they cause various EG test failures when they are actually run with the flag enabled. With this CL in place, there are still numerous unit test *failures* with multiwindow enabled, but not any crashes or timeouts. (Prior versions of this CL enabled multi-window on trunk; it now doesn't do that). Change-Id: Idde141baa4f28d17828367fb359630723c2d12dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310676 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#805841}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2b117e76f5dc..fb8d5f7d60cb 2020-09-10 jobay@google.com Typecheck quick_open/FilteredListWidget.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If8f2e3c08d38791c856383f25f4be00dd6bb5d75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403942Reviewed-by:
-
Dave Tapuska authored
Synthetic events injected had a static timestamp. In https://chromium-review.googlesource.com/c/chromium/src/+/2235936 static timestamps were used but the real timestamp should be used. This change reverts the code back to the original. BUG=1122950 Change-Id: I52a825365fe658ab8803fea8e6ffb908b77b719b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398971Reviewed-by:
-
Arnaud Mandy authored
use of test-only-api.js in preparation for launching official MojoJS support in WPT. This would not change the test results on Chromium waterfall (everything should continue to pass) or upstream WPT (tests currently fail because MojoJS isn't enabled). Bug: 1123990 Change-Id: Ib1c94aa4980503ab90857f716f334d42a3cb4b0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396220Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com> Cr-Commit-Position: refs/heads/master@{#805838}
-
Ian Kilpatrick authored
Fixes: 1002815 Change-Id: I0c727fa8714f4a996db6b0d44c39be2a409a4c15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404261 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#805837}
-
kylechar authored
A crash has been traced back to a deserialization error on the viz.mojom.FrameSinkManager RegisterFrameSinkHierarchy IPC. Add some CHECKs to identify the root cause of bad FrameSinkId(s) being sent. Bug: 1115094 Change-Id: Ie8aaf54bdddfb6d649b1386ac62edfb0df639cff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403581Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#805836}
-
Luum Habtemariam authored
The URLLoaderFactory interface grabbed from g_process can become invalidated, like on network changes, so we can't save it. This change modifies PpdProvider to grab it fresh before every fetch. Test: chromeos_unittests passes Bug: chromium:1123567 Change-Id: I2718548c45b61b34d78c17966037e8ccb91d654f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389020Reviewed-by:
Piotr Pawliczek <pawliczek@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#805835}
-
Peter Kasting authored
Bug: none Change-Id: I391f332af03db0d79877b0983c2060fc3f6bfaf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385239 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#805834}
-
Andrew Grieve authored
Also update comment about .ndjson->.size Bug: 1123778 Change-Id: I3f7465d5babcb990da23cefee0582589a15e44a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404142 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#805833}
-
Owen Min authored
The command line swtiches --device-management-url and --realtime-reporting-url are disabled on Window, Mac, Linux, Android on Beta and Stable channel. They are still allowed in Dev, Canary, trunk and browser tests. The are still allowed on Chrome OS without any additional condition. Bug: 1119515 Change-Id: I8b78b030e06e4339e374387004d4e8e37ab863f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382870 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#805832}
-
Charlie Hu authored
This CL fixes a crash caused by having a stand alone default feature(*) in document policy header/policy attribute. Bug: 1124853 Change-Id: I2ac5ef051e19e2b729a7e80724a1deedc1d333da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403584 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#805831}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/498d5ea20aed..9427c97d9c29 2020-09-10 bryan.bernhart@intel.com Fix ASSERT in WindowsDebugLogger again If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Id2c0eb72dd979f2da6e83bdb81639fa2201da755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403903Reviewed-by:
-
Josh Nohle authored
When the Nearby Share service is created, start the certificate, contact, and local-device-data managers. No manager tasks are run until the managers are started. We also add logging. Change-Id: I9ee592d181f1fbe670318d364b3a5fec4dec45b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370924 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Auto-Submit: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#805829}
-
Prakhar authored
Pending build time looks within limits as of now: http://shortn/_knva2rUxM9 (except for a single spike) Bug: 1024915 Change-Id: I48263543636a7d47c02164f183d85e24983dab1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404220 Auto-Submit: Prakhar Asthana <pasthana@google.com> Commit-Queue: Erik Staab <estaab@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#805828}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202009100800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/rr3VhMXsq7y_PFGfYuF4xO5k6h8d3dTyYtD20gc4jK8C If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/128567301,b/138961540,b/159892033,b/161761740,b/162294373,b/162706572 Tbr: media-app@grotations.appspotmail.com Change-Id: Ief0ec7ac5c174ac0de829ff6b2a19deffa470bda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403637Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805827}
-
Matthias Körber authored
The missing groups result in a DCHECK fail when votes for the new types are generated. Change-Id: Id8000421161b382d7d3d35dcd95c9f8411a19faa Bug: 1126957 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403472Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Commit-Queue: Matthias Körber <koerber@google.com> Auto-Submit: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#805826}
-
Alison Maher authored
Handle :visited background-colors in a similar way to the normal background-color property in Forced Colors Mode. Bug: 970285 Change-Id: I1dd0ac2530f3dec7de4b79de459d34e1d2ae193b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393299Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#805825}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d281ff186273..607aa13c8b9a 2020-09-10 chrome-bot@chromium.org Update config settings by config-updater. 2020-09-10 chrome-bot@chromium.org Update config settings by config-updater. 2020-09-10 vapier@chromium.org image test: rename white/black lists 2020-09-10 yueherngl@google.com brya: add factory/recovery signing and disable HW test 2020-09-09 yichengli@chromium.org artifacts: Use paths without leading ./ in firmware tarball If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I2afd0da6ac1321287665cde038dc4553edb371dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403634Reviewed-by:
-
Michael Chang authored
This will add a mechanism for the updater to be able to remove any apps that are not currently on a machine. Bug: 1056450 Change-Id: Id8fa734def07599d3926999a7a2c5910fb618656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393947 Commit-Queue: Michael Chang <donchan@microsoft.com> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#805823}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fb5e0ebef07c..18f6a54fc3ce 2020-09-10 bsalomon@google.com Revert "Temporary hack to force text texture index varying to be float." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: reed@google.com Change-Id: Idcd459c243edaf3ce34c2050b9281e78b39a4c22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403636Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/b24900a1aa39..41974f57973e 2020-09-10 jaebaek@google.com Allow OpTypeVoid for debug function return type If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I4a554fc725fe900ae10be8804fe4e243aeba18aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403633Reviewed-by:
-
John Z Wu authored
This will allow users to opt out of leak check if desired. Also added a missing test for passwordAutofillEnabled. Bug: 1096281 Change-Id: Ibff3bf6fdb7b6bac6170f6b9aaa44938076f49fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401943Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#805820}
-
Yuki Shiino authored
macOS and iOS do not support malloc_stats and mallopt, plus we'll hit the following error if we define them. ../../chrome/tools/build/mac/verify_order: unordered symbols in Chromium Framework.framework/Versions/87.0.4260.0/Chromium Framework: _malloc_stats _mallopt So, this patch removes them when OS_APPLE. Bug: 998048 Change-Id: I5820670ce7b77d19b4f80acded73b3703b8aa478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400584Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#805819}
-
Miguel Casas authored
crrev.com/c/2401512 suggested using sizeof(variable) ISO sizeof(type) for various reasons [1]. This CL follows up by cleaning a previously landed similar idiom. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2401512/comment/8675d0dc_90c8dccc/ Bug: b/166646505 Change-Id: I86f21fd4e12f8c1b4402ec2520391f138a402f5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403680 Auto-Submit: Miguel Casas <mcasas@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#805818}
-
Shengfa Lin authored
Enable chromedriver log for CI wpt tests Change-Id: I02d4acb627ca90233b7c0dab401c7c28e6759604 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402319Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
-
Daniel Classon authored
Changes the release notes online and offline elements to render with a dom-if instead of with hidden. This makes it easier to deep link to either of the elements. Bug: 1084154 Change-Id: I1e062524cfbfb616e960141e404230fb3d85a2e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402131 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#805816}
-
Eugene But authored
Test is consistently failing on downstream bots (iPhone and iPad device) Bug: 1126746c TBR: fernandex@chromium.org Change-Id: I0cf93a563b5ca25356aa2fe8027559fc87e8f45e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404021Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#805815}
-
