GitLab

https://webrtc.googlesource.com/src.git/+log/a667f878b15c..9cee07983fc9

2020-10-16 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 17855e1b..e7588486 (817792:817908)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I327bc4c73d3b7ec429a7b25de1787b03b3563534
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481043Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#818063}

The default audio buffer sizes for a device are not currently chosen
with real-time communication in mind, and are also set independently of
the sample rate of the audio used. We want minimal latency, so we set
the buffer size to always be 10ms of audio regardless of the sample
rate.

Bug: internal 170432827
Test: On device. Ensured correct size is set.
Change-Id: Ifb7e37ef1c033e6efbabd07eb01b6c58476addc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481287Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Commit-Queue: Adam Whiteside <awhiteside@google.com>
Cr-Commit-Position: refs/heads/master@{#818062}

Adds the ability to pass in --code-review-system to specify the code
review system being used for a Skia Gold-backed gtest pixel test. This
defaults to "gerrit" if not passed in, which is what it was hard-coded
to before, but can now be set to "gerrit-internal" for internal code
reviews.

Bug: skia:10532
Change-Id: I28848158efbf83f223f5d56acdf5bd62271ce95b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476669Reviewed-by: Sven Zheng <svenzheng@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818061}

It was erroneously checking if a candidate entry in the atomic string
table was an existing lowercase version of the provided string by
comparing the two strings for lower-ASCII equality, but this doesn't
imply that the string found in the atomic string table is lowercase
ASCII.

For urgent merging to release branches, this is a minimal fix.
A followup CL will land a more efficient version of this.

Bug: 1138487
Change-Id: I3af7411879ea831c9210e43cee16bca607b51b30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480844Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818060}

Bug: None
Change-Id: Iba44c99b6146eef187f4d5a5b0492610f58649cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481122Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818059}

The new IDs are submitted to GWS and are in range to be Finch-eligible.

Bug: 1135401
Change-Id: Idc92402627fe73d2560783faa7268784708c9c41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480814
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818058}

These flags were incorrectly added to the default flags for all
js_type_check() targets at r813273, which is unnecessary.

Fixed: 1138171
Change-Id: I049c00a13345aad6cad2bf444730514a25e8bd11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474573
Auto-Submit: dpapad <dpapad@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818057}

This deflakes the test by resetting the SystemNetworkContextManager's
URLLoaderFactory remote in OnNetworkServiceCreated() (which is called
when the network service restarts) to avoid old URLLoaderFactory
instances from being used. This also adds two missing steps to the test:
(1) flushing the network interfaces for the storage partition and the
SystemNetworkContextManager, and (2) setting back up the mock
CertVerifyResult for the test host.

Bug: 1131803
Change-Id: Id14ea7351cfec959c7fa79155d4fb87340cd3250
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480810Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Auto-Submit: Chris Thompson <cthomp@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818056}

Should not mutate the object/list.

Change-Id: I3efe2e7726b2671b32ac7d9a0bc44b48621bcd69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480823Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#818055}

Bug: 772945
Change-Id: I70086bea566951bf153eee521e2ec76102470dfa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469440
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818054}

TBR: triploblastic@chromium.org
Bug: 1139399
Change-Id: Ie13bb7d23ee953f871bfd98426d7bb73cf563381
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480888Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818053}

This CL detects and allows signed exchange cache URLs even if they are
lookalikes.

Signed Exchange cache URLs (the initial URL that redirects to the
SXG) serve application/signed-exchange Content-Type response header.
In this case, the navigation will always either fail or redirect to
the primary URL (getting the content either from inside the SXG or the
network depending on whether the validations succeed).

Bug: 1110151
Change-Id: I5a15c0248402e563bb34b9643c483d80770bd121
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441276
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818052}

Also fixes having multiple test-launcher-filter-file in buidbot JSON.
As well as parsing multiple test-launcher-filter-file on Android.

TBR=bsheedy

Bug: 1139118
Change-Id: I5c27b358286cdb66402ec75a0409e2e8fb900ae5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476837Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818051}

Bug: None
Change-Id: If7fb029fa54bad0908695d087e3f5350ca42bf31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481064Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818050}

Most of the DelegatedInkTrail pixel tests are using a fuzzy comparator,
but a few are expecting exact results. They should all be using the
fuzzy off by one comparator to ensure they are consistently passing.

Also disable DelegatedInkTest.TrailExtendsBeyondPresentationArea on Dawn
as it is slightly above the pass threshold for this comparator.

Bug: 1139340
Change-Id: I52e6e1695beec4804be6f14174015e0112872957
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480813Reviewed-by: weiliangc <weiliangc@chromium.org>
Commit-Queue: Mario Bianucci <mabian@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#818049}

The Search Engine check DCHECK's on empty URL. Empty Referrers exist,
so it's better to handle that case than DCHECK on it.

Bug: 1131107
Change-Id: Ic238ff86ccc6cee912baea37d8f549b99b685f50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480963Reviewed-by: sebsg <sebsg@chromium.org>
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818048}

Bug: 1125150
Test: browser_tests --gtest_filter=DiagnosticsApp*
Change-Id: If347312a688734df64e475f44cc2c54344fecb11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476622Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Joon Ahn <joonbug@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818047}

Certain overlay candidates forward damage rects that are smaller than
the quad itself. This works perfectly fine in the case of composition
as it simply corresponds to a partial update within a quad.

However, in the case of underlays, the primary plane must have the
overlay candidate rect be FULLY replaced by a black "window" quad.

Currently the code fails to do this on promotion and will make no
attempt to do this after promotion. This change damages the entire quad
rect so that the "window" quad is fully composed on the primary plane.

The reason why this bug remains unreported (till this time) is because
it only occurs for candidates that have damage as a subset of the quad
rect. Basically, only in the case of Lacros underlays.


Bug: 1130733
Change-Id: Ib4ecd77b105c5ad6e7b46d21e9edd5a8b802412f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468678
Commit-Queue: Peter McNeeley <petermcneeley@chromium.org>
Reviewed-by: Maggie Chen <magchen@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Kramer Ge <fangzhoug@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818046}

This CL is to simplify how PaintCanvasVideoRenderer::Cache manages
video frames whose |visible_rect| is smaller than their |coded_size|.
By always using SkImage::MakeFromAdoptedTexture, texture lifetime
management is now always handled internally by skia. This will make the
transition to OOPR here much simpler.

More details about overall PaintImage effort: crbug.com/1023259
Info about the OOPR-Canvas2D project: crbug.com/1018894

Bug: 1115217
Change-Id: I2177b2deeea893fa5331afbe8796761253db2759
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451213
Commit-Queue: Jonah Chin <jochin@microsoft.com>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818045}

Code coverage setup code is only run in the chromium_trybot recipe, not
the regular CI chromium recipe

Bug: 1136565
Change-Id: I90fbbc115277ecca9740cc717d1517fe5f88a27a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480886
Commit-Queue: Stephanie Kim <kimstephanie@google.com>
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818044}

Remove JNI calls that do only that and record through the Java API.

Bug: 1139081
Change-Id: I6f22bca96f8e3bd2de125d6e302d12eadb5e4301
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473042Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818043}

This reverts commit fbde9d8b.

Reason for revert: Failing tests https://ci.chromium.org/p/chromium/builders/ci/Marshmallow%2064%20bit%20Tester/33521

Original change's description:
> Reland: Add Google Sans to FontUniqueNameLookup browser test
>
> Work around previous failure on SkiaRenderer,Vulkan bot by not running
> the tests there.
>
> This will help ensure we have local access to the Google Sans although
> the bots only verify this on Pixel devices, not on OEM devices which
> retrieve Google Sans from GMScore. Currently there is only manual
> verification for the latter.
>
> Bug: 1115064, 1129552
> Change-Id: I7817499d1cc6e60e9a151641022fd1f2de3c51e9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475698
> Commit-Queue: Dominik Röttsches <drott@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#817829}

TBR=avi@chromium.org,drott@chromium.org

Change-Id: I32809b32ddc91062e2149de90721295f063f6ad8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1115064
Bug: 1129552
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481008Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818042}

Bug: 1136486
Change-Id: Id15a99875e7529985df3d795994dbb162e5c0460
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462491
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818041}

This reverts commit 4d32f3cb.

Reason for revert: crbug.com/1139337

Original change's description:
> Pass CSSValue TreeScope to StyleBuilder::ApplyProperty
>
> Wrap CSSValue and the corresponding TreeScope from MatchResult in a
> ScopedCSSValue passing it to StyleBuilder.
>
> Currently use a nullptr TreeScope in the cases where we don't have one
> to look up tree-scoped references. We do not support such names/
> references in UA stylesheets. We currently support @keyframes in user
> stylesheets, but collect them from the StyleEngine regardless of which
> scope the animation-name came from. It would be possible to have a
> TreeScope for user sheets (and even UA sheets) and use
> ScopedStyleResolvers instead of extra structures in StyleEngine. For now
> pass null TreeScopes for UA and user style values.
>
> Bug: 336876
>
> Change-Id: I4c5af46bde94b9fda41d676982d9e9386b652538
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455609
> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
> Reviewed-by: Fernando Serboncini <fserb@chromium.org>
> Commit-Queue: Rune Lillesveen <futhark@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#816999}

TBR=fserb@chromium.org,futhark@chromium.org,andruud@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 336876
Change-Id: I223a24e0e93ed80dbfd9a7f9ba9b2ced10acb93c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480644Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818040}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/985f6835c900..71478928d7c2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC rbpotter@google.com,juanmihd@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1126301,chromium:1137985,chromium:1138532,chromium:1139098
Tbr: rbpotter@google.com,juanmihd@google.com
Change-Id: I5a7887382bc20e921a067f03e545ebedbe653913
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480924Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#818039}

This class will be used to do default search engine prefetches. Right
now, it is created based on a feature/not incognito, and does little
else.

Bug: 1138629
Change-Id: I763d9c05b6c2341d32dee9e6cf73103898ac6734
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477902
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Auto-Submit: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818038}

No change to production logic. This adds a test to verify we collect
renderer process histograms and merge them with browser process
histograms (at which point we can be confident they'll be included in
the next UMA log).

Fixed: 1112018
Test: run_webview_instrumentation_test_apk -f AwMetricsIntegrationTest.*
Change-Id: I2a4cd8328061fea6e67f9f4fb43f1fdd07669525
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473807
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Auto-Submit: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818037}

Add a debugging chrome:// URL that loads a page with JavaScript that
just throws some exceptions. This will be used to test the WebUI
JavaScript Error Reporting feature, both manually and in integration
tests.

This page is currently Linux + Chrome OS only. It may be added to
Windows in a future CL if https://crbug.com/1129544 is fixed and
the general WebUI JS Error Reporting feature gets Windows support.

Bug: chromium:1121816

Change-Id: I3d7e29c15d6af9a863b023d900ced5d8c542d12d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473157Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Ian Barkley-Yeung <iby@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818036}

Element.classList is normally updated by AttributeChanged(). When the
underlying attribute is updated via the corresponding SVG animated
property AttributeChanged() is not invoked, which makes the list and
attribute go out of sync.

Refactor baseVal updates on SVGElement so that they go through a single
entry point by renaming SvgAttributeBaseValChanged() to
BaseValueChanged() and folding it into the other user
(SVGElement::AttributeChanged). Fold InvalidateSVGAttributes() into
BaseValueChanged() since it's the only caller.

BaseValueChanged() is then updated to update the classList when the
className base value is updated. Move the classList update into a shared
Element::UpdateClassList() function.

Fixed: 1137953
Change-Id: I64efff0bfd163b14eb937c635c3d170b4511f4a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480023
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818035}

Bug: 1085261
Change-Id: Ia9e9e3749918a2c19c57b7dae96fc22600f66f80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472587
Auto-Submit: Xinghui Lu <xinghuilu@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818034}

Removed histogram:
- Settings.HomePageIsCustomized
- Settings.ShowHomeButtonPreferenceState*

Bug: 1109958, 1138318
Change-Id: I7dee5c0c3c4e59271f4df929e849f92033e5ccc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472431
Commit-Queue: Wenyu Fu <wenyufu@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Auto-Submit: Wenyu Fu <wenyufu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818033}

These GPU Memory Tracking UMA is no longer used. The sum of these
memory tracking can be found Memory.Gpu.PrivateMemoryFootprint. The
latest memory tracking uses the peak memory observer.

Bug: 928615, 1112389
Change-Id: Ia4ced34d8e1b7c7135b95d69219e1f5f4fe6e054
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469076Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: weiliangc <weiliangc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818032}

This is the right thing to do in general, since we treat cloaked windows
as non-occluding. It also fixes an issue with switching virtual desktops
since that triggers window cloaking and uncloaking events.

Bug: 1137419
Change-Id: I2b66182bc72c17e69c3f72cd793e2924ba483bb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478082
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Reviewed-by: Jesse McKenna <jessemckenna@google.com>
Cr-Commit-Position: refs/heads/master@{#818031}

This is in preparation for avoiding excessive UKM reporting for viewport
size media queries in [1].

The skip_ukm_reporting_ will be set to true when we detect if any media
queries have changed, e.g. on window resize. The new result will be
detected later in RuleSet::AddRulesFromSheet for stylesheets and
MediaQueryList::UpdateMatches() for matchMedia() when the evaluation
actually changed.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/2449913

Bug: 973801
Change-Id: Ic8db810c8be2f223e08113db040d5515c42e6592
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479372Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818030}

Change-Id: I3e518d396d1e19cbfe71287984c65d7e0d9b7688
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473164Reviewed-by: John Williams <jrw@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818029}

Change-Id: I1eeac7ede3aca6c71856ce541a086b5f302936ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473360
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818028}

Replacing site URL comparison with a check that compares extension
pointers. This is similar to ProcessManager::GetExtensionForWebContents()
code which appears to be trying to accomplish the same goal. This change
is part of an effort to remove site URL usage across the code base.

Bug: 1085275
Change-Id: Ice16e145849786eabcfbe5fd05861528a2beb8a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212785
Commit-Queue: Aaron Colwell <acolwell@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Auto-Submit: Aaron Colwell <acolwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818027}

Generate DIR_METADATA files and remove metadata from OWNERS
files for //ui/events.

R=nzolghadr@chromium.org, sadrul@chromium.org, wez@chromium.org

Bug: 1113033
Change-Id: I3efd4af2f9405bcddef0b0574553b55cf413cbe1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477662
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818026}

Generate DIR_METADATA files and remove metadata from OWNERS
files for //ui/gfx.

R=thakis@chromium.org

Bug: 1113033
Change-Id: I9e1aeded0e6703a8473bd83fa2c7d7e98ebe3121
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477445
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818025}

This CL adds the initial drag image that is displayed when dragging
items out of Holding Space UI. Follow up CLs will:

- Render screenshot items differently
- Render at most two items with an overflow badge if necessary

Note that this CL does not use ui::Layer's to accomplish the desired
drop shadow effect because a solution could not be identified to paint
a view hierarchy with its layer tree to an SkBitmap.

Demo: http://shortn/_mWLGXsTcTY
Note that the screen recorder did not capture the cursor moving with
the drag image but it actually does so on device.

Bug: 1139113
Change-Id: I569bf42b31beb19459f85a80bfc1c3f673a40b1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476728
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818024}