- 08 Nov, 2018 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2f8889b876d3..23d1f94faac1 git log 2f8889b876d3..23d1f94faac1 --date=short --no-merges --format='%ad %ae %s' 2018-11-08 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@23d1f94faac1 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: I07b09336847b1d21e54c779a02af902c55bca8ce Reviewed-on: https://chromium-review.googlesource.com/c/1325861Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606392}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/026f83d49289..f04a3a61ad90 git log 026f83d49289..f04a3a61ad90 --date=short --no-merges --format='%ad %ae %s' 2018-11-08 dpranke@chromium.org Update the expectation parser in TYP to match the new format. Created with: gclient setdep -r src/third_party/catapult@f04a3a61ad90 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:835690 TBR=sullivan@chromium.org Change-Id: I342f7d89d9cd55f70eaad8659ac9d56450d4ddf5 Reviewed-on: https://chromium-review.googlesource.com/c/1325653Reviewed-by:
-
Alexandre Courbot authored
This document used to be maintained as a Google Docs, but having it available in the Chromium repository makes it much easier to access for partners. BUG=None TEST=Generated and checked HTML using Markdown. Change-Id: I790504be2720150cebee151a585a2435ac35a494 Reviewed-on: https://chromium-review.googlesource.com/c/1322174 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#606390}
-
Yuzu Saijo authored
This CL allows detection-only mode for oom intervention in order to gather data from finch, while not actually triggering intervention (or the infobar). Change-Id: I511bf3ccd51218521a526ea001de2a823e1c16bc Reviewed-on: https://chromium-review.googlesource.com/c/1325583Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/master@{#606389}
-
Yoichi Osato authored
We used to invalidate always LayoutSVGText even local selection rect was empty before inserting early return of L342. That caused regression that selection in svg text is not invalidated. This patch fixes the regression by invalidating LayoutSVGText always as before. Bug: 897752 Change-Id: I534959ccb461d55d38e85e053c9b9c478b3878b3 Reviewed-on: https://chromium-review.googlesource.com/c/1314019 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#606388}
-
Gauthier Ambard authored
This CL removes the -closeAllIncognitoTabs command as it is not used. Bug: 902781 Change-Id: I583e53095fcddf03c899d6b44779b38daced32a3 Reviewed-on: https://chromium-review.googlesource.com/c/1323670Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#606387}
-
Arthur Sonzogni authored
After sending: URLLoaderClient::OnReceiveResponse(response_head), not all URLLoader are sending: URLLoaderClient::OnStartLoadingResponseBody(response_body). It even happens to send URLLoaderClient::OnComplete(net::OK) after that, which may confuse the URLLoaderClient. Most URLLoader not sending a response's body datapipe are the one with an empty response. For consistency, always send a response's body datapipe, even if it doesn't contains data. This CL updates every tests not aligned with this. Once every URLLoader and tests are consistent. DCHECK enforcing this will be added. This CL is a prerequisite for: https://chromium-review.googlesource.com/c/chromium/src/+/1172290 Bug: 826868, 831155 Change-Id: Id3434ea442c93b47bd200d15322cc21cd0c0b89f Reviewed-on: https://chromium-review.googlesource.com/c/1323092Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#606386}
-
Hayato Ito authored
This bug number is not related to the content of TODO comment. TBR=rakina@chromium.org Change-Id: Ifd8563c8104a00134d91c176d8418b93592098da Reviewed-on: https://chromium-review.googlesource.com/c/1325284Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#606385}
-
yoshiki iguchi authored
This CL is almost reverts of the following CL: crrev.com/c/1315207 This test has been disabled on Chrome OS because of flakiness: crbug.com/901235. The flakiness is fixed by the recent change (crrev.com/c/1316986) so that this CL re-enable it. TBR=mlamouri@chromium.org, vitaliii@chromium.org Bug: 901235 Test: trybots pass Change-Id: I1cec695988728ae40bd1f6031135efaf07c760b3 Reviewed-on: https://chromium-review.googlesource.com/c/1325597Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#606384}
-
John Z Wu authored
1. Add API to enable explicit updates of expiration dates. This is needed to handle cases where user was issued a new card where only the expiration date and CVCs changed. 2. Remove CWVCreditCardVerifierErrorMessageKey and use NSLocalizedDescriptionKey instead. Change-Id: Iff1dbed037d991be8d582c5e734d49e33916de99 Reviewed-on: https://chromium-review.googlesource.com/c/1325282 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#606383}
-
David Jean authored
These helpers create a bridge between manual fill credit card and payments' FullCardRequester to let user 'unlock' server side credit card by entering correct cvc. Bug: 845472 Change-Id: I9fcf013a0352673659d77291c03faa8aa31a9980 Reviewed-on: https://chromium-review.googlesource.com/c/1304413Reviewed-by:
Eric Noyau <noyau@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#606382}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/28451dd1..acacecec Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I67d87ebec9b223023d4665986c066d27fc07bc0a Reviewed-on: https://chromium-review.googlesource.com/c/1325416Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606381}
-
Camillo Bruni authored
This CL updates a couple of system_health wprgo archives. Simple failing GET requests have been manually added to reduce the number of network failures in the benchmarks. Improvements in network requests: play:media:soundcloud:2018 41 down to 8 load:search:taobao:2018 10 down to 3 multitab:misc:typical24:2018 110 down to 96 browse:news:reddit:2018 16 down to 13 load:news:cnn:2018 no change Bug: 878390 Change-Id: I2b2e15e84fe9688a1db72d9216491ed290c94c6a Reviewed-on: https://chromium-review.googlesource.com/c/1323053 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#606380}
-
Yuta Kitamura authored
This CL simplifies lengthy function calls via Platform::Current() that obtain the current, main or compositor thread by using Thread:: Current(), Thread::MainThread() or Thread::CompositorThread(). Bug: 826203 Change-Id: I791712e02848b8792204b598fc7fa19114ae36cd Reviewed-on: https://chromium-review.googlesource.com/c/1319395Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#606379}
-
Nigel Tao authored
This is a reland of f3fe6cc9 with additional changed files: chrome/browser/chromeos/apps/intent_helper/apps_navigation_throttle.cc chrome/browser/chromeos/apps/intent_helper/apps_navigation_throttle.h chrome/browser/chromeos/apps/intent_helper/apps_navigation_types.h chrome/browser/ui/views/intent_picker_bubble_view.h to fix some #include lines not being updated for the file renames, which then required these DEPS changes: chrome/browser/chromeos/DEPS chrome/browser/ui/views/DEPS Original change's description: > Move the app_service code to //chrome/services > > The app_service code was originally created under //chrome/browser, > specifically //chrome/browser/apps/foundation. This was because of an > early concern that the app_service implementation would need to be > tightly coupled to browser concepts, especially a Profile. More recent > prototyping suggests that this won't be the case. > > This is just a "git mv" plus some semi-mechanical clean-up, e.g. keeping > "#include" lines sorted. > > Change-Id: I0e511f5cab636afb7ac5e5235139873d75230377 > Reviewed-on: https://chromium-review.googlesource.com/c/1312435 > Reviewed-by: Dominic Battré <battre@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Commit-Queue: Nigel Tao <nigeltao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605876} Change-Id: I27729734618c7e023074b5e420c6350225d0774e Reviewed-on: https://chromium-review.googlesource.com/c/1321530Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#606378}
-
Hayato Ito authored
It would be better to remove the author field. See https://crrev.com/c/1322179 for the context. TBR=tkent@chromium.org Change-Id: Id97a9603b1cee3f31058e864ee3e0ff92c1d741e Reviewed-on: https://chromium-review.googlesource.com/c/1325287Reviewed-by:
-
Jinho Bang authored
This patch adds a use counter to number of calling updateWith() without shippingOptions dictionary member on ShippingAddressChange and ShippingOptionChange events. Bug: 902291 Change-Id: Iac779040dc1a7245dcfe4db795e09d4ecbca9b90 Reviewed-on: https://chromium-review.googlesource.com/c/1319653 Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#606376}
-
Tarun Bansal authored
For default search engine pages, give higher weight to cross-origin anchor elements. For non-default search engine pages, give higher weight to same-origin anchor elements. Change-Id: I6de3037d9b28dbb770032255f8f22a7c2e6342a6 Bug: 899098 Reviewed-on: https://chromium-review.googlesource.com/c/1300594 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#606375}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/448b99f1a580..905ee08219fa git log 448b99f1a580..905ee08219fa --date=short --no-merges --format='%ad %ae %s' 2018-11-08 syoussefi@chromium.org Vulkan: Fix cleanup race condition on Context destroy Created with: gclient setdep -r src/third_party/angle@905ee08219fa The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Change-Id: I72a3bbd07553babdf9562fd32b6e3f766080966f Reviewed-on: https://chromium-review.googlesource.com/c/1325335Reviewed-by:
-
Yuki Shiino authored
We've been allowing cross-origin named access on Window just in order to keep the backward compatibility for a while. This patch finally fixes it and ignores cross-origin window name when performing named access on Window. Basically, this is a revert of https://codereview.chromium.org/2753773003 Bug: 538562 Change-Id: I3856bb5c655a9415c2d0b87d1ec4b3743b94d076 Reviewed-on: https://chromium-review.googlesource.com/c/1314021Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
John Abd-El-Malek authored
Remove some duplicate code between NavigationURLLoaderImpl and ResourceDispatcherHostImpl::BeginNavigationRequest. Change-Id: I7befae9ca3d332d5d31a5d0424de8eeb355a8810 Reviewed-on: https://chromium-review.googlesource.com/c/1325151 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c248c0542bc1..2f8889b876d3 git log c248c0542bc1..2f8889b876d3 --date=short --no-merges --format='%ad %ae %s' 2018-11-08 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-11-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 1bf18ce9e2ca..448b99f1a580 (1 commits) 2018-11-07 mtklein@google.com Reland "Revert "hide nested hinting enum"" Created with: gclient setdep -r src/third_party/skia@2f8889b876d3 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: I84d82a9be38b63e9069d494e0f2b4cc26c6a7769 Reviewed-on: https://chromium-review.googlesource.com/c/1325652Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/991ed76c8331..bd8b72d215eb Created with: gclient setdep -r src-internal@bd8b72d215eb The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia59d1db40325c22f70f1f86477e9a6b94c2092a2 Reviewed-on: https://chromium-review.googlesource.com/c/1325656Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606370}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: Id7ee6f3fae084182f0090ce94b9fabf9a14b72fa Reviewed-on: https://chromium-review.googlesource.com/c/1325654Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/fd5e90efc65a..538b8fbb4875 git log fd5e90efc65a..538b8fbb4875 --date=short --no-merges --format='%ad %ae %s' 2018-11-08 dgarrett@google.com repository: Use faster copy for Preload. Created with: gclient setdep -r src/third_party/chromite@538b8fbb4875 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Icb554700c85d36cfd67c6e2a2f6dbbb595f8ee01 Reviewed-on: https://chromium-review.googlesource.com/c/1325336Reviewed-by:
-
Yuta Kitamura authored
In some tests, FakeRendererScheduler is used to obtain the IPC task runner. However, FakeRendererScheduler::IPCTaskRunner() just returns nullptr, and there's no real point in using FakeRendererScheduler in those tests. This CL removes those unnecessary FakeRendererSchedulers, and passes nullptr to the arguments where an IPC task runner is expected. This CL is part of the refactoring of WebThreadScheduler. Bug: 826203 Change-Id: Ie6800829b3f30cf19a1c2212e58e4cab505df80b Reviewed-on: https://chromium-review.googlesource.com/c/1319224 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#606367}
-
Evan Stade authored
Bug: 797558 Change-Id: I859f90bb23f4a9ff6550d2a2bffcdb71ba73282d Reviewed-on: https://chromium-review.googlesource.com/c/1324148Reviewed-by:
-
Eric Orth authored
Removed a bunch of whitelist entries that were no longer needed, mostly due to completed servicification migrations. Some usage was no-longer-needed includes that I removed, and all of UrlInfo appeared to be no longer used or present in build files so I removed the whole class and tests. Some usage of MDnsClient was just accessing the Get...Endpoint() methods that could easily be moved to net/dns/public and thus no longer require whitelisting. Ensured all remaining whitelist entries were commented with why usage is appropriate or with a TODO and bug for anything still requiring servicification migration. Bug: 846454 Change-Id: I39aeeaa437bd8fe2899e78189ca7ef0adbffd1f6 Reviewed-on: https://chromium-review.googlesource.com/c/1320511 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#606365}
-
Matt Falkenhagen authored
No behavior change. According to the Blink C++ style guide, functions that aren't for web-exposed bindings must be uppercase CamelCase(). Also order some functions to match the idl. Change-Id: I7def926826a352929db20d96d7b74460d7e074c0 Reviewed-on: https://chromium-review.googlesource.com/c/1325577Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#606364}
-
Leo Zhang authored
Change-Id: Ie4008527ec268b1c67704bdc1e7ede4b60caf17e Reviewed-on: https://chromium-review.googlesource.com/c/1321709Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#606363}
-
Matt Falkenhagen authored
It was accidentally removed in r606118. Bug: 901909 Change-Id: I8a3e96b6ed2acc1aac7f71b9de30206771cb8ad1 Reviewed-on: https://chromium-review.googlesource.com/c/1325591Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
-
Takashi Toyoshima authored
Now Chrome specific origin permissions are handled in extensions::DispatcherDelegate implementation in chrome/renderer/extensions. To share this code with new callers in browser process, this change moves the method to ExtensionsClient so that browser side callers can call it. Bug: 870172 Change-Id: I0a55bd41b0eccb3450c7b6b32bc1fa5105ac3856 Reviewed-on: https://chromium-review.googlesource.com/c/1314018Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#606361}
-
Koji Ishii authored
This patch allows reusing line boxes when it is easy to resolve BFC offset. It was one of the most common criteria that prevents reusing. HandleInFlow resolves BFC for non-empty inline formatting context. The reusability increases by moving the logic to after that. This patch improves line-layout-repeat-append by ~60%. Bug: 636993 Change-Id: I90d63addd934f6966c76baa1e4dd312b68f6df4e Reviewed-on: https://chromium-review.googlesource.com/c/1314076Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#606360}
-
Varun Khaneja authored
This should catch the cases when the callback is unexpectedly null and provide a more useful call stack. I'm not convinced this will trigger because the code already de-references callback 2 lines later but I don't have a better lead at the moment. Bug: 889972 Change-Id: If63da6f5eaa611e9369da7c70cfcfc784695f01c Reviewed-on: https://chromium-review.googlesource.com/c/1323721Reviewed-by:
Nathan Parker <nparker@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#606359}
-
Michael Lippautz authored
Use asyncGC instead of window.gc(). Bug: 843903 Change-Id: Id65e65d4b3cd68a1510b3d7aff759232fc6c972b Reviewed-on: https://chromium-review.googlesource.com/c/1324616 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/316dba28ff32..991ed76c8331 Created with: gclient setdep -r src-internal@991ed76c8331 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ib54f2ca5ca0a1a7a50358163f3dd0e4545e73225 Reviewed-on: https://chromium-review.googlesource.com/c/1325396Reviewed-by:
-
Alexey Baskakov authored
To ensure URL correctness. Bug: 891172 Change-Id: If2fad77d59a3675f30c168e55c376a5c53d43262 Reviewed-on: https://chromium-review.googlesource.com/c/1325573 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#606356}
-
Etienne Pierre-doray authored
base::ThreadRestrictions::ScopedAllowWait is deprecated in favor of its more explicit counterpart. It should have been replaced by : * base::ScopedAllowBaseSyncPrimitivesForTesting in test files. * base::ScopedAllowSyncPrimitives in non-test files * base::ScopedAllowSyncPrimitivesOutsideBlockingScope when it's used on threads that don't allow blocking The last one is strongly frowned upon but this CL aims to document existing behavior rather than address it. Owners are encouraged to follow-up by fixing unnecessary waits and more particularly unnecessary waits outside-blocking-scope. Note: The non-for-testing versions require friend'ing in thread_restrictions.h but care was taken to add these friends ahead of git cl split (since it wasn't possible to do a line-by-line associated CL split). Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1288533 Please CQ if LGTY! This CL was uploaded by git cl split. R=haraken@chromium.org Bug: 766678 Change-Id: Ib67286038ee8d3f1db66a095f029e5f6a7f000d4 Reviewed-on: https://chromium-review.googlesource.com/c/1325209Reviewed-by:
-
Scott Graham authored
Bug: 883496 Change-Id: I656ef4172089f65b6febf0ba3075a510bb4e9e11 Reviewed-on: https://chromium-review.googlesource.com/c/1318835 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#606354}
-
Nicholas Verne authored
This code now avoids a redundant check of crostini UI allowed. Bug: None Change-Id: I34c15883eccb2446b4cab0388ca479c7203ed65e Reviewed-on: https://chromium-review.googlesource.com/c/1325273Reviewed-by:
Renée Wright <rjwright@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#606353}
-
