GitLab

WebRTC 8220:8247
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/cfe4b49..c24c0fb

Libjingle 8221:8245
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/18f533d..b3a2c1e

TBR=niklase

Review URL: https://codereview.chromium.org/904633002

Cr-Commit-Position: refs/heads/master@{#314805}

Cr-Commit-Position: refs/heads/master@{#314804}

Failing due to Blink r189541 which can't just be reverted. Disable this
test while investigating the Blink r198541 failure. Landing to progress
the Blink roll.

TBR=jochen@chromum.org
NOTREECHECK=true
NOTRY=true
BUG=455691

Review URL: https://codereview.chromium.org/904683002

Cr-Commit-Position: refs/heads/master@{#314803}

Fix a cast that didn't play nice in 64-bit.

Modify patch_orderfile.py and cyglog_to_orderfile to accept a --target_arch parameter.

Pass architecture to symbol_extractor.

BUG=448054

Review URL: https://codereview.chromium.org/902633002

Cr-Commit-Position: refs/heads/master@{#314802}

This fixes a TODO to point to the right path where this file now lives.

BUG=None
R=kalman@chromium.org

Review URL: https://codereview.chromium.org/887273003

Cr-Commit-Position: refs/heads/master@{#314801}

Remove old exceptions that are no longer useful after the corresponding
dependencies have been abstracted, removed or componentized.

Remove some obsolete #include from history_service.cc instead of leaving
the corresponding exception in the DEPS file since they are not used.

Add a //chrome/browser/history/android/DEPS that remove the exclusions
and exceptions since the remaining code there will not be componentized
(at least this is not blocking the iOS componentization and upstreaming
effort since this is Android specific code).

BUG=370850
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/901723003

Cr-Commit-Position: refs/heads/master@{#314800}

BUG=455572
TBR=thakis@chromium.org

Review URL: https://codereview.chromium.org/901843004

Cr-Commit-Position: refs/heads/master@{#314799}

Introduced UserSessionManagerTestApi:
* InjectStubUserContext() to configure predefined user credentials (StubAuthenticator)
* SetShouldLaunchBrowserInTests() to control whether browser instance should be created in tests. Some tests don't really need that and were not designed to handle it properly.

LoginUtils methods:
* IsWhitelisted() is moved to CrosSettings
* CreateAuthenticator() is moved to UserSessionManager
* PrepareProfile() and DoBrowserLaunch() were already just a thin wrappers around corresponding methods of UserSessionManager.

Tests changes:
* MockAuthenticator > StubAuthenticator
* Now tests that were using MockLoginUtils to inject their own test profile are using regular profile init code with a stub user_context.

BUG=435094
TBR=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/745613002

Cr-Commit-Position: refs/heads/master@{#314798}

It turns out PESQ can deal with delays, so we don't need to
silence-trim the files to get them to line up. This solves another
problem where the silence-trimming becomes too aggressive on Windows
with the new ref file.

I also need to monitor if the new ref file, which is a lot lower
in volume than the old one, unfairly punishes the score. The
speaker volume is a bit random on the bots so the recording could
end up being quite low. Tests on my workstation suggests that PESQ
is actually pretty good about ignoring that too though. There will
be a slight effect on the score (like 0.4 MOS), which I think is
acceptable. Otherwise we need to find a way to control the speaker
volume on the bots much more stringently.

BUG=446859

Review URL: https://codereview.chromium.org/890893004

Cr-Commit-Position: refs/heads/master@{#314797}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/897273002

Cr-Commit-Position: refs/heads/master@{#314796}

BUG=438050
TEST=out/Release/browser_tests --gtest_filter=FileManagerJsTest.ListThumbnailLoader

Review URL: https://codereview.chromium.org/895093003

Cr-Commit-Position: refs/heads/master@{#314795}

Otherwise if someone tries to set it now it will get something like:

$ gn gen --args='os="android" cpu_arch="arm"' out_gn_android/Debug
ERROR at //build/config/android/rules.gni:49:22: Assignment had no
effect.
    check_includes = false
                         ^----
You set the variable "check_includes" here and it was unused before it went out of scope.
See //content/test/BUILD.gn:237:5: whence it was called.
generate_jni("jni") {
   ^--------------------

BUG=367595, 376000
TEST=see above
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/885283006

Cr-Commit-Position: refs/heads/master@{#314794}

BUG=455665
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/883263005

Cr-Commit-Position: refs/heads/master@{#314793}

BUG=none

Review URL: https://codereview.chromium.org/899183002

Cr-Commit-Position: refs/heads/master@{#314792}

The implementation mirrors that of android_commands, but is hopefully
clearer and more efficient. ReadFile/WriteFile are used to read
persistent properties first, and then GetProp/SetProp are used for
the current runtime properties.

BUG=267773

Review URL: https://codereview.chromium.org/776303002

Cr-Commit-Position: refs/heads/master@{#314791}

This should work fine now that Chrome and sandbox tests behave in an
ASan-friendly way.

This effectively reverts r313452 and r312495

BUG=382867
TBR=thakis@chromium.org,scottmg@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/903553004

Cr-Commit-Position: refs/heads/master@{#314790}

Revert of Roll src/third_party/WebKit 4b9569f:fa53a39 (svn 189384:189535) (patchset #1 id:1 of https://codereview.chromium.org/901853002/)

Reason for revert:
Broke Mac GN builds

Original issue's description:
> Roll src/third_party/WebKit 4b9569f:fa53a39 (svn 189384:189535)
>
> Summary of changes available at:
> https://chromium.googlesource.com/chromium/blink/+log/4b9569f..fa53a39
>
> TBR=dcheng@chromium.org,apavlov@chromium.org
>
> Committed: https://crrev.com/e4b735f7acc2ae3ae1c891470f2a703fe8608724
> Cr-Commit-Position: refs/heads/master@{#314785}

TBR=dcheng@chromium.org,blink-deps-roller@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/881083003

Cr-Commit-Position: refs/heads/master@{#314789}

Revert of Mac Video Capture: Add support for pixel format NV12 for AVFoundation (patchset #2 id:60001 of https://codereview.chromium.org/860333003/)

Reason for revert:
Crashes on the assert that biplanar NV12 is tightly packed.

BUG=455618

Original issue's description:
> Mac Video Capture: Add support for pixel format NV12 for AVFoundation
>
> BUG=346634
>
> Committed: https://crrev.com/40c2c94fbd52f9748ee082573e07404ae2621b9b
> Cr-Commit-Position: refs/heads/master@{#313886}

TBR=perkj@chromium.org,tommi@chromium.org,mcasas@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=346634

Review URL: https://codereview.chromium.org/886933006

Cr-Commit-Position: refs/heads/master@{#314788}

This change removes market specific search provider configuration for Bing. Using a single provider for all markets will allow the Bing server to make the market determination, providing a more consistent user experience regardless of entry point. This will additionally simplify Bing's configuration for any future changes that may be needed.

It also adds Bing to markets where it was previously excluded, moves the suggestion URL to https, and updates URL parameters used for reporting purposes.

Review URL: https://codereview.chromium.org/895223002

Cr-Commit-Position: refs/heads/master@{#314787}

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with an OS=android build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463
R=wolenetz@chromium.org

Review URL: https://codereview.chromium.org/893363002

Cr-Commit-Position: refs/heads/master@{#314786}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/4b9569f..fa53a39

TBR=dcheng@chromium.org,apavlov@chromium.org

Review URL: https://codereview.chromium.org/901853002

Cr-Commit-Position: refs/heads/master@{#314785}

Review URL: https://codereview.chromium.org/903453002

Cr-Commit-Position: refs/heads/master@{#314784}

NOTRY=true

Review URL: https://codereview.chromium.org/880193003

Cr-Commit-Position: refs/heads/master@{#314783}

This removes the latest comments of "Dependencies of" and sort up these
dependencies lists, so it will be easier for people coming up later and
adding new entries, they will know exactly where to put them and it will
be much easier to review them as well.

BUG=None
TEST=components_unittests, components_browsertests
R=blundell@chromium.org

Review URL: https://codereview.chromium.org/891273003

Cr-Commit-Position: refs/heads/master@{#314782}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/63af144..528f97f

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/899973004

Cr-Commit-Position: refs/heads/master@{#314781}

Also add an ASan test to sbox_integration_tests on Windows

BUG=382867

Review URL: https://codereview.chromium.org/868253011

Cr-Commit-Position: refs/heads/master@{#314780}

Pass the list of languages to HistoryService::Init() in order to
remove a dependency on prefs::kAcceptLanguages and on Profile.

BUG=453790
R=droger@chromium.org

Review URL: https://codereview.chromium.org/870143004

Cr-Commit-Position: refs/heads/master@{#314779}

To reduce debug logging spam, this increases the warning threshold for
posting "super long" delayed tasks to 14 days (was ~18 minutes before).
Also, make the logging message more readable by printing values in terms
of seconds rather than microseconds.

BUG=450045

Review URL: https://codereview.chromium.org/897173004

Cr-Commit-Position: refs/heads/master@{#314778}

BUG=410766
TEST=FileManagerJsTest.MetadataCacheItem

Review URL: https://codereview.chromium.org/900173002

Cr-Commit-Position: refs/heads/master@{#314777}

Revert of Fix the histograms whitelist for the OOP PDF plugin. (patchset #1 id:1 of https://codereview.chromium.org/897863003/)

Reason for revert:
Introduced 2 new static initializers:

pepper_uma_host.cc (anonymous namespace)::kWhitelistedPluginBaseNames
pepper_uma_host.cc __init_array_end+0x5e8

Original issue's description:
> Fix the histograms whitelist for the OOP PDF plugin.
>
> BUG=405305
>
> Committed: https://crrev.com/ad1fecf3841f539281c8d6ff3a873bfc9c11571d
> Cr-Commit-Position: refs/heads/master@{#314764}

TBR=raymes@chromium.org,thestig@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=405305

Review URL: https://codereview.chromium.org/901863002

Cr-Commit-Position: refs/heads/master@{#314776}

Cr-Commit-Position: refs/heads/master@{#314775}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/7404c09..63af144

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/899653004

Cr-Commit-Position: refs/heads/master@{#314774}

BUG=451321

Committed: https://crrev.com/bc78a2320b50eba4fe397f1f838a82ad30b16cd6
Cr-Commit-Position: refs/heads/master@{#314231}

Review URL: https://codereview.chromium.org/889283002

Cr-Commit-Position: refs/heads/master@{#314773}

Adding some flags to make audio debugging easier. Now we can separate audible audio from inaudible, and dump the tokens in their original encoded form.

rkc@ for copresence review.
andrew@webrtc for wav_file review.

Review URL: https://codereview.chromium.org/892423002

Cr-Commit-Position: refs/heads/master@{#314772}

Previously, it was unsafe to pass a char* because it would be implicitly
converted to a string with a very short lifetime. Now, you can safely
pass a char* as long as the memory pointed to by the char* outlives the
Replacements (which is always true for string literals).

All existing usage of Replacements should continue to work as usual.

Updated every call to Replacements Set*Str methods that that could be
simplified by the new StringPiece API (for example, passing string
literals directly, instead of copying them into a string object).

Internally, renamed StdStringReplacements to StringPieceReplacements.

BUG=454274

Review URL: https://codereview.chromium.org/889463003

Cr-Commit-Position: refs/heads/master@{#314771}

This is possible now that JSONStringValueSerializer takes a StringPiece.

BUG=455068

Review URL: https://codereview.chromium.org/891473004

Cr-Commit-Position: refs/heads/master@{#314770}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/a9d9de4..7404c09

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/902773002

Cr-Commit-Position: refs/heads/master@{#314769}

TBR=rkc@chromium.org

Review URL: https://codereview.chromium.org/902493004

Cr-Commit-Position: refs/heads/master@{#314768}

Resource message requests can be relatively expensive, particularly in
the induced work on the browser IO thread. Currently, there is no bound
on the rate with which such requests are dispatched from the renderer.
This leads to situations where the browser IO thread is flooded with
requests, potentially causing scroll jank and otherwise undesirable
stalls in the browser pipeline.

Introduce a ResourceMessageThrottler which intercepts and defers a given
resource message stream, depending on the state of the RendererScheduler.
When the RendererScheduler indicates that high priority work is
imminent/likely, requests will be throttled according to a configurable
dispatch rate.

Hook this throttling mechanism up to the ResourceDispatcher, limiting
the number of resource message requests/second during user interaction
to 180 (3 per frame at 60 fps) on Android, and 480 on desktop.

See goo.gl/H42AgQ for more design details.

Note: This change originally landed in
https://crrev.com/acfb4199abf841a1577c3968579c43b0232a53b7, but was
reverted due to issues with enforced ThreadChecker validation in
RendererSchedulerImpl. The ThreadChecker validation fix has been split
into a separate patch.

BUG=440037,402136

Review URL: https://codereview.chromium.org/847883002

Cr-Commit-Position: refs/heads/master@{#314767}

BUG=449357

Review URL: https://codereview.chromium.org/896093002

Cr-Commit-Position: refs/heads/master@{#314766}