- 18 Feb, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2e0661d7dd4e..7efa03ac94b5 git log 2e0661d7dd4e..7efa03ac94b5 --date=short --first-parent --format='%ad %ae %s' 2020-02-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 481daed34f15..0bbf7ba9f909 (5 commits) 2020-02-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src ae59435606fc..113d07a6ebda (1 commits) Created with: gclient setdep -r src/third_party/angle@7efa03ac94b5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: I6d0c6fbdfe69187596fdc111b592a1cde6887d3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061789Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742088}
-
Simon Zünd authored
Devtools web tests that dump stack traces use source maps to translate source locations. The upcoming asyncification of the source mapping machinery requires that test helpers properly await the result of source mapping. This CL prepares some web tests in http/tests/devtools/sources/* for this upcoming asyncification by properly awaiting {SourcesTestRunner.captureStackTrace} and friends. This CL is a straight up mechanical change by adding async/await keywords in the necessary places. Drive-by: Also await {ConsoleTestRunner.dumpConsoleMessages} in the http/tests/devtools/sources/* web tests. R=mathias@chromium.org Bug: chromium:1032016 Change-Id: If5962a091f872a3aef32f1af005b9e4aa37671bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061150Reviewed-by:Mathias Bynens <mathias@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#742087}
-
Hitoshi Yoshida authored
Generates setXxxToNull() to set null value on a nullable dictionary member, whose C++ type uses base::Optional<T>. This API is a migration adapter, and there are some use cases in hand-written code. We also can set a null value for other types using setXxx() APIs. Bug: 839389 Change-Id: I6989a58ed3542d4f76f7b9e519f3c49947732904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060406 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#742086}
-
Ian Struiksma authored
In http://crrev.com/c/2041592 class variable 'element_' was sent in FindFormAndFieldForFormControlElement method call when previously it had been function variable 'element'. This sends it as it had before. Bug: 957444 Change-Id: I5a985ae59b678ac47bc9c038c9fd8d33814fc3fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057539 Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#742085}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8f1ba5bf1dbb..e22500101fbd git log 8f1ba5bf1dbb..e22500101fbd --date=short --first-parent --format='%ad %ae %s' 2020-02-18 khamu@microsoft.com High contrast update for Network panels Created with: gclient setdep -r src/third_party/devtools-frontend/src@e22500101fbd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1048378 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie73f8c73d673522a45c3eba57e657717177554d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061381Reviewed-by:
-
Fredrik Söderquist authored
This replaces the LayoutObject* in SVGFilterGraphNodeMap's mapping from "filter primitive" -> "filter effect" with a weak reference to the SVGFilterPrimitiveStandardAttributes. This avoids the step through the (basically unused) LayoutObject as well as keeping a raw pointer reference in the node map. Bug: 109224 Change-Id: Ic2874013d3986d9a0a108e4e790590a65988ba15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060075Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#742083}
-
Jason Lin authored
... instead of the cancel button. Bug: 1016195 Change-Id: I018874940dbfb72e6c99e6fedc7c8222866db4ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059619 Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by:
Julian Watson <juwa@google.com> Reviewed-by:
David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#742082}
-
Marijn Kruisselbrink authored
This is the last in a series of CLs to enable storing native file system handles in IndexedDB. This adds the plumbing from blink to the browser process, as well as logic in IndexedDBBackingStore to actually serialize handles to disk. Bug: 955193 Change-Id: Ib43e0395d0355cd2ab24eef33168f4e09879f0eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931647Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#742081}
-
Hiroki Nakagawa authored
This reverts commit 1431d28a. Reason for revert: The tests still consistently time out on WebKit Linux Leak. Original change's description: > Reland "Worker: Add data URL tests for nested dedicated workers" > > The original patch was reverted because the tests with worker variant > (nested dedicated workers) consistently timed out on WebKit Linux Leak. > In general, nested dedicated workers are slow, and also WebKit Linux > Leak is slow. Probably this is the reason why the tests consistently > timed out. > > To mitigate it, this patch adds timeout=long in the WPT's META line in > addition to the original patch. > > For sheriff: If the tests still time out on WebKit Linux Leak, feel free > to revert this patch again. In that case, I'll attempt to separate the > tests into multiple files. > > Original change's description: > > Revert "Worker: Add data URL tests for nested dedicated workers" > > > > This reverts commit 1d73a2eb. > > > > Reason for revert: Worker variant of tests appears to consistently timeout on WebKit Linux Leak (crbug.com/1052322) > > > > Original change's description: > > > Worker: Add data URL tests for nested dedicated workers > > > > > > This CL renames data-url.html to data-url.any.js in order to run the > > > tests on a dedicated worker. Previously these tests only ran on window. > > > > > > Bug: n/a > > > Change-Id: I4be0cfdddc01fa4865763868c4947ea63e62d491 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054656 > > > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > > > Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#741367} > > > > TBR=nhiroki@chromium.org,shimazu@chromium.org > > > > Change-Id: I00481f9a51c672b4041364674d0bcad00d959c63 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: n/a > > Bug: 1052322 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057046 > > Reviewed-by: Stephen McGruer <smcgruer@chromium.org> > > Commit-Queue: Stephen McGruer <smcgruer@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#741417} > > Bug: 1052322 > Change-Id: I348ba1743f58a6f0fedf2b739a1cb6a574af6f2f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060356 > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742050} TBR=nhiroki@chromium.org,shimazu@chromium.org Change-Id: I09412305ad6d2093ffb6c489774552eb0bd58f3b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1052322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061577Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#742080}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ba88b74030e4..83f5cce214ee git log ba88b74030e4..83f5cce214ee --date=short --first-parent --format='%ad %ae %s' 2020-02-18 dberris@chromium.org Dashboard: Add test with custom anomaly config Created with: gclient setdep -r src/third_party/catapult@83f5cce214ee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1044760 Tbr: wenbinzhang@google.com Change-Id: I379407cc74b4ad168978530363153b19e1f853f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061122Reviewed-by:
-
Frank Li authored
This CL contains MediaFoundationSourceWrapper and related files. Explainer: https://docs.microsoft.com/en-us/windows/win32/medfound/protected-media-path Design Doc: https://docs.google.com/document/d/1kXMdmfsSKU3tcwTxG-wFU-MaEA6sN3by45PCGBV8zJU Bug: 999747 Change-Id: Ie75371525808c86e2cf6fbd35771c1f4cd6bfca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004066 Commit-Queue: Frank Li <frankli@microsoft.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#742078}
-
Noel Gordon authored
Orientations of 5 or more flip the image width/height on render, while our returned EXIF IFD data does not: https://crbug.com/1039141#c9 Fix that: flip the EXIF IFD metadata width/height if needed. Tbr: lucmult Bug: 1039141 Change-Id: Icfaece4bedc49b2ab6870a763cea21939b384c3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060442Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#742077}
-
Alexey Baskakov authored
The new WebAppMigrationManager is responsible for any migration-related code. WebAppMigrationManager::StartDatabaseMigration performs the offline migration of all bookmark apps to new web apps registry. We do the offline migration only once, before the initial sync. Any additional apps arriving after the initial sync should be installed via WebAppSyncBridge::CommitUpdate() "as if" a user installs them. This will be explained in go/chrome-bmo-migration doc and implemented as a follow up CL. WebAppMigrationManagerBrowserTest demonstrates some new techniques on how to write integration tests: - PRE test and content::IsPreTest(). - URLLoaderInterceptor instead of EmbeddedTestServer. More tests and test/data/ will follow: - DatabaseMigration_FullManifest and manifest_full_data.json. - A set of apps to test the queue. Bug: 1020037 Change-Id: I0038d321932a72deeb00fd21cd3171f1b8ee0fcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014340 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#742076}
-
Noel Gordon authored
Add 32px files-ng-only <cr-button> centered in the splitter bar. The design did not say where to place it, so make it centered. Add style being careful that the splitter bar and the splitter button both behave like buttons and can both activate dragging. For example, --hover-bg-color, :hover, :active etc need quite fine control so that button color matches regardless of which element started the drag. Bug: 1002790, 992819 Change-Id: I99edc231f49bed97b1b29e012f50af5ca7d0080a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060225Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9dbb98007b7b..4bdd08e3ef7e git log 9dbb98007b7b..4bdd08e3ef7e --date=short --first-parent --format='%ad %ae %s' 2020-02-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 2dd40d7fa75c..c8676d4ba37d (10 commits) Created with: gclient setdep -r src/third_party/skia@4bdd08e3ef7e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I0e747b89a0132eb7ae4279883ea88e84566385da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061121Reviewed-by:
-
Toni Barzic authored
Bug:1050544 TBR=tommycli@chromium.org (LGTM given on the cl, but missed +1) Change-Id: I53c0eae00f0cf080e9123e0b7849da67f6f9fde2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049083 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#742073}
-
Kent Tamura authored
Make |Event| arguments of the following functions |const|: - Node::DispatchSimulatedClick() - HTMLFormElement::SubmitImplicitly() - HTMLFormElement::PrepareForSubmission() - HTMLFormElement::ScheduleFormSubmission() - SelectType::DefaultEventHandler() This CL has no behavior changes. Change-Id: I91c233a6dead779f771ddeea357bad3f91a145f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060214Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#742072}
-
Wei-Han Chen authored
hardware_verifier is a new service on Chromebook. This CL declares the metrics we want to track for this service. BUG=b:147654337 TEST=None Cq-Depend: chromium:2049010, chromium:2000275, chromium:2000534 Change-Id: Iaadacc4425ff1257d3e6961e2108a181f8f95d51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011582 Commit-Queue: Wei-Han Chen <stimim@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#742071}
-
Keishi Hattori authored
There is no more users for LifecycleObserver and LifecycleNotifier so this CL removes them. Bug: 1052319 Change-Id: I1cd9a45867d66247add3ba53b69cd964cd3a630c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060428 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#742070}
-
Yutaka Hirano authored
Bug: 1051439, 876671 Change-Id: Ie6055aa48fc27293a89fd20d4273654553fe85cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060362Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#742069}
-
Kent Tamura authored
LayoutListBox provided * Intrinsic height, and * Adjustment of minimum width. For the former, this CL folds it into LayoutBlock and NGBlockNode because it's small. For the latter, this CL moves it to LayoutBox, and ClampIntrinsicBlockSize(), NGLayoutInputNode::ComputeMinMaxSize(), and LayoutBox::ComputeLogicalHeight() call it because the code size is not small. This CL has no behavior changes. Bug: 1040828, 1040826 Change-Id: I9dd95c0971928a50895c32fa977668421078e780 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053648 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Wez authored
It is possible for a network interface to have only IPv6 addresses, but NetInterfaceToNetworkInterfaces() was assuming that the non-optional |addr| field in the fuchsia.netstack.NetInterface would always contain a valid address, resulting in a net::NetworkInterface with INADDR_ANY being returned in the interfaces list. Fix the call to omit the IPv4 NetworkInterface if the |address| IsZero(). Bug: 1052410 Change-Id: I66dc50fcac4911416399210558484130fbfe571c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060072 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#742067}
-
David Staessens authored
When loading test images, we try to resolve the file to an absolute path. Unfortunately when the path doesn't exist this will result in an empty path, causing error messages to be printed without the file name. The CL makes sure the file name is properly printed in error messages. This CL also improves the logic when resolving file paths, to check whether the path is absolute, relative to the current path, or relative to the default test data path. TEST=./image_processor_test on hana BUG=None Change-Id: I8765174e87b25664abc56a2ec3f4ddf4141e60a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035496 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#742066}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/720d39c018b9..2f8af01a92a0 Created with: gclient setdep -r src-internal@2f8af01a92a0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I159dcfdabfd28d934e5690a37ed649b247eb596f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061116Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742065}
-
David Staessens authored
This CL contains some minor cleanup in the video decoder tests: - Update an outdated comment. - Remove a duplicate define that's already defined in macros.h. - Improved debug output when waiting for events. - Moved some initialization to header file. TEST=./video_decode_accelerator_tests on nocturne BUG=None Change-Id: Id0794cff6036396e46e293077663b62bba0b3560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032464Reviewed-by:
-
Omer Katz authored
Change-Id: I0235e805063ee1c89cb6f558a2454b3d2ca24177 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059973Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
-
Hirokazu Honda authored
This fixes the access out of bounds in VaapiDmabufVideoFrameMapper. The class creates VideoFrames by VideoFrame::WrapExternalYuvDataWithLayout(). It needs three plane's addresses. However, the class creates an array whose size is two. It causes the issue when accessing the third element in the array. Bug: 1020776 Test: VDA tests resolution_change_500frames.vp9.ivf one hour w/o --use_vd Change-Id: I50910e564076916193f0e1b366f8ec165945c71d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060226Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#742062}
-
Alice Wang authored
This CL removes the SigninTest since it is all refactored and reimplemented in SigninSignoutIntegrationTest. Bug: 1038326 Change-Id: I56c0097be1ffd10feea7d5fec9b30d00281730bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056843Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#742061}
-
Hirokazu Honda authored
crrev.com/c/2050417 changes VaapiVDA so that it calls DismissPictureBuffer() on destruction. TestVdaVD checks that their picture buffer map contains the picture buffer id passed on DismissPictureBuffer(). TestVdaVD destroys VDA after clearing the picture buffer map, so that the check is triggered thanks to crrev.com/c/2050417. This fixes the problem by destroying VDA before dropping PictureBuffers map. This follows the logic of VdaVD [1] that vda is destroyed before DismissAllPictureBuffers() is executed. [1] https://source.chromium.org/chromium/chromium/src/+/master:media/gpu/ipc/service/vda_video_decoder.cc;l=187;drc=32948393c49aa75df8fec57714e8098f2af8a1e3 Bug: 1051107 Test: video.DecodeAccel.* on eve Change-Id: I61a9e5777dac9452c9bf6c2c73143c749b3448ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060223 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
-
Anand K. Mistry authored
This is logically a SmbUrl, and needs to be in the 'smb://' form which SmbUrl provides. Bug: 939235 Change-Id: I0b8cc2994348b3a5afe87ef3988e67223823cafd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060222Reviewed-by:
Austin Tankiang <austinct@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#742059}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/015cb80815b8..2e0661d7dd4e git log 015cb80815b8..2e0661d7dd4e --date=short --first-parent --format='%ad %ae %s' 2020-02-18 cnorthrop@google.com Vulkan: Update ES 3.1 test expectations 2020-02-18 xinghua.cao@intel.com Unlimit texture size on relatively new linux Created with: gclient setdep -r src/third_party/angle@2e0661d7dd4e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: I3f940c23c08a72a0321c950fe55130a97a4a34ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061118Reviewed-by:
-
Yuzu Saijo authored
Bug: 1040318 Change-Id: I83b03a8bbcb1d39a95cc656dfddc8631867e2397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990884Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
Alan Cutter authored
This CL updates SiteSettingsHandler to use GetAppScope() instead of GetAppScopeInternal(). This means it will include web apps that have no scope and instead use their default scope. This CL removes a behavioural difference between web apps installed via promotion and those installed via "create shortcut". As an extra this CL cleans up some of the naming and types of GetInstalledApps() to better reflect the usage. Bug: 910016 Change-Id: I1eae6c496c717ee8a5ca611d3131d2ebff6bf788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050221Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#742056}
-
En-Shuo Hsu authored
Add HfpBatteryListener that listens to the BluetoothBatteryChanged D-Bus signal and then set the battery percentage to the corresponding device. Design doc: go/cros-bt-bi-hfp BUG=chromium:785758,b:140783217 TEST=Build chrome ash_unittests and run ash_unittests Connect Bose QC35 and verify the battery level is shown on the UI. Change-Id: I476138eb86fee14e2754b5071f3d6ce04d340c97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049587Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 07ac944f. With Chromium commits locally applied on WPT: acd8a467 "SharedWorker: Use CSP headers to outside settings" ec83d167 "Update performance.measureMemory to the latest proposal" d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: If6661f6bd60dac0da28e447eae17e183fe9423e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061488Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742054}
-
Rachel Sugrono authored
The background of the files-ng metadata-box is no longer see-through, use opacity 1. Change-Id: I6d26d4f2e8368b866e682e84a0a91a3af84ffc27 Bug: 992824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061572 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Rachel Sugrono authored
Add style rule changes for the separator for files-ng. Change-Id: Ib43b46bbdeef1489d64b72b2ae9377a90fc9facd Bug: 992824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060438 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Greg Thompson authored
Don't do work within the expression side of LOG_IF macros, as it isn't evaluated when logging is not enabled at the desired log level. BUG=1023080 R=ganesh@chromium.org Change-Id: I4a510eca6fe08e160d8ecd3cbaec8637b89dab2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059014 Commit-Queue: Greg Thompson <grt@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
S. Ganesh <ganesh@chromium.org> Cr-Commit-Position: refs/heads/master@{#742051}
-
Hiroki Nakagawa authored
The original patch was reverted because the tests with worker variant (nested dedicated workers) consistently timed out on WebKit Linux Leak. In general, nested dedicated workers are slow, and also WebKit Linux Leak is slow. Probably this is the reason why the tests consistently timed out. To mitigate it, this patch adds timeout=long in the WPT's META line in addition to the original patch. For sheriff: If the tests still time out on WebKit Linux Leak, feel free to revert this patch again. In that case, I'll attempt to separate the tests into multiple files. Original change's description: > Revert "Worker: Add data URL tests for nested dedicated workers" > > This reverts commit 1d73a2eb. > > Reason for revert: Worker variant of tests appears to consistently timeout on WebKit Linux Leak (crbug.com/1052322) > > Original change's description: > > Worker: Add data URL tests for nested dedicated workers > > > > This CL renames data-url.html to data-url.any.js in order to run the > > tests on a dedicated worker. Previously these tests only ran on window. > > > > Bug: n/a > > Change-Id: I4be0cfdddc01fa4865763868c4947ea63e62d491 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054656 > > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > > Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#741367} > > TBR=nhiroki@chromium.org,shimazu@chromium.org > > Change-Id: I00481f9a51c672b4041364674d0bcad00d959c63 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: n/a > Bug: 1052322 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057046 > Reviewed-by: Stephen McGruer <smcgruer@chromium.org> > Commit-Queue: Stephen McGruer <smcgruer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#741417} Bug: 1052322 Change-Id: I348ba1743f58a6f0fedf2b739a1cb6a574af6f2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060356Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#742050}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/539ac2af50bd..ba88b74030e4 git log 539ac2af50bd..ba88b74030e4 --date=short --first-parent --format='%ad %ae %s' 2020-02-18 abennetts@google.com Rename parent_test → test_path, add master & bot columns. Created with: gclient setdep -r src/third_party/catapult@ba88b74030e4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1019944 Tbr: wenbinzhang@google.com Change-Id: I9bb8d6e4e9bc4cae97e1e3cc2228a74f67df0f73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061115Reviewed-by:
-
