- 20 May, 2020 40 commits
-
-
Dominique Fauteux-Chapleau authored
This reuses tests by having the policy setters of DeepScanningBrowserTestBase set either legacy or Connector policies, and then making every upload browsertest parametrized with a bool so both policy sets get tested. The DeepScanningDialogViews test also change a bit, the ScanType test parameter is removed since this dialog doesn't depend on the type of scanning being done. This avoids having a very large number of combinations for that test that don't cover different code paths. Bug: 1076083 Change-Id: I419b21de0095add8b5b214993be010d022941202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210782Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#770745}
-
Adrian Taylor authored
On Android and iOS platforms, we do not currently pin TLS connections, so verifying Variations payloads is important to ensure that the data has not been tampered with in transit from Google to the device. Such verification of these payloads on mobile devices previously added 25ms to process startup; modern mobile devices are much quicker and we do not anticipate such an impact but we will assess on the perf bots. Unfortunately we can't delete the SignatureVerificationEnabled() call entirely because it's still needed in order to disable signature verification for unit tests. This would be hard to solve because unit tests would need to simulate the real signing procedure of the variations servers, using their private key. This may be worth further investigation in future (e.g. using a different key pair for unit tests) as it would allow removal of quite a bit of production code. Change-Id: I9cb89750e100bf7204140920583db8bd0fa0f41a Bug: 1078056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181564 Commit-Queue: Adrian Taylor <adetaylor@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#770744}
-
Bo Liu authored
Webview tests does not run on the cq L bot, and these tests are flaky on the non-cq L bot because the trick to remove the reference from InputMethodManager does not appear to work on L. It's fine as long as there is some cq bot running these tests, so just disable them on L. Bug: 1085101 Change-Id: Iedff862ca0d6ee53b62879ac1e6f688fbc1d4123 Tbr: torne@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210787Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#770743}
-
Ken Rockot authored
I've left myself in OWNERS of some specific device APIs just to share the load with other owners there, but it seems like there is diminishing value in having me own the broader extensions/ dir given my waning familiarity with the system. Bug: None Change-Id: I502d6ae4f61ba9b5cadf1bdc083b53d6160b9891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210624 Auto-Submit: Ken Rockot <rockot@google.com> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#770742}
-
Bettina authored
Increasing the deadline for this metric as we are making changes to CSD model so want to keep the metric for regression sake. Bug: 1072672 Change-Id: I8ea89a9a1b280ee6deb81374d62c3dd57dfabc79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207956Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Auto-Submit: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#770741}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: cr-fuchsia+bot@chromium.org Change-Id: I7d8cbfcebb1d9fe51601e36dd95df13bace71aad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210650Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770740}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/49de1031d4d8..c5eb5c7127b2 2020-05-20 herb@google.com Cleanup text vertex structs 2020-05-20 robertphillips@google.com Update GrVkRenderTarget to store both stencil & non-stencil render passes (for real) 2020-05-20 johnstiles@google.com Add workaround 'fDisallowDirectRG8ReadPixels' for Radeon Pro 5000 GPUs. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: Iee1480cc080d48e033d7d7dbe3d648d522e4b977 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210665Reviewed-by:
-
Dave Tapuska authored
With Frame, Widget and Synchronous mojom definitions no longer dependent on content types it can now move into blink. Eventually the implementation will move as well. BUG=1073560 Change-Id: I1c567c3a7f1a8eb1e9d2567b4eee71d3b81de38d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204308 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#770738}
-
Xianzhu Wang authored
Remove the extra baseline that was produced when the test flakily failed. The flakiness has been fixed by another CL. TBR=clamy@chromium.org Bug: 1084448 Change-Id: Ic7d01deeea6d0ca3511f572808d2e16ec6237550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210622Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#770737}
-
Eric Willigers authored
The Blink flag UseWindowsSystemColors has been stable since 2019-10. Bug: 970285 Change-Id: Ifee7d8ad4fcafd30bfd518250e729f2e650d463f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208775Reviewed-by:
Alison Maher <almaher@microsoft.com> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#770736}
-
Siyu An authored
Bug: 1082013 Change-Id: I065d5633e51d0f4435f5d9d94fdafa8cd5860a26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209636 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#770735}
-
Chris Letnick authored
To support tracing, a tracing service must also be registered with the mojo broker. This change does not implement start-up tracing which may be addressed at a later time. If (GN arg) enable_external_mojo_tracing=false (default), then a no-op tracing client implementation will be used. Bug: internal b/153566474 Test: Tested tracing with an external tracing service. Change-Id: I56ccecde888778a3f9a54353bb3e6744fb8194c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200081Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Chris Letnick <cletnick@google.com> Cr-Commit-Position: refs/heads/master@{#770734}
-
Jesse Schettler authored
Bug: chromium:1084697 Change-Id: I75a5c25392f13d5ebfa9b74df6597c17964a0cd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209245 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#770733}
-
Francois Doray authored
This enables foregrounding the video capture service in testing config, in preparation for experimenting on Beta. This is a performance optimization which does not change functionality. Bug: 1066137 Change-Id: If48edced330986353af400cd83144dc9b64ab2f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210625Reviewed-by:
-
Tao Bai authored
Implemented ExtractAllDatalist where WebView needs This feature will be enabled for WebView and WebLayer. Bug: 949555 Change-Id: I85478405e7cedd679d31072753b1455c1b843eda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203413 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
-
Scott Violet authored
This needs to handle the case of a WebContents that isn't associated with a Tab. This also renames |controller| to |tab|, which better reflects the type. BUG=none TEST=none Change-Id: Idbf58316d3223e00e28f2d7c675e125c30ecaecf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210499Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#770730}
-
Nathan Zabriskie authored
This patch unifies CPU VideoFrame uploading/conversion code for OOPR and GPU rasterization. Now clients can call ConvertFromVideoFrameYUV with CPU backed VideoFrames in addition to wrapped frames. Bug: 1058992 Change-Id: I89c37179b12fe1375fa7a6f7d919f135f77b5857 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200084 Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#770729}
-
Jarryd authored
Extend the expiry by one year so that we can continue to monitor this metric as more applications make use of non-trivial amounts of storage. Bug: 1077795 Change-Id: Ifd3b41cc84b3f4f02d63ba6a3ba843581312887e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207756 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#770728}
-
Allen Bauer authored
NotificationMenuView Bug: 1044687 Change-Id: I8590a954b5d0b14075dd60f0f6db8576955c0aa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209900Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#770727}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/704fb55255c8..3a5742c880b4 2020-05-20 tommi@webrtc.org Add thread/sequence checks to ModuleRtpRtcpImpl. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I410fe76663742869cca4612beccf757ee6a60e34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210644Reviewed-by:
-
wutao authored
This cl adds an autotest private API which can be used by a follow up cl to add tast test to measure the photo transition animation perf. This API will wait to run several photo transition animations. Bug: b/156854495 Test: new unittests Change-Id: Icc9d9ab6e83657e160c6228d1702237ac9eba56e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163146Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#770725}
-
Xing Liu authored
This CL adds the network connection type metrics when starting a new download or finishing a download. TBR=holte@chromium.org Bug: 1078575 Change-Id: I4b9d3a2e157103a2ebeb24093cd07545a5c41b25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204971 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#770724}
-
Roger Tawa authored
This reverts commit 7ea27f69. Reason for revert: It was decided that service provider configs will not be configurable for GA, so removing code that will not be used at all. Once we decide to make them configurable this CL can be relanded. Original change's description: > Implement enterprise connectors service provider configs component. > > Bug: 1069037 > Change-Id: I4ee05cab27491d59807230a79af5983cd31e366a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187000 > Commit-Queue: Roger Tawa <rogerta@chromium.org> > Reviewed-by: Tim Volodine <timvolodine@chromium.org> > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > Cr-Commit-Position: refs/heads/master@{#767774} TBR=rogerta@chromium.org,timvolodine@chromium.org,waffles@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1069037 Change-Id: I5213fbaf0a72346c97dea188b7284270b0925322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210726Reviewed-by:
-
David Bertoni authored
ExtensionSessionsTest.RestoreForeignSessionWindow was disabled for flakiness in 2013. It passed 3000 iterations on the bots on all tested platforms. Bug: 278372 Change-Id: Ie327d517473f8858140678dd0622703737691155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209305Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#770722}
-
Joe Downing authored
This crash is occurring when the user clicks 'stop sharing' on the remote session. The website will send a disconnect message which cleans up the It2Me host and friends. The website will then create a new instance of the native message host (which it uses to determine if the host is installed). Soon after this, the host website receives a session-terminate message from the client. It helpfully sends this to the It2Me host. Since signaling is not connected for the new host instance, it tries to run the incoming_message_callback_ (which is invalid) and crashes. This CL adds a check around incoming_message_callback_ to ensure it is valid before calling it (as well as some logging to indicate the condition occurred). It's possible that we could address this issue in the client w/o requiring a host fix but I think it is a good idea to handle this scenario in case it is too difficult to fix client-side or a regression sneaks in later. Bug: 1084670 Change-Id: I3714fc860339b12cfcab688652e5e8a83118a4f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210732Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#770721}
-
Sammie Quon authored
This crashes now with async window state changing ARC apps. Since DCHECK, remove. Also WindowState::Unminimze is pretty stable. Test: none Change-Id: I1786fe81a36e73b3c94b9fd4c40bcf7f64f93a51 Fixed: 1067240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210727 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#770720}
-
Frank Liberato authored
InitializeDecoder would notify the host about errors if creating either the d3d9 or d3d11 device manager failed. They should just fail, since these calls happen only during VDA init. NotifyError requires an initialized VDA. Returning false from init is enough. Bug: 1084949 Change-Id: Ifd0522deef076308ba3872d874e49b3f40a75dbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210724 Auto-Submit: Frank Liberato <liberato@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#770719}
-
Bruce Long authored
This change allows Windows spellchecking to be performed on languages that do not have Hunspell dictionary support (Arabic, Finnish, ...), as well as for regional dialects (Swiss German, ...). The browser languages settings page is still limited to adding preferred languages in the hard coded accept languages list |kAcceptLanguageList|, but spellchecking can now be toggled on for languages not in the hard coded Hunspell languages list |kSupportedSpellCheckerLanguages| if a Windows platform language pack is installed that has a dictionary corresponding to the accept language. On initializing the SpellcheckService, the list of Windows spellcheck dictionaries is retrieved asynchronously, and when the task completes the BCP47 tags are mapped to the browser's list of accept languages. If a match is found the language can now be toggled on for spellcheck, will have its dictionary loaded in LoadHunspellDictionaries, will be displayed in the spellcheck section of the context menu for editable content, and will be referenced for spellcheck requests. Some logic needed to be added to account for BCP47 script subtags, since passing just the language subtag can be ambiguous for languages that can be spelled in more than one script, such as Serbian. Note that hybrid Windows spellchecking is still behind a feature flag that is disabled by default. When the feature is enabled by default, a performance issue may be encountered, because in the current implementation it is necessary to instantiate the spellcheck service at browser startup in order for the content editable context menu to include non-Hunspell languages if visited before the language settings page, and for spellchecking to be performed on first visit to editable content. This performance issue is tracked by: https://crbug.com/1064351 Improve spell check initialization performance Bug: 1000443 Change-Id: I4af1f19deb3bee8805df88ecbcfc1bb48dfb92e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155167 Commit-Queue: Bruce Long <brlong@microsoft.com> Reviewed-by:Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
-
Lindsay Pasricha authored
Bug: 1065456 Change-Id: Ib46cf7fcf186a152d7e1f6d1b37ad9c80d546073 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210730 Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#770717}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 989f5582. With Chromium commits locally applied on WPT: f6984fd9 "De-flaky pointerlock/pointerevent_pointermove_in_pointerlock.html" 45436d4d "CookieStore: WPT to verify subscribe/unsubscribe is idempotent" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools rego@igalia.com: external/wpt/css/selectors NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Id96625917cbe58e665c5e33e884900faebf6cfd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208754Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770716}
-
Kyle Horimoto authored
These names are registered via the Hierarchy class; future CLs will use them to add search results for parent subpages. Bug: 1082249, 1071700 Change-Id: I42ab82489b40306e9ce4628cb68c83430be601fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209763Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#770715}
-
Chong Gu authored
Add the refactored target to gpu integration tests on Fuchsia Bug: 1058255 Change-Id: I3eb86a55c42a509221af84840d2ecfe0f26035b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209612Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#770714}
-
Swapnil authored
The browsertests of login test base and all the related tests are moved from policy_browsertests to a separate file. Bug: 1084166 Change-Id: I63c270c7866d64ece3e3397e8914e31fc2b2872a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207217 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#770713}
-
David Grogan authored
ResolveBlockLengthInternal was getting a content_size smaller than border_padding. Some ChromeOS browser tests hit this. There should be no user-visible behavior changes. Bug: 845235 Change-Id: Ie7a732669fcc7c17db02e96250d40eb9c48f92d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207926Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#770712}
-
Fredrik Söderqvist authored
All of these tests are currently flaky because they sometimes render without a video frame. Utilize the requestVideoFrameCallback() API to wait for a video frame callback before deciding that the tests are done. Where needed, make sure that test and ref use the same condition for when the test (and ref) should be considered completed. This appears to reduce the rate at which these tests flake, but not completely eliminate the flakiness. Bug: 988248 Change-Id: Ib999646942ec2b1247da6ec61bd4a80a2e8bfbf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208866Reviewed-by:
srirama chandra sekhar <srirama.m@samsung.com> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#770711}
-
Dana Fried authored
Currently, all clicks outside the WebUI tabstrip are swallowed, but clicking on (for example) the window close button now works whereas previously it was ignored and only closed the WebUI tabstrip. Change-Id: I7852dba7b504eb256bc021bcc020f61de598b408 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209370Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#770710}
-
Nate Fischer authored
This removes support for the log verbosifier app entirely and simplifies some startup code. This removes the verbosifier app's code entirely. Bug: 988200 Test: verify "webview-verbose-logging" still works Change-Id: I21610574763b614c1606be49894aa6fbc9a668b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169826Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#770709}
-
Swapnil authored
The browsertests of certificate transparency policy are moved from policy_browsertests to a separate file. Bug: 1083990 Change-Id: Iab10e4e79335f63cb9d5809bd84fc63d69971078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207313 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
-
Victor Vasiliev authored
This adds histograms for the error codes with which QuicTransport connections are closed, and the state at which they are closed. Bug: 1079080 Change-Id: I62e91fd3b2bc340170238e08759c190fb94c6178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197611Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#770707}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6a935445b316..37c97e9aca20 2020-05-20 bmeurer@chromium.org [formatter_worker] Fix pretty printing of nullish coalescing. 2020-05-20 sigurds@chromium.org Remove unnecessary @unrestricted annotations from front_end/sdk 2020-05-20 sigurds@chromium.org Remove unnecessary @unrestricted annotations from front_end/ui 2020-05-20 bmeurer@chromium.org [wasmparser] Change to `wget` workflow for wasmparser. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1079233 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7f75ce13442f587060f20e512dc2bb42c9f312c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210387Reviewed-by:
-
