GitLab

The ChromeMediaRouterDialogController now reports when the source URN is
not supported so that the native side can reject the PresentationRequest
correctly.
CastMediaRouteProvider now reports no sinks available if the source URN
is not supported or if Android MediaRouter's API are not present (like
on JB MR1). For the latter, we now do create ChromeMRP when MediaRouter
is null and check if it's null before using (was already checked
everywhere, except for one spot changed in this CL).

BUG=706882
TEST=manual at https://googlechrome.github.io/samples/presentation-api/

Review-Url: https://codereview.chromium.org/2783363002
Cr-Commit-Position: refs/heads/master@{#462887}

As part of enrollment, the firmware management parameters (FWMP)
partition from TPM has to be set including the flags to mark if the
devmode is blocked. The update has to be done before the TPM is locked
but after the policy is retrieved.

It is implemented by including additional step in enrollment process
that makes the D-Bus call to cryptohome to set the data in FWMP.

Similarly when the device is deprovisioned, the firmware management
parameters are removed from TPM when it is established that it is a
consumer owned device.

BUG=685144

Review-Url: https://codereview.chromium.org/2727713003
Cr-Commit-Position: refs/heads/master@{#462886}

This argument was optional until r462215.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2804913006
Cr-Commit-Position: refs/heads/master@{#462885}

BUG=564904

Review-Url: https://codereview.chromium.org/2596653002
Cr-Commit-Position: refs/heads/master@{#462884}

See https://w3c.github.io/webappsec-csp/#external-hash

Intent to Implement and Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/t2ai4lsHhWI/MndrZyEWCwAJ

BUG=706380

Review-Url: https://codereview.chromium.org/2784753003
Cr-Commit-Position: refs/heads/master@{#462883}

BUG=none

Review-Url: https://codereview.chromium.org/2792823002
Cr-Commit-Position: refs/heads/master@{#462882}

Blink has been using LayoutUnit(-1) to represent indefinite sizes or more in
general, sizes that cannot be resolved. That's unfortunate because it forces
us to use that magic number and also because negative LayoutUnits are valid
outcomes of some operations.

In our particular case, that was forcing us to check the SizingOperation
argument in the GridTrackSizingAlgorithm to know whether the passed
available and free sizes where actually indefinite or not. Actually that was
not totally correct as this was based on the assumption that we were doing
intrinsic size computations (preferred widths) whenever the sizes where
indefinite which is not correct for all the cases (it's true for widths but
a height:auto grid container would have indefinite height and require
indefinite size computations).

This does not require any additional tests as we are not changing any
behaviour. It's a step forward in the process of decoupling the concepts of
definite/indefinite sizes and intrinsicSize/layout operations.

Review-Url: https://codereview.chromium.org/2808453002
Cr-Commit-Position: refs/heads/master@{#462881}

Adjust the ownership of the instances used by most unit test fixtures.
The test Shell owns CLC as the ShelfDelegate, just like in production.
Fix up test helper functions and remove ProxyShelfDelegate.

Make BrowserWithTestWindowTest::TearDown more like production shutdown.
(first tear down the browser instance, then the Shell, then the profile)
Remove DestroyBrowserAndProfile, inline/recreate similar behavior.

Add a workaround for DefaultApps test teardown crash (crbug.com/709297).

BUG=557406
TEST=Automated tests still pass; more closely match production.
R=jamescook@chromium.org,sky@chromium.org

Review-Url: https://codereview.chromium.org/2804913002
Cr-Commit-Position: refs/heads/master@{#462880}

https://pdfium.googlesource.com/pdfium.git/+log/0e5d892fe86d..03c5e1725be9

$ git log 0e5d892fe..03c5e1725 --date=short --no-merges --format='%ad %ae %s'
2017-04-07 npm Gitignore jinja2 and markupsafe

Created with:
  roll-dep src/third_party/pdfium

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2805243002
Cr-Commit-Position: refs/heads/master@{#462879}

The status bar's color would incorrectly switch when changing tab
models in the tab switcher due to tab's onShow being called. The
tab switcher logic was not handled correctly since the Chrome Home
test existed in ChromeActivity instead of ChromeTabbedActivity;
this change moves that logic.

This change also adds a special case for the incognito NTP, since
that page is completely dark, that status bar should be too.

BUG=708680

Review-Url: https://codereview.chromium.org/2803673003
Cr-Commit-Position: refs/heads/master@{#462878}

Review-Url: https://codereview.chromium.org/2807523003
Cr-Commit-Position: refs/heads/master@{#462877}

1. Update default from 640x480 to 2880x1800. The goal is to use the native
screen resolution as default, but this is an improvement over the current
situation.
2. If a maximum resolution constraint is given, use that as default instead
of the hardcoded default. This makes the algorithm more compatible with
existing applications without breaking compatibility with the spec.

BUG=257097,709345

Review-Url: https://codereview.chromium.org/2806703002
Cr-Commit-Position: refs/heads/master@{#462876}

BUG=706118

Review-Url: https://codereview.chromium.org/2803943006
Cr-Commit-Position: refs/heads/master@{#462875}

If the users taps an offline url that does not match an entry, an error
message should be displayed.

BUG=703393

Review-Url: https://codereview.chromium.org/2800673002
Cr-Commit-Position: refs/heads/master@{#462874}

This CL changes the font of the fallback monogram of the favicons of suggested
articles, making it bigger and medium instead of regular.

BUG=none

Review-Url: https://codereview.chromium.org/2801323002
Cr-Commit-Position: refs/heads/master@{#462873}

Suborigins are supposed to make script from different suborigin
namespaces inaccessible to each other. canAccess (in spec terms
same-origin domain) is supposed to do that, so just fold the two
together

BUG=336894
R=mkwst@chromium.org

Review-Url: https://codereview.chromium.org/2805683005
Cr-Commit-Position: refs/heads/master@{#462872}

The reason for using the thick version of the progress bar was to make
it more visible against a black status bar. With recent Chrome Home
changes, the status bar is a much lighter color making the progress
bar easy to see and eliminating the need for it to be as large. This
change reduces the progress bar size for android M and above since
these versions allow themed status bars.

BUG=708680

Review-Url: https://codereview.chromium.org/2806633002
Cr-Commit-Position: refs/heads/master@{#462871}

These lint picks were noticed in the merge
https://codereview.chromium.org/2801603003/. I am putting the lint picks
into a separate issue because the original issue is big enough as is.

BUG=488484

Review-Url: https://codereview.chromium.org/2799913003
Cr-Commit-Position: refs/heads/master@{#462870}

When the shelf is in autohide, the shelf does not hide after launching from overflow shelf. This is because the overflow shelf remains visible after lauching an app, which this CL fixes.

BUG=625924
TEST=manual,ash_unittests --gtest_filter="ShelfViewTest.*"

Review-Url: https://codereview.chromium.org/2807473003
Cr-Commit-Position: refs/heads/master@{#462869}

- Initialize the URL request context getter on the IO thread.
- Initialize the response type to Default to match a DCHECK.
- Don't double initialize the fetches in BackgroundFetchedEvent

BUG=692579

Review-Url: https://codereview.chromium.org/2806713002
Cr-Commit-Position: refs/heads/master@{#462868}

Revert of Use dropdown list for admin areas in pr form. (patchset #18 id:1000001 of https://codereview.chromium.org/2680143002/ )

Reason for revert:
The patch causes chrome_public_test_apk failing on chromium.android/Marshmallow Tablet Tester: crbug.com/709491.

Original issue's description:
> Use drop-down list for admin areas (state, province, ..)
>
> -- In the payment request form (instead of the previous text-field).
>
> - For this purpose, the rules of the specified country are loaded from
>  the i18n aggregate server, and the country's sub-keys are retrieved from the right rule.
>
> - If the server doesn't respond, or there is a time-out, or if no
>   admin areas are recorded for that country, show text-field.
>
>    -- Add all the fields to the form, only when admin areas are loaded.
>       This way we can have the fields in order. Otherwise, admin areas
>       would show up at the end (since they are fetched asynchronously.)
>
> - In the Payment Request tests, the admin area field would always be a
>   text field (and not a drop down). This way, the tests would be
>   independent of the network connection state.
>
> - Tests were added to the AddressValidatorTest according to the
>   changes.
>
> BUG=675634
>
> Review-Url: https://codereview.chromium.org/2680143002
> Cr-Commit-Position: refs/heads/master@{#462611}
> Committed: https://chromium.googlesource.com/chromium/src/+/69b196d676ecbbb986009aaf9f5627fd6e332de1

TBR=sebsg@chromium.org,mathp@chromium.org,rouslan@chromium.org,dfalcantara@chromium.org,parastoog@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=675634

Review-Url: https://codereview.chromium.org/2800013004
Cr-Commit-Position: refs/heads/master@{#462867}

This method only sets the color for non-disabled states:
https://cs.chromium.org/chromium/src/ios/third_party/material_components_ios/src/components/Buttons/src/MDCButton.h?l=69

BUG=602666

Review-Url: https://codereview.chromium.org/2802033002
Cr-Commit-Position: refs/heads/master@{#462866}

This also applies when the element isn't contained by a multicol container
(which means that we shouldn't require the spanner placeholder to be present).

BUG=709362

Review-Url: https://codereview.chromium.org/2799363003
Cr-Commit-Position: refs/heads/master@{#462865}

Revert of memory-infra: Fill the memory dump callback result (2/2) (patchset #6 id:100001 of https://codereview.chromium.org/2766173003/ )

Reason for revert:
Causing build failure:
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests/builds/54494

Original issue's description:
> memory-infra: Fill the memory dump callback result (2/2)
>
> Fill in the part of the memory dump result struct
> that applies to OS's view of Chrome when finalizing
> a memory dump.
>
> BUG=703184
>
> Review-Url: https://codereview.chromium.org/2766173003
> Cr-Commit-Position: refs/heads/master@{#462849}
> Committed: https://chromium.googlesource.com/chromium/src/+/22fd5f0cf18a409dd72b96cb526a25a6cac88d24

TBR=primiano@chromium.org,fmeawad@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=703184

Review-Url: https://codereview.chromium.org/2806553005
Cr-Commit-Position: refs/heads/master@{#462864}

The timeline width seems to differ. https://crbug.com/709483 tracks
re-enabling these.

BUG=709483
TBR=mlamouri@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2802233002
Cr-Commit-Position: refs/heads/master@{#462863}

The test was previously disabled on Windows. It is flaky also on linux.
This CL disables the test fully.

BUG=600153
TBR=rouslan@chromium.org

Review-Url: https://codereview.chromium.org/2803983003
Cr-Commit-Position: refs/heads/master@{#462862}

Crushed sprite resources and layers were only used for Contextual
Search. CS no longer has a use for a the animated sprite, so this
removes the crushed sprite resources and layers and replaces
the CS use with a static icon.

BUG=707001

Review-Url: https://codereview.chromium.org/2798123002
Cr-Commit-Position: refs/heads/master@{#462861}

This CL cleans up and structures code in SignInPreference.java.
1. Three possible states (signin disabled, not signed in & signed in) of
   SignInPreference are now structured and have dedicated setup functions.
2. Added comment to clarify mViewEnabled magic.
3. Removed hardcoded Android view ids from onBindView.
4. Removed code to change enabled state.

BUG=none

Review-Url: https://codereview.chromium.org/2803753002
Cr-Commit-Position: refs/heads/master@{#462860}

BUG=672468
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2801983003
Cr-Commit-Position: refs/heads/master@{#462859}

This test is flaky (timeouts) in most dbg bots. Disabling.

BUG=709447
TBR=bbudge@chromium.org

Review-Url: https://codereview.chromium.org/2803913005
Cr-Commit-Position: refs/heads/master@{#462858}

All answer text (other than the suggestion text and positive/negative
text) is now the de-emphasizing gray.

BUG=709101

Review-Url: https://codereview.chromium.org/2804143002
Cr-Commit-Position: refs/heads/master@{#462857}

Follow up to http://crrev.com/2795593006, changes Modulator::from/setModulator/clearModulator to take ScriptState* as a parameter instead of LocalFrame*

BUG=682322

Review-Url: https://codereview.chromium.org/2803843002
Cr-Commit-Position: refs/heads/master@{#462856}

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/b9bfcb4..05fb319

$ git log b9bfcb4..05fb319 --date=short --no-merges --format=%ad %ae %s
2017-04-07 peah@webrtc.org Adding support for handling highly reverberant echoes in AEC3.
2017-04-07 peah@webrtc.org Fixing sample-rate dependent band-split filter issues in AEC3

TBR=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
BUG=

Review-Url: https://codereview.chromium.org/2799093005
Cr-Commit-Position: refs/heads/master@{#462855}

Follow-up on https://codereview.chromium.org/2697793004 review comment.

BUG=none

Review-Url: https://codereview.chromium.org/2789123003
Cr-Commit-Position: refs/heads/master@{#462854}

This CL adds SigninAlertDialogTheme style that uses Google Blue 500 color
for button text and forces message text to use Chrome default text color.

BUG=650121,669787

Review-Url: https://codereview.chromium.org/2801213003
Cr-Commit-Position: refs/heads/master@{#462853}

BUG=704791

Review-Url: https://codereview.chromium.org/2779813002
Cr-Commit-Position: refs/heads/master@{#462852}

This test is flaky on Linux as well, and was already disabled on Mac and
Windows.

BUG=680544
TBR=tommycli@chromium.org

Review-Url: https://codereview.chromium.org/2807523004
Cr-Commit-Position: refs/heads/master@{#462851}

We were being too aggressive with our DCHECK(desc->IsObject()). The spec
says (and we even mention it in a comment) that a call to
Object.getOwnPropertyDescriptor can return undefined in addition to a proper
object descriptor.

We were only considering the latter case, and crashing on the DCHECK if we
ever received an undefined descriptor, which can happen when a Proxy is used
in JS.

This is also covered by external/wpt/fetch/api/headers/headers-record.html.

BUG=707365
R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org

Review-Url: https://codereview.chromium.org/2801003005
Cr-Commit-Position: refs/heads/master@{#462850}

Fill in the part of the memory dump result struct
that applies to OS's view of Chrome when finalizing
a memory dump.

BUG=703184

Review-Url: https://codereview.chromium.org/2766173003
Cr-Commit-Position: refs/heads/master@{#462849}

IntRects can be implictly converted to FloatRect so code managed
to call enclosingIntRect on an IntRect which then converted to
FloatRect and back for an expensive noop.

R=mstensho@opera.com
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2805203003
Cr-Commit-Position: refs/heads/master@{#462848}