GitLab

These can simply be owned by the View hierarchy as normal.  However,
doing this requires making command unregistration happen before the view
is removed from the widget.  This is semantically parallel to how
command registration already happens after the view is added to the
widget, so it makes sense, but requires some plumbing.

Finally, does a few small cleanups along the way.

Bug: 1044687
Change-Id: Ie5c6988da179b89b3b63632134d4a4258fffd436
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210902
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771537}

SyncEncryptionHandlerImpl is no longer used in production code. This CL
removes all UMA_HISTOGRAM*() calls from it. Corresponding histograms
are either instrumented in modern codepaths (nigori_sync_bridge_impl.cc,
pending_local_nigori_commit.cc) or marked as obsolete.

Bug: 1083924
Change-Id: Ia77efce35af460a079a26e0cf31e828d13dff4c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209210Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
Cr-Commit-Position: refs/heads/master@{#771536}

This commit moves expire date of the following histograms:
 * Extensions.ContentVerification.ComputeHashesOnInstallTime
 * Extensions.ContentVerification.ComputeHashesOnInstallResult
 * Extensions.CorruptPolicyExtensionDetected3

Bug: 1084094, 1084095
Change-Id: Ic9bb67f5cd4bc3d99075f7030da639b4e9364d2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207227Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Oleg Davydov <burunduk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771535}

Bug: 1070409
Change-Id: Ia7308b7a93552e118225d323084af66122a1340d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212193Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771534}

Bug: 1070409
Change-Id: I40a9b6ccd2d96f4c285119c1cc11fd7f5e57065d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212192Reviewed-by: Tim Schumann <tschumann@chromium.org>
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771533}

This CL adds guard clauses to prevent the use of the manual filling
component before initialization or after its destruction. At this point,
basically every single public method is prefaced with that which means
that we should think of a (long-term) solution that either doesn't even
allow accessing the component until the native initialization finished
or defers the calls to that component.

Bug: 1084196
Change-Id: I9cc17bc34dad666fa542c9be70bc78aee42ec586
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209137
Auto-Submit: Friedrich [CET] <fhorschig@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771532}

Bug: 1070409
Change-Id: Ib26b5d5d9a6ddf20da57c9e11be43de9cfb1d7be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212117Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771531}

Special care had to be taken in order to make border-*-width
properties testable: if the corresponding border style is hidden or
none, the border-width property computes to zero per spec. Therefore
ComputedStyleWithValue is now manually setting the border style to
kSolid.

Bug: 1057072
Change-Id: I9f226cc46a0bcdadf4ad0e8ba0b35d0cbe14ec52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209075
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771530}

The visible URL isn't relevant.

Tbr: arbesser@google.com
Bug: 1081389
Change-Id: Ia51578c7bec93e70d5def3acda9b4f1ffbb3fc23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210680
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771529}

This patch changes "5065910.html" to utilize |selection_test()| and renames to
"typing_style_color.html" for ease of maintenance and help to implementing
EditingNG.

Bug: 707656, 679977
Change-Id: Icb740c1a60e51d874c54ce553c33671b5e22f3de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212195
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771528}

Bug: 1070409
Change-Id: I4e20be0704e7943a93a59e437f4126296c650740
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212232Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771527}

Profile API is being updated (issue 1033903) and the usage of
GetOffTheRecordProfile and HasOffTheRecordProfile without argument is
getting deprecated. Use cases of this call that ONLY refer to incognito
or guest mode can use [Get/Has]PrimaryOTRProfile() instead.

Several tests are updated to use the new API.

This CL does NOT change any behavior.

Bug: 1060940
Change-Id: I632623a7d718a1d56f01853ecabcb3a34823974e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213562Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771526}

BUG=1068884

Change-Id: I33f31eeec0f520f0a135c2c70f56b96d6e42a9ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203787
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771525}

This adds a webtest to check if we can pause execution in a script
compiled using streaming compilation.

Bug: chromium:1079328
Change-Id: I68756c333a0ff69294f5bf210b0a6004412ee774
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202897
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Reviewed-by: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771524}

Without this addition, the interpretation of the current metric is hard
because it is not post-selected on the presence of a valid
ADDRESS_HOME_LINE1 field.

Change-Id: Ibdd9a34a80c702729d6abbd188d4174161026b46
Bug: 1083867
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206653Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Matthias Körber <koerber@google.com>
Cr-Commit-Position: refs/heads/master@{#771523}

This is a follow up CL of
https://chromium-review.googlesource.com/c/chromium/src/+/2161072 in
which it was recommended to convert the |expected_version| member
variable from std::string to base::Version.

Bug: 1076376
Change-Id: Iaf49b0374aedbe47127e6c794204adc99853f3ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207216Reviewed-by: Oleg Davydov <burunduk@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Saurabh Nijhara <snijhara@google.com>
Cr-Commit-Position: refs/heads/master@{#771522}

TBR=benmason@chromium.org

Change-Id: I9728063d5b8144d5bef557580d3a97438995ac6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214921
Commit-Queue: Krishna Govind <govind@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771521}

This reverts commit 769719f1.

Reason for revert: Suspect of breaking win-archive-rel: https://ci.chromium.org/p/chromium/builders/ci/win-archive-rel/14224?

Original change's description:
> Adding mojolpm fuzzer generators.
> 
> This adds code that generates libprotobuf-mutator based
> structure-aware fuzzers as part of the mojom compilation process.
> (changes in //mojo).
> 
> This is a cherrypick/split from
> https://chromium-review.googlesource.com/c/chromium/src/+/2108507
> 
> Pragmatic fixes for the remaining missing dependencies.
> 
> Change-Id: I0e0d34a4b99b31f99ee872fb95be993043aef402
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170830
> Commit-Queue: Mark Brand <markbrand@google.com>
> Reviewed-by: Ken Rockot <rockot@google.com>
> Cr-Commit-Position: refs/heads/master@{#771513}

TBR=rockot@google.com,markbrand@google.com

Change-Id: I15ea11fbc72b9e2a804ca8c49be12f89d4c465a2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213566Reviewed-by: Marina Ciocea <marinaciocea@chromium.org>
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771520}

Roll Chrome Mac PGO profile from chrome-mac-master-1590378757-0e86ea9817fe6c644c14c0cd7e1701a48ebcda53.profdata to chrome-mac-master-1590392885-f817e2f6c6f861a55dc86221cdd5b022c49b4b4c.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:mac-chrome
Tbr: jeffyoon@google.com,liaoyuke@google.com
Change-Id: I364be619f6aa2009ae25085338fdbb80a2f00c84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214983Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#771519}

Everything that accesses SVGAnimatedEnumeration<Enum> will read the
current enum value, so cut directly to the chase instead and drop the
unnecessary CurrentValue/BaseValue overloads.

Change-Id: Ib7b56ae106ca6531e461e3b47973782112860ee1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207450Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#771518}

Changing the buffer size when streams are active appears unsafe, so
avoid increasing it. Future stream creation will still use a lower
buffer size where possible. I'd expect this use case to be rare.

R=henrika

Bug: 880261
Test: None.
Change-Id: I5fb857da5ae31b3d90df90dd784f90c9511264e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208295
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Henrik Andreasson <henrika@chromium.org>
Reviewed-by: Henrik Andreasson <henrika@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771517}

This is the final missing piece for bug 1053768, which is about adding
support for named pages and page orientation, so that an author can
specify that certain pages should be rotated clockwise or
counter-clockwise, without affecting layout. The effect of the rotation
will only be observable in print preview, and when saving the paginated
layout to file (typically PDF).

The page-orientation descriptor is defined here:
https://drafts.csswg.org/css-page-3/#page-orientation-prop

Test: third_party/blink/web_tests/printing/page-orientation.html
Bug: 1053768
Change-Id: I7f7b67b322592c1e90305c88a2088a567247b044
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206633
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Daniel Hosseinian <dhoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771516}

Profile API is being updated (issue 1033903) and the usage of
GetOffTheRecordProfile and HasOffTheRecordProfile without argument is
getting deprecated.

The use of the function in c/b/profiles tests is updated.

Bug: 1060940
Change-Id: I168e48fac82eec6dc968a15818412c5eceaeb352
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213564Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771515}

A callback code may call Write() on `this` database immediately in the
callback.

Since previous fix was reverted,
https://chromium-review.googlesource.com/c/chromium/src/+/2213648
let's start with a more simple synchronous fix.

We will investigate that test on Mac separately.

TBR=ericwilligers@chromium.org

Bug: 1084939
Change-Id: I6561789f226384e724940bc9bf024d6969c719ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213650Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771514}

This adds code that generates libprotobuf-mutator based
structure-aware fuzzers as part of the mojom compilation process.
(changes in //mojo).

This is a cherrypick/split from
https://chromium-review.googlesource.com/c/chromium/src/+/2108507

Pragmatic fixes for the remaining missing dependencies.

Change-Id: I0e0d34a4b99b31f99ee872fb95be993043aef402
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170830
Commit-Queue: Mark Brand <markbrand@google.com>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#771513}

It flaked on Mac due to slightly more than 0.01% of pixels in the
page already having the focus highlight color.

I updated the numbers to be more robust, with more margin for
deviations that will still allow it to pass. By making the
input element taller, that means more pixels get the focus
highlight color.

Bug: 1083806, 1021939
Change-Id: I34787ab08eedaaba9dde2cc960b0ab948e711a3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209683
Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Chris Hall <chrishall@chromium.org>
Commit-Queue: Chris Hall <chrishall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771512}

Bug: 1057072
Change-Id: I3323687393ac07a05cc14f39b3076e66d8ba49d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207169
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771511}

NotifyOnAllAppWindowsClosed API should not cause notifications
before Start or after Shutdown.

Bug: 1084939
Change-Id: I18b1299bd0cc1115a7024bd6ac8fc37a02a3e30a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214459Reviewed-by: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771510}

Bug: 839389
Change-Id: Ifbdfc9b74eda975d5ef1547d07dfe1999cd64e96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212228Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771509}

Some IDL dictionaries have to receive v8::Isolate to instantiate
ScriptValue type members with null default values.
This CL defines constructors and Create methods to accept v8::Isolate
to make them consistent, and disabled default constructors and Create()
for dictionaries which need an isolate.


Bug: 839389, 1070964
Change-Id: I5ea2533b5987af707a354b58151a343b5dea1e6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203244Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771508}

https://skia.googlesource.com/skia.git/+log/340fee5c8499..ebf28a80ca38

2020-05-25 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps
2020-05-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 96a80283cc0f to c746ac65e9d6 (5 revisions)
2020-05-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from f1735ff5 to 10bf4a61 (177 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC westont@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: westont@google.com
Change-Id: Ib573fff781c8803db4062f4043937bad0ac580b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214696Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#771507}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7ca48df80a7b..471dd7ffcd7e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC yhirano@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: yhirano@google.com
Change-Id: I3446daaab419f3db68b94b48c670275728162622
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214692Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#771506}

Bug: 1049453
Change-Id: I9df2aa516105e8f4aa230c4f9f62f9002bda8f65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208801
Commit-Queue: Julian Watson <juwa@google.com>
Auto-Submit: Julian Watson <juwa@google.com>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771505}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/af8825a827c4..3b84585447f1

2020-05-25 bmeurer@chromium.org [wasmparser] Update wasmparser to 0.14.1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ifba3135c9c7a6bda9177dea0e56e28568e480ff9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214697Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#771504}

Currently, chrome deals with powerwash after an update (e.g. on channel
downgrade) itself, from computing whether it should happen, to actually
issuing a powerwash which is never executed because the update engine
takes care of it.

After this change and the corresponding changes in the update engine,
chrome will rely on the update engine sending a flag indicating whether
a powerwash will happen after the update.

The system notifications will be addressed in a separate CL because
adapting the code there also requires properly dealing with the
rollback flag.

Depends on https://crrev.com/c/2187672

Bug: 2187671
Change-Id: I2aa7024fb7978c21e6396e366f9876d42a72e873
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187635
Commit-Queue: Miriam Polzer <mpolzer@google.com>
Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771503}

CL:2210194 updated <cr-toast> own deps, so no need our files app BUILD
to interpolate <cr-toast> internal deps anymore. Remove the TODO.

Tbr: adanilo
Bug: 1002391,1033660
Change-Id: I50022f87ba14843a4e46b8c0088e7d7d922143a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213649Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771502}

This CL sets up the MVP version of settings result ranking. We:

 - Show at most two results
 - Which are glued to the top of the launcher
 - But show no results for single-character queries.

To avoid confusion, I've removed the max results constant from the
search controller factory, and replaced it with a 'generic max results'
version. This generic version is necessary for now because a value for
max results is mandatory, but we're moving away from needing it.

Bug: 1068851
Change-Id: I188324413dd120d6f8abbf1b0a8791d4fcaac0d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214583
Commit-Queue: Tony Yeoman <tby@chromium.org>
Reviewed-by: Thanh Nguyen <thanhdng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771501}

SingleClientStandaloneTransportSyncTest needs to include WEB_APPS in
its list of OS transport-mode types.

sync_integration_tests --enable-features=SplitSettingsSync passes
after this change.

This CL is in preparation to turn SplitSettingsSync on by default.

Bug: 1060289
Change-Id: I7662ba9a4ac529db18ba8887eeebe6f4023a53f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211044
Commit-Queue: Marc Treib <treib@chromium.org>
Auto-Submit: James Cook <jamescook@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771500}

This patch adds |WritingMode| and |TextDirection| as members
of |NGFragmentItemsBuilder|.

The current code has problems if different |WritingMode| and
|TextDirection| are given to, say, |Items| and
|ToFragmentItems|. Giving them at the constructor can avoid
such inconsistencies.

This also allows delaying construction of |NGFragmentItem|,
which is part of the performance work.

Bug: 982194
Change-Id: If49c41d7ad0d65ac083d8fc58793128d2ed28616
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212229Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771499}

This patch gets rid of useless "highlight.html" and expected images for ease of
maintenance and help to implementing EditingNG.

"highlight.html" was introduced for testing "-webkit-highlight" CSS property
but this property is no longer used. This property is parsed and store in
|ComputedStyle| but layout and paint don't refer it.

Note: WebKit removed "-webkit-highlight" on 2014[1].

[1] https://bugs.webkit.org/show_bug.cgi?id=128456

Bug: 707656, 1086089
Change-Id: I945221634e0176123aee3677b1b3e9da711d0021
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214801
Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771498}