GitLab

R=brettw

Review URL: https://codereview.chromium.org/269313006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274064 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Properly prioritize the sources of an accessible name on Android. (https://codereview.chromium.org/303113003/)

Reason for revert:
Broke android bots it looks like:
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/20683

Original issue's description:
> Properly prioritize the sources of an accessible name on Android.
> 
> This spec covers the right order: http://www.w3.org/TR/wai-aria-implementation
> 
> Now Android basically matches Windows, the difference is that Android has
> to pick just one accessible name while Windows can have both a name and
> a description.
> 
> There were existing cross-platform tests; I updated the Android
> expectations.
> 
> BUG=359216
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274017

TBR=aboxhall@chromium.org,dmazzoni@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=359216

Review URL: https://codereview.chromium.org/304293006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274063 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Mojo: Specify/check alignment of pointers more carefully. (https://codereview.chromium.org/304303006/)

Reason for revert:
Broke the windows bots:
http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%283%29/builds/40269
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%284%29/builds/26580

Original issue's description:
> Mojo: Specify/check alignment of pointers more carefully.
> 
> Improve the verification routines especially in the case that no count
> is necessary.
> 
> Also add a test.
> 
> R=darin@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273936

TBR=darin@chromium.org,viettrungluu@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/312463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274062 0039d316-1c4b-4281-b951-d872f2087c98

Introduce NewTabButtonTargeter, a derived class of 
MaskedViewTargeter, to define the custom hit-test 
region of the new tab button.

BUG=377551
TEST=none

Review URL: https://codereview.chromium.org/299353007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274041 0039d316-1c4b-4281-b951-d872f2087c98

If the browser does not yet have permission to access the user's contacts, one
of the Autofill suggestions has the text "Enable Autofill using Contacts". If
the user selects that suggestion, the browser will prompt the user for access
to the user's address book.

The act of clicking the permissions dialog causes Blink to lose its focus on
the text field, which also dismisses the Autofill popup. If the user has
granted Chrome access to the address book, the autofill popup will be presented
again, and filled in.

This CL does not include the image asset, nor does it include the logic to
display the image asset on the left of the autofill entry.

BUG=139154
TEST=Run the command `tccutil reset AddressBook` to reset AddressBook
permissions for all applications. Clear the default Chromium profile:
`rm -rf ~/Library/Application\ Support/Chromium/Default/`.  Launch Chromium by
double clicking on it from Finder.  Navigate to
`https://www.mycontactform.com/samples/change_address.php`. Double click the
"First Name" field. There should not be a prompt to access your "Contacts".
There should be exactly 1 autofill entry: "Enable Autofill using Contacts...".
Clicking that autofill entry should open a system prompt that asks for Contacts
permissions for Chromium.

Review URL: https://codereview.chromium.org/286243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274040 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274038 0039d316-1c4b-4281-b951-d872f2087c98

This is designed to prevent deadlocks on the buildbots.

I couldn't figure out a way to kill them without killing the parent as well. I
also haven't looked into a Windows equivalent yet.

BUG=357059

Review URL: https://codereview.chromium.org/301313007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274036 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=no functional change.

Review URL: https://codereview.chromium.org/308193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274035 0039d316-1c4b-4281-b951-d872f2087c98

BUG=367896

Review URL: https://codereview.chromium.org/305233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274034 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274033 0039d316-1c4b-4281-b951-d872f2087c98

Use EstablishGpuChannel() with callback instead of EstablishGpuChannelSync() 
and skip and defer browser Composites until the channel is ready.

BUG=326297

Review URL: https://codereview.chromium.org/228663008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274032 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=174974:175159&mode=html

TBR=mvanouwerkerk@chromium.org

Review URL: https://codereview.chromium.org/309653006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274031 0039d316-1c4b-4281-b951-d872f2087c98

BUG=375416

Review URL: https://codereview.chromium.org/305103006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274030 0039d316-1c4b-4281-b951-d872f2087c98

This patch relands the final portion of r273386, which was reverted due
to issues with the gpu rasterization test. Those issues have been
separately fixed in r273755 and rXXXXXX.

BUG=368495
TBR=navabi@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/304233010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274029 0039d316-1c4b-4281-b951-d872f2087c98

BUG=369680

Review URL: https://codereview.chromium.org/307003005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274028 0039d316-1c4b-4281-b951-d872f2087c98

nacl_thread.h only defines nacl_tls_get() and nacl_tls_init(), which are
not generally useful for application code.  They are only used
internally within libc/libpthread.

This is part of general cleanup to reduce Chromium-side dependencies on
NaCl headers that are not in public directories (src/include/nacl and
src/public).

BUG=https://code.google.com/p/nativeclient/issues/detail?id=2832
TEST=NaCl SDK bots

Review URL: https://codereview.chromium.org/308163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274027 0039d316-1c4b-4281-b951-d872f2087c98

Adds support for the devtools generated resources.

Still doesn't compile, but getting closer.

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/304223009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274026 0039d316-1c4b-4281-b951-d872f2087c98

BUG=378849

Review URL: https://codereview.chromium.org/308063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274025 0039d316-1c4b-4281-b951-d872f2087c98

Previously if a static library depended on a source set, we'd link it in. This can easily cause multiple inclusions of the source set's code if there are multiple shared libraries that depend on it.

This patch forwards the source set up the dependency chain to the next linkable target (shared library or executable). This solves the multiple-definition problem. The downside is that if you make a static library that depends on a source set, it won't be "complete" in the sense that you can give it to somebody and it will have all of the files in it. If we need that capability, we'll add some kind of "complete" flag.

BUG=
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/302033004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274024 0039d316-1c4b-4281-b951-d872f2087c98

When run in a component build, isolate_driver recursively descends the
dependency graph to discover implicit shared library dependencies. A
bug in the recursion caused dependencies at certain depths in the
graph to be missed.

Also changed the recursion to use a set to record newly added
dependencies to avoid adding them to the isolate multiple times.
Expanded the ignored set of suffixes slightly.

BUG=378021
TEST=GLES2 conformance tests run via isolate in component build on Mac OS
R=maruel@chromium.org,vadimsh@chromium.org,csharp@chromium.org

Review URL: https://codereview.chromium.org/304993006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274023 0039d316-1c4b-4281-b951-d872f2087c98

Change some targets to source sets. These are small ones that are currently depended on by other source sets. This avoids some duplicate symbols.
duplicated.

Fix some conditions around the touch_device in ui/base.

Lots of Skia build fixes. It turns out our skia library does not use the "util" target, and some of the files in "util" reference functions that it seems are never defined in any file. This removes the ones in our list that weren't in skia_library.gypi to make accessibility_unittests link.

Update gesture recogniser file lists.

BUG=377890
TBR=scottmg

Review URL: https://codereview.chromium.org/305993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274022 0039d316-1c4b-4281-b951-d872f2087c98

BUG=379341

Review URL: https://codereview.chromium.org/307743003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274021 0039d316-1c4b-4281-b951-d872f2087c98

If a process is actively rendering audio, it should not be put into
the background state.  "Active" is determined by having any stream
in the playing state as considered by AudioRendererHost.

When a tab has active audio, it's already being woken up ~ every
10-20ms, so I expect the power impact of this change to be negligible.

This should reduce glitching under load.

BUG=362294
TEST=Ensure Windows playback under load no longer glitches.

Review URL: https://codereview.chromium.org/298253004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274020 0039d316-1c4b-4281-b951-d872f2087c98

They are necessary otherwise grit won't define IDS_WEB_FONT_FAMILY and
IDS_WEB_FONT_SIZE from app_locale_settings.grd

Which is necessary, otherwise we get the following error when trying to
compile web_ui_util.cc:

../../ui/base/webui/web_ui_util.cc:130:28: error: 'IDS_WEB_FONT_FAMILY'
was not declared in this scope
../../ui/base/webui/web_ui_util.cc:131:26: error: 'IDS_WEB_FONT_SIZE'
was not declared in this scope

BUG=367591
TEST=gn gen out/Debug_gn && ninja -C out/Debug_gn ui_base
R=brettw@chromium.org
TBR=ben (for ui/base change)

Review URL: https://codereview.chromium.org/296933017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274019 0039d316-1c4b-4281-b951-d872f2087c98

Audio ACK received events are important for simulation. Logging it now.

Review URL: https://codereview.chromium.org/307933007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274018 0039d316-1c4b-4281-b951-d872f2087c98

This spec covers the right order: http://www.w3.org/TR/wai-aria-implementation

Now Android basically matches Windows, the difference is that Android has
to pick just one accessible name while Windows can have both a name and
a description.

There were existing cross-platform tests; I updated the Android
expectations.

BUG=359216

Review URL: https://codereview.chromium.org/303113003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274017 0039d316-1c4b-4281-b951-d872f2087c98

BUG=378965

Review URL: https://codereview.chromium.org/308173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274016 0039d316-1c4b-4281-b951-d872f2087c98

An Activity can be a WebActivity, a SampleActivity etc. Each Activity has an
ActivityViewModel. The ActivityViewModel describes the UI for the Activity.

The ActivityManager is there to manage the list of activities. It is the source
of all the activities that various other activity-managers would use.

The ActivityViewManager is notified of activity updates from the ActivityManager,
and it creates the appropriate UI elements (views::Widget, etc.) to show the UI
for the activity to the user.

BUG=376357
R=oshima@chromium.org, skuhne@chromium.org
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/302683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274015 0039d316-1c4b-4281-b951-d872f2087c98

Changes:
1) Run clang-format through source and header files.
2) Fix member variables names.
3) Rename file name to mock_webrtc_data_channel_handler.

BUG=360000
TEST=None. No functional changes.

Review URL: https://codereview.chromium.org/305923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274014 0039d316-1c4b-4281-b951-d872f2087c98

When deleting a node view manager could end up messaging client both
of the delete and to advance. If delete is sent there is no need to
send an advance too.

BUG=365012
TEST=covered by tests
R=ben@chromium.org

Review URL: https://codereview.chromium.org/307003004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274013 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium:379140
TEST=unit tests pass
Signed-off-by: Simon Que <sque@chromium.org>

Review URL: https://codereview.chromium.org/302153003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274012 0039d316-1c4b-4281-b951-d872f2087c98

Introduce the virtual function 
View::CanProcessEventsWithinSubtree(), which returns 
true if the view and any of its descendants are 
permitted to be the target of an event. This will be 
called as part of event targeting and replaces the 
overrides of View::HitTestRect() in cases where the 
rect parameter is unused. One such replacement
(for ImageView) is made in this CL.

BUG=374325, 378530
TEST=ViewTest.CanProcessEventsWithinSubtree, ViewTargeterTest.CanProcessEventsWithinSubtree

Review URL: https://codereview.chromium.org/297963006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274011 0039d316-1c4b-4281-b951-d872f2087c98

Do not mark QUIC as *broken* when a 0-RTT fails because this prevents us from verifying that TCP is also working. So instead, mark it as "recently broken" which requires handshake confirmation.

Review URL: https://codereview.chromium.org/305213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274010 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274009 0039d316-1c4b-4281-b951-d872f2087c98

The test file is a bit too big (30mb) to stick into the regression
tests, so we'll just count on ClusterFuzz for watching this one in
the future.

Pulls in:
96481cb avformat/matroskadec: fix off by 1 error in matroska_read_seek()

BUG=378782
TEST=file no longer crashes.
TBR=wolenetz

Review URL: https://codereview.chromium.org/301223011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274008 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/307013004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274007 0039d316-1c4b-4281-b951-d872f2087c98

We already have the title available (because we're not throwing away the old
document in the renderer process), and if we don't immediately set the title,
there is a race condition where the title may be updated in the ui before the renderer
process sends a FrameHostMsg_UpdateTitle IPC. In this case, the title will flicker to
the page url and immeidately back to the proper title.

BUG=375455
TEST=NavigationControllerTest.PushStateUpdatesTitle

Review URL: https://codereview.chromium.org/308143004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274006 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/289333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274005 0039d316-1c4b-4281-b951-d872f2087c98

BUG=371530

Review URL: https://codereview.chromium.org/301243005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274004 0039d316-1c4b-4281-b951-d872f2087c98

The recording of the histograms has already landed in r273559.

BUG=376811

Review URL: https://codereview.chromium.org/302143006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274003 0039d316-1c4b-4281-b951-d872f2087c98