GitLab

Syzygy is unable to instrument some of the Chrome tests (browser_tests and unit_tests) due to interactions with RTC. Disable them so that we can collect full coverage stats.

BUG=


Review URL: https://chromiumcodereview.appspot.com/12207129

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182004 0039d316-1c4b-4281-b951-d872f2087c98

BUG=175665


Review URL: https://chromiumcodereview.appspot.com/12220122

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182003 0039d316-1c4b-4281-b951-d872f2087c98

Getting rid of some more native desktop only BrowserList::const_iterator.

BUG=129187


Review URL: https://chromiumcodereview.appspot.com/12213053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182002 0039d316-1c4b-4281-b951-d872f2087c98

BUG=175629

Review URL: https://codereview.chromium.org/12209110

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182001 0039d316-1c4b-4281-b951-d872f2087c98

Added UMA records for:
* portal detection result
* portal detection duration
* discrepancy with shill's result

BUG=174047
TEST=Manual tests on Lumpy


Review URL: https://chromiumcodereview.appspot.com/12211111

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181999 0039d316-1c4b-4281-b951-d872f2087c98

Make this function visible on about:tracing since it used to show up as a hotspot during early startup.

BUG=162838


Review URL: https://chromiumcodereview.appspot.com/12207125

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181998 0039d316-1c4b-4281-b951-d872f2087c98

1. Instead of using "new" to create cloud print URL fetchers,
use protected virtual ::CreateCloudPrintURLFetcher()

2. Instead of having a private destructor, have a protected one,
allowing for sub-classing (useful for testing purposes)

BUG=


Review URL: https://chromiumcodereview.appspot.com/12208089

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181997 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/12223102

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181996 0039d316-1c4b-4281-b951-d872f2087c98

TBR=petewil@chromium.org,MHX348@motorola.com
BUG=175744
TEST=waterfall.sh

Review URL: https://codereview.chromium.org/12210146

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181995 0039d316-1c4b-4281-b951-d872f2087c98

The cause of the flaky tests this was causing is now better-understood
and we can re-enable this (the flaky tests are still disabled).

Note that this flag is also enabled by default on phones from Java,
so we should turn it on here to get the behavior everywhere and
stop needing to support the old path.

NOTRY=true
BUG=161945


Review URL: https://chromiumcodereview.appspot.com/12210132

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181994 0039d316-1c4b-4281-b951-d872f2087c98

BUG=


Review URL: https://chromiumcodereview.appspot.com/12246003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181993 0039d316-1c4b-4281-b951-d872f2087c98

clang-tools-extra contains several useful utilities for refactoring such
as clang-format and (eventually) clang-format-diff.py.

BUG=none

Review URL: https://codereview.chromium.org/12213081

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181992 0039d316-1c4b-4281-b951-d872f2087c98

BUG=175509
TEST=Manual tests on Lumpy


Review URL: https://chromiumcodereview.appspot.com/12217133

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181991 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/12207091

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181989 0039d316-1c4b-4281-b951-d872f2087c98

R=reveman,ccameron
BUG=174572


Review URL: https://chromiumcodereview.appspot.com/12208123

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181988 0039d316-1c4b-4281-b951-d872f2087c98

BUG=172404


Review URL: https://chromiumcodereview.appspot.com/12207099

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181987 0039d316-1c4b-4281-b951-d872f2087c98

BUG=175000
TEST=run_all_tests.py


Review URL: https://chromiumcodereview.appspot.com/12224116

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181985 0039d316-1c4b-4281-b951-d872f2087c98

Getting rid of some of the last BrowserList:: iterator methods :)!

Also making BrowserListImpl const-safe (otherwise GetLastActive(), required in this CL, couldn't be used on a const BrowserListImpl*).

BUG=129187

Review URL: https://codereview.chromium.org/12213091

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181984 0039d316-1c4b-4281-b951-d872f2087c98

through the ViewsDelegate::OnBeforeWidgetInit(). This way if the
delegate needs top_level (as we do for win-aura) its set correctly.

BUG=175115
TEST=covered by unit test now.
R=ben@chromium.org


Review URL: https://chromiumcodereview.appspot.com/12212136

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181983 0039d316-1c4b-4281-b951-d872f2087c98

The grey bar is added to the primary display to denote the launcher.
This doesn't make sense because now we provide a launcher for each
display, and we decided to just remove the launcher rather than
keeping it to every displays.

BUG=175569


Review URL: https://chromiumcodereview.appspot.com/12208121

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181982 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=Tested with x64 Linux build with chromeos=1.

Review URL: https://codereview.chromium.org/12217144

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181981 0039d316-1c4b-4281-b951-d872f2087c98

Looks like this is a bug in https://codereview.chromium.org/10910242.

BUG=175211
TEST=manual. see bug

Review URL: https://chromiumcodereview.appspot.com/12211121

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181980 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/12209080

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181979 0039d316-1c4b-4281-b951-d872f2087c98

BUG=164555
TEST=content_unittests
TBR=wiltzius
Review URL: https://codereview.chromium.org/12225142

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181977 0039d316-1c4b-4281-b951-d872f2087c98

Add makefile rules to install the built webkit string paks into
the system image.



Review URL: https://chromiumcodereview.appspot.com/12223093

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181976 0039d316-1c4b-4281-b951-d872f2087c98

This fixes the dialog-like confirm "bubble" class.
(make it a window-modal dialog delegate subclass)
Call new SpellingBubbleModel::SetPref(false) on 'No thanks'.
(clicking ok then cancel in two windows yields feature off)

See pics of the change at http://crbug.com/166075#c31

TODO(followup): Remove ConfirmBubble*? (only used by spelling).
TODO(followup): Fix insets after tweaking the new dialog style.
TODO(followup): Fix dialog 'extra view' placement.

BUG=166075
TEST=Spelling bubble (web textfield context menu -> "Spell-checker options" -> "Ask Google for suggestions") looks/works reasonable on Win/CrOS/Aura.
R=rlp@chromium.org,sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12222003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181975 0039d316-1c4b-4281-b951-d872f2087c98

The check being removed here basically says "if you're offscreen, and have no time to visible, then you should go in the never bin."

The problem is that when a layer stops moving, then its offscreen tiles are put in never bin. That means that we lose all those tiles we put effort into painting. This increases the frequency at which one sees blurry tiles after the page goes stationary. 

R=ccameron,reveman
BUG=175276

Review URL: https://chromiumcodereview.appspot.com/12220115

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181974 0039d316-1c4b-4281-b951-d872f2087c98

Handle if search_provider == NULL when constructing aqs CGI parameter.

BUG=175428
TEST=AutocompleteProviderTest::GetDestinationURL

Review URL: https://chromiumcodereview.appspot.com/12218104

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181973 0039d316-1c4b-4281-b951-d872f2087c98

BUG=v8::2487


Review URL: https://chromiumcodereview.appspot.com/12210035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181970 0039d316-1c4b-4281-b951-d872f2087c98

R=estade@chromium.org
BUG=171567


Review URL: https://chromiumcodereview.appspot.com/12209101

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181969 0039d316-1c4b-4281-b951-d872f2087c98

This CL changes the spell check correction to replace the misspelled range
within a selection instead of replacing the whole selection. This change enables
spell check of words selected with surrounding whitespace or punctuation. Such
selection happens on a double-click of a word with a trailing underscore in
Windows, for example. This CL requires the change in https://webkit.org/b/108513.

BUG=167485,169659

Review URL: https://chromiumcodereview.appspot.com/12038037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181968 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jochen@chromium.org
BUG=170097


Review URL: https://chromiumcodereview.appspot.com/11348046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181967 0039d316-1c4b-4281-b951-d872f2087c98

BUG=129050
TBR=sky

Review URL: https://codereview.chromium.org/12225139

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181966 0039d316-1c4b-4281-b951-d872f2087c98

Make zoom using ctrl+mouse wheel work in win aura. Windows non-aura had a hack that was a layering violation which sent a custom win32 message from RenderWidgetHostViewWin to WebContentsViewWin. Instead do this properly from RenderWidgetHostImpl to its delegate (WebContentsImpl), which works for both aura and non-aura windows builds.

BUG=175055
Review URL: https://codereview.chromium.org/12221144

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181965 0039d316-1c4b-4281-b951-d872f2087c98

BUG=174821

Review URL: https://codereview.chromium.org/12210057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181964 0039d316-1c4b-4281-b951-d872f2087c98

> Distribute extra memory evenly among visible clients
> 
> After computing all clients' memory budgets, take any
> extra memory left over and distribute it amongst the
> visible clients (so that, if their memory requirments
> suddenly jump, they don't need to wait for a roundtrip
> to the GPU process to get extra memory).
> 
> Disallow keeping around backgrounded tabs' contents on
> Android, to keep the maximum for the main tab.
> 
> Explicitly limit the memory to use for prepainting by
> specifying NiceToHave on Mac to avoid performance problems.
> 
> BUG=175125
> 
> Review URL: https://codereview.chromium.org/12226082

TBR=ccameron@chromium.org
Review URL: https://codereview.chromium.org/12208134

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181962 0039d316-1c4b-4281-b951-d872f2087c98

Prevent translated key events (WM_CHAR) associated with key events that focus the WebContents from being sent to the renderer, as they are not intended to target the renderer.

Example:

When the focus is in the omnibox, and a new URL is typed and Enter is pressed, the Enter keypress should focus the WebContents but the WebContents should not send the Enter char event to the current page.

BUG=175634
TEST=open print preview, select "save as pdf" as the destination and then navigate in the url bar by typing a url then enter. The "choose file" dialog shouldn't come up.
Review URL: https://codereview.chromium.org/12221133

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181958 0039d316-1c4b-4281-b951-d872f2087c98

There are some cases where WebCore internally needs to "reposition" the origin
point about which CSS transforms are applied. For example, when a perspective
container becomes composited, the composited location/bounds may change
depending on the positioning of its children. The perspective-origin from the
original DOM tree should not change, but internally it does require a new
origin to be given to the compositor. It turns out that WebCore uses the anchor
point layer property to communicate these cases. So, the compositor needs to
apply the sublayer transform about the anchor point instead of about the layer
center.

BUG=157961


Review URL: https://chromiumcodereview.appspot.com/12224113

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181957 0039d316-1c4b-4281-b951-d872f2087c98

With this command line flag, this store a detailed dump of all tile data into the trace buffer, including tile quads in screenspace. This provides enough foundation for cc-frame-viewer to visualize what impl-side painting is doing.

NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/12096112

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181956 0039d316-1c4b-4281-b951-d872f2087c98

Custom implementation of VectorPlatformDeviceEmf::drawBitmapRect, to shield it from changes in SkDevice::drawBitmapRect

Review URL: https://chromiumcodereview.appspot.com/12221116

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181955 0039d316-1c4b-4281-b951-d872f2087c98