- 18 Nov, 2020 40 commits
-
-
Norman Rosas authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //components/infobars Bug: 1113033 Change-Id: I91afed53796b1795e0eaaaa91c606f8122c7fb65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543586Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Norman Rosas <normando@google.com> Cr-Commit-Position: refs/heads/master@{#828733}
-
Norman Rosas authored
Generate DIR_METADATA files and remove metatada from OWNERS files for //components/crash Bug: 1113033 Change-Id: I95da1e0f4712feee96eda781c3d273633dea112c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542572Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Norman Rosas <normando@google.com> Cr-Commit-Position: refs/heads/master@{#828732}
-
Ioana Pandele authored
This reverts commit 9a10a6f1. Reason for revert: org.chromium.content.browser.GestureListenerManagerTest#testOnScrollEventsAfterCrashAndReload is very flaky Bug: 1150208 Original change's description: > Add test coverage for GestureListenerManager crash/reload case > > Bug: 1144109 > Change-Id: Iba055d3a9876b80f0da828409e2f21b1c5940a85 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521156 > Commit-Queue: Evan Stade <estade@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825525} TBR=sky@chromium.org,estade@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1144109 Change-Id: I46f9b3b990b578474258260715715103bfd851da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546543Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#828731}
-
W. James MacLean authored
This CL fixes some comment issues for https://chromium-review.googlesource.com/c/chromium/src/+/2540749. TBR=creis@chromium.org Bug: 1148739 Change-Id: I29f18518ce65a955a295cea310219a7b10a66842 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546961Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#828730}
-
Saurabh Nijhara authored
The browser test related to audio output allowed policy is moved to a separated file. Bug: 1150081 Change-Id: Ic2e4c881b58f7d068c357908eb3b14e3e206ec28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545384Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#828729}
-
Ken Rockot authored
This disentangles most of the remaining Service Manager bits brought up and/or exposed by the Content layer. After this CL, it is trivial to move Service Manager ownership completely into //chromecast where its only remaining consumers reside. Bug: 977637 Change-Id: I8306c5dde888fc14c20b1f6fcdd5d439f0e12831 Tbr: danakj@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545068Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#828728}
-
Robert Phillips authored
Bug: 1149931 Change-Id: I2580451a2b2dd9f9e598004a0903dfc51bf87530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544870Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#828727}
-
Dave Tapuska authored
HandleMouseLeave can be a common implementation, this fixes a TODO in the OOPIF case for clearing the target URL. BUG=1097816 Change-Id: I41c7e6d6d022360f5f964e005485ae80e9871d9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543123 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#828726}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2efafe688dd1..9ef7e206b9a2 2020-11-18 robertphillips@google.com Remove friending between GrRenderTask and GrDDLTask 2020-11-18 robertphillips@google.com Update the TopoSort test ... If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: lovisolo@google.com Change-Id: I6d16d2c5dc659fd0bdb2404d5549481d3f9f7e54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546869Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828725}
-
Ioana Pandele authored
Seems to be timing out again on Linux debug, but not on other platforms. See: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/93029 TBR=masonfreed@chromium.org Bug: 1095379, 1105957 Change-Id: Ie8ee802ce51a20ba52edbc961a38b5a023bf6cbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545508Reviewed-by:
-
Olesia Marukhno authored
Fix browser and interactive ui tests when permission requests use chip UI. Bug: 1148277 Change-Id: I4f50a2aa32f7ad8f1f8ead3873a87cee20f9b80a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539201 Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#828723}
-
Norman Rosas authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //components/pdf... Bug: 1113033 Change-Id: Ia0545364052f110429122f80cd1d9275d05a7c8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545482Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Norman Rosas <normando@google.com> Cr-Commit-Position: refs/heads/master@{#828722}
-
Omar Morsi authored
When an extension requests to generate a key, if after generation, registering the key as corporate fails, the key is left around and an error is returned to the requesting extension. This CL introduces an extra steps after the corporate registration fails, which is deleting the generated key. Bug: 1131436 Change-Id: Ia31afcb394baa168cce4e83c9dac8adb27cf07ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544686Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#828721}
-
Olesia Marukhno authored
Bug: 1150365 Change-Id: I94c3ce6a04815a6789934e18c4565834ad5f46d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546981 Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
-
Xiaocheng Hu authored
Bug: 687225 Change-Id: Ied4368ce4f31ef5d3f6538c05b26dc90792d0507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545046 Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#828719}
-
Dave Tapuska authored
MouseCaptureLost is a signal from the browser that capture has been lost. It was getting overridden for WebViews to also release the mouse capture if it was necessary. This has been changed to a separate call in https://chromium-review.googlesource.com/c/chromium/src/+/2541202 and now the common implementation can be moved into base. BUG=1097816 Change-Id: Ic545e543805e0df72dfe11821f02f5f5971844a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542845 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Clemens Arbesser authored
This fixes a problem where trigger scripts would fail to start for the special case that there is no LastCommittedURL, which can happen during testing with adb. This also fixes a potential null-pointer exception on the java side. Finally, this CL disables animations for integration tests to hopefully fix recently reported flakiness. Bug: 1149965 Bug: b/171776026 Change-Id: I5a4071fa84516c7ef9f1445f090a3bb953af3eeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545628 Commit-Queue: Clemens Arbesser <arbesser@google.com> Auto-Submit: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#828717}
-
Francois Doray authored
Change-Id: I48f6574d9ebfadf678e248abe2d2ba98a9806fbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540572 Auto-Submit: François Doray <fdoray@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#828716}
-
Anton Bikineev authored
Bug: 11297512 Change-Id: Ic20a21fd11053e9762d5e8c005b3309bb431e1a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546762 Auto-Submit: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#828715}
-
Josip Sokcevic authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under //content. R=boliu@chromium.org, jochen@chromium.org Bug: 1113033 Change-Id: I0470511febbec67619e7f96381b7df11b0e0e01c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543248 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Auto-Submit: Josip Sokcevic <sokcevic@google.com> Cr-Commit-Position: refs/heads/master@{#828714}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3644d1fc..de5334a0 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I98af6328e0a02d70076ee9f70f62827db078f3fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546902Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828713}
-
David Lei authored
Without this, the unittests may fail if you inserted the entries arbitrarily. Change-Id: I805029532f36358e623eda7eae6a541c3bbc62a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546343 Auto-Submit: David Lei <dlei@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#828712}
-
Alice Wang authored
This CL disable the sync service when user signs in but no data is synced. Bug: 1148219 Change-Id: Ib8b8b96843b85db048d19122e5c6629212d460b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543047 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#828711}
-
David Bienvenu authored
Bug: 1007788 Change-Id: Ia46955803364a314fa1a7d5810ac8fd1269f3e59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533394Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#828710}
-
Maksim Ivanov authored
Migrate the chrome.certificateProvider API's apitests to use net::EmbeddedTestServer instead of net::SpawnedTestServer. The latter is outdated and doesn't support TLS 1.3. This commit is a preparation for introducing the TLS 1.3 / RSA-PSS support in chrome.certificateProvider. Bug: 792204 Change-Id: I207ccc1d898ac247b943382f5525ec12fb7cf8db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546004 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Fabian Sommer <fabiansommer@chromium.org> Cr-Commit-Position: refs/heads/master@{#828709}
-
Mark Cogan authored
To start to remove model-layer functionality from the BVC, this CL factors four web navigation methods out of the BrowserCommands protocol and moves them into a new Browser agent. WebNavigationBrowserAgent acts as a wrapper around a Browser, providing common navigation options (back, forward, stop, reload) on the active web state (if any) in the Browser's WebStateList, as well as similarly wrapping the CanGoBack and CanGoForward methods. BVC no longer provides these methods as part of BrowserCommands or KeyCommandsPlumbing. Call sites for the old commands instead fetch the new BrowserAgent in the usual way and call the methods on it. The KeyCommandsProvider has theagent injected into it. Only one part of these methods was heavily coupled to the BVC's innards: the special casing for reloading a page showing an NTP. Since the BVC owns a map of NTP coordinators, it needs to handle the NTP reloads. Factoring the NTP coordinator ownership out of the BVC will be the work of several CLs and is well beyond the scope for including in this one. As an interim solution pending a fix for this implementation, this CL adds a "web navigation NTP delegate" that abstracts out the functions needed for reloading the NTP. The BVC publicly conforms to this delegate while it is in use. Change-Id: I9c21549f6d8af5c7970dfc50baabb2c7fc4d93c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537795 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#828708}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/49ce691f0bca..d14436f82285 2020-11-18 aerotwist@chromium.org [unit test] Add flag for HTML report generation 2020-11-18 janscheffler@chromium.org [e2etest] Move hosted mode server to https 2020-11-18 tvanderlippe@chromium.org Use TypeScript-authored files in elements/ 2020-11-18 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-11-18 tvanderlippe@chromium.org Typecheck profiler/HeapSnapshotView.js with TypeScript 2020-11-18 szuend@chromium.org TypeScript-ify ui/UIUtils.js part 3 2020-11-18 szuend@chromium.org TypeScript-ify ui/UIUtils.js part 2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6b9cac177113f037451b610d984c9c7ee69c6678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546864Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605679120-9f3476b66a4fad3e32e51dc995f45ad61750f20a.profdata to chrome-linux-master-1605700503-b63c9b13eb8ce76349ecd0eadd611ab4ead01971.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I38b0a59b645853df89969c7449f7a505b0ba784d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546868Reviewed-by:
-
Fredrik Söderqvist authored
ApplyStyleCommand, ComputedStyleCSSValueMapping, StyleBuilderFunctions, CSSToStyleMap and StyleResolverState no longer appear to need these privileges. Update comments for FilterOperationResolver and StyleResolver. Change-Id: I1396f1bb79df6f8a36ab3f7c3f414c4a709cee07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546013 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#828705}
-
Rohit Agarwal authored
Incognito CCT is restricted to be used only by 1P apps. This makes the testing the feature on non-1P apps impossible. This CL adds kCCTIncognitoAvailableToThirdParty feature flag that would allow opening Incognito CCT from a 3P context and would be removed by M91. The flag is set to disabled by default and enabling this flag has no effect. Bug: 1150360 Change-Id: I164913e15e407262f976bd564d752fd4b61de393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544895Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
-
Illia Klimov authored
This CL prevents Notification permission revocation for origins with abusive content or abusive prompts if warning is enabled. Bug: 1150379 Change-Id: Ifbb0732758c4f8e45c1ffca3fe2e79231bbc991e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545504Reviewed-by:
-
Sylvain Defresne authored
Passing pointer to C++ objects to blocks is dangerous as it can lead to use after free. Change BookmarkHomeViewController implementation to instead pass GURL or node ids (recovering the node by iterating over the bookmarks). This causes edit/move/remove operation to do a linear search of the BookmarkNode* in the BookmarkModel which can cause those operations to become slower if the user has a large number of bookmarks. If it is a problem, then BookmarkHomeViewController should probably use a proxy object instead of directly referencing the BookmarkNode* with the proxy listening for node deletion. Bug: 1113618 Change-Id: I15cb714f15950194ed7a0cf821a3ff36cb52417b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544705 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#828702}
-
Nohemi Fernandez authored
The current CHROME_CONNECTED cookie tests in AccountConsistencyService use the update time to approximate whether a cookie has been set. This patch switches the test to use a fake cookie manager to instead simulate interactions with the cookie store. Because the |last_cookie_update_map| is not updated by the external source, we no longer rely on it as the source of truth for number of cookies in the cookie store. We can, however, use it to understand the last time the service updated a cookie for a given domain. Bug: 1148814 Change-Id: Iebcd137272ab77a14fa25971f5786d00f0ad34c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540466 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#828701}
-
Fredrik Söderqvist authored
Everything uses ConvertStyleColor() now, so drop this helper since it is dead. This also allows removing the friend declaration from ComputedStyle. Change-Id: I2a516d74d6e1cf52877fc007db84a34117737a40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545627 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
-
Julie Jeongeun Kim authored
This CL removes crash key logging added to debug DCHECK error at WebRequestPermissions::HideRequest(). Bug: 1145496 Change-Id: I73728e5e85907b52bc63c7c267934300a4b2f8cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546386Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#828699}
-
Dave Tapuska authored
WebViewFrameWidget overode SetPageScaleStateAndLimits to force notification for remote frames. This can be pushed into the base implementation. BUG=1097816 Change-Id: I93247b9e2125a63f9b7579cfc60ab0960fa27fe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540579 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Maksim Ivanov authored
Make sure that the chrome.certificateProvider API rejects certificate descriptions that contain empty lists of algorithms/hashes. Such descriptions have always been documented as invalid, but this commit makes sure they're treated as such. Besides making the API's behavior more consistent, this also makes sure that the apitests will work correctly after migrating to a different HTTPS test server, since an empty algorithm is treated as "any algorithm is supported" by some of them, which would make the tests fail due to hitting unexpected algorithms. Bug: 792204 Change-Id: Ia14a37841f7ce0e5f56fa40b8ccbe8a197926bd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545385 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Fabian Sommer <fabiansommer@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f1f7c370eb0d..dda9c164cb3b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I01362a67fbe4c7738e68397ed8b9a4c884e3d839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546901Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a1112b326a79..2efafe688dd1 2020-11-18 kjlubick@google.com Fix debugger auto-deploy If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: lovisolo@google.com Change-Id: Icb75aa6c966ca076b32a30817aa5373ddc44c774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546861Reviewed-by:
-
Gauthier Ambard authored
The histogram is still used. Fixed: 1149534 Change-Id: I4da9757d4751ddc09ee798e1ce2439b461a2b9ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542985 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#828694}
-
