- 20 Nov, 2018 40 commits
-
-
liberato@chromium.org authored
Previously, 'Learner' was a roll-up trainer + model, intended to make it easy for clients to use the learning system. However, since LearningSession can do this too, it makes sense to split the model apart from the particular training algorithm used to build it. Change-Id: If207bf64c6a5b34fb84591b9b149bdd9a3ff6af4 Reviewed-on: https://chromium-review.googlesource.com/c/1327544Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#609802}
-
Mirko Bonadei authored
It will be moved to another header and another build target soon. More info: https://groups.google.com/d/msg/discuss-webrtc/F__pbaZxxS0/tP8bMo7GAQAJ. Bug: webrtc:9862 Change-Id: I260dca561db73d65eebb09930d510bec98d236c5 Reviewed-on: https://chromium-review.googlesource.com/c/1343259Reviewed-by:
Florent Castelli <orphis@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#609801}
-
Javier Ernesto Flores Robles authored
Instead of looking only to the credit cards to suggest, check for all to hide and show the Manual Fallback icon. User can also use this icon to go to the manage cards settings page. Bug: 845472, 906019 Change-Id: I3be2a715ebd00583ec44c5d45517e769c92d57f5 Reviewed-on: https://chromium-review.googlesource.com/c/1340265 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#609800}
-
Sergey Ulanov authored
FrameImpl was destroying FocusController without removing it from list of window event handlers, which was causing CHECK in the destructor. Bug: 906785 Change-Id: I78bb13a60e9e56ce663cfba9f6ded0357c3bab4c Reviewed-on: https://chromium-review.googlesource.com/c/1344749Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#609799}
-
Xianzhu Wang authored
This corresponds the interest rect expansion for scrolling contents in CompositedLayerMapping::RecomputeInterestRect(). Bug: 792577 Change-Id: Ibcde49ad098f9f3e53ca2af246ce2aa825a21f20 Reviewed-on: https://chromium-review.googlesource.com/c/1335748Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#609798}
-
Fabio Tirelo authored
This is the first CL to generalized the keyboard accessory handlers on the Chrome backend, so they can be also used to serve Autofill data. This CL spawns ManualFillingController from PasswordAccessoryController, both controllers are attached to a WebContents object. The new controller which is responsible for: - Coordinating requests from type-specific accessory controllers (Autofill and Password) and forwarding them to the native UI; - Forwarding events from the native UI to the type-specific controllers. To allow mocking of these classes in unit tests, this CL defines an interface and an implementation for each controller. Code review order suggestion: - password_accessory_controller.h: split original class into interface + implementation, this is the interface; - password_accessory_controller_impl.h: class implementing the interface; - manual_filling_controller.h: very similar to password_accessory_controller, but git doesn't understand copies; same idea: interface + implementation; - manual_filling_controller_impl.cc: class implementing the interface; - password_accessory_controller_impl*.cc; - manual_filling_controller_impl*.cc; - everything else, basically minor changes. In order to keep this CL more focused on the split, some steps of the generalization will be done in follow-ups (check TODOs pointing to https://crbug.com/896690), and the ManualFillingCoordinator simply forwards events to PasswordAccessoryController. One example is password generation: in this CL, MFC contains methods to forward password generation events to PAC; in the final state, MFC will define a general function that handles "actions" and will forward events to type-specific coordinators (passwords or autofill) based on action type. Please refer to the linked bug for details on next steps of this refactoring. Once it's done, we will be able to plug in Autofill requests. Bug: 905669 Change-Id: I4fb2fd1b4a729114d3c7e4dd59ec7a582ba8aea0 Reviewed-on: https://chromium-review.googlesource.com/c/1336557Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Friedrich Horschig [CET] <fhorschig@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#609797}
-
Jeremy Roman authored
It appears that this is intended to be a public header (at least, Blink is using it as such), so this updates the deps to depend on the appropriate target. Change-Id: I593f77d065b25ce080159f2920816841c9bf7837 Reviewed-on: https://chromium-review.googlesource.com/c/1330033Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#609796}
-
Xi Cheng authored
RegisterOrRemovePreviousRunMetricsFile() has 5 arguments already. If we want to tweak and apply it to the code block below TODO, we need to add another 3 arguments to the function at least. The function will end up with having 8+ arguments which is undesired for readability. Change-Id: I9cd5e03287ad661253c0312e48b9d143df35da74 Reviewed-on: https://chromium-review.googlesource.com/c/1343519 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#609795}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b81ff9e6c518..0e604f9f1107 git log b81ff9e6c518..0e604f9f1107 --date=short --no-merges --format='%ad %ae %s' 2018-11-20 jmadill@chromium.org ANGLE Perf Test fixes. Created with: gclient setdep -r src/third_party/angle@0e604f9f1107 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I2673a61d1c70dcbe635d972a98d0f909bdedee22 Reviewed-on: https://chromium-review.googlesource.com/c/1343853Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609794}
-
James Hawkins authored
R=hansberry@chromium.org Bug: 903991 Test: none Change-Id: Ifdeeb97fee9a964bca4fdeaece3df139e6c7584c Reviewed-on: https://chromium-review.googlesource.com/c/1344250 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#609793}
-
Vikas Soni authored
Update generate_bindings.py to generate android platform specific device functions. Bug: 891060 Change-Id: I88f5b6149c4e955613b64e56c403caf2a970dd6f Reviewed-on: https://chromium-review.googlesource.com/c/1344223Reviewed-by:
Chris Blume <cblume@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#609792}
-
James Hawkins authored
Bug: 903991 Test: none Change-Id: Ia52137049e6805bae4f04c1251ff1df862a6d644 Reviewed-on: https://chromium-review.googlesource.com/c/1343536Reviewed-by:
-
John Rummell authored
This reverts commit 45a0df8f. Reason for revert: Mac tests flaky, due to filesystem storing time in second increments only. Original change's description: > Reland "Update BrowsingDataRemoverBrowserTest to include MediaLicenses" > > Original change's description: > > MediaLicenses can be cleared from the ClearBrowsingData dialog, so update the > > BrowsingDataRemoverBrowserTest to check them as well. This uses the test-only > > External Clear Key CDM to store the license in the file system, if it is > > available. > > > > This reverts commit 72f2d4cd. > > BUG=808690,879812 > TEST=new browser_tests pass > > Change-Id: Ie9e9229fc85244eed922d93dce82cb3fa09bbe5c > Reviewed-on: https://chromium-review.googlesource.com/c/1342779 > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > Commit-Queue: John Rummell <jrummell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609752} TBR=jrummell@chromium.org,dullweber@chromium.org Change-Id: I1c49014959d10fb9eb2306af0f71cb724ef40070 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 808690, 879812 Reviewed-on: https://chromium-review.googlesource.com/c/1344884Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#609790}
-
Alexandre Frechette authored
Bug: 907134, 902803 Change-Id: Ifb63346572e90a191918bcfe30d24f4362c10b45 Reviewed-on: https://chromium-review.googlesource.com/c/1344256Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#609789}
-
Scott Chen authored
This CL moves all functions related to figuring out user's country code from component/search_engines/ to a stand-alone component, so that they can be reused by other features that also want to know the user's country code. Bug: 894499 Change-Id: I1a79a4db6a5a8abcc32101db3fb7dce8013a1f16 Reviewed-on: https://chromium-review.googlesource.com/c/1334859Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Karan Bhatia authored
This CL changes the extensions using the web request API to require host permission to the request initiator (in addition to the request url), thus fixing a long standing security bug. Also add documentation for the same. BUG=157736 Change-Id: If943878336f9095ddc201f297d8cdc3cc24d85e4 Reviewed-on: https://chromium-review.googlesource.com/c/1313053Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#609787}
-
Yi Su authored
[sheriff] disable GoogleServicesSettingsTestCase.testActivityAndInteractionsDisabledWithHistoryDisabled on all devices/simulators. The test is only disabled on devices for now, and this CL disables it on both devices and simulators. TBR=edchin@chromium.org Change-Id: I7aabcbd1fbfe9017907db950097a9e3e002efa68 Reviewed-on: https://chromium-review.googlesource.com/c/1345009Reviewed-by:
Yi Su <mrsuyi@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#609786}
-
François Beaufort authored
This makes sure Picture-in-Picture window doesn't show play/pause button if video duration is infinity like we do already for mediastream video. Bug: 905136 Change-Id: Iec193e8807a756f51fec6efd4d446fa65e2df71b Reviewed-on: https://chromium-review.googlesource.com/c/1328963Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#609785}
-
Krishna Govind authored
R=abdulsyed@chromium.org Change-Id: I04757d4cdb3085349ad54c01804560b28d2ec256 Reviewed-on: https://chromium-review.googlesource.com/c/1344809Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#609784}
-
edchin authored
Change-Id: Ib1f0a6716ff4682b3754b94e969b25a279bcc9ae Reviewed-on: https://chromium-review.googlesource.com/c/1341248 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#609783}
-
Vadym Doroshenko authored
Bug: None Change-Id: Ie15384d059c4fa0db3de479fc1068a488e85fef7 Reviewed-on: https://chromium-review.googlesource.com/c/1344140Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#609782}
-
Yi Su authored
CollectionViewController to ChromeTableViewController, and show search engines' keywords in Settings. This CL migrates the SearchEngineSettingsCollectionViewController from CollectionViewController, which is based on MDCCollectionViewController, to ChromeTableViewController, which is based on UITableViewController. This CL also enables showing search engines' keywords in Settings for security considerations. Bug: 894791, 433824 Change-Id: I0eb6cf7081159d13cf389750f99ca13ee162c9d6 Reviewed-on: https://chromium-review.googlesource.com/c/1344134 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
-
Lukasz Anforowicz authored
This CL associates test expectations for navigation-blocking-xorigin-iframe.js with Site Isolation, and restores test coverage offerred by this test (via virtual/not-site-per-process test suite). Bug: 906879 Change-Id: If57837cf0650f02c4ce58665d845462c4422cce5 Reviewed-on: https://chromium-review.googlesource.com/c/1344258Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#609780}
-
Javier Ernesto Flores Robles authored
The password icon on the iPad is now in the trailing side, no need to keep presenting the modal in the leading side. Bug: 878388 Change-Id: Ib53da429660bad996247727e622ef03a7fedc876 Reviewed-on: https://chromium-review.googlesource.com/c/1344430Reviewed-by:
-
edchin authored
Change-Id: I4bec2b03fbc58dfa91e89fff059b9a0a5dbd8e5b Reviewed-on: https://chromium-review.googlesource.com/c/1341448 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7da982abf99f..e47ac15d93b8 git log 7da982abf99f..e47ac15d93b8 --date=short --no-merges --format='%ad %ae %s' 2018-11-20 abenner@google.com Fix git cl format --python on windows Created with: gclient setdep -r src/third_party/depot_tools@e47ac15d93b8 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:846432 TBR=agable@chromium.org Change-Id: I2915800b137f3679f918b5cfa488a70469505ffe Reviewed-on: https://chromium-review.googlesource.com/c/1344271Reviewed-by:
-
Evan Stade authored
This simplifies the test fixture and allows the tests to pass in single process mash. (Technically, they also pass in single process mash without this change, but would cease to do so after AuraTestSuite stops creating an InputDeviceClient, which will soon happen.) Bug: 905430 Change-Id: I9536989b016176b96db824732720b86d6442f27d Reviewed-on: https://chromium-review.googlesource.com/c/1343338 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#609776}
-
Kyle Horimoto authored
This CL adds latency metrics for sub-tasks of BLE connections: * start scan ==> receive advertisement * start scan ==> GATT connection * receive advertisement ==> GATT connection * GATT connection ==> authentication Bug: 870139 Change-Id: If1f4230bb873e097a10963f8fc86003afc1146ac Reviewed-on: https://chromium-review.googlesource.com/c/1336921Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
-
Ted Choc authored
This removes the duplicate parsing logic in Java. BUG= Change-Id: If43303f6a7bc708186601bdaca0e876c6c3ceee4 Reviewed-on: https://chromium-review.googlesource.com/c/1343080 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#609774}
-
Tommy C. Li authored
We aren't experimenting on this anymore. Bug: 900255 Change-Id: Idc932239bb767ffb602323d66b9cf2f89321891d Reviewed-on: https://chromium-review.googlesource.com/c/1343362 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Reviewed-by:
-
Fredrik Söderquist authored
This one using inline style instead of presentation attributes. Bug: 650147 Change-Id: I00ee6c52b95803a928dd0b95a33da89f531a05ac Reviewed-on: https://chromium-review.googlesource.com/c/1344102Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#609772}
-
Mohsen Izadi authored
This also cleans up initialization a bit. BUG=none Change-Id: Ic875db92a4f1b1e9e72bed180da3b4da1211fe29 Reviewed-on: https://chromium-review.googlesource.com/c/1343244Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#609771}
-
Saman Sami authored
Change-Id: I2e81f37f27ce73fd4ceac36f1c523b9dfdb90d42 Reviewed-on: https://chromium-review.googlesource.com/c/1343355Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
-
Daniel Bratell authored
Both components/policy/core/common/cloud/machine_level_user_cloud_policy_metrics.h and components/policy/core/common/cloud/enterprise_metrics.h define policy::kMaxValue in two different enums. If code includes both headers, it won't compile and this happens in some jumbo build configurations. This patch changes one of the enums to use enum class so that the symbols are in different namespaces. (One will shadow the other but as long as they are used correctly it will be fine) Bug: 905702 Change-Id: Ia4dd0c89dc8ec5c23c516e90eae7f6c3256a232a Reviewed-on: https://chromium-review.googlesource.com/c/1344129Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#609769}
-
Vincent Boisselle authored
needed by the download manager to handle the new api to reuse most of the logic in place for the legacy api. Change-Id: I529a55781919ddb8c23b3cebc9f1b1d0af148af6 Reviewed-on: https://chromium-review.googlesource.com/c/1334268 Commit-Queue: Vincent Boisselle <vincb@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#609768}
-
bsheedy authored
This is a reland of a8f4b170 No changes from original CL (erroneously reverted) Original change's description: > Cleanup XR usage of EmbeddedTestServer > > Cleans up manual usage of EmbeddedTestServer in XR tests, which was both > adding a lot of duplicate code and had the potential to fail to clean up > the server if the test failed, which could then affect other tests. > > This is achieved by making EmbeddedTestServerRule lazy and applying it > to all ChromeActivityTestRules, not just WebappActivityTestRule. > > Bug: 901923 > Change-Id: I431dac3ce2488a1a5762a1ab1f5ec68aea16c9f5 > Reviewed-on: https://chromium-review.googlesource.com/c/1320024 > Commit-Queue: Brian Sheedy <bsheedy@chromium.org> > Reviewed-by: Tommy Nyquist <nyquist@chromium.org> > Reviewed-by: Paul Jensen <pauljensen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609556} TBR=nyquist@chromium.org, pauljensen@chromium.org Bug: 901923 Change-Id: I1d538672fc6b67d97a47f4bd165c4169e9b3f37c Reviewed-on: https://chromium-review.googlesource.com/c/1344550Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#609767}
-
Gauthier Ambard authored
This CL prepares the AutofillEditItem to be changed to be used with UITableView. Bug: 894791 Change-Id: Iee510dd6cf2df483ef2977fba9ff4ca3a85f9326 Reviewed-on: https://chromium-review.googlesource.com/c/1344135Reviewed-by:
-
Dan Elphick authored
Replace use of deprecated Maybe<bool> BooleanValue(Context) with bool BooleanValue(Isolate*). The Maybe version is unnecessary as BooleanValue can never throw. Bug: v8:7279, v8:8238 Change-Id: Iaf827cedbf158c59727900ff551962e2af4ccbac Reviewed-on: https://chromium-review.googlesource.com/c/1344063 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#609765}
-
Robert Sesek authored
There are slightly different font metrics between macOS versions, and either macOS 10.10 or 10.11 will fail with a single hard-coded constant value for pixel widths. Just disable this test on 10.10, which is the oldest version that is supported, and let the test pass on 10.11+. Bug: 739386 Change-Id: I82ea6a3276ebe5de4906c33a906ebf76cf2c85b9 Reviewed-on: https://chromium-review.googlesource.com/c/1344769Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#609764}
-
Geoff Lang authored
ResetDecoder would always pass a true have_context to GLES2Decoder::Destroy causing some assertions in the destuction of GL objects when the context had previously been lost. BUG=877524 Change-Id: I8b455ba0aa9515764d5caca63668401b09cb124e Reviewed-on: https://chromium-review.googlesource.com/c/1344212Reviewed-by:
-
