- 05 Dec, 2017 40 commits
-
-
Tomasz Mikolajewski authored
To match semantics of ExtensionProvider. Test: All current FSP tests pass. Bug: 790836 Change-Id: I6948086c234319031a4ae95664d9216c2fb5f55c Reviewed-on: https://chromium-review.googlesource.com/802836 Commit-Queue: Tomasz Mikolajewski <mtomasz@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#521608}
-
Stefan Zager authored
When an overflow:auto vertical scrollbar is removed from an RTL LayoutView, then the call to ClampScrollOffsetAfterOverflowChange in LayoutView::UpdateAfterLayout during the second layout pass (after removing the scrollbar) will happen when the ScrollableArea's overflow_rect_ needs updating. BUG=711468 R=skobes@chromium.org,pdr@chromium.org,bokan@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I191a7142808851b266904b1916afc57b4b305940 Reviewed-on: https://chromium-review.googlesource.com/802179 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#521607}
-
calamity authored
This reverts commit e8d7bd37. Reason for revert: Seems to be causing these test failures: https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Trusty__dbg_/7571/layout-test-results/results.html Original change's description: > [DevTools] show multiline errors in DebuggerPausedMessage > > Without this CL we show only first line, sometimes other lines are > important as well (see attached bug). With this CL we show message > until first call frame. > > R=lushnikov@chromium.org > > Bug: chromium:780816 > Change-Id: I4737c7cb4e7033126eeb7a419bcb59478afea0d2 > Reviewed-on: https://chromium-review.googlesource.com/802076 > Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#521587} TBR=lushnikov@chromium.org,kozyatinskiy@chromium.org Change-Id: Ifbb44fa5029f8019317d8757e0289f8c0296607a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:780816 Reviewed-on: https://chromium-review.googlesource.com/807597Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#521606}
-
Xianzhu Wang authored
This keeps consistent with legacy-results.html and rebaseline bots which treat MISSING as regressions. Also rename "unexpected failures" to "regressions" to be consistent with "Regressions" in summary. Also avoid exception when some test is directly under LayoutTests/ (where some developers like me put quick local layout tests). Change-Id: I80da6c9f54c64c98089a90ab72ae51e821a06a7b Reviewed-on: https://chromium-review.googlesource.com/807264 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#521605}
-
Derek Cheng authored
The dropdown will replace the checkbox that is currently in place to control whether media remoting is enabled. Note that this is not meant to be the final iteration of the UX; it is however an improvement over the existing checkbox and is a reasonable interim solution (while we gather feedback + do another UX study) Screenshots: LTR: https://screenshot.googleplex.com/dSPAZY4yHd5 RTL: https://screenshot.googleplex.com/apBUWUvp74q BUG=774245 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I296c47cae0ecf4d16b5b645f92af00a2e1161d4f Reviewed-on: https://chromium-review.googlesource.com/804138 Commit-Queue: Derek Cheng <imcheng@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#521604}
-
Helen Li authored
Reset the NetTestSuite's global task environment in unit test so the MOCK_TIME environment doesn't leak into subsequent tests. Bug: 791804 Change-Id: Ic5df1fc6c21c7ef6b88bff2d05a68b4636b7650a Reviewed-on: https://chromium-review.googlesource.com/807287 Commit-Queue: Helen Li <xunjieli@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#521603}
-
Alexander Alekseev authored
Google AccountId must have GaiaId identifier and correct type, which chromium tests still commonly ignore. This Cl adds correct AccountId initialization to some tests, which are needed for https://chromium-review.googlesource.com/c/chromium/src/+/804968 . TBR=sky@chromium.org,elijahtaylor@chromium.org Bug: 789068 Change-Id: Ied6d77bcdae2723fe9d224e2a35c701539d0e3b1 Reviewed-on: https://chromium-review.googlesource.com/805596 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Cr-Commit-Position: refs/heads/master@{#521602}
-
Devlin Cronin authored
Inspectable views can have any url, including some maddeningly long ones. We need to ensure that these render appropriately on the extension's card in the main view of the chrome://extensions page. Make the following changes: - Ensure that the inspect views section does not grow beyond the content area. - Ensure that the "Inspect views" and "n more..." are always visible - Adjust the overflow for the shown inspectable view to be hidden behind ellipses, and have the title text have the full label. Bug: 789655 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Icb6b769ed96c5775ea34a62eb15b89dbf625d124 Reviewed-on: https://chromium-review.googlesource.com/802095 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#521601}
-
erikchen authored
This CL adds two histograms: * OutOfProcessHeapProfiling.UploadTrace.Size is emitted on each trace upload, and reflects the uncompressed size of the trace. * OutOfProcessHeapProfiling.RecordTrace.Success is recorded after each attempt to record a trace, and reflects whether a trace was successfully recorded. This CL makes two other small changes: * Increase the timeout for waiting for a trace to 30 seconds from 10 seconds. * Update the OutOfProcessHeapProfilingMode enum to reflect new profiling modes. Bug: Change-Id: I303349b8a61dd2d5e3d25930f8e4c59cac109795 Reviewed-on: https://chromium-review.googlesource.com/806325 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#521600}
-
Donn Denman authored
Updates the flag for Chrome Smart Selection on Android to default enabled. BUG=770767 Change-Id: I39db673c4e37aa7919f5fd3edf4ee4e8a1f0d104 Reviewed-on: https://chromium-review.googlesource.com/807325Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#521599}
-
Hiroshige Hayashizaki authored
Previously, Document::EnforceSandboxFlags() - Calls ApplySandboxFlags(), - Detects indirectly whether a new unique origin is set in ApplySandboxFlags(), and - Modifies Document's SecurityOrigin that is the new unique origin that was just set. This CL moves the modification to the new unique origin into ApplySandboxFlags(), before setting the origin to SecurityContext. |is_potentially_trustworthy| is plumbed to do this. No behavior changes are expected. Bug: 779730 Change-Id: Ia62a35c81bd4130e7a8119cc93e17c6b527f5e12 Reviewed-on: https://chromium-review.googlesource.com/762337Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#521598}
-
dpapad authored
Bug: 787229 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I173e9c72b269c69a18f9c7909cfc60a0158f4707 Reviewed-on: https://chromium-review.googlesource.com/806930Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#521597}
-
Alexander Timin authored
Rename FrameType which is used for reporting to FrameStatus. This removed unfortunate collision between said FrameType and WebFrameScheduler::FrameType which is used to distinguish main frame and subframes. This patch also moves FrameStatus from renderer_metrics_helper to a separate header. This is done to use FrameStatus in ResourceLoadScheduler for per-frame network metrics. The histograms are not changed and still have PerFrameType in their names. R=npm@chromium.org Bug: Change-Id: I1bca2f0ba556969da1fe33093b5b43dd3c8f16e0 Reviewed-on: https://chromium-review.googlesource.com/801674 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#521596}
-
Emma Haruka Iwao authored
This patch adds updateViaCache to ServiceWorkerRegistrationOptions struct in mojom and ServiceWorkerContext. Intent to implement and ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/RwjXGTAbuuA/7Q3NPlJ4BAAJ Split from the original patch: https://chromium-review.googlesource.com/c/chromium/src/+/618076 Bug: 675540 Change-Id: I199357745605ebf43a82adfd30b2fbfd5e18e4b4 Reviewed-on: https://chromium-review.googlesource.com/792810Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#521595}
-
Joel Einbinder authored
This should make the color picker much faster Bug: none Change-Id: I487616d71e430cb6c8374473bc1d84d7810f10cf Reviewed-on: https://chromium-review.googlesource.com/807545 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#521594}
-
Kurt Horimoto authored
Although this is only used by the new architecture, it is model code built on top of BrowserCoordinator, which also lives in ios/chrome. This CL also renames the test_helpers/ directory to test/ to match other cases in ios/chrome. Bug: none Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I9b731c0805b36feb9cbced4688cb9899ac129ca8 Reviewed-on: https://chromium-review.googlesource.com/648076 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#521593}
-
Devlin Cronin authored
JS can be suspended when the renderer receives the IPC to dispatch an event. In this case, the JS shouldn't immediately run, but rather respect the JS state. Currently, the EventEmitter does this by using JSRunner::RunJSFunction() (which does respect JS suspension) with each of the listeners for the event. This mostly works, but has a couple of problems. For one, it makes it difficult to catch exceptions thrown from a JS listener (since the listener isn't notified when we queue it up through the JSRunner). It also doesn't account for the possibility of listeners being removed between a event comes in, and when it is actually disptached. Finally, it makes creating a single result for the dispatch difficult, which is problematic for messaging bindings. Rework the way event dispatching works to instead use a v8::Function wrapper around the EventEmitter to trigger the event being dispatched to listeners. Once that function is triggered, it's safe to use synchronous JS execution, since JS is already running at that point. This addresses the concerns with the current approach. Also add a Suspension utility to the TestJSRunner to simulate JS being suspended in testing, and add unit tests for dispatching events while JS is suspended. Bug: 653596 Change-Id: I7899e1946e8fe750fa2a1f53d62a04e5bd075664 Reviewed-on: https://chromium-review.googlesource.com/792033 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#521592}
-
edchin authored
A method (-controllerForUnhandledContent:) was in CRWWebDelegate when it belongs in CRWNativeContentProvider protocol. This helped pull the implementation out of tab.mm and into the BVC, which can provide a base view controller for presenting UI, instead of using rootViewController for presentation. Bug: 791206 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If82dcb4f16a64d5e1fef99e2805588e92f2ca4d9 Reviewed-on: https://chromium-review.googlesource.com/807306 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#521591}
-
Tom Anderson authored
BUG=790683 TBR=creis@chromium.org Change-Id: I9ba4317841f6487795f1fb0676c9dde09f6fe500 Reviewed-on: https://chromium-review.googlesource.com/801264 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#521590}
-
John Abd-El-Malek authored
Bug: 783981 Change-Id: I41afc98d8c9d60051cde53f3d17c28515ec9a8aa Reviewed-on: https://chromium-review.googlesource.com/807403Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#521589}
-
Emil A Eklund authored
Change FontPlatformData::FontFamilyName to parse the font family name as UTF-8 instead of latin-1 as that is the encoding of the localized family name provided by the API. Verified on Linux, Windows 7/10, and Mac OS X. No test as I was unable to find a font with a localized non-latin family name under a suitable license. Bug: 667154 Change-Id: Iddb7932b68681824062cc2a7bf163459fc356cbb Reviewed-on: https://chromium-review.googlesource.com/807527Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#521588}
-
Alexey Kozyatinskiy authored
Without this CL we show only first line, sometimes other lines are important as well (see attached bug). With this CL we show message until first call frame. R=lushnikov@chromium.org Bug: chromium:780816 Change-Id: I4737c7cb4e7033126eeb7a419bcb59478afea0d2 Reviewed-on: https://chromium-review.googlesource.com/802076Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#521587}
-
Chris Harrelson authored
Full-width offscreen tiles become increasingly expensive on larger displays. Bug: 768799 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ibb2423c6dc956a7ad81a85d12aefd9d58ee28872 Reviewed-on: https://chromium-review.googlesource.com/806994Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#521586}
-
Robert Sesek authored
Bug: 598854, 626802 Change-Id: I89e8afa29d884a63b6db68b9618d87ea5863432c Reviewed-on: https://chromium-review.googlesource.com/807169 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#521585}
-
Ovidio Henriquez authored
This change updates the gc-detach.html and detach-gc.html tests to use promise_test as opposed to async_test. This will help us migrate the tests to the wpt/ directory, since we use a wrapper around promise_test to dynamically load Chromium-specific modules. This change also updates gc-detach.html and detach-gc.html to use health-thermometer-iframe.html in order to use getHealthThermometerDevice rather than setBluetoothFakeAdapter. As a result, health-thermometer-iframe.html now contains a "RequestAndConnect" message case, and bluetooth-helpers.js does not rely on the "Ready" message from the health-thermometer-iframe.html anymore. Additionally, bluetooth-helpers.js now contains a function called setUpConnectableHealthThermometerDevice that sets up a fake_peripheral without requesting the device for tests that require the device to be requested outside of the main frame. BUG=769412 Change-Id: I310fd68569fb646e9e4e2ffde202b8f953a47e9b Reviewed-on: https://chromium-review.googlesource.com/777339 Commit-Queue: Ovidio Henriquez <odejesush@google.com> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Conley Owens <cco3@chromium.org> Cr-Commit-Position: refs/heads/master@{#521584}
-
Pavel Yatsuk authored
SingleClientSessionsSyncTest.CookieJarMismatch test is flaky. It fails on the step when signed in account gets included in the list of accounts in cookie jar. In this case value of cookie_jar_mismatch should turn to false. I wasn't able to reproduce this bug, nor I was able to find scenario how this test could fail. I'm adding a check that ensures correct value of cookie_jar_mismatch is passed to sync engine. The next time this test fails it will be clear if failure caused by incorrect value or the value wasn't delivered to the server. R=pnoland@chromium.org BUG=789129 Change-Id: I508e5d37083e98b2c02e1bf3a35917dad3a9645f Reviewed-on: https://chromium-review.googlesource.com/804556 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Patrick Noland <pnoland@google.com> Cr-Commit-Position: refs/heads/master@{#521583}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7be49f33. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/6909 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=qyearsley No-Export: true Change-Id: Ibc166887ab9305cefdb751ea3855aaf3a0578828 Reviewed-on: https://chromium-review.googlesource.com/806366 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521582}
-
Rintaro Kuroiwa authored
- Instead set and remove keys one by one. Bug: 785563 Change-Id: Ib67694a5e38f927a9bb10477b359101c72b799e0 Reviewed-on: https://chromium-review.googlesource.com/804642 Commit-Queue: Rintaro Kuroiwa <rkuroiwa@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#521581}
-
Blake O'Hare authored
OnKeyboardBoundsChanging is being split into several more specific methods that have a stronger contract of how they are being used by the implementer. More information about why this is being done is in the associated bug. OnKeyboardWorkspaceOccludedBoundChanging is called when the keyboard's bounds change in a way that makes certain regions of the workspace unusable, as far as workspace layout is concerned. When the keyboard's bounds change in a way that is purely visual or the keyboard is in a mode where it shouldn't affect workspace layout (such as a floating keyboard), this method will not be called. Bug: 786290 Change-Id: I4237be051b1a4bb3cf6eeff5598079205b4e1292 Reviewed-on: https://chromium-review.googlesource.com/804626Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Blake O'Hare <blakeo@chromium.org> Cr-Commit-Position: refs/heads/master@{#521580}
-
Jay Civelli authored
SafeXmlParser would DCHECK with CData containing non UTF8 strings. Now validating that the text is valid UTF8 and failing gracefully if it's not. Bug: 789832 Change-Id: I6cae6d1fad4297563627d2168c726160095be0d0 Reviewed-on: https://chromium-review.googlesource.com/805001 Commit-Queue: Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#521579}
-
Thomas Guilbert authored
Currently, MediaSource and RemotingMediaSource have no common ancestor. This makes code reuse between CastMediaRouteProvider and RemotingMediaRouteProvider difficult. This CL renames MediaSource into CastMediaSource, adds a MediaSource interface, and updates RemotingMediaSource and CastMediaSources to both derive from this interface. This paves the way for the introduction of a BaseMediaRouteProvider. Bug: 790766 Change-Id: I3f8e46816a1e9f8f2f617a43b1099c8614204efc Reviewed-on: https://chromium-review.googlesource.com/783836 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Anton Vayvod <avayvod@chromium.org> Reviewed-by:
Zhiqiang Zhang <zqzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#521578}
-
Bruce Dawson authored
message_compiler.py checks to make sure its results match those generated by mc.exe, but these checks are only valid for a given version of mc.exe, because the output changes with every new Windows 10 SDK version. The checking is disabled for SDK versions other than 10.0.15063 but only for .man files. This change extends the disabling of checking for .mc files also, due to observed failures. Bug: 774669 Change-Id: I618f68d8926b73621192e7933aea5d264fedd214 Reviewed-on: https://chromium-review.googlesource.com/807205Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#521577}
-
Aleks Totic authored
Part 2 of inline containing block patch. Stores inline-cb on NGOutOfFlowPositionedDescendant Bug: 740993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ib3ed1dfe654f691f38a2ee0069177bc78fca51ce Reviewed-on: https://chromium-review.googlesource.com/804994 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#521576}
-
Ken MacKay authored
Bug: Change-Id: I0c44d05c6b2c94f849621fb6d9073ad4d1faba62 Reviewed-on: https://chromium-review.googlesource.com/807587Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#521575}
-
Shanmuga Pandi M authored
As per the spec[1], Constructing CSSURLImageValue should throw an error, if the URL is invalid. [1] https://drafts.css-houdini.org/css-typed-om-1/#dom-cssurlimagevalue-cssurlimagevalue Bug: 791434 Change-Id: I06ae5dad378ca91ce827f64ff56498a06c9963af Reviewed-on: https://chromium-review.googlesource.com/805635Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Shanmuga Pandi <shanmuga.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#521574}
-
Theresa Wellington authored
BUG=778736 Change-Id: I44217534a8aba3c07d113b687c4065864d6303c0 Reviewed-on: https://chromium-review.googlesource.com/806978Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#521573}
-
Theresa Wellington authored
Start closing the bottom sheet before clearing URL focus on backpress to prevent "Search or type URL" from temporarily showing while the bottom sheet is closing. BUG=789775 Change-Id: I79bc1013b5dc91cc4ff94a8df86a7df7996b2d69 Reviewed-on: https://chromium-review.googlesource.com/807345Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#521572}
-
Emircan Uysaler authored
This CL adds a fallback for reading canvas content when async callback returns false. It looks like this ReadbackTextureAsync() is not supported for certain Intel CrOS devices, see below bug for more details. Bug: 788386 Change-Id: I691ce745b2703af8dab25b5c703427fe7b9b6f73 Reviewed-on: https://chromium-review.googlesource.com/804831 Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#521571}
-
Zhongyi Shi authored
Bug: 774622 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iebb15655a503c33d674b1a1cb636ea788ffdecde Reviewed-on: https://chromium-review.googlesource.com/803632Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#521570}
-
khmel authored
This fixes the issue when Linux implementation of the assigning app icon for the window does not request image representation and as result icon is not loaded. Bug: 779463 Test: Manually Change-Id: I33ac3733ad1a428c6a448bc3845d2589ff640d09 Reviewed-on: https://chromium-review.googlesource.com/807398Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Elliot Glaysher <erg@chromium.org> Commit-Queue: Yury Khmel <khmel@google.com> Cr-Commit-Position: refs/heads/master@{#521569}
-