GitLab

The very first step to reuse Bork manifests in ResourcePrefetchPredictor. This
CL adds a new table to the predictor database.

BUG=699115

Review-Url: https://codereview.chromium.org/2738613003
Cr-Commit-Position: refs/heads/master@{#455798}

DataFetcherSharedMemoryBase has a thread to which it posts tasks. It
currently stops this thread in its destructor. However, this behavior
is problematic: the tasks call pure virtual methods of
DataFetcherSharedMemoryBase, and stopping the thread ensures that all
pending tasks are run. The combination of these facts mean that code
gets run in the DataFetcherSharedMemoryBase that calls pure virtual
methods of that class, which naturally causes crashes (as the
subclass' vtable has been torn down at that point).

This CL fixes the problem by stopping the thread in
DataFetcherSharedMemoryBase::Shutdown(), at which point the subclass
instance is guaranteed to still be alive.

BUG=699496

Review-Url: https://codereview.chromium.org/2743493003
Cr-Commit-Position: refs/heads/master@{#455797}

BUG=

Review-Url: https://codereview.chromium.org/2740893002
Cr-Commit-Position: refs/heads/master@{#455796}

We are adding COMPONENT/TEAM information into OWNERS file
(ozone, gesture, etc).

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
Component lists
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
R=rjkroege@chromium.org

Review-Url: https://codereview.chromium.org/2741523002
Cr-Commit-Position: refs/heads/master@{#455795}

AshWindowTreeHostX11 stops receiving XEvents when PrepareForShutdown()
is called to ensure it doesn't get any configuration events after Ash
starts tearing down the RootWindowController. Things like the window
size changing after teardown has started ends up crashing Ash.

We need to do something similar, in a platform independent way for
Ozone, when using the Ozone X11 platform. Add
PlatformWindow::PrepareForShutdown() and call it from
AshWindowTreeHostPlatform::PrepareForShutdown().

BUG=664570

Review-Url: https://codereview.chromium.org/2741533002
Cr-Commit-Position: refs/heads/master@{#455794}

This CL increases coverage for HttpRequestCompletionErrorCodes metrics.

TEST = ChromeNetworkDelegateTest

Review-Url: https://codereview.chromium.org/2715393002
Cr-Commit-Position: refs/heads/master@{#455793}

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431

Review-Url: https://codereview.chromium.org/2743743002
Cr-Commit-Position: refs/heads/master@{#455792}

BUG=698994
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2743573002
Cr-Commit-Position: refs/heads/master@{#455791}

NOEXPORT=true

Change-Id: I77d93dbb734848f88ce03c21a57db3ed6fe99588
Reviewed-on: https://chromium-review.googlesource.com/449027Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#455790}

RPCS printers will cause a crash in DocumentProperties on Windows 8 and
above. Detect these printers before calling DocumentProperties and
return invalid settings so that the preview displays an error message.

Change preview area so that "Loading.." does not overwrite the error
message when invalid printer settings are obtained.

BUG=679160
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2741483002
Cr-Commit-Position: refs/heads/master@{#455789}

Convert SetVisuallyDeemphasized to a mojo message while moving its
definition and declaration out of chrome/ code into extensions/ code.

BUG=697613

Review-Url: https://codereview.chromium.org/2724933002
Cr-Commit-Position: refs/heads/master@{#455788}

When virtual time is suspended, suspend all timers from running -- even
if they would be eligible to run given the current virtual time value.
This allows us to deterministically schedule fetch responses w.r.t. all
types of timers tasks regardless of how soon the fetch request is
serviced. The downside is that the throughput of timer work is reduced
depending on the number of fetches performed by a page.

Design doc:
https://docs.google.com/document/d/19s2g4fPP9p9qmMZvwPX8uDGbb-39rgR9k56B4B-ueG8/edit?pli=1#

BUG=696001

Review-Url: https://codereview.chromium.org/2725633002
Cr-Commit-Position: refs/heads/master@{#455787}

CollectionBackingTraceTrait no longer exists, and Visitor only
needs to be friend with WeakMember<>.

R=
BUG=

Review-Url: https://codereview.chromium.org/2745433003
Cr-Commit-Position: refs/heads/master@{#455786}

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2743643002
Cr-Commit-Position: refs/heads/master@{#455785}

BUG=None
NOTRY=true

Review-Url: https://codereview.chromium.org/2742813002
Cr-Commit-Position: refs/heads/master@{#455784}

A recent refactoring dropped a test from the conditional which caused
the Omnibox to paint the scheme text in black in cases where it should
not. Restore the conditional so that the Omnibox only colors the scheme
text in the correct scenarios.

BUG=699222
TEST=Type about:blank in the omnibox and hit enter. "about:" should be
grey and "blank" should be black

Review-Url: https://codereview.chromium.org/2734783007
Cr-Commit-Position: refs/heads/master@{#455783}

This knocks out one of the two major dependencies on crypto/x509 in
//net. With this, SSL_SESSIONs in the session cache no longer retain the
expensive X509* objects. This is especially exciting on non-Android
platforms where net::X509Certificate already did not use X509*. (On
Android, net::X509Certificate still needs to be rewritten and, in
particular, is retained in the certificate verification cache.)

BUG=671420

Review-Url: https://codereview.chromium.org/2728303005
Cr-Commit-Position: refs/heads/master@{#455782}

Previously resize events did not explicitly trigger renders from the
compositor. This went unnoticed because most of the UI existed at
the top of the screen which was largely unaffected by the resize
event. Now, the ToolbarSceneLayer is responsible for requesting
renders when it is at the bottom of the screen.

BUG=698111

Review-Url: https://codereview.chromium.org/2730183002
Cr-Commit-Position: refs/heads/master@{#455781}

BUG=none
R=sdefresne@chromium.org

Review-Url: https://codereview.chromium.org/2735973003
Cr-Commit-Position: refs/heads/master@{#455780}

https://skia.googlesource.com/skia.git/+log/c65aec976196..5395c598dbc3

$ git log c65aec976..5395c598d --date=short --no-merges --format='%ad %ae %s'
2017-03-08 halcanary FuzzCanvas: TextBlob RSXform SkMaskFilter SkPathEffect
2017-03-08 reed make GrPaint.h private -- IWYU
2017-03-09 reed move intermediate patheffect classes inside src

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=djsollen@chromium.org

Change-Id: I475a55e1ddb0449b34908151d04b6c4a738fe9c1
Reviewed-on: https://chromium-review.googlesource.com/451966Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#455779}

The bug seems to have been there since we added DisplayItem::kCaret.
This breaks under-invalidation checking itself only. It won't cause
any visible issue to release builds, except small performance
penalty that the drag caret is always repainted because of no match
in the cache with the wrong id.

BUG=699480

Review-Url: https://codereview.chromium.org/2742693002
Cr-Commit-Position: refs/heads/master@{#455778}

We are adding COMPONENT/TEAM information into OWNERS file
(autofill, etc).

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
Component lists
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
R=estade@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2716753003
Cr-Commit-Position: refs/heads/master@{#455777}

BUG=697971

Review-Url: https://codereview.chromium.org/2738933002
Cr-Commit-Position: refs/heads/master@{#455776}

This adds TLS 1.3 specific metrics for SSL connection errors and
latency and a Google specific metric for SSL connection errors.

BUG=699226

Review-Url: https://codereview.chromium.org/2732103003
Cr-Commit-Position: refs/heads/master@{#455775}

This will begin collecting DOM hierarchy data in upcoming threat reports. The feature was initially just for safety but it's not needed to control the launch of populating the DOM field.

BUG=674618

Review-Url: https://codereview.chromium.org/2731913003
Cr-Commit-Position: refs/heads/master@{#455774}

This test is failing on all downstream iPad versions.

BUG=700001
TBR=gambard

Review-Url: https://codereview.chromium.org/2739943004
Cr-Commit-Position: refs/heads/master@{#455773}

Build: https://build.chromium.org/p/chromium.infra.cron/builders/rebaseline-o-matic/builds/627310

https://chromium.googlesource.com/chromium/src/+/0f9cfc4753603

BUG=699044
TBR=wangxianzhu@chromium.org

Review-Url: https://codereview.chromium.org/2736403004 .
Cr-Commit-Position: refs/heads/master@{#455772}

BUG=699536

Review-Url: https://codereview.chromium.org/2737843004
Cr-Commit-Position: refs/heads/master@{#455771}

This CL makes the following changes:

(1) Make SpdySession use Socket::ReadIfReady(). This new behavior is
    hidden behind a field trial flag, SocketReadIfReady.
(2) Make SpdySession lazily allocate |read_buffer| on demand.
(3) Make SpdySession release |read_buffer| when Read() completes or
    when ReadIfReady() cannot be completed synchronously.

Re-allocating an 8KiB buffer should be cheap, see more discussion
at https://groups.google.com/a/chromium.org/d/msg/project-trim/QtliUsApxyk/AOSnyuY7CgAJ

BUG=690915

Review-Url: https://codereview.chromium.org/2734933002
Cr-Commit-Position: refs/heads/master@{#455770}

Change SVGUseElement to use the observeTarget() helper from
SVGURIReference. Since SVGUseElement has some additional requirements
for its reference management, a more low-level observeTarget() variant
is exposed.
To facilitate this change, clearShadowTree() is renamed to
clearResourceReference(), and the shadow tree tear-down is hoisted out
of it.

BUG=661598

Review-Url: https://codereview.chromium.org/2744613002
Cr-Commit-Position: refs/heads/master@{#455769}

I think this would be nice as documentation, as these classes can be
quite confusing to people outside of content/ experts.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2727263004
Cr-Commit-Position: refs/heads/master@{#455768}

After this is added, Mac10.12 builders will be used when getting new baselines (rebaseline-o-matic and rebaseline-cl), and and will be checked when removing flaky expectations (update-test-expectations).

I believe that https://codereview.chromium.org/2738053002 should be committed first.

BUG=697971

Review-Url: https://codereview.chromium.org/2731403011
Cr-Commit-Position: refs/heads/master@{#455767}

Browser process hit testing was enabled on Android in r455559, along
with the appropriate browser tests. Unfortunately on some builders these
tests fail, due to coordinates being off skewed from expectations. The
tests attempt to account for scale factor rounding error on Android that
does not exist on other platforms, due to differently treatment of DSF,
but apparently the variance can be quite high across devices. We need
to investigate a way to work around this in browser tests.

BUG=700007
TBR=creis@chromium.org

Review-Url: https://codereview.chromium.org/2743733002
Cr-Commit-Position: refs/heads/master@{#455766}

Change SVGFEImageElement to use the observeTarget() helper from
SVGURIReference.
A slight change in behavior for when a load is initiated for a potential
image resource is made. Instead of using a "failed element lookup and a
non-existing id" as the condition, use "failed element lookup and non-
local resource reference".
Also add a new method clearImageResource() and put the tear-down for
the image resource, and change a use of ownerDocument() to just
document().

BUG=661598

Review-Url: https://codereview.chromium.org/2740003003
Cr-Commit-Position: refs/heads/master@{#455765}

It was used to distinguish hang types in the big hang timer in RenderWidgetHostImpl, but that timer is now only used for a single type of hang.

BUG=418266
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2737553003
Cr-Commit-Position: refs/heads/master@{#455764}

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2743723002
Cr-Commit-Position: refs/heads/master@{#455763}

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2742783002
Cr-Commit-Position: refs/heads/master@{#455762}

This utilizes length of scripts and stylesheets recently exposed in the protocolto avoid requesting content in CoverageModel.

Review-Url: https://codereview.chromium.org/2735133004
Cr-Commit-Position: refs/heads/master@{#455761}

Revert of webrtc-internals: dont remove tab (patchset #1 id:1 of https://codereview.chromium.org/2739443002/ )

Reason for revert:
This is breaking some Mac builds
https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests/builds/14781

Original issue's description:
> webrtc-internals: dont remove tab
>
> instead of removing the tab when a peerconnection is garbage collected
> this adds a symbol which removes the tab on click.
>
> BUG=416876
>
> Review-Url: https://codereview.chromium.org/2739443002
> Cr-Commit-Position: refs/heads/master@{#455743}
> Committed: https://chromium.googlesource.com/chromium/src/+/b31e6f5fc2cae4ce8efdb57eb995a0c2e583dd75

TBR=guidou@chromium.org,tommi@chromium.org,philipp.hancke@googlemail.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=416876

Review-Url: https://codereview.chromium.org/2745433004
Cr-Commit-Position: refs/heads/master@{#455760}

This will let us simplify the Mojo code a bit in the future, and it
makes it consistent with all other ResourceHandler methods, which
always use ResourceController for resuming and cancellation, rather
than returning a bool.

No ResourceHandler currently takes advantage of this behavior, though
this CL updates all intermediary ResourceHandlers to support it.

BUG=687240

Review-Url: https://codereview.chromium.org/2668603003
Cr-Commit-Position: refs/heads/master@{#455759}