GitLab

Revert of Call PaintLayer::setNeedsRepaint in LayoutBoxModelObject::invalidateDisplayItemClientOnBacking() (patchset #1 id:1 of https://codereview.chromium.org/1469823004/ )

Reason for revert:
This is incorrect. We missed setNeedsRepaint() of the PaintLayers between the object's enclosingLayer and paintInvalidationContainer's layer.

Original issue's description:
> Call PaintLayer::setNeedsRepaint in LayoutBoxModelObject::invalidateDisplayItemClientOnBacking()
>
> To ensure layer is set needsRepaint().
>
> BUG=536999
> TEST=scrollbars/scrollbar-added-during-drag.html etc with sync painting enabled
>
> Committed: https://crrev.com/4c9d4570c68eddbc58f73b1fb4f4c95614bcf9d3
> Cr-Commit-Position: refs/heads/master@{#361179}

TBR=chrishtr@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=536999

Review URL: https://codereview.chromium.org/1475483003

Cr-Commit-Position: refs/heads/master@{#361379}

|using| directives should not be global, but they should be used on a per-file bases.  Therefore they should not be placed in header files.

Review URL: https://codereview.chromium.org/1458163002

Cr-Commit-Position: refs/heads/master@{#361378}

Check for the isolate-extensions flag as well as --site-per-process.

BUG=532666

Review URL: https://codereview.chromium.org/1469153003

Cr-Commit-Position: refs/heads/master@{#361377}

Also using a no_sanitize list for SANITIZER_HOOK_ATTRIBUTE instead of
separate attributes per tool.

BUG=
R=glider@chromium.org

Review URL: https://codereview.chromium.org/1474733002

Cr-Commit-Position: refs/heads/master@{#361376}

https://pdfium.googlesource.com/pdfium.git/+log/8840ec9..3647692

R=thestig@chromium.org
BUG=555784,558840

Review URL: https://codereview.chromium.org/1466223003

Cr-Commit-Position: refs/heads/master@{#361375}

Re-enable conformance2/textures/misc/tex-storage-compressed-formats.html. This test is now passing.

Suppress const-array-init, tex-image-and-sub-image-3d*,
and floor-div-cos-should-not-truncate failures.

BUG=295792, 560555, angleproject:1179, angleproject:1198
TBR=zmo@chromium.org

Review URL: https://codereview.chromium.org/1471943002

Cr-Commit-Position: refs/heads/master@{#361374}

BUG=295792
NOTRY=true

Review URL: https://codereview.chromium.org/1465993003

Cr-Commit-Position: refs/heads/master@{#361373}

Review URL: https://codereview.chromium.org/1471743002

Cr-Commit-Position: refs/heads/master@{#361372}

As a step along the way to componentizing SecurityStateModel, this CL
introduces a SecurityStateModelClient interface and a
ChromeSecurityStateModelClient implementation. The client has just a
couple methods for now but will expand such that the client will
eventually provide everything from //content and //chrome that the model
needs.

BUG=515071

Review URL: https://codereview.chromium.org/1470813002

Cr-Commit-Position: refs/heads/master@{#361371}

https://chromium.googlesource.com/external/swarming.client.git/+log/05e17879accc..df99a00d96fa

$ git log 05e17879a..df99a00d9 --date=short --no-merges --format='%ad %ae %s'
2015-11-24 maruel Ignore .pyc in client/.

R=tandrii@chromium.org
BUG=chromium:555827

Review URL: https://codereview.chromium.org/1470113003

Cr-Commit-Position: refs/heads/master@{#361370}

That change added gfx_geometry as a dep in .gyp files, but forgot
to do the same for .gn files, which broke the Windows component
builders.  (The Linux component build seems to inline this function,
I guess.)

Due to crbug.com/497970, this breakage went undetected for pretty
long.

BUG=486089,552545
TBR=christhr

Review URL: https://codereview.chromium.org/1471263002 .

Cr-Commit-Position: refs/heads/master@{#361369}

Revert of webgl: use immutable texture for the default FBO. (patchset #2 id:20001 of https://codereview.chromium.org/1449043005/ )

Reason for revert:
following test is broken.
WebglConformance.deqp_functional_gles3_readpixel

Original issue's description:
> webgl: use immutable texture for the default FBO.
>
> Use immutable texture for the default FBO like chromium compositor.
>
> In theory, it speeds up drawing speed, because immutable texture skips texture
> validation on drawing call.
>
> In addition, immutable texture allows GL_INTEL_framebuffer_CMAA more optimization.
>
> BUG=557848
> TEST=
> WebglConformance.conformance_renderbuffers_framebuffer_state_restoration
> WebglConformance.conformance_textures_misc_texture_size_cube_maps
> WebglConformance.conformance_textures_misc_texture_sub_image_cube_maps
> WebglConformance.conformance_textures_webgl_canvas_tex_image_and_sub_image_2d_with_webgl_canvas_rgb_rgb_unsigned_byte
> WebglConformance.conformance_textures_webgl_canvas_tex_image_and_sub_image_2d_with_webgl_canvas_rgb_rgb_unsigned_short_5_6_5
> WebglConformance.conformance_textures_webgl_canvas_tex_image_and_sub_image_2d_with_webgl_canvas_rgba_rgba_unsigned_byte
> WebglConformance.conformance_textures_webgl_canvas_tex_image_and_sub_image_2d_with_webgl_canvas_rgba_rgba_unsigned_short_4_4_4_4
> WebglConformance.conformance_textures_webgl_canvas_tex_image_and_sub_image_2d_with_webgl_canvas_rgba_rgba_unsigned_short_5_5_5_1
>
> Committed: https://crrev.com/fb9d8e245ac84c6c0806e86e7884b4775a84b4b5
> Cr-Commit-Position: refs/heads/master@{#361335}

TBR=kbr@chromium.org,adrian.belgun@intel.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=557848

Review URL: https://codereview.chromium.org/1474763002

Cr-Commit-Position: refs/heads/master@{#361368}

NOTE: This is the second attempt of https://crrev.com/1140723003/

TODO:
1. Edit core/frame/UseCounter.h accordingly.
2. Add UMA metric in OfflineAudioContext.idl.

Adds suspend() and resume() feature in OfflineAudioContext to support the
synchronous graph manipulation with the render block precision (k-rate) in the
non-realtime audio rendering.

The benefit of being able to suspend/resume the context with the render block
precision is:

1) The audio graph can be modified in a time-accurate way, independent of the
   hardware. Without this, setTimeout, completion events, or state change events
   are needed to manipulate the graph, and the results depend on when the events
   are fired and on how fast the hardware is.

2) Makes an OfflineAudioContext more symmetrical to the AudioContext, which
   already supports suspend/resume. (There are minor difference required by the
   difference between offline and online contexts.)

This feature also can be used in Blink layout tests to verify the behavior of
audio rendering. With this feature in the implementation, several flaky web
audio layout tests can be fixed.

http://webaudio.github.io/web-audio-api/#the-offlineaudiocontext-interface

https://github.com/WebAudio/web-audio-api/issues/302#issuecomment-106101885

BUG=497933, 545686
TEST=
webaudio/offlineaudiocontext-suspend-resume-basic.html
webaudio/offlineaudiocontext-suspend-resume-eventhandler.html
webaudio/offlineaudiocontext-suspend-resume-graph-manipulation.html
webaudio/offlineaudiocontext-suspend-resume-promise.html
webaudio/offlineaudiocontext-suspend-resume-sequence.html

Review URL: https://codereview.chromium.org/1405413004

Cr-Commit-Position: refs/heads/master@{#361367}

Necessitated adding a "write_asset_list" arg for creating the
assets_list file.

BUG=547162

Review URL: https://codereview.chromium.org/1435333008

Cr-Commit-Position: refs/heads/master@{#361366}

This includes:
- AssociatedBinding
- AssociatedGroup
- AssociatedInterfacePtr
- AssociatedInterfacePtrInfo
- AssociatedInterfaceRequest

BUG=546067

Review URL: https://codereview.chromium.org/1465293002

Cr-Commit-Position: refs/heads/master@{#361365}

Review URL: https://codereview.chromium.org/1468173007

Cr-Commit-Position: refs/heads/master@{#361364}

Currently code dchecks on the existence of the offline page for a given
bookmark, which might not be the case.
Removing DCHECK and only continuing execution if the offline page exists.

BUG=560518
R=jianli@chromium.org

Review URL: https://codereview.chromium.org/1473043002

Cr-Commit-Position: refs/heads/master@{#361363}

Previously It2Me host was stopped asynchronoulsy, which makes the
shutdown more complicated. Now it's synchronous and is significantly
simpler.
Also removed ChromotingHost::RejectAuthenticatingClient() which is no
longer needed.

Review URL: https://codereview.chromium.org/1458323002

Cr-Commit-Position: refs/heads/master@{#361362}

BUG=559284

Review URL: https://codereview.chromium.org/1469943002

Cr-Commit-Position: refs/heads/master@{#361361}

Also fixes up the GCM error code logging (using the wrong enum that relied on
positive net error codes, while GCM was sending negative)

BUG=556773

Review URL: https://codereview.chromium.org/1471103002

Cr-Commit-Position: refs/heads/master@{#361360}

This is the case for ContentShell.apk

BUG=

Review URL: https://codereview.chromium.org/1469113004

Cr-Commit-Position: refs/heads/master@{#361359}

The pref data_reduction_proxy::prefs::kDataReductionProxy should have
been part of data_reduction_proxy::RegisterPrefs() to avoid having
all embedder register it manually just before call said function.

BUG=557814

Review URL: https://codereview.chromium.org/1463973003

Cr-Commit-Position: refs/heads/master@{#361358}

It's one very trivial function that only has a single call-site. It
doesn't need its own file.

BUG=

Review URL: https://codereview.chromium.org/1474533004

Cr-Commit-Position: refs/heads/master@{#361357}

That way, we don't have to mess with the hidden values in the dtor.

BUG=558975
R=haraken@chromium.org,sigbjornf@opera.com

Review URL: https://codereview.chromium.org/1472823002

Cr-Commit-Position: refs/heads/master@{#361356}

BUG=

Review URL: https://codereview.chromium.org/1468043003

Cr-Commit-Position: refs/heads/master@{#361355}

BUG=528489

Review URL: https://codereview.chromium.org/1468163003

Cr-Commit-Position: refs/heads/master@{#361354}

BUG=

Review URL: https://codereview.chromium.org/1473553002

Cr-Commit-Position: refs/heads/master@{#361353}

Also changed the API for the prefixed version to maintain compatibility between the two.

This is an interop issue, Firefox bubbles the event while Safari does not, but I think we should match Firefox.

See http://www.w3.org/TR/page-visibility/#sec-processing-model

BUG=501821

Review URL: https://codereview.chromium.org/1435893003

Cr-Commit-Position: refs/heads/master@{#361352}

Rename SVGPathTraversalStateBuilder.{cpp,h} to SVGPathQuery.{cpp,h}, and
similarly rename the class itself. Move the query methods in
SVGPathUtilities (getSVGPathSegAtLengthFromSVGPathByteStream,
getTotalLengthOfSVGPathByteStream, getPointAtLengthOfSVGPathByteStream)
to that class, shortening their names in the process.
Open-code the SVGPathParser driver to allow the general SVGPathConsumer
interface to be simplified - incrementPathSegmentCount and
continueConsuming are only used for path queries.

BUG=467592

Review URL: https://codereview.chromium.org/1471943003

Cr-Commit-Position: refs/heads/master@{#361351}

JUnit/Robolectric tests run on the host without native code and so can't
set the application context the usual way. Provide a test-only method to
set only the Java-side context for this purpose.

Move the assertion about not changing the set context to
initApplicationContext because the JUnit tests will use a different
mock context for each test case.

BUG=552419
R=dgn@chromium.org

Review URL: https://codereview.chromium.org/1474723002

Cr-Commit-Position: refs/heads/master@{#361350}

The early return after PostTaskAndReply() in
GLSurfaceOzoneSurfaceless::SwapBuffersAsync was erroneously removed in
f960a950 ("Split up synchronous & asynchronous swap buffers APIs").  This
adds it back.

It also removes the else after return; that's against the style guide.

BUG=560553
TEST=boot chrome on veyron_jerry

Review URL: https://codereview.chromium.org/1475683002

Cr-Commit-Position: refs/heads/master@{#361349}

Add repeat_delay_ms and repeat_count as configurable parameters to the infinit scrolling benchmarks.

Twitter gets stuck most of the time when we scroll continuously. Non-continuous scrolling fixes the issue.

BUG=

Review URL: https://codereview.chromium.org/1471233002

Cr-Commit-Position: refs/heads/master@{#361348}

This reverts commit 587e7058
(crrev.com/1447213002)

Reason for the revert:
broke all Android perf bots. More context in crbug.com/560813.
This CL is causing a null pointer deref in the browser whenever
a renderer kill is detected:

Thread 0 (crashed)
 0  libchrome_public.so!breakpad::CrashDumpManager::Observe [crash_dump_manager_android.cc : 194 + 0x0]

    Found by: given as instruction pointer in context
 1  libchrome_public.so!content::NotificationServiceImpl::Notify [notification_service_impl.cc : 123 + 0xd]

    Found by: call frame info
 2  libchrome_public.so!content::RenderProcessHostImpl::Cleanup [render_process_host_impl.cc : 1790 + 0x1]

    Found by: call frame info
 3  libchrome_public.so!content::RenderWidgetHostImpl::~RenderWidgetHostImpl [render_widget_host_impl.cc : 257 + 0x9]

    Found by: call frame info
 4  libchrome_public.so!content::RenderViewHostImpl::~RenderViewHostImpl [render_view_host_impl.cc : 266 + 0x5]

    Found by: call frame info
 5  libchrome_public.so!content::RenderViewHostImpl::~RenderViewHostImpl [render_view_host_impl.cc : 277 + 0x3]

    Found by: call frame info
 6  libchrome_public.so!content::RenderWidgetHostImpl::Destroy [render_widget_host_impl.cc : 1465 + 0x7]

    Found by: call frame info

BUG=560813,510327
NOTRY=TRUE
TBR=skyostil@chromium.org,yfriedman@chromium.org,wnwen@chromium.org

Review URL: https://codereview.chromium.org/1474543003

Cr-Commit-Position: refs/heads/master@{#361347}

BUG=

Review URL: https://codereview.chromium.org/1471253002

Cr-Commit-Position: refs/heads/master@{#361346}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b787e6bc..0164a63f

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1469803005

Cr-Commit-Position: refs/heads/master@{#361345}

Also remove a few Windows newlines :-/

BUG=560836
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/1470093004 .

Cr-Commit-Position: refs/heads/master@{#361344}

* Now targets all devices by default rather than failing
* Allows --device flag to target a specific device

BUG=

Review URL: https://codereview.chromium.org/1469143002

Cr-Commit-Position: refs/heads/master@{#361343}

https://url.spec.whatwg.org/#api

This changes the generated code, but ought not be observable, as any
call to `new URL(x, urlObject)` will now instead behaves as
`new URL(x, urlObject.toString())`.

BUG=460722

Review URL: https://codereview.chromium.org/1464133002

Cr-Commit-Position: refs/heads/master@{#361342}

BUG=557430

Review URL: https://codereview.chromium.org/1438863002

Cr-Commit-Position: refs/heads/master@{#361341}

BUG=560836
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/1466423006 .

Cr-Commit-Position: refs/heads/master@{#361340}